journald: do not store the iovec entry for process commandline on stack

This fixes a crash where we would read the commandline, whose length is under
control of the sending program, and then crash when trying to create a stack
allocation for it.

CVE-2018-16864
https://bugzilla.redhat.com/show_bug.cgi?id=1653855

The message actually doesn't get written to disk, because
journal_file_append_entry() returns -E2BIG.

(cherry picked from commit 084eeb865ca63887098e0945fb4e93c852b91b0f)
(cherry picked from commit cf56627fe5525132c8e09eb3e77bfc0556a2f04d)

Gbp-Pq: Name journald-do-not-store-the-iovec-entry-for-process-command.patch

journald: remove unnecessary {}

(cherry picked from commit bc2762a309132a34db1797d8b5792d5747a94484)
(cherry picked from commit ccbb69e14ea9938c20ced03b4952fee0d22684b0)

Gbp-Pq: Name journald-remove-unnecessary.patch

coredump: remove duplicate MESSAGE= prefix from message

systemd-coredump[9982]: MESSAGE=Process 771 (systemd-journal) of user 0 dumped core.
systemd-coredump[9982]: Coredump diverted to /var/lib/systemd/coredump/core...

log_dispatch() calls log_dispatch_internal() which calls write_to_journal()
which appends MESSAGE= on its own.

(cherry picked from commit 4f62556d71206ac814a020a954b397d4940e14c3)
(cherry picked from commit 9f564b3f45008c1a178a186f944ddc7485614cd2)

Gbp-Pq: Name coredump-remove-duplicate-MESSAGE-prefix-from-message.patch

core/mount: make mount_setup_existing_unit() not drop MOUNT_PROC_JUST_MOUNTED flag from units

This fixes a bug introduced by ec88d1ea0591beccab97d9096fd3fd7b09bc823c.

Fixes #11362.

(cherry picked from commit d253a45e1c147f5174265d71d7419da7bd52a88b)
(cherry picked from commit 27492fe33697c88b5452602604b0b28771bfd39f)

Gbp-Pq: Name core-mount-make-mount_setup_existing_unit-not-drop-MOUNT_.patch

udev-node: make link_find_prioritized() return negative value when nothing found

Fixes a bug introduced by a2554acec652fc65c8ed0c6c1fede9ba8c3693b1.

Fixes RHBZ#1662303.

(cherry picked from commit 82d9ac23fd5ab2befe2a95187640a8d38799dd64)
(cherry picked from commit f665fe3e2e74548a2a236f3b7635227621aa568a)

Gbp-Pq: Name udev-node-make-link_find_prioritized-return-negative-valu.patch

json: handle NULL explicitly in json_variant_has_type()

(cherry picked from commit f8c186c9ece5c1c0b89abf52f058efb0ed37e0cb)
(cherry picked from commit 388e534d24cac041bd00b48f27a84d6b31089c67)

Gbp-Pq: Name json-handle-NULL-explicitly-in-json_variant_has_type.patch

udev: rework how we handle the return value from spawned programs

When running PROGRAM="...", we would log
systemd-udevd[447]: Failed to wait spawned command '...': Input/output error
no matter why the program actually failed, at error level.

The code wouldn't distinguish between an internal failure and a failure in the
program being called and run sd_event_exit(..., -EIO) on any kind of error. EIO
is rather misleading here, becuase it suggests a serious error.

on_spawn_sigchld is updated to set the return code to distinguish failure to
spawn, including the program being killed by a signal (a negative return value),
and the program failing (positive return value).

The logging levels are adjusted, so that for PROGRAM= calls, which are
essentially "if" statements, we only log at debug level (unless we get a
timeout or segfault or another unexpected error).

(cherry picked from commit a75211421fc9366068e6d9446e8e567246c72feb)
(cherry picked from commit 5862f1730af205e2b95349b477aeed25b2f3e3b8)

Gbp-Pq: Name udev-rework-how-we-handle-the-return-value-from-spawned-p.patch

Revert "pam_systemd: drop setting DBUS_SESSION_BUS_ADDRESS"

This reverts commit 2b2b7228bffef626fe8e9f131095995f3d50ee3b.

Fixes #11293.

Removing the environment variable causes problems, e.g. Xfce and Chromium and
... don't communicate with the running dbus instance. If they attempt to start their
own instance, things become even more confusing. Those packages could be fixed
one by one, but removing the variable right now is causing too many problems.

(cherry picked from commit 00efd4988b8e4a147f96337de32e54925640f0b7)
(cherry picked from commit 6c44e6c681e55f8291078b51c72cbfd81cc21a94)

Gbp-Pq: Name Revert-pam_systemd-drop-setting-DBUS_SESSION_BUS_ADDRESS.patch

journal: rely on _cleanup_free_ to free a temporary string used in client_context_read_cgroup

Closes https://github.com/systemd/systemd/issues/11253.

(cherry picked from commit ef30f7cac18a810814ada7e6a68a31d48cc9fccd)
(cherry picked from commit 1789a12dbf74112992a478ac4cf2f13d8c286d15)

Gbp-Pq: Name journal-rely-on-_cleanup_free_-to-free-a-temporary-string.patch

test: add test for sending/receiving an invalid device

(cherry picked from commit 4fe0caadc85431118f2d8aea7570307cfc2aed27)
(cherry picked from commit c2a11194c33de9bc7545a7c4df3fda5b90f02a50)

Gbp-Pq: Name test-add-test-for-sending-receiving-an-invalid-device.patch

Revert "udevd: configure a child process name for worker processes"

This reverts commit 49f3ee7e74c714f55aab395c080b1099fc17f7fd.

(cherry picked from commit ff86c92e3043f71fc801cf687600a480ee8f6778)
(cherry picked from commit 77421020c9ab36c1e701901d7e72747ca98d3133)

Gbp-Pq: Name Revert-udevd-configure-a-child-process-name-for-worker-pr.patch

Revert "sd-device: ignore bind/unbind events for now"

This reverts commit 56c886dc7ed5b2bb0882ba85136f4070545bfc1b.

Fixes #11277 and #11299.

(cherry picked from commit b261494128e60dd3168e0ea961606ec4f39c5739)
(cherry picked from commit ff2145bfe5aac524c5870a295293b8e3cc74e27a)

Gbp-Pq: Name Revert-sd-device-ignore-bind-unbind-events-for-now.patch

sd-device: fix segfault when error occurs in device_new_from_{nulstr,strv}()

As devpath may not be set yet.

When debug logging is enabled, log_device_*() calls
sd_device_get_sysname(). So, we should not assume that devpath is always
set.

Fixes #11258.

(cherry picked from commit 18fee12a2d489378a2a9b647db0d0eb8c43f5362)
(cherry picked from commit 9ae73a6273461361eef7e83d48aadee111d6616e)

Gbp-Pq: Name sd-device-fix-segfault-when-error-occurs-in-device_new_fr.patch

libudev-util: make util_replace_whitespace() read only len characters

This effectively reverts df8ba4fa0e8be1ff7899d08a4b6be0196c8405a0.

Fixes #11264.

(cherry picked from commit 577ab71c58d36bc8577d15f172a306c9c05cd2f4)
(cherry picked from commit c3712308fc090116e388f395e4a8bb0bd8446ea6)

Gbp-Pq: Name libudev-util-make-util_replace_whitespace-read-only-len-c.patch

Pass separate dev_t var to device_path_parse_major_minor

MIPS/O32's st_rdev member of struct stat is unsigned long, which
is 32bit, while dev_t is defined as 64bit, which make some problems
in device_path_parse_major_minor.

Don't pass st.st_rdev, st_mode to device_path_parse_major_minor,
while pass 2 seperate variables. The result of stat is alos copied
out into these 2 variables. Fixes: #11247

(cherry picked from commit f5855697aa19fb92637e72ab02e4623abe77f288)
(cherry picked from commit a0d4edf0e7fe6674c44258a73e0722494d659976)

Gbp-Pq: Name Pass-separate-dev_t-var-to-device_path_parse_major_minor.patch

test-json: check absolute and relative difference in floating point test

The test fails under valgrind, so there was an exception for valgrind.
Unfortunately that check only works when valgrind-devel headers are
available during build. But it is possible to have just valgrind installed,
or simply install it after the build, and then "valgrind test-json" would
fail.

It also seems that even without valgrind, this fails on some arm32 CPUs.
Let's do the usual-style test for absolute and relative differences.

(cherry picked from commit aa70783f55b369521b94e0985e84bbdaae16b174)
(cherry picked from commit 88938bf95b850849d075d7a6ebe37bb1d9780efe)

Gbp-Pq: Name test-json-check-absolute-and-relative-difference-in-float.patch

Docs: Add Missing Space Between Words

(cherry picked from commit 8d7fac92f07cc662e51dcda7c9f3a322454895c7)
(cherry picked from commit e60c80a908a2c8c6036e41d083134c9e095aa268)

Gbp-Pq: Name Docs-Add-Missing-Space-Between-Words.patch

ask-password-api: do not call ask_password_keyring() if keyname == NULL

Fixes #11295.

(cherry picked from commit 1f00998c8739ac6adc2b7623cc1e5a8f67d95d7d)
(cherry picked from commit 095a38313daf043413c863634378c8ea7e5f6a09)

Gbp-Pq: Name ask-password-api-do-not-call-ask_password_keyring-if-keyn.patch

udev-event: do not read stdout or stderr if the pipefd is not created

Fixes #11255.

(cherry picked from commit adeb26c1affd09138bb96a9e25b795d146e64c97)
(cherry picked from commit 32a11a27b69031240beea38260d93e034ea33036)

Gbp-Pq: Name udev-event-do-not-read-stdout-or-stderr-if-the-pipefd-is-.patch

switch-root: fix error message

Fixes #11261.

(cherry picked from commit a5c67ccc575e6ebf12710cb7df84f65a51c5dc58)
(cherry picked from commit ebcd154e1df434865d2752efdccbc7737bb28029)

Gbp-Pq: Name switch-root-fix-error-message.patch

core: free lines after reading them

Closes https://github.com/systemd/systemd/issues/11251.

(cherry picked from commit 7334ade4a7e103b1a01d1c8fe1ea7c7a854a1c31)
(cherry picked from commit 5fa79ab2eb900fc58824060e3dcf9508276c9047)

Gbp-Pq: Name core-free-lines-after-reading-them.patch

Do not start server if it is already runnning (#11245)

(cherry picked from commit 7da7340afdd4760fb2dd9d000105c324a77aff4b)

Gbp-Pq: Name Do-not-start-server-if-it-is-already-runnning-11245.patch

systemd (240-4) unstable; urgency=medium

  [ Benjamin Drung ]
  * Fix shellcheck issues in initramfs-tools scripts

  [ Michael Biebl ]
  * Import patches from v240-stable branch (up to f02b5472c6)
    - Fixes a problem in logind closing the controlling terminal when using
      startx. (Closes: #918927)
    - Fixes various journald vulnerabilities via attacker controlled alloca.
      (CVE-2018-16864, CVE-2018-16865, Closes: #918841, Closes: #918848)
  * sd-device-monitor: Fix ordering of setting buffer size.
    Fixes an issue with uevents not being processed properly during coldplug
    stage and some kernel modules not being loaded via "udevadm trigger".
    (Closes: #917607)
  * meson: Stop setting -fPIE globally.
    Setting -fPIE globally can lead to miscompilations on certain
    architectures. Instead use the b_pie=true build option, which was
    introduced in meson 0.49. Bump the Build-Depends accordingly.
    (Closes: #909396)

[dgit import unpatched systemd 240-4]

Import systemd_240-4.debian.tar.xz

[dgit import tarball systemd 240-4 systemd_240-4.debian.tar.xz]

Import systemd_240.orig.tar.gz

[dgit import orig systemd_240.orig.tar.gz]