Matthias Clasen [Wed, 29 Dec 2021 14:58:53 +0000 (14:58 +0000)]
Merge branch 'wip/chergert/4575-fix-texthistory-selection' into 'main'
testsuite: ignore texthistory selection on delete/backspace
Closes #4575
See merge request GNOME/gtk!4287
Matthias Clasen [Wed, 29 Dec 2021 14:38:28 +0000 (14:38 +0000)]
Merge branch 'wip/exalm/inspector' into 'main'
inspector: Register extension on startup
See merge request GNOME/gtk!4296
Matthias Clasen [Wed, 29 Dec 2021 14:34:26 +0000 (14:34 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
tests: Make fontchooser test build on macOS
See merge request GNOME/gtk!4300
Matthias Clasen [Wed, 29 Dec 2021 14:15:26 +0000 (09:15 -0500)]
tests: Make fontchooser test build on macOS
Not sure what changed here, but we want to
be able to build this without fontconfig too.
Matthias Clasen [Wed, 29 Dec 2021 00:28:09 +0000 (00:28 +0000)]
Merge branch 'nullable' into 'main'
popover: Add missing nullable annotation
Closes #4556
See merge request GNOME/gtk!4295
Matthias Clasen [Wed, 29 Dec 2021 00:24:46 +0000 (00:24 +0000)]
Merge branch 'wip/baedert/for-master' into 'main'
application demo: Resolve a keyboard shortcut conflict
See merge request GNOME/gtk!4290
Alexander Mikhaylenko [Tue, 28 Dec 2021 23:14:03 +0000 (04:14 +0500)]
inspector: Register extension on startup
Alexander Mikhaylenko [Tue, 28 Dec 2021 23:12:16 +0000 (04:12 +0500)]
Revert "inspector: Export gtk_inspector_init"
This reverts commit
3f5107cea56edb6c339345b2432a1a481f7f3dd1.
Ian Douglas Scott [Tue, 28 Dec 2021 17:43:06 +0000 (09:43 -0800)]
popover: Add missing nullable annotation
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/4556.
Looks like the other `Popover` methods are have correct nullable
annotations.
Hugo Carvalho [Mon, 27 Dec 2021 22:53:20 +0000 (22:53 +0000)]
Update Portuguese translation
Matthias Clasen [Mon, 27 Dec 2021 15:08:48 +0000 (15:08 +0000)]
Merge branch 'm-shinder-master-patch-90567' into 'main'
gdk_content_provider_get_value() argument should have 'out' direction
See merge request GNOME/gtk!4283
Matthias Clasen [Mon, 27 Dec 2021 15:06:56 +0000 (15:06 +0000)]
Merge branch 'get-key-capture-widget-nullable' into 'main'
GtkSearchBar - Mark get_key_capture_widget() return value as nullable
See merge request GNOME/gtk!4286
Yuri Chornoivan [Mon, 27 Dec 2021 14:08:03 +0000 (14:08 +0000)]
Update Ukrainian translation
Benjamin Otte [Mon, 27 Dec 2021 13:54:27 +0000 (13:54 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
inspector: Add dnd inspection support
See merge request GNOME/gtk!4289
Timm Bäder [Mon, 27 Dec 2021 09:00:30 +0000 (10:00 +0100)]
applicationwindow: Don't pass for_size < -1 to measure()
If the application window is measured with for_size -1 horizontally,
this code clearly passes something lower to the parent class measure()
implementation. Only subtract the menubar_height if we're passed a
for_size > -1.
Timm Bäder [Mon, 27 Dec 2021 08:59:19 +0000 (09:59 +0100)]
application demo: Resolve a keyboard shortcut conflict
There were two menu entries side-by-side with the same keyboard shortcut
Benjamin Otte [Mon, 27 Dec 2021 04:57:05 +0000 (05:57 +0100)]
inspector: Add dnd inspection support
This has lots of issues:
* It randomly crashes when data is loading while the dnd goes away.
* The data gets randomly reset at the wrong time
* Can't scroll the window on Wayland
* ...
But it's better than nothing, so better get it committed.
Benjamin Otte [Sun, 26 Dec 2021 23:20:34 +0000 (23:20 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
widget: Don't queue an allocate on a nonexisting parent
See merge request GNOME/gtk!4288
Benjamin Otte [Sun, 26 Dec 2021 21:58:09 +0000 (22:58 +0100)]
css: Don't crash on invalid rotate3d()
m-shinder [Sun, 26 Dec 2021 21:20:33 +0000 (21:20 +0000)]
Merge branch 'main' into 'm-shinder-master-patch-90567'
# Conflicts:
# NEWS
Benjamin Otte [Sun, 26 Dec 2021 21:17:54 +0000 (22:17 +0100)]
widget: Don't queue an allocate on a nonexisting parent
No test, no idea how to trigger this reliably.
Christian Hergert [Sun, 26 Dec 2021 20:56:42 +0000 (12:56 -0800)]
textview: scroll insert onscreen after undo/redo
After performing an action such as undo/redo, we need to actually scroll
to the position where the operation occurred.
I do note that the scroll here seems to often get invalidated if it is
pages away, and we never make the full scroll. But I've seen this all over
the place elsewhere too and that needs to be handled, most likely, as a
more comprehensive fix for scrolling during line validation.
Related #4575
Christian Hergert [Sun, 26 Dec 2021 20:47:45 +0000 (12:47 -0800)]
texthistory: always track selection bounds
It's cheap to store the selection position, so always set it even if we
are in a user section. Otherwise, we risk not having the right position
when starting a delete action within a begin_user_action(),
end_user_action() pair.
Related #4575
Christian Hergert [Sun, 26 Dec 2021 20:46:16 +0000 (12:46 -0800)]
testsuite: add failing test for delete selection
This adds a test to expose the failure of #4575 which results in the
selection being incorrect when performing a delete as we are likely
already in a begin_user_action()/end_user_action() pair.
Related #4575
Christian Hergert [Sun, 26 Dec 2021 20:43:22 +0000 (12:43 -0800)]
testsuite: ignore texthistory selection on delete/backspace
We don't need to apply these here, as it will clear the selection which is
needed for the undo. Otherwise we won't be able to test that we end up at
the right selection afterwards.
Sebastian Dröge [Sun, 26 Dec 2021 09:03:25 +0000 (11:03 +0200)]
GtkSearchBar - Mark get_key_capture_widget() return value as nullable
The setter allows setting NULL so this can clearly also return NULL
under normal circumstances.
Same for the corresponding API in GtkSearchEntry.
Emmanuele Bassi [Sat, 25 Dec 2021 17:26:06 +0000 (17:26 +0000)]
Merge branch 'ebassi/build-fixes' into 'main'
build: Replace source_root()
See merge request GNOME/gtk!4281
Benjamin Otte [Sat, 25 Dec 2021 15:34:01 +0000 (15:34 +0000)]
Merge branch 'wip/otte/gles' into 'main'
Fix GLES
Closes #4571
See merge request GNOME/gtk!4285
Benjamin Otte [Sat, 25 Dec 2021 14:06:12 +0000 (15:06 +0100)]
gles: Be picky abpout glGetFramebufferAttachmentParameter()
This function does not at all work like in OpenGL - if it works at all.
So make it behave accordingly.
Fixes #4571
Benjamin Otte [Sat, 25 Dec 2021 13:46:07 +0000 (14:46 +0100)]
gles: glGetTexLevelParameter() isn't supported
Benjamin Otte [Sat, 25 Dec 2021 13:43:33 +0000 (14:43 +0100)]
gles: GLES 2 doesn't have glDrawBuffers()
So don't call it.
Benjamin Otte [Sat, 25 Dec 2021 13:14:52 +0000 (14:14 +0100)]
gl: Change gdk_gl_context_check_version()
Instead of just passing major/minor, pass them twice, once for GL and
once for GLES. This way, we don't need to check for GL and GLES
separately.
If something is supported unconditionally, passing 0/0 works fine.
That said, I'd like to group the arguments somehow, because otherwise
it's just a confusing list of numbers - but I have no idea how to do
that.
Benjamin Otte [Sat, 25 Dec 2021 13:41:20 +0000 (14:41 +0100)]
glcontext: Use different log levels for GL debug
We want critical GL debug messages to be critical, so that the testsuite
sudokus itself when they appear.
This is relevant in particular for GLES warnings in the GLES runner,
because its warnings can cause crashes on GL drivers less forgiving than
Mesa.
Related: #4571
Emmanuele Bassi [Sat, 25 Dec 2021 13:29:07 +0000 (13:29 +0000)]
Apply 1 suggestion(s) to 1 file(s)
m-shinder [Sat, 25 Dec 2021 10:04:43 +0000 (10:04 +0000)]
Fix: Set direction for `value` parameter
Emmanuele Bassi [Fri, 24 Dec 2021 15:55:26 +0000 (15:55 +0000)]
build: Remove deprecated get_pkgconfig_variable()
Replace it with `get_variable(pkgconfig:...)`.
Emmanuele Bassi [Fri, 24 Dec 2021 15:51:11 +0000 (15:51 +0000)]
build: Replace deprecated 'gui_app'
Use `win_subsystem: 'windows'` instead.
Emmanuele Bassi [Fri, 24 Dec 2021 15:48:06 +0000 (15:48 +0000)]
build: Replace source_root()
Use project_source_root(), which replaces the deprecated source_root().
Matthias Clasen [Thu, 23 Dec 2021 21:59:26 +0000 (16:59 -0500)]
sizerequest: Remove critical warning for now
At last as long as widgets like GtkFlowBox and
GtkGrid still trigger this, it is not a great
idea to have this warning in a stable release.
So remove it for 4.6
Benjamin Otte [Wed, 22 Dec 2021 19:45:53 +0000 (19:45 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
gl: Clear current when destroying current's surface
Closes #4554
See merge request GNOME/gtk!4279
Benjamin Otte [Wed, 22 Dec 2021 18:49:13 +0000 (19:49 +0100)]
gl: Clear current when destroying current's surface
When destroying the EGLSurface or GLXDrawable of a GdkSurface, make sure
the current context is not still bound to it.
If it is, clear the current context.
Fixes #4554
Matthias Clasen [Wed, 22 Dec 2021 16:54:18 +0000 (16:54 +0000)]
Merge branch 'wip/baedert/for-master' into 'main'
label: Fix get_natural_wrap_mode() precondition check
See merge request GNOME/gtk!4278
Timm Bäder [Wed, 22 Dec 2021 16:38:05 +0000 (17:38 +0100)]
label: Fix get_natural_wrap_mode() precondition check
Hugo Carvalho [Wed, 22 Dec 2021 14:05:50 +0000 (14:05 +0000)]
Update Portuguese translation
Yuri Chornoivan [Wed, 22 Dec 2021 12:52:52 +0000 (12:52 +0000)]
Update Ukrainian translation
Timm Bäder [Wed, 22 Dec 2021 08:08:38 +0000 (08:08 +0000)]
Merge branch 'fix_typos' into 'main'
Fix minor typo
See merge request GNOME/gtk!4275
Yuri Chornoivan [Tue, 21 Dec 2021 21:42:12 +0000 (23:42 +0200)]
Fix minor typo
Yuri Chornoivan [Tue, 21 Dec 2021 21:36:53 +0000 (21:36 +0000)]
Update Ukrainian translation
Matthias Clasen [Tue, 21 Dec 2021 19:20:34 +0000 (19:20 +0000)]
Merge branch 'high-contrast-4' into 'main'
gdk/wayland: Support new `high-contrast` key
See merge request GNOME/gtk!4271
Matthias Clasen [Tue, 21 Dec 2021 18:22:53 +0000 (18:22 +0000)]
Merge branch 'discrete-scroll' into 'main'
Don't keep discrete scroll events in the queue
See merge request GNOME/gtk!4274
Florian Müllner [Mon, 20 Dec 2021 18:10:35 +0000 (19:10 +0100)]
gdk/wayland: Support new `high-contrast` key
We now have a boolean setting that determines whether the high-contrast
theme should be used. Support it by automatically setting the existing
`gtk-theme-name` and `gtk-icon-theme-name` properties when enabled.
With that, it is no longer necessary to change the regular theme settings
for high-contrast, so toggling between high-contrast and a non-default
theme finally works reliably.
Matthias Clasen [Mon, 20 Dec 2021 19:51:37 +0000 (14:51 -0500)]
Don't keep discrete scroll events in the queue
We are not going to compress those anyway.
Matthias Clasen [Mon, 20 Dec 2021 19:08:59 +0000 (19:08 +0000)]
Merge branch 'testsuite-introspection-extend-envvars' into 'main'
testsuite: introspection: Do not override environment variables.
See merge request GNOME/gtk!4268
Benjamin Otte [Mon, 20 Dec 2021 19:01:52 +0000 (19:01 +0000)]
Merge branch 'wip/otte/diff' into 'main'
Make render node diffing not slow
Closes #4560 and #2396
See merge request GNOME/gtk!4269
Benjamin Otte [Mon, 20 Dec 2021 17:40:02 +0000 (18:40 +0100)]
rendernode: Limit diff region
Limit the diff region to 30 rectangles (randomly chosen because it
looked big enough to not trigger by accident and small enough to not
cause performance issues).
If the diff region gets more complicated, we abort to the parent node
and use its bounds as the diff region instead and then continue diffing
the rest of the node tree.
Fixes: #4560
Fixes: #2396
Maxim Cournoyer [Mon, 20 Dec 2021 04:19:50 +0000 (23:19 -0500)]
testsuite: introspection: Do not override environment variables.
Functional package managers such as GNU Guix rely on environment
variables such as GI_TYPELIB_PATH to discover the system libraries and
resources; extend rather than override them.
* testsuite/introspection/meson.build (env): New variable that extends
rather than override the GI_TYPELIB_PATH and LD_PRELOAD environment
variables.
(api): Use the above as the value of the 'env' keyword argument.
Benjamin Otte [Mon, 20 Dec 2021 15:50:55 +0000 (16:50 +0100)]
gsk: Allow diffing code to abort
Now the vfuncs can decide they don't want to diff anymore, not just the
actual diff function.
Hugo Carvalho [Mon, 20 Dec 2021 16:07:31 +0000 (16:07 +0000)]
Update Portuguese translation
Matthias Clasen [Mon, 20 Dec 2021 15:49:05 +0000 (15:49 +0000)]
Merge branch 'wip/otte/wrapping-is-natural' into 'main'
label: Add gtk_label_set_natural_wrap_mode()
See merge request GNOME/gtk!4267
Matthias Clasen [Mon, 20 Dec 2021 15:45:36 +0000 (15:45 +0000)]
Merge branch 'progressbar-queue-allocate' into 'main'
progressbar: Queue allocate when setting "inverted"
See merge request GNOME/gtk!4264
Matthias Clasen [Mon, 20 Dec 2021 15:41:51 +0000 (15:41 +0000)]
Merge branch 'ebassi/find-gi' into 'main'
build: Check for the gi python module
See merge request GNOME/gtk!4266
Fran Dieguez [Mon, 20 Dec 2021 08:50:36 +0000 (08:50 +0000)]
Update Galician translation
Benjamin Otte [Sun, 19 Dec 2021 18:22:31 +0000 (19:22 +0100)]
label: Add gtk_label_set_natural_wrap_mode()
Allows influencing natural size requests so that labels can request more
width than necessary for a given height.
Related: !4245
Related: #4535
Emmanuele Bassi [Sun, 19 Dec 2021 16:26:37 +0000 (16:26 +0000)]
ci: Add pygobject to the MSYS2 job
Emmanuele Bassi [Sun, 19 Dec 2021 16:06:49 +0000 (16:06 +0000)]
build: Check for the gi python module
The introspection tests depend on the pygobject module, but we currently
are not checking if it's available at configuration time, which means we
can get build failures like:
> ModuleNotFoundError: No module named 'gi'
when running the test suite.
Marco Melorio [Sat, 18 Dec 2021 17:45:28 +0000 (18:45 +0100)]
progressbar: Queue allocate when setting "inverted"
Piotr Drąg [Sat, 18 Dec 2021 12:36:19 +0000 (13:36 +0100)]
Update POTFILES.skip
Yuri Chornoivan [Sat, 18 Dec 2021 06:29:43 +0000 (06:29 +0000)]
Update Ukrainian translation
Matthias Clasen [Fri, 17 Dec 2021 12:58:01 +0000 (12:58 +0000)]
Merge branch 'meson-msvc-cleanup' into 'main'
Remove Visual Studio 2013 bits from Meson files
See merge request GNOME/gtk!4249
Hugo Carvalho [Fri, 17 Dec 2021 12:41:33 +0000 (12:41 +0000)]
Update Portuguese translation
Matthias Clasen [Fri, 17 Dec 2021 02:43:20 +0000 (21:43 -0500)]
4.5.1
Matthias Clasen [Fri, 17 Dec 2021 02:11:50 +0000 (02:11 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
label: word-char wrapping should word-wrap for natural size
Closes #4535
See merge request GNOME/gtk!4245
Matthias Clasen [Fri, 17 Dec 2021 02:00:47 +0000 (21:00 -0500)]
NEWS: Updates
Matthias Clasen [Fri, 17 Dec 2021 00:35:18 +0000 (00:35 +0000)]
Merge branch 'toolbar-combobox' into 'main'
Don't make all buttons in toolbars flat
Closes #4384
See merge request GNOME/gtk!4103
Matthias Clasen [Fri, 17 Dec 2021 00:32:08 +0000 (00:32 +0000)]
Merge branch 'main' into 'main'
docs: Mention GtkImage and GtkPicture changes
Closes #4415
See merge request GNOME/gtk!4251
Jakub Kulík [Fri, 17 Dec 2021 00:32:08 +0000 (00:32 +0000)]
docs: Mention GtkImage and GtkPicture changes
Matthias Clasen [Fri, 17 Dec 2021 00:31:20 +0000 (00:31 +0000)]
Merge branch 'wip/baedert/for-master' into 'main'
settings test: Print expected and seen values
See merge request GNOME/gtk!4259
Benjamin Otte [Thu, 16 Dec 2021 21:46:52 +0000 (21:46 +0000)]
Merge branch 'wip/otte/inspector' into 'main'
inspector: Add measure graph
See merge request GNOME/gtk!4260
Benjamin Otte [Thu, 16 Dec 2021 17:05:31 +0000 (18:05 +0100)]
inspector: Add measure graph
Generates a graph visualizing calls to gtk_widget_measure().
Generation of the graph can be slow - like when it forces Pango to wrap
a huge label 1000s of times.
You can dnd the graph to look at it closer or to impress people in
gitlab issues.
Benjamin Otte [Thu, 16 Dec 2021 17:14:06 +0000 (18:14 +0100)]
inspector: Remove a stray g_print()
Benjamin Otte [Mon, 13 Dec 2021 17:23:32 +0000 (18:23 +0100)]
label: Fix docs
Hugo Carvalho [Thu, 16 Dec 2021 15:48:11 +0000 (15:48 +0000)]
Update Portuguese translation
Luca Bacci [Thu, 16 Dec 2021 14:58:03 +0000 (14:58 +0000)]
Merge branch 'fix-3728-3799' into 'main'
GDK-Win32: Force toplevel surfaces to configure as needed (fix issues #3728 and #3799)
Closes #3728 and #3799
See merge request GNOME/gtk!3712
Timm Bäder [Thu, 16 Dec 2021 10:04:37 +0000 (11:04 +0100)]
gskglcommandqueue: Mark some variables G_GNUC_UNUSED
These are unused if sysprof isn't being used.
Timm Bäder [Tue, 14 Dec 2021 10:41:01 +0000 (11:41 +0100)]
textlayout: Remove unused-but-set variables
Timm Bäder [Mon, 13 Dec 2021 14:26:00 +0000 (15:26 +0100)]
settings test: Print expected and seen values
That test breaks locally (and in CI it seems?), so at least print the
values we see.
Matthias Clasen [Thu, 16 Dec 2021 04:34:01 +0000 (04:34 +0000)]
Merge branch 'event-recorder' into 'main'
inspector: Add axes to event details in recorder
See merge request GNOME/gtk!4258
Matthias Clasen [Thu, 16 Dec 2021 02:56:53 +0000 (21:56 -0500)]
inspector: Highlight event sequences
Optionally, highlight rows of events whose
event sequences match the selected event.
Matthias Clasen [Thu, 16 Dec 2021 01:33:03 +0000 (20:33 -0500)]
wayland: Add sequences for touchpad gestures
It makes sense.
Matthias Clasen [Thu, 16 Dec 2021 01:11:51 +0000 (20:11 -0500)]
gdk: Prepare touchpad events for sequences
It makes sense to connect the begin/update/end events
for touchpad swipes and pinches in a sequence. This
commit adds the plumbing for it, but not backends
are setting sequences yet.
Matthias Clasen [Thu, 16 Dec 2021 00:20:00 +0000 (19:20 -0500)]
inspector: Details about touchpad events
Useful to have for debugging these.
Matthias Clasen [Wed, 15 Dec 2021 23:05:14 +0000 (18:05 -0500)]
inspector: Add axes to event details in recorder
This is useful information if you have devices
producing such events.
Matthias Clasen [Wed, 15 Dec 2021 22:29:32 +0000 (17:29 -0500)]
docs: Add some information about event axes
Sveinn í Felli [Wed, 15 Dec 2021 19:44:49 +0000 (19:44 +0000)]
Update Icelandic translation
Sveinn í Felli [Wed, 15 Dec 2021 18:37:57 +0000 (18:37 +0000)]
Update Icelandic translation
Matthias Clasen [Wed, 15 Dec 2021 05:51:28 +0000 (05:51 +0000)]
Merge branch 'event-recorder' into 'main'
inspector: Tweaks to the recorder
See merge request GNOME/gtk!4256
Matthias Clasen [Wed, 15 Dec 2021 05:24:05 +0000 (00:24 -0500)]
Fix event history
Collecting of history wasn't working correctly
for either motion or scroll events.
Matthias Clasen [Wed, 15 Dec 2021 04:43:29 +0000 (23:43 -0500)]
inspector: Show event history in recorder
This was instrumental in debugging why
scroll compression does not work.
Matthias Clasen [Wed, 15 Dec 2021 04:42:14 +0000 (23:42 -0500)]
Cosmetrics: Remove mention of a nonexisting type
No such thing as GdkScrollHistory.
Matthias Clasen [Wed, 15 Dec 2021 03:03:52 +0000 (22:03 -0500)]
inspector: Remove debug spew