Simon McVittie [Tue, 3 Jan 2023 12:45:21 +0000 (12:45 +0000)]
Make fast forward from 4.8.2+ds-4
[dgit --quilt=unapplied]
Simon McVittie [Fri, 3 Sep 2021 14:08:08 +0000 (15:08 +0100)]
Disable clipboard test
This regularly times out on buildds, but I can't reproduce the hang
locally.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/4229
Forwarded: no
Gbp-Pq: Topic debian
Gbp-Pq: Name Disable-clipboard-test.patch
Simon McVittie [Fri, 12 Aug 2022 09:44:17 +0000 (10:44 +0100)]
Disable inscription-markup.ui reftest
It's rendered 1px to the left of where it should be, which is not a
serious problem for practical use of GTK, but is a test failure.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5099
Forwarded: not-needed, workaround
Gbp-Pq: Topic debian
Gbp-Pq: Name Disable-inscription-markup.ui-reftest.patch
Simon McVittie [Sat, 13 Feb 2021 16:19:10 +0000 (16:19 +0000)]
reftests: Allow minor differences to be tolerated
Based on an earlier patch by Michael Biebl, as used in Debian's GTK 3
packaging, with additional inspiration from librsvg's reftests.
Each .ui or .node reftest can have an accompanying .keyfile file
like this:
[reftest]
tolerated-diff-level=20
tolerated-diff-pixels=1000
If the image differs, but the number of pixels that differ is no more
than tolerated-diff-pixels and the differences are no more than
tolerated-diff-level, then we treat it as a success with warnings, save
the .diff.png for analysis, and use g_test_incomplete() to record the
test-case as "TODO".
Signed-off-by: Simon McVittie <smcv@debian.org>
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3195
Applied-upstream: no, upstream want reftests to be a strict pass/fail with identical results required
Gbp-Pq: Topic debian
Gbp-Pq: Name reftests-Allow-minor-differences-to-be-tolerated.patch
Simon McVittie [Sat, 13 Feb 2021 18:26:24 +0000 (18:26 +0000)]
reftest_compare_surfaces: Report how much the images differ
In unattended/non-interactive/autobuilder environments where the images
are not trivially accessible, this provides a way to distinguish between
totally different rendering and more subtle issues.
Signed-off-by: Simon McVittie <smcv@debian.org>
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3195
Applied-upstream: no, upstream want reftests to be a strict pass/fail with identical results required
Gbp-Pq: Topic debian
Gbp-Pq: Name reftest_compare_surfaces-Report-how-much-the-images-diffe.patch
Simon McVittie [Tue, 6 Dec 2022 11:13:59 +0000 (11:13 +0000)]
node-editor: Save test data relative to current working directory
This avoids hard-coding the GTK source directory into the binary, which
would make the binary non-reproducible across different source paths,
particularly in a distro build environment where the source directory
used by autobuilders will often not exist on end-user systems. The node
editor can still be used to create new test-cases by running it with the
GTK source directory as its current working directory.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5403
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5297
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name node-editor-Save-test-data-relative-to-current-working-di.patch
Simon McVittie [Wed, 23 Nov 2022 21:26:50 +0000 (21:26 +0000)]
testsuite: Don't create .test files for flaky or failing tests
These tests can be run manually, but are not suitable for use as an
acceptance test, so let's not make frameworks like Debian's autopkgtest
run these when they run ginsttest-runner in the most obvious way.
Signed-off-by: Simon McVittie <smcv@debian.org>
Applied-upstream: 4.9.2, commit:
94b57a967c492ab18df8142557710ba0b1a02cee
Gbp-Pq: Name testsuite-Don-t-create-.test-files-for-flaky-or-failing-t.patch
Simon McVittie [Wed, 23 Nov 2022 19:13:32 +0000 (19:13 +0000)]
testsuite: Use separate setups for unstable tests instead of should_fail
There are two possible interpretations of "expected failure": either
the test *must* fail (exactly the inverse of an ordinary test, with
success becoming failure and failure becoming success), or the test
*may* fail (with success intended, but failure possible in some
environments). Autotools had the second interpretation, which seems
more useful in practice, but Meson has the first.
Instead of using should_fail, we can put the tests in one of two new
suites: "flaky" is intended for tests that succeed or fail unpredictably
according to the test environment or chance, while "failing" is for
tests that ought to succeed but currently never do as a result of a
bug or missing functionality. With a sufficiently new version of Meson,
the flaky and failing tests are not run by default, but can be requested
by running a setup that does not exclude them, with a command like:
meson test --setup=x11_unstable --suite=flaky --suite=failing
As a bonus, now that we're setting up setups and their excluded suites
programmatically, the gsk-compare-broadway tests are also excluded by
default when running the test setup for a non-broadway backend.
When running the tests in CI, --suite=gtk overrides the default
exclude_suites, so we have to specify --no-suite=flaky and
--no-suite=failing explicitly.
This arrangement is inspired by GNOME/glib!2987, which was contributed
by Marco Trevisan.
Signed-off-by: Simon McVittie <smcv@debian.org>
Applied-upstream: 4.9.2, commit:
957dd49ef7d371926f90212bdf52b92742062e3e
Gbp-Pq: Name testsuite-Use-separate-setups-for-unstable-tests-instead-.patch
Simon McVittie [Tue, 3 Jan 2023 12:45:39 +0000 (12:45 +0000)]
Release to unstable
Simon McVittie [Tue, 3 Jan 2023 12:42:25 +0000 (12:42 +0000)]
d/copyright: Add details of run-with-display script
Simon McVittie [Tue, 3 Jan 2023 12:42:12 +0000 (12:42 +0000)]
d/copyright: Move standalone license stanzas to the end
Simon McVittie [Tue, 3 Jan 2023 12:37:13 +0000 (12:37 +0000)]
d/tests/build: Avoid PWD bashism
Simon McVittie [Tue, 3 Jan 2023 12:26:48 +0000 (12:26 +0000)]
d/tests/build: Suppress D-Bus/a11y warnings
Simon McVittie [Tue, 3 Jan 2023 12:25:21 +0000 (12:25 +0000)]
d/tests/python3-gi: Explicitly disable a11y
This version of GTK logs a warning (which makes the autopkgtest fail)
if we cannot contact the a11y bus provided by AT-SPI.
Simon McVittie [Tue, 3 Jan 2023 12:24:45 +0000 (12:24 +0000)]
d/tests: Quote more defensively
Simon McVittie [Tue, 3 Jan 2023 10:22:42 +0000 (10:22 +0000)]
d/run-tests.sh: Use dh_auto_test
In particular this forces the C.UTF-8 locale, which should mean the tests
pass even when run under a non-UTF-8 locale like C (which official Debian
buildds do not do, but some other environments like reproducible-builds
might).
Closes: #1027680
Simon McVittie [Tue, 3 Jan 2023 11:15:07 +0000 (11:15 +0000)]
d/tests/run-with-display: Use absolute path to WAYLAND_DISPLAY socket
This means we can still use the Wayland display, even when dh_auto_test
changes our XDG_RUNTIME_DIR.
Simon McVittie [Tue, 3 Jan 2023 09:47:52 +0000 (09:47 +0000)]
Update changelog
Simon McVittie [Tue, 3 Jan 2023 09:45:58 +0000 (09:45 +0000)]
Drop patches that were applied upstream
Simon McVittie [Tue, 3 Jan 2023 09:40:49 +0000 (09:40 +0000)]
New upstream release
Simon McVittie [Tue, 3 Jan 2023 09:40:49 +0000 (09:40 +0000)]
Update upstream source from tag 'upstream/4.8.3+ds'
Update to upstream version '4.8.3+ds'
with Debian dir
6122bb6b29c3012752f6dedab6935025ff82eee1
Simon McVittie [Tue, 3 Jan 2023 09:40:21 +0000 (09:40 +0000)]
New upstream version 4.8.3+ds
Matthias Clasen [Thu, 22 Dec 2022 18:35:11 +0000 (13:35 -0500)]
4.8.3
Matthias Clasen [Thu, 22 Dec 2022 18:41:22 +0000 (18:41 +0000)]
Merge branch 'cherry-pick-
acd7d739' into 'gtk-4-8'
[4.8] GdkWin32: Fix resizes with native decorations
See merge request GNOME/gtk!5368
Luca Bacci [Fri, 7 Oct 2022 16:15:29 +0000 (18:15 +0200)]
GdkWin32: Fix resizes with native decorations
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/5142
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/5088
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/5090
Matthias Clasen [Wed, 21 Dec 2022 07:30:05 +0000 (07:30 +0000)]
Merge branch 'hicolor-backport' into 'gtk-4-8'
Merge branch 'include-hicolor-index-theme-as-resource-rebased' into 'main'
See merge request GNOME/gtk!5364
Matthias Clasen [Tue, 20 Dec 2022 02:18:16 +0000 (21:18 -0500)]
tests: Maybe skip introspection tests
If we don't find the python gi module,
skip the introspection test.
Luca Bacci [Tue, 20 Dec 2022 16:08:11 +0000 (16:08 +0000)]
Merge branch 'include-hicolor-index-theme-as-resource-rebased' into 'main'
Include hicolor index.theme as a resource (rebased)
Closes #5303
See merge request GNOME/gtk!5361
Benjamin Otte [Wed, 21 Dec 2022 02:41:07 +0000 (02:41 +0000)]
Merge branch 'cherry-pick-
ae097d96' into 'gtk-4-8'
listbase: Cancel rubberband if not handling drag
See merge request GNOME/gtk!5363
Benjamin Otte [Wed, 21 Dec 2022 01:14:57 +0000 (01:14 +0000)]
Merge branch 'wip/antoniof/listbase-rubberband-better-fix' into 'main'
listbase: Cancel rubberband if not handling drag
See merge request GNOME/gtk!4831
(cherry picked from commit
ae097d9674177ea4d91d67c170f27fda8b337a1d)
efbd2289 listbase: Cancel rubberband if not handling drag
Aleksandr Melman [Tue, 20 Dec 2022 09:21:34 +0000 (09:21 +0000)]
Update Russian translation
Matthias Clasen [Thu, 15 Dec 2022 17:10:33 +0000 (17:10 +0000)]
Merge branch 'cherry-pick-
1f001a8f' into 'gtk-4-8'
Merge branch 'wip/corey/listbase-focus' into 'main'
See merge request GNOME/gtk!5338
Matthias Clasen [Thu, 15 Dec 2022 16:27:57 +0000 (16:27 +0000)]
Merge branch 'cherry-pick-
e8f70be2' into 'gtk-4-8'
Merge branch 'wip/otte/for-5422' into 'main'
See merge request GNOME/gtk!5331
Benjamin Otte [Wed, 14 Dec 2022 19:06:57 +0000 (19:06 +0000)]
Merge branch 'wip/corey/listbase-focus' into 'main'
listbase: Use set_focus_child properly
Closes #5433 and #5432
See merge request GNOME/gtk!5169
(cherry picked from commit
1f001a8f6af1c761d8b47e9f5eb0e8936d77d92a)
7081bfc6 listbase: Split scroll_to_item for reuse
93e591fd listbase: Use set_focus_child properly
Matthias Clasen [Thu, 15 Dec 2022 00:25:25 +0000 (00:25 +0000)]
Merge branch 'x11-fixes-backports-4-8' into 'gtk-4-8'
Assorted x11 fix backports
See merge request GNOME/gtk!5333
Matthias Clasen [Thu, 15 Dec 2022 00:24:54 +0000 (00:24 +0000)]
Merge branch 'update-ci-image-4-8' into 'gtk-4-8'
text: Prevent unexpected notify::direction emissions
See merge request GNOME/gtk!5334
Matthias Clasen [Wed, 14 Dec 2022 20:09:04 +0000 (15:09 -0500)]
Getting desperate
Matthias Clasen [Wed, 14 Dec 2022 19:02:53 +0000 (14:02 -0500)]
ci: Another fixup
Matthias Clasen [Wed, 14 Dec 2022 18:12:55 +0000 (13:12 -0500)]
ci: Add /home/user/.local/bin to PATH
Matthias Clasen [Wed, 14 Dec 2022 17:42:58 +0000 (12:42 -0500)]
Install meson 0.64 in ci jobs
Matthias Clasen [Wed, 14 Dec 2022 16:36:53 +0000 (11:36 -0500)]
ci: Try to defeat the caching
Drop subprojects/glib from the caching, since it
fails to update.
Emmanuele Bassi [Sat, 26 Nov 2022 14:56:10 +0000 (14:56 +0000)]
vulkan: Add missing enumeration
Check for VK_ERROR_COMPRESSION_EXHAUSTED_EXT.
Matthias Clasen [Sun, 27 Nov 2022 02:53:33 +0000 (21:53 -0500)]
Don't emit ::notify from a getter
GdkX11Keymap ddetermines the direction of the
keymap on demand, and was emitting notify::direction
Matthias Clasen [Thu, 6 Oct 2022 00:14:09 +0000 (20:14 -0400)]
mountoperation: Add a mnemonic to a button
This is a good practice, even if this is a rarely
used dialog.
Matthias Clasen [Wed, 5 Oct 2022 01:24:16 +0000 (21:24 -0400)]
mountoperation: Don't use a treeview
Port the process list from GtkTreeView
to GtkListView, and fix a number of broken
things along the way.
Matthias Clasen [Wed, 5 Oct 2022 01:25:26 +0000 (21:25 -0400)]
testmountoperation: Test process dialog
Without this, it is hard to trigger the
dialog. Event with this, we have to force
GtkMountOperation to use its own dialog.
Matthias Clasen [Wed, 5 Oct 2022 00:15:43 +0000 (20:15 -0400)]
mountoperation: Survive on Wayland
The code was assuming it is dealing with an
X11 display, and trigger assertions. Fix that
to make it work at least as well as it does
on Windows.
Matthias Clasen [Fri, 25 Nov 2022 12:59:35 +0000 (07:59 -0500)]
text: Prevent unexpected notify::direction emissions
Calling gdk_device_get_direction can trigger a
notify::direction emissions, since the X11 backend
determines the direction on demand. Prevent that by
forcing the direction to be determined ahead of time.
Fixes: #5311
Carlos Garnacho [Wed, 7 Dec 2022 12:16:36 +0000 (13:16 +0100)]
gdk/x11: Clear all data in GdkSurfaceX11 finalization
Currently, the GdkSurfaceX11 implementation relies that the upper
layers hid the surface before destruction, and that no
GdkSurfaceClass.compute_resize happened between them. If these
circumstances happened, there would be a compute_size timeout left
dangling after the surface got destroyed, poking at incorrect data
later on. Something that looks like this was reported in the
recent mutter-x11-frames "SSD frames server":
mutter-x11-frames:423016): GLib-GObject-WARNING **: 19:41:16.869: invalid unclassed pointer in cast to 'GtkWindow'
Thread 1 "mutter-x11-fram" received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=0x7ffff7f7c4f8 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, format=<optimized out>, args=<optimized out>) at ../../../glib/gmessages.c:1433
1433 ../../../glib/gmessages.c: No such file or directory.
(gdb) bt
#0 g_logv (log_domain=0x7ffff7f7c4f8 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, format=<optimized out>, args=<optimized out>) at ../../../glib/gmessages.c:1433
#1 0x00007ffff73470ff in g_log (log_domain=log_domain@entry=0x7ffff7f7c4f8 "GLib-GObject", log_level=log_level@entry=G_LOG_LEVEL_WARNING, format=format@entry=0x7ffff7f84da8 "invalid unclassed pointer in cast to '%s'")
at ../../../glib/gmessages.c:1471
#2 0x00007ffff7f72892 in g_type_check_instance_cast (type_instance=type_instance@entry=0x5555558e04b0, iface_type=<optimized out>) at ../../../gobject/gtype.c:4144
#3 0x00007ffff791e77d in toplevel_compute_size (toplevel=<optimized out>, size=0x7fffffffe170, widget=0x5555558e04b0) at ../../../gtk/gtkwindow.c:4227
#4 0x00007ffff7f4f3b0 in g_closure_invoke (closure=0x555555898cc0, return_value=return_value@entry=0x0, n_param_values=2, param_values=param_values@entry=0x7fffffffdeb0, invocation_hint=invocation_hint@entry=0x7fffffffde30)
at ../../../gobject/gclosure.c:832
#5 0x00007ffff7f62076 in signal_emit_unlocked_R
(node=node@entry=0x55555588feb0, detail=detail@entry=0, instance=instance@entry=0x55555560e990, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7fffffffdeb0)
at ../../../gobject/gsignal.c:3796
#6 0x00007ffff7f68bf5 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7fffffffe050) at ../../../gobject/gsignal.c:3549
#7 0x00007ffff7f68dbf in <emit signal ??? on instance 0x55555560e990 [GdkX11Toplevel]> (instance=<optimized out>, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3606
#8 0x00007ffff7a8de96 in gdk_toplevel_notify_compute_size (toplevel=<optimized out>, size=size@entry=0x7fffffffe170) at ../../../gdk/gdktoplevel.c:112
#9 0x00007ffff7a4b15a in compute_toplevel_size (surface=surface@entry=0x55555560e990 [GdkX11Toplevel], update_geometry=update_geometry@entry=1, width=width@entry=0x7fffffffe220, height=height@entry=0x7fffffffe224)
at ../../../gdk/x11/gdksurface-x11.c:281
#10 0x00007ffff7a4c3b2 in compute_size_idle (user_data=0x55555560e990) at ../../../gdk/x11/gdksurface-x11.c:356
#11 0x00007ffff733f67f in g_main_dispatch (context=0x55555563f6e0) at ../../../glib/gmain.c:3444
#12 g_main_context_dispatch (context=context@entry=0x55555563f6e0) at ../../../glib/gmain.c:4162
#13 0x00007ffff733fa38 in g_main_context_iterate (context=0x55555563f6e0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4238
#14 0x00007ffff733fcef in g_main_loop_run (loop=loop@entry=0x5555560874a0) at ../../../glib/gmain.c:4438
#15 0x0000555555557de0 in main (argc=<optimized out>, argv=<optimized out>) at ../src/frames/main.c:68
It perhaps makes sense to warn in these situations, but either way
it sounds like gdk_surface_x11_finalize() could enforce the correct
behavior by ensuring there is no dangling timeouts/data. This commit
does that.
Matthias Clasen [Sun, 27 Nov 2022 02:53:33 +0000 (21:53 -0500)]
Don't emit ::notify from a getter
GdkX11Keymap ddetermines the direction of the
keymap on demand, and was emitting notify::direction
Danial Behzadi [Wed, 14 Dec 2022 12:33:15 +0000 (12:33 +0000)]
Update Persian translation
Matthias Clasen [Thu, 6 Oct 2022 00:14:09 +0000 (20:14 -0400)]
mountoperation: Add a mnemonic to a button
This is a good practice, even if this is a rarely
used dialog.
Matthias Clasen [Wed, 5 Oct 2022 01:24:16 +0000 (21:24 -0400)]
mountoperation: Don't use a treeview
Port the process list from GtkTreeView
to GtkListView, and fix a number of broken
things along the way.
Matthias Clasen [Wed, 5 Oct 2022 01:25:26 +0000 (21:25 -0400)]
testmountoperation: Test process dialog
Without this, it is hard to trigger the
dialog. Event with this, we have to force
GtkMountOperation to use its own dialog.
Matthias Clasen [Wed, 5 Oct 2022 00:15:43 +0000 (20:15 -0400)]
mountoperation: Survive on Wayland
The code was assuming it is dealing with an
X11 display, and trigger assertions. Fix that
to make it work at least as well as it does
on Windows.
Corey Berla [Wed, 14 Dec 2022 01:56:04 +0000 (01:56 +0000)]
Merge branch 'wip/otte/for-5422' into 'main'
contentserializer: Serialize to file:// if possible
Closes #5422
See merge request GNOME/gtk!5330
(cherry picked from commit
e8f70be2c1c0532666941db9049cdb7307633e13)
ea056d26 contentserializer: Serialize to file:// if possible
Matthias Clasen [Fri, 25 Nov 2022 12:59:35 +0000 (07:59 -0500)]
text: Prevent unexpected notify::direction emissions
Calling gdk_device_get_direction can trigger a
notify::direction emissions, since the X11 backend
determines the direction on demand. Prevent that by
forcing the direction to be determined ahead of time.
Fixes: #5311
Matthias Clasen [Fri, 9 Dec 2022 21:26:30 +0000 (21:26 +0000)]
Merge branch 'wip/corey/cherrypick-from-main' into 'gtk-4-8'
Cherrypick into 4.8
See merge request GNOME/gtk!5312
Olga Smirnova [Fri, 9 Dec 2022 20:36:05 +0000 (20:36 +0000)]
Add Interlingue translation
Corey Berla [Tue, 29 Nov 2022 00:34:12 +0000 (16:34 -0800)]
atspicontext: Log more helpful warnings when the a11y bus doesn't exist
Corey Berla [Tue, 29 Nov 2022 00:32:52 +0000 (16:32 -0800)]
atspicontext: Cache empty atspi bus address
We are caching the bus address as data on the display object when it
exists, but fail to set the data when the bus address doesn't exist.
That causing excessive calls to GetAddress when the accesssbility
bus doesn't exist. Make sure to cache a non-existent accessibility
bus by setting the "" string.
Corey Berla [Sun, 27 Nov 2022 22:12:36 +0000 (14:12 -0800)]
atspicontext: Log failure to connect to a11y
GTK depends on the a11y infrastructure to be in place unless GTK_A11Y is
set to none. It appears that despite that, users attempt to
get around the a11y requirement without setting GTK_A11Y.
This can cause, amongst other issues, performance problems
with gtk applications. Log failure to connect to the a11y
bus.
Simon McVittie [Tue, 6 Dec 2022 11:52:39 +0000 (11:52 +0000)]
Release to unstable
Simon McVittie [Tue, 6 Dec 2022 11:52:29 +0000 (11:52 +0000)]
Make fast forward from 4.8.2+ds-3
[dgit --quilt=unapplied]
Simon McVittie [Fri, 3 Sep 2021 14:08:08 +0000 (15:08 +0100)]
Disable clipboard test
This regularly times out on buildds, but I can't reproduce the hang
locally.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/4229
Forwarded: no
Gbp-Pq: Topic debian
Gbp-Pq: Name Disable-clipboard-test.patch
Simon McVittie [Fri, 12 Aug 2022 09:44:17 +0000 (10:44 +0100)]
Disable inscription-markup.ui reftest
It's rendered 1px to the left of where it should be, which is not a
serious problem for practical use of GTK, but is a test failure.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5099
Forwarded: not-needed, workaround
Gbp-Pq: Topic debian
Gbp-Pq: Name Disable-inscription-markup.ui-reftest.patch
Simon McVittie [Sat, 13 Feb 2021 16:19:10 +0000 (16:19 +0000)]
reftests: Allow minor differences to be tolerated
Based on an earlier patch by Michael Biebl, as used in Debian's GTK 3
packaging, with additional inspiration from librsvg's reftests.
Each .ui or .node reftest can have an accompanying .keyfile file
like this:
[reftest]
tolerated-diff-level=20
tolerated-diff-pixels=1000
If the image differs, but the number of pixels that differ is no more
than tolerated-diff-pixels and the differences are no more than
tolerated-diff-level, then we treat it as a success with warnings, save
the .diff.png for analysis, and use g_test_incomplete() to record the
test-case as "TODO".
Signed-off-by: Simon McVittie <smcv@debian.org>
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3195
Applied-upstream: no, upstream want reftests to be a strict pass/fail with identical results required
Gbp-Pq: Topic debian
Gbp-Pq: Name reftests-Allow-minor-differences-to-be-tolerated.patch
Simon McVittie [Sat, 13 Feb 2021 18:26:24 +0000 (18:26 +0000)]
reftest_compare_surfaces: Report how much the images differ
In unattended/non-interactive/autobuilder environments where the images
are not trivially accessible, this provides a way to distinguish between
totally different rendering and more subtle issues.
Signed-off-by: Simon McVittie <smcv@debian.org>
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3195
Applied-upstream: no, upstream want reftests to be a strict pass/fail with identical results required
Gbp-Pq: Topic debian
Gbp-Pq: Name reftest_compare_surfaces-Report-how-much-the-images-diffe.patch
Simon McVittie [Tue, 6 Dec 2022 11:13:59 +0000 (11:13 +0000)]
node-editor: Save test data relative to current working directory
This avoids hard-coding the GTK source directory into the binary, which
would make the binary non-reproducible across different source paths,
particularly in a distro build environment where the source directory
used by autobuilders will often not exist on end-user systems. The node
editor can still be used to create new test-cases by running it with the
GTK source directory as its current working directory.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5403
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5297
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name node-editor-Save-test-data-relative-to-current-working-di.patch
Simon McVittie [Wed, 23 Nov 2022 21:26:50 +0000 (21:26 +0000)]
testsuite: Don't create .test files for flaky or failing tests
These tests can be run manually, but are not suitable for use as an
acceptance test, so let's not make frameworks like Debian's autopkgtest
run these when they run ginsttest-runner in the most obvious way.
Signed-off-by: Simon McVittie <smcv@debian.org>
Applied-upstream: 4.9.2, commit:
94b57a967c492ab18df8142557710ba0b1a02cee
Gbp-Pq: Name testsuite-Don-t-create-.test-files-for-flaky-or-failing-t.patch
Simon McVittie [Wed, 23 Nov 2022 19:13:32 +0000 (19:13 +0000)]
testsuite: Use separate setups for unstable tests instead of should_fail
There are two possible interpretations of "expected failure": either
the test *must* fail (exactly the inverse of an ordinary test, with
success becoming failure and failure becoming success), or the test
*may* fail (with success intended, but failure possible in some
environments). Autotools had the second interpretation, which seems
more useful in practice, but Meson has the first.
Instead of using should_fail, we can put the tests in one of two new
suites: "flaky" is intended for tests that succeed or fail unpredictably
according to the test environment or chance, while "failing" is for
tests that ought to succeed but currently never do as a result of a
bug or missing functionality. With a sufficiently new version of Meson,
the flaky and failing tests are not run by default, but can be requested
by running a setup that does not exclude them, with a command like:
meson test --setup=x11_unstable --suite=flaky --suite=failing
As a bonus, now that we're setting up setups and their excluded suites
programmatically, the gsk-compare-broadway tests are also excluded by
default when running the test setup for a non-broadway backend.
When running the tests in CI, --suite=gtk overrides the default
exclude_suites, so we have to specify --no-suite=flaky and
--no-suite=failing explicitly.
This arrangement is inspired by GNOME/glib!2987, which was contributed
by Marco Trevisan.
Signed-off-by: Simon McVittie <smcv@debian.org>
Applied-upstream: 4.9.2, commit:
957dd49ef7d371926f90212bdf52b92742062e3e
Gbp-Pq: Name testsuite-Use-separate-setups-for-unstable-tests-instead-.patch
Asier Sarasua Garmendia [Sat, 3 Dec 2022 09:45:52 +0000 (09:45 +0000)]
Update Basque translation
Origin: upstream, 4.8.3, commit:
5186430d9d8b020c5546fdf11e5f051a05efe6f9
Gbp-Pq: Name Update-Basque-translation.patch
Benjamin Otte [Fri, 2 Dec 2022 15:32:22 +0000 (15:32 +0000)]
GLX: Add extra glXMakeContextCurrent () call to work around a DRI issue
Closes #4499, #5387, and #5170
See merge request GNOME/gtk!5285
(cherry picked from commit
a9c9678e1f617755368f16424a03ae1f2d2ced4e)
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/4499
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5170
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5387
Origin: upstream, 4.8.3, commit:
b17ccd13e6ecc401bf9108d84ec089a62aae67c0
Gbp-Pq: Name GLX-Add-extra-glXMakeContextCurrent-call-to-work-around-a.patch
Nart Tlisha [Fri, 2 Dec 2022 10:13:21 +0000 (10:13 +0000)]
Update Abkhazian translation
Origin: upstream, 4.8.3, commit:
b061d413e45ee5a0a243a87b05b07a9a8dfcef49
Gbp-Pq: Name Update-Abkhazian-translation-1.patch
Carlos Garnacho [Fri, 18 Nov 2022 14:02:22 +0000 (15:02 +0100)]
gdksurface: Do not consider GDK_TOUCH_END/CANCEL as popup-dismiss worthy
GDK_TOUCH_END deserves the same treatment than GDK_BUTTON_RELEASE, since it's
subject to the same circumstances (popping up a menu on long press would be
immediately dismissed on release if we handled them there). Ideally, we would
want to match releases that we obtained a press for while grabbed, but as
the popup is also dismissed on GDK_BUTTON_PRESS/GDK_TOUCH_BEGIN, there's no
use for this tracking.
And GDK_TOUCH_CANCEL sounds weird as a reason to dismiss popups, just like
crossing events would.
(cherry-picked from commit
2ff4c77c5500110e2b387a8764ab19a92045ff4e)
Related: https://gitlab.gnome.org/GNOME/mutter/-/issues/2512
Origin: upstream, 4.8.3, commit:
cc5ba83ebae31b20d8ac53fe1a32685b252a100d
Gbp-Pq: Name gdksurface-Do-not-consider-GDK_TOUCH_END-CANCEL-as-popup-.patch
Carlos Garnacho [Fri, 18 Nov 2022 12:57:02 +0000 (13:57 +0100)]
gtktext: Claim gesture more selectively
Even though button 1 (or touch down) presses do most often have
an effect in one way or another (starting drag, moving focus,
starting selection, ...), there is one situation that they do
immediately nothing: When clicking on the entry does not move
the text caret around. Dragging might start a selection, but
the entry did not do anything just yet, and an immediate
button/touch release should remain at "did nothing".
And that is precisely the hint that the Wayland IM context's click
gesture takes, clicks that do not scroll nor move the caret around,
having the GtkText not claim the gesture in that situation makes
the IM gesture able to do its thing without in-fighting.
This is typically not a problem when the GtkText is embedded in
another GtkEditable implementation (e.g. GtkEntry), since the
IM gesture is inactive and capturing from the parent widget, so
gets a pass that it otherwise doesn't get when both gestures are
in the same widget. This makes it work regardless of GtkText not
being a child of a composite widget, like NautilusQueryEditor
and AdwRowEntry.
(cherry-picked from commit
09b982f0264e42bda3e8471bb25abec5ee742ecc)
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5351
Origin: upstream, 4.8.3, commit:
3b940b12f64c78346cbea8a2fafde24690ecd9fe
Gbp-Pq: Name gtktext-Claim-gesture-more-selectively.patch
Carlos Garnacho [Wed, 19 Oct 2022 10:46:09 +0000 (12:46 +0200)]
gdk/wayland: Use serial of the latest implicit grab available
When getting the serial for primary/clipboard selections we used a
function that largely relied on a GdkEvent being passed. We have
another available function that looks up the most recent serial
given the ongoing touch/tablet input as well.
This is the second best, compared to actually knowing the
input/device from the event that was received by the UI an triggered
the clipboard operation, and is already in use in other places
(e.g. window dragging). It is valid for these situations too.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5250
Origin: upstream, 4.8.3, commit:
873c304a9460ab30c4acf8e922605412cbededf8
Gbp-Pq: Name gdk-wayland-Use-serial-of-the-latest-implicit-grab-availa.patch
Colin Kinloch [Mon, 7 Nov 2022 11:08:18 +0000 (11:08 +0000)]
wayland: calculate union of geometry of all monitors for toplevel bounds
Signed-off-by: Colin Kinloch <colin.kinloch@collabora.com>
Origin: upstream, 4.8.3, commit:
e551a9d1c4cbd66be04a1c45af172e7b5872f99c
Gbp-Pq: Name wayland-calculate-union-of-geometry-of-all-monitors-for-t.patch
Adam Williamson [Wed, 2 Nov 2022 00:26:29 +0000 (17:26 -0700)]
focus: fall back to old behaviour if we didn't focus anything
8455b9ac74 seems to have introduced a problem where we can wind
up focusing no widget at all if the `while (parent)` loop doesn't
find a widget it can successfully move the focus to. This 'fixes'
that by falling back to doing the previous thing if we make it
all the way through that loop without moving the focus. Thanks to
@coreyberla for a hint to improve the implementation.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Origin: upstream, 4.8.3, commit:
824ff01eee3080672dd9c77005faca959f33a037
Gbp-Pq: Name focus-fall-back-to-old-behaviour-if-we-didn-t-focus-anyth.patch
Carlos Garnacho [Wed, 2 Nov 2022 16:11:10 +0000 (17:11 +0100)]
gdk/wayland: Fix button mask calculation on button events
There's 2 things broken here:
- The mask was calculated on top of the GDK button (i.e. skipping
4-7 buttons), so GDK_BUTTON4_MASK and GDK_BUTTON5_MASK were not
assigned. This is now calculated on the (continuous) BTN_ evcodes
so it is guaranteed that the next 2 physical buttons (i.e.
back/forward) get these two places in the mask assigned.
- Furthermore, these buttons would be pushed to places in the
modifier mask that they didn't belong to. It is now checked hard
that only the first 5 buttons enable a modifier flag.
Overall, this ensures that no event masks with bonkers values are
forwarded, and that no stale implicit grabs are left after additional
buttons are pressed.
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5301
Origin: upstream, 4.8.3, commit:
9b74027deaa4995ef582fdaf970ad881c3263cc1
Gbp-Pq: Name gdk-wayland-Fix-button-mask-calculation-on-button-events.patch
Balázs Úr [Sat, 5 Nov 2022 22:22:32 +0000 (22:22 +0000)]
Update Hungarian translation
Origin: upstream, 4.8.3, commit:
1e5b47c7ef5b3e444fb38c4072a6d4c84c584ef1
Gbp-Pq: Name Update-Hungarian-translation.patch
Daniel Mustieles [Wed, 2 Nov 2022 08:45:53 +0000 (09:45 +0100)]
Updated Spanish translation
Origin: upstream, 4.8.3, commit:
953c2ec3aed3b8ec4622e30d9cd3b6a56f7949db
Gbp-Pq: Name Updated-Spanish-translation.patch
Sabri Ünal [Wed, 2 Nov 2022 06:04:08 +0000 (06:04 +0000)]
Update Turkish translation
Origin: upstream, 4.8.3, commit:
ff8aadba7bb693d8a49311907ef4b7ec79d52480
Gbp-Pq: Name Update-Turkish-translation.patch
Nathan Follens [Tue, 1 Nov 2022 23:10:49 +0000 (23:10 +0000)]
Update Dutch translation
Origin: upstream, 4.8.3, commit:
381c05607060c584779f9e6fab6f662ddfada1fa
Gbp-Pq: Name Update-Dutch-translation.patch
Zurab Kargareteli [Tue, 1 Nov 2022 19:57:41 +0000 (19:57 +0000)]
Update Georgian translation
Origin: upstream, 4.8.3, commit:
f70c3548e10d229e136b2b189b55d20b2960dd44
Gbp-Pq: Name Update-Georgian-translation.patch
Nart Tlisha [Mon, 31 Oct 2022 09:51:47 +0000 (09:51 +0000)]
Update Abkhazian translation
Origin: upstream, 4.8.3, commit:
5863ddbfdd8baa7f0febe69ac06d553561faed7b
Gbp-Pq: Name Update-Abkhazian-translation.patch
Mat [Wed, 26 Oct 2022 10:51:23 +0000 (13:51 +0300)]
Revert "treepopover: Do not propagate natural width of content"
This reverts commit
9c919ffa462dd4511da0bfd19d36d2e15c51651b.
Origin: upstream, 4.8.3, commit:
339b9eb1b979fffc751cc82d1142d6231be8f0c5
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5192
Gbp-Pq: Name Revert-treepopover-Do-not-propagate-natural-width-of-cont.patch
Matthias Clasen [Thu, 20 Oct 2022 19:15:38 +0000 (19:15 +0000)]
wayland: Fix keycode->keyval mapping
Bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/5277
Origin: upstream, 4.8.3, commit:
bb61b5fb5b9d9c6118a484bb2f5d83e5f97895cc
Forwarded: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5167
Gbp-Pq: Name wayland-Fix-keycode-keyval-mapping.patch
Simon McVittie [Tue, 6 Dec 2022 11:52:24 +0000 (11:52 +0000)]
Update changelog
Simon McVittie [Tue, 6 Dec 2022 11:50:19 +0000 (11:50 +0000)]
Revert "Work around Mesa regresion #
1025312 by forcing software rendering"
This reverts commit
21fbef6d66586999e9a57d1c57694a4b8771f1c7.
Simon McVittie [Tue, 6 Dec 2022 11:50:07 +0000 (11:50 +0000)]
Update changelog
Simon McVittie [Tue, 6 Dec 2022 11:49:47 +0000 (11:49 +0000)]
Update from upstream gtk-4-8 branch
- Fix visual artifacts on X11
- Update translations
Simon McVittie [Tue, 6 Dec 2022 11:45:14 +0000 (11:45 +0000)]
d/patches: Sort Debian-specific patches to the end of the series
Simon McVittie [Tue, 6 Dec 2022 11:43:45 +0000 (11:43 +0000)]
Add patch to make the node editor reproducible
Simon McVittie [Mon, 5 Dec 2022 11:21:09 +0000 (11:21 +0000)]
Update changelog
Asier Sarasua Garmendia [Sat, 3 Dec 2022 09:45:52 +0000 (09:45 +0000)]
Update Basque translation
Simon McVittie [Fri, 2 Dec 2022 22:51:09 +0000 (22:51 +0000)]
Don't try to install man pages under nodoc build-profile
Simon McVittie [Fri, 2 Dec 2022 22:46:33 +0000 (22:46 +0000)]
Drop unused docbook and xsltproc build-dependencies
The man pages now use python3-docutils instead.
Benjamin Otte [Fri, 2 Dec 2022 17:10:38 +0000 (17:10 +0000)]
Merge branch 'cherry-pick-
a9c9678e' into 'gtk-4-8'
Merge branch 'workaround-glx-issue' into 'main'
See merge request GNOME/gtk!5287
Benjamin Otte [Fri, 2 Dec 2022 15:32:22 +0000 (15:32 +0000)]
Merge branch 'workaround-glx-issue' into 'main'
GLX: Add extra glXMakeContextCurrent () call to work around a DRI issue
Closes #4499, #5387, and #5170
See merge request GNOME/gtk!5285
(cherry picked from commit
a9c9678e1f617755368f16424a03ae1f2d2ced4e)
f788e994 GLX: Add extra glXMakeContextCurrent () call to work around a DRI issue