gtk4.git
3 years agofilechooserwidget: Reimplement DnD Drop Target
Corey Berla [Tue, 11 Oct 2022 04:20:07 +0000 (21:20 -0700)]
filechooserwidget: Reimplement DnD Drop Target

This reverts commit 34752a15a71597d00a8d08befc545ac1c178b81b.

Leaving out the drag source portion as that needs a total
reimplementation.  The GtkDropTarget only required minor
modifications.

3 years agofilechooserwidget: Reinstate show_and_select_files
Matthias Clasen [Tue, 11 Oct 2022 02:36:35 +0000 (22:36 -0400)]
filechooserwidget: Reinstate show_and_select_files

Now that we have information about visible and
filtered-out status of items, we can make this
function work again.

3 years agofilechooserwidget: Add a filter model
Matthias Clasen [Tue, 11 Oct 2022 02:21:39 +0000 (22:21 -0400)]
filechooserwidget: Add a filter model

Put a filter model between the selection model and
the filesystem model, and make it filter on the
filechooser::visible attribute. This makes the filer
combo in the filterchooser and the 'show hidden files'
item work. But we need to prod the filter to trigger
a refiltering every now and then.

3 years agofilesystemmodel: Make filtering info available
Matthias Clasen [Tue, 11 Oct 2022 02:19:40 +0000 (22:19 -0400)]
filesystemmodel: Make filtering info available

Provide the filtered-out and visible bits as a file attributes
under the names filechooser::filtered-out and filechooser::visible,
so that we can filter on it.

3 years agofilechooserwidget: Connect to the right model
Georges Basile Stavracas Neto [Tue, 11 Oct 2022 02:19:14 +0000 (23:19 -0300)]
filechooserwidget: Connect to the right model

When recreating the browse_files_model model, connect to that
model's item-changed signal, instead of connecting to the selection
model.

3 years agofilechooserwidget: Connect to items-changed when changing model
Georges Basile Stavracas Neto [Tue, 11 Oct 2022 02:18:00 +0000 (23:18 -0300)]
filechooserwidget: Connect to items-changed when changing model

Just like previous commit, we need to call list_items_changed()
even if we change from single selection to multi selection or
vice-versa.

3 years agofilesystemmodel: Drop an unused include
Matthias Clasen [Mon, 10 Oct 2022 23:59:47 +0000 (19:59 -0400)]
filesystemmodel: Drop an unused include

3 years agofilechooserwidget: Listen to items-changed too
Matthias Clasen [Mon, 10 Oct 2022 23:53:36 +0000 (19:53 -0400)]
filechooserwidget: Listen to items-changed too

To track changes of the selected items in a selection
model, we need to listen to both ::selection-changed
and ::items-changed.

This fixes the open button not turning sensitive
when initially loading a new folder.

3 years agofilechooser: Prevent recursion when activating items
Matthias Clasen [Mon, 10 Oct 2022 23:25:45 +0000 (19:25 -0400)]
filechooser: Prevent recursion when activating items

When a list item is activated, we activate the default widget.
Unfortunately, due to some other bug, sometimes the open button
is not made sensitive, and then default.activate falls back
to activating the focus widget (which is the item we are just
coming from). Boom

3 years agoactionmuxer: Add debug spew for action activation
Matthias Clasen [Mon, 10 Oct 2022 23:25:20 +0000 (19:25 -0400)]
actionmuxer: Add debug spew for action activation

This helps tracking down whe activation goes wrong.

3 years agofilesystemmodel: Drop the tree model implementation
Matthias Clasen [Mon, 10 Oct 2022 19:47:45 +0000 (15:47 -0400)]
filesystemmodel: Drop the tree model implementation

This is no longer used.

3 years agofilechooserwidget: Use GListModel API for post-renaming selection
Georges Basile Stavracas Neto [Mon, 10 Oct 2022 14:28:50 +0000 (11:28 -0300)]
filechooserwidget: Use GListModel API for post-renaming selection

3 years agofilechooserentry: Use separate GtkTreeStore for completion
Georges Basile Stavracas Neto [Mon, 10 Oct 2022 14:09:33 +0000 (11:09 -0300)]
filechooserentry: Use separate GtkTreeStore for completion

Soon GtkFileSystemModel will not be a GtkTreeModel implementation,
so preemptively remove any usage of this interface. Populate the
list store using the GListModel's 'items-changed' signal.

3 years agofilesystemmodel: Retire GtkFileSystemItem
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 21:52:12 +0000 (18:52 -0300)]
filesystemmodel: Retire GtkFileSystemItem

This has to be the shortest-living object in GTK history!

It helped us greatly during the transition to GtkColumnView, but
now we can remove it in favour of GFileInfo directly. Perhaps I
could have never introduced GtkFileSystemItem in the first place,
but we're 30 commits deep and it's too late to just redo the whole
thing that will get us exactly here anyway.

3 years agofilesystemmodel: Always set standard::file attribute
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 21:50:23 +0000 (18:50 -0300)]
filesystemmodel: Always set standard::file attribute

This will help us greatly when porting GtkFileSystemModel to
GtkDirectoryList.

3 years agofilesystemmodel: Trivial cleanup
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 21:49:37 +0000 (18:49 -0300)]
filesystemmodel: Trivial cleanup

Use g_set_object() which does exactly what the code there does.

3 years agofilechooserutils: Add helper to get GFile from info
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 20:41:33 +0000 (17:41 -0300)]
filechooserutils: Add helper to get GFile from info

This will be used extensively starting from next commit!

3 years agofilechooserentry: Trivial cleanups
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 20:25:09 +0000 (17:25 -0300)]
filechooserentry: Trivial cleanups

Use g_clear_object() in a couple of places. No functional changes.

3 years agosearchenginemodel: Use GListModel API to filter
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 20:21:29 +0000 (17:21 -0300)]
searchenginemodel: Use GListModel API to filter

We now start a mini-series of commits that will ultimately remove
the GtkTreeModel implementation of GtkFileSystemModel.

As a first step, port GtkSearchEngineModel iter through the files
using GListModel API.

3 years agofilechooserwidget: Remove treeview
Georges Basile Stavracas Neto [Sun, 9 Oct 2022 17:16:06 +0000 (14:16 -0300)]
filechooserwidget: Remove treeview

Now that most of the treeview usage is gone, remove the remaining
code that uses it - mostly event handling code, which for now won't
work, but will be fixed by next commits - and drop the tree view
entirely.

3 years agofilechooserwidget: Use GtkSelectionModel for selection
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 23:12:20 +0000 (20:12 -0300)]
filechooserwidget: Use GtkSelectionModel for selection

So far, GtkFileChooserWidget has relied on GtkTreeView's selection
management. This commit moves it away from GtkTreeView, and that's
a massive surgery - sorry :(

The most important aspect of this commit is that 'selection_model'
is now the main model we deal with. Changing between directories,
recent files, and search, all sets the selection_model's model.

Selections are entirely handled by GtkSelectionModel now.

3 years agofilesystemmodel: Add more GtkFileSystemItem getters
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 22:42:12 +0000 (19:42 -0300)]
filesystemmodel: Add more GtkFileSystemItem getters

They'll help us further remove GtkTreeModel code.

3 years agofilechooserwidget: Stop centering on selected files
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 18:18:13 +0000 (15:18 -0300)]
filechooserwidget: Stop centering on selected files

3 years agofilechooserwidget: Don't queue redraw / resize on tree view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 17:50:18 +0000 (14:50 -0300)]
filechooserwidget: Don't queue redraw / resize on tree view

3 years agofilechooserwidget: Compare focus against column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 17:49:35 +0000 (14:49 -0300)]
filechooserwidget: Compare focus against column view

This effectively doesn't work, but focus will be reworked at some
point, and this gets us a tiny bit closer to that.

3 years agogtkfilechooserwidget: Don't set size request
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 17:11:53 +0000 (14:11 -0300)]
gtkfilechooserwidget: Don't set size request

3 years agofilesystemmodel: Don't implement GtkTreeDragSource
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:32:48 +0000 (12:32 -0300)]
filesystemmodel: Don't implement GtkTreeDragSource

3 years agofilechooserwidget: Remove DnD code
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:32:19 +0000 (12:32 -0300)]
filechooserwidget: Remove DnD code

Another case where we'll reimplement it later.

3 years agofilesystemmodel: Drop GtkTreeSortable interface
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:25:10 +0000 (12:25 -0300)]
filesystemmodel: Drop GtkTreeSortable interface

Stop implementing this interface. We'll be able to reimplement
sorting once we fully transition to GListModel.

3 years agofilechooserwidget: Remove sorting
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:11:51 +0000 (12:11 -0300)]
filechooserwidget: Remove sorting

This will be reimplemented later using list models. For now, let's
remove it so we can untangle all this code properly.

3 years agofilechooserwidget: Stop autosizing treeview
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:10:55 +0000 (12:10 -0300)]
filechooserwidget: Stop autosizing treeview

3 years agofilechooserwidget: Use column view scrolled window
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:04:25 +0000 (12:04 -0300)]
filechooserwidget: Use column view scrolled window

One less hook to treeview widgetry.

3 years agofilechooserwidget: Move tooltip text to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 15:02:20 +0000 (12:02 -0300)]
filechooserwidget: Move tooltip text to column view

Use a closure binding to query the tooltip.

3 years agofilechooserwidget: Move folder navigation to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 13:51:14 +0000 (10:51 -0300)]
filechooserwidget: Move folder navigation to column view

React to column view's 'activate' signal, instead of treeview's
'row-activated'. It doesn't handle file sensitivity yet, but that
will probably be dropped later.

3 years agofilechooserwidget: Move keynav handling to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 13:24:04 +0000 (10:24 -0300)]
filechooserwidget: Move keynav handling to column view

3 years agofilechooserwidget: Set rubberbanding on column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 13:20:14 +0000 (10:20 -0300)]
filechooserwidget: Set rubberbanding on column view

And stop setting it on the tree view.

3 years agofilesystemmodel: Don't expose cache
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 13:12:41 +0000 (10:12 -0300)]
filesystemmodel: Don't expose cache

With this commit we start slowly cleaning up the sattelite code
surrounding GtkFileChooserWidget, so that we eventually drop it
all.

3 years agofilechooserwidget: Remove extra action bar
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 13:09:42 +0000 (10:09 -0300)]
filechooserwidget: Remove extra action bar

3 years agofilechooserwidget: Move date and time to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 13:03:05 +0000 (10:03 -0300)]
filechooserwidget: Move date and time to column view

Because this is the last treeview column, some pending tasks
are marked as TODO. We're getting close to dropping the tree
view!

3 years agofilechooserwidget: Move file type to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 12:29:15 +0000 (09:29 -0300)]
filechooserwidget: Move file type to column view

3 years agofilechooserwidget: Move size to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 12:13:01 +0000 (09:13 -0300)]
filechooserwidget: Move size to column view

This was one of the easier ones. We merely delegate the hard work
to g_format_size(), like we already do for treeview.

3 years agofilechooserwidget: Move location to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 12:01:42 +0000 (09:01 -0300)]
filechooserwidget: Move location to column view

Move the entire location column, which only contains the location
renderer, to the column view. The code to generate locations from
the current folder is essentially intact.

3 years agofilechooserwidget: Drop name column from treeview
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 11:22:53 +0000 (08:22 -0300)]
filechooserwidget: Drop name column from treeview

It is now entirely handled by the column view.

3 years agofilechooserwidget: Move file icon to column view
Georges Basile Stavracas Neto [Sat, 8 Oct 2022 11:15:09 +0000 (08:15 -0300)]
filechooserwidget: Move file icon to column view

This commit moves the icon loading code into a new private
widget called GtkFileThumbnail, which is bound to the GFileInfo
of the model, and asynchronously loads the file icon from that.

3 years agofilechooserwidget: Move file name to column view
Georges Basile Stavracas Neto [Fri, 7 Oct 2022 21:11:06 +0000 (18:11 -0300)]
filechooserwidget: Move file name to column view

And remove it from the tree view. Next commits will look a lot like
this, until all columns are moved.

3 years agofilechooserwidget: Replace 'list' page with column view
Georges Basile Stavracas Neto [Fri, 7 Oct 2022 20:48:26 +0000 (17:48 -0300)]
filechooserwidget: Replace 'list' page with column view

Replace the 'list' page of the main stack with another page, this
one containing a GtkColumnView. This, again, is the very minimal
code to achieve a column view - and validate the GListModel code
introduced in the previous commit - but there's a long way until
this column view covers the full range of features of the file
chooser.

The tree view still lives in an unused 'list2' page. From now on,
commits will "cannibalize" the treeview, each commit porting any
particular feature - be it a column, an event controller, etc -
to the column view, and dropping the corresponding feature from
the treeview.

3 years agofilesystemmodel: Implement GListModel
Georges Basile Stavracas Neto [Fri, 7 Oct 2022 19:52:56 +0000 (16:52 -0300)]
filesystemmodel: Implement GListModel

This is a trivial implementation of the GListModel interface. It
does not do anything fancy, like filtering out hidden files, nor
sorting.

The purpose of this minimal implementation is to bootstrap the
initial work to port GtkFileChooserWidget to GtkColumnView.

3 years agofilesystemmodel: Use g_clear_* on finalize
Georges Basile Stavracas Neto [Fri, 7 Oct 2022 20:12:05 +0000 (17:12 -0300)]
filesystemmodel: Use g_clear_* on finalize

Trivial cleanup, no functional changes.

3 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Fri, 21 Oct 2022 02:28:02 +0000 (02:28 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

inspector: Fix accessibility calls

See merge request GNOME/gtk!5154

3 years agoMerge branch 'completion' into 'main'
Matthias Clasen [Fri, 21 Oct 2022 02:13:42 +0000 (02:13 +0000)]
Merge branch 'completion' into 'main'

entrycompletion: Fix inserted-text handler

See merge request GNOME/gtk!4892

3 years agofilechooserentry: Fix completions
Matthias Clasen [Fri, 21 Oct 2022 01:41:18 +0000 (21:41 -0400)]
filechooserentry: Fix completions

Before we can drop them, lets make them work.

This was broken since 4.0, I assume :(

3 years agoinspector: Fix accessibility calls
Matthias Clasen [Fri, 21 Oct 2022 01:13:46 +0000 (21:13 -0400)]
inspector: Fix accessibility calls

The argument list of gtk_accessible_update_property
is -1-terminated, not NULL-terminated.

3 years agoMerge branch 'columnview-sorter-api' into 'main'
Matthias Clasen [Thu, 20 Oct 2022 19:18:26 +0000 (19:18 +0000)]
Merge branch 'columnview-sorter-api' into 'main'

gtk-demo: Add more sort columns

Closes #5149

See merge request GNOME/gtk!5152

3 years agoMerge branch 'fix-wayland-keycode-mapping' into 'main'
Matthias Clasen [Thu, 20 Oct 2022 19:15:38 +0000 (19:15 +0000)]
Merge branch 'fix-wayland-keycode-mapping' into 'main'

wayland: Fix keycode->keyval mapping

Closes #5277

See merge request GNOME/gtk!5147

3 years agoMerge branch 'ebassi/tree-deprecation-docs' into 'main'
Matthias Clasen [Thu, 20 Oct 2022 18:39:29 +0000 (18:39 +0000)]
Merge branch 'ebassi/tree-deprecation-docs' into 'main'

docs: Add deprecation messages to GtkTreeStore

See merge request GNOME/gtk!5115

3 years agoMerge branch 'wip/jtojnar/compose-consistent-system' into 'main'
Matthias Clasen [Thu, 20 Oct 2022 18:28:47 +0000 (18:28 +0000)]
Merge branch 'wip/jtojnar/compose-consistent-system' into 'main'

Improve composetable inclusions

See merge request GNOME/gtk!5150

3 years agocolumnviewtitle: Clean up interactions
Matthias Clasen [Thu, 20 Oct 2022 17:37:26 +0000 (13:37 -0400)]
columnviewtitle: Clean up interactions

Separate the apis we use for updating title,
menu and sort indicator.

3 years agocolumnviewsorter: Add public API
Matthias Clasen [Thu, 20 Oct 2022 14:33:57 +0000 (10:33 -0400)]
columnviewsorter: Add public API

This API should be sufficient to serialize
a columnviews sort configuration.

Fixes: #5149
3 years agoMake GtkColumnViewSorter public
Matthias Clasen [Thu, 20 Oct 2022 14:05:13 +0000 (10:05 -0400)]
Make GtkColumnViewSorter public

API is yet to come.

3 years agocolumnviewsorter: Cosmetics
Matthias Clasen [Thu, 20 Oct 2022 13:59:28 +0000 (09:59 -0400)]
columnviewsorter: Cosmetics

3 years agocolumnviewcolumn: Add an ID
Matthias Clasen [Thu, 20 Oct 2022 13:50:14 +0000 (09:50 -0400)]
columnviewcolumn: Add an ID

This string can be used when storing columnview
configuration.

3 years agocolumnviewcolumn: Remove some unused code
Matthias Clasen [Thu, 20 Oct 2022 13:52:54 +0000 (09:52 -0400)]
columnviewcolumn: Remove some unused code

3 years agocolumnviewcolumn: Cosmetics
Matthias Clasen [Thu, 20 Oct 2022 13:40:39 +0000 (09:40 -0400)]
columnviewcolumn: Cosmetics

3 years agogtk-demo: Add more sort columns
Matthias Clasen [Thu, 20 Oct 2022 15:38:40 +0000 (11:38 -0400)]
gtk-demo: Add more sort columns

Add a second sort column to the Settings demo,
to make it easier to test column view sorting.

3 years agoAdd more messages to the deprecation warnings
Emmanuele Bassi [Thu, 20 Oct 2022 11:42:27 +0000 (12:42 +0100)]
Add more messages to the deprecation warnings

Point to replacement types for the old GtkTree* API.

3 years agoMark GtkStyleContext type as deprecated
Emmanuele Bassi [Thu, 20 Oct 2022 11:36:32 +0000 (12:36 +0100)]
Mark GtkStyleContext type as deprecated

Add the Deprecated tag to the type docblock

3 years agoMark GtkEntryCompletion type as deprecated
Emmanuele Bassi [Thu, 20 Oct 2022 11:36:08 +0000 (12:36 +0100)]
Mark GtkEntryCompletion type as deprecated

Add the Deprecated tag to the type docblock.

3 years agoMark GtkTreeView-related types as deprecated
Emmanuele Bassi [Thu, 20 Oct 2022 11:35:31 +0000 (12:35 +0100)]
Mark GtkTreeView-related types as deprecated

Add the Deprecated annotation to the type docblock.

3 years agoimcontextsimple: Document that Compose file support is incomplete
Jan Tojnar [Thu, 20 Oct 2022 14:19:13 +0000 (16:19 +0200)]
imcontextsimple: Document that Compose file support is incomplete

And that `include "%L"` does something different as introduced in
https://gitlab.gnome.org/GNOME/gtk/-/commit/3b4b1c68781aad61fc6b91c9dff75b5790b4d8e4

Note that user can still use `include "/.%L"` as a workaround.

3 years agoMark GtkAppChooser-related types as deprecated
Emmanuele Bassi [Thu, 20 Oct 2022 11:23:58 +0000 (12:23 +0100)]
Mark GtkAppChooser-related types as deprecated

The type docblock needs a Deprecated annotation.

3 years agoMark GtkCellRenderer-related types as deprecated
Emmanuele Bassi [Thu, 20 Oct 2022 11:23:13 +0000 (12:23 +0100)]
Mark GtkCellRenderer-related types as deprecated

The docblock for the type needs a Deprecated annotation, and we can use
it to point to the appropriate replacement.

3 years agoPoint at the replacement for GtkIconView
Emmanuele Bassi [Thu, 20 Oct 2022 10:38:11 +0000 (11:38 +0100)]
Point at the replacement for GtkIconView

In the symbol annotations and in the docblocks.

3 years agoPoint at the replacements for GtkTreeView
Emmanuele Bassi [Thu, 20 Oct 2022 10:37:23 +0000 (11:37 +0100)]
Point at the replacements for GtkTreeView

In the symbol annotations and in the docblocks.

3 years agoPoint to replacement for GtkComboBoxText
Emmanuele Bassi [Thu, 20 Oct 2022 10:11:41 +0000 (11:11 +0100)]
Point to replacement for GtkComboBoxText

GtkDropDown and GtkStringList replace GtkComboBoxText with a simpler
API.

3 years agocomposetable: Support non-FHS paths for Compose tables
Jan Tojnar [Thu, 20 Oct 2022 10:59:17 +0000 (12:59 +0200)]
composetable: Support non-FHS paths for Compose tables

On platforms like NixOS, the libX11 installation prefix may differ from /usr/share,
breaking the hardcoded placeholders. Let’s re-use the X11 path definition from imcontextsimple.

3 years agoPoint to GtkDropDown as the GtkComboBox replacement
Emmanuele Bassi [Thu, 20 Oct 2022 10:10:57 +0000 (11:10 +0100)]
Point to GtkDropDown as the GtkComboBox replacement

3 years agodocs: Add deprecation message for GtkListStore
Emmanuele Bassi [Wed, 12 Oct 2022 23:06:12 +0000 (00:06 +0100)]
docs: Add deprecation message for GtkListStore

Point to GListStore and list models instead.

3 years agodocs: Add deprecation messages to GtkTreeStore
Emmanuele Bassi [Wed, 12 Oct 2022 22:48:38 +0000 (23:48 +0100)]
docs: Add deprecation messages to GtkTreeStore

Point to GtkTreeListModel, and while we're at it, let's fix some of the
gtk-doc-isms that are still there.

3 years agoMerge branch 'label-selection-fix' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 21:37:08 +0000 (21:37 +0000)]
Merge branch 'label-selection-fix' into 'main'

label: Tweak selection behavior

Closes #2024

See merge request GNOME/gtk!5148

3 years agolabel: Tweak selection behavior
Matthias Clasen [Wed, 19 Oct 2022 20:21:36 +0000 (16:21 -0400)]
label: Tweak selection behavior

Arrange for double-click-followed-by-drag to do
select by words, not select-and-dnd. This matches
the behavior in GtkTextView better and feels
intuitive.

Fixes: #2024
3 years agowayland: Fix keycode->keyval mapping
Matthias Clasen [Wed, 19 Oct 2022 19:35:12 +0000 (15:35 -0400)]
wayland: Fix keycode->keyval mapping

We were looping over the levels, but not using
the current level value to obtain the keymap
entries. Oops.

Fixes: #5277
3 years agoMerge branch 'filechooser-amberol' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 19:41:15 +0000 (19:41 +0000)]
Merge branch 'filechooser-amberol' into 'main'

filechooser: Improve "Open in File Manager"

Closes #5260

See merge request GNOME/gtk!5140

3 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 19:11:57 +0000 (19:11 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

docs: Remove mention of ~/.gtk-4.0

Closes #3266

See merge request GNOME/gtk!5146

3 years agofilechooser: Improve "Open in File Manager"
Matthias Clasen [Wed, 19 Oct 2022 05:51:19 +0000 (01:51 -0400)]
filechooser: Improve "Open in File Manager"

Just relying on GAppInfo leads to suboptimal
results. Instead, call either the OpenURI portal
or the org.freedesktop.FileManager1 interface
directly, and only fall back to GAppInfo.

The wrapper code for the OpenURI portal is taken
from gio, with small adjustments.

Fixes: #5260
3 years agodocs: Remove mention of ~/.gtk-4.0
Matthias Clasen [Wed, 19 Oct 2022 18:32:23 +0000 (14:32 -0400)]
docs: Remove mention of ~/.gtk-4.0

We are not looking there anymore, for a long time.

Fixes: #3266
3 years agoMerge branch 'builder-tool-scope' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 18:34:25 +0000 (18:34 +0000)]
Merge branch 'builder-tool-scope' into 'main'

docs: Update gtk4-builder-tool docs

See merge request GNOME/gtk!5145

3 years agodocs: Document new buildertool options
Matthias Clasen [Wed, 19 Oct 2022 16:31:53 +0000 (12:31 -0400)]
docs: Document new buildertool options

3 years agobuildertool: Support enumerating callbacks
Matthias Clasen [Wed, 19 Oct 2022 16:29:39 +0000 (12:29 -0400)]
buildertool: Support enumerating callbacks

The new scope approach makes this easy, and
it can be useful to know what functions are
needed.

3 years agobuildertool: Improve validate implementation
Matthias Clasen [Wed, 19 Oct 2022 15:41:35 +0000 (11:41 -0400)]
buildertool: Improve validate implementation

Reimplement deprecation checking via a scope.
This lets us ignore missing callbacks, and helps
for validating templates.

3 years agobuildertool: Add a builder scope implementation
Matthias Clasen [Wed, 19 Oct 2022 16:13:29 +0000 (12:13 -0400)]
buildertool: Add a builder scope implementation

This will be used in future commits.

3 years agobuildertool: Use --deprecations for templates
Matthias Clasen [Wed, 19 Oct 2022 14:30:36 +0000 (10:30 -0400)]
buildertool: Use --deprecations for templates

Use this option for templates too.

We still can't parse most templates, since they are
missing their callbacks.

3 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 17:13:23 +0000 (17:13 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

docs: Update gtk4-builder-tool docs

See merge request GNOME/gtk!5144

3 years agoMerge branch 'wip/clipboard-serials' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 13:57:19 +0000 (13:57 +0000)]
Merge branch 'wip/clipboard-serials' into 'main'

gdk/wayland: Use serial of the latest implicit grab available

Closes #5250

See merge request GNOME/gtk!5143

3 years agodocs: Update gtk4-builder-tool docs
Matthias Clasen [Wed, 19 Oct 2022 12:50:34 +0000 (08:50 -0400)]
docs: Update gtk4-builder-tool docs

Mention the new --deprecations option of the
validate command.

3 years agogdk/wayland: Use serial of the latest implicit grab available
Carlos Garnacho [Wed, 19 Oct 2022 10:46:09 +0000 (12:46 +0200)]
gdk/wayland: Use serial of the latest implicit grab available

When getting the serial for primary/clipboard selections we used a
function that largely relied on a GdkEvent being passed. We have
another available function that looks up the most recent serial
given the ongoing touch/tablet input as well.

This is the second best, compared to actually knowing the
input/device from the event that was received by the UI an triggered
the clipboard operation, and is already in use in other places
(e.g. window dragging). It is valid for these situations too.

Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5250
3 years agoMerge branch 'builder-deprecations' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 11:20:37 +0000 (11:20 +0000)]
Merge branch 'builder-deprecations' into 'main'

buildertool: Fix template handling

Closes #5256

See merge request GNOME/gtk!5141

3 years agobuildertool: Warn about deprecations
Matthias Clasen [Wed, 19 Oct 2022 06:46:52 +0000 (02:46 -0400)]
buildertool: Warn about deprecations

Add a new option --deprecations to the validate
command that will warn about use of deprecated types.

The list of current deprecations is unfortunately
hardcoded in the source, so this list will have to
be kept up-to-date.

Fixes: #5256
3 years agobuildertool: Fix template handling
Matthias Clasen [Wed, 19 Oct 2022 06:40:10 +0000 (02:40 -0400)]
buildertool: Fix template handling

We were not properly parsing the error message
here, leading to badness.

3 years agoMerge branch 'text-overwrite-undo' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 05:59:13 +0000 (05:59 +0000)]
Merge branch 'text-overwrite-undo' into 'main'

testsuite: Fix tiff pixbuf tests

Closes #4411

See merge request GNOME/gtk!5138

3 years agoMerge branch 'clarify-gapplication-docs' into 'main'
Matthias Clasen [Wed, 19 Oct 2022 03:54:36 +0000 (03:54 +0000)]
Merge branch 'clarify-gapplication-docs' into 'main'

docs: Clarify a point in GtkApplication docs

See merge request GNOME/gtk!5139