Nextcloud bot [Thu, 8 Oct 2020 03:37:16 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Wed, 7 Oct 2020 15:12:02 +0000 (17:12 +0200)]
Merge pull request #2514 from nextcloud/make_it_easier_for_user_to_provide_debug_information
Make it easier for user to provide debug information
Kevin Ottens [Mon, 5 Oct 2020 19:56:42 +0000 (21:56 +0200)]
Also add build infos in the archive
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 17:45:47 +0000 (19:45 +0200)]
Also add the command line arguments in the archive
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 17:45:40 +0000 (19:45 +0200)]
Add a button to create a debug archive
This will harvest everything we might need for debugging purposes:
* config file
* sync journal dbs
* log files
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 17:20:26 +0000 (19:20 +0200)]
Add dependency on QtGuiPrivate
I'm not a huge fan of using private APIs but QZip is really the API with
the least hassles for our debug archive need. No external dependency and
we know it is generally available and stable despite the lack of
stability promise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 17:36:25 +0000 (19:36 +0200)]
Expose more of the logger state
It is better to rely on the Logger state to know exactly where we're
logging. Indeed due to the the various ways to impact its state the
config alone might not now where we're logging.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 17:34:46 +0000 (19:34 +0200)]
Make sure --logfile has precedence on config
Since we changed the default in the config file and since log dir had
precedence on log file, the --logfile command line option wasn't doing
anything anymore.
We make sure it has an effect again overriding --logdir or the logDir
config entry.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 15:48:30 +0000 (17:48 +0200)]
Change the defaults for logging
Turn on the logging by default for everyone. Let's use a log dir within
the config directory of the application and have debug logs expiring
after a day.
This obviously means we'll generate quite some logs but with the
automated compression it shouldn't be too horrible. Obviously that
scales with the amount of files and syncs occurring. In our tests with a
large setup we're around 100 MB for a day worth of logs, this shouldn't
be too much of an issue on today's average desktop/laptop.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Michael Schuster [Wed, 7 Oct 2020 13:30:17 +0000 (15:30 +0200)]
Merge pull request #2520 from nextcloud/handle_askForOptionalPassword_capability
Handle ask for optional password capability
Kevin Ottens [Tue, 6 Oct 2020 12:01:53 +0000 (14:01 +0200)]
If askForOptionalPassword is enabled preset a random password
This is the same approach used on the server side. Turns out I quite
like it, this avoids popping up a dialog to the user and since she won't
know the password she'll have to set a new one anyway or disable it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 6 Oct 2020 10:45:45 +0000 (12:45 +0200)]
Since we must ask for a password this can't be a default public link
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 6 Oct 2020 10:45:19 +0000 (12:45 +0200)]
Add sharePublicLinkAskOptionalPassword to Capabilities
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Nextcloud bot [Wed, 7 Oct 2020 03:36:23 +0000 (03:36 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Tue, 6 Oct 2020 03:36:51 +0000 (03:36 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Mon, 5 Oct 2020 14:56:23 +0000 (16:56 +0200)]
Merge pull request #2512 from nextcloud/fix_updater_with_github_downloads
Handle redirects when downloading updates
Kevin Ottens [Mon, 5 Oct 2020 13:48:39 +0000 (15:48 +0200)]
Handle redirects when downloading updates
This is necessary for downloads coming from Github for instance. They
are systematically redirected and we'd just fail the download.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 5 Oct 2020 07:43:00 +0000 (09:43 +0200)]
Merge pull request #2500 from nextcloud/docs-msi
Windows MSI: Update Docs & add SKIPAUTOUPDATE property
Michael Schuster [Fri, 2 Oct 2020 18:28:36 +0000 (20:28 +0200)]
Docs: Be slightly more modern and use 64-bit examples
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Fri, 2 Oct 2020 00:36:29 +0000 (02:36 +0200)]
Windows MSI: Add SKIPAUTOUPDATE property for the skipUpdateCheck setting
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Tue, 29 Sep 2020 17:11:01 +0000 (19:11 +0200)]
Docs: Use our app name in the MSI docs
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Tue, 29 Sep 2020 17:05:39 +0000 (19:05 +0200)]
Windows MSI: Stay compatible with the upstream "StartMenuShortcuts" feature
Even though we only create a program shortcut in the Start Menu, try to make administrators lives easier by not diverging feature and option naming.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Tue, 29 Sep 2020 17:04:08 +0000 (19:04 +0200)]
Docs: Adopt latest MSI doc enhancements from upstream master
Signed-off-by: Michael Schuster <michael@schuster.ms>
Dominik Schmidt [Tue, 29 Sep 2020 16:21:29 +0000 (18:21 +0200)]
Docs: Adopt upstream commit
fe04300 for MSI installation
See: https://github.com/owncloud/client/commit/
fe043006c8f4a43b033243a85c294d21c7450238
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Tue, 29 Sep 2020 15:59:39 +0000 (17:59 +0200)]
Docs: Update macOS version info
Signed-off-by: Michael Schuster <michael@schuster.ms>
Nextcloud bot [Mon, 5 Oct 2020 03:38:36 +0000 (03:38 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sun, 4 Oct 2020 03:38:54 +0000 (03:38 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sat, 3 Oct 2020 03:40:51 +0000 (03:40 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Fri, 2 Oct 2020 17:30:26 +0000 (19:30 +0200)]
Merge pull request #2497 from nextcloud/fix/mac-folderwatcher-memory-leak
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
Michael Schuster [Thu, 1 Oct 2020 21:38:13 +0000 (23:38 +0200)]
Fix source file access modes
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Tue, 14 Jul 2020 06:54:07 +0000 (08:54 +0200)]
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
Signed-off-by: Michael Schuster <michael@schuster.ms>
Nextcloud bot [Fri, 2 Oct 2020 03:32:41 +0000 (03:32 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Thu, 1 Oct 2020 22:07:45 +0000 (00:07 +0200)]
Merge pull request #2478 from Aldaris1985/patch-1
Update propagateupload.cpp
Aldaris1985 [Mon, 28 Sep 2020 11:00:30 +0000 (19:00 +0800)]
Update propagateupload.cpp
Typo corrected.
Kevin Ottens [Thu, 1 Oct 2020 11:03:09 +0000 (13:03 +0200)]
Merge pull request #2493 from nextcloud/kesselb-patch-1
Delete FUNDING.yml
kesselb [Thu, 1 Oct 2020 09:21:12 +0000 (11:21 +0200)]
Delete FUNDING.yml
Nextcloud bot [Thu, 1 Oct 2020 03:40:09 +0000 (03:40 +0000)]
[tx-robot] updated from transifex
Kevin Ottens [Wed, 30 Sep 2020 12:02:27 +0000 (14:02 +0200)]
Merge pull request #2487 from nextcloud/add-talk-icon
Add a clickable icon for Talk notifications.
Camila [Tue, 29 Sep 2020 17:22:43 +0000 (19:22 +0200)]
Add a clickable icon for Talk notifications.
Signed-off-by: Camila <hello@camila.codes>
Nextcloud bot [Wed, 30 Sep 2020 03:39:38 +0000 (03:39 +0000)]
[tx-robot] updated from transifex
Kevin Ottens [Tue, 29 Sep 2020 17:58:52 +0000 (19:58 +0200)]
Merge pull request #2272 from snake66/issues/2219/deprecate-foreach
Issues/2219/deprecate foreach
Harald Eilertsen [Tue, 29 Sep 2020 17:23:06 +0000 (19:23 +0200)]
Replace find_if with none_of where appropriate.
We're not interested in any found element in these cases, just to check
that none of the elements matches.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Tue, 29 Sep 2020 16:32:48 +0000 (18:32 +0200)]
Don't hold ref to value returned from function.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 12:24:19 +0000 (14:24 +0200)]
gui/accountmanager: Make isAccountIdAvailable a bit clearer.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 11:19:08 +0000 (13:19 +0200)]
gui/folderman: Replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 11:13:21 +0000 (13:13 +0200)]
gui/folder: Replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 11:11:22 +0000 (13:11 +0200)]
gui/application: replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 11:07:34 +0000 (13:07 +0200)]
gui/accountstate: Replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sat, 15 Aug 2020 12:41:59 +0000 (14:41 +0200)]
gui/accountstate: Replace foreach (#2219)
Most instances have been converted to range based for, but std::find_if
has been used where it made sense.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 11:02:27 +0000 (13:02 +0200)]
gui/accountmanager: Replace foreach/Q_FOREACH (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Harald Eilertsen [Sun, 27 Sep 2020 11:25:52 +0000 (13:25 +0200)]
cmd: Replace foreach with range base for (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
Camila [Tue, 29 Sep 2020 17:26:06 +0000 (19:26 +0200)]
Merge pull request #2486 from nextcloud/fix-notification
Connect signal guiLog to slot to display systray message.
Camila [Tue, 29 Sep 2020 16:51:48 +0000 (18:51 +0200)]
Correct the object name returned by the api.
The id was always 0 so no new systray messages were displayed.
Signed-off-by: Camila <hello@camila.codes>
Camila [Tue, 29 Sep 2020 15:07:36 +0000 (17:07 +0200)]
Connect signal guiLog to slot to display systray message.
Signed-off-by: Camila <hello@camila.codes>
Kevin Ottens [Tue, 29 Sep 2020 12:43:39 +0000 (14:43 +0200)]
Merge pull request #2485 from nextcloud/Valdnet-patch-1
l10n: Remove space from string text
Valdnet [Tue, 29 Sep 2020 12:39:34 +0000 (14:39 +0200)]
l10n: Remove space from string text
Nextcloud bot [Tue, 29 Sep 2020 03:41:15 +0000 (03:41 +0000)]
[tx-robot] updated from transifex
Kevin Ottens [Mon, 28 Sep 2020 14:48:26 +0000 (16:48 +0200)]
Merge pull request #2317 from nextcloud/tray-accessibility
Tray accessibility
Dominique Fuchs [Tue, 15 Sep 2020 14:45:22 +0000 (16:45 +0200)]
emitting signals from Qts Accessibility interaction invocations instead of duplicating actions
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 14:52:05 +0000 (16:52 +0200)]
KISS. Removed description for now, instead clarified some Accessible.name
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 13:00:19 +0000 (15:00 +0200)]
Added missing qsTr() calls - again
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 12:59:10 +0000 (14:59 +0200)]
Added missing qsTr() calls
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 11:17:37 +0000 (13:17 +0200)]
Fix typo
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 11:16:42 +0000 (13:16 +0200)]
Typo fixes, minor additions
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 10:56:24 +0000 (12:56 +0200)]
Re-add wrongly delete action
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Tue, 25 Aug 2020 10:54:56 +0000 (12:54 +0200)]
Initial accessibility declarations for tray window qml src
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Camila [Mon, 28 Sep 2020 11:02:41 +0000 (13:02 +0200)]
Merge pull request #2477 from nextcloud/free_icon_job
Free IconJob after use
Dan Griffin [Mon, 28 Sep 2020 10:27:16 +0000 (12:27 +0200)]
Free IconJob after use
Signed-off-by: Dan Griffin <github.mk@xiragon.com>
Nextcloud bot [Mon, 28 Sep 2020 03:37:52 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sun, 27 Sep 2020 03:37:06 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sat, 26 Sep 2020 03:38:03 +0000 (03:38 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Fri, 25 Sep 2020 03:41:46 +0000 (03:41 +0000)]
[tx-robot] updated from transifex
Kevin Ottens [Thu, 24 Sep 2020 12:49:44 +0000 (14:49 +0200)]
Merge pull request #2470 from nextcloud/fix_qt_5_12_tooltip_wrap
Force tooltip wrap mode because it's not enabled in Qt 5.12...
Kevin Ottens [Thu, 24 Sep 2020 12:47:56 +0000 (14:47 +0200)]
Force tooltip wrap mode because it's not enabled in Qt 5.12...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Nextcloud bot [Thu, 24 Sep 2020 03:38:39 +0000 (03:38 +0000)]
[tx-robot] updated from transifex
Kevin Ottens [Wed, 23 Sep 2020 11:15:00 +0000 (13:15 +0200)]
Merge pull request #2409 from jplsek/native-text-render
Use native text rendering for qml windows
Jeremy Plsek [Fri, 11 Sep 2020 00:36:28 +0000 (20:36 -0400)]
Use native text rendering for qml windows
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com>
Kevin Ottens [Wed, 23 Sep 2020 07:59:31 +0000 (09:59 +0200)]
Merge pull request #2441 from nextcloud/enh/server-url
Allow server URL to be pre-defined without enforcing it
Michael Schuster [Thu, 17 Sep 2020 01:38:35 +0000 (03:38 +0200)]
Allow server URL to be pre-defined without enforcing it to be used unmodified
APPLICATION_SERVER_URL can be either empty or be specified. This commit adds the new CMake option APPLICATION_SERVER_URL_ENFORCE to decide whether to enforce the
URL's unmodified use (like before, default: ON) or to allow modification by the user (new).
By default APPLICATION_SERVER_URL_ENFORCE is set to ON, to no break with the previous implementation's expectations.
If APPLICATION_SERVER_URL is empty, APPLICATION_SERVER_URL_ENFORCE will be ignored by the Account Wizard.
The previous behaviour confused me a bit with branded builds. When the URL was (usually) specified but not forced, it was simply discarded, forcing the user to
manually supply it.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Nextcloud bot [Wed, 23 Sep 2020 03:37:35 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Tue, 22 Sep 2020 03:37:33 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Mon, 21 Sep 2020 15:35:37 +0000 (17:35 +0200)]
Merge pull request #2369 from nextcloud/enh/windows-msi
Windows: MSI support & Win32 migration tools
Michael Schuster [Wed, 9 Sep 2020 19:01:38 +0000 (21:01 +0200)]
Windows: Win32 migration tools code review
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Sat, 5 Sep 2020 05:35:53 +0000 (07:35 +0200)]
Windows MSI: Add MSI scripts and UI resources
Uses CMake to generate and install all required files in the "msi/" directory.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Sat, 5 Sep 2020 04:58:48 +0000 (06:58 +0200)]
Windows: Add Win32 stand-alone migration tool NCNavRemove
Removes all Explorer Navigation Pane entries for a given ApplicationName, specified in NavRemove.ini in the working directory.
Also compiles a DLL with the same behaviour that exports:
- RemoveNavigationPaneEntries
Both tool variants are Mutex-protected.
Statically linked, optimized for binary size, no Qt dependencies.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Sat, 5 Sep 2020 04:30:09 +0000 (06:30 +0200)]
Windows MSI: Add helper DLL and shared migration tools code
The helper DLL will be utilized by Windows Installer with Custom Actions defined in the NCMsiHelper.wxs WiX fragment.
Exports:
- ExecNsisUninstaller
- RemoveNavigationPaneEntries
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Sat, 5 Sep 2020 02:39:05 +0000 (04:39 +0200)]
Windows MSI: Let CMake install Shell Extensions WiX fragment to "msi/"
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Sat, 5 Sep 2020 02:25:49 +0000 (04:25 +0200)]
Windows MSI: Add Upgrade Code and migration tool build options to NEXTCLOUD.cmake
The Upgrade Code is a GUID (specified without brackets) for the MSI package to allow Windows Installer identify existing installations.
New build options (default: OFF):
- BUILD_WIN_MSI: Build all MSI scripts and a required helper DLL (to uninstall NSIS legacy installations and remove Explorer Navigation Pane entries)
- BUILD_WIN_TOOLS: Build additional migration tools (currently NCNavRemove, a stand-alone tool for Explorer entries removal)
The helper DLL and migration tools are set to be statically linked and optimized for binary size.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Kevin Ottens [Mon, 21 Sep 2020 13:40:37 +0000 (15:40 +0200)]
Merge pull request #2431 from jplsek/remove-this-includes
Remove "This includes" due to tooltip order
Jeremy Plsek [Tue, 15 Sep 2020 21:13:36 +0000 (17:13 -0400)]
Remove "This includes" due to tooltip order
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com>
Nextcloud bot [Mon, 21 Sep 2020 03:32:07 +0000 (03:32 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sun, 20 Sep 2020 03:31:45 +0000 (03:31 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sat, 19 Sep 2020 03:34:11 +0000 (03:34 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Fri, 18 Sep 2020 18:41:34 +0000 (20:41 +0200)]
Merge pull request #2437 from nextcloud/remove_no_description_available_messages_in_activity_list
If there's no description just say nothing
Kevin Ottens [Wed, 16 Sep 2020 11:38:52 +0000 (13:38 +0200)]
If there's no description just say nothing
Otherwise we get lots of "No description available" lines in the
activity list which is basically noise. Also trains the user to ignore
the secondary line.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Michael Schuster [Fri, 18 Sep 2020 04:44:11 +0000 (06:44 +0200)]
Merge pull request #2445 from nextcloud/fix-mac-catalina-login
Entitlement to sign the QtWebEngineProcess with an exception.
Camila San [Thu, 17 Sep 2020 18:06:52 +0000 (20:06 +0200)]
Entitlement to sign the QtWebEngineProcess with an exception.
Fix for #1793: The problem seems to be related enabling hardened runtime.
This exception allows the webview to load.
Signed-off-by: Camila San <hello@camila.codes>
Nextcloud bot [Fri, 18 Sep 2020 03:30:59 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Thu, 17 Sep 2020 14:04:12 +0000 (16:04 +0200)]
Merge pull request #2439 from nextcloud/fix-subfolder-missing-contentsync
Fix missing subdirectory discovery on move operations in macOS
Dominique Fuchs [Wed, 16 Sep 2020 17:50:16 +0000 (19:50 +0200)]
Fix missing subdirectory discovery on move operations in macOS.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Add qAsConst to avoid detaching
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Changed callchain to find and return possibly coalesced paths
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Removed another qAsConst remnant, more func const-correctness.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
projects / nextcloud-desktop.git / log