Claudio Cambra [Mon, 4 Mar 2024 13:51:37 +0000 (21:51 +0800)]
Reload data source on share saving
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:42:06 +0000 (21:42 +0800)]
Use a sharecontroller in shareviewcontroller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:40:01 +0000 (21:40 +0800)]
Make save button functional in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:37:04 +0000 (21:37 +0800)]
Add fields as parameters to save in sharecontroller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:35:40 +0000 (21:35 +0800)]
Correctly handle NKShare's "canEdit" in share options view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:35:25 +0000 (21:35 +0800)]
Add convenience function to enable or disable all share option fields
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:02:35 +0000 (21:02 +0800)]
Respond to changes in share of sharecontroller in shareoptionsview
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 13:02:00 +0000 (21:02 +0800)]
Add convenience function to format date to valid server string in nkshare
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 12:42:52 +0000 (20:42 +0800)]
Use ShareController in ShareOptionsView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 12:41:01 +0000 (20:41 +0800)]
Add functionality to share controller to save changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 12:40:31 +0000 (20:40 +0800)]
Add convenience property to nkshare extension to get valid expiration date string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 12:09:17 +0000 (20:09 +0800)]
Add starter sharecontroller for fileprovider
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 11:17:19 +0000 (19:17 +0800)]
Handle optionsview as ShareOptionsView in share view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 11:16:57 +0000 (19:16 +0800)]
Handle state of share options view via setting of NKShare
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Mar 2024 11:08:35 +0000 (19:08 +0800)]
Improve placeholder text for share view password field
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 14:37:01 +0000 (22:37 +0800)]
Add a ShareOptionsView class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:57:23 +0000 (21:57 +0800)]
Ensure calls are made via main actor to delegate in share table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:57:08 +0000 (21:57 +0800)]
Tell delegate when fetch ongoing in share table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:56:47 +0000 (21:56 +0800)]
Add fetch related handling functions to ui delegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:56:26 +0000 (21:56 +0800)]
Add a loading overlay to table view to indicate fetch in progress
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:36:19 +0000 (21:36 +0800)]
Implement hide and show of share options in share view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:28:07 +0000 (21:28 +0800)]
Re-integrate share options view into main share view controller XIB
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:16:34 +0000 (21:16 +0800)]
Implement ui delegate in ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:15:53 +0000 (21:15 +0800)]
Treat bottom view in share view as a target view to inject other views
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:15:31 +0000 (21:15 +0800)]
Add a shareview ui delegate protocol for datasources
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 13:15:11 +0000 (21:15 +0800)]
Extract options view to different XIB
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 12:50:09 +0000 (20:50 +0800)]
Redesign shares to incorporate share options into main share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 12:17:23 +0000 (20:17 +0800)]
Add starter ShareOptionsWindow class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 11:39:01 +0000 (19:39 +0800)]
Replace ShareOptionsView with a ShareOptionsWindow
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 09:18:08 +0000 (17:18 +0800)]
Implement ShareOptionsView design
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 09:17:57 +0000 (17:17 +0800)]
Add starter ShareOptionsView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:47:48 +0000 (16:47 +0800)]
Add popover and corresponding view controller to sharetableitemview
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:36:15 +0000 (16:36 +0800)]
Temporarily change copy share link button image after clicking
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:35:57 +0000 (16:35 +0800)]
Implement share link copying in share table item view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:03:15 +0000 (16:03 +0800)]
Improve share table style
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:01:01 +0000 (16:01 +0800)]
Make share property central to display update of share table item view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:00:28 +0000 (16:00 +0800)]
Add displayString property to NKShare extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 08:00:11 +0000 (16:00 +0800)]
Add typeImage property to NKShare extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 07:59:53 +0000 (15:59 +0800)]
Add ShareType enum to NKShare extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 07:31:45 +0000 (15:31 +0800)]
Add starter NKShare extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Feb 2024 06:54:57 +0000 (14:54 +0800)]
Customise prepareForReuse in ShareTableItemView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 16:21:01 +0000 (00:21 +0800)]
Ensure usable rowHeight for shares table view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 16:20:43 +0000 (00:20 +0800)]
Set basic property of sharetableitemview in delegate method of data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 16:20:05 +0000 (00:20 +0800)]
Add corresponding class for ShareTableItemView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 16:19:37 +0000 (00:19 +0800)]
Set delegate for shares table view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 16:19:25 +0000 (00:19 +0800)]
Remove default item view in ShareViewController table XIB
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:56:55 +0000 (23:56 +0800)]
Move all share fetching logic to FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:56:18 +0000 (23:56 +0800)]
Register shareItemView nib in shareTableView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:56:08 +0000 (23:56 +0800)]
Implement NSTableViewDelegate viewFor method in sharetableviewdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:55:26 +0000 (23:55 +0800)]
Add essential table view data source method to ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:54:12 +0000 (23:54 +0800)]
Add release entitlements fro FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:53:49 +0000 (23:53 +0800)]
Add method to get an item's server path through FPUIExtensionService
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 15:53:19 +0000 (23:53 +0800)]
Remove logging from NextcloudAccount
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 14:47:43 +0000 (22:47 +0800)]
Add method to FPUIExtensionServiceSource to get extension account details
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 14:44:12 +0000 (22:44 +0800)]
Add NextcloudAccount to FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 14:43:58 +0000 (22:43 +0800)]
Add method to convert dictionary to NextcloudAccount
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 14:43:46 +0000 (22:43 +0800)]
Add method to export NextcloudAccount details to dictionary
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 13:25:47 +0000 (21:25 +0800)]
Fix linking of FileProviderUIExt which was missing NextcloudKit symbols
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 13:25:22 +0000 (21:25 +0800)]
Add FPUIExtensionServiceSource to services published by FileProviderExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 13:25:02 +0000 (21:25 +0800)]
Fix visibility of logging in ItemSharesController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 13:24:49 +0000 (21:24 +0800)]
Fix protocol used for FPUIExtensionServiceSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:29:07 +0000 (20:29 +0800)]
Instantiate share data source in share view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:28:55 +0000 (20:28 +0800)]
Add item shares loading routine to ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:29:46 +0000 (20:29 +0800)]
Add share fetching routine to FPUIExtensionService
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:28:27 +0000 (20:28 +0800)]
Move serviceConnection method to table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:28:09 +0000 (20:28 +0800)]
Add base properties to ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:27:19 +0000 (20:27 +0800)]
Add outlet for share view table view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 12:27:04 +0000 (20:27 +0800)]
Add starter ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 11:57:01 +0000 (19:57 +0800)]
Add more complete ShareTableItemView design
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 11:56:47 +0000 (19:56 +0800)]
Add starter ShareTableItemView XIB
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 11:39:49 +0000 (19:39 +0800)]
Add table to ShareViewControlelr XIB
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 07:07:02 +0000 (15:07 +0800)]
Add fetch method to itemsharescontroller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Feb 2024 06:44:15 +0000 (14:44 +0800)]
Add starter ItemSharesController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 12:29:03 +0000 (20:29 +0800)]
Add starter FPUIExtensionServiceSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 12:23:57 +0000 (20:23 +0800)]
Implement convenience method to acquire FPUIExtensionService in share view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 11:19:41 +0000 (19:19 +0800)]
Add starter FPUIExtensionService protocol
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 10:59:39 +0000 (18:59 +0800)]
Extract display updating upon url acquisition to different method in ShareViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 10:49:58 +0000 (18:49 +0800)]
Set the right filename and icon on share view controller view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 10:48:42 +0000 (18:48 +0800)]
Add domain property to document action view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 10:03:29 +0000 (18:03 +0800)]
Make close button work properly in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:58:39 +0000 (17:58 +0800)]
Store file provider item identifiers in ShareViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:56:57 +0000 (17:56 +0800)]
Add proper design for share view in file provider UI
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:45:20 +0000 (17:45 +0800)]
Properly add share custom action
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:45:03 +0000 (17:45 +0800)]
Remove unused IBActions in DocumentActionViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:44:49 +0000 (17:44 +0800)]
Add convenience method to prepare child view controllers in DocumentActionViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:21:50 +0000 (17:21 +0800)]
Create ShareViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:20:48 +0000 (17:20 +0800)]
Add logging for prepare methods of document action view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 09:18:57 +0000 (17:18 +0800)]
Add logger extension to FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 08:18:52 +0000 (16:18 +0800)]
Add FileProviderUIExt entitlements file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 21 Feb 2024 07:43:07 +0000 (15:43 +0800)]
Build and install FileProviderUIExt via CMake
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 20 Feb 2024 12:03:50 +0000 (20:03 +0800)]
Add new FileProviderUIExt target
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 20:45:43 +0000 (04:45 +0800)]
Merge pull request #6636 from nextcloud/backport/6635/stable-3.13
[stable-3.13] Fix crash when in debug mode when toggling enabled status of an account's virtual files (macOS)
Claudio Cambra [Tue, 16 Apr 2024 19:05:46 +0000 (03:05 +0800)]
Fix crash when in debug mode when toggling enabled status of an account's virtual files (macOS)
Caused by comparing to the wrong thing in the Q_ASSERT *facepalm*
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Wed, 10 Apr 2024 21:53:37 +0000 (23:53 +0200)]
Merge pull request #6519 from nextcloud/ci/fixWindowsCi
fix windows and macOS ci checks
Matthieu Gallien [Wed, 10 Apr 2024 15:27:43 +0000 (17:27 +0200)]
just use the default value for "Packager/RepositoryUrl"
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 8 Mar 2024 08:43:12 +0000 (09:43 +0100)]
disable coverage on windows due to a crash
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 8 Mar 2024 08:41:17 +0000 (09:41 +0100)]
update python for macos and update deployment target
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 7 Mar 2024 20:13:00 +0000 (21:13 +0100)]
install inkscape using same cache as OpenCppCoverage
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 7 Mar 2024 18:33:43 +0000 (19:33 +0100)]
install inkscape via chocolatey after other dependencies
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 7 Mar 2024 17:23:57 +0000 (18:23 +0100)]
switch Craft cache to proper location
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
projects / nextcloud-desktop.git / log