Nextcloud bot [Fri, 27 Sep 2019 03:04:15 +0000 (03:04 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Fri, 27 Sep 2019 02:54:04 +0000 (04:54 +0200)]
Revert "Fix White Window issue on Windows after Qt 5.12.4 upgrade"
This reverts commit
8f616969ab482c72092cb7c037a91292a0f159e1.
Turns out that with the upgrade to the new released Qt 5.12.5 the issue
has been solved by the Qt developers, so this fix becomes obsolete.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Camila Ayres [Thu, 26 Sep 2019 11:20:42 +0000 (13:20 +0200)]
Merge pull request #1443 from nextcloud/enhancement/change-share-menu-wording
Improve wording of the context menu in the file manager extension.
Camila Ayres [Thu, 26 Sep 2019 09:12:43 +0000 (11:12 +0200)]
Merge branch 'master' into enhancement/change-share-menu-wording
Camila Ayres [Thu, 26 Sep 2019 09:04:14 +0000 (11:04 +0200)]
Merge pull request #1445 from nextcloud/fix-white-window
Fix White Window issue on Windows after Qt 5.12.4 upgrade
Michael Schuster [Thu, 26 Sep 2019 03:21:42 +0000 (05:21 +0200)]
Merge branch 'master' into fix-white-window
Nextcloud bot [Thu, 26 Sep 2019 03:03:05 +0000 (03:03 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Thu, 26 Sep 2019 02:59:17 +0000 (04:59 +0200)]
Fix White Window issue on Windows after Qt 5.12.4 upgrade
Qt 5.12.4 seems to introduce a new bug on Windows, causing the settings window
to not be redrawn when re-opening it, for example by clicking at the tray icon.
As a workaround this fix starts a 100 ms timer to be fired once upon
QDialog::showEvent is called.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Wed, 25 Sep 2019 23:41:06 +0000 (01:41 +0200)]
Merge branch 'master' of https://github.com/nextcloud/desktop
Camila San [Wed, 25 Sep 2019 17:54:22 +0000 (19:54 +0200)]
Improve wording of the context menu in the file manager extension.
'Share...' -> 'Share options'
'private link' -> 'internal link'
Removes 'to clipboard' from 'copy link' options.
Signed-off-by: Camila San <hello@camila.codes>
Nextcloud bot [Wed, 25 Sep 2019 03:04:06 +0000 (03:04 +0000)]
[tx-robot] updated from transifex
Camila Ayres [Tue, 24 Sep 2019 14:52:27 +0000 (16:52 +0200)]
Merge pull request #1438 from nextcloud/enhancement/change-share-menu-wording
Changes wording in the share context menu.
Camila San [Tue, 24 Sep 2019 14:25:03 +0000 (16:25 +0200)]
Changes wording in the share context menu.
Instead of only Nextcloud it says "Share via Nextcloud".
Signed-off-by: Camila San <hello@camila.codes>
Camila Ayres [Tue, 24 Sep 2019 10:24:36 +0000 (12:24 +0200)]
Merge pull request #1434 from nextcloud/ui-msg-delete-all-files
UI improvement: Message box: Delete / Keep all files
Camila Ayres [Tue, 24 Sep 2019 10:06:09 +0000 (12:06 +0200)]
Merge branch 'master' into ui-msg-delete-all-files
Nextcloud bot [Tue, 24 Sep 2019 03:07:21 +0000 (03:07 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sat, 21 Sep 2019 03:02:36 +0000 (03:02 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Fri, 20 Sep 2019 14:47:11 +0000 (16:47 +0200)]
UI improvement: Message box: Delete / Keep all files
Signed-off-by: Michael Schuster <michael@schuster.ms>
Nextcloud bot [Fri, 20 Sep 2019 03:04:15 +0000 (03:04 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Thu, 19 Sep 2019 17:51:12 +0000 (19:51 +0200)]
Merge pull request #1427 from mawasak/master
Fix for #1382 "linux client crashes for no discernable reason"
Dominique Fuchs [Thu, 19 Sep 2019 15:05:04 +0000 (17:05 +0200)]
Merge branch 'master' into master
Camila Ayres [Thu, 19 Sep 2019 12:47:40 +0000 (14:47 +0200)]
Finish adding tags to the the exemptLabels list for the stale bot.
Camila Ayres [Thu, 19 Sep 2019 11:36:44 +0000 (13:36 +0200)]
Update exempt labels config for stale bot.
Camila Ayres [Thu, 19 Sep 2019 11:05:14 +0000 (13:05 +0200)]
Add configuration file for funding.
Bounty source link.
Camila Ayres [Thu, 19 Sep 2019 10:59:21 +0000 (12:59 +0200)]
Add configuration file for stale bot.
Nextcloud bot [Thu, 19 Sep 2019 03:06:20 +0000 (03:06 +0000)]
[tx-robot] updated from transifex
Mariusz Wasak [Tue, 17 Sep 2019 16:39:51 +0000 (18:39 +0200)]
Fix for #1382 "linux client crashes for no discernable reason"
There in no "return" in
PropagateUploadFileCommon::slotStartUpload in if (prevModtime != _item-
>_modtime) {... }
There is possibility that
PropagateItemJob::done(status, errorString)
maybe called two times from PropagateUploadFileCommon::slotStartUpload
1. in if (prevModtime != _item->_modtime) {... }
2. in if (fileIsStillChanging(*_item)) {..}
if changes in files are frequent the second call is possible.
This two calls has effect in PropagatorCompositeJob::slotSubJobFinished
and job is removed two times in _runningJobs.remove(i);
(the second time with argumetnt -1 (because first call removed job).
This return was removed in commit
efc039863b096f0e39543001b6cb53937808bebf - by accident I think.
Good simulation is to synchronize firefox profile with frequent page
refresh.
Signed-off-by: Mariusz Wasak <mawasak@gmail.com>
Nextcloud bot [Wed, 18 Sep 2019 03:04:37 +0000 (03:04 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Tue, 17 Sep 2019 15:46:17 +0000 (17:46 +0200)]
Merge branch 'master' of https://github.com/nextcloud/desktop
Nextcloud bot [Tue, 17 Sep 2019 02:55:13 +0000 (02:55 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Mon, 16 Sep 2019 18:26:18 +0000 (20:26 +0200)]
Add warning for failed chown in libsync/propagatedownload.cpp
In addition to PR 1409 generate warnings if chown fails.
See: https://github.com/nextcloud/desktop/pull/1409
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Mon, 16 Sep 2019 18:08:29 +0000 (20:08 +0200)]
Merge pull request #1240 from ivan-cukic/ivan/remote-size-retrieved-race-condition
Race condition in the remote size loading logic
Michael Schuster [Mon, 16 Sep 2019 17:17:00 +0000 (19:17 +0200)]
Merge branch 'master' into ivan/remote-size-retrieved-race-condition
Michael Schuster [Mon, 16 Sep 2019 17:08:10 +0000 (19:08 +0200)]
Merge pull request #1409 from DominiqueFuchs/msvc-warn-audit
Review of msvc/gcc warnings -> code cleanup, prevention of implicit casts, variadic macros
Michael Schuster [Mon, 16 Sep 2019 14:55:42 +0000 (16:55 +0200)]
Merge branch 'master' into msvc-warn-audit
Nextcloud bot [Mon, 16 Sep 2019 02:55:42 +0000 (02:55 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Sun, 15 Sep 2019 17:31:20 +0000 (19:31 +0200)]
Merge pull request #1214 from Thaodan/fix_urlscheme_warning
fix qt warning about registering a URL sheme first.
Dominique Fuchs [Sun, 15 Sep 2019 17:12:22 +0000 (19:12 +0200)]
Merge branch 'master' into fix_urlscheme_warning
Camila Ayres [Sun, 15 Sep 2019 16:52:05 +0000 (18:52 +0200)]
Merge pull request #1149 from nextcloud/bugfixing-slideshow
slideshow buttons
Camila Ayres [Sun, 15 Sep 2019 16:18:46 +0000 (18:18 +0200)]
Merge branch 'master' into bugfixing-slideshow
Camila Ayres [Sun, 15 Sep 2019 15:22:49 +0000 (17:22 +0200)]
Merge pull request #1420 from nextcloud/e2e-csr-transmit
Fixing E2E CSR transmission failure for new connections
Dominique Fuchs [Sun, 15 Sep 2019 10:03:16 +0000 (12:03 +0200)]
Merge branch 'master' into e2e-csr-transmit
Dominique Fuchs [Sun, 15 Sep 2019 09:53:57 +0000 (11:53 +0200)]
Fixed e2e key transmission issue after generation (forgotten content type on sendrequest())
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Sun, 15 Sep 2019 07:56:16 +0000 (09:56 +0200)]
Merge branch 'master' into fix_urlscheme_warning
Nextcloud bot [Sun, 15 Sep 2019 02:57:10 +0000 (02:57 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sat, 14 Sep 2019 02:55:51 +0000 (02:55 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Fri, 13 Sep 2019 18:49:59 +0000 (20:49 +0200)]
Fixed unused var
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Fri, 13 Sep 2019 18:38:16 +0000 (20:38 +0200)]
Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow
Dominique Fuchs [Fri, 13 Sep 2019 18:38:03 +0000 (20:38 +0200)]
Added slight svg transparency as requested in ref issue, fixed bg detection logic
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Fri, 13 Sep 2019 15:30:25 +0000 (17:30 +0200)]
Merge branch 'master' into bugfixing-slideshow
Dominique Fuchs [Fri, 13 Sep 2019 15:26:39 +0000 (17:26 +0200)]
(Maybe) finished implementation of themed wizard buttons and accessibility refinements and thus implementation of helper fct. to retrieve themed QIcons.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Fri, 13 Sep 2019 06:24:02 +0000 (08:24 +0200)]
[WIP] themed button implementation
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Fri, 13 Sep 2019 06:08:39 +0000 (08:08 +0200)]
[WIP] Resource file and include changes as well as new control icons for wizard slide buttons
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Nextcloud bot [Fri, 13 Sep 2019 02:57:35 +0000 (02:57 +0000)]
[tx-robot] updated from transifex
Michael Schuster [Fri, 13 Sep 2019 00:19:22 +0000 (02:19 +0200)]
Merge branch 'master' of https://github.com/nextcloud/desktop
Dominique Fuchs [Thu, 12 Sep 2019 20:00:43 +0000 (22:00 +0200)]
Layout optimizations and tab access for self-hosting link
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Michael Schuster [Thu, 12 Sep 2019 19:25:43 +0000 (21:25 +0200)]
Merge pull request #1414 from nextcloud/fix-double-slashes
Fix double slashes
Dominique Fuchs [Thu, 12 Sep 2019 18:59:03 +0000 (20:59 +0200)]
fix naming for slide navigation, adapted everywhere to be consistent
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Thu, 12 Sep 2019 18:53:40 +0000 (20:53 +0200)]
Restructured layout, as the initial change were too broken (after additions through the last months)
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Thu, 12 Sep 2019 15:56:30 +0000 (17:56 +0200)]
Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow
Dominique Fuchs [Thu, 12 Sep 2019 15:52:31 +0000 (17:52 +0200)]
Fixed wrong resource paths
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Thu, 12 Sep 2019 15:09:26 +0000 (17:09 +0200)]
Merge branch 'master' into bugfixing-slideshow
Dominique Fuchs [Thu, 12 Sep 2019 14:43:54 +0000 (16:43 +0200)]
Merge branch 'bugfixing-slideshow' of https://github.com/nextcloud/desktop into bugfixing-slideshow
Dominique Fuchs [Thu, 12 Sep 2019 14:43:24 +0000 (16:43 +0200)]
Added newly created next/prev svg's and fixed reduntant layout parts in wizard
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Michael Schuster [Thu, 12 Sep 2019 03:09:21 +0000 (05:09 +0200)]
Merge branch 'master' into fix-double-slashes
Nextcloud bot [Thu, 12 Sep 2019 02:55:19 +0000 (02:55 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Wed, 11 Sep 2019 20:56:34 +0000 (22:56 +0200)]
Merge branch 'master' into ivan/remote-size-retrieved-race-condition
Dominique Fuchs [Wed, 11 Sep 2019 20:17:57 +0000 (22:17 +0200)]
Merge branch 'master' into bugfixing-slideshow
Michael Schuster [Wed, 11 Sep 2019 15:31:16 +0000 (17:31 +0200)]
fix comment typo
Signed-off-by: Michael Schuster <michael@schuster.ms>
Michael Schuster [Wed, 11 Sep 2019 15:27:49 +0000 (17:27 +0200)]
Merge branch 'master' of https://github.com/nextcloud/desktop
Nextcloud bot [Wed, 11 Sep 2019 03:05:21 +0000 (03:05 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Tue, 10 Sep 2019 14:15:43 +0000 (16:15 +0200)]
Merge pull request #916 from nextcloud/icons
Remove outdated (and unused) icons
Dominique Fuchs [Tue, 10 Sep 2019 12:36:40 +0000 (14:36 +0200)]
Merge branch 'master' into icons
Dominique Fuchs [Tue, 10 Sep 2019 12:31:30 +0000 (14:31 +0200)]
Merge pull request #719 from tuxmaster5000/owncloud
Rename owncloud tests to nextcloud
Dominique Fuchs [Tue, 10 Sep 2019 11:11:02 +0000 (13:11 +0200)]
Merge branch 'master' into owncloud
Dominique Fuchs [Tue, 10 Sep 2019 09:38:59 +0000 (11:38 +0200)]
Merge pull request #1039 from javierllorente/master
Add sync date next to "Synchronized with local folder"
Dominique Fuchs [Tue, 10 Sep 2019 09:03:39 +0000 (11:03 +0200)]
Merge branch 'master' into owncloud
Dominique Fuchs [Tue, 10 Sep 2019 08:17:37 +0000 (10:17 +0200)]
Merge branch 'master' into master
Dominique Fuchs [Tue, 10 Sep 2019 07:46:24 +0000 (09:46 +0200)]
Merge pull request #1231 from Zottel92/issue1216/IgnoreEmacsRecoveryFiles
issue1216: added sync-exclude entry for emacs recovery files
Dominique Fuchs [Tue, 10 Sep 2019 07:02:55 +0000 (09:02 +0200)]
Merge branch 'master' into issue1216/IgnoreEmacsRecoveryFiles
Nextcloud bot [Tue, 10 Sep 2019 03:06:52 +0000 (03:06 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Mon, 9 Sep 2019 19:46:39 +0000 (21:46 +0200)]
Merge branch 'master' into issue1216/IgnoreEmacsRecoveryFiles
Dominique Fuchs [Mon, 9 Sep 2019 18:16:52 +0000 (20:16 +0200)]
Merge branch 'master' into msvc-warn-audit
Dominique Fuchs [Mon, 9 Sep 2019 18:06:32 +0000 (20:06 +0200)]
fixed wrongly assigned pointer, didn't recognize class
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 17:35:30 +0000 (19:35 +0200)]
Use -Wno-gnu-zero-variadic-macro-arguments only for Clang
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 17:14:19 +0000 (19:14 +0200)]
Q_UNUSED for atm unused parameters
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 17:09:38 +0000 (19:09 +0200)]
Declared Q_UNUSED for as-of-now unused parameters.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:52:36 +0000 (18:52 +0200)]
Prevented warning regarding operator precedence - enhanced clarity by adding parentheses
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:46:25 +0000 (18:46 +0200)]
removed reduntant /* within a comment
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:44:29 +0000 (18:44 +0200)]
Remove unnecessary argument
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:40:23 +0000 (18:40 +0200)]
Prevent use of uninitialized folder pointer.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:22:48 +0000 (18:22 +0200)]
Added forgotten case when parsing log through gui. LockedFiles were not communicated.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:16:44 +0000 (18:16 +0200)]
initialize _modtime to prevent undefined usage
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 16:06:29 +0000 (18:06 +0200)]
Use return type to prevent warning and determine chown success. Added TODO
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Mon, 9 Sep 2019 11:46:46 +0000 (13:46 +0200)]
Removed disabling of msvc warning to prevent generating a unknown option for other compilers in turn. Now detect specifically GCC in ifdef
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Nextcloud bot [Mon, 9 Sep 2019 03:06:29 +0000 (03:06 +0000)]
[tx-robot] updated from transifex
Dominique Fuchs [Sun, 8 Sep 2019 18:00:48 +0000 (20:00 +0200)]
Merge branch 'master' into msvc-warn-audit
Dominique Fuchs [Sun, 8 Sep 2019 17:46:08 +0000 (19:46 +0200)]
Moved macro definition due to timing issues while compiling when relying on header inheritance
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Sun, 8 Sep 2019 17:37:56 +0000 (19:37 +0200)]
Conditional (based on Qt version) use of 'horizontalAdvance' to provide better UI experience. See https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Dominique Fuchs [Sun, 8 Sep 2019 17:22:40 +0000 (19:22 +0200)]
commit 222b2d did the trick. now streamlined use of https://doc.qt.io/qt-5/qtglobal.html#QT_VERSION_CHECK
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>