Joey Hess [Fri, 28 Aug 2020 18:28:42 +0000 (14:28 -0400)]
test: Stop gpg-agent daemons that are started for the test framework's gpg key
They normally shutdown when the GNUPGHOME directory is deleted, but on
NFS they keep the directory from being deleted. And also, this avoids
a number of them piling up while the test suite is running.
Joey Hess [Fri, 28 Aug 2020 18:07:31 +0000 (14:07 -0400)]
need lts-13.11 after all
the newer one fails at the end of build with an unavailable libc symbol.
Joey Hess [Fri, 28 Aug 2020 17:59:00 +0000 (13:59 -0400)]
further changes to get back to last working build state on OSX
Seems 13.11 was not being used for a while, but 14.27 works.
For some reason, stack was getting confused when I set the magicmime
flag on the command line, but setting it in stack.yaml didn't confuse
it. Ugh.
Joey Hess [Fri, 28 Aug 2020 17:55:54 +0000 (13:55 -0400)]
close
Joey Hess [Fri, 28 Aug 2020 17:54:42 +0000 (13:54 -0400)]
close
Joey Hess [Fri, 28 Aug 2020 17:53:15 +0000 (13:53 -0400)]
close
Joey Hess [Fri, 28 Aug 2020 17:01:56 +0000 (13:01 -0400)]
fix build
Joey Hess [Fri, 28 Aug 2020 16:57:25 +0000 (12:57 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Fri, 28 Aug 2020 16:53:51 +0000 (12:53 -0400)]
add stack.yaml for OSX autobuilder
Unfortunately, the autobuilder is using an old version of OSX, and
cannot use ghc newer than the one in lts-13.11. Newer ghc versions use a
libc symbol that is not available.
Since the main stack.yaml has been updated to a newer lts, and just
substituting in lts-13.11 no longer works due to other dependency
issues, it's simplest to use a separate one for the OSX build.
Hopefully this is temporary, and the autobuilder gets updated.
Joey Hess [Fri, 28 Aug 2020 15:17:30 +0000 (11:17 -0400)]
remove build warning about old process version
The timeout features never materialized.
Joey Hess [Fri, 28 Aug 2020 15:16:51 +0000 (11:16 -0400)]
remove unused imports
jcohen@8a78f6f9e293f581b96cd43634328c0e9de6b36e [Fri, 28 Aug 2020 02:12:57 +0000 (02:12 +0000)]
jcohen@8a78f6f9e293f581b96cd43634328c0e9de6b36e [Fri, 28 Aug 2020 02:12:15 +0000 (02:12 +0000)]
Ilya_Shlyakhter [Fri, 28 Aug 2020 01:02:50 +0000 (01:02 +0000)]
Added a comment
cardoso-neto [Fri, 28 Aug 2020 00:20:31 +0000 (00:20 +0000)]
Added a comment
Ilya_Shlyakhter [Thu, 27 Aug 2020 15:32:09 +0000 (15:32 +0000)]
Added a comment: understanding why standalone conda package gets preferred
Joey Hess [Wed, 26 Aug 2020 17:09:47 +0000 (13:09 -0400)]
comment
Joey Hess [Wed, 26 Aug 2020 17:06:14 +0000 (13:06 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Wed, 26 Aug 2020 17:05:34 +0000 (13:05 -0400)]
Display a message when git-annex has to wait for a pid lock file held by another process
Joey Hess [Wed, 26 Aug 2020 16:20:56 +0000 (12:20 -0400)]
refactor out Annex.PidLock
yarikoptic [Wed, 26 Aug 2020 01:26:29 +0000 (01:26 +0000)]
Added a comment: dreaming of everyone using CoW FSs
Joey Hess [Tue, 25 Aug 2020 21:43:50 +0000 (17:43 -0400)]
comment
Joey Hess [Tue, 25 Aug 2020 18:57:25 +0000 (14:57 -0400)]
add gitAnnexChildProcess and use instead of incorrect use of runsGitAnnexChildProcess
Fixes reversion in 8.
20200617 that made annex.pidlock being enabled result
in some commands stalling, particularly those needing to autoinit.
Renamed runsGitAnnexChildProcess to make clearer where it should be
used.
Arguably, it would be better to have a way to make any process git-annex
runs have the env var set. But then it would need to take the pid lock
when running any and all processes, and that would be a problem when
git-annex runs two processes concurrently. So, I'm left doing it ad-hoc
in places where git-annex really does run a child process, directly
or indirectly via a particular git command.
Joey Hess [Tue, 25 Aug 2020 18:47:17 +0000 (14:47 -0400)]
wording
Joey Hess [Tue, 25 Aug 2020 18:31:43 +0000 (14:31 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 25 Aug 2020 18:31:15 +0000 (14:31 -0400)]
analysis
kyle [Tue, 25 Aug 2020 17:51:43 +0000 (17:51 +0000)]
Added a comment
Joey Hess [Tue, 25 Aug 2020 17:40:52 +0000 (13:40 -0400)]
fix comment format
Joey Hess [Tue, 25 Aug 2020 17:34:37 +0000 (13:34 -0400)]
document that annex.thin beats annex.hardlink
Joey Hess [Tue, 25 Aug 2020 17:01:03 +0000 (13:01 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 25 Aug 2020 16:56:38 +0000 (12:56 -0400)]
addurl --file youtube-dl reversion fix
addurl: Fix reversion in 7.
20190322 that made --file not be honored when
youtube-dl was used to download media.
8758f9c561 was on the right track, but missed that | otherwise prevented
the code it added from being used.
Also, refactored out a common function.
This commit was sponsored by Graham Spencer on Patreon.
yarikoptic [Tue, 25 Aug 2020 16:27:11 +0000 (16:27 +0000)]
Added a comment: pidlock to blame!
kyle [Tue, 25 Aug 2020 15:20:46 +0000 (15:20 +0000)]
Added a comment
yarikoptic [Tue, 25 Aug 2020 15:07:21 +0000 (15:07 +0000)]
initial report on hardlink in thin mode
kyle [Tue, 25 Aug 2020 15:02:45 +0000 (15:02 +0000)]
Added a comment: comment: works on my end
yarikoptic [Tue, 25 Aug 2020 15:01:19 +0000 (15:01 +0000)]
Added a comment
yarikoptic [Tue, 25 Aug 2020 14:47:38 +0000 (14:47 +0000)]
initial report on get being stuck
yarikoptic [Tue, 25 Aug 2020 03:12:16 +0000 (03:12 +0000)]
initial report on gpgtmp .nfs busy files
Joey Hess [Mon, 24 Aug 2020 18:11:37 +0000 (14:11 -0400)]
stack.yaml: Updated to lts-16.10
Needs stack version 2.3 to build, which has only recently made it into
debian unstable.
This commit was sponsored by Jake Vosloo on Patreon.
kyle [Thu, 20 Aug 2020 20:34:26 +0000 (20:34 +0000)]
Added a comment
cardoso-neto [Thu, 20 Aug 2020 20:08:07 +0000 (20:08 +0000)]
Added a comment
cardoso-neto [Thu, 20 Aug 2020 18:36:47 +0000 (18:36 +0000)]
Added a comment: Rationale behind deleting and readding the symlinks on a move or rename
kyle [Wed, 19 Aug 2020 17:54:11 +0000 (17:54 +0000)]
Added a comment: thanks
Joey Hess [Wed, 19 Aug 2020 16:20:07 +0000 (12:20 -0400)]
fix hang if external program is not available
startExternal' throws an exception, which left the externalAsync TMVar
empty, so the next try to use it would hang.
Joey Hess [Tue, 18 Aug 2020 19:47:49 +0000 (15:47 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com
kyle [Tue, 18 Aug 2020 17:44:01 +0000 (17:44 +0000)]
Joey Hess [Sat, 15 Aug 2020 19:53:35 +0000 (15:53 -0400)]
avoid using MonadFail in ParseDuration
There's no instance for Either String, so that makes it not as useful as
it could be, so instead just return an Either String.
Joey Hess [Sat, 15 Aug 2020 18:33:18 +0000 (14:33 -0400)]
fix some warnings
Joey Hess [Fri, 14 Aug 2020 20:01:39 +0000 (16:01 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com
Joey Hess [Fri, 14 Aug 2020 20:00:49 +0000 (16:00 -0400)]
Merge branch 'asyncexternal'
Joey Hess [Fri, 14 Aug 2020 19:38:31 +0000 (15:38 -0400)]
Display warning when external special remote does not start up properly, or is not usable
I'm sure this used to work, but somewhere along the line something or
things (getCost and getAvailability I think, probably others)
started catching the exception and not displaying it. So, show warnings.
Joey Hess [Fri, 14 Aug 2020 19:24:34 +0000 (15:24 -0400)]
async extension done
cardoso-neto [Fri, 14 Aug 2020 18:55:18 +0000 (18:55 +0000)]
Added a comment: Having cutting edge packages with conda is not that straighforward.
Joey Hess [Fri, 14 Aug 2020 18:40:30 +0000 (14:40 -0400)]
switch to TMVars for thread safety when using the async extension
TVars were not updated atomically, which was ok when each thread got its
own External that was the only thing using these TVars. But, with the
async extension, several External instances can share the same var, so
it needs to be a TMVar to avoid read/write conflicts.
In particular, this makes PREPARE only be sent once.
Joey Hess [Fri, 14 Aug 2020 18:24:46 +0000 (14:24 -0400)]
one jobid per thread
And, relay ERROR on to all listening threads.
Ilya_Shlyakhter [Fri, 14 Aug 2020 02:59:12 +0000 (02:59 +0000)]
Added a comment
Joey Hess [Fri, 14 Aug 2020 00:18:06 +0000 (20:18 -0400)]
rethought the async protocol some more
Moving jobid generation to the git-annex side lets it be simplified a
lot.
Note that it will also be possible to generate one jobid per connection,
rather than a new job per request. That will make overflow not an issue,
and will avoid some work, and will simplify some of the code.
cardoso-neto [Fri, 14 Aug 2020 00:08:29 +0000 (00:08 +0000)]
Added a comment: Ugly message when installing git-annex through conda
Joey Hess [Thu, 13 Aug 2020 20:11:38 +0000 (16:11 -0400)]
async proto fully tested and working
Including with a concurrent capable remote program.
However, this is not quite ready to merge, there's a TODO in the code.
Joey Hess [Thu, 13 Aug 2020 19:49:43 +0000 (15:49 -0400)]
async proto basically working
Simplified the protocol by removing END-ASYNC.
There's a STM crash when a non-async protocol message is sent, which
needs to be fixed.
Joey Hess [Wed, 12 Aug 2020 20:27:40 +0000 (16:27 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com
Joey Hess [Wed, 12 Aug 2020 20:27:02 +0000 (16:27 -0400)]
branch
Joey Hess [Wed, 12 Aug 2020 20:25:53 +0000 (16:25 -0400)]
further work on external async relay
Joey Hess [Wed, 12 Aug 2020 19:54:30 +0000 (15:54 -0400)]
relayer receive loop is done
Receive loop looks right. Still need the send loop.
And, a complication is that some messages git-annex
sends need to be wrapped in REPLY_ASYNC, while others
do not. So will probably need to split externalSend
into two.
Joey Hess [Wed, 12 Aug 2020 19:17:53 +0000 (15:17 -0400)]
wip external remote async protocol extension
Joey Hess [Wed, 12 Aug 2020 19:12:09 +0000 (15:12 -0400)]
rethought this protocol again
Now that I've started implementation, I see it's really necessary that
every message the special remote sends use the protocol, otherwise
nasty edge cases abound.
Joey Hess [Wed, 12 Aug 2020 16:30:45 +0000 (12:30 -0400)]
generalized ExternalState to not be limited to a ExternalAddonProcess
Idea is for ASYNC extension, it will instead contain methods that communicate
with the thread that handles all communication with the external process.
Joey Hess [Wed, 12 Aug 2020 16:04:12 +0000 (12:04 -0400)]
types for async protocol extension
renamed AsyncMessage to ExceptionalMessage to make way for this new
extension.
Bug: addurl --file not working as expected with youtube-dl
raf@4b53f20230978a98fc814b6e5565d9a30567a4f8 [Wed, 12 Aug 2020 12:54:46 +0000 (12:54 +0000)]
removed
raf@4b53f20230978a98fc814b6e5565d9a30567a4f8 [Wed, 12 Aug 2020 12:47:19 +0000 (12:47 +0000)]
cardoso-neto [Tue, 11 Aug 2020 22:10:27 +0000 (22:10 +0000)]
Added a comment
Joey Hess [Tue, 11 Aug 2020 20:42:37 +0000 (16:42 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com
Joey Hess [Tue, 11 Aug 2020 20:42:09 +0000 (16:42 -0400)]
draft async extension
cardoso-neto [Tue, 11 Aug 2020 20:23:25 +0000 (20:23 +0000)]
Ilya_Shlyakhter [Tue, 11 Aug 2020 20:19:49 +0000 (20:19 +0000)]
Added a comment: strange conda install behavior
cardoso-neto [Tue, 11 Aug 2020 19:57:06 +0000 (19:57 +0000)]
Added a comment
Joey Hess [Tue, 11 Aug 2020 18:01:22 +0000 (14:01 -0400)]
close
Ilya_Shlyakhter [Tue, 11 Aug 2020 16:03:40 +0000 (16:03 +0000)]
added note on installing the standalone git-annex distribution with conda
Ilya_Shlyakhter [Tue, 11 Aug 2020 15:51:28 +0000 (15:51 +0000)]
Added a comment: checking the conda-forge recipe
cardoso-neto [Tue, 11 Aug 2020 13:23:00 +0000 (13:23 +0000)]
Added a comment: Great tip about conda.
Ilya_Shlyakhter [Tue, 11 Aug 2020 00:43:51 +0000 (00:43 +0000)]
Added a comment: please keep the hackage tarballs
Joey Hess [Mon, 10 Aug 2020 23:22:55 +0000 (19:22 -0400)]
add news item for git-annex 8.
20200810
Joey Hess [Mon, 10 Aug 2020 22:46:44 +0000 (18:46 -0400)]
comment
Joey Hess [Mon, 10 Aug 2020 22:42:00 +0000 (18:42 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com
Joey Hess [Mon, 10 Aug 2020 22:41:02 +0000 (18:41 -0400)]
fix osxapp build issue
need to build git-annex 1st, otherwise otool can't run
Ilya_Shlyakhter [Mon, 10 Aug 2020 21:52:32 +0000 (21:52 +0000)]
Added a comment
kyle [Mon, 10 Aug 2020 21:34:46 +0000 (21:34 +0000)]
Added a comment
Ilya_Shlyakhter [Mon, 10 Aug 2020 21:14:05 +0000 (21:14 +0000)]
Added a comment: full source tarballs for specific releases?
Joey Hess [Mon, 10 Aug 2020 20:49:09 +0000 (16:49 -0400)]
fix build failure on i386-ancient
Standalone: tmp/git-annex.linux/usr/lib/i386-linux-gnu/i686: renameFile: inappropriate type (is a directory)
Joey Hess [Mon, 10 Aug 2020 20:33:58 +0000 (16:33 -0400)]
improve slightly
This probably avoids the situation that caused the exception to be
thrown. It also makes sure that both threads end up canceled in the end,
while before the exception from wait outt could have caused errt to
never be waited on.
Joey Hess [Mon, 10 Aug 2020 20:18:47 +0000 (16:18 -0400)]
discard any exception thrown while trying to kill worker threads
Since there's a race here, and since Kyle saw an exception leak out,
which I have not been able to reproduce that. See my comment for what
I think might be going on.
Note that, I used tryNonAsync, because it seems a later tryNonAsync
caught the exception. I don't actually understand how it did, as I
understand exception classification, it's the data type, not the way it
was thrown. One possibility is that the async exception may have been wrapped
in some other, non-async exception, and Show displayed it the same way.
Joey Hess [Mon, 10 Aug 2020 20:18:35 +0000 (16:18 -0400)]
reorder
Joey Hess [Mon, 10 Aug 2020 20:03:59 +0000 (16:03 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com
Joey Hess [Mon, 10 Aug 2020 20:03:46 +0000 (16:03 -0400)]
comment
kyle [Mon, 10 Aug 2020 19:48:03 +0000 (19:48 +0000)]
Added a comment
Joey Hess [Mon, 10 Aug 2020 19:38:31 +0000 (15:38 -0400)]
fix order
Joey Hess [Mon, 10 Aug 2020 19:37:54 +0000 (15:37 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com