Claudio Cambra [Thu, 21 Nov 2024 17:45:50 +0000 (01:45 +0800)]
Rename horizontalLayout with duplicate name
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 17:45:37 +0000 (01:45 +0800)]
Fix broken general setting UI file
Looks like it was originally caused at some point by a bad rebase
conflict resolution
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 22 Nov 2024 02:52:48 +0000 (02:52 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 18:43:19 +0000 (02:43 +0800)]
Merge pull request #7548 from nextcloud/bugfix/mac-crafter-woes-pt-100000
Only sign main executable at end (mac-crafter)
Claudio Cambra [Thu, 21 Nov 2024 18:30:04 +0000 (02:30 +0800)]
Skip main executable during first binary codesign round
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 18:29:49 +0000 (02:29 +0800)]
Add ability to skip certain files in recursive codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 16:58:12 +0000 (00:58 +0800)]
Merge pull request #7545 from nextcloud/bugfix/final-final-mc-fix-pls
Fix mac-crafter codesign executable check path building
Claudio Cambra [Thu, 21 Nov 2024 16:36:25 +0000 (00:36 +0800)]
Ensure we sign the app bundle's main executable last
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 16:36:12 +0000 (00:36 +0800)]
Only define enumeratedItemPath once
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 15:09:13 +0000 (23:09 +0800)]
Ensure path passed to codesigning is absolute when using mac-crafter codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 15:08:38 +0000 (23:08 +0800)]
Do not take current dir pth for filemanager for recursive codesign executable path check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:32:18 +0000 (12:32 +0100)]
Merge pull request #7540 from nextcloud/ci/fixWindowsAutomatedTests
remove this call that is probably useless and crashing tests
Matthieu Gallien [Thu, 21 Nov 2024 09:37:50 +0000 (10:37 +0100)]
remove this call that is probably useless and crashing tests
we initialize all colors in the palette, so this init methos is most
probably not doing anything useful
crashes when doing in automated tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:31:32 +0000 (12:31 +0100)]
Merge pull request #5433 from nextcloud/feature/disable-talk-notifications
Feature/disable talk chat notifications
Claudio Cambra [Mon, 18 Nov 2024 08:15:31 +0000 (16:15 +0800)]
Remove unneeded check for DnD status when showing desktop talk notification
The server will not deliver it anyway
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Jun 2024 09:24:42 +0000 (17:24 +0800)]
Do not use const for POD type in setShowCallNotifications declaration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 13:15:18 +0000 (14:15 +0100)]
Only notify talk chat notifications if this is enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 12:56:20 +0000 (13:56 +0100)]
Add the chat notification toggle setting logic in generalsettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 12:47:52 +0000 (13:47 +0100)]
Add setting for showing chat notifications to configfile
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 12:15:01 +0000 (13:15 +0100)]
Add checkbox to disable general talk notifications in general settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:07:07 +0000 (12:07 +0100)]
Merge pull request #7532 from nextcloud/bugfix/narrowDownPermissionsDuringSync
Bugfix/narrow down permissions during sync
Matthieu Gallien [Thu, 21 Nov 2024 10:52:04 +0000 (11:52 +0100)]
better logs and factor common code in folder permissions handling
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 20 Nov 2024 13:09:08 +0000 (14:09 +0100)]
ensure no any user writable permissions in Nextcloud sync folder
past versions may have wrongly set the write permissions for other users
(UNIX style permissions)
remove this under the hypothesis that newly created files or folders
gets more restrictive permissions and that past files or folders should
be updated to get the same permissions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 20 Nov 2024 11:03:37 +0000 (12:03 +0100)]
ensure folder permissions are read-only when needed
a folder item must be set read-only if files or sub-folders cannot be
created
a folder item must be set read-write in all other situations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:06:19 +0000 (12:06 +0100)]
Merge pull request #7495 from nextcloud/feature/smartFlushOfLogs
flush logs every 5 lines written
Matthieu Gallien [Wed, 13 Nov 2024 10:54:36 +0000 (11:54 +0100)]
flush logs every 5 lines written
should help not loosing too much logs in case of a crash or similar not
nominal stop of the client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:04:58 +0000 (12:04 +0100)]
Merge pull request #7517 from nextcloud/feature/noDefaultShareLinks
Feature/no default share links
Matthieu Gallien [Tue, 19 Nov 2024 14:58:18 +0000 (15:58 +0100)]
improve files explorer context menu by removing obsolete commands
remove any commands related to publi share links because they either got
replaced by the use of the share dialog or are better achieved by
showing the share dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 10:52:33 +0000 (18:52 +0800)]
Merge pull request #7541 from nextcloud/bugfix/final-mac-crafter-fix-istg
Fix mac-crafter codesign executable detection
Claudio Cambra [Thu, 21 Nov 2024 10:43:58 +0000 (18:43 +0800)]
Do not do final bundle codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 10:28:19 +0000 (18:28 +0800)]
Do not rely on FileManager's isExecutableFile, check manually for Mach-O executable type
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 10:27:52 +0000 (18:27 +0800)]
Allow using an external task for running commands in mac-crafter run command
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 09:14:51 +0000 (10:14 +0100)]
Merge pull request #7512 from nextcloud/bugfix/search-view-on-focus
Pull up the unified search view immediately on unified search field focus
Claudio Cambra [Tue, 19 Nov 2024 06:53:51 +0000 (14:53 +0800)]
Unify definition of unified seach placeholder views fonts
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 06:53:23 +0000 (14:53 +0800)]
Clean up ids of internal components of placeholder views
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 06:03:20 +0000 (14:03 +0800)]
Place unified search placeholder view in main tray window view when in focus and no text is entered
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 06:02:58 +0000 (14:02 +0800)]
Add a UnifiedSearchPlaceholderView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 06:02:00 +0000 (14:02 +0800)]
On escape pressed of unified search placeholder view, diable activeSearchFocus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 05:43:59 +0000 (13:43 +0800)]
Fix keyboard tab behaviour when focus reaches unified search bar
Do not activate search if the focus reason is tab as otherwise the user
will never be able to access elements that depend on search being
inactive via the keyboard
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 05:37:47 +0000 (13:37 +0800)]
Add a mouse area to allow de-focusing the unified search text field on click elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 05:37:20 +0000 (13:37 +0800)]
Make the unified search input being focused a valid active reason
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 08:58:19 +0000 (09:58 +0100)]
Merge pull request #7375 from nextcloud/bugfix/filetag-fetching-path
Fix file tag fetching for files in sync folders that have non-root remote target
Claudio Cambra [Thu, 21 Nov 2024 07:39:27 +0000 (15:39 +0800)]
Remove unused includes in filetagmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 07:32:07 +0000 (15:32 +0800)]
Add missing nodiscards in folder methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 23 Oct 2024 06:53:37 +0000 (14:53 +0800)]
Move setup of server relative path used in FileTagModel into FileDetails
This fixes the build breakages in the file tag model tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Oct 2024 06:57:22 +0000 (14:57 +0800)]
Ensure we are checking for tags in correct server path regardless of the particular local path
Fixes issues with users who are using remote non-root sync folders
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Oct 2024 06:56:14 +0000 (14:56 +0800)]
Simply pass AccountPtr to updateFileTagModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Oct 2024 06:54:34 +0000 (14:54 +0800)]
Store fetched folder as private member in filedetails
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Oct 2024 06:52:14 +0000 (14:52 +0800)]
Mark non-const getters in Folder definition as const
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 08:26:39 +0000 (16:26 +0800)]
Merge pull request #7537 from nextcloud/bugfix/exec-detection-mac-crafter
Do not treat bundles as executables in codesign check
Claudio Cambra [Thu, 21 Nov 2024 08:24:52 +0000 (16:24 +0800)]
Do not treat bundles as executables in codesign check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 07:41:41 +0000 (08:41 +0100)]
Merge pull request #7498 from nextcloud/bugfix/ui-polish
Polish tray window interface
Claudio Cambra [Thu, 21 Nov 2024 06:37:29 +0000 (14:37 +0800)]
Move tray window header component into separate file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 06:22:24 +0000 (14:22 +0800)]
Move current account header button definition into own file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 06:11:41 +0000 (14:11 +0800)]
Do not load caret on current user button if the button had a non-null indicator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 05:51:29 +0000 (13:51 +0800)]
Remove unused properties from UserLine
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 05:29:45 +0000 (13:29 +0800)]
Remove rectangle aboce folder state indicator background in tray folders menu button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:58:57 +0000 (11:58 +0800)]
Reduce size of tray window header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:51:20 +0000 (11:51 +0800)]
Fix colour of indicator outlines in tray header elements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f bgc
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:45:43 +0000 (11:45 +0800)]
Remove unused style measurements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:10:16 +0000 (11:10 +0800)]
Use constexpr for accentcolor adjustment value
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:07:04 +0000 (11:07 +0800)]
Give sync progress bar expected fill colour
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f p
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:02:46 +0000 (11:02 +0800)]
Use accentColor rather than header colour where appropriate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 03:02:21 +0000 (11:02 +0800)]
Remove unused colours from style
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 02:50:51 +0000 (10:50 +0800)]
Move remaining uses of secondary text color to use palette midlight, remove this property froms style
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 02:41:28 +0000 (10:41 +0800)]
Use standard text colour in ncinputtextedit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 02:37:29 +0000 (10:37 +0800)]
Remove background color from Style, use palette base in its place
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 02:36:50 +0000 (10:36 +0800)]
Remove now unused hover colors
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 02:31:30 +0000 (10:31 +0800)]
Remove menuBorder Style variable, just use palette (as we have already done in parts)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Nov 2024 02:25:27 +0000 (10:25 +0800)]
Fix search bar separator in tray window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 15 Nov 2024 10:30:29 +0000 (18:30 +0800)]
Do not use magic numnbers for spacing of sync status icon
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 15 Nov 2024 10:23:02 +0000 (18:23 +0800)]
Fix displaying of busy indicator on share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 15 Nov 2024 10:21:15 +0000 (18:21 +0800)]
Fix label alignments on share view checkboxes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 15 Nov 2024 09:19:53 +0000 (17:19 +0800)]
Fix sizing of share details page buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 15 Nov 2024 09:13:14 +0000 (17:13 +0800)]
Remove custom button QML items
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 25 Nov 2022 11:53:56 +0000 (12:53 +0100)]
Replace use of CustomButton with standard Button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 25 Nov 2022 12:06:16 +0000 (13:06 +0100)]
Decouple emoji field button from UserStatusSelectorButton
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 15 Nov 2024 08:07:16 +0000 (16:07 +0800)]
Fix placeholderTextColor in user status selector text field
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 24 Nov 2022 14:18:53 +0000 (15:18 +0100)]
Simplify layout and fix alignments, sizings, and layouts of items with native theming in unified search input container
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 11:15:01 +0000 (19:15 +0800)]
Respect showDismissButton
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 11:12:29 +0000 (19:12 +0800)]
Fix spacing of activity item buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 10:59:20 +0000 (18:59 +0800)]
Fix icons in share delegate buttons being uncentered
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 10:58:41 +0000 (18:58 +0800)]
Fix borders for share details page footer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 10:51:48 +0000 (18:51 +0800)]
Fix sync status separator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 10:51:02 +0000 (18:51 +0800)]
Fix components for share details page footer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 10:50:46 +0000 (18:50 +0800)]
Fix colours for some more components
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 10:24:01 +0000 (18:24 +0800)]
Fix some more colours
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:44:17 +0000 (17:44 +0800)]
Make sizing of addacount button more reasonable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:44:01 +0000 (17:44 +0800)]
Improve spacings of userline
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:23:11 +0000 (17:23 +0800)]
Use standard icon property to set icon for userline
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:23:01 +0000 (17:23 +0800)]
Use standard icon for addAccountButton, fixing sizing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:20:31 +0000 (17:20 +0800)]
Wrap the instantiated userLine components in a menu item
Get proper handling of hover and so on this way
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:19:37 +0000 (17:19 +0800)]
Remove commented-out hover effect component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:19:25 +0000 (17:19 +0800)]
Remove internal list view and scrollview from apps menu
This was breaking proper hover handling and selection
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:18:46 +0000 (17:18 +0800)]
Remove custom background from menus and menu buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 09:12:54 +0000 (17:12 +0800)]
Use palette base colour for windows (we always display item views)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 08:46:44 +0000 (16:46 +0800)]
Fix background colour for tray window (should be base as we only show item views)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 14 Nov 2024 08:18:59 +0000 (16:18 +0800)]
Bring back coloured header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 05:18:28 +0000 (13:18 +0800)]
Merge pull request #7535 from nextcloud/bugfix/codesign-mac-crafter-again
Fix recursive codesign steps and final bundle codesign in mac-crafter
Claudio Cambra [Thu, 21 Nov 2024 05:16:45 +0000 (13:16 +0800)]
Do a codesign of the app bundle itself as final step
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
projects / nextcloud-desktop.git / log