Nextcloud bot [Thu, 3 Nov 2022 03:19:28 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 2 Nov 2022 03:21:25 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Tue, 1 Nov 2022 09:41:00 +0000 (10:41 +0100)]
Merge pull request #5067 from nextcloud/bugfix/e2e-do-not-generate-keys-without-request
E2EE. Do not generate keypair without user request.
allexzander [Fri, 14 Oct 2022 15:47:46 +0000 (18:47 +0300)]
E2EE. Do not generate keypair without user request.
Signed-off-by: allexzander <blackslayer4@gmail.com>
Nextcloud bot [Tue, 1 Nov 2022 03:20:33 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Mon, 31 Oct 2022 17:41:51 +0000 (18:41 +0100)]
Merge pull request #4929 from nextcloud/feature/qml-file-details
Add a new file details window, unify file activity and sharing
Claudio Cambra [Sun, 30 Oct 2022 11:56:11 +0000 (12:56 +0100)]
Change liveDialog to nullDialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 29 Oct 2022 17:24:54 +0000 (19:24 +0200)]
Update Kirigami WheelHandler to upstream v5.99.0
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 18 Oct 2022 18:31:32 +0000 (20:31 +0200)]
Add testing for SortedShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 18 Oct 2022 15:15:10 +0000 (17:15 +0200)]
Moved all server mocking code for share model test to independent ShareTestUtils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 17 Oct 2022 08:37:14 +0000 (10:37 +0200)]
Add testing for ShareeModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 6 Oct 2022 11:21:33 +0000 (13:21 +0200)]
Add a suite of tests for ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Test ShareModel error handling
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Improve testing of user/group shares in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Add testing for maximum share expire date enforcement in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 17 Oct 2022 19:49:12 +0000 (21:49 +0200)]
Filter out sharees that already have active shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Oct 2022 21:16:10 +0000 (23:16 +0200)]
Improve server error handling in the ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 3 Oct 2022 14:57:02 +0000 (16:57 +0200)]
Check for state of file record retrieval in fileactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 3 Oct 2022 08:47:27 +0000 (10:47 +0200)]
Fix default date parser handling of timezones
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 15:02:49 +0000 (17:02 +0200)]
Renamed _userStoppedTypingTimer to searchRateLimitingTimer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 15:00:31 +0000 (17:00 +0200)]
Add trailing comma to shareemodel enum
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 14:49:28 +0000 (16:49 +0200)]
Replace manual index bound checks with calls to checkIndex
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 13:52:53 +0000 (15:52 +0200)]
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 09:53:12 +0000 (11:53 +0200)]
Use auto where possible
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 09:47:36 +0000 (11:47 +0200)]
Add minimum size to file details window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 09:35:26 +0000 (11:35 +0200)]
Remove default cases in switches, rely on compiler warnings for missed cases
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 08:50:14 +0000 (10:50 +0200)]
Eliminate unneeded parent Item in FileActivityView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 08:37:02 +0000 (10:37 +0200)]
Add early return checks for setter methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 1 Oct 2022 08:26:06 +0000 (10:26 +0200)]
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 30 Sep 2022 23:16:52 +0000 (01:16 +0200)]
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 30 Sep 2022 23:13:41 +0000 (01:13 +0200)]
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 17:55:25 +0000 (19:55 +0200)]
Show password set errors in the popup where passwords are set rather than in the main dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 16:25:41 +0000 (18:25 +0200)]
Improve share view tab buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 16:18:47 +0000 (18:18 +0200)]
Change 'Link share' to 'Share link', matching server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Sep 2022 16:18:12 +0000 (18:18 +0200)]
Improve flat buttons in share delegates
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 25 Jul 2022 16:57:18 +0000 (18:57 +0200)]
Add a file details window/page, QMLify file sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Mon, 31 Oct 2022 11:23:52 +0000 (12:23 +0100)]
add mising namespace
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 31 Oct 2022 10:00:07 +0000 (11:00 +0100)]
Merge pull request #5116 from nextcloud/ci/fixMacCompilationEditLocallly
use new public API to open an edit locally URL
Matthieu Gallien [Mon, 31 Oct 2022 09:28:47 +0000 (10:28 +0100)]
use new public API to open an edit locally URL
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Mon, 31 Oct 2022 03:19:19 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 30 Oct 2022 03:23:26 +0000 (03:23 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Sat, 29 Oct 2022 15:03:46 +0000 (17:03 +0200)]
Merge pull request #5097 from nextcloud/bugfix/sync-now-visible-connected
Only show Sync Now button if account is connected
Claudio Cambra [Wed, 26 Oct 2022 10:47:42 +0000 (12:47 +0200)]
Only show Sync Now button if account is connected
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 29 Oct 2022 13:44:21 +0000 (15:44 +0200)]
Merge pull request #5105 from nteodosio/master
Fix compatibility with newer python3-nautilus
Nathan Pratta Teodosio [Fri, 26 Aug 2022 18:03:03 +0000 (15:03 -0300)]
Fix compatibility with newer python3-nautilus
Signed-off-by: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
Claudio Cambra [Sat, 29 Oct 2022 12:37:29 +0000 (14:37 +0200)]
Merge pull request #5027 from nextcloud/bugfix/modernise-accountsettings-code
Modernise and improve code in AccountSettings
Claudio Cambra [Wed, 26 Oct 2022 20:04:34 +0000 (22:04 +0200)]
Modernise QString-related construction
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 20:01:33 +0000 (22:01 +0200)]
Add braces to all if statements missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Oct 2022 10:35:41 +0000 (12:35 +0200)]
Expand use of const and auto, improve readability of accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Sat, 29 Oct 2022 12:02:04 +0000 (14:02 +0200)]
Merge pull request #5107 from nextcloud/bugfix/refactor-folderman-edit-locally
Refactor FolderMan's "Edit Locally" capabilities as separate class
Claudio Cambra [Sat, 29 Oct 2022 11:21:56 +0000 (13:21 +0200)]
Rename EditLocallyHandler to EditLocallyJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 22:19:04 +0000 (00:19 +0200)]
Ensure the checkTokenJob object gets deallocated
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 18:22:27 +0000 (20:22 +0200)]
Show edit locally loading dialog sooner, improve feedback for user
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 17:40:06 +0000 (19:40 +0200)]
Refactor edit locally handler management away from application and into own class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 14:43:30 +0000 (16:43 +0200)]
Don't show the user any potenitally questionable remote data
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 14:42:57 +0000 (16:42 +0200)]
Verify token before checking disk or modifying state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 18:13:38 +0000 (20:13 +0200)]
Refactor edit locally into its own class, rather than bolting onto FolderMan
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 17:10:21 +0000 (19:10 +0200)]
Refactor large editFileLocally FolderMan method into smaller, clearer separate methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Sat, 29 Oct 2022 03:31:52 +0000 (03:31 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 28 Oct 2022 11:11:01 +0000 (13:11 +0200)]
Merge pull request #5093 from nextcloud/work/validate-edit-locally-token
Validate and sanitise edit locally token and relpath before sending to server
Claudio Cambra [Thu, 27 Oct 2022 14:32:51 +0000 (16:32 +0200)]
Use addQueryParams for checkTokenForEditLocally SimpleApiJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 14:07:59 +0000 (16:07 +0200)]
Make sure to check relPath and compare to canonical cleaned path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 17:19:43 +0000 (19:19 +0200)]
Make sure to encode the relPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 13:56:53 +0000 (15:56 +0200)]
Validate edit locally token before sending to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 28 Oct 2022 03:20:17 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 27 Oct 2022 13:56:46 +0000 (15:56 +0200)]
Merge pull request #5102 from nextcloud/bugfix/fix-mac-autoupdater-settings
Fix macOS autoupdater settings
Claudio Cambra [Thu, 27 Oct 2022 12:30:33 +0000 (14:30 +0200)]
Fix macOS autoupdater settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Thu, 27 Oct 2022 03:19:41 +0000 (03:19 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Wed, 26 Oct 2022 17:11:33 +0000 (19:11 +0200)]
Merge pull request #5026 from nextcloud/bugfix/modernise-account-code
Modernise and improve code in AccountManager
Claudio Cambra [Mon, 10 Oct 2022 10:02:22 +0000 (12:02 +0200)]
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Wed, 26 Oct 2022 03:21:16 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 19:33:08 +0000 (21:33 +0200)]
Merge pull request #5018 from nextcloud/feature/force-sync-tray-button
Add a 'Sync now' button to the sync status header in the tray window
Claudio Cambra [Thu, 20 Oct 2022 11:41:55 +0000 (13:41 +0200)]
Add a 'Sync now' button to the sync status header in the tray window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Oct 2022 11:46:12 +0000 (13:46 +0200)]
Add forcefoldersync method to folder manager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Oct 2022 11:41:25 +0000 (13:41 +0200)]
Create commonly accessible properties for current user colours in Style.qml
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 17:14:25 +0000 (19:14 +0200)]
Merge pull request #5070 from nextcloud/work/simplify-cleanuppollsjob-constructor
Remove unneeded parameter from CleanupPollsJob constructor
Claudio Cambra [Wed, 19 Oct 2022 16:25:02 +0000 (18:25 +0200)]
Remove unneeded parameter from CleanupPollsJob constructor
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 25 Oct 2022 13:57:47 +0000 (15:57 +0200)]
Merge pull request #5042 from nextcloud/bugfix/systray-slots
Make Systray's void methods slots
Claudio Cambra [Fri, 14 Oct 2022 16:59:08 +0000 (18:59 +0200)]
Make Systray's void methods slots
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Tue, 25 Oct 2022 10:18:58 +0000 (12:18 +0200)]
Merge pull request #5071 from nextcloud/work/sync-engine-method-cleanup
Clean up methods in sync engine
Claudio Cambra [Wed, 19 Oct 2022 17:23:37 +0000 (19:23 +0200)]
Clean up methods in sync engine
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 25 Oct 2022 09:04:20 +0000 (11:04 +0200)]
Merge pull request #5086 from nextcloud/NeroBurner-patch-1
Update CMake usage in README build instructions
NeroBurner [Sun, 23 Oct 2022 19:45:16 +0000 (21:45 +0200)]
Update CMake usage in README build instructions
CMake 3.14.0 released in March 2019 [1] added the command line config options
`-S <source-dir>` and `-B <build-dir>` and the build argument `--build <build-dir>` [2].
These options are universally valid independent of the build system used (`make`,
`nmake`, `ninja`, `MSBuild`,...), making the provided CMake commands more generic.
As reference Ubuntu 20.04 ships the CMake 3.16.3 [3] version.
- [1] https://gitlab.kitware.com/cmake/cmake/-/tags/v3.14.0
- [2] https://cmake.org/cmake/help/v3.14/release/3.14.html#command-line
- [3] https://packages.ubuntu.com/focal/cmake
Signed-off-by: NeroBurner <pyro4hell@gmail.com>
Nextcloud bot [Tue, 25 Oct 2022 03:24:49 +0000 (03:24 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 24 Oct 2022 16:36:17 +0000 (18:36 +0200)]
Merge pull request #5087 from nextcloud/bugfix/syncFolderStatusIcon
emit missing signal to update folder sync status icon
Matthieu Gallien [Mon, 24 Oct 2022 10:30:36 +0000 (12:30 +0200)]
emit missing signal to update folder sync status icon
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 24 Oct 2022 13:39:00 +0000 (15:39 +0200)]
Merge pull request #4949 from nextcloud/bugfix/checkCertAgainstPrivateKey
validate certificate for E2EE against private key
Matthieu Gallien [Wed, 12 Oct 2022 10:05:45 +0000 (12:05 +0200)]
fix review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 15:27:45 +0000 (17:27 +0200)]
fix more sonarcloud issues
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 13:43:56 +0000 (15:43 +0200)]
fix more issues reported by sonarcloud
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 13:41:31 +0000 (15:41 +0200)]
remove useless lines: fix review comment
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 09:21:29 +0000 (11:21 +0200)]
fix review comments from sonarcloud static analyzis
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 5 Oct 2022 09:20:02 +0000 (11:20 +0200)]
address review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 16 Sep 2022 16:20:41 +0000 (18:20 +0200)]
validate certificate for E2EE against private key
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Mon, 24 Oct 2022 03:20:08 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 23 Oct 2022 03:20:11 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 22 Oct 2022 03:21:06 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 21 Oct 2022 03:28:29 +0000 (03:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 20 Oct 2022 13:18:26 +0000 (15:18 +0200)]
Merge pull request #5074 from nextcloud/bugfix/call-notification-buttons
Fix call notification dialog buttons
Claudio Cambra [Thu, 20 Oct 2022 12:11:10 +0000 (14:11 +0200)]
Fix call notification dialog buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
rakekniven [Thu, 20 Oct 2022 09:54:27 +0000 (11:54 +0200)]
Merge pull request #5066 from nextcloud/update/changelog
Update CHANGELOG with 3.6.1 changes.
Camila [Tue, 18 Oct 2022 14:15:15 +0000 (16:15 +0200)]
Update CHANGELOG with 3.6.1 changes.
Signed-off-by: Camila <hello@camila.codes>
Claudio Cambra [Wed, 19 Oct 2022 12:04:24 +0000 (14:04 +0200)]
Merge pull request #5013 from nextcloud/bugfix/webflow-user-strings
Improve "pretty user name"-related strings, display in webflow credentials
projects / nextcloud-desktop.git / log