Josh [Sun, 21 Jul 2024 06:46:03 +0000 (02:46 -0400)]
ci(clang-tidy-review): Fix for qt6 + swap to docker-ci container (#6860)
* ci(clang-tidy-review): Fix for qt6 + swap to docker-ci container
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: add OPENSSL_ROOT_DIR
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: use clang-tidy-diff.py
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: path to clang-tidy-diff.py -> clang-tidy-diff-15.py
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: try to fix git usage
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: LD_LIBRARY_PATH workaround for python in clang-tidy-pr-comments
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: bump back to 1.4.3 clang-tidy-pr-comments to avoid workarounds
Signed-off-by: Josh <josh.t.richards@gmail.com>
* fix: wrap up after debugging this
Signed-off-by: Josh <josh.t.richards@gmail.com>
---------
Signed-off-by: Josh <josh.t.richards@gmail.com>
Nextcloud bot [Sat, 20 Jul 2024 02:42:57 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 08:59:38 +0000 (16:59 +0800)]
Merge pull request #6897 from nextcloud/bugfix/mac-vfs-checkboxes
Fix clickable area of macOS VFS settings checkboxes
Claudio Cambra [Wed, 10 Jul 2024 07:07:49 +0000 (15:07 +0800)]
Limit clickable area of macOS vfs fast sync checkbox to its drawing zone
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 10 Jul 2024 07:07:30 +0000 (15:07 +0800)]
Limit clickable area of enable macOS vfs checkbox to its text/box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 08:57:31 +0000 (16:57 +0800)]
Merge pull request #6921 from nextcloud/bugfix/mac-crafter-cross-build
Add additional options to make cross-compiling client feasible with Mac Crafter
Claudio Cambra [Tue, 16 Jul 2024 07:54:44 +0000 (15:54 +0800)]
Add option to set product path in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Jul 2024 07:53:43 +0000 (15:53 +0800)]
Use default long arg type for build path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Jul 2024 07:51:00 +0000 (15:51 +0800)]
Allow setting of osx archs craft option in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 08:56:49 +0000 (16:56 +0800)]
Merge pull request #6929 from nextcloud/feature/ncfpk-upgrade
Upgrade to NextcloudFileProviderKit stable-1.0
Claudio Cambra [Fri, 19 Jul 2024 07:18:29 +0000 (15:18 +0800)]
Remove unused urlsession stuff in FileProviderExtension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 07:17:59 +0000 (15:17 +0800)]
Implement ChangeNotificationInterface in client interface extension of FileProviderExtension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 07:17:17 +0000 (15:17 +0800)]
Adapt to remoteInterface changes in NCFPK
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 07:16:05 +0000 (15:16 +0800)]
Add NCFPKAppGroupIdentifier in FileProviderExt info plist
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 07:15:21 +0000 (15:15 +0800)]
Move to depending on stable-1.0 in master
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 08:21:52 +0000 (16:21 +0800)]
Merge pull request #6927 from nextcloud/bugfix/info-container-visiblity-no-updater
Fix visibility of info buttons and details when updater is disabled in general settings
Claudio Cambra [Thu, 18 Jul 2024 07:42:08 +0000 (15:42 +0800)]
Fix visibility of info buttons and details when updater is disabled in general settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 Jul 2024 08:18:39 +0000 (16:18 +0800)]
Merge pull request #6898 from nextcloud/bugfix/macos-file-provider-ci
Build file provider module in CI runs
Claudio Cambra [Wed, 10 Jul 2024 07:30:06 +0000 (15:30 +0800)]
Build file provider module in CI runs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 19 Jul 2024 02:38:57 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 15 Jul 2024 02:38:40 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 14 Jul 2024 02:40:16 +0000 (02:40 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 13 Jul 2024 02:42:17 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 12 Jul 2024 02:40:11 +0000 (02:40 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 11 Jul 2024 17:02:59 +0000 (01:02 +0800)]
Merge pull request #6907 from ivaradi/optimize_debian_build
Optimize Ubuntu/Debian build
István Váradi [Thu, 11 Jul 2024 14:29:48 +0000 (16:29 +0200)]
Use a single OBS package for all Debian distributions
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
István Váradi [Wed, 10 Jul 2024 17:44:32 +0000 (19:44 +0200)]
Determine the base version and build kind using the Debian build branch
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
Claudio Cambra [Thu, 11 Jul 2024 15:20:34 +0000 (23:20 +0800)]
Merge pull request #6895 from ivaradi/mantic_oracular
Remove Ubuntu Mantic, add Oracular
István Váradi [Tue, 9 Jul 2024 15:10:13 +0000 (17:10 +0200)]
Remove Ubuntu Mantic, add Oracular
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
Matthieu Gallien [Thu, 11 Jul 2024 13:41:23 +0000 (15:41 +0200)]
Merge pull request #6629 from nextcloud/feature/support-lnk-files-in-vfs-win
Support Windows .lnk files with VFS Cf API.
alex-z [Thu, 18 Apr 2024 22:20:37 +0000 (00:20 +0200)]
Bugfix. Migrate non-placeholder shortcuts to placeholder version.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Mon, 15 Apr 2024 04:44:06 +0000 (06:44 +0200)]
Unit tests. Test .lnk file with a real shortcut file. Test will hang if QFileInfo is used on .lnk files.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 10 Apr 2024 19:54:37 +0000 (21:54 +0200)]
Support Windows .lnk files with VFS Cf API.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Wed, 10 Jul 2024 02:55:42 +0000 (02:55 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 9 Jul 2024 10:09:41 +0000 (18:09 +0800)]
Merge pull request #6892 from nextcloud/bugfix/avoid-freeze-vfs-settings
Fix permanent freeze upon opening macOS VFS settings
Claudio Cambra [Tue, 9 Jul 2024 06:48:47 +0000 (14:48 +0800)]
Add check to detect if we timed out wait for file provider extension service response on fast enumeration state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jul 2024 06:48:17 +0000 (14:48 +0800)]
Do not wait forever to get fast enumeration state from file provider extension service
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jul 2024 06:47:42 +0000 (14:47 +0800)]
Fix _Generic C11 extension compile warning under clang
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 9 Jul 2024 02:38:50 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Camila Ayres [Mon, 8 Jul 2024 12:22:11 +0000 (14:22 +0200)]
Merge pull request #6885 from nextcloud/bugfix/cloud-operation
Remove unecessary call to sendTransferInfo.
Camila Ayres [Fri, 5 Jul 2024 17:34:03 +0000 (19:34 +0200)]
Remove unecessary call to sendTransferInfo.
Possible fix for #6876.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Claudio Cambra [Mon, 24 Jun 2024 11:41:28 +0000 (19:41 +0800)]
Add offline flag to mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jun 2024 11:01:19 +0000 (19:01 +0800)]
Replace bool options with flags in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 23 Jun 2024 09:45:52 +0000 (17:45 +0800)]
Add option to build tests or not in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 14:55:17 +0000 (22:55 +0800)]
When doing a full rebuild in mac crafter, delete old build folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 09:29:52 +0000 (17:29 +0800)]
Simplify dylib signing process and ensure resource libs are signed in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 09:29:21 +0000 (17:29 +0800)]
Improve build mode flag handling in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 08:49:55 +0000 (16:49 +0800)]
Make mac-related build options configurable in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 08:44:31 +0000 (16:44 +0800)]
Throw on failure of any shell commands to complete successfully in ma crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 08:41:58 +0000 (16:41 +0800)]
Compile and install instead of full clean rebuild of client in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 08:41:40 +0000 (16:41 +0800)]
Allow setting custom git clone command in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 08:41:22 +0000 (16:41 +0800)]
Always configure craft if first download and set to not reconfigure by default in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 08:01:22 +0000 (16:01 +0800)]
Use --options as recommended for configuring craft build in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 22 Jun 2024 07:59:11 +0000 (15:59 +0800)]
Make craft blueprint name adjustable in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Jun 2024 12:16:37 +0000 (20:16 +0800)]
Add support for fetching and including Sparkle in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Jun 2024 12:16:14 +0000 (20:16 +0800)]
Remove unused Build file in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 11:38:33 +0000 (19:38 +0800)]
Extract app bundle codesigning procedure to separate file in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 11:33:50 +0000 (19:33 +0800)]
Directly sign plugins and frameworks within app bundle in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:48:05 +0000 (18:48 +0800)]
Add relevant files to mac crafter gitignore
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:46:44 +0000 (18:46 +0800)]
Add option to skip craft configuration in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:31:39 +0000 (18:31 +0800)]
Divide client app dir path construction in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:30:57 +0000 (18:30 +0800)]
Fix unused codesignidentity warning in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:20:26 +0000 (18:20 +0800)]
Throw if codesign binary not found in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:20:10 +0000 (18:20 +0800)]
Fix buildtype argument for craft in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:11:33 +0000 (18:11 +0800)]
Add procedure to codesign app bundle in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:11:07 +0000 (18:11 +0800)]
Allow explicitly skipping code-signing of dependencies in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 10:09:48 +0000 (18:09 +0800)]
Allow setting of build type in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 07:59:25 +0000 (15:59 +0800)]
Remove previous craft client builder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 07:59:10 +0000 (15:59 +0800)]
Fix paths in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:59:11 +0000 (14:59 +0800)]
Fix mac-crafter abstract
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:58:14 +0000 (14:58 +0800)]
Adjust arguments for mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:58:02 +0000 (14:58 +0800)]
Fix dependencies for mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:43:27 +0000 (14:43 +0800)]
Make URLs adjustable in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:43:08 +0000 (14:43 +0800)]
Make build path adjustable in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:40:34 +0000 (14:40 +0800)]
Move library check to separate file in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:27:37 +0000 (14:27 +0800)]
Codesign all crafted plugins in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:27:25 +0000 (14:27 +0800)]
Codesign all the crafted libraries with mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:26:12 +0000 (14:26 +0800)]
Make codesigning throw in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:25:56 +0000 (14:25 +0800)]
Make installIfMissing throwing in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:16:58 +0000 (14:16 +0800)]
Implement basic argumentparser in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 06:05:06 +0000 (14:05 +0800)]
Move functions of mac crafter into different files
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 05:55:55 +0000 (13:55 +0800)]
Add copyright header to main.swift
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jun 2024 05:50:12 +0000 (13:50 +0800)]
Move build script into dedicated package
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 12:29:22 +0000 (20:29 +0800)]
Add codesign function to macos builder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 10:33:07 +0000 (18:33 +0800)]
Craft the desktop client in the mac builder script
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 10:32:15 +0000 (18:32 +0800)]
Clone craft master to craftdir in mac builder script
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 10:26:58 +0000 (18:26 +0800)]
Clone craft in mac builder script
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 10:08:43 +0000 (18:08 +0800)]
Deduplicate installation of required tools in macos builder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 10:01:51 +0000 (18:01 +0800)]
Set up python if missing in mac builder script
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 10:01:36 +0000 (18:01 +0800)]
Configure xcode command line tools if missing in mac builder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 09:48:26 +0000 (17:48 +0800)]
Install inkscape via mac builder script if not present
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 09:47:56 +0000 (17:47 +0800)]
Install brew through builder if not present
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 09:47:41 +0000 (17:47 +0800)]
Add convenience func to check if command exists
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 09:47:19 +0000 (17:47 +0800)]
Add convenience func to run shell command
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jun 2024 09:46:59 +0000 (17:46 +0800)]
Start working on mac builder script
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Mon, 8 Jul 2024 02:39:57 +0000 (02:39 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 6 Jul 2024 02:39:53 +0000 (02:39 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 5 Jul 2024 11:57:14 +0000 (13:57 +0200)]
Merge pull request #6780 from nextcloud/bugfix/groupfolder-rename
Check if sync item is actually a folder before processing it
Camila Ayres [Tue, 25 Jun 2024 14:40:02 +0000 (16:40 +0200)]
Fix renaming tests for files under group folders.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Mon, 24 Jun 2024 16:58:02 +0000 (18:58 +0200)]
Only check for external storage permissions when it is a folder.
Signed-off-by: Camila Ayres <hello@camilasan.com>
projects / nextcloud-desktop.git / log