Fix folder opening in ActivityListModel

After fixing the crash in the previous commit, double-clicking on Activity list rows still didn't work.

This fix partly reverts commit 8546d53b05a76271e245f085d1caa5d405dadb8d in ActivityItemDelegate::PathRole
of ActivityListModel::data, but adds a new check for relPath's existence in line 74.

I'm assuming the previous change there has been done to shorten the code and avoid opening the user's home
folder upon clicking entries which file value is "App Password". The new path-check takes care of that too now.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix crash in ActivityListModel (fixes #1693)

Signed-off-by: Michael Schuster <michael@schuster.ms>

Show date and time in activity log (fixes issue #1683)

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Fix build (missing refactoring)

Signed-off-by: Michael Schuster <michael@schuster.ms>

Mac and high-dpi displays: Add workaround in ActivityItemDelegate to show full uncropped activity's actionText and timeText

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make all ProgressIndicator's background-aware (Dark-/Light-Mode switching)

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make OwncloudWizard and its pages background-aware (Dark-/Light-Mode switching)

Signed-off-by: Michael Schuster <michael@schuster.ms>

Remove unnecessary string translation and copy in ActivityItemDelegate

Signed-off-by: Michael Schuster <michael@schuster.ms>

Remove unnecessary breaks in ActivityListModel

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make ActivityItemDelegate background- and selection-aware (Dark-/Light-Mode switching)

Also implement cached member icons in ActivityListModel and return their enums to
ActivityItemDelegate instead of always recreating them for each call to paint().

Signed-off-by: Michael Schuster <michael@schuster.ms>

Refactor ActivitySettings: Rename member variable ui to _ui

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make AccountSettings and ActivitySettings background-aware (Dark-/Light-Mode switching)

Signed-off-by: Michael Schuster <michael@schuster.ms>

Change error link colour in AccountSettings::showConnectionLabel

Signed-off-by: Michael Schuster <michael@schuster.ms>

Add new Theme helper method to custom-colourize links

Signed-off-by: Michael Schuster <michael@schuster.ms>

Change Dark Mode link colour

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

Fix Activity List: Add check to avoid first empty entry

Add checks to ActivityListModel::combineActivityLists in order to avoid adding
empty Activity entries to the _finalList.

The previous implementation always added an empty entry to the top of the list because
_notificationIgnoredFiles was appended without checking (_listOfIgnoredFiles.size() > 0).

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

macOS: Rename 'Explorer' appropriately on non-Windows

- Rename it to 'Finder' on macOS.
- This way we also avoid having the whole string re-translated on Transifex.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make the ShareDialog background-aware (Dark-/Light-Mode switching)

Use customizeStyle() to change link colours, icons and pixmaps in the ShareDialog and notify
it's widgets via slots.

TODO - known issue (macOS):
- The background and font colours in the ShareUserLine widget still stay the same.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make SettingsDialog background-aware (Dark-/Light-Mode switching)

Use customizeStyle() to change link colours in the SettingsDialog and notify it's widgets via slots.

Also modify the background colour of the errors messages in AccountSettings::showConnectionLabel
to always use an appropiate colour for it's custom-defined background.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Implement and move some colour-aware helper methods into the Theme class

This introduces a new method to change the colours in the links in QLabel's.
Utilizes a custom crafted RegEx function to replace already-coloured links.

Moved code is based on stuff from the SettingsDialog class.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Pick from upstream: Fix too low contrast when tab is selected

The low contrast is also a problem with the Dark Mode on macOS.

For reference please see:
- Commit: https://github.com/owncloud/client/commit/413ef5e96d098f45694c261bbc409fcf21e0cb65
- Issue: https://github.com/owncloud/client/issues/7512

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix SSL-button's info background color for Dark Mode

Signed-off-by: Michael Schuster <michael@schuster.ms>

Remove submodule qtmacgoodies and the MacSettingsDialog class

Reverts back to the SettingsDialog class because of bugs and glitches with
more recent Qt versions (Qt 5.12) and with the macOS Dark Mode.

See upstream: https://github.com/owncloud/client/pull/7492

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Fix deleteKeychainEntries: Stay consistent with job->setInsecureFallback(false)

We never fall back to the insecure variant in the whole codebase, so don't do it here.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix Windows key-chunk deletion (too paranoid)

Clear the key chunk buffer, but don't set _clientSslKeyChunkCount to zero because we need it later for deleteKeychainEntries

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix member variable name from last refactoring (Windows code)

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix Remote Wipe keychain storage

In certain cases don't write the app password in Account::writeAppPasswordOnce:
- id() is empty: This always happend once the Account Wizard showed the folder selection
- appPassword is empty: Caused by Logout -> Relaunch, preventing remote wipe on relaunch

Implement some logging to ease debugging in the future.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Remote Wipe: Implement hack to allow deleting all keychain entries (SSL certs & keys)

Client SSL certificates and keys cannot be deleted at this time because there is
no UI for selecting them on re-login.

We introduce this dirty hack here, to allow deleting them upon Remote Wipe.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys

WebFlowCredentials:
- Remove _clientSslCaKeyWriteQueue and simply use _clientSslKeyChunkBufferPEM
- Store key's sub-chunks in slots with "." (dot) suffix
- Implement deletion of the key chunks in WebFlowCredentials::deleteKeychainEntries
- Remove spaces in log messages
- Improve code readability

Signed-off-by: Michael Schuster <michael@schuster.ms>

Windows: Workaround for storing >= 4k (4096 bit) client-cert SSL keys

With QtKeychain on Windows, storing larger keys in one keychain entry causes the
following error due to limits in the Windows APIs:
  Error: "Credential size exceeds maximum size of 2560"

To avoid overhead on the other platforms and balance code duplication, this
approach puts some read- and write-parts into Windows-only defines.

For reference also see previous fixes:
- https://github.com/nextcloud/desktop/pull/1389
- https://github.com/nextcloud/desktop/pull/1394

This (again) fixes the re-opened issue:
- https://github.com/nextcloud/desktop/issues/863

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

Fall back to old login flow on GS as this is not yet ready (#2: re-auth)

This commit ensures that the check also occurs on re-authorization in case
the user gets logged out.

See: https://github.com/nextcloud/desktop/pull/1644

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fall back to old login flow on GS as this is not yet ready

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Compare QDateTime objects more efficient

There is no need to call toMSecsSinceEpoch() as QDateTime implements an
comparison operator itself. This is more efficient, because the
QDateTime comparison operator doesn't call localtime() in all cases. Thus, we
don't read /etc/localtime for every comparison. This improves
performance in some cases.

Signed-off-by: David Kahles <david.kahles96@gmail.com>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Use … instead of 3 dots

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix some translations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Improve the translation of "Share via …"

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Fix copyright year in MacOSXBundleInfo.plist.in for 2019

Signed-off-by: Michael Schuster <michael@schuster.ms>

Use ReadPasswordJob::finished for ReadPasswordJob

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix remote wipe keychain storage (issue #1592)

The app password for the remote wipe was constantly being written in
WebFlowCredentials::slotFinished to the keychain, leading to unnecessary
write and log overhead on the system.

This fix introduces a check to only store the app password once in
a lifetime of the Account class. Also the method used to store the
password will be renamed from setAppPassword to writeAppPasswordOnce
to be more expressive.

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Build for Debian stable and oldstable

Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>

Fix legal notice year

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Merge pull request #1623 from nextcloud/mac-prepare-notarization

macOS build: Avoid the Get-Task-Allow Entitlement (Notarization)

macOS build: Avoid the Get-Task-Allow Entitlement (Notarization)

Setting CODE_SIGN_INJECT_BASE_ENTITLEMENTS to NO is required for macOS
Notarization.

See: https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues

And upstream: https://github.com/owncloud/client/pull/7007/commits/97f4af32ae1b64e835bb41c78c8abe6689916c01

Signed-off-by: Michael Schuster <michael@schuster.ms>

Merge pull request #1621 from nextcloud/mac-sign-timestamp

Add timestamp to Mac installer code signing

Add timestamp to Mac installer code signing

Use the --timestamp option for 'productsign' to add a secure timestamp.

See: https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

Merge pull request #1619 from nextcloud/bumpQt-5.12.5

Bump Qt 5.12.5 image

Fix: add /usr/local/lib to LD_LIBRARY_PATH for OpenSSL 1.1.1

Drone pipeline qt-5.12 failed because the unit tests didn't find OpenSSL.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Fix: escape env vars

Signed-off-by: Michael Schuster <michael@schuster.ms>

Bump Qt 5.12.5 image

Signed-off-by: Michael Schuster <michael@schuster.ms>

Merge pull request #1617 from nextcloud/appimageQt-5.12.5

Upgrade for Qt 5.12.5 in docker-ci

Fix dir in upload script

Signed-off-by: Michael Schuster <michael@schuster.ms>

Make AppImage upload optional and add timeout

Moves the upload into a separate Drone command and adds a timeout for curl
to fail after 15 minutes.

Returns zero to keep Drone from failing.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Move .desktop file path to new env var to avoid duplicates

Signed-off-by: Michael Schuster <michael@schuster.ms>

Upgrade for Qt 5.12.5 in docker-ci

- Use the new image: nextcloudci/client-5.12:client-5.12-5
- Use it's new QT_BASE_DIR: /opt/qt5.12.5

Signed-off-by: Michael Schuster <michael@schuster.ms>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Merge pull request #1604 from nextcloud/rakekniven-patch-1

l10n: Remove string from Transifex resource

Merge pull request #1605 from nextcloud/revert-1586-qt5.5-compat

Revert and Fix "Remove HTTP/2 support from Xenial"

Fix: Apply http2 patch from owncloud #1573 - only with Qt >= 5.8

Drone builds failed with Qt 5.7 and we introduce a new ifdef here
to avoid patching specifically for Ubuntu Xenial only.

Signed-off-by: Michael Schuster <michael@schuster.ms>

Revert "Remove HTTP/2 support from Xenial"

Merge pull request #1586 from ivaradi/qt5.5-compat

Remove HTTP/2 support from Xenial

l10n: Remove string from Transifex resource

Fix for #1578

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex