ncbi-blast+.git
16 months agoDeclare fast forward from 2.16.0+ds-5
Aaron M. Ucko [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
Declare fast forward from 2.16.0+ds-5

[dgit --quilt=gbp --overwrite]

16 months agobig_endian_workaround
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
big_endian_workaround

Gbp-Pq: Name big_endian_workaround

16 months agoto3
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
to3

Gbp-Pq: Name 2to3

16 months agotune_lmdb_defaults
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
tune_lmdb_defaults

Gbp-Pq: Name tune_lmdb_defaults

16 months agoBypass env in Perl script shebangs.
Aaron M. Ucko [Thu, 2 Dec 2021 02:38:20 +0000 (21:38 -0500)]
Bypass env in Perl script shebangs.

Gbp-Pq: Name run_perl_directly

16 months agoSupport GCC 10+.
Aaron M. Ucko [Mon, 7 Sep 2020 02:57:35 +0000 (22:57 -0400)]
Support GCC 10+.

Debian-Bug: 957581.

* ncbifile.cpp (s_GetFileSystemInfo): Formally cast st.f_type to avoid
  narrowing errors for cases with the high bit set when that field is
  a 32-bit signed integer (as on i386).

Gbp-Pq: Name support_gcc10

16 months agoSpelling fixes
Michael R. Crusoe [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
Spelling fixes

Gbp-Pq: Name spelling

16 months agoadd missing lib for tests
Olivier Sallou [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
add missing lib for tests

Forwarded: Not-Needed
Last-Updated: 2018-02-11

Gbp-Pq: Name fix_unit_tests

16 months agoHang on to sequence data even if -parse_deflines recognized a non-local ID,
Aaron M. Ucko [Thu, 15 Dec 2016 03:44:19 +0000 (22:44 -0500)]
Hang on to sequence data even if -parse_deflines recognized a non-local ID,

   on the condition that the environment variable BLAST_ALWAYS_KEEP_SEQUENCE
   (or configuration parameter [BLAST] always_keep_sequence) is set to a
   "true" value (English-only, case-insensitive true, t, yes, y, or 1).

Gbp-Pq: Name optionally_keep_sequence

16 months agosuppress gnu TLS and mbed TLS version checks
Aaron M. Ucko [Thu, 2 Dec 2021 03:08:16 +0000 (22:08 -0500)]
suppress gnu TLS and mbed TLS version checks

   Prevent bailing when the exact compile-time and runtime GNU TLS versions
   differ; trust dpkg to disallow combinations that are actually incompatible.
   Likewise for mbed TLS.

Gbp-Pq: Name suppress_tls_version_checks

16 months agoSupport x32
Aaron M. Ucko [Thu, 2 Dec 2021 02:37:42 +0000 (21:37 -0500)]
Support x32

Avoid picking up wrong inline assembly.

Gbp-Pq: Name support_x32

16 months agofix path for debian build
Olivier Sallou [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
fix path for debian build

Forwarded: no
Last-Updated: 2014-06-06

Gbp-Pq: Name fix_configure

16 months agoremove network required test
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
remove network required test

Forwarded: no
Last-Updated: 2013-06-01

Gbp-Pq: Name skip_services_unit_test

16 months agobuild executables with -fPIE, not -fPIC
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
build executables with -fPIE, not -fPIC

* -fPIC is only useful for shared libraries; substitute -fPIE (along
   with -pie at link time) when building executables.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2012-05-10

Gbp-Pq: Name use_pie_for_apps

16 months agoavoid redundant rpath entries on multiarch systems
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
avoid redundant rpath entries on multiarch systems

 * src/build-system/configure(.ac): when ensuring that executables
   will be able to find libstdc++, don't add rpath entries that files
   under /etc/ld.so.conf.d already specify, even if they don't resemble
   traditional single-architecture or biarch locations.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2011-08-28

Gbp-Pq: Name no_multiarch_rpath

16 months agoensure that all libraries link against all direct dependencies
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
ensure that all libraries link against all direct dependencies

 * src/**/Makefile.*.lib: set DLL_(D)LIB correctly.  Break the dependency
   loop between libxblast and libxalgoblastdbindex by having the former
   provide only the C++ BLAST API, leaving the C core only in libblast.
 * src/build-system/library_relations.txt: Change xblast's
   relationship to blast from includes to needs, accordingly.
 * src/algo/blast/Makefile.blast_macros.mk: Add blast to BLAST_LIBS.
 * src/algo/blast/dbindex*/*/Makefile.*.app: Link against libxconnect
   rather than libconnect for consistency with libblast, which uses the
   former to keep the aforementioned cycle-breaking from causing
   inconsistency elsewhere.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2016-12-05

Gbp-Pq: Name fix_lib_deps

16 months agorename binary as blast+ for package coherency.
Olivier Sallou [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
rename binary as blast+ for package coherency.

Last-Updated: 2011-10-03

Gbp-Pq: Name legacy_rename_rpsblast

16 months agofix portability issues that led to Hurd build failures
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
fix portability issues that led to Hurd build failures

* src/build-system/configure(.ac):
  - Reflect the Hurd's support for -Wl,rpath,... .
* src/connect/ncbi_socket_cxx.cpp, src/connect/ext/ncbi_localnet.c:
  cope with missing PATH_MAX everywhere, not just under Windows.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2020-09-19

Gbp-Pq: Name hurd_fixes

16 months agoclean after failure
Debian Med Packaging Team [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
clean after failure

Last-Updated: 2013-06-01
Forwarded: no

Gbp-Pq: Name enable_clean_after_failed_compile

16 months agoblast+ use optout to send usage reports over internet
Olivier Sallou [Wed, 7 Aug 2024 01:45:09 +0000 (21:45 -0400)]
blast+ use optout to send usage reports over internet

Last-Updated: 202-02-10
Forwarded: no

Gbp-Pq: Name optin_usage_report

16 months ago[PATCH] Allow substituting PCRE2 for legacy PCRE by explicit request.
ucko [Thu, 18 Jul 2024 18:33:56 +0000 (18:33 +0000)]
[PATCH] Allow substituting PCRE2 for legacy PCRE by explicit request.

- For now, require opt-in via --with-components="...;PCRE2;..." (CMake),
  --with-pcre2 (traditional Unix build system), or uncommenting the
  relevant ThirdParty_PCRE2 setting in project_tree_builder.ini
  (traditional Windows build system).
- Likewise, hold off on switching the bundled copy to PCRE2 or checking
  for any functions or headers that will become of interest.
- Redundantly (for now) shun external PCRE2 in bin-release configurations.
- Otherwise favor (allowed!) external installations over the bundled
  copy, preferring PCRE2 over legacy PCRE when both are found and
  allowed but (in due course) external legacy PCRE over bundled PCRE2 in
  the absence of external PCRE2.
- In the traditional build system, have the widely used PCRE_LIBS macro
  correspond to whichever PCRE is default (when not falling back on a
  bundled copy), and add a PCRE_LEGACY_LIBS macro for the sake of
  anything using legacy PCRE directly (very occasionally seen).

JIRA: CXX-12761,

git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@102806 78c7ea69-d796-4a43-9a09-de51944f1b03

Irrelevant (and inapplicable) changes to c++/src/build-system/cmake/,
c++/src/build-system/configure (which will be regenerated anyway), and
c++/src/build-system/project_tree_builder.ini elided.

Gbp-Pq: Name allow_pcre2

16 months ago[PATCH] Accommodate Mbed TLS 3.x (specifically, 3.6.0 LTS).
ucko [Tue, 23 Apr 2024 19:21:48 +0000 (19:21 +0000)]
[PATCH] Accommodate Mbed TLS 3.x (specifically, 3.6.0 LTS).

- Conditionally pass mbedtls_pk_parse_key the existing pRNG and its state.
- Call psa_crypto_init during setup, as PSA may be in play even when not
  explicitly enabled.  Documentation suggests calling it as early as
  possible; in practice, though, holding off until after pRNG
  initialization avoids "insufficient entropy" errors under 2.x (at least
  2.28.8 LTS on Linux) and still works fine as of 3.6.0.
- At least for now, ensure that MBEDTLS_SSL_VERIFY_NONE remains effective
  by additionally capping the TLS version at 1.2; as of 1.3, certificate
  checking has become mandatory, and Mbed TLS respects that requirement.
- Additional tuneups to ncbi_mbedtls.c-only code:
-- Account for error-code macro repertoire changes by conditionalizing
   major-version-specific macros on their availability and specifically
   checking for or emitting MBEDTLS_ERR_PLATFORM_FEATURE_UNSUPPORTED (new)
   as appropriate,
-- x_ErrorToStatus: Conditionally use MBEDTLS_PRIVATE for p_bio, which has
   no accessor.
-- x_MbedTlsWrite: Substitute mbedtls_ssl_get_max_out_record_payload for
   mbedtls_ssl_get_output_max_frag_len, which didn't account for other
   relevant considerations and is now fully private.

https://github.com/Mbed-TLS/mbedtls/blob/development/docs/3.0-migration-guide.md
supplied useful guidance.  JIRA: CXX-13565.

git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@102329 78c7ea69-d796-4a43-9a09-de51944f1b03

Gbp-Pq: Name support_mbedtls3

16 months agoOmit convenience mbed TLS copy
Aaron M. Ucko [Thu, 2 Dec 2021 04:33:11 +0000 (23:33 -0500)]
Omit convenience mbed TLS copy

Gbp-Pq: Name system_mbedtls_only

16 months agoFinalize ncbi-blast+ 2.16.0+ds-6 for unstable.
Aaron M. Ucko [Wed, 7 Aug 2024 01:45:10 +0000 (21:45 -0400)]
Finalize ncbi-blast+ 2.16.0+ds-6 for unstable.

16 months agodebian/rules: Try disabling optimization altogether on sh4.
Aaron M. Ucko [Wed, 7 Aug 2024 01:42:29 +0000 (21:42 -0400)]
debian/rules: Try disabling optimization altogether on sh4.

16 months agoReinstate big-endian builds, with default blastdb_version 4.
Aaron M. Ucko [Wed, 7 Aug 2024 01:37:02 +0000 (21:37 -0400)]
Reinstate big-endian builds, with default blastdb_version 4.

* debian/control: Reinstate big-endian builds, which can be salvaged
  adequately well.
* debian/patches/big_endian_workaround (new): On big-endian
  architectures, roll makeblastdb's and makeprofiledb's default
  blastdb_version back to 4 pending a proper fix.  Some things,
  including in particular q2-feature-classifier, will still explicitly
  request version 5, but everything else should be OK.  (See #1077777.)

16 months agoStart work on ncbi-blast+ 2.16.0+ds-6 (yet more arch tuneups).
Aaron M. Ucko [Wed, 7 Aug 2024 01:35:42 +0000 (21:35 -0400)]
Start work on ncbi-blast+ 2.16.0+ds-6 (yet more arch tuneups).

16 months agoFinalize ncbi-blast+ 2.16.0+ds-5 for unstable.
Aaron M. Ucko [Sun, 4 Aug 2024 20:04:33 +0000 (16:04 -0400)]
Finalize ncbi-blast+ 2.16.0+ds-5 for unstable.

16 months agoDeclare fast forward from 2.16.0+ds-4
Aaron M. Ucko [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
Declare fast forward from 2.16.0+ds-4

[dgit --quilt=gbp --overwrite]

16 months agoto3
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
to3

Gbp-Pq: Name 2to3

16 months agotune_lmdb_defaults
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
tune_lmdb_defaults

Gbp-Pq: Name tune_lmdb_defaults

16 months agoBypass env in Perl script shebangs.
Aaron M. Ucko [Thu, 2 Dec 2021 02:38:20 +0000 (21:38 -0500)]
Bypass env in Perl script shebangs.

Gbp-Pq: Name run_perl_directly

16 months agoSupport GCC 10+.
Aaron M. Ucko [Mon, 7 Sep 2020 02:57:35 +0000 (22:57 -0400)]
Support GCC 10+.

Debian-Bug: 957581.

* ncbifile.cpp (s_GetFileSystemInfo): Formally cast st.f_type to avoid
  narrowing errors for cases with the high bit set when that field is
  a 32-bit signed integer (as on i386).

Gbp-Pq: Name support_gcc10

16 months agoSpelling fixes
Michael R. Crusoe [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
Spelling fixes

Gbp-Pq: Name spelling

16 months agoadd missing lib for tests
Olivier Sallou [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
add missing lib for tests

Forwarded: Not-Needed
Last-Updated: 2018-02-11

Gbp-Pq: Name fix_unit_tests

16 months agoHang on to sequence data even if -parse_deflines recognized a non-local ID,
Aaron M. Ucko [Thu, 15 Dec 2016 03:44:19 +0000 (22:44 -0500)]
Hang on to sequence data even if -parse_deflines recognized a non-local ID,

   on the condition that the environment variable BLAST_ALWAYS_KEEP_SEQUENCE
   (or configuration parameter [BLAST] always_keep_sequence) is set to a
   "true" value (English-only, case-insensitive true, t, yes, y, or 1).

Gbp-Pq: Name optionally_keep_sequence

16 months agosuppress gnu TLS and mbed TLS version checks
Aaron M. Ucko [Thu, 2 Dec 2021 03:08:16 +0000 (22:08 -0500)]
suppress gnu TLS and mbed TLS version checks

   Prevent bailing when the exact compile-time and runtime GNU TLS versions
   differ; trust dpkg to disallow combinations that are actually incompatible.
   Likewise for mbed TLS.

Gbp-Pq: Name suppress_tls_version_checks

16 months agoSupport x32
Aaron M. Ucko [Thu, 2 Dec 2021 02:37:42 +0000 (21:37 -0500)]
Support x32

Avoid picking up wrong inline assembly.

Gbp-Pq: Name support_x32

16 months agofix path for debian build
Olivier Sallou [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
fix path for debian build

Forwarded: no
Last-Updated: 2014-06-06

Gbp-Pq: Name fix_configure

16 months agoremove network required test
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
remove network required test

Forwarded: no
Last-Updated: 2013-06-01

Gbp-Pq: Name skip_services_unit_test

16 months agobuild executables with -fPIE, not -fPIC
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
build executables with -fPIE, not -fPIC

* -fPIC is only useful for shared libraries; substitute -fPIE (along
   with -pie at link time) when building executables.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2012-05-10

Gbp-Pq: Name use_pie_for_apps

16 months agoavoid redundant rpath entries on multiarch systems
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
avoid redundant rpath entries on multiarch systems

 * src/build-system/configure(.ac): when ensuring that executables
   will be able to find libstdc++, don't add rpath entries that files
   under /etc/ld.so.conf.d already specify, even if they don't resemble
   traditional single-architecture or biarch locations.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2011-08-28

Gbp-Pq: Name no_multiarch_rpath

16 months agoensure that all libraries link against all direct dependencies
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
ensure that all libraries link against all direct dependencies

 * src/**/Makefile.*.lib: set DLL_(D)LIB correctly.  Break the dependency
   loop between libxblast and libxalgoblastdbindex by having the former
   provide only the C++ BLAST API, leaving the C core only in libblast.
 * src/build-system/library_relations.txt: Change xblast's
   relationship to blast from includes to needs, accordingly.
 * src/algo/blast/Makefile.blast_macros.mk: Add blast to BLAST_LIBS.
 * src/algo/blast/dbindex*/*/Makefile.*.app: Link against libxconnect
   rather than libconnect for consistency with libblast, which uses the
   former to keep the aforementioned cycle-breaking from causing
   inconsistency elsewhere.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2016-12-05

Gbp-Pq: Name fix_lib_deps

16 months agorename binary as blast+ for package coherency.
Olivier Sallou [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
rename binary as blast+ for package coherency.

Last-Updated: 2011-10-03

Gbp-Pq: Name legacy_rename_rpsblast

16 months agofix portability issues that led to Hurd build failures
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
fix portability issues that led to Hurd build failures

* src/build-system/configure(.ac):
  - Reflect the Hurd's support for -Wl,rpath,... .
* src/connect/ncbi_socket_cxx.cpp, src/connect/ext/ncbi_localnet.c:
  cope with missing PATH_MAX everywhere, not just under Windows.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2020-09-19

Gbp-Pq: Name hurd_fixes

16 months agoclean after failure
Debian Med Packaging Team [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
clean after failure

Last-Updated: 2013-06-01
Forwarded: no

Gbp-Pq: Name enable_clean_after_failed_compile

16 months agoblast+ use optout to send usage reports over internet
Olivier Sallou [Sun, 4 Aug 2024 20:04:32 +0000 (16:04 -0400)]
blast+ use optout to send usage reports over internet

Last-Updated: 202-02-10
Forwarded: no

Gbp-Pq: Name optin_usage_report

16 months ago[PATCH] Allow substituting PCRE2 for legacy PCRE by explicit request.
ucko [Thu, 18 Jul 2024 18:33:56 +0000 (18:33 +0000)]
[PATCH] Allow substituting PCRE2 for legacy PCRE by explicit request.

- For now, require opt-in via --with-components="...;PCRE2;..." (CMake),
  --with-pcre2 (traditional Unix build system), or uncommenting the
  relevant ThirdParty_PCRE2 setting in project_tree_builder.ini
  (traditional Windows build system).
- Likewise, hold off on switching the bundled copy to PCRE2 or checking
  for any functions or headers that will become of interest.
- Redundantly (for now) shun external PCRE2 in bin-release configurations.
- Otherwise favor (allowed!) external installations over the bundled
  copy, preferring PCRE2 over legacy PCRE when both are found and
  allowed but (in due course) external legacy PCRE over bundled PCRE2 in
  the absence of external PCRE2.
- In the traditional build system, have the widely used PCRE_LIBS macro
  correspond to whichever PCRE is default (when not falling back on a
  bundled copy), and add a PCRE_LEGACY_LIBS macro for the sake of
  anything using legacy PCRE directly (very occasionally seen).

JIRA: CXX-12761,

git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@102806 78c7ea69-d796-4a43-9a09-de51944f1b03

Irrelevant (and inapplicable) changes to c++/src/build-system/cmake/,
c++/src/build-system/configure (which will be regenerated anyway), and
c++/src/build-system/project_tree_builder.ini elided.

Gbp-Pq: Name allow_pcre2

16 months ago[PATCH] Accommodate Mbed TLS 3.x (specifically, 3.6.0 LTS).
ucko [Tue, 23 Apr 2024 19:21:48 +0000 (19:21 +0000)]
[PATCH] Accommodate Mbed TLS 3.x (specifically, 3.6.0 LTS).

- Conditionally pass mbedtls_pk_parse_key the existing pRNG and its state.
- Call psa_crypto_init during setup, as PSA may be in play even when not
  explicitly enabled.  Documentation suggests calling it as early as
  possible; in practice, though, holding off until after pRNG
  initialization avoids "insufficient entropy" errors under 2.x (at least
  2.28.8 LTS on Linux) and still works fine as of 3.6.0.
- At least for now, ensure that MBEDTLS_SSL_VERIFY_NONE remains effective
  by additionally capping the TLS version at 1.2; as of 1.3, certificate
  checking has become mandatory, and Mbed TLS respects that requirement.
- Additional tuneups to ncbi_mbedtls.c-only code:
-- Account for error-code macro repertoire changes by conditionalizing
   major-version-specific macros on their availability and specifically
   checking for or emitting MBEDTLS_ERR_PLATFORM_FEATURE_UNSUPPORTED (new)
   as appropriate,
-- x_ErrorToStatus: Conditionally use MBEDTLS_PRIVATE for p_bio, which has
   no accessor.
-- x_MbedTlsWrite: Substitute mbedtls_ssl_get_max_out_record_payload for
   mbedtls_ssl_get_output_max_frag_len, which didn't account for other
   relevant considerations and is now fully private.

https://github.com/Mbed-TLS/mbedtls/blob/development/docs/3.0-migration-guide.md
supplied useful guidance.  JIRA: CXX-13565.

git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@102329 78c7ea69-d796-4a43-9a09-de51944f1b03

Gbp-Pq: Name support_mbedtls3

16 months agoOmit convenience mbed TLS copy
Aaron M. Ucko [Thu, 2 Dec 2021 04:33:11 +0000 (23:33 -0500)]
Omit convenience mbed TLS copy

Gbp-Pq: Name system_mbedtls_only

16 months agoExtend -O1 cap to sh4, which still encountered VM exhaustion.
Aaron M. Ucko [Sun, 4 Aug 2024 20:04:02 +0000 (16:04 -0400)]
Extend -O1 cap to sh4, which still encountered VM exhaustion.

16 months agodebian/rules: Try building with -fsection-anchors on alpha
Aaron M. Ucko [Sun, 4 Aug 2024 20:00:50 +0000 (16:00 -0400)]
debian/rules: Try building with -fsection-anchors on alpha

... in hopes of satisfying the GOT size limit there too.

16 months agod/control: Forbid builds for big-endian archs, at least for now.
Aaron M. Ucko [Sun, 4 Aug 2024 19:56:43 +0000 (15:56 -0400)]
d/control: Forbid builds for big-endian archs, at least for now.

They nominally succeed, but two dependent autopkgtests (for cct and
kleborate) have started failing on s390x, and there's no evidence that
other BE architectures fare any better.  (See #1077777.)

16 months agoStart work on ncbi-blast+ 2.16.0+ds5 (more arch tuneups).
Aaron M. Ucko [Sun, 4 Aug 2024 19:52:26 +0000 (15:52 -0400)]
Start work on ncbi-blast+ 2.16.0+ds5 (more arch tuneups).

16 months agoFinalize ncbi-blast+ 2.16.0+ds-4 for unstable.
Aaron M. Ucko [Sun, 28 Jul 2024 02:38:53 +0000 (22:38 -0400)]
Finalize ncbi-blast+ 2.16.0+ds-4 for unstable.

16 months agoDeclare fast forward from 2.16.0+ds-3
Aaron M. Ucko [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
Declare fast forward from 2.16.0+ds-3

[dgit --quilt=gbp --overwrite]

16 months agoto3
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
to3

Gbp-Pq: Name 2to3

16 months agotune_lmdb_defaults
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
tune_lmdb_defaults

Gbp-Pq: Name tune_lmdb_defaults

16 months agoBypass env in Perl script shebangs.
Aaron M. Ucko [Thu, 2 Dec 2021 02:38:20 +0000 (21:38 -0500)]
Bypass env in Perl script shebangs.

Gbp-Pq: Name run_perl_directly

16 months agoSupport GCC 10+.
Aaron M. Ucko [Mon, 7 Sep 2020 02:57:35 +0000 (22:57 -0400)]
Support GCC 10+.

Debian-Bug: 957581.

* ncbifile.cpp (s_GetFileSystemInfo): Formally cast st.f_type to avoid
  narrowing errors for cases with the high bit set when that field is
  a 32-bit signed integer (as on i386).

Gbp-Pq: Name support_gcc10

16 months agoSpelling fixes
Michael R. Crusoe [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
Spelling fixes

Gbp-Pq: Name spelling

16 months agoadd missing lib for tests
Olivier Sallou [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
add missing lib for tests

Forwarded: Not-Needed
Last-Updated: 2018-02-11

Gbp-Pq: Name fix_unit_tests

16 months agoHang on to sequence data even if -parse_deflines recognized a non-local ID,
Aaron M. Ucko [Thu, 15 Dec 2016 03:44:19 +0000 (22:44 -0500)]
Hang on to sequence data even if -parse_deflines recognized a non-local ID,

   on the condition that the environment variable BLAST_ALWAYS_KEEP_SEQUENCE
   (or configuration parameter [BLAST] always_keep_sequence) is set to a
   "true" value (English-only, case-insensitive true, t, yes, y, or 1).

Gbp-Pq: Name optionally_keep_sequence

16 months agosuppress gnu TLS and mbed TLS version checks
Aaron M. Ucko [Thu, 2 Dec 2021 03:08:16 +0000 (22:08 -0500)]
suppress gnu TLS and mbed TLS version checks

   Prevent bailing when the exact compile-time and runtime GNU TLS versions
   differ; trust dpkg to disallow combinations that are actually incompatible.
   Likewise for mbed TLS.

Gbp-Pq: Name suppress_tls_version_checks

16 months agoSupport x32
Aaron M. Ucko [Thu, 2 Dec 2021 02:37:42 +0000 (21:37 -0500)]
Support x32

Avoid picking up wrong inline assembly.

Gbp-Pq: Name support_x32

16 months agofix path for debian build
Olivier Sallou [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
fix path for debian build

Forwarded: no
Last-Updated: 2014-06-06

Gbp-Pq: Name fix_configure

16 months agoremove network required test
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
remove network required test

Forwarded: no
Last-Updated: 2013-06-01

Gbp-Pq: Name skip_services_unit_test

16 months agobuild executables with -fPIE, not -fPIC
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
build executables with -fPIE, not -fPIC

* -fPIC is only useful for shared libraries; substitute -fPIE (along
   with -pie at link time) when building executables.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2012-05-10

Gbp-Pq: Name use_pie_for_apps

16 months agoavoid redundant rpath entries on multiarch systems
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
avoid redundant rpath entries on multiarch systems

 * src/build-system/configure(.ac): when ensuring that executables
   will be able to find libstdc++, don't add rpath entries that files
   under /etc/ld.so.conf.d already specify, even if they don't resemble
   traditional single-architecture or biarch locations.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2011-08-28

Gbp-Pq: Name no_multiarch_rpath

16 months agoensure that all libraries link against all direct dependencies
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
ensure that all libraries link against all direct dependencies

 * src/**/Makefile.*.lib: set DLL_(D)LIB correctly.  Break the dependency
   loop between libxblast and libxalgoblastdbindex by having the former
   provide only the C++ BLAST API, leaving the C core only in libblast.
 * src/build-system/library_relations.txt: Change xblast's
   relationship to blast from includes to needs, accordingly.
 * src/algo/blast/Makefile.blast_macros.mk: Add blast to BLAST_LIBS.
 * src/algo/blast/dbindex*/*/Makefile.*.app: Link against libxconnect
   rather than libconnect for consistency with libblast, which uses the
   former to keep the aforementioned cycle-breaking from causing
   inconsistency elsewhere.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2016-12-05

Gbp-Pq: Name fix_lib_deps

16 months agorename binary as blast+ for package coherency.
Olivier Sallou [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
rename binary as blast+ for package coherency.

Last-Updated: 2011-10-03

Gbp-Pq: Name legacy_rename_rpsblast

16 months agofix portability issues that led to Hurd build failures
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
fix portability issues that led to Hurd build failures

* src/build-system/configure(.ac):
  - Reflect the Hurd's support for -Wl,rpath,... .
* src/connect/ncbi_socket_cxx.cpp, src/connect/ext/ncbi_localnet.c:
  cope with missing PATH_MAX everywhere, not just under Windows.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2020-09-19

Gbp-Pq: Name hurd_fixes

16 months agoclean after failure
Debian Med Packaging Team [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
clean after failure

Last-Updated: 2013-06-01
Forwarded: no

Gbp-Pq: Name enable_clean_after_failed_compile

16 months agoblast+ use optout to send usage reports over internet
Olivier Sallou [Sun, 28 Jul 2024 02:38:52 +0000 (22:38 -0400)]
blast+ use optout to send usage reports over internet

Last-Updated: 202-02-10
Forwarded: no

Gbp-Pq: Name optin_usage_report

16 months ago[PATCH] Allow substituting PCRE2 for legacy PCRE by explicit request.
ucko [Thu, 18 Jul 2024 18:33:56 +0000 (18:33 +0000)]
[PATCH] Allow substituting PCRE2 for legacy PCRE by explicit request.

- For now, require opt-in via --with-components="...;PCRE2;..." (CMake),
  --with-pcre2 (traditional Unix build system), or uncommenting the
  relevant ThirdParty_PCRE2 setting in project_tree_builder.ini
  (traditional Windows build system).
- Likewise, hold off on switching the bundled copy to PCRE2 or checking
  for any functions or headers that will become of interest.
- Redundantly (for now) shun external PCRE2 in bin-release configurations.
- Otherwise favor (allowed!) external installations over the bundled
  copy, preferring PCRE2 over legacy PCRE when both are found and
  allowed but (in due course) external legacy PCRE over bundled PCRE2 in
  the absence of external PCRE2.
- In the traditional build system, have the widely used PCRE_LIBS macro
  correspond to whichever PCRE is default (when not falling back on a
  bundled copy), and add a PCRE_LEGACY_LIBS macro for the sake of
  anything using legacy PCRE directly (very occasionally seen).

JIRA: CXX-12761,

git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@102806 78c7ea69-d796-4a43-9a09-de51944f1b03

Irrelevant (and inapplicable) changes to c++/src/build-system/cmake/,
c++/src/build-system/configure (which will be regenerated anyway), and
c++/src/build-system/project_tree_builder.ini elided.

Gbp-Pq: Name allow_pcre2

16 months ago[PATCH] Accommodate Mbed TLS 3.x (specifically, 3.6.0 LTS).
ucko [Tue, 23 Apr 2024 19:21:48 +0000 (19:21 +0000)]
[PATCH] Accommodate Mbed TLS 3.x (specifically, 3.6.0 LTS).

- Conditionally pass mbedtls_pk_parse_key the existing pRNG and its state.
- Call psa_crypto_init during setup, as PSA may be in play even when not
  explicitly enabled.  Documentation suggests calling it as early as
  possible; in practice, though, holding off until after pRNG
  initialization avoids "insufficient entropy" errors under 2.x (at least
  2.28.8 LTS on Linux) and still works fine as of 3.6.0.
- At least for now, ensure that MBEDTLS_SSL_VERIFY_NONE remains effective
  by additionally capping the TLS version at 1.2; as of 1.3, certificate
  checking has become mandatory, and Mbed TLS respects that requirement.
- Additional tuneups to ncbi_mbedtls.c-only code:
-- Account for error-code macro repertoire changes by conditionalizing
   major-version-specific macros on their availability and specifically
   checking for or emitting MBEDTLS_ERR_PLATFORM_FEATURE_UNSUPPORTED (new)
   as appropriate,
-- x_ErrorToStatus: Conditionally use MBEDTLS_PRIVATE for p_bio, which has
   no accessor.
-- x_MbedTlsWrite: Substitute mbedtls_ssl_get_max_out_record_payload for
   mbedtls_ssl_get_output_max_frag_len, which didn't account for other
   relevant considerations and is now fully private.

https://github.com/Mbed-TLS/mbedtls/blob/development/docs/3.0-migration-guide.md
supplied useful guidance.  JIRA: CXX-13565.

git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@102329 78c7ea69-d796-4a43-9a09-de51944f1b03

Gbp-Pq: Name support_mbedtls3

16 months agoOmit convenience mbed TLS copy
Aaron M. Ucko [Thu, 2 Dec 2021 04:33:11 +0000 (23:33 -0500)]
Omit convenience mbed TLS copy

Gbp-Pq: Name system_mbedtls_only

16 months agoDisable parallel building on sh4
Aaron M. Ucko [Sun, 28 Jul 2024 02:37:56 +0000 (22:37 -0400)]
Disable parallel building on sh4

... in hopes of avoiding buildd virtual memory exhaustion.

16 months agoCompile with -ffunction-sections on hppa and -mxgot on mips*
Aaron M. Ucko [Sun, 28 Jul 2024 02:35:02 +0000 (22:35 -0400)]
Compile with -ffunction-sections on hppa and -mxgot on mips*

... (mips64el in practice) due to having outgrown default settings.

16 months agodebian/rules: Move architecture.mk inclusion to the very top
Aaron M. Ucko [Sun, 28 Jul 2024 02:28:38 +0000 (22:28 -0400)]
debian/rules: Move architecture.mk inclusion to the very top

... for the sake of hypothetical builds bypassing dpkg-buildpackage.

16 months agoStart ncbi-blast+ 2.16.0+ds-4 for more arch-specific tuneups.
Aaron M. Ucko [Sun, 28 Jul 2024 02:25:36 +0000 (22:25 -0400)]
Start ncbi-blast+ 2.16.0+ds-4 for more arch-specific tuneups.

16 months agoDeclare fast forward from 2.16.0+ds-2
Aaron M. Ucko [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
Declare fast forward from 2.16.0+ds-2

[dgit --quilt=gbp --overwrite]

16 months agoncbi-blast+ 2.16.0+ds-3: d/rules typo fix (missing parenthesis).
Aaron M. Ucko [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
ncbi-blast+ 2.16.0+ds-3: d/rules typo fix (missing parenthesis).

16 months agoto3
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
to3

Gbp-Pq: Name 2to3

16 months agotune_lmdb_defaults
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
tune_lmdb_defaults

Gbp-Pq: Name tune_lmdb_defaults

16 months agoBypass env in Perl script shebangs.
Aaron M. Ucko [Thu, 2 Dec 2021 02:38:20 +0000 (21:38 -0500)]
Bypass env in Perl script shebangs.

Gbp-Pq: Name run_perl_directly

16 months agoSupport GCC 10+.
Aaron M. Ucko [Mon, 7 Sep 2020 02:57:35 +0000 (22:57 -0400)]
Support GCC 10+.

Debian-Bug: 957581.

* ncbifile.cpp (s_GetFileSystemInfo): Formally cast st.f_type to avoid
  narrowing errors for cases with the high bit set when that field is
  a 32-bit signed integer (as on i386).

Gbp-Pq: Name support_gcc10

16 months agoSpelling fixes
Michael R. Crusoe [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
Spelling fixes

Gbp-Pq: Name spelling

16 months agoadd missing lib for tests
Olivier Sallou [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
add missing lib for tests

Forwarded: Not-Needed
Last-Updated: 2018-02-11

Gbp-Pq: Name fix_unit_tests

16 months agoHang on to sequence data even if -parse_deflines recognized a non-local ID,
Aaron M. Ucko [Thu, 15 Dec 2016 03:44:19 +0000 (22:44 -0500)]
Hang on to sequence data even if -parse_deflines recognized a non-local ID,

   on the condition that the environment variable BLAST_ALWAYS_KEEP_SEQUENCE
   (or configuration parameter [BLAST] always_keep_sequence) is set to a
   "true" value (English-only, case-insensitive true, t, yes, y, or 1).

Gbp-Pq: Name optionally_keep_sequence

16 months agosuppress gnu TLS and mbed TLS version checks
Aaron M. Ucko [Thu, 2 Dec 2021 03:08:16 +0000 (22:08 -0500)]
suppress gnu TLS and mbed TLS version checks

   Prevent bailing when the exact compile-time and runtime GNU TLS versions
   differ; trust dpkg to disallow combinations that are actually incompatible.
   Likewise for mbed TLS.

Gbp-Pq: Name suppress_tls_version_checks

16 months agoSupport x32
Aaron M. Ucko [Thu, 2 Dec 2021 02:37:42 +0000 (21:37 -0500)]
Support x32

Avoid picking up wrong inline assembly.

Gbp-Pq: Name support_x32

16 months agofix path for debian build
Olivier Sallou [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
fix path for debian build

Forwarded: no
Last-Updated: 2014-06-06

Gbp-Pq: Name fix_configure

16 months agoremove network required test
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
remove network required test

Forwarded: no
Last-Updated: 2013-06-01

Gbp-Pq: Name skip_services_unit_test

16 months agobuild executables with -fPIE, not -fPIC
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
build executables with -fPIE, not -fPIC

* -fPIC is only useful for shared libraries; substitute -fPIE (along
   with -pie at link time) when building executables.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2012-05-10

Gbp-Pq: Name use_pie_for_apps

16 months agoavoid redundant rpath entries on multiarch systems
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
avoid redundant rpath entries on multiarch systems

 * src/build-system/configure(.ac): when ensuring that executables
   will be able to find libstdc++, don't add rpath entries that files
   under /etc/ld.so.conf.d already specify, even if they don't resemble
   traditional single-architecture or biarch locations.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2011-08-28

Gbp-Pq: Name no_multiarch_rpath

16 months agoensure that all libraries link against all direct dependencies
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
ensure that all libraries link against all direct dependencies

 * src/**/Makefile.*.lib: set DLL_(D)LIB correctly.  Break the dependency
   loop between libxblast and libxalgoblastdbindex by having the former
   provide only the C++ BLAST API, leaving the C core only in libblast.
 * src/build-system/library_relations.txt: Change xblast's
   relationship to blast from includes to needs, accordingly.
 * src/algo/blast/Makefile.blast_macros.mk: Add blast to BLAST_LIBS.
 * src/algo/blast/dbindex*/*/Makefile.*.app: Link against libxconnect
   rather than libconnect for consistency with libblast, which uses the
   former to keep the aforementioned cycle-breaking from causing
   inconsistency elsewhere.

Debian-Bug: 633567.
Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2016-12-05

Gbp-Pq: Name fix_lib_deps

16 months agorename binary as blast+ for package coherency.
Olivier Sallou [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
rename binary as blast+ for package coherency.

Last-Updated: 2011-10-03

Gbp-Pq: Name legacy_rename_rpsblast

16 months agofix portability issues that led to Hurd build failures
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
fix portability issues that led to Hurd build failures

* src/build-system/configure(.ac):
  - Reflect the Hurd's support for -Wl,rpath,... .
* src/connect/ncbi_socket_cxx.cpp, src/connect/ext/ncbi_localnet.c:
  cope with missing PATH_MAX everywhere, not just under Windows.

Author: Aaron M. Ucko <ucko@debian.org>
Last-Update: 2020-09-19

Gbp-Pq: Name hurd_fixes

16 months agoclean after failure
Debian Med Packaging Team [Fri, 26 Jul 2024 19:37:28 +0000 (15:37 -0400)]
clean after failure

Last-Updated: 2013-06-01
Forwarded: no

Gbp-Pq: Name enable_clean_after_failed_compile