Matthias Clasen [Thu, 4 May 2023 00:18:24 +0000 (20:18 -0400)]
ci: Add meson back to the fedora image
Matthias Clasen [Wed, 3 May 2023 23:26:04 +0000 (19:26 -0400)]
ci: Add pipewire-gstreamer too
Matthias Clasen [Wed, 3 May 2023 22:49:45 +0000 (18:49 -0400)]
ci: Add pipewire to the image
And its buddy, wireplumber.
But we don't need gnome-desktop-testing
anymore, now that installed tests are gone.
Matthias Clasen [Wed, 3 May 2023 19:54:24 +0000 (19:54 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
ci: Stop running failing tests
See merge request GNOME/gtk!5913
Matthias Clasen [Wed, 3 May 2023 19:33:35 +0000 (19:33 +0000)]
Merge branch 'stop-running-failing-tests' into 'main'
ci: Stop running failing tests
See merge request GNOME/gtk!5912
Matthias Clasen [Wed, 3 May 2023 19:32:50 +0000 (15:32 -0400)]
ci: Produce less terminal output
Pass --quiet to meson test.
Less is more, in this case.
Matthias Clasen [Tue, 2 May 2023 23:30:30 +0000 (19:30 -0400)]
Fix scan-build warning
Matthias Clasen [Wed, 3 May 2023 19:10:17 +0000 (15:10 -0400)]
ci: Stop running the unstable test setups
This is just duplicating all our test runs,
for no discernible gain.
Matthias Clasen [Wed, 3 May 2023 18:41:37 +0000 (14:41 -0400)]
ci: Stop running failing tests
This makes the test output much harder to read,
and is just a waste of time.
Danial Behzadi [Wed, 3 May 2023 09:00:53 +0000 (09:00 +0000)]
Update Persian translation
(cherry picked from commit
954011ef807538b2b38b7881554f10d4788f1425)
Benjamin Otte [Tue, 2 May 2023 18:09:13 +0000 (18:09 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
build: Use generated SPIR-V files
Closes #5798
See merge request GNOME/gtk!5910
Benjamin Otte [Tue, 2 May 2023 17:48:54 +0000 (19:48 +0200)]
css: Don't transition to currentColor
Transition to the color that is in use instead.
Fixes crashes because currentColor is not an RGBA color and
therefor could not be queried later.
Fixes #5798
Benjamin Otte [Tue, 2 May 2023 17:44:06 +0000 (19:44 +0200)]
vulkan: Compute offscreen texture coords properly
Most of the time we want to compute them based on the child node we
render to the offscreen, but not always.
For blend and cross-fade nodes, they need to be computed based on the
node's bounds.
Fixes widget-factory page fade animation weirdly resizing the fading
pages.
Matthias Clasen [Tue, 2 May 2023 17:42:29 +0000 (17:42 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
Expand gtk_init docs
Closes #5781
See merge request GNOME/gtk!5909
Matthias Clasen [Tue, 2 May 2023 11:13:32 +0000 (07:13 -0400)]
Add a comment to pango.wrap
So we remember the next time we try to
switch to stable dependencies.
Matthias Clasen [Tue, 2 May 2023 17:17:41 +0000 (13:17 -0400)]
Expand gtk_init docs
Make it clear that some aspects of GApplication
functionality happen before startup.
Fixes: #5781
Matthias Clasen [Tue, 2 May 2023 13:29:20 +0000 (13:29 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
Don't build fribidi docs
See merge request GNOME/gtk!5906
Matthias Clasen [Tue, 2 May 2023 10:36:18 +0000 (06:36 -0400)]
Make run-test.sh easier to use locally
Set a default timeout multiplier so we don't
have to rememver obscure environment variables.
Matthias Clasen [Tue, 2 May 2023 10:22:44 +0000 (06:22 -0400)]
Go back to fribidi master
Fribidi 1.0.12 does not work as a subproject :(
Matthias Clasen [Tue, 2 May 2023 10:22:24 +0000 (06:22 -0400)]
Don't build fribidi docs
There's no need for that. This matches what pango does.
Benjamin Otte [Tue, 2 May 2023 06:47:10 +0000 (08:47 +0200)]
vulkan: Rebuild SPIR-V files
It's been a while since somebody last compiled them, glslc should be
somewhat newer by now.
Benjamin Otte [Tue, 2 May 2023 06:41:43 +0000 (08:41 +0200)]
build: Use generated SPIR-V files
We weren't looking in the build dir for generated files.
Actually make sure that we look in the build dir *first*, otherwise
glib-compile-resources will still use the wrong files.
Matthias Clasen [Tue, 2 May 2023 02:23:34 +0000 (22:23 -0400)]
Use pango main as subproject
This is necessary to get the latest pango docs
built in ci.
Matthias Clasen [Tue, 2 May 2023 03:49:42 +0000 (23:49 -0400)]
stop using deprecated pango api
Matthias Clasen [Tue, 2 May 2023 01:11:01 +0000 (21:11 -0400)]
ci: Add mutter to the fedora image
This is in preparation for trying to use mutter --headless
in ci.
Matthias Clasen [Mon, 1 May 2023 21:06:32 +0000 (21:06 +0000)]
Merge branch 'gsk-flip-tests' into 'main'
more gsk tests
See merge request GNOME/gtk!5811
Matthias Clasen [Mon, 1 May 2023 20:41:13 +0000 (20:41 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
Cosmetics: Unset baseline too
See merge request GNOME/gtk!5904
Matthias Clasen [Mon, 1 May 2023 20:00:24 +0000 (16:00 -0400)]
Skip some tests with small textures
When textures are too large, we will scale them down
to fit the max texture size, which will cause comparisons
to fail.
Matthias Clasen [Mon, 1 May 2023 20:15:11 +0000 (16:15 -0400)]
Cosmetics: Unset baseline too
We set width and height to 0 when unrealizing
a widget. No reason to let the baseline value
linger.
Matthias Clasen [Mon, 1 May 2023 20:03:44 +0000 (20:03 +0000)]
Merge branch 'better-switch-docs' into 'main'
switch: Expand the docs
See merge request GNOME/gtk!5903
Matthias Clasen [Mon, 1 May 2023 19:15:25 +0000 (15:15 -0400)]
switch: Expand the docs
Add more text and explanation around active vs state,
since people seem easily confused by it.
Matthias Clasen [Mon, 1 May 2023 18:46:30 +0000 (14:46 -0400)]
gsk: Fix rendering big textures with offsets
When slicing the texture, the GL renderer was
forgetting to apply the viewport origin. This
shows up when rendering things with negative
scales, leading to negative origins.
Matthias Clasen [Mon, 1 May 2023 17:58:00 +0000 (13:58 -0400)]
Improve test coverage
Check that our two rounded rect intersection functions agree.
Matthias Clasen [Mon, 1 May 2023 17:33:26 +0000 (13:33 -0400)]
gsk: Give up on one test
The rounded-clip-in-clip-3d test fails in GL when
flipped. Given that it was already excluded from cairo,
and also fails cairo when flipped, give up on it for now.
Matthias Clasen [Mon, 1 May 2023 17:28:27 +0000 (13:28 -0400)]
gsk: Extract scales properly from 2D transforms
We have the code to do it properly.
Matthias Clasen [Mon, 1 May 2023 13:52:46 +0000 (09:52 -0400)]
Improve rounded rect intersection
Move the rounded rect/rect intersection code to
gskroundedrect.c, make it more precise, and add
tests for it.
Update the callers in the GL renderer.
Matthias Clasen [Mon, 1 May 2023 00:40:00 +0000 (20:40 -0400)]
gsk: Fix mask transform handling
We must reset the modelview transform when
offscreen, or else we end up applying
it twice.
Matthias Clasen [Mon, 1 May 2023 00:28:12 +0000 (20:28 -0400)]
Add a test for rotated blend nodes
Matthias Clasen [Mon, 1 May 2023 00:27:38 +0000 (20:27 -0400)]
gsk: Fix blend transform handling
We must reset the modelview transform when
rendering offscreen, or else we end up applying
it twice.
Matthias Clasen [Mon, 1 May 2023 00:20:12 +0000 (20:20 -0400)]
Add a test for rotated cross-fade nodes
This one checks that we don't apply the modelview
transform twice with cross-fades.
Matthias Clasen [Mon, 1 May 2023 00:21:47 +0000 (20:21 -0400)]
gsk: Fix cross-fade transform handling
We must reset the modelview transform when
rendering offscreen, or else we end up applying
it twice.
Matthias Clasen [Mon, 1 May 2023 17:39:23 +0000 (13:39 -0400)]
gsk: More fixes
Work towards handling negative scales and
denormalized rects everywhere.
Matthias Clasen [Sun, 30 Apr 2023 20:16:32 +0000 (16:16 -0400)]
Add another test
Matthias Clasen [Sun, 30 Apr 2023 15:19:47 +0000 (11:19 -0400)]
gsk: Transform rounded rects better
Matthias Clasen [Sat, 15 Apr 2023 20:55:24 +0000 (22:55 +0200)]
Add another gsk test
Matthias Clasen [Sat, 15 Apr 2023 20:50:34 +0000 (22:50 +0200)]
gsk: Normalize rects in GLSL
Our coverage computation only works for well-behaved
rects and rounded rects. But our modelview transform
might flip x or y around, causing things to fail.
Add functions to normalize rects and rounded rects,
and use it whenever we transform a rounded rect in GLSL.
Matthias Clasen [Fri, 14 Apr 2023 07:22:01 +0000 (09:22 +0200)]
testsuite: Fix gsk test
The repeated tests were not careful enough to produce
the correct reference image to match what the repeat
node does.
With these changes, all cairo tests pass.
Matthias Clasen [Tue, 11 Apr 2023 08:58:26 +0000 (10:58 +0200)]
testsuite: Add more gsk tests
Add separate suites for running the gsk compare-render
tests with the --flip, --rotate or --repeat options.
A bunch of these fail currently, and need diagnosis.
Matthias Clasen [Mon, 10 Apr 2023 07:40:31 +0000 (09:40 +0200)]
Add more gsk tests
Add options to the gsk compare-render test for
modifying the node (and do a matching change to
the reference image).
flip: negative scale flipping things horizontally
rotate: 90 degree rotation
repeat: 2x2 grid
Matthias Clasen [Sun, 30 Apr 2023 20:22:39 +0000 (16:22 -0400)]
Add another transform test
Test that transforming bounds with negative scales
works as expected.
Matthias Clasen [Mon, 1 May 2023 16:56:40 +0000 (16:56 +0000)]
Merge branch 'displaymanager-warning-fix' into 'main'
Avoid a bad warning
See merge request GNOME/gtk!5901
Matthias Clasen [Mon, 1 May 2023 14:35:24 +0000 (10:35 -0400)]
Avoid a bad warning
This isn't what we intended, and it breaks CI for
various projects.
Georges Basile Stavracas Neto [Mon, 1 May 2023 14:00:43 +0000 (14:00 +0000)]
Merge branch 'alatiera/vulkan-headers-fix' into 'main'
vulkan: Correct error enum version guards
See merge request GNOME/gtk!5900
Jordan Petridis [Mon, 1 May 2023 06:38:33 +0000 (09:38 +0300)]
vulkan: Correct error enum version guards
Vulkan 218 introduced these errors by they were marked as
the beta till version 238.
https://github.com/KhronosGroup/Vulkan-Headers/commit/
00671c64ba5c488ade22ad572a0ef81d5e64c803#diff-
e222ae95c2b0d5082b94d6086fb1c24da18ee31384c1a39840df3b9152023ee6
Followup to
f9b2d3104a681b3e2bb2c32c98e1d992fdd29034
Matthias Clasen [Sun, 30 Apr 2023 22:39:57 +0000 (22:39 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
docs: Migration guide updates
See merge request GNOME/gtk!5899
Matthias Clasen [Sun, 30 Apr 2023 22:29:11 +0000 (22:29 +0000)]
Merge branch 'emojichooser-variation-fix' into 'main'
emojichooser: Avoid extraneous variation selectors
See merge request GNOME/gtk!5898
Matthias Clasen [Sat, 29 Apr 2023 20:15:02 +0000 (16:15 -0400)]
docs: Migration guide updates
Mention various widget size apis going away.
Matthias Clasen [Sun, 30 Apr 2023 22:21:23 +0000 (18:21 -0400)]
gsk: Plug a few memory leaks
Matthias Clasen [Sun, 30 Apr 2023 15:55:17 +0000 (11:55 -0400)]
emojichooser: Avoid extraneous variation selectors
Only add a variation selector if there isn't one already.
Daniel Boles [Sun, 30 Apr 2023 15:55:31 +0000 (16:55 +0100)]
migrating-3to4: Fix unescaped ptr * used as italic
Daniel Boles [Sun, 30 Apr 2023 15:36:10 +0000 (16:36 +0100)]
gtk-demo/listbox: Fix 0 space between nick & date,
by restoring the right-alignment that gtk-3-24 has here, but we had lost
– I guess because we dropped the default child expand and pack-end props
Daniel Boles [Sun, 30 Apr 2023 15:05:11 +0000 (16:05 +0100)]
Inscription|InfoBar: Fix small cosmetic issue@docs
Daniel Boles [Sun, 30 Apr 2023 11:37:55 +0000 (11:37 +0000)]
Merge branch 'dboles/expander-css-nodes-doc' into 'main'
Expander: Clarify/format “CSS nodes” documentation
See merge request GNOME/gtk!5896
Daniel Boles [Sat, 29 Apr 2023 21:38:21 +0000 (22:38 +0100)]
Expander: Clarify/format CSS nodes documentation
Use backticks to highlight the node names, mention the box, and clarify
that the arrow referred to in the last sentence is the `expander` node.
Matthias Clasen [Sat, 29 Apr 2023 18:55:45 +0000 (18:55 +0000)]
Merge branch 'deprecated-get-allocated-width' into 'main'
Deprecated get allocated width
See merge request GNOME/gtk!5894
Matthias Clasen [Sat, 29 Apr 2023 18:30:59 +0000 (18:30 +0000)]
Merge branch 'box-baseline-child' into 'main'
boxlayout: Add a baseline child property
See merge request GNOME/gtk!5891
Matthias Clasen [Sat, 29 Apr 2023 18:27:59 +0000 (14:27 -0400)]
Deprecate gtk_widget_get_allocated_width
Matthias Clasen [Sat, 29 Apr 2023 18:27:39 +0000 (14:27 -0400)]
tests: Stop using gtk_widget_get_allocated_width
Matthias Clasen [Sat, 29 Apr 2023 18:10:53 +0000 (14:10 -0400)]
gtk4-demo: Stop using gtk_widget_get_allocated_size
Matthias Clasen [Sat, 29 Apr 2023 18:00:30 +0000 (14:00 -0400)]
popover: Stop using gtk_widget_get_allocated_width
Matthias Clasen [Sat, 29 Apr 2023 17:59:15 +0000 (13:59 -0400)]
placesview: Stop using gtk_widget_get_allocated_width
Matthias Clasen [Sat, 29 Apr 2023 17:58:15 +0000 (13:58 -0400)]
placessidebar: Stop using gtk_widget_get_allocated_width
Matthias Clasen [Sat, 29 Apr 2023 17:54:14 +0000 (13:54 -0400)]
columnview: Stop using gtk_widget_get_allocated_width
Matthias Clasen [Sat, 29 Apr 2023 18:29:14 +0000 (18:29 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
widget: Cosmetics
See merge request GNOME/gtk!5892
Benjamin Otte [Sat, 29 Apr 2023 18:11:21 +0000 (18:11 +0000)]
Merge branch 'wip/carlosg/x11-artifacts' into 'main'
gdk/x11: Invalidate whole surface after size change
See merge request GNOME/gtk!5857
Matthias Clasen [Sat, 29 Apr 2023 17:46:47 +0000 (13:46 -0400)]
docs: Mention baselines
Add a paragraph about baselines to the coordinates overview.
Matthias Clasen [Sat, 29 Apr 2023 17:35:24 +0000 (13:35 -0400)]
widget: Cosmetics
Rename allocated_size_baseline to allocated_baseline,
to match better with the other allocated_ fields.
Matthias Clasen [Sat, 29 Apr 2023 16:00:15 +0000 (12:00 -0400)]
spinbutton: Use GtkBoxLayout:baseline-child
This makes it so that vertical spin buttons are
properly aligned to the baseline.
Matthias Clasen [Sat, 29 Apr 2023 15:55:27 +0000 (11:55 -0400)]
Revert "spinbutton: Use a grid layout"
This reverts commit
d648a7721e826717fb2c675d8202ab34e879d521.
Matthias Clasen [Thu, 27 Apr 2023 12:57:09 +0000 (14:57 +0200)]
boxlayout: Add a baseline child property
In horizontal layout, we line up the baselines of all children to find
how much space we need above and below the box baseline.
In vertical layout, we need to pick one child to inherit the baseline
from, which is what the new GtkBoxLayout:baseline-child property is
about. It is the equivalent of GtkGridLayout:baseline-row.
Daniel Boles [Sat, 29 Apr 2023 17:12:30 +0000 (18:12 +0100)]
EventController: Fix type "even propagation"→event
Matthias Clasen [Sat, 29 Apr 2023 15:45:39 +0000 (11:45 -0400)]
Remove more debug spew
Matthias Clasen [Sat, 29 Apr 2023 14:16:42 +0000 (14:16 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
entry: Ignore the baseline when centering
See merge request GNOME/gtk!5889
Matthias Clasen [Sat, 29 Apr 2023 13:47:59 +0000 (09:47 -0400)]
widget: Don't set baselines when unused
When we are not doing baseline alignment, don't pass
a baseline to the allocated widget. This helps because
a number of widgets (GtkLabel, GtkEntry, etc) always
position their text on the given baseline.
Matthias Clasen [Sat, 29 Apr 2023 13:20:07 +0000 (09:20 -0400)]
entry: Ignore the baseline when centering
GtkEntry was always placing its text on the baseline,
even when the valign said something else.
Matthias Clasen [Sat, 29 Apr 2023 12:27:23 +0000 (12:27 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
theme: Reinstate switch labels in hc
See merge request GNOME/gtk!5888
Matthias Clasen [Sat, 29 Apr 2023 12:00:07 +0000 (08:00 -0400)]
testbaseline2: Don't set height-requests
Widget with height requests have their baselines
ignored. Oops.
Matthias Clasen [Sat, 29 Apr 2023 11:58:42 +0000 (07:58 -0400)]
theme: Reinstate switch labels in hc
Since we show them in GNOME shell, show them here too.
The comment that says "only show these in the a11y
theme" was still there, but we were always hiding them.
Carlos Garnacho [Fri, 21 Apr 2023 08:58:19 +0000 (10:58 +0200)]
gdk/x11: Invalidate whole surface after size change
The Expose events following a ConfigureNotify may arrive at
a time that we did not resize the surface yet, making these
expose events a no-op. Even though gsk/gtk take care of the
window content itself, this might lead to unrendered portions
of the window shadow.
This may be seen with GSK_RENDERER=cairo and GDK_BACKEND=x11,
attempting to tile a window (e.g. gtk4-demo) left or right.
The window will show black rectangles or other artifacts in
the window shadow areas that correspond to the newly painted
portions (as the window needs to expand vertically).
In order to fix this with a similar behavior to Wayland,
consider ourselves the whole surface invalidated after resize,
in order to ensure everything is painted from scratch.
Fabio Tomat [Sat, 29 Apr 2023 08:57:53 +0000 (08:57 +0000)]
Update Friulian translation
Benjamin Otte [Sat, 29 Apr 2023 03:43:45 +0000 (03:43 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
wayland: Use wl_surface_damage_buffer() in Cairo
See merge request GNOME/gtk!5886
Benjamin Otte [Fri, 28 Apr 2023 02:28:23 +0000 (04:28 +0200)]
rendernode: Add diffing for affine transforms
This will be needed most importantly for inverted textures,
like in GLArea.
Benjamin Otte [Sat, 29 Apr 2023 03:07:03 +0000 (05:07 +0200)]
wayland: Use wl_surface_damage_buffer() in Cairo
... when it is available.
Also introduce the new function gdk_rectangle_transform_affine(), which
looks like overkill for this purpose, but I'm about to use it elsewhere.
Matthias Clasen [Sat, 29 Apr 2023 01:15:58 +0000 (01:15 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
shortcutswindow: Avoid criticals
See merge request GNOME/gtk!5885
Matthias Clasen [Sat, 29 Apr 2023 00:44:18 +0000 (20:44 -0400)]
shortcutswindow: Avoid criticals
No point in resetting accessible relations
when we are in finalize.
Matthias Clasen [Fri, 28 Apr 2023 23:00:31 +0000 (23:00 +0000)]
Merge branch 'clarify-swapped-default-object-signal' into 'main'
builder: Clarify default "swapped" value when "object" is set for signals
See merge request GNOME/gtk!4514
Matthias Clasen [Fri, 28 Apr 2023 22:57:10 +0000 (22:57 +0000)]
Merge branch 'gtkshortcutswindow_a11y' into 'main'
GtkShortcutsWindow: Allow a screen reader user to browse the available shortcuts
See merge request GNOME/gtk!5042
Matthias Clasen [Fri, 28 Apr 2023 22:55:42 +0000 (22:55 +0000)]
Merge branch 'harmonize-would_drop' into 'main'
Harmonize would_drop() replacement for g_log_writer_default_would_drop()
See merge request GNOME/gtk!4935
Matthias Clasen [Fri, 28 Apr 2023 22:49:42 +0000 (22:49 +0000)]
Merge branch 'deprecate-get-allocation' into 'main'
Deprecate get allocation
See merge request GNOME/gtk!5882
Matthias Clasen [Fri, 28 Apr 2023 21:29:08 +0000 (17:29 -0400)]
README: Updates
Drop the section that talked about main and how to update
local checkouts - its been 2 years, people should have gotten
around to it by now. Add some general git hints instead.