Hannah von Reth [Thu, 26 Nov 2020 14:03:11 +0000 (15:03 +0100)]
Fix test on systems where C:\ is not writeable
Hannah von Reth [Mon, 23 Nov 2020 12:04:45 +0000 (13:04 +0100)]
Don't recurse the whole tree looking for a git dir, use PROJECT_SOURCE_DIR
Hannah von Reth [Mon, 16 Nov 2020 14:18:22 +0000 (15:18 +0100)]
Fix usePlaceholders migration
Hannah von Reth [Mon, 2 Nov 2020 12:24:43 +0000 (13:24 +0100)]
Remove junk files
Hannah von Reth [Thu, 29 Oct 2020 08:47:40 +0000 (09:47 +0100)]
Fix vfs experimental text
Hannah von Reth [Thu, 22 Oct 2020 15:12:00 +0000 (17:12 +0200)]
Fix folder permission check on NTFS
Fixes: #8187
Hannah von Reth [Thu, 22 Oct 2020 10:10:24 +0000 (12:10 +0200)]
Fix condition
Hannah von Reth [Wed, 21 Oct 2020 14:48:22 +0000 (16:48 +0200)]
Append .exe to crashreporter path so it is better located
Hannah von Reth [Mon, 19 Oct 2020 14:27:45 +0000 (16:27 +0200)]
Ensure the callback is triggered
Hannah von Reth [Thu, 15 Oct 2020 14:05:51 +0000 (16:05 +0200)]
Don`t block main thread when displaying all files removed dialog
Fixes: #8170
Hannah von Reth [Thu, 15 Oct 2020 13:12:16 +0000 (15:12 +0200)]
Don't use exec() on dialogs
Hannah von Reth [Mon, 19 Oct 2020 13:22:51 +0000 (15:22 +0200)]
Update libcrashreporter-qt
Hannah von Reth [Mon, 19 Oct 2020 13:29:51 +0000 (15:29 +0200)]
Draw active progressbar
Pass a widget to the progressbar in the folder delegate to draw the correct active state
Kevin Ottens [Thu, 10 Dec 2020 13:40:25 +0000 (14:40 +0100)]
Remove the plugin loader mechanism for VFS backends
We will have all the code in public anyway so it can just be compiled
in. Thus no need to go through the plugin loading dance. Replaced the
loading with factory functions. Kept mostly the same structure
otherwise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Thu, 10 Dec 2020 11:35:16 +0000 (12:35 +0100)]
Allow to control availability of folders in the settings dialog
It felt odd to be able to control the encryption status in the settings
dialog but not the availability. Also availability was controllable on
the root, so let's make it widely available.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Wed, 9 Dec 2020 15:54:49 +0000 (16:54 +0100)]
Resurrect the display of subfolders for VFS sync folders
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.
So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 17:05:29 +0000 (18:05 +0100)]
Update the FolderStatusModel when a folder encryption ends
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 16:09:24 +0000 (17:09 +0100)]
Set the account state after E2EE is setup in the GUI
Otherwise we would not display the E2EE message if the account was
connected before the creation of the settings dialog. This was likely
caused by the delayed creation of the settings dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Thu, 10 Dec 2020 10:12:11 +0000 (11:12 +0100)]
Remove empty action in the settings toolbar
This was causing an unwanted line in the middle of the bar.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 15:59:06 +0000 (16:59 +0100)]
Fix typo and style
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 15:23:31 +0000 (16:23 +0100)]
Get rid of now unused GetFolderEncryptStatusJob
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 15:20:29 +0000 (16:20 +0100)]
Remove the encryption flag check from encrypted propagation code
If we use those encrypted propagation code paths, we already know from
the discovery phase (and thus the journal db) that the folders are
encrypted so no need to check again.
This will remove another expensive round trip with the server.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 14:51:48 +0000 (15:51 +0100)]
Remove encrypt status job fetching from ClientSideEncryption
This is now unused.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 14:49:29 +0000 (15:49 +0100)]
No need to fetch encryption data separately before discovery
This step isn't necessary anymore, no one looks at ClientSideEncryption
for that information anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 14:42:28 +0000 (15:42 +0100)]
Remove unused methods on ClientSideEncryption
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 8 Dec 2020 14:36:17 +0000 (15:36 +0100)]
Stop using e2e()->isFolderEncrypted() in the folder wizard
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 18:37:21 +0000 (19:37 +0100)]
FolderStatusModel now uses the LSCOL job result for encryption status
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 18:12:21 +0000 (19:12 +0100)]
FolderStatusModel LSCOL job now gets the is-encrypted property
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 17:42:24 +0000 (18:42 +0100)]
Stop using e2e()->isFolderEncrypted() in the jobs
Thanks to the new discovery algorithm, we got all the freshest E2EE
information straight from the database so reuse it instead of going
through an in memory copy.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 17:17:14 +0000 (18:17 +0100)]
Set the encrypted flag in the database when EncryptFolderJob succeeds
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 17:12:45 +0000 (18:12 +0100)]
Change EncryptFolderJob path convention
It had a different path convention than all the other jobs, most likely
for legacy reasons because of the tight coupling it had to the settings
dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 16:38:18 +0000 (17:38 +0100)]
Have the folder token inside the EncryptFolderJob
No need to look for a token on the outside we can just work properly by
keeping all the state encapsulated in the job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 7 Dec 2020 15:33:36 +0000 (16:33 +0100)]
Don't use getFileRecordByE2eMangledName in jobs anymore
Thanks to the new discovery algorithm we got both mangled and original
file names in the item so no need to go through the database for
nothing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 1 Dec 2020 17:46:29 +0000 (18:46 +0100)]
Repair E2EE deletions
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 1 Dec 2020 11:45:01 +0000 (12:45 +0100)]
Make sure the encrypted flag gets all the way to the journal db
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Tue, 1 Dec 2020 11:33:29 +0000 (12:33 +0100)]
Repair E2EE uploads
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 30 Nov 2020 17:14:05 +0000 (18:14 +0100)]
Start hooking up E2EE to the new discovery algorithm
Now we pull the encrypted metadata during the discovery which is a
better approach than before. This shall remove the need for some of the
deep propfinds we have been using so far. It already simplifies the code
a bit for the download scenario.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Kevin Ottens [Mon, 30 Nov 2020 11:47:17 +0000 (12:47 +0100)]
Repair the Windows Build
We now enforce the use of QStringLiteral and friends in some places,
but that feel through the cracks for some of the Windows specific code.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Hannah von Reth [Wed, 21 Oct 2020 10:31:21 +0000 (12:31 +0200)]
VirtualFiles: Ensure the target location supports vfs
Fixes: #8131
Hannah von Reth [Wed, 21 Oct 2020 12:51:43 +0000 (14:51 +0200)]
Log error code as hex
Hannah von Reth [Tue, 13 Oct 2020 13:52:33 +0000 (15:52 +0200)]
Fix: Log chunked messages
Hannah von Reth [Mon, 5 Oct 2020 15:05:58 +0000 (17:05 +0200)]
Remove vfs warning in the delegate, indicate them in the description instead
Fixes: #8139
Hannah von Reth [Tue, 22 Sep 2020 09:47:40 +0000 (11:47 +0200)]
Use verbose function names instead of direct member access
Hannah von Reth [Fri, 18 Sep 2020 11:42:42 +0000 (13:42 +0200)]
Don't show 404 errors when manually creating folder sync pair.
Fixes: #7724
Hannah von Reth [Thu, 17 Sep 2020 09:16:12 +0000 (11:16 +0200)]
Use winvfs by default when adding folder sync connection
Fixes: #8083
Hannah von Reth [Tue, 15 Sep 2020 14:07:14 +0000 (16:07 +0200)]
Clear cookies on logout
Hannah von Reth [Mon, 10 Aug 2020 14:22:56 +0000 (16:22 +0200)]
Remove the use of goto from test/csync/std_tests/check_std_c_jhash.c
Hannah von Reth [Mon, 10 Aug 2020 14:22:38 +0000 (16:22 +0200)]
Remove the use of goto from src/csync/csync_exclude.cpp
Hannah von Reth [Mon, 14 Sep 2020 10:31:14 +0000 (12:31 +0200)]
Log http status
Fixes: #8073
Hannah von Reth [Fri, 17 Jul 2020 12:28:16 +0000 (14:28 +0200)]
Fix placeholders are reverted to OnlineOnly
Fixes: #7779
Hannah von Reth [Mon, 7 Sep 2020 09:58:50 +0000 (11:58 +0200)]
Crashreporter: Apply the same hdpi settings as to the main gui
Fixes: #8042
Hannah von Reth [Fri, 27 Nov 2020 11:00:46 +0000 (12:00 +0100)]
Improve log message
Hannah von Reth [Mon, 17 Aug 2020 13:31:21 +0000 (15:31 +0200)]
Windows VFS: Enable Windows VFS by default
Hannah von Reth [Fri, 14 Aug 2020 14:15:30 +0000 (16:15 +0200)]
Return empty string instead of 1 as adler32 checksum for empty files
Hannah von Reth [Fri, 14 Aug 2020 13:40:14 +0000 (15:40 +0200)]
Print checksum on mismatch
Hannah von Reth [Thu, 23 Jul 2020 11:51:36 +0000 (13:51 +0200)]
Clazy: Fix some warnings
Hannah von Reth [Tue, 11 Aug 2020 08:30:19 +0000 (10:30 +0200)]
Remove pointless warning
We also don't have a version entry in the db if thne db is new.
As I don't expect regular updates from 1.5 this message can just be removed.
Fixes: #8004
Hannah von Reth [Fri, 31 Jul 2020 07:25:37 +0000 (09:25 +0200)]
csync: apply strict QString handling
Hannah von Reth [Thu, 23 Jul 2020 10:40:58 +0000 (12:40 +0200)]
Clazy: Fix some warnigns
Hannah von Reth [Thu, 23 Jul 2020 10:39:40 +0000 (12:39 +0200)]
Ui: Hide selective sync settings if vfs is active
Fixes: #7976
Hannah von Reth [Wed, 22 Jul 2020 19:06:09 +0000 (21:06 +0200)]
Fix assertion introduced by
e1ca612c5d3087e02f6b7f8e454224e0b88e82ad
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\
17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787
e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
Hannah von Reth [Wed, 22 Jul 2020 19:02:09 +0000 (21:02 +0200)]
Use const access where possible
Hannah von Reth [Mon, 27 Jul 2020 08:44:51 +0000 (10:44 +0200)]
csync: apply strict QString handling
Hannah von Reth [Mon, 27 Jul 2020 07:48:32 +0000 (09:48 +0200)]
VFS: remove now unused parameter
Hannah von Reth [Fri, 24 Jul 2020 15:16:28 +0000 (17:16 +0200)]
Use the servers checksum type by default
Hannah von Reth [Fri, 27 Nov 2020 10:26:41 +0000 (11:26 +0100)]
Log state before specific assertion
Hannah von Reth [Wed, 8 Jul 2020 14:27:48 +0000 (16:27 +0200)]
Win: Use full Windows paths in file watcher and improve logging
Hannah von Reth [Wed, 8 Jul 2020 10:38:01 +0000 (12:38 +0200)]
Win: Move hresultToQString from vfs plugin to Utility::formatWinError
Hannah von Reth [Thu, 16 Jul 2020 12:21:38 +0000 (14:21 +0200)]
Remove more legacy C code
Hannah von Reth [Thu, 16 Jul 2020 09:59:44 +0000 (11:59 +0200)]
Tests: Port check_vio_ext to Windows
Hannah von Reth [Fri, 27 Nov 2020 10:13:54 +0000 (11:13 +0100)]
Remove custome string functions
Hannah von Reth [Fri, 17 Jul 2020 12:01:48 +0000 (14:01 +0200)]
Logging: Print enum before cast in SqlQuer::bindValue
Hannah von Reth [Tue, 14 Jul 2020 10:49:18 +0000 (12:49 +0200)]
Fix warning
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
Hannah von Reth [Wed, 8 Jul 2020 13:49:27 +0000 (15:49 +0200)]
Log: Only print 'Saved account settings' in debug mode
Don't log that there was no error...
Hannah von Reth [Fri, 3 Jul 2020 11:16:09 +0000 (13:16 +0200)]
Log: Improve log message [ info gui.folder ]: Folder sync result: 4...
by including the name of the folder and print the name of the result
Hannah von Reth [Fri, 3 Jul 2020 08:02:53 +0000 (10:02 +0200)]
Gui: Don't try to display the wizard during shutdown
Fixes: #7936
Hannah von Reth [Fri, 3 Jul 2020 11:13:38 +0000 (13:13 +0200)]
Remove dead code
Hannah von Reth [Mon, 29 Jun 2020 12:53:40 +0000 (14:53 +0200)]
Make ownCloud accassible on the Application object
Hannah von Reth [Thu, 25 Jun 2020 14:25:11 +0000 (16:25 +0200)]
Remove ifdef(Q_OS_X11) code, there never was such a define.
As noone complained since I don't think anyone will miss the code
Hannah von Reth [Mon, 29 Jun 2020 11:45:48 +0000 (13:45 +0200)]
A pedantic .desktop parser want's a list to end with ;
Hannah von Reth [Thu, 18 Jun 2020 14:12:35 +0000 (16:12 +0200)]
VFS: Tell the vfs plugin whether we have multiple accounts
This allows us to decide on the presentation of the account
Hannah von Reth [Mon, 22 Jun 2020 11:14:37 +0000 (13:14 +0200)]
UnitTests: Set a CookiesJar in FakeQNAM
Hannah von Reth [Thu, 18 Jun 2020 11:16:36 +0000 (13:16 +0200)]
CMake: Remove krazy2 support, we now use clazy
Hannah von Reth [Thu, 18 Jun 2020 14:10:02 +0000 (16:10 +0200)]
VFS: Prevent duplicated navigation panel icon
Issue: #7748
Hannah von Reth [Mon, 8 Jun 2020 13:08:13 +0000 (15:08 +0200)]
Log HTTP requests and responses
Issue: #7873
Hannah von Reth [Tue, 2 Jun 2020 12:46:36 +0000 (14:46 +0200)]
Beautify flags
Hannah von Reth [Fri, 29 May 2020 12:40:40 +0000 (14:40 +0200)]
Hannah von Reth [Fri, 29 May 2020 12:36:41 +0000 (14:36 +0200)]
Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value
Hannah von Reth [Fri, 29 May 2020 11:29:46 +0000 (13:29 +0200)]
Hannah von Reth [Fri, 29 May 2020 09:00:21 +0000 (11:00 +0200)]
Fix crash on settings migration
Fixes: #7878
Hannah von Reth [Tue, 26 May 2020 09:51:35 +0000 (11:51 +0200)]
Fix usage of QMessageBox
Fixes: #7874
Hannah von Reth [Tue, 12 May 2020 12:10:02 +0000 (14:10 +0200)]
Fix order of pluginkit commands and modernise
Hannah von Reth [Wed, 13 May 2020 15:34:41 +0000 (17:34 +0200)]
Use separate loggin category for upload v1 and ng
Hannah von Reth [Tue, 5 May 2020 10:32:15 +0000 (12:32 +0200)]
Wizard: Raise own window
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
Hannah von Reth [Mon, 4 May 2020 13:54:11 +0000 (15:54 +0200)]
VFS Dialog: Don't enable on close button clicked
Issue: #7710
Hannah von Reth [Thu, 23 Apr 2020 08:34:41 +0000 (10:34 +0200)]
Remove unused struct
Hannah von Reth [Thu, 23 Apr 2020 08:28:07 +0000 (10:28 +0200)]
Remvoe now unneeded SyncRunFileLog::directionToStr
Hannah von Reth [Thu, 23 Apr 2020 08:25:03 +0000 (10:25 +0200)]
Remvoe now unneeded SyncRunFileLog::instructionToStr
Hannah von Reth [Wed, 22 Apr 2020 13:15:55 +0000 (15:15 +0200)]
Cleanup moc_csync.cpp include
Hannah von Reth [Wed, 22 Apr 2020 13:23:18 +0000 (15:23 +0200)]
Rename csync_instructions_e -> SyncInsturctions