Timm Bäder [Sun, 29 Sep 2019 06:39:12 +0000 (08:39 +0200)]
widget-factory: Skip xml files in background selection dialog
The default contains a xml file for an animated background, so don't try
loading it as a pixbuf.
Timm Bäder [Sun, 29 Sep 2019 05:57:43 +0000 (07:57 +0200)]
widget: Plug layout manager leak
Timm Bäder [Sat, 28 Sep 2019 10:37:00 +0000 (12:37 +0200)]
modelbutton: Rework
Create all the widgets on demand and use a box layout to arrange them
instead of manual size allocation.
Also don't inherit from GtkButton
Timm Bäder [Sat, 28 Sep 2019 11:34:16 +0000 (13:34 +0200)]
button: Remove unused signal enum members
Timm Bäder [Sat, 28 Sep 2019 08:32:14 +0000 (10:32 +0200)]
modelbutton: Use a box layout
Timm Bäder [Sat, 28 Sep 2019 08:30:35 +0000 (10:30 +0200)]
modelbutton: Replace map() with root()
Timm Bäder [Sat, 28 Sep 2019 08:08:50 +0000 (10:08 +0200)]
modelbutton: Remove end_box
it's unused.
Timm Bäder [Sat, 28 Sep 2019 08:03:08 +0000 (10:03 +0200)]
modelbutton: Create accel label on demand
Timm Bäder [Sat, 28 Sep 2019 07:15:56 +0000 (09:15 +0200)]
Adwaita: Blue check/radiobuttons
Align with 3.24.
Feichtmeier [Tue, 23 Jul 2019 16:24:34 +0000 (18:24 +0200)]
Tiny refactoring
- use checkradio_fg_color for check/radio in treeview, which points to fg_color, so no change of the hex color, thus no change to the parsed CSS
frederik.feichtmeier [Fri, 26 Jul 2019 12:10:15 +0000 (08:10 -0400)]
Adwaita: Add color defines from 3.24
Jakub Steiner [Mon, 29 Jul 2019 08:03:19 +0000 (10:03 +0200)]
Adwaita: make links in infobars legible
- No longer tinted blue, make legible
Fixes https://gitlab.gnome.org/GNOME/gnome-software/issues/751
Timm Bäder [Sat, 28 Sep 2019 06:45:11 +0000 (08:45 +0200)]
adwaita: Use border-spacing to style checkbuttons
Timm Bäder [Sat, 28 Sep 2019 06:38:41 +0000 (08:38 +0200)]
radiobutton: Fix a warning in a code sample
Timm Bäder [Thu, 26 Sep 2019 03:46:35 +0000 (05:46 +0200)]
label: Remove set_selectable_hint
It's just updating the cursor, so do it via update_cursor()
Timm Bäder [Thu, 26 Sep 2019 03:42:49 +0000 (05:42 +0200)]
label: Remove gtk_label_realize
We don't need this to update the cursor anymore.
Timm Bäder [Thu, 26 Sep 2019 03:36:49 +0000 (05:36 +0200)]
label: Don't update cursor after unsetting select_info
update_cursor() doesn't do anything in the priv->select_info == NULL
case.
Timm Bäder [Thu, 26 Sep 2019 03:36:19 +0000 (05:36 +0200)]
label: Change cursor even if unrealized
Cursor don't depend on that anymore.
Timm Bäder [Thu, 26 Sep 2019 03:07:17 +0000 (05:07 +0200)]
placesviewrow: popup-menu returns a boolean
Matthias Clasen [Wed, 9 Oct 2019 12:18:26 +0000 (12:18 +0000)]
Merge branch 'wip/carlosg/tablet-invalid-reads-master' into 'master'
Fix invalid reads on tablet input (master)
Closes #2157
See merge request GNOME/gtk!1122
Carlos Garnacho [Tue, 8 Oct 2019 15:56:10 +0000 (17:56 +0200)]
gdk: Avoid poking possibly freed memory
The event may end up freed after delivery, ensure to keep a ref in order
to emit the matching emulated crossed event matching a proximity event.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/2157
Matthias Clasen [Tue, 8 Oct 2019 19:43:14 +0000 (19:43 +0000)]
Merge branch 'wip/chergert/quick-fixes' into 'master'
renderer quick fixes
See merge request GNOME/gtk!1124
Benjamin Otte [Tue, 8 Oct 2019 19:21:57 +0000 (19:21 +0000)]
Merge branch 'wip/chergert/cache-text-render-node' into 'master'
textview: cache paragraph render nodes
See merge request GNOME/gtk!1125
Christian Hergert [Tue, 8 Oct 2019 18:35:49 +0000 (11:35 -0700)]
textview: cache paragraph render nodes
We can avoid recreating a number of text nodes from render_para() on
sub-sequent runs if we cache the rendernode instead of just the
PangoLayout.
When used with GtkSourceMap, this can yield a ~7 FPS improvement during
smooth scrolling at the cost of some more memory.
Christian Hergert [Tue, 8 Oct 2019 17:58:29 +0000 (10:58 -0700)]
gl: remove stray +
Christian Hergert [Tue, 8 Oct 2019 04:36:36 +0000 (21:36 -0700)]
rendernode: remove unused macros
Carlos Garnacho [Tue, 8 Oct 2019 15:46:38 +0000 (17:46 +0200)]
gdk: Fix wl_output accounting on tablet devices
The code managing this accounting mixed seat and tablet output lists,
can't bode well. Fixes invalid reads on list elements, as there are
dangling pointers.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/2157
Sam Hewitt [Mon, 7 Oct 2019 20:50:34 +0000 (16:50 -0400)]
Adwaita: circular button fix
- remove old border drawing code that was breaking coloured buttons
- fixes #2173
Sam Hewitt [Mon, 7 Oct 2019 19:27:55 +0000 (15:27 -0400)]
Adwaita: osd button fixes
- remove text/icon shadow from osd buttons
- use :only-child to get circular standalone button
- fixes #1696
Sam Hewitt [Mon, 7 Oct 2019 17:05:12 +0000 (13:05 -0400)]
Adwaita: use borders_color for separators
- fixes #2175
Benjamin Otte [Thu, 3 Oct 2019 22:42:28 +0000 (00:42 +0200)]
eventcontrollerkey: Change behavior of contains-focus
contains-focus now returns TRUE when is-focus is TRUE instead of FALSE.
Fixes #2184
Benjamin Otte [Thu, 3 Oct 2019 20:13:54 +0000 (22:13 +0200)]
eventcontrollerkey: Add getters for the properties
...and use them.
Benjamin Otte [Thu, 3 Oct 2019 04:49:32 +0000 (06:49 +0200)]
icontheme: Don't try to scale pixbufs to 0px
Always insist on at least 1px, even if the thumbnail we're turning into
an icon was 256 * 3 and should be scaled to 32 * 3/8.
Benjamin Otte [Sat, 5 Oct 2019 14:28:44 +0000 (16:28 +0200)]
selectionmodel: Remove doubled semicolon
Alan Mortensen [Sun, 6 Oct 2019 21:36:47 +0000 (23:36 +0200)]
Updated Danish translation of gtk
Daniel Boles [Sun, 6 Oct 2019 19:48:10 +0000 (20:48 +0100)]
Builder: Fix a couple of typos in documentation
Piotr Drąg [Sun, 6 Oct 2019 13:13:31 +0000 (15:13 +0200)]
Update POTFILES.in
Benjamin Otte [Sat, 5 Oct 2019 15:19:04 +0000 (15:19 +0000)]
Merge branch 'gbsneto/vulkan-fixes' into 'master'
Implement VK_KHR_incremental_present
See merge request GNOME/gtk!1116
Georges Basile Stavracas Neto [Fri, 4 Oct 2019 21:53:10 +0000 (18:53 -0300)]
vulkan/context: Implement VK_KHR_incremental_present
This is the Vulkan version of eglSwapBuffersWithDamage(), and
it's always a good idea to limit the number of pixels we're
pushing to the GPU and/or swapping into the display.
Georges Basile Stavracas Neto [Fri, 4 Oct 2019 20:55:25 +0000 (17:55 -0300)]
vulkan/renderpass: Use GENERAL for initial layout
UNDEFINED initial layouts may not preserve the contents
of the attachment after transitioning the layout. We want
them to be preserved because we do partial rendering.
Use GENERAL as the initial layout for render passes.
Georges Basile Stavracas Neto [Fri, 4 Oct 2019 14:52:43 +0000 (11:52 -0300)]
vulkan/image: Set HOST and TRANSFER bits for before barriers
Multiple images in the before barrier array are defined with
VK_ACCESS_TRANSFER_WRITE_BIT and VK_ACCESS_TRANSFER_READ_BIT,
which requires passing VK_PIPELINE_STAGE_TRANSFER_BIT and
VK_PIPELINE_STAGE_HOST_BIT to vkCmdPipelineBarrier().
Pass these flags correctly.
Georges Basile Stavracas Neto [Sat, 5 Oct 2019 14:38:29 +0000 (11:38 -0300)]
wayland: Allow binding to wl_compositor v4
This is a requirement for using VK_KHR_incremental_present.
Vulkan Wayland drivers translate the VkPresentRegionsKHR to
wl_surface.damage_buffer(), which a v4-only request.
Christian Hergert [Fri, 4 Oct 2019 23:30:04 +0000 (23:30 +0000)]
Merge branch 'wip/chergert/textview-widgets' into 'master'
textview: use GtkWidget for borders and center_child
See merge request GNOME/gtk!1099
Christian Hergert [Fri, 4 Oct 2019 02:21:45 +0000 (19:21 -0700)]
textview: use GtkTextViewChild for border and overlay children
This creates a new GtkTextViewChild that can manage overlay children at
given x,y offsets in buffer coordinates. This simplifies GtkTextView by
extracting this from GtkTextWindow as well as providing a real widget for
the borders.
With this change, we also rename gtk_text_view_add_child_in_window() to
gtk_text_view_add_overlay(). For those that were using
GTK_TEXT_WINDOW_WIDGET, they can use a GtkOverlay. It does not appear
that anyone was using GTK_TEXT_WINDOW_(LEFT|RIGHT|TOP|BOTTOM) for widgets
in this fashion, but that can be done by setting a gutter widget with
gtk_text_view_set_gutter(). We can make GtkTextViewChild public if
necessary to simplify this should it become necessary.
GtkTextViewChild will setup a CSS node of either "text" or "border"
depending on the GtkTextWindowType.
The old GtkTextViewChild has been renamed to AnchoredChild as it is only
used for widgets with anchors in the GtkTextBuffer. This also removes the
use of allocated GSList and instead embeds a GQueue and GList to save a
few extraneous allocations.
Christian Hergert [Mon, 23 Sep 2019 23:08:53 +0000 (16:08 -0700)]
textview: revert renaming of buffer_to_surface_coords()
The renaming of this function doesn't make much since because the window
is the GtkTextWindowType, not GdkWindow specifically. So we can keep the
old name which is closer to the proper meaning and less code for consumers
to change when porting to 4.x.
Matthias Clasen [Fri, 4 Oct 2019 18:27:05 +0000 (18:27 +0000)]
Merge branch 'list-box-headers' into 'master'
Fix reuse of list box header widgets
See merge request GNOME/gtk!1114
Sam Hewitt [Fri, 4 Oct 2019 18:16:11 +0000 (14:16 -0400)]
Adwaita: new levelbar style
Philip Withnall [Fri, 4 Oct 2019 17:25:34 +0000 (18:25 +0100)]
gtklistbox: Only unparent header rows if they haven’t been reused
It’s possible for code which uses a `GtkListBox` to reuse a single
header row, and move it around between rows. For example, this might
happen if the code has interactive widgets (like buttons) in the row,
and doesn’t want to continually recreate them and reattach signals to
them whenever the row headers change.
Unfortunately, this was broken, as the old header widget was
unconditionally unparented, even if it had just been set as the header
for a different row in the same `GtkListBox`. This left it assigned as
a child widget in the `GtkListBox` (so it was iterated over by
`forall`), but without its parent widget set.
Fix that by only unparenting the header if it hasn’t already been
assigned as the parent of a different row.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Philip Withnall [Fri, 4 Oct 2019 17:25:16 +0000 (18:25 +0100)]
gtklistbox: Factor the new header out into a separate variable
Makes the code a little clearer, but makes no functional changes.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Christoph Reiter [Wed, 2 Oct 2019 19:35:20 +0000 (21:35 +0200)]
Print a warning if GTK_DEBUG is set but gtk isn't built with G_ENABLE_DEBUG
G_ENABLE_DEBUG is tied to the meson builttype property, so building with "plain"
results in G_ENABLE_DEBUG not being defined and the GTK_DEBUG env var just gets ignored
for that build.
Since it can be confusing that GTK_DEBUG has no effect print a warning message instead.
See #2020. This is a port of !1109 to master
Ask Hjorth Larsen [Wed, 2 Oct 2019 03:54:14 +0000 (05:54 +0200)]
Updated Danish translation of gtk-properties
Ask Hjorth Larsen [Wed, 2 Oct 2019 03:54:12 +0000 (05:54 +0200)]
Updated Danish translation of gtk
Marek Černocký [Wed, 2 Oct 2019 00:06:13 +0000 (02:06 +0200)]
Updated Czech translation
Georges Basile Stavracas Neto [Tue, 1 Oct 2019 19:13:43 +0000 (16:13 -0300)]
wayland/surface: Fix crash when unexporting
This is the exact same problem of
655c9dd526.
Marek Černocký [Tue, 1 Oct 2019 15:32:46 +0000 (17:32 +0200)]
Updated Czech translation
Georges Basile Stavracas Neto [Tue, 1 Oct 2019 15:22:22 +0000 (15:22 +0000)]
Merge branch 'gbsneto/fix-wayland-export-handle' into 'master'
wayland/surface: Only call destroy func when available
Closes #2179
See merge request GNOME/gtk!1112
Georges Basile Stavracas Neto [Tue, 1 Oct 2019 14:54:28 +0000 (11:54 -0300)]
wayland/surface: Only call destroy func when available
When calling gdk_wayland_surface_export_handle(), if we pass
some 'user_data' but no 'destroy_func', GTK4 crashes. That's
because in xdg_exported_handle() we are unconditionally calling
destroy_func -- even when it's NULL.
Fix that by checking if there's a destroy function before calling
it.
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/2179
Matej Urbančič [Sat, 28 Sep 2019 19:14:54 +0000 (21:14 +0200)]
Updated Slovenian translation
Piotr Drąg [Sat, 28 Sep 2019 11:59:24 +0000 (13:59 +0200)]
Update Polish translation
Aurimas Černius [Sat, 28 Sep 2019 09:51:44 +0000 (12:51 +0300)]
Updated Lithuanian translation
Matthias Clasen [Fri, 27 Sep 2019 19:24:00 +0000 (19:24 +0000)]
Merge branch 'printing-get-ppd-from-original-host-if-needed' into 'master'
Printing get ppd from original host if needed
See merge request GNOME/gtk!1100
Benjamin Otte [Thu, 26 Sep 2019 10:44:30 +0000 (10:44 +0000)]
Merge branch 'wip/ricotz/mediafile' into 'master'
mediafile: Use correct return-type for factory methods
See merge request GNOME/gtk!1105
Rico Tzschichholz [Thu, 26 Sep 2019 05:34:31 +0000 (07:34 +0200)]
mediafile: Add g-i annotations for actual return-type of factory methods
Timm Bäder [Wed, 25 Sep 2019 15:10:34 +0000 (17:10 +0200)]
eventcontrollerscroll: Events are unhandled by default
While the ::scroll signal always returns whether it handled the event,
the others do not, for example ::decelerate.
Previously, this caused the event to stop at a scroll controller with
CAPTURE phase, never emitting the ::decelerate signal on later
controllers with BUBBLE phase.
Fixes #2151
Timm Bäder [Wed, 25 Sep 2019 15:07:45 +0000 (17:07 +0200)]
snapshot: Try to avoid some linear gradient nodes
Timm Bäder [Tue, 24 Sep 2019 04:18:40 +0000 (06:18 +0200)]
searchentry: Use a box layout
Timm Bäder [Tue, 24 Sep 2019 04:18:19 +0000 (06:18 +0200)]
searchentry: Use edit-clear-all-symbolic as clear icon
Fixes #2109
Timm Bäder [Tue, 24 Sep 2019 04:13:00 +0000 (06:13 +0200)]
gl renderer: Fix rounded rect intersection
Timm Bäder [Mon, 23 Sep 2019 15:02:03 +0000 (17:02 +0200)]
fontchooserwidget: Use a bin layout
Timm Bäder [Mon, 23 Sep 2019 15:00:07 +0000 (17:00 +0200)]
colorbutton: Use a bin layout
Timm Bäder [Sun, 22 Sep 2019 08:18:06 +0000 (10:18 +0200)]
dialog: Remove useless gtk_widget_show() call
Timm Bäder [Sun, 22 Sep 2019 07:20:36 +0000 (09:20 +0200)]
filechooserbutton: Add icon to default (None) combo box item
See #2118
Timm Bäder [Sun, 22 Sep 2019 07:12:38 +0000 (09:12 +0200)]
filechooserbutton: Remove priv->child
We never use it except when updating the state flags, but we can as well
do that for both children.
Timm Bäder [Sun, 22 Sep 2019 07:07:33 +0000 (09:07 +0200)]
filechooserbutton: Remove an outdated comment
The path used is wrong but the string isn't used in the testsuite
anyway.
Timm Bäder [Sun, 22 Sep 2019 06:57:43 +0000 (08:57 +0200)]
scrolledwindow: Remove set_placement_internal()
set_placement() does the exact same thing.
Timm Bäder [Sat, 21 Sep 2019 15:37:42 +0000 (17:37 +0200)]
menubar: Use a box layout
Timm Bäder [Sat, 21 Sep 2019 12:27:43 +0000 (14:27 +0200)]
video: Use a bin layout
Timm Bäder [Sat, 21 Sep 2019 10:56:09 +0000 (12:56 +0200)]
levelbar: Use a bin layout
Matthias Clasen [Tue, 24 Sep 2019 15:38:35 +0000 (11:38 -0400)]
docs: Add GtkNative to types
This is needed to make doc generation work
for GtkNative.
Danial Behzadi [Sun, 22 Sep 2019 11:36:55 +0000 (11:36 +0000)]
Update Persian translation
Timm Bäder [Sat, 21 Sep 2019 07:41:53 +0000 (09:41 +0200)]
headerbar: Fix end-packed child order
We pack from right to left there.
Marek Kasik [Thu, 19 Sep 2019 16:35:23 +0000 (18:35 +0200)]
printing: Get PPD from original host if needed
Try to get PPD from original host if there is no PPD for remote printer
on current CUPS server.
Matthias Clasen [Mon, 16 Sep 2019 22:10:02 +0000 (22:10 +0000)]
Merge branch 'wip/kill-menu' into 'master'
Use menus less
See merge request GNOME/gtk!1098
Matthias Clasen [Sat, 14 Sep 2019 20:55:06 +0000 (16:55 -0400)]
toolbar: Use a popover for overflow
We are phasing out menus.
This is not quite complete, toolitems still
create menuitems, which we translate on the fly.
Matthias Clasen [Sat, 14 Sep 2019 19:03:22 +0000 (15:03 -0400)]
notebook: Use a popover for the tab menu
We are phasing out menus.
Matthias Clasen [Sat, 14 Sep 2019 21:14:55 +0000 (17:14 -0400)]
menutoolbutton: Add support for popovers
Just like the underlying menu button, support
popovers too.
Matthias Clasen [Fri, 13 Sep 2019 23:06:26 +0000 (19:06 -0400)]
window: Make fallback menu a popover
We want to phase out menus.
Matthias Clasen [Fri, 13 Sep 2019 21:24:37 +0000 (17:24 -0400)]
Remove unused includes
Don't include gtkmenu.h in places where
it isn't used anymore.
Matthias Clasen [Fri, 13 Sep 2019 21:25:02 +0000 (17:25 -0400)]
text util: Remove an unused function
_gtk_text_util_append_special_char_menuitems was not used.
Rico Tzschichholz [Sun, 15 Sep 2019 15:54:52 +0000 (17:54 +0200)]
gtk: Fix some g-i annotation warnings
Rico Tzschichholz [Sun, 15 Sep 2019 15:31:41 +0000 (17:31 +0200)]
gtk: Fix parameter annotations for gtk_buildable_parse_context_get_position
Rico Tzschichholz [Sun, 15 Sep 2019 15:49:34 +0000 (17:49 +0200)]
build: gtkbuilderparser.c contains g-i annotations for public API
Matthias Clasen [Sun, 15 Sep 2019 15:54:08 +0000 (15:54 +0000)]
Merge branch 'wip/rah/screensaver-active-fix' into 'master'
gtkapplication-dbus: Initialise screensaver-active property
See merge request GNOME/gtk!1091
Matthias Clasen [Sat, 14 Sep 2019 21:18:02 +0000 (21:18 +0000)]
Merge branch 'wip/chergert/fix-textview-clip' into 'master'
textview: clip to text window when drawing
See merge request GNOME/gtk!1095
Christian Hergert [Fri, 13 Sep 2019 23:26:26 +0000 (16:26 -0700)]
textview: clip to text window when drawing
When drawing the GtkTextView text, we need to clip to the visible area
so that we do not risk drawing under the border windows.
Christian Hergert [Fri, 13 Sep 2019 23:02:28 +0000 (16:02 -0700)]
textview: fix textview drawing in presence of gutters
When drawing a left or top gutter, we need to adjust the origin of the
text snapshot or we risk the gutter drawing above the text.
Timm Bäder [Fri, 13 Sep 2019 12:45:54 +0000 (14:45 +0200)]
notebook: Use a box layout
And incidentally make the CSS node docs correct again.
Timm Bäder [Fri, 13 Sep 2019 12:28:48 +0000 (14:28 +0200)]
fontbutton: Shorten clear_font_data a bit
Timm Bäder [Fri, 13 Sep 2019 09:53:24 +0000 (11:53 +0200)]
fontbutton: Use a bin layout
Timm Bäder [Fri, 13 Sep 2019 09:39:34 +0000 (11:39 +0200)]
appchooserdialog: Remove unnecessary gtk_widget_show() calls