Claudio Cambra [Mon, 19 Dec 2022 16:38:35 +0000 (17:38 +0100)]
Remove unused targetFile QString in propagateremotemove
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:37:35 +0000 (17:37 +0100)]
Remove unused supportedTransmissionChecksums from bulkpropagatorjob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:35:42 +0000 (17:35 +0100)]
Remove unused QStrings from remotewipe
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:34:48 +0000 (17:34 +0100)]
Remove HACK for Windows Vista as this OS is no longer supported
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 16:33:20 +0000 (17:33 +0100)]
Remove unused variables in folderstatusdelegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 20 Dec 2022 11:58:30 +0000 (12:58 +0100)]
Merge pull request #5287 from nextcloud/bugfix/corrext-signal-emit
Make correct use of Qt signal 'emit' keyword
Claudio Cambra [Mon, 19 Dec 2022 14:12:11 +0000 (15:12 +0100)]
Fix bad signal emissions
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 14:11:59 +0000 (15:11 +0100)]
Remove use of emit keyword where used for non signals
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 19 Dec 2022 14:11:18 +0000 (15:11 +0100)]
Add 'emit' keyword to signal emissions that were missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 20 Dec 2022 11:07:09 +0000 (12:07 +0100)]
Merge pull request #5291 from nextcloud/bugfix/qfileinfo-exists
Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists
Claudio Cambra [Mon, 19 Dec 2022 16:46:27 +0000 (17:46 +0100)]
Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists, as it is faster
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 20 Dec 2022 03:35:32 +0000 (03:35 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 19 Dec 2022 03:37:57 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 18 Dec 2022 03:30:14 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 17 Dec 2022 03:31:14 +0000 (03:31 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 16:40:30 +0000 (17:40 +0100)]
Merge pull request #5141 from nextcloud/bugfix/upgradeFromOldClients
fix migration from old settings configuration files
Claudio Cambra [Thu, 15 Dec 2022 15:09:39 +0000 (16:09 +0100)]
Fix conflicting definitions in anonymous namespace in Unity build
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 13:32:48 +0000 (14:32 +0100)]
Constify groups variable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 12:29:51 +0000 (13:29 +0100)]
Use std::make_unique rather than manually build unique_ptr for oCSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 12:27:12 +0000 (13:27 +0100)]
Make checks for config file more concise, warn when file not readable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 15 Dec 2022 12:24:34 +0000 (13:24 +0100)]
Constify config file QFileInfo, create directly in if statement
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 7 Dec 2022 16:11:28 +0000 (17:11 +0100)]
Fix includes in accountmanager.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 6 Dec 2022 13:07:28 +0000 (14:07 +0100)]
Replace QDesktopServices datalocation with emulated version of it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 1 Dec 2022 13:04:02 +0000 (14:04 +0100)]
Add full list of possible legacy config locations
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Mon, 7 Nov 2022 17:33:39 +0000 (18:33 +0100)]
fix migration from old settings configuration files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Thu, 15 Dec 2022 14:44:29 +0000 (15:44 +0100)]
Merge pull request #5258 from nextcloud/feature/do-not-sync-enc-folders-if-e2ee-is-not-setup
Feature/do not sync enc folders if e2ee is not setup
alex-z [Wed, 7 Dec 2022 18:43:27 +0000 (19:43 +0100)]
Do not sync encrypted folders if the E2EE mnemonic is not entered. Automatically blacklist them. Remove from blacklist once the E2EE mnemonic is provided.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Claudio Cambra [Thu, 15 Dec 2022 12:12:10 +0000 (13:12 +0100)]
Merge pull request #5245 from nextcloud/bugfix/remove-unused-headerbanner
Remove unused HeaderBanner component
Claudio Cambra [Wed, 7 Dec 2022 12:38:39 +0000 (13:38 +0100)]
Remove unused headerbanner component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 15 Dec 2022 11:02:00 +0000 (12:02 +0100)]
Merge pull request #5271 from nextcloud/feature/removeObsoleteNames
Feature/remove obsolete names
Matthieu Gallien [Tue, 13 Dec 2022 10:13:55 +0000 (11:13 +0100)]
use nextcloud.log suffix for log files of desktop client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 13 Dec 2022 10:06:53 +0000 (11:06 +0100)]
use .nextcloudsync.log to perform file monitoring test at start
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 15 Dec 2022 10:10:58 +0000 (11:10 +0100)]
Merge pull request #5273 from nextcloud/bugfix/testsyncengine-fix-localstate-destroyed-failure
Fix SyncEngineTest failure when localstate is destroyed.
alex-z [Tue, 13 Dec 2022 13:41:07 +0000 (14:41 +0100)]
Fix SyncEngineTest failure when localstate is destroyed.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Matthieu Gallien [Thu, 15 Dec 2022 08:41:24 +0000 (09:41 +0100)]
Merge pull request #5269 from nextcloud/ci/forceCraftPixmanVersion
sets a fixed version for pixman when buildign desktop client via Craft
Matthieu Gallien [Tue, 13 Dec 2022 10:43:27 +0000 (11:43 +0100)]
tell OpenCppCoverage that we run an optimized build
should fix the crash accordign to the doc linked there
https://github.com/OpenCppCoverage/OpenCppCoverage/wiki/FAQ#your-application-has-thrown-an-unhandled-exception-code-
3221225477-exception_access_violation
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 13 Dec 2022 09:56:36 +0000 (10:56 +0100)]
sets a fixed version for pixman when buildign desktop client via Craft
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Thu, 15 Dec 2022 03:30:27 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 14 Dec 2022 03:33:33 +0000 (03:33 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 20:32:11 +0000 (21:32 +0100)]
Merge pull request #5274 from nextcloud/bugfix/remove-get-task-allow-entitlement
Avoid the Get-Task-Allow Entitlement (macOS Notarization)
Claudio Cambra [Tue, 13 Dec 2022 18:53:53 +0000 (19:53 +0100)]
Avoid the Get-Task-Allow Entitlement (macOS Notarization)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 18:33:31 +0000 (19:33 +0100)]
Merge pull request #5131 from nextcloud/feature/implement-internal-link-share
Add an internal link share to the share dialog
Claudio Cambra [Tue, 13 Dec 2022 16:35:40 +0000 (17:35 +0100)]
Clean up data section for internal link in model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 16:34:41 +0000 (17:34 +0100)]
Fix copy link button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 16:34:23 +0000 (17:34 +0100)]
Remove unneeded property from ShareDetailsPage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 5 Nov 2022 12:20:13 +0000 (13:20 +0100)]
Fix bad remote path in sharetestutils fakefolder, which led to failed FakePropfindReply being provided in tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 5 Nov 2022 12:19:37 +0000 (13:19 +0100)]
Incorporate internal link share into tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 4 Nov 2022 18:30:22 +0000 (19:30 +0100)]
Add an internal link share to the share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 13 Dec 2022 15:45:04 +0000 (16:45 +0100)]
Merge pull request #5007 from nextcloud/feature/nix
Add a nix flake for easy building and dev environments
Claudio Cambra [Thu, 29 Sep 2022 11:23:50 +0000 (13:23 +0200)]
Add support for macOS to flake
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Wed, 28 Sep 2022 15:54:54 +0000 (17:54 +0200)]
Add nix flake for desktop client
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Tue, 13 Dec 2022 13:31:00 +0000 (14:31 +0100)]
Merge pull request #5263 from nextcloud/feature/encrypt-folder-context-menu
Add an "Encrypt" menu entry in file browser context menu for folders
Claudio Cambra [Mon, 12 Dec 2022 22:25:54 +0000 (23:25 +0100)]
Check socketlistener is valid before trying to send encryption menu item message
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 12 Dec 2022 11:12:46 +0000 (12:12 +0100)]
Don't show Encrypt menu entry if server does not support E2EE
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 22:22:30 +0000 (23:22 +0100)]
Improve folder encryption dialog info boxes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 18:05:27 +0000 (19:05 +0100)]
Make encryption job errors provide descriptive error messages
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 17:46:59 +0000 (18:46 +0100)]
Add encryption success message box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 17:31:06 +0000 (18:31 +0100)]
Move encrypt menu entry declaration to own method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 17:19:21 +0000 (18:19 +0100)]
Don't allow encryption if account is not correctly configured for it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 17:15:16 +0000 (18:15 +0100)]
Add context menu entry to encrypt folders
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 13 Dec 2022 10:01:17 +0000 (11:01 +0100)]
Merge pull request #5257 from cgzones/typo
Fix typo
Christian Göttsche [Thu, 8 Dec 2022 14:45:45 +0000 (15:45 +0100)]
Fix typo
Found by Lintian.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Nextcloud bot [Tue, 13 Dec 2022 03:43:32 +0000 (03:43 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Mon, 12 Dec 2022 17:42:13 +0000 (18:42 +0100)]
Merge pull request #5261 from nextcloud/feature/do-not-show-error-status-on-editlocally-abort
Silence sync termination errors when running EditLocallyJob.
alex-z [Fri, 9 Dec 2022 15:25:29 +0000 (16:25 +0100)]
Silence sync termination errors when running EditLocallyJob.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Mon, 12 Dec 2022 03:30:01 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 11 Dec 2022 03:41:47 +0000 (03:41 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 10 Dec 2022 03:37:47 +0000 (03:37 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 16:44:00 +0000 (17:44 +0100)]
Merge pull request #5139 from nextcloud/feature/file-details-in-tray
Show file details within the tray dialog, rather than in a separate dialog
Claudio Cambra [Fri, 9 Dec 2022 12:42:29 +0000 (13:42 +0100)]
Adapt changes from share details page changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 9 Nov 2022 12:10:59 +0000 (13:10 +0100)]
Replace share button with file details button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 9 Nov 2022 11:50:33 +0000 (12:50 +0100)]
Replace drawer 'Done' button at bottom-right with close button at top-right
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 9 Nov 2022 11:21:07 +0000 (12:21 +0100)]
Make drawer modal, reduce width
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 7 Nov 2022 13:05:20 +0000 (14:05 +0100)]
Show file details within the tray dialog, rather than in a separate dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 14:03:33 +0000 (15:03 +0100)]
Merge pull request #5143 from nextcloud/feature/interactive-talk-macos-notifications
Add interactive NC Talk notifications on macOS
Claudio Cambra [Fri, 9 Dec 2022 13:36:05 +0000 (14:36 +0100)]
Remove semicolons from Q_UNUSED macros
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 18:18:41 +0000 (19:18 +0100)]
Differentiate between normal normal and Talk notifications, invoke macOS text reply notifications
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 15:16:39 +0000 (16:16 +0100)]
Add Talk message type of notifications to native macOS notifications
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 12:32:55 +0000 (13:32 +0100)]
Merge pull request #5194 from nextcloud/feature/share-details-page
Replace share settings popup with a page on a StackView
Claudio Cambra [Thu, 8 Dec 2022 11:30:42 +0000 (12:30 +0100)]
Use EnforcedPlainTextLabel in new ShareDetailsPage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 23 Nov 2022 14:25:09 +0000 (15:25 +0100)]
Add copy share link button to share details page footer, remove unneeded columnlayout in contentitem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 23 Nov 2022 13:44:10 +0000 (14:44 +0100)]
Make 'Add another link' button less prominent
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 23 Nov 2022 13:33:49 +0000 (14:33 +0100)]
Make unshare button less prominent, move out of bottom button box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Nov 2022 11:18:13 +0000 (12:18 +0100)]
Set main file details page as initial item of stack view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 18 Nov 2022 17:09:22 +0000 (18:09 +0100)]
Match design of expire date spinbox to other text fields
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 18 Nov 2022 16:42:58 +0000 (17:42 +0100)]
Improve layout of share details page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 18 Nov 2022 15:12:49 +0000 (16:12 +0100)]
Convert share details menu into a page pushed onto stackview
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 18 Nov 2022 15:12:30 +0000 (16:12 +0100)]
Add stackview to file details view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 9 Dec 2022 11:39:27 +0000 (12:39 +0100)]
Merge pull request #5181 from nextcloud/feature/dont-spam-user-with-mnemonic-request
Only show mnemonic request dialog when user explicitly wants to enable E2EE
Claudio Cambra [Tue, 29 Nov 2022 10:53:35 +0000 (11:53 +0100)]
Register askUserForMneominc in property system
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 15 Nov 2022 16:25:13 +0000 (17:25 +0100)]
Only request mnemonic when user explicitly wants to enable E2EE
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Fri, 9 Dec 2022 11:07:49 +0000 (12:07 +0100)]
Merge pull request #5256 from nextcloud/bugfix/doNotBulkUploadE2EE
do not use bulk upload for e2ee files
Matthieu Gallien [Thu, 8 Dec 2022 14:57:04 +0000 (15:57 +0100)]
do not use bulk upload for e2ee files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Fri, 9 Dec 2022 03:46:30 +0000 (03:46 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 8 Dec 2022 12:30:34 +0000 (13:30 +0100)]
Merge pull request #5214 from nextcloud/bugfix/user-status-selector-text-input-sizing
Explicitly size and align user status selector text input to avoid bugs with alternate QtQuick styles
Claudio Cambra [Fri, 25 Nov 2022 13:53:16 +0000 (14:53 +0100)]
Explicitly size and align user status selector text input to avoid bugs with alternate QtQuick styles
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 8 Dec 2022 12:04:37 +0000 (13:04 +0100)]
Merge pull request #5216 from nextcloud/bugfix/basic-combo-internal-layout
Fix BasicComboBox internal layout
Claudio Cambra [Fri, 25 Nov 2022 16:54:17 +0000 (17:54 +0100)]
Fix BasicComboBox internal layout, take proper account of insets
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 8 Dec 2022 10:00:48 +0000 (11:00 +0100)]
Merge pull request #5253 from nextcloud/bugfix/editLocallyShouldWork
do not create GUI from a random thread and show error on real error
Matthieu Gallien [Thu, 8 Dec 2022 09:58:58 +0000 (10:58 +0100)]
do not create GUI from a random thread and show error on real error
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>