docs: conf file option moveToTrash is no longer Linux specific

Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <josh.t.richards@gmail.com>

Merge pull request #7046 from nextcloud/backport/7029/stable-3.14

[stable-3.14] Bugfix/log database errors

also include temporary files from WAL SQLite mode into debug archive

should make sure that the debug archive has a correct up to date view of
the sync client database

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

add missing logs and checks for database errors

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7045 from nextcloud/backport/7030/stable-3.14

[stable-3.14] properly detect and enable Qt6 WebEngine integration

properly detect and enable Qt6 WebEngine integration

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7043 from nextcloud/backport/7042/stable-3.14

[stable-3.14] on windows use QWidget native platform style

on windows use QWidget native platform style

will make all QWidget based user interface look more native

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix release kind detection

Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>

prepare 3.14.0 RC1 release (i.e. v3.14.0-rc1)

version number is 3.13.81

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7020 from nextcloud/bugfix/removeReadOnlyFoldersInReadOnlyFolders

Bugfix/remove read only folders in read only folders

enable users to delete unexpected new folders inside a read-only folder

let unexpected new folders in read-only folders be read-write

would be done for folders that are inside a read-only folder and cannot
be uploaded because the parent folder is realy read-only

most probably those folders should never have been there

in case they would be read-only, users cannot delete them, in such
situation, letting them be read-write again should really help

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

when deciding to create a new folder on server: check permissions

sometime we need to create a folder on server because some local files
or folders modifications would be lost without that

in that case instead of locally deleting teh folder, we create it back
on server

when doing that, it is important to check the remote permissions such
that we do not try to create a folder in a read-only folder on server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7017 from nextcloud/bugfix/fixIncorrectQStringBuilderUsage

avoid wrong usage of QStringBuilder via auto type deduction

avoid wrong usage of QStringBuilder via auto type deduction

detected via https://github.com/KDE/clazy/blob/master/docs/checks/README-auto-unexpected-qstringbuilder.md#auto-unexpected-qstringbuilder

also reported by g++ via compile time warnings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6952 from nextcloud/bugfix/doc-building-warnings

Fix doc building warnings

Fix string warning in account setup commandline doc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix table warning in troubleshooting doc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix header underline warnings in docs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7016 from nextcloud/bugfix/hideEncryptFromContextMenu

Bugfix/hide encrypt from context menu

only empty top folders offer the menu entry to encrypt

in the contextual menu shown in files explorer will show encrypt menu
entry only for top folders that are non-encrypted and empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

only add encrypt menu entry for top folders

with current end-to-end encryption only top folders can be encrypted

limit the availability of the menu entry to top folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

ensure the arguments of socket API commands are valid

fix string data being invalid when using QStringView

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7015 from nextcloud/fix-bug-report-typo

fix bug report breakage

fix bug report breakage

Signed-off-by: Josh <josh.t.richards@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7010 from nextcloud/bugfix/deleteReadonlyFolders

Bugfix/delete readonly folders

make folders read-write when needed when deleting local items

if a folder is read-only, when deleting content inside this folder, it
may be needed to make it temporary read-write

do this as required by the automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

add automated test for deletion of child items in read-only folders

should ensure we are able to get files or dolders be deleted by sync
engine within read-only folders

would happen as the result of changes on server side being propagated
locally or when using selective sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6965 from nextcloud/feature/server-forbidden-filenames

Feature/server forbidden filenames

When forbidden filename sync warning is encountered, add reason why the filename is forbidden to the item's error string

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Store forbidden filename match bools outside of if statement

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Set invalid filename dialog mode in activity list model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Provide different message and explanation strings in invalid filename dialog depending on invalid mode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add invalid mode enum to invalid filename dialog

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Handle invalid filename activities button verb in activity list model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add rename file link/button to invalid filename activities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Also provide notification for items that have file name invalid on server

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Assign invalid filename on server syncfileitem status to items with forbidden filenames

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Provide Windows-compatible forbidden filename character in forbidden filenames test

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add test for new forbidden filename capabilities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Check for new forbidden filename-related capabilities during exclusion handling in discovery

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Parse forbidden filename related capability features

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7006 from nextcloud/fix/bug-issue-template-package-list

fix: Update bug reporting package list + misc tweaks

fix: Update bug reporting package list + misc tweaks

Signed-off-by: Josh <josh.t.richards@gmail.com>

Merge pull request #7011 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.12.1

Bump cpp-linter/cpp-linter-action from 2.12.0 to 2.12.1

Bump cpp-linter/cpp-linter-action from 2.12.0 to 2.12.1

Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.12.0 to 2.12.1.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.12.0...v2.12.1)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #6855 from raldone01/fix/cropped_thumbnails

Keep aspect ratio for thumbnails

Fixes cropped thumbnails #6154

Signed-off-by: raldone01 <raldone01@gmail.com>

Merge pull request #7004 from nextcloud/fix/issue-6723-http-icon

fix(settings): Use broken lock icon when not using https

fix(settings): Use broken lock icon when not using https

Fixes #6723

Signed-off-by: Josh <josh.t.richards@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6994 from nextcloud/bugfix/remove-systray-popup

Remove systray call to display network errors.

Remove systray call to display network errors.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6993 from nextcloud/bugfix/removeTransparentBackgroundColor

remove most usages of transparent background: fix visual regressions

fix header buttons background color to match existing colors

the bckground of buttons on teh top bar of main dialog had a wrong color
not matching the top bar background color

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

change color used for background to match system window default color

avoid having many background colors being transparent when they should
never have been

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

avoid transparent background in user menu from main dialog

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

remove most usages of transparent background: fix visual regressions

with transparent backgrounds, most of teh time the result is hard to
read

that is mostly unintended and unless there is some blur added, the UI
becomes unusable

Close https://github.com/nextcloud/desktop/issues/6992

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6991 from nextcloud/bugfix/notif-tr

Make multiple notifications text translatable

Make multiple notifications text translatable

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6986 from nextcloud/feature/alwaysEnableHttp2

always enable http2

always enable http2

Nextcloud server documentation is recommending enabling http2 for
performance resons
https://docs.nextcloud.com/server/latest/admin_manual/installation/server_tuning.html#enable-http-2-for-faster-loading

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6985 from nextcloud/ci/removeDeprecatedQtCompatibilityCode

remove deprecated code only usefull for very old Qt releases

remove deprecated code only usefull for very old Qt releases

we require Qt > 6.0 so any conditionnal code for older releases can be
deleted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6987 from nextcloud/bugfix/fixCrazyNetworkTimeout

use very coarse timers for network timeout

use very coarse timers for network timeout

seems to work around some timers expiring too early

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6937 from nextcloud/dependabot/github_actions/platisd/clang-tidy-pr-comments-1.5.0

Bump platisd/clang-tidy-pr-comments from 1.4.3 to 1.5.0

Bump platisd/clang-tidy-pr-comments from 1.4.3 to 1.5.0

Bumps [platisd/clang-tidy-pr-comments](https://github.com/platisd/clang-tidy-pr-comments) from 1.4.3 to 1.5.0.
- [Release notes](https://github.com/platisd/clang-tidy-pr-comments/releases)
- [Commits](https://github.com/platisd/clang-tidy-pr-comments/compare/v1.4.3...v1.5.0)

---
updated-dependencies:
- dependency-name: platisd/clang-tidy-pr-comments
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #6958 from nextcloud/bugfix/preventCrashOnEncryptShellIntegrationRequests

prevent event loop reentrance when handling ENCRYPT socket requests

prevent event loop reentrance when handling ENCRYPT socket requests

when receiving a shell integration socket command for ENCRYPT, a generic
interface and generic code paths was used

the assumption was that the listener socket would need (and remain)
valid while hanlding teh request

some code paths need to display error messages to the user via a
QMessageBox

the issue is that this will execute a Qt event loop that will handle the
socket disconnection while the socket variable from the caller seems it
will stay valid and alive

prevent that by not using a blocking method invocation such that life
time mishandling about the socket listener is not possible

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6954 from nextcloud/enh/account-folder-list

List sync folders in the file explorer with user's username.

List sync folders in the file explorer with user's username.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6974 from nextcloud/bugfix/update-channels

Make sure to not repeat the update channels list when loading the settings for a second account.

Make sure to not repeat the update channels list when loading the settings for a second account.

When adding a new account, the combo box would list each update channels twice.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6939 from nextcloud/rakekniven-patch-1

chore(i18n): Changed grammar

chore(i18n): Add trailing space to show them separated at Transifex.

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

chore(i18n): Changed grammar

Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Merge pull request #6888 from nextcloud/bugfix/signupWithProviderPage

Bugfix/signup with provider page

fix authentication using provider page and web page login flow

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6975 from nextcloud/bugfix/fixImplicitHydrationCorruptedData

use QByteArray::left to send the newly received data during hydration

use QByteArray::left to send the newly received data during hydration

we use the proper method from QByteArray to forward the data received by
GETFileJob to the socket connected to teh fetch data CfApi callback

Close https://github.com/nextcloud/desktop/issues/6769

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6973 from nextcloud/bugfix/login-dialog-crash

Fix crash: web flow credential dialog is deleted when closing it.

Fix crash: web flow credential dialog is deleted when closing it.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6966 from nextcloud/bugfix/mac-crafter-product-path

Fix product path handling in Mac Crafter

Add mac-crafter Package.resolved to gitignore

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add default product folder to gitignore

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Only create product path's directory if it doesn't exist already

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>