Claudio Cambra [Wed, 1 Mar 2023 13:31:21 +0000 (14:31 +0100)]
Clean up declarations in activitylistmodel header, remove unused methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 13:06:36 +0000 (14:06 +0100)]
Fix fetch handling in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 12:36:18 +0000 (13:36 +0100)]
Expose insert dummy activity method in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 12:35:36 +0000 (13:35 +0100)]
Make TestingALM a friend class of ActivityListModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 12:16:37 +0000 (13:16 +0100)]
Add test to check that the sortedactivitylistmodel correctly gets updated when the sourcemodel does
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 11:52:34 +0000 (12:52 +0100)]
Verify sorted model is showing the rows in source activity model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 11:26:29 +0000 (12:26 +0100)]
Add SortedActivityListModel test
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 01:06:24 +0000 (02:06 +0100)]
Move creation of example activities from testactivitylistmodel to activitylistmodeltestutils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 00:52:22 +0000 (01:52 +0100)]
Move activitylistmodel testing QNAM override to dedicated convenience method in ActivityTestUtils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 00:23:37 +0000 (01:23 +0100)]
Replace unnecessary folder include in ActivityData with SyncResult
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 28 Feb 2023 22:59:27 +0000 (23:59 +0100)]
Move TestingALM to activitylistmodeltestutils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 28 Feb 2023 22:50:49 +0000 (23:50 +0100)]
Move FakeRemoteActivityStorate to new activitylistmodeltestutils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 6 Feb 2023 15:45:48 +0000 (16:45 +0100)]
Place all sorts of sync file item status errors near the top
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 6 Feb 2023 15:37:02 +0000 (16:37 +0100)]
Move activity list SyncResult errors to the top of the list
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 6 Feb 2023 15:29:48 +0000 (16:29 +0100)]
Move activity list syncfileitemstatus errors to the top of the list
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 23:47:20 +0000 (01:47 +0200)]
Merge pull request #5602 from nextcloud/bugfix/clean-up-systray-mac
Clean up systray.mm (macOS)
Claudio Cambra [Mon, 24 Jul 2023 23:13:32 +0000 (07:13 +0800)]
Use QSharedPointer<T>::create for talk reply in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:26:03 +0000 (17:26 +0800)]
Fix spacing and indentation in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:14:11 +0000 (17:14 +0800)]
Modernise property accessing in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:06:51 +0000 (17:06 +0800)]
Use const auto for C++ variables in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:00:57 +0000 (17:00 +0800)]
Constify object pointers in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 10:43:27 +0000 (12:43 +0200)]
Merge pull request #5903 from nextcloud/bugfix/fix-findersyncext
Fix Finder Sync Extension
Claudio Cambra [Mon, 24 Jul 2023 10:02:15 +0000 (18:02 +0800)]
Operate directly on NSMutableData for incoming socket data, do not work with raw buffers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Jul 2023 06:02:20 +0000 (14:02 +0800)]
Use more informative NSAssert rather than assert for _registeredDirectories
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Jul 2023 06:01:57 +0000 (14:01 +0800)]
Allocate new unsigned char buffer for processed line in heap, fixing crash
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 10:18:55 +0000 (18:18 +0800)]
Fix optional compile of File Provider module
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 08:35:53 +0000 (16:35 +0800)]
Fix BUILD_FILE_PROVIDER_MODULE check in application.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 02:13:54 +0000 (10:13 +0800)]
Do not GENERATE_INFOPLIST_FILE for FinderSyncExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 23:46:45 +0000 (07:46 +0800)]
Correctly initialise internal data members for FinderSync
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 23:46:16 +0000 (07:46 +0800)]
Define FinderSync internal data members as private interface extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 15:00:29 +0000 (23:00 +0800)]
Use modern dot notation to access _inBuffer properties
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 14:51:50 +0000 (22:51 +0800)]
Add quotes to processed line in FinderSyncExt to easily demarcate received line start and end
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 14:50:36 +0000 (22:50 +0800)]
Fix parsing of in buffer lines in FinderSyncExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 14:03:16 +0000 (22:03 +0800)]
Clean up FinderSyncExt processInBuffer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Mon, 24 Jul 2023 02:32:09 +0000 (02:32 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
István Váradi [Sat, 22 Jul 2023 14:10:02 +0000 (16:10 +0200)]
Remove Ubuntu Kinetic, add Mantic
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
Nextcloud bot [Sun, 23 Jul 2023 02:33:43 +0000 (02:33 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Sat, 22 Jul 2023 10:56:52 +0000 (12:56 +0200)]
Merge pull request #5468 from nextcloud/work/sparkle-bumps
Improve macOS Sparkle updater
Claudio Cambra [Thu, 13 Jul 2023 10:13:07 +0000 (18:13 +0800)]
Convert directly from QUrl to NSURL
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 15:10:47 +0000 (16:10 +0100)]
Clean up declaration in SparkleUpdater header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 15:08:49 +0000 (16:08 +0100)]
Fix localisation of updater status strings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 14:20:47 +0000 (15:20 +0100)]
Properly handle skipping auto update checks in the sparkle updater
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 14:03:51 +0000 (15:03 +0100)]
Only instantiate sparkle updater if autoupdating is available
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 13:34:35 +0000 (14:34 +0100)]
Fix qbytearray related clazy warnings in objective-c++ sparkle updater side
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 13:25:03 +0000 (14:25 +0100)]
Only enable check for update button when the sparkle updater is not working
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 13:23:33 +0000 (14:23 +0100)]
Implement proper notifying of sparkle updater state changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 12:42:10 +0000 (13:42 +0100)]
Also record sparkle updater state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 12:05:07 +0000 (13:05 +0100)]
Properly display status string for changes in updater
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 01:18:46 +0000 (02:18 +0100)]
Add ability for sparkle updater to notify UI when state has changed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 22 Feb 2023 22:06:50 +0000 (23:06 +0100)]
Add q pointer to SparkleInterface
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 22 Feb 2023 22:00:48 +0000 (23:00 +0100)]
Replace private class with an interfacing class to bridge Obj-C delegate class and owner CPP class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 22 Feb 2023 21:45:42 +0000 (22:45 +0100)]
Name sparkle updater delegate more reasonably
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 22 Feb 2023 21:44:17 +0000 (22:44 +0100)]
Use std::unique_ptr in sparkle updater class rather than manual management
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Sat, 22 Jul 2023 02:38:37 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Fri, 21 Jul 2023 12:03:35 +0000 (14:03 +0200)]
Merge pull request #5912 from nextcloud/bugfix/fix-msvc-sharemodel-build
Fix build of sharemodel.cpp on MSVC
Claudio Cambra [Fri, 21 Jul 2023 10:40:40 +0000 (18:40 +0800)]
Fix build of sharemodel.cpp on MSVC
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 21 Jul 2023 02:31:44 +0000 (02:31 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 16:14:50 +0000 (18:14 +0200)]
Merge pull request #5698 from nextcloud/feature/trashfiles
Add option to move deleted files to trash instead of permanently deleting them
Claudio Cambra [Tue, 16 May 2023 05:50:10 +0000 (13:50 +0800)]
Add checkbox to general settings to enabling file removal meaning moving files to trash, rather than immediate deletion
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 May 2023 05:28:48 +0000 (13:28 +0800)]
Replace custom moveToTrash solution with Qt QFile::moveToTrash
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 16:02:20 +0000 (18:02 +0200)]
Merge pull request #5666 from nextcloud/bugfix/svg-provider-error-fix
Fix SVG rendering error in SvgImageProvider
Claudio Cambra [Thu, 20 Jul 2023 11:01:33 +0000 (19:01 +0800)]
Remove empty statement, standalone semicolon
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 May 2023 06:43:54 +0000 (14:43 +0800)]
Extract custom color svg image finding into separate function
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 May 2023 06:37:15 +0000 (14:37 +0800)]
Simplify findSvgFilePath, define result value on definition
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 15:51:38 +0000 (17:51 +0200)]
Merge pull request #5717 from nextcloud/bugfix/better-password-gen
Fix password generation for shares, improve generator
Claudio Cambra [Thu, 8 Jun 2023 09:16:47 +0000 (17:16 +0800)]
Simplify loop to write bytes to password
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 8 Jun 2023 09:14:28 +0000 (17:14 +0800)]
Use std::array to store hash bytes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 20 May 2023 16:34:54 +0000 (00:34 +0800)]
Replace use of std::rand with improved C++11 random
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 20 May 2023 15:30:12 +0000 (23:30 +0800)]
Guarantee that the generated password for share will have all the types of characters needed to pass server check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 20 May 2023 15:12:31 +0000 (23:12 +0800)]
Simplify password generation in sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 19 May 2023 07:52:06 +0000 (15:52 +0800)]
Generate better passwords for shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 15:21:50 +0000 (17:21 +0200)]
Merge pull request #5659 from nextcloud/bugfix/expire-date-set-share-view
Fix expire date field in Share settings
Claudio Cambra [Mon, 8 May 2023 12:03:12 +0000 (20:03 +0800)]
Track invalid input in ShareDetailsPage expireDateSpinBoxTextField
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 8 May 2023 12:02:43 +0000 (20:02 +0800)]
Add ability for NCInputTextField to display red border when invalid input provided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 8 May 2023 12:00:34 +0000 (20:00 +0800)]
Ensure the text for the expire date spin box is updated even in situations when the expire date is forced back down to the same one being currently held
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 8 May 2023 09:59:01 +0000 (17:59 +0800)]
Make sure to imperatively set text for spinbox textfield after user breaks binding by editing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 8 May 2023 09:16:50 +0000 (17:16 +0800)]
Rename "moreMenu" ColumnLayout to "scrollContentsColumn" in ShareView, stop treating like menu which it used to be
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 20 Jul 2023 14:46:22 +0000 (16:46 +0200)]
Merge pull request #5890 from m7913d/fixCantUpdateNonExistingPlaceholder
Create placeholder while dehydrating if needed
Dries Mys [Sat, 15 Jul 2023 22:05:20 +0000 (00:05 +0200)]
Create placeholder while dehydrating if needed
When replacing an OnlineOnly file by another one, the file maintains it
OnlineOnly pin state, but it is converted to a regular file. So, the
dehydration should convert the regular file to a (dehydrated)
placeholder instead of trying to update the (non-existing) placeholder.
Closes #4274
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Matthieu Gallien [Thu, 20 Jul 2023 13:01:53 +0000 (15:01 +0200)]
Merge pull request #5853 from m7913d/ignoredFilesExcludedPinState
Set VFS PinState to Excluded for ignored files.
Dries Mys [Wed, 19 Jul 2023 08:55:36 +0000 (10:55 +0200)]
Small coding improvements
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Dries Mys [Tue, 18 Jul 2023 20:49:16 +0000 (22:49 +0200)]
Remove warning when querying pin state on non-placeholder file
F.ex. Folder::slotWatchedPathChanged calls this function on non-
placeholder files to check if the ignored file is already assigned an
Excluded pin state. Note that it is allowed to set the pin state to
Excluded on non-placeholder files.
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Dries Mys [Sun, 2 Jul 2023 17:05:37 +0000 (19:05 +0200)]
Set VFS PinState to Excluded for ignored files.
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.
Closes #5524
Closes #5594
Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Nextcloud bot [Thu, 20 Jul 2023 02:35:26 +0000 (02:35 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 19 Jul 2023 02:35:31 +0000 (02:35 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 18 Jul 2023 13:58:13 +0000 (15:58 +0200)]
Merge pull request #5885 from nextcloud/bugfix/sharing-api-disabled-share-view
Disable share view completely when server does not support/has disabled file sharing
Claudio Cambra [Tue, 18 Jul 2023 08:40:33 +0000 (16:40 +0800)]
Swap folder nullness assert for return
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 04:42:06 +0000 (12:42 +0800)]
Compress share page tab button width and height when sharing API is disabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 04:41:51 +0000 (12:41 +0800)]
Make swipeIndex properties readonly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 02:36:27 +0000 (10:36 +0800)]
Fix background of tabbar in file details page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 02:28:31 +0000 (10:28 +0800)]
Do not handle setting page to sharing page if sharing not available
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 02:28:10 +0000 (10:28 +0800)]
Do not display sharing entry if sharing is not available on server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 01:28:54 +0000 (09:28 +0800)]
Set sharingAvailable property in FileDetails from Folder account capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 01:27:07 +0000 (09:27 +0800)]
Add sharingAvailable property to FileDetails class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 18 Jul 2023 12:32:23 +0000 (14:32 +0200)]
Merge pull request #4977 from tomdereub/patch-1
windows reserved word silently excluded - csync exclude.cpp
tomdereub [Sat, 8 Oct 2022 21:42:48 +0000 (23:42 +0200)]
Adapt test 2
Signed-off-by: tomdereub <pbtom@lamonerie.net>
tomdereub [Sat, 8 Oct 2022 19:49:09 +0000 (21:49 +0200)]
Adapt test to silent exclusion
Signed-off-by: tomdereub <pbtom@lamonerie.net>
tomdereub [Tue, 27 Sep 2022 11:22:34 +0000 (13:22 +0200)]
windows reserved word silently excluded - csync exclude.cpp
Proposal to solve https://github.com/nextcloud/desktop/issues/3826, by excluding silently windows reserved word like $RECYCLE.BIN.
Signed-off-by: tomdereub <pbtom@lamonerie.net>
Matthieu Gallien [Tue, 18 Jul 2023 08:56:31 +0000 (10:56 +0200)]
Merge pull request #5879 from nextcloud/bugfix/fix-incorrect-seen-chat-notifications-removal
Fix crash and incorrect implementation of seen chat notofications removal
Matthieu Gallien [Tue, 18 Jul 2023 07:53:12 +0000 (09:53 +0200)]
try to force use of python 3.8 for windows as required by craft
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
projects / nextcloud-desktop.git / log