Daniel Molkentin [Mon, 23 Mar 2015 21:22:54 +0000 (22:22 +0100)]
Add docker buildscript for win32
Carla Schroder [Mon, 23 Mar 2015 17:55:24 +0000 (10:55 -0700)]
Merge pull request #3008 from owncloud/passman
add note re password managers
Carla Schroder [Mon, 23 Mar 2015 17:52:57 +0000 (10:52 -0700)]
add note re password managers
Olivier Goffart [Mon, 23 Mar 2015 17:28:51 +0000 (18:28 +0100)]
SSLButton: Fix a crash
Made with danimo.
Attempt to fix a crash seen on breakpad reports.
(
cc06b990-0c10-40eb-bcec-
4d3902150320)
Daniel Molkentin [Mon, 23 Mar 2015 17:22:12 +0000 (18:22 +0100)]
Activity: Correctly restore column sizes
Fixes: #3005
Olivier Goffart [Mon, 23 Mar 2015 15:50:37 +0000 (16:50 +0100)]
Add-folder Wizard: Select the newly created folder
Olivier Goffart [Mon, 23 Mar 2015 15:28:42 +0000 (16:28 +0100)]
Add-folder wizard: Make sure there is a scrollbar if folder names are too long
Fixes #2962
Jocelyn Turcotte [Mon, 23 Mar 2015 15:13:52 +0000 (16:13 +0100)]
Fix a crash when accessing a dangling UploadDevice pointer #2984
This is largely a guess, but this is the only place where we use
a QIODevice to push data through QNAM and that the QIODevice isn't
a direct child of the QNetworkReply.
Fix the issue by making sure that we don't go back to the event loop
and possibly handle network events between the destruction of the
upload QIODevice and the QNetworkReply, which might lead to QNAM
dereferencing a dangling QIODevice pointer.
Olivier Goffart [Mon, 23 Mar 2015 13:59:29 +0000 (14:59 +0100)]
application: --confdir option with invalid direcotry now exit
Show an error and exit if an invalid directory (eg, a file) is passed to --confdir
Fixes: #2453
Jocelyn Turcotte [Mon, 23 Mar 2015 12:43:59 +0000 (13:43 +0100)]
Disable asserts in official builds
Make sure that we define NDEBUG in all configurations.
Also remove inconsistent defines:
WIN32: We don't use
_DEBUG;_WINDOWS;_USRDLL: Should be defined by the compiler if necessary
OCCONTEXTMENU_EXPORTS: We currently don't use dllimport anyway
This also update the binary submodule with an updated build.
Daniel Molkentin [Mon, 23 Mar 2015 10:28:28 +0000 (11:28 +0100)]
Merge pull request #2997 from owncloud/fix_shell-integration-python3
fix python3 syntax errors
Olivier Goffart [Mon, 23 Mar 2015 10:06:14 +0000 (11:06 +0100)]
Merge pull request #2998 from owncloud/remove-old-mirall-translation
Remove forgotten file.
Hefee [Sun, 22 Mar 2015 17:01:25 +0000 (18:01 +0100)]
Remove forgotten file.
Hefee [Sun, 22 Mar 2015 16:49:09 +0000 (17:49 +0100)]
fix python3 syntax errors
Jenkins for ownCloud [Fri, 20 Mar 2015 06:18:41 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Christian Kamm [Thu, 19 Mar 2015 10:57:25 +0000 (11:57 +0100)]
CookieJar: Session cookies should *not* be stored in cookies.db.
Christian Kamm [Thu, 19 Mar 2015 10:40:47 +0000 (11:40 +0100)]
Windows: Reset QNAM as a workaround. #2899 #2895 #2973
The QNetworkAccessManager is reset when we are disconnected, just
before attempting to fetch the server's status.php.
This may help fix the problem described in various issues where we
get 'Connection closed' or timeout errors after the OS has woken
from sleep.
Christian Kamm [Fri, 13 Mar 2015 09:55:53 +0000 (10:55 +0100)]
Remote delete: Consider 404 a success. #2919
Jenkins for ownCloud [Thu, 19 Mar 2015 06:18:50 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 18 Mar 2015 06:18:42 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 18 Mar 2015 05:15:17 +0000 (01:15 -0400)]
[tx-robot] updated from transifex
Markus Goetz [Tue, 17 Mar 2015 22:31:30 +0000 (23:31 +0100)]
Propagator: Introduce custom property to make error soft
This can be set by a custom credential QNAM.
Jenkins for ownCloud [Tue, 17 Mar 2015 06:18:44 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Klaas Freitag [Mon, 16 Mar 2015 14:28:58 +0000 (15:28 +0100)]
Push version to final 1.8.0
Jenkins for ownCloud [Mon, 16 Mar 2015 06:18:44 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 14 Mar 2015 06:18:44 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Fri, 13 Mar 2015 17:30:45 +0000 (18:30 +0100)]
shell_integration: Fix disappearing context menus on Windows #2898
Since each new connection to the socket API would trigger a broadcast
of REGISTER_PATH to all existing connections, opening the context menu
would trigger a SHChangeNotify call of the root directory through
the overlay icon extension, which is currently also connected to the
socket API, waiting for changes.
Fix the issue by sending the initial REGISTER_PATH automatic response
only to the connecting socket.
Markus Goetz [Fri, 13 Mar 2015 15:35:44 +0000 (16:35 +0100)]
OS X: Always return 0 from pre_install.sh
Markus Goetz [Fri, 13 Mar 2015 14:48:35 +0000 (15:48 +0100)]
Propagator: Add comment
Christian Kamm [Thu, 12 Mar 2015 14:59:59 +0000 (15:59 +0100)]
Remote folder wizard: Add optional manual entry #2613
Jenkins for ownCloud [Fri, 13 Mar 2015 06:18:46 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Carla Schroder [Thu, 12 Mar 2015 16:48:00 +0000 (09:48 -0700)]
spelling corrections
Carla Schroder [Thu, 12 Mar 2015 16:46:27 +0000 (09:46 -0700)]
fix server side permissions table
Jocelyn Turcotte [Thu, 12 Mar 2015 15:49:47 +0000 (16:49 +0100)]
Install the crash handler earlier during startup
This moves the crash handler installation during the OCC::Application
contruction. This still leaves a window where crashes wouldn't be
caught, leaving the QtSingleApplication and theme initialization
code unreported, but isn't requiring any refactoring for now.
Issue #2952
Klaas Freitag [Thu, 12 Mar 2015 15:59:12 +0000 (16:59 +0100)]
Doc: Formatting fixes
Klaas Freitag [Thu, 12 Mar 2015 15:49:31 +0000 (16:49 +0100)]
Some ChangeLog corrections.
Daniel Molkentin [Thu, 12 Mar 2015 15:25:32 +0000 (16:25 +0100)]
Win32: More reserved file names to ignore, including Recycle Bin
Addresses #2955
Jocelyn Turcotte [Thu, 12 Mar 2015 13:58:54 +0000 (14:58 +0100)]
shell_integration: Remove the incorrect usage of the MIIM_BITMAP flag
This flag should only be specified if the hbmpItem member of the
MENUITEMINFO has been set.
Jocelyn Turcotte [Thu, 12 Mar 2015 11:56:43 +0000 (12:56 +0100)]
Fix the build with GCC 4.7
Disable bitfields completely in SyncFileItem with that compiler.
Christian Kamm [Thu, 12 Mar 2015 12:18:08 +0000 (13:18 +0100)]
Uploads: Fix big seeks on Windows. #2954
Klaas Freitag [Thu, 12 Mar 2015 10:21:23 +0000 (11:21 +0100)]
Set version postfix to rc1
Christian Kamm [Thu, 12 Mar 2015 09:26:44 +0000 (10:26 +0100)]
Logging: Print instruction when job completed.
Christian Kamm [Thu, 12 Mar 2015 08:58:30 +0000 (09:58 +0100)]
FolderMan: fix folderSyncStateChange emission. #2896
It was not emitted when a removed folder finished its sync,
and that left the UI in an old state sometimes.
Removing the Folder explicitly is unnecessary as a QSignalMapper
will automatically remove mappings for deleted QObjects.
Christian Kamm [Thu, 12 Mar 2015 08:32:44 +0000 (09:32 +0100)]
Activity: Set a message for conflicts. #2792
Also show size when conflicting files are downloaded.
Daniel Molkentin [Thu, 12 Mar 2015 08:26:41 +0000 (09:26 +0100)]
Remove unused (and partly binary!) NSIS artifacts
Jenkins for ownCloud [Thu, 12 Mar 2015 06:18:36 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Wed, 11 Mar 2015 16:57:07 +0000 (17:57 +0100)]
shell_integrations: Fix the precompiled headers usage in OCUtil
Enable it in all configurations and add the missing include.
Markus Goetz [Wed, 11 Mar 2015 15:41:37 +0000 (16:41 +0100)]
OS X: Fix UI glitches related to sync folder
For #2113 and #2947
Jocelyn Turcotte [Wed, 11 Mar 2015 14:34:53 +0000 (15:34 +0100)]
Completely disable the crash handler if the user disabled it
The config currently only disable the reporter, but still leaves
the crash handler installed on startup. This causes conflicts
when running those builds in lldb.
Work around the issue by requiring the crash reporter to be
disabled in the settings before owncloud can be run in lldb.
This has the negative side-effect of not covering the
initial ConfigFile loading with the crash handler.
Issue #2946
Klaas Freitag [Wed, 11 Mar 2015 14:46:05 +0000 (15:46 +0100)]
ShareDialog: Connect the proper DateEdit signal.
Klaas Freitag [Wed, 11 Mar 2015 13:57:55 +0000 (14:57 +0100)]
ShareDialog: If the password is empty, disable button
Klaas Freitag [Wed, 11 Mar 2015 13:09:31 +0000 (14:09 +0100)]
ShareDialog: Consider if resharing is not allowed on a share.
If a file or directory is shared without resharing permission, the
share dialog displays an error. This is not the optimal solution, but
best for now, as we do not have the permissions available for the file
manager plugin.
This fixes #2923
Klaas Freitag [Wed, 11 Mar 2015 13:09:06 +0000 (14:09 +0100)]
SocketAPI: If filename has a trailing slash, remove it.
The SyncJournal stores the the names of directories without trailing slash.
Klaas Freitag [Wed, 11 Mar 2015 09:29:58 +0000 (10:29 +0100)]
doc: Added snippet about custom WebDAV properties.
Christian Kamm [Wed, 11 Mar 2015 09:51:36 +0000 (10:51 +0100)]
Lnk: Work around QFile::rename() #2792
QFile::rename() fails if the source file is a shortcut to a file
or directory that does not exist.
Jocelyn Turcotte [Wed, 11 Mar 2015 10:41:42 +0000 (11:41 +0100)]
Shrink sizeof(SyncFileItem) by 20%
Move all small fields together in the struct and make them use bitfields.
Also remove the unused log::_other_remotePerm field.
Olivier Goffart [Wed, 11 Mar 2015 10:31:51 +0000 (11:31 +0100)]
Disable parallel uploads for server versions <= 8.0.2
Issue #2938
Jenkins for ownCloud [Wed, 11 Mar 2015 06:18:42 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Klaas Freitag [Tue, 10 Mar 2015 11:14:14 +0000 (12:14 +0100)]
Output a more sensible error message for auth errors
Klaas Freitag [Tue, 10 Mar 2015 10:17:35 +0000 (11:17 +0100)]
Revert "SetupW: Display proper error messages if password or user was wrong."
This reverts commit
396f38598fa7f9e04adc4bd9a963fbd8f95a5161.
This adds redundant code and potentially breaks Shibboleth
Jenkins for ownCloud [Tue, 10 Mar 2015 06:18:50 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Markus Goetz [Mon, 9 Mar 2015 15:19:16 +0000 (16:19 +0100)]
Revert "Propagator: Delete job on finish"
Needs a bit more thinking.
This reverts commit
8746914f3b5ca659b2726c609703597a81810af4.
Markus Goetz [Mon, 9 Mar 2015 14:52:52 +0000 (15:52 +0100)]
Propagator: Use QBA for responseTimestamp instead of QString
Markus Goetz [Mon, 9 Mar 2015 14:41:13 +0000 (15:41 +0100)]
Propagator: Delete job on finish
Klaas Freitag [Mon, 9 Mar 2015 14:14:55 +0000 (15:14 +0100)]
Make win32 build work again.
Klaas Freitag [Mon, 9 Mar 2015 13:33:02 +0000 (14:33 +0100)]
ShareDialog: Made it less "webbish" for better usability.
- Check the share checkbox automatically on open of the dialog
- Use the date picker with popping up calendar
- Proper initial size
- no resizing and appearing and disappearing.
Fixes probably #2917, also #2764
Jenkins for ownCloud [Mon, 9 Mar 2015 06:18:47 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 7 Mar 2015 07:18:24 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Fri, 6 Mar 2015 18:11:51 +0000 (19:11 +0100)]
Fix a crash in the crash reporter on OSX
The install_name of dependent libraries need to be updated
like we do for cmd and gui.
Jocelyn Turcotte [Fri, 6 Mar 2015 18:06:38 +0000 (19:06 +0100)]
Add a gen_sym_files script for OSX
This attempts to replicate what i686-w64-mingw32-gen_sym_files
is doing for us with MinGW by parsing the output of otool -L
to get the library name actually used by the executable.
Klaas Freitag [Fri, 6 Mar 2015 15:36:21 +0000 (16:36 +0100)]
SetupW: Display proper error messages if password or user was wrong.
If the password or user was wrong during setup, the client showed a
ConnectionClosed error instead of a proper Username or password wrong
message. This was because in HTTPCredentials::slotAuthentication, the
reply is closed, and a property is set to indicate the auth problem.
This patch now checks at all occurences of networkErrors if it might
have been an authentication problem, and displays something useful.
There is a good chance that this is a sufficient fix for
owncloud/enterprise#556
Klaas Freitag [Fri, 6 Mar 2015 15:35:20 +0000 (16:35 +0100)]
Push version to beta3
Klaas Freitag [Thu, 5 Mar 2015 16:09:54 +0000 (17:09 +0100)]
Theme: Return the correct version string from version()
Daniel Molkentin [Fri, 6 Mar 2015 14:47:12 +0000 (15:47 +0100)]
win32: libproxy is not needed
Markus Goetz [Fri, 6 Mar 2015 08:28:50 +0000 (09:28 +0100)]
SyncEngine: Show a debug msg only when relevant
Jenkins for ownCloud [Fri, 6 Mar 2015 07:18:35 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Markus Goetz [Thu, 5 Mar 2015 20:56:39 +0000 (21:56 +0100)]
Propagate: Don't retry direct download on abort
Markus Goetz [Thu, 5 Mar 2015 16:49:12 +0000 (17:49 +0100)]
ETags: For Folder and RequestEtagJob, always use Concatenation
Markus Goetz [Thu, 5 Mar 2015 15:50:33 +0000 (16:50 +0100)]
Discovery: Change abort code a bit
Now pressing pause in the UI will not show an error to the user.
Jenkins for ownCloud [Thu, 5 Mar 2015 07:18:52 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Klaas Freitag [Wed, 4 Mar 2015 12:50:55 +0000 (13:50 +0100)]
Add OWNCLOUDSYNC_EXPORT prefix to make windows build.
Klaas Freitag [Wed, 4 Mar 2015 11:29:17 +0000 (12:29 +0100)]
Bump version to 1.8.0 beta2.
Olivier Goffart [Wed, 4 Mar 2015 11:00:25 +0000 (12:00 +0100)]
PropagateUpload: also read the OC-ErrorString header from the poll job
Olivier Goffart [Wed, 4 Mar 2015 07:42:24 +0000 (08:42 +0100)]
PropagateUpload: add a few comments
Jocelyn Turcotte [Wed, 4 Mar 2015 08:50:02 +0000 (09:50 +0100)]
Fix missing symbols on XP
Import a fix from libcrashreporter-qt that should remove
usage of symbols not available in XP's msvcrt.dll
This should help solving #2907 with the crash reporter enabled.
Jenkins for ownCloud [Wed, 4 Mar 2015 07:18:30 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Markus Goetz [Tue, 3 Mar 2015 16:46:13 +0000 (17:46 +0100)]
Propagator: Don't use 0,0 progress signals.
They seemed to have messed up the calculation sometimes for
the last chunk.
Olivier Goffart [Tue, 3 Mar 2015 15:01:41 +0000 (16:01 +0100)]
setup wizard: use a PROPFIND instead of a GET on the webdav url
In order to initiate the conneciton, we should not send a GET on the
webdav URL because that is not a valid webdav command on a collection.
Issue #2911
Klaas Freitag [Tue, 3 Mar 2015 15:00:45 +0000 (16:00 +0100)]
DiscoveryJob: Fix progress display.
This fixes #2909
Olivier Goffart [Tue, 3 Mar 2015 09:05:38 +0000 (10:05 +0100)]
Fix build of the legacy propagator
Olivier Goffart [Tue, 3 Mar 2015 07:33:59 +0000 (08:33 +0100)]
Do not ask for the password when the check server job times up
QNetworkReply::OperationCanceledError may be both because of anthentication
error (because the HTTPCredentials abort the reply) or because of a timeout
(the timer abort the reply). We should only ask for the password if the
reply was canceled because the password was wrong.
Jenkins for ownCloud [Tue, 3 Mar 2015 07:18:28 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 3 Mar 2015 06:15:17 +0000 (01:15 -0500)]
[tx-robot] updated from transifex
Markus Goetz [Mon, 2 Mar 2015 14:08:21 +0000 (15:08 +0100)]
Discovery: Free some memory before propagate (#2902)
Markus Goetz [Mon, 2 Mar 2015 13:09:01 +0000 (14:09 +0100)]
Discovery: Free some memory on VIO dir close (#2902)
Olivier Goffart [Mon, 2 Mar 2015 10:00:37 +0000 (11:00 +0100)]
LsColJob: one must now specify the properties
So the discovery phase don't ask for the quota, and the selective sync
don't ask for all the other properties
Issue #2906
Jenkins for ownCloud [Sun, 1 Mar 2015 07:18:29 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 28 Feb 2015 07:18:39 +0000 (02:18 -0500)]
[tx-robot] updated from transifex
Daniel Molkentin [Fri, 27 Feb 2015 16:13:14 +0000 (17:13 +0100)]
Update Windows cross build instructions for 1.8
Markus Goetz [Fri, 27 Feb 2015 15:20:08 +0000 (16:20 +0100)]
libowncloudsync: Don't link to Qt SQL and Qt XML
For issue #2901 ..