nextcloud-desktop.git
6 years agoResized add account icon, adapted layout for new size
Dominique Fuchs [Wed, 15 Jan 2020 07:01:54 +0000 (08:01 +0100)]
Resized add account icon, adapted layout for new size

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFont and icon size improvements, svg transfer to new folder
Dominique Fuchs [Tue, 14 Jan 2020 18:48:21 +0000 (19:48 +0100)]
Font and icon size improvements, svg transfer to new folder

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix missing trayScreen init in non-OSX clause
Dominique Fuchs [Tue, 14 Jan 2020 07:55:39 +0000 (08:55 +0100)]
Fix missing trayScreen init in non-OSX clause

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMake qml UI strings translatable
Dominique Fuchs [Tue, 14 Jan 2020 06:59:28 +0000 (07:59 +0100)]
Make qml UI strings translatable

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMade tray window positioning HighDPI aware
Dominique Fuchs [Mon, 13 Jan 2020 21:11:57 +0000 (22:11 +0100)]
Made tray window positioning HighDPI aware

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoActivity refresh in background
Dominique Fuchs [Mon, 13 Jan 2020 13:35:58 +0000 (14:35 +0100)]
Activity refresh in background

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoAdded progressInfo / cleanup to acitivtymodel
Dominique Fuchs [Mon, 13 Jan 2020 12:10:32 +0000 (13:10 +0100)]
Added progressInfo / cleanup to acitivtymodel

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoIntegrated local error messages in activitymodel
Dominique Fuchs [Mon, 13 Jan 2020 11:54:38 +0000 (12:54 +0100)]
Integrated local error messages in activitymodel

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoIntegrated local sync activities in activitymodel
Dominique Fuchs [Mon, 13 Jan 2020 11:20:41 +0000 (12:20 +0100)]
Integrated local sync activities in activitymodel

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMinor improvements
Dominique Fuchs [Mon, 13 Jan 2020 10:46:49 +0000 (11:46 +0100)]
Minor improvements

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoIcon selection, svg path transfers, scrollbar
Dominique Fuchs [Mon, 13 Jan 2020 08:59:34 +0000 (09:59 +0100)]
Icon selection, svg path transfers, scrollbar

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoShow ListView delegate only when model is populated (prevent dummy delegate)
Dominique Fuchs [Mon, 13 Jan 2020 08:12:44 +0000 (09:12 +0100)]
Show ListView delegate only when model is populated (prevent dummy delegate)

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoAdd populate transition
Dominique Fuchs [Mon, 13 Jan 2020 07:43:51 +0000 (08:43 +0100)]
Add populate transition

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix local folder not opening on windows, add extra slash
Dominique Fuchs [Mon, 13 Jan 2020 07:33:10 +0000 (08:33 +0100)]
Fix local folder not opening on windows, add extra slash

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoTemperarily disabling animations due to lags - FIXME
Dominique Fuchs [Sun, 12 Jan 2020 20:37:08 +0000 (21:37 +0100)]
Temperarily disabling animations due to lags - FIXME

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoShow activitylist on initial tray opening when logged in
Dominique Fuchs [Sun, 12 Jan 2020 20:19:18 +0000 (21:19 +0100)]
Show activitylist on initial tray opening when logged in

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoRemoved old account toolbox
Dominique Fuchs [Sun, 12 Jan 2020 18:53:02 +0000 (19:53 +0100)]
Removed old account toolbox

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoBunch of fixes and optimizations for activityList
Dominique Fuchs [Sun, 12 Jan 2020 16:52:51 +0000 (17:52 +0100)]
Bunch of fixes and optimizations for activityList

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoModel/View improvements, also fixes crash on account removal
Dominique Fuchs [Sun, 12 Jan 2020 15:16:24 +0000 (16:16 +0100)]
Model/View improvements, also fixes crash on account removal

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMore fixes to login/logout logic
Dominique Fuchs [Sun, 12 Jan 2020 10:06:48 +0000 (11:06 +0100)]
More fixes to login/logout logic

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoemit signal for current user GUI refresh on login/logout
Dominique Fuchs [Sun, 12 Jan 2020 09:46:14 +0000 (10:46 +0100)]
emit signal for current user GUI refresh on login/logout

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agocall resetRejectedCertificates on fresh login
Dominique Fuchs [Sun, 12 Jan 2020 09:42:40 +0000 (10:42 +0100)]
call resetRejectedCertificates on fresh login

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMerge branch 'master' into qml-tray-menu
Dominique Fuchs [Sun, 12 Jan 2020 08:12:16 +0000 (09:12 +0100)]
Merge branch 'master' into qml-tray-menu

6 years agoConnection status indicators as avatar overlay
Dominique Fuchs [Sun, 12 Jan 2020 08:10:06 +0000 (09:10 +0100)]
Connection status indicators as avatar overlay

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoGeneralized connection check, now working for every user in account menu
Dominique Fuchs [Sun, 12 Jan 2020 07:50:13 +0000 (08:50 +0100)]
Generalized connection check, now working for every user in account menu

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 12 Jan 2020 03:25:48 +0000 (03:25 +0000)]
[tx-robot] updated from transifex

6 years agoStreamlined 'Add account' button with account entries
Dominique Fuchs [Sat, 11 Jan 2020 19:28:00 +0000 (20:28 +0100)]
Streamlined 'Add account' button with account entries

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix local folder URL
Dominique Fuchs [Sat, 11 Jan 2020 18:56:56 +0000 (19:56 +0100)]
Fix local folder URL

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoSystray now a singleton with instance(), show tray on finished wizard
Dominique Fuchs [Sat, 11 Jan 2020 16:34:56 +0000 (17:34 +0100)]
Systray now a singleton with instance(), show tray on finished wizard

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix comment
Dominique Fuchs [Sat, 11 Jan 2020 16:14:44 +0000 (17:14 +0100)]
Fix comment

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoAdded confirmation dialog for account removal
Dominique Fuchs [Sat, 11 Jan 2020 16:06:42 +0000 (17:06 +0100)]
Added confirmation dialog for account removal

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix crash on startup when no users configured
Dominique Fuchs [Sat, 11 Jan 2020 15:41:20 +0000 (16:41 +0100)]
Fix crash on startup when no users configured

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoDetect newly added user and rebuild account menu automatically
Dominique Fuchs [Sat, 11 Jan 2020 14:47:36 +0000 (15:47 +0100)]
Detect newly added user and rebuild account menu automatically

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoImplemented account removal
Dominique Fuchs [Sat, 11 Jan 2020 14:32:59 +0000 (15:32 +0100)]
Implemented account removal

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoTray creation timing, account menu reinstantiating on visible change
Dominique Fuchs [Sat, 11 Jan 2020 14:05:37 +0000 (15:05 +0100)]
Tray creation timing, account menu reinstantiating on visible change

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMore UserLine, avatar fixes
Dominique Fuchs [Sat, 11 Jan 2020 13:57:22 +0000 (14:57 +0100)]
More UserLine, avatar fixes

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 11 Jan 2020 03:25:40 +0000 (03:25 +0000)]
[tx-robot] updated from transifex

6 years agoUserLine drafting, bugfixes, restuctures
Dominique Fuchs [Fri, 10 Jan 2020 15:28:53 +0000 (16:28 +0100)]
UserLine drafting, bugfixes, restuctures

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 10 Jan 2020 03:27:02 +0000 (03:27 +0000)]
[tx-robot] updated from transifex

6 years agoAsk for password on password protected link shares
Roeland Jago Douma [Thu, 9 Jan 2020 14:10:01 +0000 (15:10 +0100)]
Ask for password on password protected link shares

Fixes #1485

This was missed when creating the new share dialog.
Now it pops up with a nice share password dialog to enter for your link
share.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 9 Jan 2020 04:16:12 +0000 (04:16 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 8 Jan 2020 04:16:49 +0000 (04:16 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 7 Jan 2020 04:17:27 +0000 (04:17 +0000)]
[tx-robot] updated from transifex

6 years agoUpdated year in legalnotice.cpp
JanDragon [Wed, 1 Jan 2020 14:26:50 +0000 (15:26 +0100)]
Updated year in legalnotice.cpp

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 6 Jan 2020 04:16:30 +0000 (04:16 +0000)]
[tx-robot] updated from transifex

6 years agoPreps for UserLine submenu
Dominique Fuchs [Sun, 5 Jan 2020 20:31:09 +0000 (21:31 +0100)]
Preps for UserLine submenu

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoCode cleanup regarding context menu. Pause/resume logic implemented. Halfway through...
Dominique Fuchs [Sun, 5 Jan 2020 20:06:42 +0000 (21:06 +0100)]
Code cleanup regarding context menu. Pause/resume logic implemented. Halfway through remodeling account menu.

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFocus and popup improvements for macOS
Dominique Fuchs [Sun, 5 Jan 2020 15:25:32 +0000 (16:25 +0100)]
Focus and popup improvements for macOS

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 5 Jan 2020 04:28:46 +0000 (04:28 +0000)]
[tx-robot] updated from transifex

6 years agoQuit/settings button in tray menu, disable context menu, font size fixes
Dominique Fuchs [Sat, 4 Jan 2020 16:22:56 +0000 (17:22 +0100)]
Quit/settings button in tray menu, disable context menu, font size fixes

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix blurry caret svg due to https://bugreports.qt.io/browse/QTBUG-44863
Dominique Fuchs [Sat, 4 Jan 2020 11:18:06 +0000 (12:18 +0100)]
Fix blurry caret svg due to https://bugreports.qt.io/browse/QTBUG-44863

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix wrong macro clause
Dominique Fuchs [Sat, 4 Jan 2020 11:15:01 +0000 (12:15 +0100)]
Fix wrong macro clause

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix macOS popup y position, neglecting unneccesary calculations
Dominique Fuchs [Sat, 4 Jan 2020 11:08:30 +0000 (12:08 +0100)]
Fix macOS popup y position, neglecting unneccesary calculations

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoTray account menu wording/positioning
Dominique Fuchs [Sat, 4 Jan 2020 09:09:01 +0000 (10:09 +0100)]
Tray account menu wording/positioning

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 4 Jan 2020 04:17:33 +0000 (04:17 +0000)]
[tx-robot] updated from transifex

6 years agoFirst real activity connection
Dominique Fuchs [Fri, 3 Jan 2020 15:15:15 +0000 (16:15 +0100)]
First real activity connection

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix server adress retreival in tray window buttons
Dominique Fuchs [Fri, 3 Jan 2020 13:00:07 +0000 (14:00 +0100)]
Fix server adress retreival in tray window buttons

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoMore typo fix
Dominique Fuchs [Fri, 3 Jan 2020 12:42:07 +0000 (13:42 +0100)]
More typo fix

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoHas function for ActivityModel, typos
Dominique Fuchs [Fri, 3 Jan 2020 12:39:10 +0000 (13:39 +0100)]
Has function for ActivityModel, typos

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFixed client.qrc
Dominique Fuchs [Fri, 3 Jan 2020 12:17:01 +0000 (13:17 +0100)]
Fixed client.qrc

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix git not recognizing case sensitive changes
Dominique Fuchs [Fri, 3 Jan 2020 12:12:04 +0000 (13:12 +0100)]
Fix git not recognizing case sensitive changes

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoGigantic ton of changes and deletions: ActivityListModel, tray GUI, Account logic.
Dominique Fuchs [Fri, 3 Jan 2020 12:09:29 +0000 (13:09 +0100)]
Gigantic ton of changes and deletions: ActivityListModel, tray GUI, Account logic.

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoAdded ActivityModel in new tray backend, implemented as delegate in UI
Dominique Fuchs [Thu, 2 Jan 2020 09:39:53 +0000 (10:39 +0100)]
Added ActivityModel in new tray backend, implemented as delegate in UI

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoAdded folder search for User instance, added open folder button connection
Dominique Fuchs [Thu, 2 Jan 2020 08:55:37 +0000 (09:55 +0100)]
Added folder search for User instance, added open folder button connection

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFall back to primary screen on QT version < 5.10 instead of icon position detection
Dominique Fuchs [Thu, 2 Jan 2020 07:56:07 +0000 (08:56 +0100)]
Fall back to primary screen on QT version < 5.10 instead of icon position detection

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoFix merge conflict
Dominique Fuchs [Thu, 2 Jan 2020 07:43:34 +0000 (08:43 +0100)]
Fix merge conflict

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 2 Jan 2020 04:14:47 +0000 (04:14 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 1 Jan 2020 04:14:20 +0000 (04:14 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 31 Dec 2019 04:15:07 +0000 (04:15 +0000)]
[tx-robot] updated from transifex

6 years agoImplemented platform agnostic tray window positioning logic
Dominique Fuchs [Mon, 30 Dec 2019 13:14:28 +0000 (14:14 +0100)]
Implemented platform agnostic tray window positioning logic

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoBackend code separation & structure cleanup
Dominique Fuchs [Mon, 30 Dec 2019 10:52:07 +0000 (11:52 +0100)]
Backend code separation & structure cleanup

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years agoAdded popup show/hide logic
Dominique Fuchs [Mon, 30 Dec 2019 10:39:21 +0000 (11:39 +0100)]
Added popup show/hide logic

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 30 Dec 2019 04:12:51 +0000 (04:12 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 29 Dec 2019 04:14:53 +0000 (04:14 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 28 Dec 2019 04:13:31 +0000 (04:13 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 27 Dec 2019 04:13:27 +0000 (04:13 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 26 Dec 2019 04:11:34 +0000 (04:11 +0000)]
[tx-robot] updated from transifex

6 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 25 Dec 2019 04:13:59 +0000 (04:13 +0000)]
[tx-robot] updated from transifex

6 years agoKeychainChunk: Fix error handling in ReadJob::slotReadJobDone
Michael Schuster [Tue, 24 Dec 2019 11:17:43 +0000 (12:17 +0100)]
KeychainChunk: Fix error handling in ReadJob::slotReadJobDone

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFix date in ActivityWidget and remove unnecessary string conversion
Michael Schuster [Tue, 24 Dec 2019 07:26:16 +0000 (08:26 +0100)]
Fix date in ActivityWidget and remove unnecessary string conversion

The local date and time value was converted into a string, just to be converted
into another string, to be converted to a value once again, returning zero as
the result. This caused the widget to always display "now".

Looks like this was a simply copy and paste mistake from this line in
ActivityListModel::slotActivitiesReceived:

a._dateTime = QDateTime::fromString(json.value("date").toString(), Qt::ISODate);

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoHeavy refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys and...
Michael Schuster [Tue, 24 Dec 2019 06:12:54 +0000 (07:12 +0100)]
Heavy refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys and large certs

With QtKeychain on Windows, storing larger keys or certs in one keychain entry causes the
following error due to limits in the Windows APIs:
    Error: "Credential size exceeds maximum size of 2560"

This fix implements the new wrapper class KeychainChunk with wrapper jobs ReadJob and WriteJob
to encapsulate the QKeychain handling of ReadPasswordJob and WritePasswordJob with binaryData
but split every supplied keychain entry's data into 2048 byte chunks, on Windows only.

The wrapper is used for all keychain operations in WebFlowCredentials, except for the server password.

All finished keychain jobs now get deleted properly, to avoid memory leaks.

For reference also see previous fixes:
- https://github.com/nextcloud/desktop/pull/1389
- https://github.com/nextcloud/desktop/pull/1394

This should finally fix the re-opened issue:
- https://github.com/nextcloud/desktop/issues/863

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2AuthWidget: Minor fixes and improvements
Michael Schuster [Mon, 23 Dec 2019 14:45:05 +0000 (15:45 +0100)]
Flow2AuthWidget: Minor fixes and improvements

- Improve status messages

- Add a counter to make sure that "Link copied to clipboard." is visible for
  three seconds and to not enable the buttons too early

- Add more space between buttons and status

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Refactor UI into Flow2AuthWidget only and improve Flow2Auth
Michael Schuster [Mon, 23 Dec 2019 05:51:46 +0000 (06:51 +0100)]
Flow2: Refactor UI into Flow2AuthWidget only and improve Flow2Auth

- Flow2AuthCredsPage:
  - Remove .ui file and embed Flow2AuthWidget into layout

- Flow2AuthWidget:
  - Make use generic for Flow2AuthCredsPage and WebFlowCredentialsDialog
  - Fix _errorLabel to render HTML tags instead of dumping them as plain text

- Flow2Auth:
  - Explicitly start auth with startAuth(account) instead of using constructor
  - Take control of copying the auth link to clipboard
  - Request a new auth link on copying, to avoid expiry invalidation
  - Use signals statusChanged() and result() to be more verbose (status, errors)
  - Change timer invocation and add safety bool's to avoid weird behaviour when
    the user triggers multiple link-copy calls (fetchNewToken)

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoAdd new HeaderBanner class for WebFlowCredentialsDialog
Michael Schuster [Mon, 23 Dec 2019 05:01:00 +0000 (06:01 +0100)]
Add new HeaderBanner class for WebFlowCredentialsDialog

New widget on top of the layout, based on Qt's own modern wizard header banner.

This should improve the user's perception of the dialog.

Encapsulate the existing layout into a container layout to allow the banner taking
the full width of the dialog.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoMake WebFlowCredentialsDialog cancellation- and deletion-safe
Michael Schuster [Mon, 23 Dec 2019 04:14:21 +0000 (05:14 +0100)]
Make WebFlowCredentialsDialog cancellation- and deletion-safe

- Add new signal to let WebFlowCredentials know and emit asked() to also
  tell AccountState that the user won't authenticate, and triggering
  log-out state in the settings window.

- Use deleteLater() to safely delete WebFlowCredentialsDialog, so
  that Qt can free it at the right time and without crashes.
  Do the same with it's _webView and _flow2AuthWidget on closeEvent().

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoWebFlowCredentialsDialog: Bring re-auth dialog to top (raise) on error
Michael Schuster [Sat, 21 Dec 2019 18:44:37 +0000 (19:44 +0100)]
WebFlowCredentialsDialog: Bring re-auth dialog to top (raise) on error

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Make ProgressIndicator's background-aware (Dark-/Light-Mode switching)
Michael Schuster [Sat, 21 Dec 2019 03:31:45 +0000 (04:31 +0100)]
Flow2: Make ProgressIndicator's background-aware (Dark-/Light-Mode switching)

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Add poll status text, ProgressIndicator and countdown timer
Michael Schuster [Sat, 21 Dec 2019 03:21:41 +0000 (04:21 +0100)]
Flow2: Add poll status text, ProgressIndicator and countdown timer

Also enable / disable buttons during polling.

This aims to make the authentication status more transparent and should avoid the
impression that the client is perhaps doing nothing.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoSmall fixes and code cleanup
Michael Schuster [Sat, 21 Dec 2019 03:06:37 +0000 (04:06 +0100)]
Small fixes and code cleanup

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Poll for re-auth result upon WebFlowCredentialsDialog window activation
Michael Schuster [Sat, 21 Dec 2019 02:52:51 +0000 (03:52 +0100)]
Flow2: Poll for re-auth result upon WebFlowCredentialsDialog window activation

Since the default remote poll interval has been re-raised recently to 30 seconds,
the delay between clicking "Grant access" in the browser and fetch and showing success
in the dialog may seem erroneous to the users and tempt them to click "Re-open browser"
again, causing the whole login process to restart.

This commit implements an event handler to pass the dialog's window activation
event down to the Login Flow v2 widget, in order to allow it to poll earlier.

See previous commits for dependent implementation details.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoWebFlowCredentialsDialog: Bring re-auth dialog to top (raise) upon showing SettingsDialog
Michael Schuster [Sat, 21 Dec 2019 02:16:22 +0000 (03:16 +0100)]
WebFlowCredentialsDialog: Bring re-auth dialog to top (raise) upon showing SettingsDialog

Purpose: The floating re-auth windows of the WebFlowCredentialsDialog often get hidden behind
the SettingsDialog, and the users have to minimize a lot of other windows to find them again.

See previous commit for dependent implementation details.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoAdd helper slots and signals to catch SettingsDialog's window activation events
Michael Schuster [Sat, 21 Dec 2019 02:04:31 +0000 (03:04 +0100)]
Add helper slots and signals to catch SettingsDialog's window activation events

Signal the SettingsDialog's window activation event down to ownCloudGui and Application,
so that other classes can hook in to get notified when the SettingsDialog is being shown
again.

This approach has been chosen because we otherwise would have to deal with new instance
pointers of the current SettingsWindow - but Application is already there ;-)

Purpose: The floating re-auth windows of the WebFlowCredentialsDialog often get hidden
behind the SettingsDialog, and the users have to minimize a lot of other windows to find
them again. This commit implements the preparation for the upcoming fix commit.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Use ownCloudGui::raiseDialog to bring account setup wizard to top (raise)...
Michael Schuster [Sat, 21 Dec 2019 01:33:53 +0000 (02:33 +0100)]
Flow2: Use ownCloudGui::raiseDialog to bring account setup wizard to top (raise) on auth result

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Poll for auth result upon account setup wizard window activation
Michael Schuster [Fri, 20 Dec 2019 03:05:39 +0000 (04:05 +0100)]
Flow2: Poll for auth result upon account setup wizard window activation

Since the default remote poll interval has been re-raised recently to 30 seconds,
the delay between clicking "Grant access" in the browser and fetch and showing success
in the wizard may seem erroneous to the users and tempt them to click "Re-open browser"
again, causing the whole login process to restart.

This commit implements an event handler to pass the wizard's window activation
event down to the Login Flow v2 page, in order to allow it to poll earlier.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFlow2: Bring account setup wizard to top (raise) on auth result
Michael Schuster [Fri, 20 Dec 2019 03:01:54 +0000 (04:01 +0100)]
Flow2: Bring account setup wizard to top (raise) on auth result

Show and raise the wizard on success / error in the Login Flow v2 auth.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFix issue #1237: White text on almost-white background
Michael Schuster [Mon, 23 Dec 2019 13:29:34 +0000 (14:29 +0100)]
Fix issue #1237: White text on almost-white background

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFix folder opening in ActivityListModel
Michael Schuster [Sun, 22 Dec 2019 05:16:27 +0000 (06:16 +0100)]
Fix folder opening in ActivityListModel

After fixing the crash in the previous commit, double-clicking on Activity list rows still didn't work.

This fix partly reverts commit 8546d53b05a76271e245f085d1caa5d405dadb8d in ActivityItemDelegate::PathRole
of ActivityListModel::data, but adds a new check for relPath's existence in line 74.

I'm assuming the previous change there has been done to shorten the code and avoid opening the user's home
folder upon clicking entries which file value is "App Password". The new path-check takes care of that too now.

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoFix crash in ActivityListModel (fixes #1693)
Michael Schuster [Sun, 22 Dec 2019 05:06:20 +0000 (06:06 +0100)]
Fix crash in ActivityListModel (fixes #1693)

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years agoShow date and time in activity log (fixes issue #1683)
Michael Schuster [Thu, 19 Dec 2019 21:10:37 +0000 (22:10 +0100)]
Show date and time in activity log (fixes issue #1683)

Signed-off-by: Michael Schuster <michael@schuster.ms>
6 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 24 Dec 2019 04:15:27 +0000 (04:15 +0000)]
[tx-robot] updated from transifex