Make warning text before deleting all files more clear and concise.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix #3144: check for promptDeleteAllFiles config setting before emitting signal to display warning.

The signal is not connected to any slot when running nextcloudcmd.
The callback to finish the sync was never being called because the check for the config was done in the slot,
which was never called.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6821 from nextcloud/bugfix/undeletable-vfs-suffic-files

Allow deletion of virtual suffix placeholder files

Properly reset fakefolder test state post-placeholder file delete in testsyncvirtualfiles

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ensure stripping of suffix vfs placeholder file's suffix when issuing delete command to server

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Amend behaviour of suffix virtual files test to reflect new expected behaviour

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Allow deletion of virtual suffix placeholder files

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6839 from nextcloud/bugfix/rw-folders-broken

Bugfix/rw folders broken

Do not wrap macOS ifdefs in filesystem when parent function already wrapped in ifdef

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not re-generate standard string path twice

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ensure we are re-adding same permissions as removed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6846 from nextcloud/enh/add-cfapi-debug-logs

Add cfapi debug logs

Print desktop client process id.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add new cfapi callbacks for logging.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add more logs to track file hydration.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6841 from nextcloud/bugfix/updateEncryptionStateWhenServerChange

Bugfix/update encryption state when server change

ignore encrypted items during discovery when encryption is disabled

when we know a folder should be encrypted but encryption client side app
is disabled, ignore any items in the encrypted folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

do not allow to select e2ee folders if the server support is missing

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

maintain e2ee state even if the server does not support e2ee

might be that the server previously supported e2ee and e2ee folders
exist

so we have to fetch the info to properly handle it on client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6833 from nextcloud/bugfix/fp-account-crash

Fix crash when updating enabled File Provider domains (macOS VFS)

Remove no longer existing account id from configured vfs accounts list

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Prevent crash when updating file provider domains if the account for which a file provider domain was configured no longer exists

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use accountfwd header for account forward declaration in account header itself, preventing conflicting decls

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Assert validity of accountstate and its accountptr when adding it

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove overwrought loadFromSettings method from AccountState

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Take AccountPtr by reference in accountstate constructor

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6637 from nextcloud/feature/nc-assistance

Display the NC assistant in the main Window

Move the logic for handling the featured app qml to cpp.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Display the Nextcloud assistant icon in the main window.

- If NC assistant is enabled in the server, display the icon
to open it instead of Talk. Talk is then displayed in the
list with the other apps.
- The direct link is only available in the assistant app >= 1.0.9.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6832 from nextcloud/ci/testIsMountRootProperty

Ci/test is mount root property

automated test: allow rename of the child items of a mount point

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

automated test: block rename of the top folder of a mount point

encode current behavior in a new automated test

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6811 from nextcloud/bugfix/nxtexedit-text-color

Fix text colour for NCInputTextEdit

Fix text colour for NCInputTextEdit

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6808 from Johnson-zs/master

fix build failed

fix build failed

Signed-off-by: Zhang Sheng <zhangsheng@uniontech.com>

Merge pull request #6806 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.12.0

Build(deps): Bump cpp-linter/cpp-linter-action from 2.11.0 to 2.12.0

Build(deps): Bump cpp-linter/cpp-linter-action from 2.11.0 to 2.12.0

Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.11.0 to 2.12.0.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.11.0...v2.12.0)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #6805 from tanganellilore/patch-config-file-doc

fix doc configuration file

fix doc configuration file

Signed-off-by: Lorenzo Tanganelli <lorenzo.tanganelli@hotmail.it>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6798 from nextcloud/bugfix/kde-qml

Fix broken tray GUI on Linux

Prevent crash when originalSize is null

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove broken and unneeded scroll view in tray user menu

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix displaying of more button in UserLine

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix displaying of header buttons in tray window

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ensure svg icons generated by svgimageprovider have a reasonable default size

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix use of sourceSize in TrayFoldersMenuButton

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix vertical center anchor in trayfoldersmenubutton

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove unneeded qt5compat import in headerbutton

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix breakages in autosizing menu when item does not have expected internal properties

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add non-white talk and more-apps svgs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Correctly fall back to originalSize if requestedSize not valid in svg image provider

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6714 from nextcloud/bugifx/version-suffix

Update build-appimage.sh to use $VERSION_SUFFIX

Update build-appimage.sh to use $VERSION_SUFFIX

Make sure that we can pass the value of MIRALL_VERSION_SUFFIX via parameter.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6779 from nextcloud/Jerome-Herbinet-replace-edit-with-open-in-browser

Replace "Edit" with "Open in browser"

Replace "Edit" with "Open in browser"

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6738 from nextcloud/bugfix/incorrect-date-parsing

Fix incorrect date parsing.

Merge pull request #6758 from nextcloud/ci/githubActionsForAppimage

produce Appimage packages from github actions

produce Appimage packages from github actions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6706 from nextcloud/bugfix/account-details

Censor account details string in file provider logging

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6713 from nextcloud/ci/fixWindowsTests

some files just cannot sync on windows: get automated tests to work

some files just cannot sync on windows: get automated tests to work

fix one automated test knowing the platform limitations of windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6756 from nextcloud/ci/fixMacCi

skip tests currently broken on macOS: enable mandatory tests for macOS

skip tests currently broken on macOS: enable mandatory tests for macOS

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6715 from nextcloud/updateInstallRequirementsInDoc

update doc with install requirements fom Qt6 supported platforms

update doc with install requirements for Qt6 supported platforms

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6725 from nextcloud/update/documentation

Extend 'How the "Edit locally" functionality works' text.

Extend 'How the "Edit locally" functionality works' text.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6705 from nextcloud/ci/fixWindowsCi

use windows-2022 image to run our windows CI on github actions

skip FolderWatcher on windows: really not a reliable test

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

disable some unreliable tests for CfApi CI

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix regression with VFS update metadata instruction

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

only compute checksum of a local file that is not a virtual one

should avoid triggering implicit hydration from within the desktop
client

triggering an implicit hydration on our own is strictly forbidden as
that is causing issues like deadlock and failed hydration attempts

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

remove usage of memory sanitizers in drone tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

better automated tests log

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

catch std::filesystem exceptions in automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

temporarily ignore failed tests on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>