Matthieu Gallien [Tue, 7 Dec 2021 13:44:08 +0000 (14:44 +0100)]
prevent injecting invalid modified time through CfApi calls
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 7 Dec 2021 10:48:13 +0000 (11:48 +0100)]
do not consider that a file has changed if its mtime is invalid
a mtime should never be 0 or negative
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 7 Dec 2021 10:33:43 +0000 (11:33 +0100)]
avoid downloading a file from server when modified time is invalid
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 7 Dec 2021 10:25:43 +0000 (11:25 +0100)]
prevent invalid modified time from being propagated
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 6 Dec 2021 14:07:57 +0000 (15:07 +0100)]
assert on invalid modtime
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Wed, 8 Dec 2021 04:04:09 +0000 (04:04 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Tue, 7 Dec 2021 17:19:50 +0000 (19:19 +0200)]
Merge pull request #4014 from nextcloud/feature/folder-logo-variations
Feature/folder logo variations
alex-z [Wed, 24 Nov 2021 14:09:41 +0000 (16:09 +0200)]
Use different icon for a sync folder on Windows depending on zoom level.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Matthieu Gallien [Tue, 7 Dec 2021 12:41:39 +0000 (13:41 +0100)]
Merge pull request #4033 from nextcloud/bugfix/renameBadFileNames
do not forget the path when renaming files with invalid names
Matthieu Gallien [Fri, 3 Dec 2021 10:43:45 +0000 (11:43 +0100)]
do not forget the path when renaming files with invalid names
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 3 Dec 2021 11:41:33 +0000 (12:41 +0100)]
test files that should be renamed in sub-directory
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Tue, 7 Dec 2021 05:08:46 +0000 (05:08 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 6 Dec 2021 04:00:07 +0000 (04:00 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 5 Dec 2021 04:07:16 +0000 (04:07 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 4 Dec 2021 04:02:11 +0000 (04:02 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Fri, 3 Dec 2021 10:32:30 +0000 (12:32 +0200)]
Merge pull request #4031 from nextcloud/feature/always-prefill-username-for-server24-and-up
Always prefill username from Windows login name based on server version
alex-z [Fri, 3 Dec 2021 08:41:33 +0000 (10:41 +0200)]
Always prefill username from Windows login name based on server version
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Fri, 3 Dec 2021 03:57:51 +0000 (03:57 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 2 Dec 2021 03:57:44 +0000 (03:57 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 1 Dec 2021 18:47:06 +0000 (18:47 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Wed, 1 Dec 2021 04:00:08 +0000 (04:00 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 30 Nov 2021 13:38:17 +0000 (14:38 +0100)]
Merge pull request #4009 from nextcloud/rakekniven-patch-1
l10n: Changed case of word
rakekniven [Sat, 27 Nov 2021 15:52:15 +0000 (16:52 +0100)]
l10n: Changed case of word
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Nextcloud bot [Tue, 30 Nov 2021 03:57:45 +0000 (03:57 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Camila [Mon, 29 Nov 2021 17:22:21 +0000 (18:22 +0100)]
Merge pull request #4012 from nextcloud/bugfix/fixCfApiUpdateMetadata
fix random error when updating CfApi metadata
Matthieu Gallien [Mon, 29 Nov 2021 16:43:44 +0000 (17:43 +0100)]
fix random error when updating CfApi metadata
initialiazing all fields in a structure is required to not have random
behavior
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Camila [Mon, 29 Nov 2021 14:10:47 +0000 (15:10 +0100)]
Merge pull request #4011 from nextcloud/bump-version
Bump version to 3.4.50.
Camila [Mon, 29 Nov 2021 13:57:18 +0000 (14:57 +0100)]
Bump version to 3.4.50.
Signed-off-by: Camila <hello@camila.codes>
Camila [Mon, 29 Nov 2021 13:46:29 +0000 (14:46 +0100)]
Merge pull request #4010 from nextcloud/bump-version
Bump VERSION.cmake to 3.4.0.
Camila [Mon, 29 Nov 2021 13:33:29 +0000 (14:33 +0100)]
Bump VERSION.cmake to 3.4.0.
Signed-off-by: Camila <hello@camila.codes>
Nextcloud bot [Mon, 29 Nov 2021 03:52:09 +0000 (03:52 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 28 Nov 2021 03:50:40 +0000 (03:50 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 27 Nov 2021 03:53:51 +0000 (03:53 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 26 Nov 2021 16:50:01 +0000 (17:50 +0100)]
Merge pull request #4006 from nextcloud/bugfix/speedUpBulkUpload
Bugfix/speed up bulk upload
Matthieu Gallien [Thu, 25 Nov 2021 21:58:12 +0000 (22:58 +0100)]
use the error message sent by the server for bulk upload
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 25 Nov 2021 21:11:59 +0000 (22:11 +0100)]
allow sending parallel batch of files: curretly disabled
can allow to send a new batch before the reply to a previous one is
received
due to concerns with the reliability on the server side this is disabled
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 25 Nov 2021 15:49:20 +0000 (16:49 +0100)]
really check that this is a valid answer when receiving batch upload
we could somehow miss that the reply is missing proper fields
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 25 Nov 2021 15:48:10 +0000 (16:48 +0100)]
batch upload: only handle file that are in the reply
do not handle all files sent but only received ones
should allow to submit more than one request in parallel
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 25 Nov 2021 15:46:10 +0000 (16:46 +0100)]
let auto tests of batch upload return proper file paths
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 25 Nov 2021 15:45:19 +0000 (16:45 +0100)]
make sure we do not start a new batch when the previous one is not sent
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 25 Nov 2021 15:44:57 +0000 (16:44 +0100)]
use a proper constant for the size of batch
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 26 Nov 2021 14:31:15 +0000 (15:31 +0100)]
Merge pull request #4003 from nextcloud/bugfix/errorBulkUpload
if BulkPropagatorJob abort after an error emit finished signal
Matthieu Gallien [Thu, 25 Nov 2021 09:17:47 +0000 (10:17 +0100)]
if BulkPropagatorJob abort after an error emit finished signal
prevent sync engine being stuck because of an error when preparing bulk
upload
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Fri, 26 Nov 2021 04:14:39 +0000 (04:14 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 25 Nov 2021 03:52:56 +0000 (03:52 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 24 Nov 2021 17:04:18 +0000 (18:04 +0100)]
Merge pull request #4001 from nextcloud/bumpVersion
release 3.4.0 RC2
Matthieu Gallien [Wed, 24 Nov 2021 16:46:10 +0000 (17:46 +0100)]
release 3.4.0 RC2
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 24 Nov 2021 16:42:25 +0000 (17:42 +0100)]
Merge pull request #3887 from nextcloud/feature/bulkUpload
Feature/bulk upload
Matthieu Gallien [Wed, 8 Sep 2021 10:10:01 +0000 (12:10 +0200)]
implement bulk upload
add PutMultiFileJob to send many files at once
use it in BulkPropagatorJob to implement bulk upload feature
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 28 Oct 2021 14:55:27 +0000 (16:55 +0200)]
read capabilities for bulk upload from server
use it in dedicated tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 25 Oct 2021 14:29:57 +0000 (16:29 +0200)]
make AbstractNetworkJob::errorString virtual: it is already overriden
in practice AbstractNetworkJob::errorString is already overriden but the
overrided code is probably never called while the intention looked like
the opposite
fix that by making the method virtual in base class
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Wed, 24 Nov 2021 11:26:29 +0000 (13:26 +0200)]
Merge pull request #3930 from nextcloud/feature/additional-features-for-initial-setup-config
Pass username from Windows to login page.
alex-z [Wed, 27 Oct 2021 15:55:08 +0000 (18:55 +0300)]
Pass username from Windows to login page.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Matthieu Gallien [Tue, 23 Nov 2021 16:11:07 +0000 (17:11 +0100)]
Merge pull request #3993 from nextcloud/bugfix/variousVfsFixes
Bugfix/various vfs fixes
Matthieu Gallien [Mon, 22 Nov 2021 12:28:58 +0000 (13:28 +0100)]
improve logging for CfApi
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 22 Nov 2021 12:27:00 +0000 (13:27 +0100)]
gracefully handle one case of invalid handles
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 22 Nov 2021 12:25:55 +0000 (13:25 +0100)]
fix OCC::CfApiWrapper::handleForPath when path does not exist
sometime it can be called with a path that is already deleted
ensure we always go to the correct code path
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 22 Nov 2021 12:24:50 +0000 (13:24 +0100)]
remove too noisy log print
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Camila [Tue, 23 Nov 2021 13:13:45 +0000 (14:13 +0100)]
Merge pull request #3983 from nextcloud/bugfix/only-build-app-bundle-if-needed
Only build app bundle if requested
Felix Weilbach [Wed, 17 Nov 2021 10:52:47 +0000 (11:52 +0100)]
Only build app bundle if requested
For development a app bundle is not needed. The app bundle is only
needed for distribution and macdeployqt takes a lot of time.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Matthieu Gallien [Tue, 23 Nov 2021 09:58:06 +0000 (10:58 +0100)]
Merge pull request #3994 from nextcloud/bugfix/reset-syncfolder-icon
Cleanup system bindings from Windows when removing a local sync folder
alex-z [Fri, 19 Nov 2021 14:03:09 +0000 (16:03 +0200)]
Cleanup system bindings from Windows when removing a local sync folder
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Tue, 23 Nov 2021 03:55:50 +0000 (03:55 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 22 Nov 2021 14:52:19 +0000 (15:52 +0100)]
Merge pull request #3989 from nextcloud/bugfix/forceVFS
fix button that should be disabled when force VFS
Matthieu Gallien [Fri, 19 Nov 2021 17:49:05 +0000 (18:49 +0100)]
fix button that should be disabled when force VFS
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 22 Nov 2021 12:51:55 +0000 (13:51 +0100)]
Merge pull request #3982 from nextcloud/addUserAgentQml
add a network access factory to qml engine
Matthieu Gallien [Wed, 17 Nov 2021 09:36:05 +0000 (10:36 +0100)]
add a network access factory to qml engine
ensure network access made via qml are using our user agent
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 22 Nov 2021 12:20:27 +0000 (13:20 +0100)]
Merge pull request #3971 from nextcloud/fix/scrolling-activiy-list
Make scrolling with a touchpad in activity list and search result more natural
Carl Schwan [Fri, 12 Nov 2021 20:02:58 +0000 (21:02 +0100)]
Add WheelHandler to the Search result list too
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Fri, 12 Nov 2021 17:22:00 +0000 (18:22 +0100)]
[tray] Makes scrolling with a touchpad in activiy list more natural
This basically use the same method that is used in Kirigami and Plasma
Components3.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
allexzander [Mon, 22 Nov 2021 10:39:01 +0000 (12:39 +0200)]
Merge pull request #3987 from nextcloud/bugfix/upload-new-folder-with-vfs
Quick fix! Disable VFS folders removal for non-Windows VFS.
alex-z [Thu, 18 Nov 2021 14:13:14 +0000 (16:13 +0200)]
Quick fix! Disable VFS folders removal for non-Windows VFS.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Sun, 21 Nov 2021 03:52:24 +0000 (03:52 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 20 Nov 2021 04:12:29 +0000 (04:12 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 19 Nov 2021 13:38:03 +0000 (14:38 +0100)]
Merge pull request #3988 from nextcloud/bugfix/runVfsFixOnlyOnce
properly query sync journal DB to know when to run fix for VFS
Matthieu Gallien [Thu, 18 Nov 2021 14:47:04 +0000 (15:47 +0100)]
properly query sync journal DB to know when to run fix for VFS
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run
the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Fri, 19 Nov 2021 09:48:05 +0000 (11:48 +0200)]
Merge pull request #3984 from nextcloud/bugfix/vfs-folder-upload-conflict
Added more logs to 'postProcessLocalNew'.
alex-z [Tue, 2 Nov 2021 14:21:06 +0000 (16:21 +0200)]
Added more logs to 'postProcessLocalNew'.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Fri, 19 Nov 2021 04:35:47 +0000 (04:35 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 18 Nov 2021 13:37:40 +0000 (13:37 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Thu, 18 Nov 2021 09:58:50 +0000 (10:58 +0100)]
Merge pull request #3985 from nextcloud/bugfix/unified-search-open-local-file
Use QUrl::fromLocalFile to open local files in Unified Search results
alex-z [Mon, 15 Nov 2021 12:24:04 +0000 (14:24 +0200)]
Use QUrl::fromLocalFile to open local files in Unified Search results.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Thu, 18 Nov 2021 09:08:38 +0000 (09:08 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 17 Nov 2021 10:31:29 +0000 (11:31 +0100)]
Merge pull request #3978 from nextcloud/bugfix/correct-placeholder-files
Correct virtual files placeholder files if needed
Felix Weilbach [Tue, 16 Nov 2021 11:11:08 +0000 (12:11 +0100)]
Refactor key-value store query code
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Felix Weilbach [Tue, 16 Nov 2021 10:50:43 +0000 (11:50 +0100)]
Correct virtual files placeholder files if needed
In the past not all files were converted to placeholder files when
converting an existing sync folder to a virtual files folder. Because
some files were not converted to placeholder files, the status would
be wrong on the files. This code makes sure that every file in a
virtual files folder is a placeholder file. It could be removed in the
future.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Felix Weilbach [Wed, 17 Nov 2021 09:17:27 +0000 (10:17 +0100)]
Merge pull request #3979 from nextcloud/bugfix/avoidUselessIconDownloads
avoid adding icon data in a cache we never use
Matthieu Gallien [Tue, 16 Nov 2021 15:11:44 +0000 (16:11 +0100)]
avoid adding icon data in a cache we never use
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 16 Nov 2021 13:53:35 +0000 (14:53 +0100)]
Merge pull request #3972 from nextcloud/fix/accessibility-keyboard
Fix focus indicator
Carl Schwan [Fri, 12 Nov 2021 19:17:15 +0000 (20:17 +0100)]
More fixes to the menu implementation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Fri, 12 Nov 2021 17:59:33 +0000 (18:59 +0100)]
Fix focus indicator
This improve considerably the keyboard navigation in the SystemTray.
But this is still not as good as the golden standard that is recommended
by this article: https://www.sarasoueidan.com/blog/focus-indicators/
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Matthieu Gallien [Tue, 16 Nov 2021 09:25:58 +0000 (10:25 +0100)]
Merge pull request #3969 from nextcloud/bugfix/finder-arch
Compile Finder extensions for arm and x86
Felix Weilbach [Fri, 12 Nov 2021 12:03:35 +0000 (13:03 +0100)]
Compile finder extensions for arm and x86
Fix: https://github.com/nextcloud/desktop/issues/3967
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Matthieu Gallien [Tue, 16 Nov 2021 08:53:37 +0000 (09:53 +0100)]
Merge pull request #3968 from nextcloud/bugfix/user-status-disabled
Check if the server has user status app enabled
Felix Weilbach [Fri, 12 Nov 2021 10:55:16 +0000 (11:55 +0100)]
Check if the server has user status app enabled
According to
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#user-status-retrieve-statuses
we should check the user status capability, not the the end points.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Matthieu Gallien [Mon, 15 Nov 2021 16:19:24 +0000 (17:19 +0100)]
Merge pull request #3970 from nextcloud/updateDoc
we run on Windows 8.1+
Matthieu Gallien [Fri, 12 Nov 2021 14:18:53 +0000 (15:18 +0100)]
we run on Windows 8.1+
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 15 Nov 2021 12:18:30 +0000 (13:18 +0100)]
Merge pull request #3959 from Minoru/bugifx/detect-missing-guiprivate
CMake: fail if `Qt5::GuiPrivate` is not found
Alexander Batischev [Mon, 8 Nov 2021 12:31:50 +0000 (15:31 +0300)]
CMake: fail if `Qt5::GuiPrivate` is not found
`nextcloud` and `nextcloudCore` depend on three Qt5 components which
aren't mentioned in `find_library`: `Xml`, `Network`, and `GuiPrivate`.
The first two are omitted by mistake, apparently, so this commit just
adds them.
`GuiPrivate` is a special case: it doesn't have its own CMake config, so
adding it to "required components" in `find_package` will always fail
the build. Thus, we implement our own check instead.
Signed-off-by: Alexander Batischev <eual.jp@gmail.com>
Felix Weilbach [Mon, 15 Nov 2021 08:43:55 +0000 (09:43 +0100)]
Merge pull request #3966 from nextcloud/bugfix/macos-installer-universal
Let the macOS installer know that the application can run on Arm64
projects / nextcloud-desktop.git / log