Benjamin Otte [Wed, 30 May 2018 19:04:05 +0000 (21:04 +0200)]
gdk: Remove leftover type from autocleanup
Benjamin Otte [Wed, 30 May 2018 02:37:47 +0000 (04:37 +0200)]
wayland: Get rid of GdkWaylandSelection
Move data source handling into the DND code instead.
Benjamin Otte [Wed, 30 May 2018 02:04:51 +0000 (04:04 +0200)]
wayland: Split drop context into GdkWaylandDrop
GdkWaylandDrop no longer inherits from GdkDragContext now.
Benjamin Otte [Wed, 30 May 2018 02:04:39 +0000 (04:04 +0200)]
wayland: Remove a bunch of unused functions
Benjamin Otte [Tue, 29 May 2018 18:49:41 +0000 (20:49 +0200)]
events: Make GdkEventDND have a GdkDrop member
... instead of a GdkDragContext.
Benjamin Otte [Tue, 29 May 2018 18:44:32 +0000 (20:44 +0200)]
x11: Refactor DND filter
The filters now return TRUE/FALSE and no longer a GdkFilterReturn. They
also don't conform to the GdkFilterFunc typedef anymore but instead take
the arguments that they need.
Benjamin Otte [Tue, 29 May 2018 17:13:24 +0000 (19:13 +0200)]
x11: Use new DND event emitters
Benjamin Otte [Tue, 29 May 2018 17:00:10 +0000 (19:00 +0200)]
win32: Use new DND event emitters
Benjamin Otte [Wed, 23 May 2018 18:11:28 +0000 (20:11 +0200)]
wayland: Use new DND event emitters
Benjamin Otte [Wed, 23 May 2018 17:41:54 +0000 (19:41 +0200)]
drop: Add private API for event emission
Benjamin Otte [Wed, 23 May 2018 16:30:14 +0000 (18:30 +0200)]
drop: Add GdkDrop:surface property
This replaces gdk_drag_context_get_dest_surface().
Benjamin Otte [Tue, 22 May 2018 17:43:43 +0000 (19:43 +0200)]
display: Don't wake up the main loop anymore
This is not needed because GTK must be run in the main thread these days,
which is the same one that runs the main loop. So when this function is
called, the main loop is awake.
https://bugzilla.gnome.org/show_bug.cgi?id=550989
Benjamin Otte [Tue, 22 May 2018 13:48:50 +0000 (15:48 +0200)]
x11: Don't sneakily allocate memory in initializers
Benjamin Otte [Tue, 22 May 2018 13:32:27 +0000 (15:32 +0200)]
dnd: Add gdk_event_get_drop()
And remove gdk_event_get_drag_context().
All GTK code now only uses GdkDrop for dropping.
Benjamin Otte [Sun, 20 May 2018 18:22:02 +0000 (20:22 +0200)]
wayland: Fix drop operations for new semantics
Benjamin Otte [Sun, 20 May 2018 18:15:39 +0000 (20:15 +0200)]
dnd: Remove GdkDragContext::commit_drag_status() vfunc
The idea behind the vfunc doesn't work as status updates can happen
asynchronously.
A better solution needs to be found.
Benjamin Otte [Thu, 17 May 2018 02:51:18 +0000 (04:51 +0200)]
dnd: Make drag-motion and drag-drop signals use GdkDrop
Benjamin Otte [Wed, 16 May 2018 02:50:24 +0000 (04:50 +0200)]
dnd: Make drag-data-received use a GdkDrop
Benjamin Otte [Wed, 16 May 2018 02:49:58 +0000 (04:49 +0200)]
drop: Add gdk_drop_get_drag()
For now, it'll always return NULL. We'll fix that later.
Benjamin Otte [Tue, 15 May 2018 22:59:01 +0000 (00:59 +0200)]
widget: Make GtkWidgetClass::drag_leave() take a GdkDrop
Drag Contexts are on their way out!
Benjamin Otte [Tue, 15 May 2018 03:45:06 +0000 (05:45 +0200)]
dnd: Add gdk_drop_finish()
and move the vfunc into GdkDrop.
Benjamin Otte [Mon, 14 May 2018 14:44:43 +0000 (16:44 +0200)]
dnd: Get rid of gtk_drag_finish()
It's just a wrapper around gdk_drag_finish(), so use that one instead.
Benjamin Otte [Mon, 14 May 2018 13:09:42 +0000 (15:09 +0200)]
dnd: Rename gdk_drop_finish() => gdk_drag_finish()
This is a simple rename, so that we can reintroduce gdk_drop_finish()
with the GdkDrop object.
Benjamin Otte [Mon, 14 May 2018 02:16:25 +0000 (04:16 +0200)]
dnd: Move the gdk_drag_status() function
It's now gdk_drop_status().
Also clarify the intended semantics.
Benjamin Otte [Mon, 14 May 2018 00:49:33 +0000 (02:49 +0200)]
dnd: Add gdk_drop_get_actions()
This uses the new method without GDK_ACTION_ASK:
Either it is a single action (queryable via gdk_drag_action_is_unique())
or it is not and then the drop target has to make a decision
(potentially by asking someone).
Benjamin Otte [Sun, 13 May 2018 15:03:57 +0000 (17:03 +0200)]
dnd: Make actions a private member variable
Use a setter in the backends.
Benjamin Otte [Sun, 13 May 2018 00:38:31 +0000 (02:38 +0200)]
x11: Remove unused variables
Benjamin Otte [Sat, 12 May 2018 21:43:01 +0000 (23:43 +0200)]
wayland: Set correct variable
This got messed up in commit
7f8a8f221d60bc5da23602e5e024eb91f8b0f758.
Benjamin Otte [Fri, 11 May 2018 22:13:11 +0000 (00:13 +0200)]
dnd: Add gdk_drag_action_is_unique()
This will be necessary once we remove the ASK action.
Benjamin Otte [Tue, 8 May 2018 11:56:08 +0000 (13:56 +0200)]
dnd: Remove GDK_ACTION_DEFAULT and GDK_ACTION_PRIVATE
They're unused and nobody knows what they're supposed to men anyway.
Benjamin Otte [Mon, 7 May 2018 22:47:26 +0000 (00:47 +0200)]
drop: Move gdk_drop_read_async() to GdkDrop class
Benjamin Otte [Mon, 30 Apr 2018 12:10:44 +0000 (14:10 +0200)]
dnd: Add GdkDrop base class for GdkDragContext
The ultimate goal of this patch series is to split GdkDragContext into
GdkDrop + GdkDrag classes for the destination and source side of a dnd
operation.
The refactoring is meant to work something like this:
1. Introduce GdkDrop as a base class
2. Make all drop related code (like GdkEvent) use GdkDrop instead of
GdkDragContext. Move/duplicate APIs to allow that.
3. Port all drop contexts in the backends from GdkDragContext to GdkDrop
4. Delete all APIs in GdkDragContext that aren't needed anymore.
5. Make GdkDragContext no longer a GdkDrop subclass
6. Rename GdkDragContext to GdkDrag
Matthias Clasen [Mon, 18 Jun 2018 21:37:42 +0000 (21:37 +0000)]
Merge branch 'lrn/misc-gtk4-fixes' into 'master'
Misc GTK4 fixes
See merge request GNOME/gtk!195
Matthias Clasen [Mon, 18 Jun 2018 20:09:47 +0000 (20:09 +0000)]
Merge branch 'win32-filechooser-fix-file-list-order' into 'master'
win32 file chooser: add missing g_slist_reverse
See merge request GNOME/gtk!199
Timm Bäder [Mon, 18 Jun 2018 17:39:32 +0000 (19:39 +0200)]
themes: Don't handle box.linked special
We don't reverse the css nodes anymore in RTL layouts.
Timm Bäder [Mon, 18 Jun 2018 15:24:57 +0000 (17:24 +0200)]
filechooserbutton: Remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 13:25:25 +0000 (15:25 +0200)]
GtkStyleContext: Remove the frame clock
It's unused within GtkStyleContext.
Timm Bäder [Mon, 18 Jun 2018 13:04:00 +0000 (15:04 +0200)]
dnd: Fix up a comment
The below function does not take a GtkIconHelper anymore.
Timm Bäder [Mon, 18 Jun 2018 12:28:19 +0000 (14:28 +0200)]
colorscale: Remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 11:11:06 +0000 (13:11 +0200)]
fontbutton: Remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 10:33:37 +0000 (12:33 +0200)]
radiobutton: remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 10:23:56 +0000 (12:23 +0200)]
picture: Fix up some docs
Use nullable instead of allow-none consistently, remove trailing
whitespace and fix some c&p problems.
Timm Bäder [Mon, 18 Jun 2018 09:17:41 +0000 (11:17 +0200)]
drawingarea: Clarify some comments
Timm Bäder [Mon, 18 Jun 2018 09:14:36 +0000 (11:14 +0200)]
messagedialog: Remove priv pointer
Timm Bäder [Sat, 16 Jun 2018 18:58:50 +0000 (20:58 +0200)]
paned: Allocation x/y are always 0
The allocation position we get passed to size_allocate is always 0/0
these days.
Timm Bäder [Sat, 16 Jun 2018 18:58:17 +0000 (20:58 +0200)]
paned: Remove handle_pos member
Query the handle bounds on demand instead.
Timm Bäder [Sat, 16 Jun 2018 18:31:48 +0000 (20:31 +0200)]
paned: Chain up in snapshot
No need to snapshot all child widgets ourselves, the implementation in
GtkWidget can just do it for us.
Timm Bäder [Sat, 16 Jun 2018 18:15:18 +0000 (20:15 +0200)]
paned: Remove unnecessary local variable
We can just pass the given allocation on.
Timm Bäder [Sat, 16 Jun 2018 18:13:07 +0000 (20:13 +0200)]
paned: Don't unnecessarily redraw handle in size_allocate
We size_allocate it after all, which will redraw it.
Timm Bäder [Sat, 16 Jun 2018 15:19:30 +0000 (17:19 +0200)]
paned: Store GParamSpecs
So we can use the more efficient g_object_notify_by_pspec everywhere.
Timm Bäder [Sat, 16 Jun 2018 14:10:00 +0000 (16:10 +0200)]
Remove gtk_css_node_reverse_children
Not needed anymore.
Timm Bäder [Sat, 16 Jun 2018 14:09:14 +0000 (16:09 +0200)]
toolbar: Stop reordering css nodes based on text direction
Timm Bäder [Sat, 16 Jun 2018 14:05:05 +0000 (16:05 +0200)]
headerbar: Stop reordering css nodes depending on text direction
Timm Bäder [Sat, 16 Jun 2018 13:56:55 +0000 (15:56 +0200)]
notebook: Stop reversing tabs based on text direction
Timm Bäder [Sat, 16 Jun 2018 13:25:14 +0000 (15:25 +0200)]
builder: Fix g-i annotations of _get_translation_domain
The return value can be null and is (transfer none).
Timm Bäder [Sat, 16 Jun 2018 12:59:49 +0000 (14:59 +0200)]
builder: Use TRUE/FALSE for error return values
Instead of guint and 0/1.
Timm Bäder [Sat, 16 Jun 2018 12:51:12 +0000 (14:51 +0200)]
builder: Remove priv pointer
Timm Bäder [Sun, 10 Jun 2018 19:54:25 +0000 (21:54 +0200)]
box: Don't reorder children based on text direction
Make :first-child always be the first child, i.e. the leftest one in LTR
and the rightest one in RTL.
Timm Bäder [Sun, 10 Jun 2018 19:47:35 +0000 (21:47 +0200)]
paned: Don't reorder css nodes based on text direction
Timm Bäder [Sun, 10 Jun 2018 19:35:19 +0000 (21:35 +0200)]
center box: Don't reorder css nodes in RTL
So widget order matches css order. We will do the same thing with GtkBox
eventually.
Timm Bäder [Sat, 16 Jun 2018 09:47:06 +0000 (11:47 +0200)]
scrolledwindow: Remove priv pointer
Matthias Clasen [Mon, 18 Jun 2018 11:36:09 +0000 (11:36 +0000)]
Merge branch 'window-activate-grab-4-again' into 'master'
gdk: activate surface on keyboard grabs
Closes #85
See merge request GNOME/gtk!174
Nicolai Syvertsen [Mon, 18 Jun 2018 09:44:46 +0000 (09:44 +0000)]
win32 file chooser: add missing g_slist_reverse
the list is prepended to so we need to reverse the list
before returning
Samuel Thibault [Fri, 1 Jun 2018 14:43:01 +0000 (16:43 +0200)]
gdk: activate surface on keyboard grabs
In
01455399e83a ("gdk: do not deactivate surface on keyboard grabs"), we
made gdk avoid deactivating surfaces when another application takes a
keyboard grab, by using has_focus_window instead of has_focus. That however
broke activating surfaces when the gdk application acquired a grab itself,
in which case has_focus_window is false but has_focus is true.
We thus actually need to use both: surfaces should be activated either
because we have normal keyboard focus, or because we grabbed the keyboard.
This also renames HAS_FOCUS to APPEARS_FOCUSED to better reflect its
role.
Fixes #85
Piotr Drąg [Sun, 17 Jun 2018 15:24:07 +0000 (17:24 +0200)]
Update Polish translation
Руслан Ижбулатов [Sat, 16 Jun 2018 18:26:29 +0000 (18:26 +0000)]
GDK W32: don't unref window iconlist textures
We do not own these textures, nor do we ref them, so it's inappropriate
to unref them.
Руслан Ижбулатов [Sat, 16 Jun 2018 18:24:56 +0000 (18:24 +0000)]
W32: Use correct hinstance values
According to the old new thing[0], we should use the instance handle
of the GDK/GTK DLL when registering GDK-specific types in the system.
Using the instance handle for the whole application in these circumstances
is not an error, but can potentially clash with the types registered
by the application itself.
Also, extract window class icons from the GDK/GTK DLL, not from the
application executable.
[0]: https://blogs.msdn.microsoft.com/oldnewthing/
20050418-59/?p=35873
Руслан Ижбулатов [Sat, 16 Jun 2018 18:23:56 +0000 (18:23 +0000)]
Pass the correct data to gdk_content_register_serializer()
The argument is eventually passed to g_conv(), so it should
be the charset, not the mime/type. Without this change the
contentype converter will fail to convert UTF-8 strings to, say,
CP-1251 later on.
Руслан Ижбулатов [Sat, 16 Jun 2018 18:22:12 +0000 (18:22 +0000)]
W32: don't put a string literal into gtk_libdir
In all other instances gtk_libdir is a dynamically-allocated string,
so dup the literal in this case as well.
Руслан Ижбулатов [Sat, 16 Jun 2018 18:21:42 +0000 (18:21 +0000)]
Add forward declaration for DllMain() in gtkwin32.c
Руслан Ижбулатов [Sat, 16 Jun 2018 18:20:49 +0000 (18:20 +0000)]
Use const for media type in devmode_to_settings()
Руслан Ижбулатов [Sat, 16 Jun 2018 18:20:22 +0000 (18:20 +0000)]
Add foward declarations to gtk_print_operation_run_without_dialog
Timm Bäder [Sat, 16 Jun 2018 08:15:57 +0000 (10:15 +0200)]
search bar example: remove unused function
Timm Bäder [Sun, 10 Jun 2018 19:30:23 +0000 (21:30 +0200)]
center box: Remove snapshot implementation
Timm Bäder [Sun, 10 Jun 2018 12:41:43 +0000 (14:41 +0200)]
gl renderer: call glViewport directly
Timm Bäder [Sun, 10 Jun 2018 11:39:30 +0000 (13:39 +0200)]
button: Remove measure implementation
This is already done by GtkBin.
Timm Bäder [Sun, 10 Jun 2018 10:25:44 +0000 (12:25 +0200)]
combobox: Remove priv pointer
Matthias Clasen [Fri, 15 Jun 2018 16:27:44 +0000 (16:27 +0000)]
Merge branch 'wip/lantw/fix-gtkdoc-build-without-wayland' into 'master'
docs: Fix gtk-doc build when wayland is disabled
See merge request GNOME/gtk!193
Ting-Wei Lan [Fri, 15 Jun 2018 15:51:15 +0000 (23:51 +0800)]
docs: Fix gtk-doc build when wayland is disabled
Unconditionally putting 'gdkwayland_inc' in src_dir argument of gtkdoc
call tells gtkdoc-scan to scan source files in a non-existent build
directory, gdk/wayland. To avoid causing build failure when a specific
backend is disabled, we should include directories conditionally.
Matthias Clasen [Fri, 15 Jun 2018 02:00:57 +0000 (02:00 +0000)]
Merge branch 'design_by' into 'master'
aboutbox: use a more fitting 'design by" role
Closes #1153
See merge request GNOME/gtk!192
Mohammed Sadiq [Thu, 14 Jun 2018 17:53:14 +0000 (23:23 +0530)]
examples: Simplify handling events in search-bar
In search-bar example, we can use gtk_search_bar_set_key_capture_widget()
which would simplify handling keyboard events.
Jakub Steiner [Thu, 14 Jun 2018 14:36:38 +0000 (16:36 +0200)]
aboutbox: use a more fitting 'design by" role
- in most cases, authors listed under "artwork by" are actually responsible for
the design of the app as a whole
Fixes issue #1153
Mohammed Sadiq [Thu, 14 Jun 2018 05:45:14 +0000 (11:15 +0530)]
Revert "imcontext: Make size arguments be gsize and not int"
This was committed accidently.
This reverts commit
eefd2d6f104973d1461feee0b94dff8af991e145.
Mohammed Sadiq [Thu, 14 Jun 2018 05:39:19 +0000 (11:09 +0530)]
examples: Fix alignment of search-bar example
The search entry was taking the whole window size.
Let's reduce the size so as to have more natural size.
Benjamin Otte [Wed, 13 Jun 2018 19:40:38 +0000 (21:40 +0200)]
imcontext: Make size arguments be gsize and not int
Otherwise gcc complains when we use these as arguments to g_new() on
32bit architectures with:
../gtk/gtkcomposetable.c: In function ‘gtk_compose_table_list_add_array’:
/usr/include/glib-2.0/glib/gmem.h:217:10: warning: argument 1 range [
2147483648,
4294967295] exceeds maximum object size
2147483647 [-Walloc-size-larger-than=]
__p = g_##func##_n (__n, __s); \
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gmem.h:279:42: note: in expansion of macro ‘_G_NEW’
#define g_new0(struct_type, n_structs) _G_NEW (struct_type, n_structs, malloc0)
^~~~~~
../gtk/gtkcomposetable.c:851:22: note: in expansion of macro ‘g_new0’
gtk_compose_seqs = g_new0 (guint16, length);
^~~~~~
/usr/include/glib-2.0/glib/gmem.h:96:10: note: in a call to allocation function ‘g_malloc0_n’ declared here
gpointer g_malloc0_n (gsize n_blocks,
^~~~~~~~~~~
Mohammed Sadiq [Thu, 14 Jun 2018 00:00:21 +0000 (05:30 +0530)]
docs: Update getting started docs
We have removed references to private members in our examples.
Let the docs be updated to reflect that.
Mohammed Sadiq [Wed, 13 Jun 2018 14:45:20 +0000 (20:15 +0530)]
docs: Use gtk_widget_show() to show window
gtk_window_show_all() is no longer available (and no longer needed)
Mohammed Sadiq [Wed, 13 Jun 2018 14:28:01 +0000 (19:58 +0530)]
snapshot: Trivial typo fix in comment
Rico Tzschichholz [Wed, 13 Jun 2018 11:08:28 +0000 (13:08 +0200)]
picture: Fix g-i annotation warning
Mohammed Sadiq [Mon, 11 Jun 2018 15:14:23 +0000 (20:44 +0530)]
build: Fix compiler warnings
Mohammed Sadiq [Mon, 11 Jun 2018 12:10:05 +0000 (17:40 +0530)]
overlay: Use the right property variable name
Benjamin Otte [Mon, 11 Jun 2018 11:55:09 +0000 (11:55 +0000)]
Merge branch 'wip/sadiq/fixes' into 'master'
overlay: Add support for clipping overlay widgets
See merge request GNOME/gtk!189
Mohammed Sadiq [Mon, 11 Jun 2018 10:36:22 +0000 (16:06 +0530)]
overlay: Add support for clipping overlay widgets
Sometimes users may want to restrict the growth of child
widgets in a GtkOverlay to grow atmost the size of the overlay.
Let's add a support for that.
Matthias Clasen [Sun, 10 Jun 2018 23:14:42 +0000 (23:14 +0000)]
Merge branch 'lrn/gtk4warnings' into 'master'
Fix a lot of warnings in GTK4
See merge request GNOME/gtk!188
Matthias Clasen [Sun, 10 Jun 2018 23:05:50 +0000 (23:05 +0000)]
Merge branch 'master' into 'master'
gtk: Add gtk_is_initialized() and gtk_get_main_thread()
See merge request GNOME/gtk!186
Matthias Clasen [Sun, 10 Jun 2018 22:05:12 +0000 (22:05 +0000)]
Merge branch 'lrn/aligned-alloc' into 'master'
Aligned allocators for GTK4
Closes #856
See merge request GNOME/gtk!187
Руслан Ижбулатов [Sun, 10 Jun 2018 21:05:30 +0000 (21:05 +0000)]
Use correct stat struct for ftw()
check_dir_mtime() is called by ftw() and is given
the real stat struct, not its glib version (which may
or may not be the same as "struct stat").
This is irrelevant for MSVC (it has no ftw()) and
works correctly for MinGW-w64 (which declares stat
structures correctly). If mingw.org complains, add
a special ifdef for it later.
Руслан Ижбулатов [Sun, 10 Jun 2018 21:04:50 +0000 (21:04 +0000)]
See if _MSC_VER is defined before checking its value
Руслан Ижбулатов [Sun, 10 Jun 2018 21:04:27 +0000 (21:04 +0000)]
Fix missing default switch case in DllMain
Руслан Ижбулатов [Sun, 10 Jun 2018 21:04:03 +0000 (21:04 +0000)]
Fix missing default switch cases in gtkimcontextsimple