summary |
shortlog | log |
commit |
commitdiff |
tree
first ⋅ prev ⋅ next
Michael Tokarev [Sat, 2 Apr 2022 16:01:55 +0000 (19:01 +0300)]
ensure libsmbclient.h is being used with LFS enabled
Bug-Debian: https://bugs.debian.org/221618
Forwarded: not-needed
We build samba with LFS (Large File Support) even on 32bits.
This means some types like off_t are 64-bit wide, again,
even on a 32bit host. libsmbclient.h uses off_t in function
prototypes, and thes prototypes muct match those which were
used at samba compile time - if some other source includes
libsmbclient.h without LFS, it'll get wrong prototypes and
the resulting binary will most likely crash when using
libsmbclient functions.
Detect and error-out this at compile time.
We can not do anything with this in the public header since
it is alredy too late to redefine things, since we can't
guarantee we're the first header a program #includes, and
at the time this libsmbclient.h is included, off_t can
already be defined so our (re)define of _FILE_OFFSET_BITS
does nothing already.
Patching libsmbclient.h to use off64_t means client program
should change their off_t to off64_t too when storing
file offsets returning from libsmbclient, so this is not
an option too.
With this change, we will error out even if the user source
does not use any off_t-related functions. Namely, it was ok
to #include <libsmbclient.h> and use smbc_open/smbc_read/
smbc_write/smbc_close without _F_O_B=64, - neither of these
functions uses off_t. smbc_lseek and others doesn't work,
but if a program does not use them anyway, whole thing will
just work even without enabling LFS. Ideally we can probably
check each individual function which is being affected, by
replacing it with #error if sizeof(off_t) < 8. But this
requires quite some hackery...
Gbp-Pq: Name libsmbclient-ensure-lfs-221618.patch
Michael Tokarev [Fri, 18 Apr 2025 10:02:55 +0000 (13:02 +0300)]
samba (2:4.22.1+dfsg-1) unstable; urgency=medium
* new upstream stable/bugfix release:
- https://bugzilla.samba.org/show_bug.cgi?id=15727:
net ad join fails with "Failed to join domain:
failed to create kerberos keytab"
- https://bugzilla.samba.org/show_bug.cgi?id=15767:
Deadlock between two smbd processes
- https://bugzilla.samba.org/show_bug.cgi?id=15774:
Running "gpo manage motd set" twice fails with backtrace
- https://bugzilla.samba.org/show_bug.cgi?id=15791:
Remove of file or directory not possible with vfs_acl_tdb
- https://bugzilla.samba.org/show_bug.cgi?id=15810:
Add async io API from libcephfs to ceph_new VFS module
- https://bugzilla.samba.org/show_bug.cgi?id=15818:
vfs_ceph_new module does not work with other modules
for snapshot management
- https://bugzilla.samba.org/show_bug.cgi?id=15822:
Enable support for cephfs case insensitive behavior
- https://bugzilla.samba.org/show_bug.cgi?id=15823:
Subnet based interfaces definition not listening
on all covered IP addresses
- https://bugzilla.samba.org/show_bug.cgi?id=15829:
samba-tool gpo backup creates entity backups it can't read
- https://bugzilla.samba.org/show_bug.cgi?id=15834:
vfs_ceph_new: Add path based fallback for SMB_VFS_FCHOWN,
SMB_VFS_FCHMOD and SMB_VFS_FNTIMES
- https://bugzilla.samba.org/show_bug.cgi?id=15836:
PANIC: assert failed at source3/smbd/smb2_oplock.c(156):
sconn->oplocks.exclusive_open>=0
- https://bugzilla.samba.org/show_bug.cgi?id=15839:
gp_cert_auto_enroll_ext.py has problem unpacking GUIDs with prepended 0's
- https://bugzilla.samba.org/show_bug.cgi?id=15841:
Wide link issue in samba 4.22
- https://bugzilla.samba.org/show_bug.cgi?id=15845:
NT_STATUS_INVALID_PARAMETER: Can't create folders
on share of an exfat file system
- https://bugzilla.samba.org/show_bug.cgi?id=15849:
Lease code is not endian-safe
* drop widelinks-nofollow.patch (included upstream)
* drop smbd-fix-handling-of-directory-leases-and-oplock-lev.patch (ditto)
[dgit import unpatched samba 2:4.22.1+dfsg-1]
Michael Tokarev [Fri, 18 Apr 2025 10:02:55 +0000 (13:02 +0300)]
Import samba_4.22.1+dfsg.orig.tar.xz
[dgit import orig samba_4.22.1+dfsg.orig.tar.xz]
Michael Tokarev [Fri, 18 Apr 2025 10:02:55 +0000 (13:02 +0300)]
Import samba_4.22.1+dfsg-1.debian.tar.xz
[dgit import tarball samba 2:4.22.1+dfsg-1 samba_4.22.1+dfsg-1.debian.tar.xz]