Claudio Cambra [Wed, 17 Apr 2024 20:55:14 +0000 (04:55 +0800)]
Wrap access of itemUrl in security scoping
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 20:54:40 +0000 (04:54 +0800)]
Explicitly set bundle name and identifiers from env vars in FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 18:26:49 +0000 (02:26 +0800)]
Unify FileProviderUIExt entitlements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 18:07:48 +0000 (02:07 +0800)]
Make sure network error is shown in UI instead of generic error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 17:58:38 +0000 (01:58 +0800)]
Improve logging across file provider sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 08:45:46 +0000 (16:45 +0800)]
Merge pull request #6645 from nextcloud/backport/6642/stable-3.13
[stable-3.13] Make use of NextcloudFileProviderKit in File Provider Module
Claudio Cambra [Wed, 17 Apr 2024 08:18:17 +0000 (16:18 +0800)]
Pin NextcloudFileProviderKit version to 0.9.0 (up to next major version)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 08:17:42 +0000 (16:17 +0800)]
Remove now-unneeded Realm dependency from FileProviderExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 18:47:21 +0000 (02:47 +0800)]
Set changeobserver as delegate for nkcommon
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 18:06:30 +0000 (02:06 +0800)]
Remove client-side push notification handling for file provider extension in favour of simply using NCFPK remote change observer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 16:48:59 +0000 (00:48 +0800)]
Add change observer from NCFPK
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 13:27:47 +0000 (21:27 +0800)]
Always signal enumerator after errors to try and recover from what the error might have been
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 13:27:27 +0000 (21:27 +0800)]
Provide NCFPK enumerator with extension domain
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Apr 2024 10:22:53 +0000 (18:22 +0800)]
Correctly set up NCKit instance with account string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 18:47:36 +0000 (02:47 +0800)]
Remove unused components in FileProviderExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 18:42:50 +0000 (02:42 +0800)]
Fix passing of wrong item into item.modify
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 17:54:37 +0000 (01:54 +0800)]
Improve logging in delete item procedure of FPExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 17:54:20 +0000 (01:54 +0800)]
Use NCFPK item modify method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 16:54:21 +0000 (00:54 +0800)]
Use NCFPK Item.create in createItem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 15:51:40 +0000 (23:51 +0800)]
Use fetchContents from NCFPK item
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 14:42:53 +0000 (22:42 +0800)]
Simplify FileProviderExtension's deleteItem method by leveraging Item's delete method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 14:41:22 +0000 (22:41 +0800)]
Greatly simplify item method of FIleProviderExtension by using item storedItem method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 11:40:53 +0000 (19:40 +0800)]
Use new convenience method to get Item for root container from NCFPK
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 11:30:09 +0000 (19:30 +0800)]
Use thumbnail fetching procedure from NCFPK
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 10:42:50 +0000 (18:42 +0800)]
Fix build of ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 10:33:08 +0000 (18:33 +0800)]
Adapt to new NextcloudFileProviderKit item nomenclature
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 10:24:57 +0000 (18:24 +0800)]
Make use of NextcloudFileProviderKit materialisedenumerationobserver
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 10:21:31 +0000 (18:21 +0800)]
Use FileProviderItem from NextcloudFileProviderKit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 10:07:23 +0000 (18:07 +0800)]
Use Enumerator in NextcloudFileProviderKit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 09:30:08 +0000 (17:30 +0800)]
Remove use of all code now available in NextcloudFileProviderKit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 09:28:37 +0000 (17:28 +0800)]
Add NextcloudFileProviderKit dependency
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 08:08:40 +0000 (16:08 +0800)]
Remove FileProviderExtTests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 07:44:10 +0000 (15:44 +0800)]
Allow NextcloudFilesDatabaseManager to take a specific realmconfig in constructor
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 07:36:13 +0000 (15:36 +0800)]
Database manager does not need to be an NSObject
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 07:28:34 +0000 (15:28 +0800)]
Add test target for file provider testing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 17 Apr 2024 08:43:39 +0000 (16:43 +0800)]
Merge pull request #6643 from nextcloud/backport/stable-3.13-fp-sharing
Backport/stable 3.13 fp sharing
Claudio Cambra [Wed, 17 Apr 2024 05:47:17 +0000 (13:47 +0800)]
Set file provider extension target as a dependency of file provider ui extension target in CMake
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Apr 2024 07:18:07 +0000 (15:18 +0800)]
Allow SuggestionsTextFieldKit to use up to next major version
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 8 Apr 2024 10:45:18 +0000 (18:45 +0800)]
Upgrade NextcloudCapabilitiesKit version
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 17:09:13 +0000 (01:09 +0800)]
Add a "no shares" label if there are no shares available in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 16:58:26 +0000 (00:58 +0800)]
Update description label in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 16:46:38 +0000 (00:46 +0800)]
Display shareWith in nkshare displaystring extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 16:42:18 +0000 (00:42 +0800)]
Pin NextcloudCapabilitiesKit version
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 14:30:27 +0000 (22:30 +0800)]
Pin NextcloudKit version
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 14:28:22 +0000 (22:28 +0800)]
Set suggestionstextfieldkit to 1.0.0
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 14:28:10 +0000 (22:28 +0800)]
Clean up TODO comments in file provider ui ext
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 14:14:52 +0000 (22:14 +0800)]
Fix SuggestionsTextFieldKit import
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 14:11:29 +0000 (22:11 +0800)]
Simplify configuration of text field delegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sat, 6 Apr 2024 10:04:34 +0000 (18:04 +0800)]
Fix suggestion labels for sharees
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Apr 2024 12:46:01 +0000 (20:46 +0800)]
Use suggestions window controller in share options view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Apr 2024 12:41:08 +0000 (20:41 +0800)]
Improve logging in ShareeSuggestionsDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Apr 2024 12:40:58 +0000 (20:40 +0800)]
Post suggestions changed notification in ShareeSuggestionsDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Apr 2024 10:19:01 +0000 (18:19 +0800)]
Update suggestions on inputString change in sharee suggestions data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Apr 2024 10:18:42 +0000 (18:18 +0800)]
Add converter method fro nksharee to suggestion
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Apr 2024 10:17:35 +0000 (18:17 +0800)]
Add sharee fetcher method to shareesuggestionsdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Apr 2024 10:17:08 +0000 (18:17 +0800)]
Add basic shareesuggestionsdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Apr 2024 10:16:31 +0000 (18:16 +0800)]
Add SuggestionsTextFieldKit dependency
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 18:26:35 +0000 (02:26 +0800)]
Add package dependency NextcloudCapabilitiesKit to NextcloudIntegration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 12:54:41 +0000 (20:54 +0800)]
Retry getting information from FileProviderExt if doing so has failed (usually due to opening share view before auth details are present)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 12:19:16 +0000 (20:19 +0800)]
Deduplicate error presentation in ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 12:08:14 +0000 (20:08 +0800)]
Fix options view disappearing when clicking create button in share view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 11:38:56 +0000 (19:38 +0800)]
Fix letter used to identify shareability in sharetableviewdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 11:38:41 +0000 (19:38 +0800)]
Fix scan path to retrieve item metadata in share table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 11:05:54 +0000 (19:05 +0800)]
Ensure interpolated logging string in share table view data source is public
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 10:57:52 +0000 (18:57 +0800)]
Check if the given item is shareable before fetching shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 19 Mar 2024 10:57:28 +0000 (18:57 +0800)]
Add method to ShareTableViewDataSource to fetch the given item's metadata
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 12:14:31 +0000 (20:14 +0800)]
Add more debug logging to sharecapabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 12:14:22 +0000 (20:14 +0800)]
Fix default states around passwords for share options view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 11:58:30 +0000 (19:58 +0800)]
Fix ShareCapabilities parsing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 11:18:27 +0000 (19:18 +0800)]
Fix password capabilities for public link capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 11:17:13 +0000 (19:17 +0800)]
Update form layout according to picked type when picked type changed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 11:16:29 +0000 (19:16 +0800)]
Setup the fields in share options view when creating a new form according to capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 11:15:10 +0000 (19:15 +0800)]
Update reset to make sure it also resets min and max dates in date picker, don't affect share type
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 10:52:39 +0000 (18:52 +0800)]
Extract conversion of picked menu item in share type picker into NKShare ShareType into new method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 10:06:56 +0000 (18:06 +0800)]
Do not bother fetching shares if sharing is disabled on server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 10:06:26 +0000 (18:06 +0800)]
Fetch sharing capabilities in ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 09:51:10 +0000 (17:51 +0800)]
Add init for ShareCapabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 18 Mar 2024 09:49:47 +0000 (17:49 +0800)]
Add init for public link capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 13 Mar 2024 11:08:07 +0000 (19:08 +0800)]
Add initialiser from dictionary for EmailCapabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 13 Mar 2024 10:59:28 +0000 (18:59 +0800)]
Restructure ShareCapabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 13 Mar 2024 10:16:51 +0000 (18:16 +0800)]
Add ShareCapabilities struct
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 12 Mar 2024 06:27:35 +0000 (14:27 +0800)]
Adapt visibility of note recipient text field upon toggling checkbox
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 18:00:41 +0000 (02:00 +0800)]
Adapt visibility of expiration date field upon toggling checkbox
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 17:30:57 +0000 (01:30 +0800)]
Adapt visibility of password field upon toggling password checkbox
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 17:20:58 +0000 (01:20 +0800)]
Reset newly added fields in ShareOptionsView correctly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 17:12:19 +0000 (01:12 +0800)]
Properly handle failure state when creating new share in share options view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 17:11:42 +0000 (01:11 +0800)]
Correctly treat share recipient text field in the share options view flow
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 17:10:43 +0000 (01:10 +0800)]
Add a text field for relevant shareWith in ShareOptionsView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 16:50:45 +0000 (00:50 +0800)]
Have specific cancel behaviour in shareoptionsview on delete if in create mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 16:39:56 +0000 (00:39 +0800)]
Change deleteButton to a cancel button when in creation mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 15:44:34 +0000 (23:44 +0800)]
Adjust share options view title depending on create mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 12:09:54 +0000 (20:09 +0800)]
Make share options view capable of creating or updating view upon clicking "save" depending on create status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 12:09:16 +0000 (20:09 +0800)]
Connect different share type popup button menu items to outlets in share options view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 12:08:45 +0000 (20:08 +0800)]
Make create button in share view controller show options view and toggle create mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 12:08:06 +0000 (20:08 +0800)]
Add "createMode" toggle to share options view, start building for use to create new shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Mar 2024 12:07:24 +0000 (20:07 +0800)]
Add additional options to share controller creation method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 5 Mar 2024 11:24:16 +0000 (19:24 +0800)]
Nilify itemServerRelativePath upon loading item in table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 5 Mar 2024 11:15:05 +0000 (19:15 +0800)]
Make item's server relative path public in sharetableviewdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 5 Mar 2024 11:14:33 +0000 (19:14 +0800)]
Add static method to create shares in ShareController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 5 Mar 2024 10:35:28 +0000 (18:35 +0800)]
Add a popupbutton to share options vie to select type of share
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
projects / nextcloud-desktop.git / log