Olivier Goffart [Fri, 19 Oct 2018 07:11:01 +0000 (09:11 +0200)]
Fix windows build
Olivier Goffart [Wed, 17 Oct 2018 13:15:11 +0000 (15:15 +0200)]
Account Settings: fix progress being written in white when there are errors
Christian Kamm [Fri, 31 Aug 2018 13:50:54 +0000 (15:50 +0200)]
Virtual files: Wipe selective sync settings when enabled
Christian Kamm [Thu, 30 Aug 2018 15:55:24 +0000 (17:55 +0200)]
virtual files: show option only when branding allows it
Christian Kamm [Fri, 31 Aug 2018 13:50:36 +0000 (15:50 +0200)]
Virtual files: Use theme to check for option availability
Olivier Goffart [Thu, 26 Nov 2020 08:56:52 +0000 (09:56 +0100)]
Account Settings: Add a context menu entry to enable or disable virtual files
Issue #6725
Olivier Goffart [Tue, 9 Oct 2018 07:20:15 +0000 (09:20 +0200)]
Upload: Do not error out if the server do not send the X-OC-MTime: accepted header
If the server does not set the mtime, it is not a big problem for the
synchronisation.
The test was used before so we could do a PROPPATCH for server that did not
support this header. But now that all server supports that we don't need to
to the check. (We do not do the PROPPATCH since we got rid of the neon
dependency)
Apparently, it may happen that some backend don't support setting mtime
and this can lead to this error.
https://github.com/owncloud/client/issues/6797
Dominik Schmidt [Thu, 27 Sep 2018 18:08:48 +0000 (20:08 +0200)]
Do not select ownCloud in Finder after installation to fix #6781
Olivier Goffart [Fri, 5 Oct 2018 17:45:43 +0000 (19:45 +0200)]
OAuth2: Store 'Account::davUser' in the config, and use that user for connecting
We need to use the user id to check if we are connected to the right account.
These might be different from the HTTP Basic Auth login. (LDAP setups)
When the account was configured as an oauth2 account form the wisard, the
http_user was already set correctly to the user id. But when the server is
upgrading from basic auth to oauth2, we need to pick the right login.
Note that Account::davUser() already defaults to the HTTP user when none
is set, so this means the upgrade will be fine if this is not set in the
config.
Issues:
https://github.com/owncloud/oauth2/issues/109
https://github.com/owncloud/enterprise/issues/2781
Olivier Goffart [Thu, 11 Oct 2018 10:15:44 +0000 (12:15 +0200)]
Local discovery: always recurse within touched directory
If the file system watcher tells us a directory was modified, we should
recurse into it because it means it is probably a new directory
Issue #6804
Christian Kamm [Mon, 8 Oct 2018 10:04:54 +0000 (12:04 +0200)]
PropagateUpload: Avoid crash due to cascading aborts
https://sentry.io/owncloud/desktop-win-and-mac/issues/
698694072/activity/
Olivier Goffart [Fri, 5 Oct 2018 17:03:08 +0000 (19:03 +0200)]
Fix leaks in tests
As discovered by AddressSanitizer
Christian Kamm [Wed, 17 Oct 2018 08:59:45 +0000 (10:59 +0200)]
Discovery: restructure processFileAnalyzeLocalInfo
Christian Kamm [Wed, 17 Oct 2018 08:43:25 +0000 (10:43 +0200)]
Discovery: easy conditions first in processFileAnalyzeRemoteInfo
Removing two levels of indent that way
Christian Kamm [Wed, 17 Oct 2018 08:42:58 +0000 (10:42 +0200)]
Discovery: Add comments
Olivier Goffart [Tue, 16 Oct 2018 14:18:39 +0000 (16:18 +0200)]
Discovery: make sure finished is not called twice, even in case of errors
Olivier Goffart [Tue, 16 Oct 2018 14:08:49 +0000 (16:08 +0200)]
Remove the backup deteciton code which was used for server < 9.1
Olivier Goffart [Tue, 16 Oct 2018 14:00:59 +0000 (16:00 +0200)]
Discovery: Remove stale DB entries
And test the Remove/Remove case.
This means we need to always query the database for all the entries.
This showed another small bug in the test in which sync item for virtual
files at the root could have a slash in front of them.
Christian Kamm [Tue, 16 Oct 2018 13:08:04 +0000 (15:08 +0200)]
Discovery: Comments and visibility adjustments
Olivier Goffart [Tue, 16 Oct 2018 11:25:17 +0000 (13:25 +0200)]
Discovery: cleanups and comments
Olivier Goffart [Tue, 16 Oct 2018 12:55:39 +0000 (14:55 +0200)]
Discovery: move checkMovePermissions to its own function
Olivier Goffart [Tue, 16 Oct 2018 12:44:20 +0000 (14:44 +0200)]
Discovery: Adjust the instruction in case of resolved conflict
When resolving a conflict because the file was just updated on the server,
we write all the metadata on the database immediatly, so INSTRUCITON_NONE
is enough and UPDATE_METADATA is not needed
Olivier Goffart [Tue, 16 Oct 2018 11:42:52 +0000 (13:42 +0200)]
ProcessDirectoryJob: always set _childModified to true, regardless the direction
This was like that to handle the case of CSYNC_INSTRUCTION_TYPE_CHANGE, but just add
a condition in this location.
Olivier Goffart [Tue, 16 Oct 2018 11:03:24 +0000 (13:03 +0200)]
Discovery phase: refactor some code in DiscoveryPhase::findAndCancelDeletedJob
Less code duplication
Olivier Goffart [Tue, 16 Oct 2018 09:03:46 +0000 (11:03 +0200)]
New Discovery Algorithm: more cleanups
- rename progress() to be more explicit
- Make some more member of the discovery phase private
Olivier Goffart [Mon, 15 Oct 2018 16:05:51 +0000 (18:05 +0200)]
Fixup commit
835c9163374f42003aa2f7795ade3f4ff62c8877
The previous code considered the also HTTP 207 code without the
application/xml header to have this message.
httpCode 0 does not make much sense anyway.
This change the behavior to consider any 2xx without the xml header
to show this error message
Olivier Goffart [Mon, 15 Oct 2018 15:02:04 +0000 (17:02 +0200)]
New discovery algorithm: fixups
Adapt reviews from ckamm in https://github.com/owncloud/client/pull/6738#pullrequestreview-
164623532
- SyncJournalFileRecord: initialize everything inline
- Add more comments
- And some ENFORCE
Olivier Goffart [Mon, 15 Oct 2018 14:51:24 +0000 (16:51 +0200)]
Move Result to its own header
Olivier Goffart [Fri, 12 Oct 2018 12:44:33 +0000 (14:44 +0200)]
New discovery algorithm: Parallel PROPFIND
Olivier Goffart [Tue, 9 Oct 2018 13:54:42 +0000 (15:54 +0200)]
New Discovery algorithm: Remove the sync cleanup phase
Since we do not recurse within some directories, many files are not seen.
The stale entry will cleanup by themself as the sync engine try to remove
the files that are already removed.
Should we need to actually do this cleanup, it should be dotected in the
discovery.
Olivier Goffart [Tue, 9 Oct 2018 13:54:03 +0000 (15:54 +0200)]
New discovery algorithm: Set the originalFile for ignored files
This is used to show the name in the UI
Olivier Goffart [Tue, 9 Oct 2018 13:12:02 +0000 (15:12 +0200)]
New Propagation algorithm: Fetch, and emit, the root etag
Remove the feature to concatenate etags as servers that don't
have a root etag are no longer suported
Olivier Goffart [Tue, 9 Oct 2018 11:45:27 +0000 (13:45 +0200)]
New Discovery Algorithm: Ge tthe size of new folders
Also add a test that this works properly
Olivier Goffart [Tue, 9 Oct 2018 10:49:21 +0000 (12:49 +0200)]
New Discovery algorithm: Split the process function even further
Move the finialization in its own function.
This allow to save a bit of code duplication.
Also change the order of the parameter in the constructor for consistency
Olivier Goffart [Fri, 5 Oct 2018 09:05:08 +0000 (11:05 +0200)]
New Discovery Algo: Refactor by splitting the processFile in two
Olivier Goffart [Thu, 4 Oct 2018 13:04:29 +0000 (15:04 +0200)]
New Discovery Algorithm: Handle rename of virtual files
Christian Kamm [Wed, 26 Sep 2018 11:41:02 +0000 (13:41 +0200)]
Virtual files: Renames propagate #6718
Olivier Goffart [Sun, 16 Sep 2018 10:25:44 +0000 (12:25 +0200)]
Folder Wizard: Disable the 'choose what to sync' treeview if virtual files are selected
Don't allow to configure virtual files with a selective sync blacklist
Olivier Goffart [Sun, 16 Sep 2018 19:52:50 +0000 (21:52 +0200)]
AccountSetting: Fix Small Memoy leak
Olivier Goffart [Wed, 5 Sep 2018 16:36:53 +0000 (18:36 +0200)]
Fix tx.pl
The conflict filename changed
Olivier Goffart [Mon, 3 Sep 2018 07:45:08 +0000 (09:45 +0200)]
AccountSettings: Force sync should wipe the blacklist
Issue #6757
Olivier Goffart [Thu, 30 Aug 2018 16:14:33 +0000 (18:14 +0200)]
Virtual files: don't check for new big folders
https://github.com/owncloud/client/issues/6724#issuecomment-
417368475
Olivier Goffart [Thu, 30 Aug 2018 16:14:13 +0000 (18:14 +0200)]
Virtual files: Don't show selective sync
Issue #6724
Olivier Goffart [Tue, 28 Aug 2018 08:35:26 +0000 (10:35 +0200)]
Socket API: add an option to replace existing files with virtual files
Issue #6726
Olivier Goffart [Fri, 29 Jun 2018 07:43:53 +0000 (09:43 +0200)]
Update the minimum supported version
We want to warn if the server version is not supported and did not get
appropriate QA for this client version.
https://github.com/owncloud/enterprise/issues/2687
Markus Goetz [Wed, 22 Aug 2018 14:38:57 +0000 (16:38 +0200)]
CMakeLists.txt: Log the Qt version in compile
Christian Kamm [Tue, 21 Aug 2018 09:24:45 +0000 (11:24 +0200)]
Conflicts: Rename BasePath to InitialBasePath #6709
Olivier Goffart [Thu, 5 Jul 2018 12:36:10 +0000 (14:36 +0200)]
Checksum: Add support for SHA256 and SHA3
In case, some day, the server also supports it
Olivier Goffart [Thu, 5 Jul 2018 12:24:44 +0000 (14:24 +0200)]
Move the checksum related routine from FileSystem to checksum, where they belong
Olivier Goffart [Mon, 3 Sep 2018 09:47:15 +0000 (11:47 +0200)]
Fix a compilation error on windows
Olivier Goffart [Mon, 27 Aug 2018 13:10:12 +0000 (15:10 +0200)]
New Discovery Algo: readability improvements
As proposed by ckamm on #6738
Olivier Goffart [Tue, 21 Aug 2018 17:54:48 +0000 (19:54 +0200)]
New discovery algo: data finger print
Olivier Goffart [Tue, 21 Aug 2018 11:08:09 +0000 (13:08 +0200)]
New Disco Algo: Handle spurious virtual files
Port commit
0b9049e6ff01401883184d29d22dd4a30c092da8
for issue #6718
Olivier Goffart [Tue, 21 Aug 2018 08:45:27 +0000 (10:45 +0200)]
Fix test link with older Qt
Olivier Goffart [Tue, 14 Aug 2018 11:35:04 +0000 (13:35 +0200)]
Conflict handling: add the OC-ConflictBasePath header
Issue #6702
Olivier Goffart [Sat, 18 Aug 2018 07:37:00 +0000 (09:37 +0200)]
Account Settings: Add a text for folder using vierual files
Issue #6723
Olivier Goffart [Sat, 18 Aug 2018 07:14:01 +0000 (09:14 +0200)]
Virtual Files: Set the mtime of the virtual file to that of the server
Note: When the server mtime is modified, the mtime of the file is not updated
Issue #6727
Olivier Goffart [Fri, 17 Aug 2018 10:04:48 +0000 (12:04 +0200)]
Virtual Files Mime Type: use "vnd." prefix instead of "x-"
As reported in https://github.com/owncloud/client/issues/6717#issuecomment-
413703567
Christian Kamm [Thu, 16 Aug 2018 10:38:39 +0000 (12:38 +0200)]
Virtual files: Renaming to virtual doesn't delete data #6718
Unfortunately to do this, the local update phase must write to the
database, creating a new side-effect and order dependency (local update
must run before remote update).
Olivier Goffart [Tue, 7 Aug 2018 07:32:14 +0000 (09:32 +0200)]
SyncEngine: Fix renames making hierarchy inversion
Issue #6694
Christian Kamm [Wed, 15 Aug 2018 10:16:46 +0000 (12:16 +0200)]
RemotePermissions: Fix empty vs null
Fixes two bugs that appeared since the introduction of the struct:
- when reading permissions from the journal, null ("") was read as
empty-not-null
- when reading permissinos from the server, empty ("") was read as null
Addresses #4608
Olivier Goffart [Wed, 1 Aug 2018 09:10:38 +0000 (11:10 +0200)]
FolderStatusModel: Do not abort applying selective sync if one folder has an error
Issue #6675
Olivier Goffart [Tue, 14 Aug 2018 07:19:31 +0000 (09:19 +0200)]
SyncEngine: Fix the "direction" of the "all file delted" message when the server is reset
Using the direction of the "first" item is not enough as it might be a directory
which is a UPDATE_META_DATA, or there can have been a few changes locally as well.
As reported on https://github.com/owncloud/client/issues/6317#issuecomment-
412163113
Christian Kamm [Wed, 25 Jul 2018 09:13:14 +0000 (11:13 +0200)]
Do not require server replies to contain an mtime
The check was added for #6317 in commit
13eb64584f5f96647ced39dcd3252860ebec5a37.
We did see missing mtimes in replies in tests with live servers though.
Possibly those were old incomplete responses cached in the stat cache?
Olivier Goffart [Mon, 6 Aug 2018 10:53:51 +0000 (12:53 +0200)]
New discovery algorithm: Call FolderDiscovered
Olivier Goffart [Mon, 6 Aug 2018 10:41:59 +0000 (12:41 +0200)]
New Discovery algorithm: Refactor a bit the way the signal are emited
Olivier Goffart [Mon, 6 Aug 2018 10:37:39 +0000 (12:37 +0200)]
Fix TestDownload: _ignore_hidden_files was not properly initialized
Olivier Goffart [Mon, 6 Aug 2018 09:27:11 +0000 (11:27 +0200)]
New Discovery Phase: fix a few FIXME
Some FIXME were already fixed.
Olivier Goffart [Mon, 6 Aug 2018 08:52:34 +0000 (10:52 +0200)]
New discovery algorithm: handle symlinks
Olivier Goffart [Mon, 6 Aug 2018 08:31:37 +0000 (10:31 +0200)]
New discovery algo: Handle Database error
Olivier Goffart [Thu, 26 Jul 2018 11:53:40 +0000 (13:53 +0200)]
Skip failing test
These tests are failling because now we consider that any files that ends
with .owncloud is a virtual file, regardless what the DB say.
Olivier Goffart [Thu, 26 Jul 2018 08:16:28 +0000 (10:16 +0200)]
New discovery phase: read the direct download URL and Cookie
Olivier Goffart [Thu, 26 Jul 2018 07:53:40 +0000 (09:53 +0200)]
More cleanup of csync remains
Olivier Goffart [Wed, 25 Jul 2018 16:31:36 +0000 (18:31 +0200)]
New Discovery Algo: Permsission check
Olivier Goffart [Wed, 25 Jul 2018 14:00:16 +0000 (16:00 +0200)]
Remove csync_update and csync_reconcile
I guess some other csync utilities can also be remove dnow but
that will be for later
Olivier Goffart [Wed, 25 Jul 2018 13:31:54 +0000 (15:31 +0200)]
Remove the check_csync_update test
since csync_update is going away
Olivier Goffart [Wed, 25 Jul 2018 13:24:30 +0000 (15:24 +0200)]
New Discovery Algorithm: handle server errors
Olivier Goffart [Wed, 25 Jul 2018 12:08:55 +0000 (14:08 +0200)]
Olivier Goffart [Wed, 25 Jul 2018 10:21:29 +0000 (12:21 +0200)]
Added test that checks what happens when there is an error in the remote discovery
(Many of the expected error string are left empty because the current
error message is not insterresting
Olivier Goffart [Mon, 23 Jul 2018 13:19:32 +0000 (15:19 +0200)]
Convert p7.pl to a C++ test
This is just a translation of test/scripts/txpl/t7.pl to C++ using the test
framework.
Olivier Goffart [Wed, 18 Jul 2018 11:44:41 +0000 (13:44 +0200)]
New Discovery Algo: Support the DatabaseAndFilesystem mode for local discovery
Olivier Goffart [Wed, 18 Jul 2018 10:40:22 +0000 (12:40 +0200)]
New Disco algortihm: Fix TestChunkingNG::connectionDroppedBeforeEtagRecieved
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Olivier Goffart [Wed, 18 Jul 2018 10:15:13 +0000 (12:15 +0200)]
New disco algo: Fix TestSyncFileStatusTracker
Olivier Goffart [Wed, 18 Jul 2018 09:13:46 +0000 (11:13 +0200)]
New discovery algorithm: More work on virtual files
Olivier Goffart [Tue, 17 Jul 2018 15:18:07 +0000 (17:18 +0200)]
New Disco algorithm: Type change (file to dir)
Olivier Goffart [Tue, 17 Jul 2018 11:33:57 +0000 (13:33 +0200)]
New discovery algorithm: Virtual files
The commented tests lines were implementation details
Olivier Goffart [Tue, 17 Jul 2018 08:09:57 +0000 (10:09 +0200)]
New discovery algorithm: Fix directory deletion
TestAllFilesDeleted passes
Olivier Goffart [Mon, 16 Jul 2018 16:35:35 +0000 (18:35 +0200)]
New Discovery algorithm
Some error handling. In particular for the case where there is a conflict
between files and directories.
SyncEngineTest and SyncMoveTest passes
Olivier Goffart [Mon, 16 Jul 2018 14:31:10 +0000 (16:31 +0200)]
New Discovery algorithm: Handle of move within a moved directory
Olivier Goffart [Fri, 13 Jul 2018 15:47:06 +0000 (17:47 +0200)]
New discovery algoritmh: more on Renames
Olivier Goffart [Fri, 13 Jul 2018 13:33:54 +0000 (15:33 +0200)]
New Discovery algorithm: Check that the original file is still on the server while renaming
Olivier Goffart [Thu, 12 Jul 2018 08:36:15 +0000 (10:36 +0200)]
New disco algorithm: Fix some moving
Fix TestSyncMove::testSelectiveSyncMovedFolder
Olivier Goffart [Wed, 11 Jul 2018 15:45:47 +0000 (17:45 +0200)]
New discovery algorithm: Local rename
Olivier Goffart [Wed, 11 Jul 2018 14:55:00 +0000 (16:55 +0200)]
New discovery algo: Remote move
TestSyncMove::testRemoteChangeInMovedFolder
Olivier Goffart [Tue, 10 Jul 2018 14:56:15 +0000 (16:56 +0200)]
Handle Encoding Problems
TestSyncEngine now passes
Olivier Goffart [Tue, 10 Jul 2018 14:37:59 +0000 (16:37 +0200)]
Ignore Hidden Files
Olivier Goffart [Tue, 10 Jul 2018 14:21:45 +0000 (16:21 +0200)]
Port the invalid napme regexp
TestSyncEngine::testInvalidFilenameRegex
Olivier Goffart [Tue, 10 Jul 2018 13:45:20 +0000 (15:45 +0200)]
More progress
TestSyncEngine::testFakeConflict / TestSyncEngine::testSyncFileItemProperties
Olivier Goffart [Tue, 10 Jul 2018 12:50:32 +0000 (14:50 +0200)]
New discovery algo
Make TestSyncEngine::testSelectiveSyncBug pass
Olivier Goffart [Tue, 10 Jul 2018 09:22:43 +0000 (11:22 +0200)]
New discovery: TestSyncEngine::testEmlLocalChecksum