Christian Hergert [Fri, 22 Jul 2022 18:30:21 +0000 (11:30 -0700)]
build: configure subproject sysprof with -Dagent=false
Sysprof has a new -Dagent=true build option which allows installing a
/usr/bin/sysprof-agent program (simimlar to sysprof-cli). It provides a
P2P D-Bus API to the process which can control subprocesses. It's used by
IDE tooling to have more control across container boundaries.
However, we do not need it for GTK CI.
Emmanuele Bassi [Tue, 26 Jul 2022 15:09:28 +0000 (15:09 +0000)]
Merge branch 'markand-main-patch-04776' into 'main'
gtk: Missing end of code block
See merge request GNOME/gtk!4902
David Demelier [Tue, 26 Jul 2022 14:52:30 +0000 (14:52 +0000)]
gtk: Missing end of code block
Nart Tlisha [Tue, 26 Jul 2022 11:17:20 +0000 (11:17 +0000)]
Add Abkhazian translation
Benjamin Otte [Tue, 26 Jul 2022 01:08:08 +0000 (01:08 +0000)]
Merge branch 'gridview' into 'main'
Gridview fix rubberbanding issues
Closes #3462 and #3445
See merge request GNOME/gtk!4688
Corey Berla [Tue, 26 Jul 2022 00:01:28 +0000 (17:01 -0700)]
listview: Fix selection for last item in get_items_in_rect
Make the last item dependent on y + height
Corey Berla [Tue, 26 Jul 2022 00:00:46 +0000 (17:00 -0700)]
listview: Allow starting rubberband in empty space below last row
Rubberband does not work when initiated past the last row
(warning is printed "Could not start rubberbanding: No item).
Clamp y at the max height of the widgets in the listview
Corey Berla [Mon, 25 Jul 2022 23:59:35 +0000 (16:59 -0700)]
listview: Return an empty bitset when selecting only empty space
Return an empty bitset if the user selects exclusively below the last
row.
Corey Berla [Thu, 5 May 2022 04:48:11 +0000 (21:48 -0700)]
gridview: Fix typo in docstring for gtk_grid_view_get_cell_at_y()
Corey Berla [Thu, 5 May 2022 04:41:30 +0000 (21:41 -0700)]
listbase: Clear selection if rubberband selected an empty set
If rubberband returns an empty bitset the selection should be cleared
unless the shift or ctrl key is held
Corey Berla [Mon, 25 Jul 2022 22:55:13 +0000 (15:55 -0700)]
gridview: Return an empty bitset when selecting only empty space
Return an empty bitset if the user selects exclusively below the last
row. No need to calculate selection.
Corey Berla [Tue, 26 Jul 2022 00:16:56 +0000 (17:16 -0700)]
gridview: Fix get_items_in_rect() selection
last_row should be dependent on y + height, not y
Corey Berla [Mon, 25 Jul 2022 22:35:20 +0000 (15:35 -0700)]
gridview: Allow starting rubberband in empty space below last row
Rubberband does not work when initiated past the last row
(warning is printed "Could not start rubberbanding: No item).
Clamp y at the max height of the widgets in the gridview
Fixes: #3462
Corey Berla [Thu, 5 May 2022 04:33:26 +0000 (21:33 -0700)]
gridview: Limit rectangle to gridview columns
The function gtk_grid_view_get_items_in_rect() erroneously calculates
columns less than 0 and greater than n_columns when the user attempts
to rubberband all the way to the left or right respectively. This
causes the rubberband to persistent and creates unexpected behavior.
Limit the rows to a minimum of 0 and maximum of n_columns - 1.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3445
Corey Berla [Tue, 26 Jul 2022 00:19:30 +0000 (17:19 -0700)]
gridview: Move gtk_grid_view_computer_total_height() up for reuse
Emmanuele Bassi [Mon, 25 Jul 2022 21:31:18 +0000 (21:31 +0000)]
Merge branch 'widget-docs-fix' into 'main'
gtkwidget: Fix a small typo in a docs comment
See merge request GNOME/gtk!4901
Philip Withnall [Mon, 25 Jul 2022 21:15:58 +0000 (23:15 +0200)]
gtkwidget: Fix a small typo in a docs comment
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Zurab Kargareteli [Mon, 25 Jul 2022 16:03:57 +0000 (16:03 +0000)]
Update Georgian translation
Emmanuele Bassi [Mon, 25 Jul 2022 11:45:43 +0000 (11:45 +0000)]
Merge branch 'content-fit-since' into 'main'
picture: Fix Since and Deprecated annotations for content-fit
See merge request GNOME/gtk!4897
Maximiliano Sandoval R [Mon, 25 Jul 2022 10:52:43 +0000 (12:52 +0200)]
picture: Fix Since and Deprecated annotations
gi-docgen will parse four or more whitespaces of indentation as code blocks,
two whitespaces were used.
This was missing in https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4873.
Jordi Mas [Thu, 21 Jul 2022 02:25:20 +0000 (04:25 +0200)]
Update Catalan translation
Carlos Garnacho [Tue, 19 Jul 2022 22:15:04 +0000 (22:15 +0000)]
Merge branch 'fix-controller-key-event-propagation-file-chooser-widget' into 'main'
GtkFileChooserWidget: Propagate captured key events when the location entry is focused
Closes #4880
See merge request GNOME/gtk!4674
Matthias Clasen [Mon, 18 Jul 2022 14:35:11 +0000 (14:35 +0000)]
Merge branch 'drag-action' into 'main'
tree/iconview: Use a unique drag action in drag_enter/motion callbacks
Closes #3187
See merge request GNOME/gtk!4882
Matthias Clasen [Mon, 18 Jul 2022 14:33:26 +0000 (14:33 +0000)]
Merge branch 'treeview-drag-ancestor' into 'main'
treeview: Check for column header area in row click/drag gestures
Closes #4453
See merge request GNOME/gtk!4885
Matthias Clasen [Mon, 18 Jul 2022 14:24:49 +0000 (14:24 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
css: Fix handling of transform values
See merge request GNOME/gtk!4890
Matthias Clasen [Mon, 18 Jul 2022 14:18:22 +0000 (14:18 +0000)]
Merge branch 'wip/carlosg/use-press-serial' into 'main'
gdk/wayland: Use last implicit grab serial for DnD start requests
Closes #5048
See merge request GNOME/gtk!4889
Carlos Garnacho [Mon, 18 Jul 2022 10:50:39 +0000 (12:50 +0200)]
gdk/wayland: Stop storing the last serial in GdkWaylandDisplay
This is not used anymore, so we can drop the serial being stored
here.
Matthias Clasen [Mon, 18 Jul 2022 12:38:52 +0000 (12:38 +0000)]
Merge branch 'drop-target-unique' into 'main'
droptarget: Provide a unique action for gdk_drop_finish
Closes #5051
See merge request GNOME/gtk!4888
Matthias Clasen [Mon, 18 Jul 2022 12:28:34 +0000 (12:28 +0000)]
Merge branch 'tree-popover-scroll' into 'main'
treepopover: Add support for scrolling
Closes #3674 and #4877
See merge request GNOME/gtk!4887
Matthias Clasen [Sun, 17 Jul 2022 13:11:23 +0000 (09:11 -0400)]
css: Improve test coverage
Among other things, this includes a test for the fix
in the previous commit.
Matthias Clasen [Mon, 18 Jul 2022 11:59:39 +0000 (06:59 -0500)]
css: Fix handling of transform values
When computing a transform value, there is nothing
to do, but we still need to copy the matrix from
src to dest, since it depends on the other transforms
in the array whether we are using the src or the
dest in the end.
This fixes cases like
-gtk-icon-transform: perspective(100px) matrix(1,2,...);
which would otherwise end up with a zero matrix.
Matthias Clasen [Sun, 17 Jul 2022 13:10:38 +0000 (09:10 -0400)]
gtk: Improve test coverage
Matthias Clasen [Sun, 17 Jul 2022 13:10:08 +0000 (09:10 -0400)]
sortlistmodel: Add more tests
Matthias Clasen [Sun, 17 Jul 2022 13:09:58 +0000 (09:09 -0400)]
filterlistmodel: Add more tests
Carlos Garnacho [Mon, 18 Jul 2022 10:46:11 +0000 (12:46 +0200)]
gdk/wayland: Use last press serial for clipboard/primary selections
This serial observes key and button presses, we can use that instead
of relying on the last serial which might come from other
events/devices.
Carlos Garnacho [Mon, 18 Jul 2022 10:37:29 +0000 (12:37 +0200)]
gdk/wayland: Use last implicit grab serial for DnD start requests
This serial should be that from a button press/touch down/etc, use
the last implicit grab here, which will presumably be from the same
device that triggered the event.
Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5048
Mat [Sun, 17 Jul 2022 19:24:51 +0000 (22:24 +0300)]
treepopover: Add support for scrolling
Add support for scrolling large tree popovers in a similar fashion to GtkPopoverMenu.
Fixes #3674
Fixes #4877
Mat [Sun, 17 Jul 2022 16:11:34 +0000 (19:11 +0300)]
droptarget: Provide a unique action for gdk_drop_finish
gdk_drop_finish() requires a unique drop action. Reuse the existing
make_action_unique() function to get one.
Fixes #5051
Quentin PAGÈS [Sun, 17 Jul 2022 15:38:50 +0000 (15:38 +0000)]
Update Occitan translation
Emmanuele Bassi [Sun, 17 Jul 2022 15:00:19 +0000 (15:00 +0000)]
Merge branch 'picture-suggest-content-fit' into 'main'
picture: Remove keep-aspect-ratio mention in the doc
See merge request GNOME/gtk!4886
Mat [Sun, 17 Jul 2022 12:48:30 +0000 (15:48 +0300)]
treeview: Check for column header area in row click/drag gestures
Bail out if a row click/drag gesture is performed in the column header area,
since separate gestures handle column headers.
Fixes #4453
Marco Melorio [Sun, 17 Jul 2022 14:17:40 +0000 (16:17 +0200)]
picture: Remove keep-aspect-ratio mention in the doc
We were still suggesting to use it in the main doc page. Suggest using
content-fit instead.
Matthias Clasen [Sun, 17 Jul 2022 10:50:22 +0000 (10:50 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
filterlistmodel: Add a test
See merge request GNOME/gtk!4884
Matthias Clasen [Sun, 17 Jul 2022 10:27:39 +0000 (06:27 -0400)]
slicelistmodel: Improve a test
Make sure that replacements in the underlying model
don't affect the slice list model if they are outside
the slice window.
Matthias Clasen [Sun, 17 Jul 2022 10:22:55 +0000 (06:22 -0400)]
sortlistmodel: Add a test
Add a test to prove that additions and removals
in the underlying model show up as expected.
Matthias Clasen [Sun, 17 Jul 2022 10:05:15 +0000 (06:05 -0400)]
filterlistmodel: Add a test
Test that items added in the underlying model show
up in the filter model (if they pass the filter).
Test removals as well.
See #5050
Mat [Sat, 16 Jul 2022 17:50:41 +0000 (20:50 +0300)]
tree/iconview: Use a unique drag action in drag_enter/motion callbacks
Functions already exist for providing a unique drag action for gdk_drop_finish().
Reuse these functions in the drag_enter/motion callbacks, since they require
a unique action as the return value.
Fixes #3187
Matthias Clasen [Sun, 17 Jul 2022 01:33:09 +0000 (01:33 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
widget-factory: Make the icon work uninstalled
See merge request GNOME/gtk!4881
Matthias Clasen [Sun, 17 Jul 2022 01:16:40 +0000 (21:16 -0400)]
widget-factory: Make the icon work uninstalled
Include the app logo as a resource, so we can show
it even when uninstalled.
Matthias Clasen [Sat, 16 Jul 2022 23:19:10 +0000 (23:19 +0000)]
Merge branch 'fix-wrong-label-wrap-in-popover' into 'main'
popover: Correctly substract arrow height when measuring popover widget
See merge request GNOME/gtk!4880
Benjamin Otte [Sat, 16 Jul 2022 21:37:15 +0000 (21:37 +0000)]
Merge branch 'dnd' into 'main'
DnD Fix Preferred Action for X11
Closes #4259
See merge request GNOME/gtk!4785
Corey Berla [Sat, 16 Jul 2022 20:34:07 +0000 (13:34 -0700)]
gdkdrop-x11: Use the preferred action if possible
The XDND suggested action is a relic from when the source would control
the action for a drop. With the new GtkDropTarget the target decides
the action (not the source). That means the all of the returned
results from the ::enter and ::motion handlers will be unexpectely
ignored. Prefer to use the preferred action over the x11 suggested action.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/4259
Corey Berla [Sat, 16 Jul 2022 20:01:31 +0000 (13:01 -0700)]
gdkdrop-x11: Fix preferred action
gdk_x11_drop_update_actions() sets actions to
drop_x11->suggested_action when !drop_x11->xdnd_have_actions
and then sets it again to drop_x11->suggested_action if it is.
If xdnd_have_actions is true use xdnd_actions.
Yubao Liu [Sat, 16 Jul 2022 16:12:39 +0000 (00:12 +0800)]
popover: Correctly substract arrow height when measuring popover widget
For default popover arrow position and default height-for-width layout mode,
natural_width is calculated first with for_size=-1 and orientation=HORIZONTAL,
at the end of gtk_popover_measure() natural_width won't be added with tail_height.
Then to measure with for_size=natural_width and orientation=VERTICAL, obviously
for_size shouldn't be substract with tail_height.
The wrong logic will force content in popover gets less width and then text labels
in popover may get wrapped unnecessarily.
Benjamin Otte [Sat, 16 Jul 2022 16:06:57 +0000 (16:06 +0000)]
Merge branch 'content-fit-reftests' into 'main'
reftests: Add content-fit picture tests
See merge request GNOME/gtk!4879
Marco Melorio [Sat, 16 Jul 2022 14:47:17 +0000 (16:47 +0200)]
reftests: Add content-fit picture tests
Matthias Clasen [Sat, 16 Jul 2022 14:08:37 +0000 (14:08 +0000)]
Merge branch 'test-coverage' into 'main'
gtk-demo: Fix icon theme breakage
See merge request GNOME/gtk!4878
Matthias Clasen [Sat, 16 Jul 2022 13:34:01 +0000 (09:34 -0400)]
gtk-demo: Make the icon work uninstalled
Include the app logo as a resource, so we can show
it even when uninstalled.
Matthias Clasen [Sat, 16 Jul 2022 12:16:37 +0000 (08:16 -0400)]
gtk-demo: Add a winning sound to the puzzle
We should celebrate every win.
Matthias Clasen [Sat, 16 Jul 2022 11:23:55 +0000 (07:23 -0400)]
gtk-demo: Fix icon theme breakage
The starred emblem silently went away :(
Matthias Clasen [Sat, 16 Jul 2022 03:08:28 +0000 (23:08 -0400)]
gdk: Improve test coverage
Matthias Clasen [Sat, 16 Jul 2022 03:07:59 +0000 (23:07 -0400)]
png loader: gray can have alpha
Matthias Clasen [Sat, 16 Jul 2022 03:03:28 +0000 (23:03 -0400)]
gdk: Drop an unused function
Matthias Clasen [Sat, 16 Jul 2022 02:49:42 +0000 (22:49 -0400)]
gdk: Improve test coverage
Benjamin Otte [Sat, 16 Jul 2022 00:24:31 +0000 (00:24 +0000)]
Merge branch 'content-fit-followup' into 'main'
GtkContentFit followups
See merge request GNOME/gtk!4877
Marco Melorio [Fri, 15 Jul 2022 23:37:10 +0000 (01:37 +0200)]
picture: Move variable definition at the top
Marco Melorio [Fri, 15 Jul 2022 23:31:19 +0000 (01:31 +0200)]
picture: Set overflow to be hidden
The new content-fit property was wrongly suggesting to manually set
widgets' overflow property, but that property is not really intended to
be set by external code. This commit removes those suggestions and
directly set picture's overflow to be hidden.
Marco Melorio [Fri, 15 Jul 2022 23:18:07 +0000 (01:18 +0200)]
picture: Fix replacement for deprecated methods
Matthias Clasen [Fri, 15 Jul 2022 23:00:16 +0000 (23:00 +0000)]
Merge branch 'text-placeholder-visibility' into 'main'
text: Update placeholder visibility more
See merge request GNOME/gtk!4875
Matthias Clasen [Fri, 15 Jul 2022 22:34:02 +0000 (22:34 +0000)]
Merge branch 'test-coverage' into 'main'
node-editor: Make the help more helpful
See merge request GNOME/gtk!4874
Matthias Clasen [Fri, 15 Jul 2022 22:28:42 +0000 (22:28 +0000)]
Merge branch 'gtk-content-fit' into 'main'
picture: Add content-fit property
Closes #5027
See merge request GNOME/gtk!4873
Matthias Clasen [Fri, 15 Jul 2022 22:21:23 +0000 (22:21 +0000)]
Merge branch 'nick.richards-main-patch-67353' into 'main'
Improve style in GtkInscription documentation
See merge request GNOME/gtk!4876
Marco Melorio [Fri, 15 Jul 2022 16:18:26 +0000 (18:18 +0200)]
picture: Add content-fit property
It allows to specify the resize mode of the paintable inside the
GtkPicture allocation. This also deprecates the keep-aspect-ratio
property.
Fixes #5027.
nick richards [Fri, 15 Jul 2022 20:55:37 +0000 (20:55 +0000)]
Improve style in GtkInscription documentation
Matthias Clasen [Fri, 15 Jul 2022 20:44:54 +0000 (16:44 -0400)]
text: Update placeholder visibility more
When the text in the buffer changes, we should
update the placeholder visibility, since we might
have gone from empty to non-empty.
Matthias Clasen [Fri, 15 Jul 2022 13:42:45 +0000 (09:42 -0400)]
gsk: Improve test coverage
Matthias Clasen [Fri, 15 Jul 2022 18:40:55 +0000 (14:40 -0400)]
glshader: Add preconditions
Add preconditions to many of the glshader
uniform apis.
Matthias Clasen [Fri, 15 Jul 2022 14:24:41 +0000 (10:24 -0400)]
Drop an unused function
Matthias Clasen [Fri, 15 Jul 2022 12:36:35 +0000 (08:36 -0400)]
node-editor: Sort help better
Move the gshader section where it belongs.
Matthias Clasen [Fri, 15 Jul 2022 11:42:35 +0000 (07:42 -0400)]
node-editor: Make the help more helpful
I struggled to remember how newlines vs strings work in
this format, so put it in the docs.
Matthias Clasen [Fri, 15 Jul 2022 11:15:07 +0000 (07:15 -0400)]
rendernodeparser: Cosmetics
Matthias Clasen [Fri, 15 Jul 2022 03:32:00 +0000 (23:32 -0400)]
Add some tests for GtkNoSelection
Matthias Clasen [Fri, 15 Jul 2022 02:51:13 +0000 (22:51 -0400)]
Add some tests for the listlistmodel
Matthias Clasen [Thu, 14 Jul 2022 23:51:26 +0000 (19:51 -0400)]
maplistmodel: Fix an oversight
This was meant to go into
678eb8ab76bd.
Matthias Clasen [Thu, 14 Jul 2022 23:48:27 +0000 (23:48 +0000)]
Merge branch 'fix-maplistmodel' into 'main'
maplistmodel: Fix items-changed emission
See merge request GNOME/gtk!4872
Matthias Clasen [Thu, 14 Jul 2022 20:52:30 +0000 (16:52 -0400)]
Add more maplistmodel tests
Add some tests for adding and removing items.
Matthias Clasen [Thu, 14 Jul 2022 20:50:22 +0000 (16:50 -0400)]
maplistmodel: Fix items-changed emission
We were modifying the removed value before passing
it to the items-changed signal, so we always ended
up with removed == 0 in our signal emission, instead
of passing the original value on, as we should.
Pointed out in !4870
Matthias Clasen [Thu, 14 Jul 2022 20:46:37 +0000 (20:46 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
pango_font_description_to_css: Handle numeric weight
See merge request GNOME/gtk!4871
Matthias Clasen [Thu, 14 Jul 2022 13:46:05 +0000 (09:46 -0400)]
pango_font_description_to_css: Handle numeric weight
The PangoWeight enum agrees with the numeric values
we use here, so we can do this without a switch and
support numeric weight values at the same time.
Matthias Clasen [Thu, 14 Jul 2022 11:43:04 +0000 (11:43 +0000)]
Merge branch 'add-back-pango-css' into 'main'
pango_font_description_to_css: Add extra-expanded
See merge request GNOME/gtk!4869
Maximiliano Sandoval R [Thu, 14 Jul 2022 10:55:16 +0000 (12:55 +0200)]
pango_font_description_to_css: Add extra-expanded
Matthias Clasen [Wed, 13 Jul 2022 23:44:53 +0000 (23:44 +0000)]
Merge branch 'coreyberla-main-patch-84997' into 'main'
ci: Remove print-backends build option
See merge request GNOME/gtk!4866
Matthias Clasen [Wed, 13 Jul 2022 21:11:58 +0000 (21:11 +0000)]
Merge branch 'ebassi/childless-stack-page' into 'main'
stack: Assert that StackPage:child is set
See merge request GNOME/gtk!4201
Corey Berla [Wed, 13 Jul 2022 14:21:12 +0000 (14:21 +0000)]
ci: Remove print-backends build option
Flatpak CI is failing because of unknown option "print-backends".
print-backends was renamed to print in
c4d350c260879c11ea94641ac820b331aeaccc7c
and subsequently was removed in
a4aa6d79addfcc5f6b61a9aecd2b3a647e249622
(replaced by print-cups and print-cloudprint as auto options)
Matthias Clasen [Fri, 27 May 2022 21:24:58 +0000 (17:24 -0400)]
testsuite: Fix up a few test for GtkStackPage changes
GtkStackPage objects can no longer be freely created.
Update our generic object tests to take that into
account.
Matthias Clasen [Fri, 27 May 2022 21:24:14 +0000 (17:24 -0400)]
GtkStack: Create stack pages with child
We're requiring stack pages to have a child
at construction time now. Make it so!
Emmanuele Bassi [Mon, 29 Nov 2021 16:57:21 +0000 (16:57 +0000)]
stack: Assert that StackPage:child is set
Childless GtkStackPage instances are not allowed, otherwise everything
falls apart in random places.
Kukuh Syafaat [Wed, 13 Jul 2022 12:58:18 +0000 (12:58 +0000)]
Update Indonesian translation
Matthias Clasen [Wed, 13 Jul 2022 11:20:57 +0000 (11:20 +0000)]
Merge branch 'check-button-s-ancestry' into 'main'
print: Check button is not descendant of toggle button
See merge request GNOME/gtk!4864
Matthias Clasen [Wed, 13 Jul 2022 11:17:07 +0000 (11:17 +0000)]
Merge branch 'empty_list_adjustment' into 'main'
listviews: Reset scrollbar adjustment when list is empty
Closes #4370
See merge request GNOME/gtk!4865