Carlos Garnacho [Mon, 26 Jun 2017 17:26:26 +0000 (19:26 +0200)]
gtkrange: Instaurate GTK+ grabs while manipulating ranges
It should not be necessary for most situations, except while there's
GDK grabs coercing events in a different way.
https://bugzilla.gnome.org/show_bug.cgi?id=782870
Carlos Garnacho [Mon, 26 Jun 2017 17:20:20 +0000 (19:20 +0200)]
gtkgesture: Do not ignore events from other GdkWindows than the widget's
There's GDK grab situations (eg. pointer motion outside the grab window
in combination with a GTK+ grab) where a gesture may receive events from
windows that are not the widget's.
The _update_widget_coordinates() still does work for those situations, so
just let these events go through instead of ignoring them.
https://bugzilla.gnome.org/show_bug.cgi?id=782870
Carlos Garnacho [Tue, 25 Jul 2017 14:18:07 +0000 (16:18 +0200)]
gtklabel: Fix touch link handling under wayland
Refactor the code updating the active link under the current coordinates
into a separate function, and call it on GtkGestureMultiPress::pressed
so the link is updated on GDK_TOUCH_BEGIN. Based on a patch by
Jan-Michael Brummer <jan.brummer@tabos.org>.
https://bugzilla.gnome.org/show_bug.cgi?id=776903
Carlos Garnacho [Tue, 25 Jul 2017 13:46:01 +0000 (15:46 +0200)]
gtklinkbutton: Set cursor on button's event window
Setting the cursor on the widget window (i.e. the parent widget's) is
finicky because the cursor needs to be updated on crossing events, and
will yield the wrong result for other master devices that happen to be
in other areas of the same parent widget's window.
Just set it always on the event window created by the GtkButton parent
class. That window was causing the crossing events, so the rectangle
that gets the hand cursor set will be the same size, and we don't need
to track pointer crossing state that way.
https://bugzilla.gnome.org/show_bug.cgi?id=785375
Carlos Garnacho [Tue, 25 Jul 2017 13:44:30 +0000 (15:44 +0200)]
wayland: Clear tablet tool cursor on proximity out
This ensures that the tablet tool will get the cursor updated even if it
happens to fall within the same window again on the next proximity in.
https://bugzilla.gnome.org/show_bug.cgi?id=785375
Carlos Garnacho [Tue, 25 Jul 2017 13:37:10 +0000 (15:37 +0200)]
gdkwindow: Update cursor for tablet tools in the window
This check must be done explicitly on Wayland as the master device for
tablet tools differ from the Core Pointer. This ensures that whenever a
tablet tool is inside a window and the cursor is programmatically changed,
it will be visually updated too.
https://bugzilla.gnome.org/show_bug.cgi?id=785375
Carlos Garnacho [Tue, 25 Jul 2017 13:35:41 +0000 (15:35 +0200)]
wayland: Observe GDK_SEAT_CAPABILITY_TABLET_STYLUS on gdk_seat_get_slaves()
This flag wasn't being honored so far...
Jason Gerecke [Mon, 12 Jun 2017 22:41:51 +0000 (15:41 -0700)]
wayland: Implement support for tablet wheel scrolling
Adds support for creating scroll events from Wayland tablet wheel events.
Even though no Wacom tablet puck has a smooth-scrolling wheel, both event
types need to be generated to make the upper layers happy.
https://bugzilla.gnome.org/show_bug.cgi?id=783716
Carlos Garnacho [Thu, 20 Jul 2017 11:26:00 +0000 (13:26 +0200)]
wayland: Make function to create scroll event more generic
Add GdkWaylandPointerData and GdkDevice arguments so it can be
used across master devices.
https://bugzilla.gnome.org/show_bug.cgi?id=783716
Jason Gerecke [Fri, 23 Jun 2017 18:17:53 +0000 (11:17 -0700)]
wayland: Get implicit grab serial information from tablet devices
If a tablet device is used to perform actions like window moving or resizing,
GTK must provide the correct implicit grab serial number over Wayland to Mutter
in order for the action to succeed. This commit adds tablet support to the
implicit serial getters.
https://bugzilla.gnome.org/show_bug.cgi?id=777333
Jonas Ådahl [Mon, 13 Mar 2017 06:42:38 +0000 (14:42 +0800)]
wayland: Throttle system bell requests
If a bad behaving application tries to make the window/display beep too
often, throttle the beep requests so that we don't end up filling the
Wayland socket queue.
The throttle is set to 50 beeps per second, which far more beeps than
will ever make any sense from a user experience point of view, but will
avoid terminating due to an excessive amount of requests.
https://bugzilla.gnome.org/show_bug.cgi?id=778188
Jonas Ådahl [Mon, 13 Mar 2017 06:33:06 +0000 (14:33 +0800)]
wayland: Make beep requests go through the GdkDisplay
This way we can add things like throttling.
https://bugzilla.gnome.org/show_bug.cgi?id=778188
Matthias Clasen [Wed, 19 Jul 2017 02:24:40 +0000 (22:24 -0400)]
3.22.17
Matthias Clasen [Wed, 19 Jul 2017 02:55:10 +0000 (22:55 -0400)]
update expected test results
Timm Bäder [Sat, 4 Feb 2017 09:49:43 +0000 (10:49 +0100)]
filechooserwidget: Let the rename entry hexpand
This makes a difference with other locals where error messages are
longer than the standard width of entry+spacing+button.
Iñaki García Etxebarria [Sat, 29 Apr 2017 11:08:49 +0000 (13:08 +0200)]
Add nullable return annotation to gtk_text_mark_get_name
https://bugzilla.gnome.org/show_bug.cgi?id=781936
Iñaki García Etxebarria [Sat, 29 Apr 2017 11:08:26 +0000 (13:08 +0200)]
Add nullable return annotation to gtk_notebook_get_tab_label
https://bugzilla.gnome.org/show_bug.cgi?id=781935
Cody Russell [Tue, 18 Jul 2017 18:54:11 +0000 (14:54 -0400)]
Update API for El Capitan+
Use NSAnimationContext where possible.
Cody Russell [Sun, 9 Jul 2017 19:04:00 +0000 (19:04 +0000)]
os x: Add new versions
Daniel Aleksandersen [Fri, 14 Jul 2017 01:19:47 +0000 (03:19 +0200)]
Update the URLs of known licenses to HTTPS
Use HTTPS by default for security/privacy. Avoids slow redirects.
https://bugzilla.gnome.org/show_bug.cgi?id=766517
Arun Raghavan [Thu, 13 Jul 2017 05:55:11 +0000 (11:25 +0530)]
gtkapplication: Mark gtk_application_get_active_window() as nullable
https://bugzilla.gnome.org/show_bug.cgi?id=784888
John Ralls [Tue, 18 Jul 2017 18:15:12 +0000 (11:15 -0700)]
Copy gtk_clipboard_get_default implementation to gtkclipboard-quartz.c
Fixes bug 784323.
Piotr Drąg [Tue, 18 Jul 2017 17:43:09 +0000 (19:43 +0200)]
Update POTFILES.in
Tom Schoonjans [Thu, 13 Jul 2017 19:07:22 +0000 (20:07 +0100)]
GtkFileChooserNativeWin32: add support for get_filter and set_filter
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Thu, 13 Jul 2017 19:03:55 +0000 (20:03 +0100)]
testgtk.c: native file chooser filter changes
Set the filter before showing the dialog
Afterwards, fetch the last active filter and display its name.
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Thu, 13 Jul 2017 19:01:38 +0000 (20:01 +0100)]
GtkFileChooserNativeQuartz: add support for get_filter and set_filter
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Sun, 9 Jul 2017 17:04:06 +0000 (18:04 +0100)]
GtkFileChooserNative: documentation updated
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Sun, 9 Jul 2017 16:06:12 +0000 (17:06 +0100)]
GtkFileChooserNativeQuartz: add support for filters
Includes:
* Simple glob patterns (*.ext, *.*,...)
* MIME types
* pixbuf formats
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Tue, 4 Jul 2017 07:07:09 +0000 (08:07 +0100)]
GtkFileChooserNativeQuartz: add partial support for extra widget
When the extra widget is a GtkLabel, then its text will be displayed as
a message in the NSSavePanel or NSOpenPanel
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Mon, 3 Jul 2017 11:54:39 +0000 (12:54 +0100)]
GtkFileChooserNativeQuartz: add support for GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER
Which is via NSOpenPanel, not NSSavePanel...
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Tom Schoonjans [Fri, 30 Jun 2017 20:34:05 +0000 (21:34 +0100)]
GtkFilechooserNative: add macOS support
Based on the Win32 implementation, as well as the macOS file chooser
from
https://github.com/GNOME/gedit/blob/master/gedit/gedit-file-chooser-dialog-osx.[ch]
Not fully tested yet, but working properly so far.
TODO: filter support, extra widget (label), documentation...
https://bugzilla.gnome.org/show_bug.cgi?id=784723
Fabio Tomat [Sat, 15 Jul 2017 18:28:20 +0000 (20:28 +0200)]
Add Friulian translation
Bastien Nocera [Wed, 5 Jul 2017 21:01:26 +0000 (23:01 +0200)]
image: Fix loading of pixdata GResources
Pixdata is deprecated but some software already use GtkImage widgets
with image data loaded from GResource-backed pixdata. As the
security-problem ridden pixdata loader was removed, we need to manually
check whether the GResource data is pixdata, and load it manually.
https://bugzilla.gnome.org/show_bug.cgi?id=781583
Matthias Clasen [Sun, 2 Jul 2017 00:14:15 +0000 (20:14 -0400)]
Avoid a race in the print portal
Same as the previous commit; use the new predictable request
object path to connect to the Response signal early.
Matthias Clasen [Sat, 1 Jul 2017 23:13:03 +0000 (19:13 -0400)]
Avoid a race in the file chooser portal
Use the new predictable request object path and connect
to the Response signal before issuing the portal call.
This avoids a race that is pretty unlikely to hit in
the filechooser case.
Daniel Boles [Fri, 7 Jul 2017 07:13:41 +0000 (08:13 +0100)]
label: Remove extra quote in code example
Daniel Boles [Thu, 6 Jul 2017 12:59:53 +0000 (13:59 +0100)]
GdkRGBA: Fix typo precentage => percentage
Jason Gerecke [Tue, 27 Jun 2017 21:21:05 +0000 (14:21 -0700)]
x11: Assign GDK_SOURCE_TABLET_PAD when necessary
Wacom tablets often have a "pad" device which houses multiple buttons. At
present, these devices are incorrectly marked as GDK_SOURCE_PEN which can
cause problems for some software.
https://bugzilla.gnome.org/show_bug.cgi?id=782040
Daniel Boles [Thu, 22 Jun 2017 19:49:02 +0000 (20:49 +0100)]
migrating-StyleContext: CSS does support bindings
so remove the bit in the migration guide that says it doesn’t.
Daniel Boles [Thu, 22 Jun 2017 19:40:06 +0000 (20:40 +0100)]
css-overview: Fix typo “{with=>which} is disabled”
Baurzhan Muftakhidinov [Thu, 22 Jun 2017 14:28:19 +0000 (14:28 +0000)]
Update Kazakh translation
Mart Raudsepp [Thu, 22 Jun 2017 02:35:36 +0000 (05:35 +0300)]
GdkWaylandWindow: Fix version numbers in export_handle() docs
This change appeared first in 3.22.16 release, not 3.22.13.
https://bugzilla.gnome.org/show_bug.cgi?id=782325
Matthias Clasen [Tue, 20 Jun 2017 15:34:17 +0000 (11:34 -0400)]
3.22.16
Matthias Clasen [Tue, 20 Jun 2017 16:09:55 +0000 (12:09 -0400)]
Update a11y tests
Expected output of a11y tests has changed.
Marek Cernocky [Tue, 20 Jun 2017 12:32:46 +0000 (14:32 +0200)]
Updated Czech translation
Daniel Mustieles [Mon, 19 Jun 2017 15:35:54 +0000 (17:35 +0200)]
Updated Spanish translation
Carlos Garnacho [Fri, 16 Jun 2017 16:21:34 +0000 (18:21 +0200)]
gdk: Set vid/pid on wayland tablets
This was missed so far... Use %.4x format, in order to behave just
the same than X11.
Will Thompson [Thu, 15 Jun 2017 14:53:18 +0000 (15:53 +0100)]
headerbar: fix "widow" typo in docs
Kjartan Maraas [Wed, 14 Jun 2017 05:45:40 +0000 (07:45 +0200)]
Updated Norwegian bokmål translation
Debarshi Ray [Tue, 13 Jun 2017 09:06:50 +0000 (11:06 +0200)]
GtkActionHelper: Remove unnecessary NULL check
This NULL check has existed since commit
652f16dd985dbc1b, when
GtkActionHelper was first introduced, but so has the assertion at the
top to ensure the validity of 'widget'.
https://bugzilla.gnome.org/show_bug.cgi?id=783587
Debarshi Ray [Fri, 9 Jun 2017 10:15:53 +0000 (12:15 +0200)]
GtkActionHelper: Allow a NULL action-name to unset the previous GAction
https://bugzilla.gnome.org/show_bug.cgi?id=783587
Matthias Clasen [Tue, 13 Jun 2017 17:09:56 +0000 (13:09 -0400)]
file chooser: Don't pass NULL as title to the portal
This causes critical warnings.
Felipe Borges [Thu, 18 May 2017 14:11:56 +0000 (16:11 +0200)]
printunixdialog: Update collate icon as entry changes
By relying on GtkSpinButton default activation behavior, the
collate icon doesn't get updated when a new number is typed
in the copies spin button.
https://bugzilla.gnome.org/show_bug.cgi?id=759308
Nelson Benítez León [Sun, 4 Jun 2017 06:20:19 +0000 (11:20 +0500)]
gtktextdisplay: remove unused code
In render_para() function, which is called for every text line that
needs to be drawn.
https://bugzilla.gnome.org/show_bug.cgi?id=783397
Matthias Clasen [Sat, 3 Jun 2017 02:28:27 +0000 (22:28 -0400)]
dist icon.list
Otherwise things will not work in a release tarball.
Matthias Clasen [Fri, 2 Jun 2017 21:42:04 +0000 (14:42 -0700)]
icon-browser: Add a few icons
These have appeared recently.
Matthias Clasen [Fri, 2 Jun 2017 20:57:58 +0000 (13:57 -0700)]
icon browser: Make icons a bit larger
Use 48x48 in the list, instead of 32x32. We have the space.
Matthias Clasen [Fri, 2 Jun 2017 19:39:39 +0000 (12:39 -0700)]
icon browser: Add a 'copy to clipboard' button
This makes it more obvious how to use the icon.
Matthias Clasen [Fri, 2 Jun 2017 01:52:50 +0000 (18:52 -0700)]
icon browser: put icons as data
Instead of hardcoding all the add_icon calls,
read the icon list from a keyfile, for easier
extensibility.
Daniel Boles [Fri, 24 Feb 2017 22:46:05 +0000 (22:46 +0000)]
testsuite/scrolledwindow: Try non-overlay/non-auto
It was only testing the default configuration, where overlay scrolling
is on and both scrollbars use POLICY_AUTOMATIC. We should also test the
other 3 configurations that are available by including non-overlay
scrollbars and/or those that use POLICY_ALWAYS.
https://bugzilla.gnome.org/show_bug.cgi?id=778853
Daniel Boles [Fri, 24 Feb 2017 22:46:05 +0000 (22:46 +0000)]
ScrolledWindow: Don’t req size for autohidden bars
POLICY_AUTOMATIC means scrollbars are only shown when needed, i.e. when
the size of the window is not large enough to show the entire child. So
when measuring the preferred size, such scrollbars should be ignored.
But measure() added size for *any* non-overlay scrollbar of the opposite
orientation, e.g. for horizontal size, it added the width of vscrollbar.
So we requested for child + bar, & having enough for child meant that the
policy hid the bar, leaving extra space empty below/right of the child.
Fix this by only adding size for such bars if they use POLICY_ALWAYS.
https://bugzilla.gnome.org/show_bug.cgi?id=778853
Timm Bäder [Wed, 10 May 2017 08:55:50 +0000 (10:55 +0200)]
scrolledwindow: Avoid critical when removing source
Make sure indicator->conceil_timer is actually set before trying to
remove it.
Dan Torop [Thu, 13 Apr 2017 14:37:22 +0000 (10:37 -0400)]
wayland: selectively cancel key repeat on key release
Under Wayland, when multiple keys are pressed and the user releases a
key, key repeat should continue unless the key released is the one
currently repeating.
In the case of:
- key1 press
- key1 repeat
- key2 press -> key1 repeat stopped
- key2 repeat
- key2 release
The behavior should be to cancel keyboard repeat, though key1 is still
held down. This is consistent with prior X11/XWayland behavior.
The following also must work:
- key1 press
- key2 press
- key2 release
- key2 press
- key1 release
- key2 should continue to repeat
The fix for bug #778019 should continue to work:
- key1 press
- key1 repeat
- key2 press -> key1 repeat stopped
- key1 release
- key2 should repeat
The choice to change the counter nkeys to the flag repeat_active
helps to solve the second test case.
https://bugzilla.gnome.org/show_bug.cgi?id=781285
Olivier Fourdan [Fri, 2 Jun 2017 13:54:50 +0000 (15:54 +0200)]
wayland: fix xdg_surface test in move/resize drag
begin_resize_drag() and begin_move_drag() check for xdg_surface being
not null, but those apply on xdg_toplevel so they should check for
xdg_toplevel being non-null instead.
https://bugzilla.gnome.org/show_bug.cgi?id=781945
Olivier Fourdan [Tue, 16 May 2017 14:13:34 +0000 (16:13 +0200)]
wayland: check parent surface for subsurface
When an event is received while a tooltip is showing, the GtkTooltip's
event handling code can end up calling gdk_window_set_transient_for()
from gtk_tooltip_set_last_window().
The Wayland GDK backend will try to automatically create a subsurface
in gdk_wayland_window_set_transient_for() but if the parent surface is
gone meanwhile, this will will cause a crash when trying to create a
subsurface from a parent with a null surface.
Checking for the parent is not sufficient, we ought to check for the
parent surface as well to avoid the crash.
https://bugzilla.gnome.org/show_bug.cgi?id=782283
Olivier Fourdan [Tue, 2 May 2017 09:41:26 +0000 (11:41 +0200)]
wayland: Do not map toplevel utility as popup
Applications can specify the type hint as utility even on toplevel
windows.
When that toplevel is also marked as a transient for another window,
GDK Wayland backend would translate that as an xdg_popup which is not
appropriate.
While utility temp windows should remain mapped as subsurfaces (such as
the ones used by treeviews), regular windows should not translate as
neither a subsurface nor an xdg_popup.
https://bugzilla.gnome.org/show_bug.cgi?id=781945
Christoph Reiter [Fri, 2 Jun 2017 10:55:23 +0000 (12:55 +0200)]
gtkfilechoosernativewin32: Fix support for non-ASCII paths
The code used SIGDN_URL to get an URL for the selected item, but Windows URLs
are a mix of unicode and percent encoded characters in the locale encoding
and not something GFile can understand. The result is a garbage file
path.
Instead use SIGDN_FILESYSPATH to get a real file path if available.
Also checks the return value of g_utf16_to_utf8 because file paths on
Windows can contain lone surrogates which would make the conversion fail.
https://bugzilla.gnome.org/show_bug.cgi?id=783347
Matthias Clasen [Fri, 26 May 2017 01:57:24 +0000 (21:57 -0400)]
Redo the listbox dnd example
Rewrite this example to have better drag highlighting.
Daniel Boles [Wed, 31 May 2017 18:08:28 +0000 (19:08 +0100)]
Adwaita: Add missing rule for fullscreen headerbar
Another selector forces round corners for headerbars in a stack, and it
has higher priority than the selector covering the non-stack case from
commit
712a8adbd9a11fcebce0269562e9a028a17fa862. Totem’s MainToolbar
happens to be in a stack, and we should maintain symmetry here anyway.
So, as window classes .maximized and .tiled are excluded from this other
selector, the newly handled .fullscreen case must be excluded here also.
https://bugzilla.gnome.org/show_bug.cgi?id=770513
Daniel Boles [Wed, 31 May 2017 17:45:59 +0000 (18:45 +0100)]
HighContrast: Regenerate CSS files with sassc
Daniel Boles [Wed, 31 May 2017 17:45:24 +0000 (18:45 +0100)]
HighContrast: Update parse-sass.sh; remove Gemfile
Make parse-sass.sh use sassc instead of the old Ruby method.
Daniel Boles [Wed, 31 May 2017 17:45:04 +0000 (18:45 +0100)]
Adwaita: Remove unused Gemfile
Daniel Boles [Wed, 31 May 2017 07:16:46 +0000 (08:16 +0100)]
themes: Square corners on fullscreen win headerbar
Totem uses a fullscreen window with a headerbar at the top, and without
this change, that headerbar has rounded corners, which look different
from a maximised window and let video content show through beneath.
https://bugzilla.gnome.org/show_bug.cgi?id=770513
Aurimas Černius [Tue, 30 May 2017 19:32:23 +0000 (22:32 +0300)]
Updated Lithuanian translation
Debarshi Ray [Wed, 24 May 2017 14:42:01 +0000 (16:42 +0200)]
wayland: Don't warn if the display is lost, skip exit handlers
There is no need to have every application log a warning when the
Wayland display server goes away, and we are using _exit instead of
exit elsewhere.
This is also what the X11 backend does (see gdk_x_io_error).
https://bugzilla.gnome.org/show_bug.cgi?id=745289
Марко Костић [Sat, 27 May 2017 22:41:26 +0000 (22:41 +0000)]
Update Serbian translation
Debarshi Ray [Wed, 24 May 2017 14:08:07 +0000 (16:08 +0200)]
wayland: Don't abort when preparing the source if connection is lost
Aborting the application makes it look like an application bug, when
it is the expected thing to do when the Wayland display server goes
way. eg., when the user logs out. The log level is also demoted to
avoid a storm of warnings in the log from all applications whenever
this happens.
This is also what the X11 backend does (see gdk_x_io_error).
https://bugzilla.gnome.org/show_bug.cgi?id=783047
Emmanuele Bassi [Tue, 23 May 2017 04:12:41 +0000 (05:12 +0100)]
textview: Make GTK_TEXT_WINDOW_PRIVATE public
The GTK_TEXT_WINDOW_PRIVATE enumeration value is really *not* private.
Internally, it's used as a simple "invalid value" marker, and
application and library developers are supposed to use it as such in
their own code.
Let's just document it, and since the GtkTextView documentation and
internals go a long way to state the fact that it should not be used as
an argument value, let's add some pre-condition checks as well.
This commit fixes GtkSourceView's use of GTK_TEXT_WINDOW_PRIVATE as
default value for a GObject property that was broken by the change in
glib-mkenums to honor the `/*< public >*/` and `/*< private >*/`
trigraphs.
Jonas Ådahl [Mon, 8 May 2017 12:51:43 +0000 (20:51 +0800)]
tests: Add testforeign
Add a test for exporting a handle. There are no GTK+ API for this, but
only per backend GDK API, and so far only Wayland is supported. There
is a private GdkWindow API but it's not exposed externally.
https://bugzilla.gnome.org/show_bug.cgi?id=782325
Jonas Ådahl [Mon, 8 May 2017 10:35:50 +0000 (18:35 +0800)]
GdkWaylandWindow: Allow calling export() multiple time
Allow getting the same export handle multiple times by calling
gdk_wayland_window_export_handle() multiple times. For each time
export() is called, a unexport() must be called to unexport.
When the window is already exported, the exported callback is called
via a idle handler. If there are multiple export() calls, they are
invoked in order either when the handle is received by the display
server, or when the idle callback is invoked.
Calling unexport() will not affect future invokations of the exported
callback, unless all export() calls have their unexport() call count
matched.
https://bugzilla.gnome.org/show_bug.cgi?id=782325
Olof-Joachim Frahm [Sun, 26 Feb 2017 15:02:49 +0000 (16:02 +0100)]
Move style change for popover creation.
Creating with `gtk_popover_new_from_model` should be exactly the same as
if via `gtk_popover_new` plus `gtk_popover_bind_model`.
Also remove the style if the model is unbound at any point.
Timm Bäder [Tue, 2 May 2017 18:54:57 +0000 (20:54 +0200)]
widget: Remove useless assignment
We don't use adjusted_allocation after this line.
Timm Bäder [Sat, 24 Sep 2016 07:36:32 +0000 (09:36 +0200)]
examples/drawing: Don't call gtk_main_quit
This is a GtkApplication so it will do the right thing when closing the
window.
Timm Bäder [Sun, 21 Aug 2016 13:43:29 +0000 (15:43 +0200)]
fallback-c89: Include config.h
It holds all the HAVE_<func> definitions.
Timm Bäder [Sun, 30 Apr 2017 18:21:39 +0000 (20:21 +0200)]
widget: remove double assignment
We never read the value we assign here.
Timm Bäder [Sun, 30 Apr 2017 18:20:58 +0000 (20:20 +0200)]
placesview: Remove duplicate GtkMountOperation assignment
we assign a new mount operation a few lines later again.
Timm Bäder [Sun, 30 Apr 2017 18:19:56 +0000 (20:19 +0200)]
levelbar: Don't allocate 0 blocks
Could result in a division by zero later on and doesn't make a lot of
sense anyway.
Timm Bäder [Fri, 28 Apr 2017 09:25:21 +0000 (11:25 +0200)]
grid: Remove unnecessary NULL checks
The minimum and natural pointers passed to measure are never NULL and
that's the only place where we call gtk_grid_get_size_for_size.
Timm Bäder [Thu, 27 Apr 2017 15:54:49 +0000 (17:54 +0200)]
GtkGestureMultiPress: Remove superfluous NULL check
The rect parameter in gtk_gesture_multi_press_set_area is annotated as
nullable and the code handles the rect==NULL case, but the
g_return_if_fail kept that case from ever happening.
Timm Bäder [Thu, 27 Apr 2017 15:52:46 +0000 (17:52 +0200)]
label: Remove dead ternary operator
Timm Bäder [Wed, 26 Apr 2017 11:43:30 +0000 (13:43 +0200)]
filechooserwidget: Remove always-false error case
_gtk_search_engine_new never returns NULL, it always returns a valid
GObject with at least the simple search engine initialized.
Timm Bäder [Wed, 26 Apr 2017 09:37:58 +0000 (11:37 +0200)]
sidebarrow: Remove useless size group
Nice try, but size groups don't work with invisible widgets anyway.
Invisible widgets request 0×0.
Timm Bäder [Tue, 25 Apr 2017 13:43:10 +0000 (15:43 +0200)]
label: Remove useless if statements
We never pass nullable pointers into get_size_for_allocation.
Olivier Fourdan [Wed, 3 May 2017 12:29:18 +0000 (14:29 +0200)]
gtkwindow: Hide CSD title bar when undecorated
When switching from decorated to undecorated, the title bar should be
hidden as well.
https://bugzilla.gnome.org/show_bug.cgi?id=782117
Robert Ancell [Sat, 20 May 2017 01:07:05 +0000 (13:07 +1200)]
docs: Fix copy-paste error in gtk_file_chooser_get_extra_widget() doc comment
Lapo Calamandrei [Wed, 17 May 2017 16:09:59 +0000 (18:09 +0200)]
Adwaita: Avoid accindental border on last treeview header
The :last-child selector supposed to reset the border was
overridden by the :hover selector. This is fixed by moving the
:last-child selector after the overriding one.
Thanks to Sebastian Keller for spotting.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=779078.
Lapo Calamandrei [Wed, 17 May 2017 16:06:39 +0000 (18:06 +0200)]
Adwaita: regenerate the css with sassc
Lapo Calamandrei [Wed, 17 May 2017 16:05:13 +0000 (18:05 +0200)]
Adwaita: modify parse-sass.sh script to use sassc
Robert Ancell [Mon, 15 May 2017 05:03:36 +0000 (17:03 +1200)]
EntryBuffer: Don't generate changed events when input is truncated
Daniel Boles [Sat, 13 May 2017 20:55:28 +0000 (21:55 +0100)]
widget-factory: Use :relief=none, not class .flat
The rest of the ui file follows that convention.