Corey Berla [Mon, 15 May 2023 20:09:52 +0000 (13:09 -0700)]
filechooserwidget: Stop leaking file system models
FeRD (Frank Dana) [Sun, 14 May 2023 21:01:38 +0000 (17:01 -0400)]
doc/actions: Fix end-of-file :
The actions document ended with a : where there used to be a period,
seemingly a bug in the conversion from XML. Replace that : with a
period, and remove another spurious : inserted during the conversion.
FeRD (Frank Dana) [Sun, 14 May 2023 20:23:41 +0000 (16:23 -0400)]
docs/input: <kbd>␣</kbd> => <kbd>Space</kbd>
- Switch to semantic newlines, where adding <kbd> caused wrapped text
to grow wider than 80 characters on some lines.
FeRD (Frank Dana) [Sun, 14 May 2023 20:20:33 +0000 (16:20 -0400)]
docs/input-handling: A few more <kbd> wrappings
- Format a few missed keypresses/combos using <kbd>
- Switch to semantic newlines for those (paragraphs, bullet points)
FeRD (Frank Dana) [Sun, 14 May 2023 09:18:48 +0000 (09:18 +0000)]
docs/input-handling: Don't leave reader hanging
Strangely, the document's last sentence ended with a colon,
giving the impression there's missing text that should follow.
There is not.
Even more strange, it's _always_ ended with a colon,
ever since the file was converted from XML
(in commit
10cd539104af54f5d1d1e49618f5aa9d8ac42074).
BUT, the XML file it was converted _from_ ended that same sentence
with a period! I have no idea where the colon came from.
Matthias Clasen [Sun, 14 May 2023 00:11:56 +0000 (20:11 -0400)]
Add a README to examples/hello
Just so nobody wonders why there's a meson.build
in this subdirectory.
Daniel Boles [Sat, 13 May 2023 17:17:17 +0000 (18:17 +0100)]
Widget: Fix doubled word need, missing possessives
Matthias Clasen [Sat, 13 May 2023 11:35:05 +0000 (07:35 -0400)]
popover: Stop making assumptions about corners
The popover tail drawing code was just assuming that
the corner values are numbers. Which they won't, anymore.
Matthias Clasen [Fri, 12 May 2023 22:11:14 +0000 (18:11 -0400)]
css: Fix initial rotate transform value
Matthias Clasen [Fri, 12 May 2023 18:48:45 +0000 (14:48 -0400)]
css: Make some corner values static
Provide static value for uniform corners
with lengths from 0 to 8px. This covers
the majority of corners in widget-factory.
Matthias Clasen [Fri, 12 May 2023 18:47:36 +0000 (14:47 -0400)]
css: More static length values
Make all length values from 0px to 8px available
as static values. This will help with cutting
down on the number of corner values (we have a
lot of 5px corners).
Matthias Clasen [Fri, 12 May 2023 18:04:59 +0000 (14:04 -0400)]
Revert "csscornervalue: Accept other values if x == y"
This reverts commit
1f2f2777e1231468f613a2936989ded060f4e2a6.
It broke transitioning of corner values.
Matthias Clasen [Fri, 12 May 2023 17:13:12 +0000 (13:13 -0400)]
css: Correct initial shadow filter values
This was using numbers instead of lengths,
causing confusion in the transition code.
Matthias Clasen [Fri, 12 May 2023 13:13:00 +0000 (09:13 -0400)]
css: Fix transition of font features
If we store ints as values, we better use
g_hash_table_lookup_extended, or zeros will
show up as missing values.
Maximiliano Sandoval R [Fri, 12 May 2023 09:35:14 +0000 (11:35 +0200)]
mediacontrols: Set valign=center on volume button
To match the play button.
Daniel Boles [Fri, 12 May 2023 09:30:37 +0000 (10:30 +0100)]
Overlay: Add minimal doc blurb for property :child
Matthias Clasen [Thu, 11 May 2023 22:33:23 +0000 (18:33 -0400)]
urilauncher: Validate the uri
We don't want to send nonsense to the portal.
Fixes: #5829
Matthias Clasen [Wed, 10 May 2023 01:21:39 +0000 (21:21 -0400)]
tests: Stop copying the tool tests
No point in doing that, and the meson feature
we are using here is deprecated.
Aurimas Černius [Sun, 4 Jun 2023 20:32:14 +0000 (20:32 +0000)]
Update Lithuanian translation
Matthias Clasen [Tue, 30 May 2023 10:24:10 +0000 (10:24 +0000)]
Merge branch 'backport_gtkstack_crash' into 'gtk-4-10'
Backport the fix from #6031
See merge request GNOME/gtk!6036
Lukáš Tyrychtr [Mon, 29 May 2023 13:14:51 +0000 (15:14 +0200)]
GtkStack: Fix a potential crash in gtk_stack_get_first_accessible_child
This one can occur when the stack has no pages.
Matthias Clasen [Mon, 29 May 2023 00:14:36 +0000 (00:14 +0000)]
Merge branch 'cherry-pick-
099955b0' into 'gtk-4-10'
cherry-picking "gridview: Add border-spacing where it was missed"
See merge request GNOME/gtk!6029
Benjamin Otte [Tue, 16 May 2023 16:08:21 +0000 (18:08 +0200)]
gridview: Add border-spacing where it was missed
We were computing column widths without taking border-spacing into
account, making them slightly too big.
(cherry picked from commit
099955b0c06dbddc9469bd3c8e63673a3a82883f)
Asier Sarasua Garmendia [Thu, 18 May 2023 16:30:55 +0000 (16:30 +0000)]
Update Basque translation
Jordi Mas [Fri, 12 May 2023 17:42:11 +0000 (19:42 +0200)]
Update Catalan translation
Guillaume Bernard [Fri, 12 May 2023 13:13:03 +0000 (13:13 +0000)]
Update French translation
Matthias Clasen [Fri, 5 May 2023 03:52:53 +0000 (03:52 +0000)]
Merge branch 'cherry-pick-
29e71868' into 'gtk-4-10'
treelistmodel: Be safer during collapsing
See merge request GNOME/gtk!5918
Benjamin Otte [Wed, 26 Apr 2023 22:06:40 +0000 (22:06 +0000)]
Merge branch 'wip/otte/treelistmodel-madness' into 'main'
treelistmodel: Be safer during collapsing
See merge request GNOME/gtk!5875
(cherry picked from commit
29e71868298448eb7fa570ed0a75935c235262de)
8766a6fa treelistmodel: Be safer during collapsing
3c76f3fb treelistmodel: Delay notifies from TreeListRow
Matthias Clasen [Thu, 4 May 2023 19:22:13 +0000 (19:22 +0000)]
Merge branch 'wip/carlosg/invalidate-surface-x11-4-10' into 'gtk-4-10'
gdk/x11: Invalidate whole surface after size change (4.10)
See merge request GNOME/gtk!5916
Carlos Garnacho [Fri, 21 Apr 2023 08:58:19 +0000 (10:58 +0200)]
gdk/x11: Invalidate whole surface after size change
The Expose events following a ConfigureNotify may arrive at
a time that we did not resize the surface yet, making these
expose events a no-op. Even though gsk/gtk take care of the
window content itself, this might lead to unrendered portions
of the window shadow.
This may be seen with GSK_RENDERER=cairo and GDK_BACKEND=x11,
attempting to tile a window (e.g. gtk4-demo) left or right.
The window will show black rectangles or other artifacts in
the window shadow areas that correspond to the newly painted
portions (as the window needs to expand vertically).
In order to fix this with a similar behavior to Wayland,
consider ourselves the whole surface invalidated after resize,
in order to ensure everything is painted from scratch.
(cherry-picked from commit
24302315fb8f46be141a9eda60e8d107c84a948d)
Danial Behzadi [Wed, 3 May 2023 09:00:53 +0000 (09:00 +0000)]
Update Persian translation
Matthias Clasen [Tue, 2 May 2023 22:21:09 +0000 (22:21 +0000)]
Merge branch 'backport-css-fix-to-gtk-4-10' into 'gtk-4-10'
Backport "css: Don't transition to currentColor" to gtk-4-10
See merge request GNOME/gtk!5911
Benjamin Otte [Tue, 2 May 2023 17:48:54 +0000 (19:48 +0200)]
css: Don't transition to currentColor
Transition to the color that is in use instead.
Fixes crashes because currentColor is not an RGBA color and
therefor could not be queried later.
Fixes #5798
Boyuan Yang [Fri, 28 Apr 2023 18:46:49 +0000 (18:46 +0000)]
Update Chinese (China) translation
Kukuh Syafaat [Fri, 28 Apr 2023 05:33:27 +0000 (05:33 +0000)]
Update Indonesian translation
Matthias Clasen [Thu, 27 Apr 2023 08:57:59 +0000 (08:57 +0000)]
Merge branch 'cherry-pick-
c5a53f23' into 'gtk-4-10'
Merge branch 'wip/otte/trelistmodel-fixage' into 'main'
See merge request GNOME/gtk!5873
Matthias Clasen [Wed, 29 Mar 2023 02:23:46 +0000 (02:23 +0000)]
Merge branch 'wip/otte/trelistmodel-fixage' into 'main'
treelistmodel: Don't add items in reverse
Closes #5707
See merge request GNOME/gtk!5744
(cherry picked from commit
c5a53f235a2ed1b0acd0a8c29153e62377262d04)
1718db14 treelistmodel: Don't add items in reverse
cd860beb Add a test for splicing treelistmodel
Fran Dieguez [Tue, 25 Apr 2023 23:22:20 +0000 (23:22 +0000)]
Update Galician translation
Sabri Ünal [Sun, 23 Apr 2023 21:12:30 +0000 (21:12 +0000)]
Update Turkish translation
Anders Jonsson [Sun, 23 Apr 2023 09:58:47 +0000 (09:58 +0000)]
Update Swedish translation
Yuri Chornoivan [Sat, 22 Apr 2023 18:19:13 +0000 (18:19 +0000)]
Update Ukrainian translation
Aleksandr Melman [Sat, 22 Apr 2023 12:20:35 +0000 (12:20 +0000)]
Update Russian translation
Matthias Clasen [Sat, 22 Apr 2023 10:38:20 +0000 (12:38 +0200)]
Post-release version bump
Matthias Clasen [Sat, 22 Apr 2023 10:28:21 +0000 (12:28 +0200)]
4.10.3
Matthias Clasen [Sat, 22 Apr 2023 10:19:35 +0000 (10:19 +0000)]
Merge branch 'cherry-pick-
0ce6bc67' into 'gtk-4-10'
filesystemmodel: Emit items-changed when modifying attributes
See merge request GNOME/gtk!5860
Piotr Drąg [Sat, 22 Apr 2023 09:16:08 +0000 (11:16 +0200)]
Update Polish translation
Martin [Sat, 22 Apr 2023 07:35:34 +0000 (07:35 +0000)]
Update Slovenian translation
Matthias Clasen [Sat, 22 Apr 2023 06:59:59 +0000 (06:59 +0000)]
Merge branch 'fix-popover-positioning-4-10' into 'gtk-4-10'
popover: Fix positioning
See merge request GNOME/gtk!5859
Olivier Crête [Sat, 22 Apr 2023 05:54:57 +0000 (05:54 +0000)]
filesystemmodel: Emit items-changed when modifying attributes
(cherry picked from commit
0ce6bc677e339b2af213377773e184674cb45c87)
Matthias Clasen [Sat, 22 Apr 2023 06:33:07 +0000 (08:33 +0200)]
popover: Fix positioning
Hugo Carvalho [Fri, 21 Apr 2023 14:30:47 +0000 (14:30 +0000)]
Update Portuguese translation
Matthias Clasen [Fri, 21 Apr 2023 14:22:28 +0000 (16:22 +0200)]
Post-release version bump
Matthias Clasen [Fri, 21 Apr 2023 09:31:06 +0000 (11:31 +0200)]
4.10.2
Matthias Clasen [Fri, 21 Apr 2023 14:00:02 +0000 (16:00 +0200)]
Move some nonworking reftests to xfail
A few of the inscription reftests have been failing since 4.10.1.
Move them to xfail until somebody shows up to fix them.
Ekaterine Papava [Fri, 21 Apr 2023 13:53:46 +0000 (13:53 +0000)]
Update Georgian translation
Matthias Clasen [Fri, 21 Apr 2023 07:58:08 +0000 (07:58 +0000)]
Merge branch 'backports-for-4-10' into 'gtk-4-10'
Accumulated backports for 4.10
This branch has my cherry-picks from main since we branched after 4.10.1.
Two inscription reftests are failing, but they were also failing before.
See merge request GNOME/gtk!5856
Marc-André Lureau [Sun, 16 Apr 2023 17:23:49 +0000 (21:23 +0400)]
gdk/win32: drop some unused variables
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Marc-André Lureau [Sat, 15 Apr 2023 10:33:20 +0000 (14:33 +0400)]
gdk: drop libangle GLES minimum version
GLES 2.0 version is fine now with current gtk according to B. Otte.
Let's use the same minimum requirement for all implementations.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Marc-André Lureau [Thu, 13 Apr 2023 15:22:21 +0000 (19:22 +0400)]
gdk: use GLES when on win32/ANGLE
When using GDK_DEBUG=gl-egl, we end up using GL, but that is not well supported:
Creating EGL context version 3.0 (debug:no, forward:no, legacy:yes, es:no)
Created EGL context[
0000000000000004]
OpenGL version: 0.0 (legacy)
* GLSL version: (NULL)
* Max texture size: -
1059701680
* Extensions checked:
- GL_KHR_debug: no
- GL_EXT_unpack_subimage: yes
- OES_vertex_half_float: no
** (gtk4-demo.exe:14324): WARNING **: 19:16:41.468: Compile failure in
vertex shader:
ERROR: 0:7: 'gl_Position' : undeclared identifier
---8<---
Use GLES when EGL implementation is ANGLE.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Marc-André Lureau [Sat, 15 Apr 2023 10:35:04 +0000 (14:35 +0400)]
gdk: drop unused vertex_array_object
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Benjamin Otte [Mon, 17 Apr 2023 03:41:34 +0000 (05:41 +0200)]
glrenderer: Don't try to use float framebuffers on GLES2
GLES doesn't know what that is.
Matthias Clasen [Sun, 16 Apr 2023 18:58:26 +0000 (20:58 +0200)]
testsuite: Skip focus tests when necessary
If our window does not get focus, we can't reliably
test things that depend on widgets being focused.
Matthias Clasen [Sun, 16 Apr 2023 18:07:13 +0000 (20:07 +0200)]
Try harder to fix focus tests
The focus test now asserts that its window is active.
So we should not run them in parallel with other tests,
since those might steal the focus.
Benjamin Otte [Sun, 16 Apr 2023 14:57:48 +0000 (16:57 +0200)]
testsuite: Fix broken test to not unref surfaces twice
The test doesn't hold 2 references, it holds only one.
The reason one unref can cause a leak is that some backends - like X11 -
only destroy the surface once the DestroyNotify event from the X server
has come in.
Benjamin Otte [Fri, 21 Apr 2023 07:26:23 +0000 (09:26 +0200)]
wayland: Don't leak all surfaces
X11 does add an extra reference to surfaces that gets released when the
DestroyNotify event arrives.
Wayland doesn't ave such an event, so that reference never gets
released.
This fixes a copy/paste error introduced in commit
590f3dfa1fcb.
Benjamin Otte [Sun, 16 Apr 2023 02:36:12 +0000 (04:36 +0200)]
wayland: Don't insta-crash when a surface gets disposed
We want to remove the event queue from the list of event queues, not the
surface.
Otherwise the freed queue stays in the list and the next time an event
comes in, we access invalid memory.
Fixes thinko introduced in commit
7fafa5133b5.
Luckily, we leak all surfaces, so this problem never occured.
Matthias Clasen [Sun, 16 Apr 2023 07:11:24 +0000 (09:11 +0200)]
testsuite: Actually wait for focus
We were failing to properly iterate the main
context here. Oops.
Matthias Clasen [Sun, 16 Apr 2023 06:50:35 +0000 (08:50 +0200)]
tests: Check is-focus instead of has-focus
We are not presenting windows here.
Matthias Clasen [Sun, 16 Apr 2023 06:49:20 +0000 (08:49 +0200)]
text: Fix fallout from focus changes
We don't get proper notification for when the toplevel
is-active property changes, so monitor has-focus, and
update cursor blinking.
Cam Cook [Sun, 16 Apr 2023 01:48:27 +0000 (21:48 -0400)]
| method | current | suggestion |
|---------------------------------------------------------------------------------------|-----------------------------------------------------------------|----------------------------------------------------------------------|
| [get_attributes](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtklabel.c#L3242) | "use`pango_layout_get_attribute (gtk_label_get_layout (self))`" | "use`pango_layout_get_attributes (gtk_label_get_layout (self))`" [1] |
| [set_yalign](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtklabel.c#L5897) | "(attributes org.gtk.Method.get_property=yalign)" | "(attributes org.gtk.Method.set_property=yalign)" |
| [get_yalign](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtklabel.c#L5923) | "(attributes org.gtk.Method.set_property=yalign)" | "(attributes org.gtk.Method.get_property=yalign)" |
| [set_ellipsize](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtklabel.c#L3892) | "to ellipsizei" | "to ellipsize" |
| [get_attributes](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtklabel.c#L3239) | "from the labels markup" | "from the label's markup" |
[1] https://docs.gtk.org/Pango/method.Layout.get_attributes.html
Cam Cook [Sat, 15 Apr 2023 16:41:13 +0000 (12:41 -0400)]
| method | current | suggestion |
|-------------------------------------------------------------------------------------------------|------------------------------------------------------------|-----------------------------------------------------------|
| [Entry/set_invisible_char](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkentry.c#L2101) | "(attributes org.gtk.Method.sets_property=invisible-char)" | "(attributes org.gtk.Method.set_property=invisible-char)" |
| [FlowBox::activate](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkflowbox.c#L541) | "This can be happen either by" | "This can happen either by" |
Benjamin Otte [Sat, 15 Apr 2023 15:50:18 +0000 (17:50 +0200)]
gles: Don't use vertex array objects
They're not needed and GLES doesn't technically support them, even
though GTK had been using them via epoxy sneakily using the
GL_OES_vertex_array_object extension behind our back.
Matthias Clasen [Sat, 15 Apr 2023 13:02:09 +0000 (15:02 +0200)]
text: Only claim primary when focused
It does not make sense otherwise, and has unfortunate
side-effects on Wayland.
Matthias Clasen [Sat, 15 Apr 2023 13:00:53 +0000 (15:00 +0200)]
wayland: Improve logging for primary selection
Matthias Clasen [Sat, 15 Apr 2023 12:58:57 +0000 (14:58 +0200)]
window: Don't mark widget prematurely as has-focus
has-focus is defined is-focus && toplevel::is-active.
We were forgetting to look at is_active when handling
focus widget changes.
Marco Trevisan (Treviño) [Fri, 14 Apr 2023 16:05:21 +0000 (18:05 +0200)]
gtk: Improve documentation on returned nodes for snapshot
Closes: #5747
Matthias Clasen [Thu, 13 Apr 2023 05:23:06 +0000 (07:23 +0200)]
openuriportal: Detect if the interface isn't there
Check the portal version number before trying to use
it. Most importantly, this will detect the case where
the interface isn't supported at all, since the proxy
will report a version of 0 in that case.
Fixes: #5733
Alexander Mikhaylenko [Wed, 12 Apr 2023 17:05:23 +0000 (21:05 +0400)]
printunixdialog: Remove a redundant style class
.view does absolutely nothing in Default style since the whole box is
covered with a GtkNotebook which has its own background, and adds an
unwanted background onto the tab strip in Adwaita.
Marco Trevisan (Treviño) [Tue, 11 Apr 2023 22:41:20 +0000 (00:41 +0200)]
gtk/dialogs: Destroy the window promptly on finish async function
Some bindings (GJS!) could add temporary references to the GAsyncResult
argument that we return, and thus to the GTask, which may cause the
dialog not to close when the finish function is called (but at garbage
collection instead!).
To prevent this, just manually destroy the window (by removing the task
data), so that we are not bound to the GTask lifetime anymore.
Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5741
Matthias Clasen [Wed, 12 Apr 2023 10:08:14 +0000 (12:08 +0200)]
filechooserentry: Plug a memory leak
Matthias Clasen [Wed, 12 Apr 2023 10:07:30 +0000 (12:07 +0200)]
filechooserentry: Make filtering work again
We need to look at the filchooser::filtered-out
attribute to know which files the filesystem model
has filtered away.
Fixes: #5743
Carlos Garnacho [Wed, 12 Apr 2023 09:24:46 +0000 (11:24 +0200)]
textview: Reset press counter if double/triple clicking on a different line
If we click close enough between lines, and with the maximum distances applied
by GtkGestureClick we could jump between lines when handling double/triple
click for word/line selection.
Ensure that the whole operation stays in the same line and reset the
gesture/counter if we do move between lines, so we start from scratch in the
new line.
G.Willems [Tue, 11 Apr 2023 21:53:35 +0000 (23:53 +0200)]
scalebutton: fix orientation not applied to scale
G.Willems [Tue, 11 Apr 2023 20:06:09 +0000 (22:06 +0200)]
scalebutton: fix CSS name in documentation
Matthias Clasen [Mon, 10 Apr 2023 04:22:20 +0000 (00:22 -0400)]
scrolledwindow: Avoid a critical
When setting the child property to NULL, we also need
to unset auto_added_viewport, to avoid triggering a
critical when setting it again.
Matthias Clasen [Sun, 9 Apr 2023 11:32:25 +0000 (07:32 -0400)]
gtk-demo: Add a keyword
Make the demo using the 'bluroverlay' come up when you type 'blur'.
Matthias Clasen [Sun, 9 Apr 2023 12:33:15 +0000 (08:33 -0400)]
gesture stylus: Fix condition
Now that the paint demo lets us test this, it has
become apparent that this condition is wrong, and
we don't get the expected events if stylus-only is
FALSE.
Matthias Clasen [Sun, 9 Apr 2023 12:28:26 +0000 (08:28 -0400)]
gtk-demo: Work without stylus
In the paint demo, don't assume that the event
backlog contains pressure. It won't, if we are
working with a plain old mouse.
Matthias Clasen [Sun, 9 Apr 2023 12:13:46 +0000 (08:13 -0400)]
gtk-demo: Test stylus-only mode
Add a checkbutton to toggle the stylus-only
mode of GtkGestureStylus, so we can test this.
Matthias Clasen [Sat, 8 Apr 2023 23:50:16 +0000 (19:50 -0400)]
range: Fix a copy-paste error
This was showing up as the alpha popup in
the color editor not being positioned correctly.
Matthias Clasen [Fri, 7 Apr 2023 21:44:27 +0000 (17:44 -0400)]
gestureclick: Use drag threshold for updates
Matthias Clasen [Thu, 6 Apr 2023 19:31:03 +0000 (15:31 -0400)]
gestureclick: Don't use threshold for touch
When determining double-clicks, don't use the distance
threshold for touch events. It is very hard to double
touch reliably within a few pixels of the same position.
Fixes: #5580
Carlos Garnacho [Fri, 7 Apr 2023 19:42:10 +0000 (21:42 +0200)]
gtkpopover: Move GTK grabs to map/unmap
Typically, a popover gets mapped when shown and unmapped when
hidden. A situation there that breaks is where the popover gets
recursively unmapped/unrealized when its root is destroyed.
In that situation, the popover does however unmap (without being
hidden first), moving the GTK grab from show/hide to map/unmap
will handle the previous situations, plus this one.
Fixes things being unclickable if e.g. a modal dialog got a
popover popped up, then got closed via Alt-F4.
Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5730
Matthias Clasen [Fri, 7 Apr 2023 17:14:51 +0000 (13:14 -0400)]
inspector: Redo the actions list
Make the actions list implement GtkActionObserver
for the muxer case, and make updates work.
Matthias Clasen [Fri, 7 Apr 2023 16:58:10 +0000 (12:58 -0400)]
inspector: Simplify the action editor
No need to listen for changes, the actions list
code will do so and tell us to update.
Matthias Clasen [Fri, 7 Apr 2023 17:14:07 +0000 (13:14 -0400)]
inspector: Add ActionHolder::changed
We will use this signal to communicate
action changes to the action list widgetry.
Matthias Clasen [Fri, 7 Apr 2023 17:15:34 +0000 (13:15 -0400)]
inspector: Cosmetics
Make the variant editor use a checkbutton
instead of a togglebutton.
Matthias Clasen [Fri, 7 Apr 2023 16:53:57 +0000 (12:53 -0400)]
actionmuxer: Add a precondition
This helps with debugging the inspectors action
handling.
Matthias Clasen [Fri, 7 Apr 2023 13:16:21 +0000 (09:16 -0400)]
inspector: Be more careful
Tweak the variant-editor code to handle some
cases more explicitly.
Matthias Clasen [Fri, 7 Apr 2023 12:55:40 +0000 (08:55 -0400)]
inspector: Plug a memory leak