Nextcloud bot [Fri, 22 Nov 2024 13:36:55 +0000 (13:36 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 11:01:27 +0000 (12:01 +0100)]
prepare for release 3.15.0
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 11:00:01 +0000 (12:00 +0100)]
Merge pull request #7490 from nextcloud/bugfix/win-locale-lang
Fix half-translated GUI strings on Windows
Matthieu Gallien [Fri, 22 Nov 2024 09:05:32 +0000 (10:05 +0100)]
we require Qt 6.7 release to build
we use new API from Qt6.7
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 09:04:52 +0000 (10:04 +0100)]
use CI images including Qt6.7 that is now required
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 13:24:24 +0000 (14:24 +0100)]
add include QLocale to fix compilation issue
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Sun, 17 Nov 2024 15:10:49 +0000 (23:10 +0800)]
Use first uiLanguage as lang
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Nov 2024 07:40:25 +0000 (16:40 +0900)]
Only grab system language from QLocale::system
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 4 Nov 2024 07:17:20 +0000 (16:17 +0900)]
Remove unneeded workaround for dash separated language strings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 10:14:29 +0000 (11:14 +0100)]
Merge pull request #7327 from nextcloud/bugfix/virtualFilesMoreReliable
Bugfix/virtual files more reliable
Matthieu Gallien [Wed, 16 Oct 2024 07:01:56 +0000 (09:01 +0200)]
prevent out of bounds access in automated tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 16 Oct 2024 07:01:12 +0000 (09:01 +0200)]
revert changes to the stale virtual files clean up function
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 10:13:38 +0000 (11:13 +0100)]
Merge pull request #7455 from cmuck/cm-fix-login-regression-on-linux
Fix login regression on linux
cmuck [Thu, 21 Nov 2024 13:50:22 +0000 (14:50 +0100)]
Fix login regression on linux
Signed-off-by: cmuck <cmuckmuck@gmail.com>
cmuck [Mon, 4 Nov 2024 12:50:06 +0000 (13:50 +0100)]
Fix login regression on linux
Signed-off-by: cmuck <cmuckmuck@gmail.com>
Matthieu Gallien [Fri, 22 Nov 2024 10:02:37 +0000 (11:02 +0100)]
Merge pull request #7436 from nextcloud/bugfix/accounts2
Fix adding account and skipping folder configuration crash.
Camila Ayres [Thu, 14 Nov 2024 18:39:56 +0000 (19:39 +0100)]
Correct Q_PROPERTY for _davDisplayName.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Thu, 14 Nov 2024 18:11:54 +0000 (19:11 +0100)]
Fix tests: make sure displayName is not empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Wed, 6 Nov 2024 16:13:28 +0000 (17:13 +0100)]
Remove check before setting display name.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Mon, 4 Nov 2024 20:11:40 +0000 (21:11 +0100)]
Call for done() when skipping folder configuration.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Mon, 4 Nov 2024 19:15:43 +0000 (20:15 +0100)]
wiz => owncloudSetupWizard.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Mon, 4 Nov 2024 18:17:15 +0000 (19:17 +0100)]
acc => account.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Mon, 4 Nov 2024 18:08:03 +0000 (19:08 +0100)]
Add {} to single line if.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Thu, 31 Oct 2024 17:18:25 +0000 (18:18 +0100)]
Use saveAccount for adding single account.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Thu, 31 Oct 2024 15:28:32 +0000 (16:28 +0100)]
Rename vars: _am => _networkAccessManager, a => newAccountData.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Tue, 29 Oct 2024 20:51:46 +0000 (21:51 +0100)]
Diferentiate between display name and dav display name.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Tue, 29 Oct 2024 19:12:20 +0000 (20:12 +0100)]
Use slots as slots.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Tue, 29 Oct 2024 17:45:03 +0000 (18:45 +0100)]
Modernize Account::displayName().
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Tue, 29 Oct 2024 17:36:40 +0000 (18:36 +0100)]
Fix warning "Calling C++ methods with 'this' objects different from the one they were retrieved from is broken"
https://doc.qt.io/qt-6/qtqml-documents-structure.html#nativemethodbehavior
Signed-off-by: Camila Ayres <hello@camilasan.com>
Camila Ayres [Tue, 29 Oct 2024 17:00:52 +0000 (18:00 +0100)]
Use slotComputeOverallSyncStatus as a slot.
- Use qAsConst.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Matthieu Gallien [Fri, 22 Nov 2024 09:08:41 +0000 (10:08 +0100)]
Merge pull request #7464 from nextcloud/bugfix/debug-archive-aio
Bundle macOS File Provider module logs into main debug archive
Claudio Cambra [Wed, 20 Nov 2024 02:27:37 +0000 (10:27 +0800)]
Move file provider header include into file provider ifdef
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Nov 2024 17:07:56 +0000 (02:07 +0900)]
Just use davUser as account identifier for macOS log filename
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 6 Nov 2024 17:07:28 +0000 (02:07 +0900)]
Move debug archive for vfs creation out of log entry creation
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 5 Nov 2024 08:40:47 +0000 (17:40 +0900)]
Ensure we are not halting the entire application when trying to generate the debug archive for macOS vfs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 29 Oct 2024 04:02:50 +0000 (12:02 +0800)]
Remove create debug archive button from individual vfs account settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 29 Oct 2024 04:02:28 +0000 (12:02 +0800)]
Directly bundle macOS vfs logs within standard debug archive
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 09:06:19 +0000 (10:06 +0100)]
Merge pull request #7477 from nextcloud/bugfix/readOnlyVirtualFilesFixes
Improve read only virtual files support on Windows
Matthieu Gallien [Tue, 5 Nov 2024 22:09:00 +0000 (23:09 +0100)]
ensure lnk shortcut files are converted to virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 7 Nov 2024 15:47:45 +0000 (16:47 +0100)]
remote permissions of a view-only folder: no new file or folder
change the way we evaluate a folder permissions to be read-only when no
new file or new folders can be created
if those permissions are lacking, client will make the local folder
read-only
if those permissions are granted, client will make local folder
read-write
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Nov 2024 16:45:20 +0000 (17:45 +0100)]
improve logs for CfAPI handle requests in erroneous cases
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Nov 2024 16:43:10 +0000 (17:43 +0100)]
never use QFileInfo on possibly pure virtual placeholder file
will prevent some type of activity being added to the list from
triggering implicit hydration during synchronization
most probably breaks existing open actions on those activities
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Nov 2024 16:39:28 +0000 (17:39 +0100)]
prevent implicit hydration when setting file permissions on shortcuts
we were using specialized API to set the file permissions on the windows
shortcut and later falling back to the generic code path due to the
mising return
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Nov 2024 16:38:04 +0000 (17:38 +0100)]
provide proper log when we block a self hydration request
should make the existing log more useful when tracking the
self requested implicit hydration bugs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Nov 2024 16:32:53 +0000 (17:32 +0100)]
fix migration of existing windows shortcut files to placeholder
we cannot do a single call to convert the plain old file to be a
dehydrated virtual file placeholder
split the conversion into a separate initial API call
fix transition from releases < 3.14 to current releases that have first
class support for windows shortcuts (so called link files)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Nov 2024 15:29:53 +0000 (16:29 +0100)]
use proper item type when converting existing windows shortcuts
we need to make shortcut files be proper virtual placeholder files
let the sync engine use the proper item type for that
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 30 Oct 2024 17:48:53 +0000 (18:48 +0100)]
fix computation of availability for empty folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 30 Oct 2024 15:37:42 +0000 (16:37 +0100)]
do not move to trash online only files/folders: going to fail
ensure that even if move to trash is enabled, we do not erroneously try
to move online only files or folders to trash bin
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 08:46:26 +0000 (09:46 +0100)]
Merge pull request #7373 from nextcloud/feature/display-sharedwithme-info
Show received share information in share view
Claudio Cambra [Wed, 20 Nov 2024 06:09:40 +0000 (14:09 +0800)]
Ensure avatarJob is run on the respective account's QNAM thread
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 20 Nov 2024 05:23:54 +0000 (13:23 +0800)]
Match definition of shared_with_me with other properties in OcsShareJob getShares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 20 Nov 2024 05:23:36 +0000 (13:23 +0800)]
Clean up whitespace in ShareModel::slotPropfindReceived
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Oct 2024 03:11:10 +0000 (11:11 +0800)]
Ensure account pointer is valid when fetching avatars
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 21 Oct 2024 03:10:58 +0000 (11:10 +0800)]
Ensure requestedSize for avatars is valid
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 17:49:09 +0000 (01:49 +0800)]
Display image for sharedWithMe share owner in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 17:48:44 +0000 (01:48 +0800)]
Build shareOwnerAvatar image provider string when handling sharedWithMe share in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 17:48:17 +0000 (01:48 +0800)]
Add shareOwnerAvatar property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 17:46:56 +0000 (01:46 +0800)]
Add ability to fetch remote server avatars in usermodel avatar ImageResponse
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 17:46:27 +0000 (01:46 +0800)]
Convert ImageProvider in an async image provider using an internal image response
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:48:47 +0000 (17:48 +0800)]
Bolden string showing who owns the share that was shared with me
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:48:32 +0000 (17:48 +0800)]
Display share owner rather than file owner (this is more relevant to user)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:37:09 +0000 (17:37 +0800)]
Display shared with me file's share expiry in share view if relevant
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:36:52 +0000 (17:36 +0800)]
Display file owner information (if not self) in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:36:20 +0000 (17:36 +0800)]
When handling fetched shares, record shared-with-me related information in sharemodel properties
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:35:42 +0000 (17:35 +0800)]
Also fetch shared with me share on target path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:33:14 +0000 (17:33 +0800)]
Add sharedWithMe-related properties to sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:30:30 +0000 (17:30 +0800)]
Set if the file owner should be displayed and the file owner display name on propfind in sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:29:15 +0000 (17:29 +0800)]
Add fileOwnerDisplayName property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 20 Oct 2024 09:28:13 +0000 (17:28 +0800)]
Add displayFileOwner property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Fri, 22 Nov 2024 08:14:52 +0000 (09:14 +0100)]
Merge pull request #7547 from nextcloud/bugfix/general-settings-ui-fix
Fix broken general settings UI file
Claudio Cambra [Thu, 21 Nov 2024 17:45:50 +0000 (01:45 +0800)]
Rename horizontalLayout with duplicate name
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 17:45:37 +0000 (01:45 +0800)]
Fix broken general setting UI file
Looks like it was originally caused at some point by a bad rebase
conflict resolution
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 22 Nov 2024 02:52:48 +0000 (02:52 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 18:43:19 +0000 (02:43 +0800)]
Merge pull request #7548 from nextcloud/bugfix/mac-crafter-woes-pt-100000
Only sign main executable at end (mac-crafter)
Claudio Cambra [Thu, 21 Nov 2024 18:30:04 +0000 (02:30 +0800)]
Skip main executable during first binary codesign round
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 18:29:49 +0000 (02:29 +0800)]
Add ability to skip certain files in recursive codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 16:58:12 +0000 (00:58 +0800)]
Merge pull request #7545 from nextcloud/bugfix/final-final-mc-fix-pls
Fix mac-crafter codesign executable check path building
Claudio Cambra [Thu, 21 Nov 2024 16:36:25 +0000 (00:36 +0800)]
Ensure we sign the app bundle's main executable last
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 16:36:12 +0000 (00:36 +0800)]
Only define enumeratedItemPath once
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 15:09:13 +0000 (23:09 +0800)]
Ensure path passed to codesigning is absolute when using mac-crafter codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 15:08:38 +0000 (23:08 +0800)]
Do not take current dir pth for filemanager for recursive codesign executable path check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:32:18 +0000 (12:32 +0100)]
Merge pull request #7540 from nextcloud/ci/fixWindowsAutomatedTests
remove this call that is probably useless and crashing tests
Matthieu Gallien [Thu, 21 Nov 2024 09:37:50 +0000 (10:37 +0100)]
remove this call that is probably useless and crashing tests
we initialize all colors in the palette, so this init methos is most
probably not doing anything useful
crashes when doing in automated tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:31:32 +0000 (12:31 +0100)]
Merge pull request #5433 from nextcloud/feature/disable-talk-notifications
Feature/disable talk chat notifications
Claudio Cambra [Mon, 18 Nov 2024 08:15:31 +0000 (16:15 +0800)]
Remove unneeded check for DnD status when showing desktop talk notification
The server will not deliver it anyway
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 26 Jun 2024 09:24:42 +0000 (17:24 +0800)]
Do not use const for POD type in setShowCallNotifications declaration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 13:15:18 +0000 (14:15 +0100)]
Only notify talk chat notifications if this is enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 12:56:20 +0000 (13:56 +0100)]
Add the chat notification toggle setting logic in generalsettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 12:47:52 +0000 (13:47 +0100)]
Add setting for showing chat notifications to configfile
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 13 Feb 2023 12:15:01 +0000 (13:15 +0100)]
Add checkbox to disable general talk notifications in general settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:07:07 +0000 (12:07 +0100)]
Merge pull request #7532 from nextcloud/bugfix/narrowDownPermissionsDuringSync
Bugfix/narrow down permissions during sync
Matthieu Gallien [Thu, 21 Nov 2024 10:52:04 +0000 (11:52 +0100)]
better logs and factor common code in folder permissions handling
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 20 Nov 2024 13:09:08 +0000 (14:09 +0100)]
ensure no any user writable permissions in Nextcloud sync folder
past versions may have wrongly set the write permissions for other users
(UNIX style permissions)
remove this under the hypothesis that newly created files or folders
gets more restrictive permissions and that past files or folders should
be updated to get the same permissions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 20 Nov 2024 11:03:37 +0000 (12:03 +0100)]
ensure folder permissions are read-only when needed
a folder item must be set read-only if files or sub-folders cannot be
created
a folder item must be set read-write in all other situations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:06:19 +0000 (12:06 +0100)]
Merge pull request #7495 from nextcloud/feature/smartFlushOfLogs
flush logs every 5 lines written
Matthieu Gallien [Wed, 13 Nov 2024 10:54:36 +0000 (11:54 +0100)]
flush logs every 5 lines written
should help not loosing too much logs in case of a crash or similar not
nominal stop of the client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 21 Nov 2024 11:04:58 +0000 (12:04 +0100)]
Merge pull request #7517 from nextcloud/feature/noDefaultShareLinks
Feature/no default share links
Matthieu Gallien [Tue, 19 Nov 2024 14:58:18 +0000 (15:58 +0100)]
improve files explorer context menu by removing obsolete commands
remove any commands related to publi share links because they either got
replaced by the use of the share dialog or are better achieved by
showing the share dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Thu, 21 Nov 2024 10:52:33 +0000 (18:52 +0800)]
Merge pull request #7541 from nextcloud/bugfix/final-mac-crafter-fix-istg
Fix mac-crafter codesign executable detection
Claudio Cambra [Thu, 21 Nov 2024 10:43:58 +0000 (18:43 +0800)]
Do not do final bundle codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>