Claudio Cambra [Thu, 10 Nov 2022 16:13:12 +0000 (17:13 +0100)]
Clearly tell user that E2EE has been enabled for an account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Fri, 25 Nov 2022 09:37:21 +0000 (10:37 +0100)]
Merge pull request #5206 from nextcloud/ci/doNotOverrideConfigurationFile
Ci/do not override configuration file
Matthieu Gallien [Thu, 24 Nov 2022 15:03:03 +0000 (16:03 +0100)]
fix include style to always use "" for files from the project
the use of #include <> is only for system headers and not headers from
the project
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 24 Nov 2022 15:02:02 +0000 (16:02 +0100)]
avoid modifying real configuration file: use temp folder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Fri, 25 Nov 2022 03:35:10 +0000 (03:35 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 24 Nov 2022 16:46:33 +0000 (17:46 +0100)]
Merge pull request #5189 from nextcloud/bugfix/custom-buttons-alignments
Fix bad custom button alignments, sizings, etc.
Claudio Cambra [Fri, 18 Nov 2022 17:18:02 +0000 (18:18 +0100)]
Fix bad custom button alignments, sizings, etc.
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Thu, 24 Nov 2022 15:31:58 +0000 (16:31 +0100)]
Merge pull request #5201 from nextcloud/ci/fixVfsRegressions
fix regressions on pinState management when doing renames
Matthieu Gallien [Wed, 23 Nov 2022 17:04:46 +0000 (18:04 +0100)]
fix regressions on pinState management when doing renames
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Thu, 24 Nov 2022 14:04:34 +0000 (15:04 +0100)]
Merge pull request #5202 from nextcloud/bugfix/tray-window-margins
Fix tray window margins, stop cutting into window border
Claudio Cambra [Thu, 24 Nov 2022 12:19:32 +0000 (13:19 +0100)]
Fix tray window margins, stop cutting into window border
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 24 Nov 2022 12:20:25 +0000 (13:20 +0100)]
Merge pull request #5199 from marv/cmake-pkg_get_variable
cmake: Use FindPkgConfig's pkg_get_variable instead of custom macro
Marvin Schmidt [Thu, 10 Nov 2022 19:36:03 +0000 (20:36 +0100)]
cmake: Use FindPkgConfig's pkg_get_variable instead of custom macro
Commit
b34a90183818 ("Use FindPkgConfig to find libcloudproviders and
related libs") introduced the usage of cmake's FindPkgConfig module
which provides `pkg_get_variable` since version 3.4 that can be used
instead of the custom `PKGCONFIG_GETVAR` macro
Signed-off-by: Marvin Schmidt <marv@exherbo.org>
Matthieu Gallien [Wed, 23 Nov 2022 16:34:14 +0000 (17:34 +0100)]
Merge pull request #5200 from nextcloud/ci/doNotModifyConfigurationFileDuringtests
Ci/do not modify configuration file duringtests
Matthieu Gallien [Wed, 23 Nov 2022 15:57:14 +0000 (16:57 +0100)]
fix code format
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 23 Nov 2022 15:56:35 +0000 (16:56 +0100)]
prevents modifying real user config file
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Wed, 23 Nov 2022 16:23:34 +0000 (17:23 +0100)]
Merge pull request #5192 from ivaradi/modernize-dolphin-plugin
Modernize the Dolphin action plugin
István Váradi [Sat, 19 Nov 2022 17:59:17 +0000 (18:59 +0100)]
Modernize the Dolphin action plugin
Instead of installing a .desktop file, it is now converted
to JSON and compiled into the plugin itself. The plugin is
also installed into a different directory.
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
Claudio Cambra [Wed, 23 Nov 2022 12:24:46 +0000 (13:24 +0100)]
Merge pull request #5124 from nextcloud/feature/end-to-end-tests
Add end-to-end tests to our CI
Claudio Cambra [Thu, 10 Nov 2022 13:05:55 +0000 (14:05 +0100)]
Always build E2E tests, but only add to test suite if enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 2 Nov 2022 16:24:20 +0000 (17:24 +0100)]
Add a file transfer e2e test
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Oct 2022 16:25:32 +0000 (18:25 +0200)]
Add a test to check e2e server test setup
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Oct 2022 12:45:00 +0000 (14:45 +0200)]
Add an end to end test utils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 16 Sep 2022 09:55:50 +0000 (11:55 +0200)]
Add server service to drone manifest
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Wed, 23 Nov 2022 03:34:07 +0000 (03:34 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 22 Nov 2022 17:24:11 +0000 (18:24 +0100)]
Merge pull request #5188 from nextcloud/bugfix/properlyUpdateMetadata
check that we update local file mtime on changes from server
Matthieu Gallien [Tue, 22 Nov 2022 14:44:43 +0000 (15:44 +0100)]
fix many errors when querying/setting pin state of virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 22 Nov 2022 11:18:58 +0000 (12:18 +0100)]
when renaming a virtual file, manage pin state for the target name
will avoid trying to set a pin state for a file that has just been
renamed by us
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 18 Nov 2022 14:32:44 +0000 (15:32 +0100)]
set mtime when building local sync folder state in automated tests
would allow checking mtime with a correct value instead of having a
default value
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 18 Nov 2022 14:32:07 +0000 (15:32 +0100)]
update mtime on modified metdata of non virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 18 Nov 2022 14:09:08 +0000 (15:09 +0100)]
check that we update local file mtime on changes from server
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Tue, 22 Nov 2022 12:34:38 +0000 (13:34 +0100)]
Merge pull request #5081 from nextcloud/feature/context-menu-leaveshare-entry
Implement context menu entry "Leave this share"
allexzander [Fri, 21 Oct 2022 14:11:29 +0000 (17:11 +0300)]
Implement 'Leave this share' context menu entry. Fix incorrect sharing state for incoming and my shares in custom state icons and local database.
Signed-off-by: allexzander <blackslayer4@gmail.com>
Nextcloud bot [Tue, 22 Nov 2022 03:35:58 +0000 (03:35 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 21 Nov 2022 03:26:42 +0000 (03:26 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 20 Nov 2022 03:28:08 +0000 (03:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 19 Nov 2022 03:33:48 +0000 (03:33 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Fri, 18 Nov 2022 17:16:30 +0000 (18:16 +0100)]
Merge pull request #5089 from nextcloud/ci/clazyRangeLoopDetach
fix instances of: c++11 range-loop might detach Qt container warnings
Matthieu Gallien [Tue, 15 Nov 2022 10:52:25 +0000 (11:52 +0100)]
tidy some loop related code: avoid one letter variable names
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 24 Oct 2022 15:53:40 +0000 (17:53 +0200)]
fix instances of: c++11 range-loop might detach Qt container warnings
analyzed via clazy
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 18 Nov 2022 10:43:02 +0000 (11:43 +0100)]
Merge pull request #5182 from nextcloud/bugfix/fixRenameDeepHierarchy
fix renaming of folders with a deep hierarchy inside them
Matthieu Gallien [Fri, 18 Nov 2022 08:19:03 +0000 (09:19 +0100)]
remove a few warnings reported by sonarcloud to tidy the code
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 18 Nov 2022 08:11:41 +0000 (09:11 +0100)]
tidy code to fix review comments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 17 Nov 2022 13:48:51 +0000 (14:48 +0100)]
tidy code by fixing one clazy reported warning
use QString::arg with multiple parameters because that is faster
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 17 Nov 2022 13:45:11 +0000 (14:45 +0100)]
fix behavior of folder rename with deep hierarchy inside it
propagate renaming of parent folders to child recursively
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 16 Nov 2022 17:00:15 +0000 (18:00 +0100)]
test for proper renaming of folder parent of a deep hierarchy
currently broken test as we miss to rename recursively
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 17 Nov 2022 08:42:47 +0000 (09:42 +0100)]
improve logging of discovery policy decisions when scanning folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 17 Nov 2022 08:28:01 +0000 (09:28 +0100)]
improve logging of the discovery policy when scanning a folder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Thu, 17 Nov 2022 03:28:03 +0000 (03:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 15 Nov 2022 17:33:08 +0000 (18:33 +0100)]
Merge pull request #5178 from nextcloud/ci/followUpstreamCraft
switch back to upstream craft
Matthieu Gallien [Tue, 15 Nov 2022 14:15:14 +0000 (15:15 +0100)]
no need to install python that is already installed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 15 Nov 2022 13:03:48 +0000 (14:03 +0100)]
switch back to upstream craft
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Tue, 15 Nov 2022 11:57:16 +0000 (12:57 +0100)]
Merge pull request #5152 from nextcloud/bugfix/sync-now-paused-folder
Ensure forcing a folder to be synced unpauses syncing on said folder
Claudio Cambra [Wed, 9 Nov 2022 15:43:08 +0000 (16:43 +0100)]
Ensure forcing a folder to be synced unpauses syncing on said folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 15 Nov 2022 10:52:12 +0000 (11:52 +0100)]
Merge pull request #5172 from nextcloud/bugfix/fix-activitylist-warnings
Fix ActivityList delegate warnings
Claudio Cambra [Mon, 14 Nov 2022 15:00:55 +0000 (16:00 +0100)]
Fix ActivityList delegate warnings·
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 15 Nov 2022 10:51:23 +0000 (11:51 +0100)]
Merge pull request #5173 from nextcloud/bugfix/nccustombutton-warnings
Remove reference to inexistent property in NCCustomButton
Claudio Cambra [Mon, 14 Nov 2022 15:13:10 +0000 (16:13 +0100)]
Remove reference to inexistent property in NCCustomButton
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 15 Nov 2022 10:02:00 +0000 (11:02 +0100)]
Merge pull request #5088 from nextcloud/ci/clazyNotFullyQualifiedTypes
fully qualify types in signals and slots
Matthieu Gallien [Mon, 24 Oct 2022 14:00:50 +0000 (16:00 +0200)]
fully qualify types in signals and slots
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Tue, 15 Nov 2022 03:26:34 +0000 (03:26 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 14 Nov 2022 10:47:30 +0000 (10:47 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 14 Nov 2022 08:43:46 +0000 (09:43 +0100)]
Merge pull request #5157 from nextcloud/hefee-patch-1
Fix typo of connector
hefee [Wed, 9 Nov 2022 20:15:44 +0000 (20:15 +0000)]
Fix typo of connector
Signed-off-by: hefee <hefee@debian.org>
Matthieu Gallien [Mon, 14 Nov 2022 08:42:59 +0000 (09:42 +0100)]
Merge pull request #5109 from tnixeu/prepare_cmake_unity_build
Add support cmake unity build
tnixeu [Wed, 9 Nov 2022 22:19:55 +0000 (23:19 +0100)]
enable unity build for appimage
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
tnixeu [Wed, 9 Nov 2022 22:19:35 +0000 (23:19 +0100)]
exclude kmessagewidget.cpp and wheelhandler.cpp from unity build
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
tnixeu [Sat, 29 Oct 2022 00:30:47 +0000 (02:30 +0200)]
skip unity build for files which fail to compile
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
tnixeu [Sat, 29 Oct 2022 00:19:35 +0000 (02:19 +0200)]
add guards around string constants and into an anonymous namespace
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
tnixeu [Sat, 29 Oct 2022 00:16:48 +0000 (02:16 +0200)]
add #pragma once
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
Nextcloud bot [Mon, 14 Nov 2022 03:24:00 +0000 (03:24 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 13 Nov 2022 03:22:20 +0000 (03:22 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 12 Nov 2022 03:25:37 +0000 (03:25 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 10 Nov 2022 03:30:19 +0000 (03:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 9 Nov 2022 21:49:32 +0000 (22:49 +0100)]
Merge pull request #5151 from nextcloud/ci/fixOneTestOnWindows
properly escape a path when creating a test file during tests
Matthieu Gallien [Wed, 9 Nov 2022 16:47:40 +0000 (17:47 +0100)]
do not run tests in parallel as we may get side effects
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 9 Nov 2022 15:36:38 +0000 (16:36 +0100)]
properly escape a path when creating a test file during tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Wed, 9 Nov 2022 17:16:21 +0000 (18:16 +0100)]
Merge pull request #5145 from nextcloud/feature/userstatusselector-modal
Make user status selector modal, show user header
Claudio Cambra [Wed, 9 Nov 2022 13:07:51 +0000 (14:07 +0100)]
Make user status selector modal, show user header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 9 Nov 2022 16:08:12 +0000 (17:08 +0100)]
Merge pull request #5118 from nextcloud/bugfix/remove-unused-var-user
Remove unused remotePath in User::processCompletedSyncItem
Claudio Cambra [Mon, 31 Oct 2022 19:19:36 +0000 (20:19 +0100)]
Remove unused remotePath in User::processCompletedSyncItem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
allexzander [Wed, 9 Nov 2022 15:06:08 +0000 (16:06 +0100)]
Merge pull request #5148 from nextcloud/bugfix/qdialig-do-not-use-copy-assignment
Do not use copy-assignment of QDialog.
alex-z [Wed, 9 Nov 2022 15:01:17 +0000 (16:01 +0100)]
Do not use copy-assignment of QDialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Wed, 9 Nov 2022 03:20:17 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 17:17:29 +0000 (18:17 +0100)]
Merge pull request #5132 from nextcloud/bugfix/dark-mode-share-delegate-buttons
Fix share delegate button icon colors in dark mode
Claudio Cambra [Fri, 4 Nov 2022 19:05:36 +0000 (20:05 +0100)]
Fix share delegate button icon colors in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 16:33:10 +0000 (17:33 +0100)]
Merge pull request #5129 from nextcloud/bugfix/sync-now-button-elide
Ensure 'Sync now' button doesn't have its text elided
Claudio Cambra [Fri, 4 Nov 2022 12:05:55 +0000 (13:05 +0100)]
Ensure 'Sync now' button doesn't have its text elided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 8 Nov 2022 15:31:31 +0000 (16:31 +0100)]
Merge pull request #5127 from nextcloud/bugfix/remove-unused-app-ptr
Remove unused app pointer in CocoaInitializer
Claudio Cambra [Fri, 4 Nov 2022 01:30:39 +0000 (02:30 +0100)]
Remove unused app pointer in CocoaInitializer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 8 Nov 2022 03:21:23 +0000 (03:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 7 Nov 2022 22:41:59 +0000 (23:41 +0100)]
Merge pull request #5104 from nextcloud/bugfix/doNotDeleteFilesInSyncDatabase
Bugfix/delete folders during propagation even when propagation has errors
Matthieu Gallien [Thu, 27 Oct 2022 15:29:02 +0000 (17:29 +0200)]
do not skip folder deletion if BlacklistedError during propagation
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)
let's not skip them but rather keep track of the error status and
properly report them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 27 Oct 2022 16:00:10 +0000 (18:00 +0200)]
new autotest to ensure that we delete folders despite blacklist errors
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 27 Oct 2022 11:13:21 +0000 (13:13 +0200)]
improve logs of E2EE API to not pollute logs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Thu, 27 Oct 2022 10:49:34 +0000 (12:49 +0200)]
logs from discovery are now namespaced by nextcloud to show debug logs
use nextcloud namespace for discovery logs as it does not show correcly
without that
this is because we have central rules for all logs from nextcloud
namespace
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Wed, 26 Oct 2022 16:13:55 +0000 (18:13 +0200)]
remove dead code related to item renaming
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
allexzander [Mon, 7 Nov 2022 14:13:50 +0000 (15:13 +0100)]
Merge pull request #5136 from nextcloud/feature/config-name-in-cmake
Use separate variable for cfg file name in CMAKE.
alex-z [Mon, 7 Nov 2022 09:00:23 +0000 (10:00 +0100)]
Use separate variable for cfg file name in CMAKE.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Mon, 7 Nov 2022 03:20:00 +0000 (03:20 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>