gtk4.git
2 years agoPost-release version bump
Matthias Clasen [Tue, 14 Mar 2023 12:16:30 +0000 (08:16 -0400)]
Post-release version bump

2 years ago4.10.1
Matthias Clasen [Mon, 13 Mar 2023 14:58:58 +0000 (15:58 +0100)]
4.10.1

2 years agoUpdated Spanish translation
Daniel [Tue, 14 Mar 2023 11:43:00 +0000 (12:43 +0100)]
Updated Spanish translation

2 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Tue, 14 Mar 2023 05:30:17 +0000 (05:30 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

gsk: Mark mask nodes as 'supports transforms'

See merge request GNOME/gtk!5650

2 years agocss: Small speedups
Matthias Clasen [Mon, 13 Mar 2023 21:20:12 +0000 (22:20 +0100)]
css: Small speedups

2 years agoicontheme: Silence a compiler warning
Matthias Clasen [Mon, 13 Mar 2023 21:19:51 +0000 (22:19 +0100)]
icontheme: Silence a compiler warning

2 years agotests: Add more tests for texture scale nodes
Matthias Clasen [Mon, 13 Mar 2023 17:20:02 +0000 (18:20 +0100)]
tests: Add more tests for texture scale nodes

2 years agogsk: Mark mask nodes as 'supports transforms'
Matthias Clasen [Mon, 13 Mar 2023 17:10:53 +0000 (18:10 +0100)]
gsk: Mark mask nodes as 'supports transforms'

Just like blur nodes, the renderer can handle
these without creating an extra offscreen.

2 years agoMerge branch 'fix-texture-scale-rotation' into 'main'
Matthias Clasen [Tue, 14 Mar 2023 05:08:37 +0000 (05:08 +0000)]
Merge branch 'fix-texture-scale-rotation' into 'main'

gtk4-demo: Polish the image scaling demo

See merge request GNOME/gtk!5649

2 years agoMerge branch 'bilelmoussaoui-main-patch-31679' into 'main'
Benjamin Otte [Tue, 14 Mar 2023 05:03:13 +0000 (05:03 +0000)]
Merge branch 'bilelmoussaoui-main-patch-31679' into 'main'

GLTexture: Add GL_RGB format support

See merge request GNOME/gtk!5647

2 years agogsk: Fix rotated texture scale nodes
Matthias Clasen [Mon, 13 Mar 2023 16:59:04 +0000 (17:59 +0100)]
gsk: Fix rotated texture scale nodes

This was causing us to render rotated texture scale
nodes to an unclipped offscreen, bringing 'giant
intermediate texture' problems back.

2 years agogtk4-demo: Add a tooltip to image scaling
Matthias Clasen [Mon, 13 Mar 2023 15:54:22 +0000 (16:54 +0100)]
gtk4-demo: Add a tooltip to image scaling

Show some information about the values.

2 years agogtk4-demo: Polish the image scaling demo
Matthias Clasen [Mon, 13 Mar 2023 12:10:52 +0000 (13:10 +0100)]
gtk4-demo: Polish the image scaling demo

Make the scale binding bidirectional again, fix up
the ranges and the sensitivity of the actions, and
add a mark for the unscaled position.

2 years agoUpdate German translation
Jürgen Benvenuti [Mon, 13 Mar 2023 18:30:32 +0000 (18:30 +0000)]
Update German translation

2 years agoGLTexture: Add GL_RGB format support
Bilal Elmoussaoui [Mon, 13 Mar 2023 13:59:17 +0000 (13:59 +0000)]
GLTexture: Add GL_RGB format support

2 years agoMerge branch 'more-scaled-texture-fixes' into 'main'
Matthias Clasen [Mon, 13 Mar 2023 08:58:58 +0000 (08:58 +0000)]
Merge branch 'more-scaled-texture-fixes' into 'main'

Fix gtk_snapshot_append_scaled_texture

See merge request GNOME/gtk!5638

2 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Mon, 13 Mar 2023 07:55:52 +0000 (07:55 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

gtk4-demo: Fix rotation handling in image scaling

See merge request GNOME/gtk!5643

2 years agogtk4-demo: Use gtk_snapshot_append_scaled_texture
Matthias Clasen [Mon, 13 Mar 2023 07:54:13 +0000 (08:54 +0100)]
gtk4-demo: Use gtk_snapshot_append_scaled_texture

2 years agoFix gtk_snapshot_append_scaled_texture
Matthias Clasen [Fri, 10 Mar 2023 23:50:40 +0000 (00:50 +0100)]
Fix gtk_snapshot_append_scaled_texture

This was doing the wrong thing with transforms.

2 years agodocs: Details about texture scale nodes
Matthias Clasen [Mon, 13 Mar 2023 07:38:58 +0000 (08:38 +0100)]
docs: Details about texture scale nodes

Add some more details about filtering, to
clarify things a bit.

2 years agogtk4-demo: Scale logarithmically in image scaling
Matthias Clasen [Mon, 13 Mar 2023 07:21:10 +0000 (08:21 +0100)]
gtk4-demo: Scale logarithmically in image scaling

2 years agogtk4-demo: Fix rotation handling in image scaling
Matthias Clasen [Mon, 13 Mar 2023 07:11:29 +0000 (08:11 +0100)]
gtk4-demo: Fix rotation handling in image scaling

We weren't sizing the widget correctly in rotated
cases.

2 years agoUpdate Portuguese translation
Hugo Carvalho [Mon, 13 Mar 2023 00:06:26 +0000 (00:06 +0000)]
Update Portuguese translation

2 years agoUpdate Galician translation
Fran Dieguez [Sun, 12 Mar 2023 23:19:49 +0000 (23:19 +0000)]
Update Galician translation

2 years agoUpdate Lithuanian translation
Aurimas Černius [Sun, 12 Mar 2023 20:01:39 +0000 (20:01 +0000)]
Update Lithuanian translation

2 years agoUpdate Bulgarian translation
Alexander Shopov [Sun, 12 Mar 2023 18:36:38 +0000 (18:36 +0000)]
Update Bulgarian translation

2 years agoUpdated Danish translation
Ask Hjorth Larsen [Sun, 12 Mar 2023 15:24:18 +0000 (16:24 +0100)]
Updated Danish translation

2 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Sun, 12 Mar 2023 10:20:04 +0000 (10:20 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

gtk-demo: Add rotation to the scaling demo

Closes #5659

See merge request GNOME/gtk!5641

2 years agoUpdate Basque translation
Asier Sarasua Garmendia [Sun, 12 Mar 2023 09:35:14 +0000 (09:35 +0000)]
Update Basque translation

2 years agocolumnview: Be more defensive
Matthias Clasen [Sun, 12 Mar 2023 07:23:16 +0000 (08:23 +0100)]
columnview: Be more defensive

I am not sure how we can have no listitem here,
but better to be safe than sorry.

Fixes: #5659
2 years agogtk-demo: Add rotation to the scaling demo
Matthias Clasen [Sat, 11 Mar 2023 17:56:08 +0000 (18:56 +0100)]
gtk-demo: Add rotation to the scaling demo

Closing in on eog :)

2 years agoUpdate Turkish translation
Sabri Ünal [Sat, 11 Mar 2023 16:03:32 +0000 (16:03 +0000)]
Update Turkish translation

2 years agoUpdate Swedish translation
Anders Jonsson [Sat, 11 Mar 2023 15:47:38 +0000 (15:47 +0000)]
Update Swedish translation

2 years agoUpdate Polish translation
Piotr Drąg [Sat, 11 Mar 2023 14:14:42 +0000 (15:14 +0100)]
Update Polish translation

2 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Sat, 11 Mar 2023 11:56:23 +0000 (11:56 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

inspector: Force a full redraw for debug nodes

See merge request GNOME/gtk!5640

2 years agoinspector: Force a full redraw for debug nodes
Matthias Clasen [Sat, 11 Mar 2023 11:30:44 +0000 (12:30 +0100)]
inspector: Force a full redraw for debug nodes

Without this, debug nodes randomly are missing
in the tree, where we are reusing older render
nodes.

2 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Sat, 11 Mar 2023 10:21:13 +0000 (10:21 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

themes: Avoid ':' in custom target names

Closes #5280

See merge request GNOME/gtk!5639

2 years agothemes: Avoid ':' in custom target names
Matthias Clasen [Sat, 11 Mar 2023 10:03:43 +0000 (11:03 +0100)]
themes: Avoid ':' in custom target names

For whatever reason, meson decides to use custom
target names in the file system, and on Windows,
the ':' is causing trouble here. So avoid it.

Fixes: #5280
2 years agoUpdate Czech translation
Marek Černocký [Sat, 11 Mar 2023 08:52:49 +0000 (08:52 +0000)]
Update Czech translation

2 years agoUpdate Georgian translation
Ekaterine Papava [Sat, 11 Mar 2023 05:39:09 +0000 (05:39 +0000)]
Update Georgian translation

2 years agoMerge branch 'wip/otte/rendernode-export' into 'main'
Benjamin Otte [Sat, 11 Mar 2023 00:26:18 +0000 (00:26 +0000)]
Merge branch 'wip/otte/rendernode-export' into 'main'

rendernode: Register SVG serializer

See merge request GNOME/gtk!5637

2 years agoUpdate Hungarian translation
Balázs Úr [Fri, 10 Mar 2023 23:47:38 +0000 (23:47 +0000)]
Update Hungarian translation

2 years agoMerge branch 'wip/x11-create-destroy-without-show-show-hide' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 23:40:50 +0000 (23:40 +0000)]
Merge branch 'wip/x11-create-destroy-without-show-show-hide' into 'main'

x11/surface: Clear compute_size idle source also when destroying

See merge request GNOME/gtk!5636

2 years agoMerge branch 'cache-scaled-texture' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 23:38:50 +0000 (23:38 +0000)]
Merge branch 'cache-scaled-texture' into 'main'

gsk: Cache scaled texture

Closes #5642

See merge request GNOME/gtk!5633

2 years agonode-editor: Add more export options
Benjamin Otte [Fri, 10 Mar 2023 21:58:19 +0000 (22:58 +0100)]
node-editor: Add more export options

Auto-detect tiff and svg and if those are chosen, save to that format.

2 years agorendernode: Register PNG serializer
Benjamin Otte [Fri, 10 Mar 2023 23:08:20 +0000 (00:08 +0100)]
rendernode: Register PNG serializer

This allows dropping or copy/pasting rendernodes into apps that accept
images.

2 years agogtk4-demo: Add tooltips to the menu demo
Matthias Clasen [Fri, 10 Mar 2023 23:07:07 +0000 (00:07 +0100)]
gtk4-demo: Add tooltips to the menu demo

Not great UI, but better than nothing.

2 years agoRename the menu demo
Matthias Clasen [Fri, 10 Mar 2023 23:03:05 +0000 (00:03 +0100)]
Rename the menu demo

At this point, the Menu demo is more about scaling images
than about menus, so rename it to Image Scaling.

2 years agorendernode: Register SVG serializer
Benjamin Otte [Fri, 10 Mar 2023 14:30:26 +0000 (15:30 +0100)]
rendernode: Register SVG serializer

This allows dropping or copy/pasting rendernodes into apps that accept
SVGs.

Not sure how useful this is because we advertise text/plain from
rendernodes already and we prefer that.

2 years agogtk-demo: Add a file chooser to the menu demo
Matthias Clasen [Fri, 10 Mar 2023 22:51:17 +0000 (23:51 +0100)]
gtk-demo: Add a file chooser to the menu demo

So we can try this with bigger images.

2 years agox11/surface: Clear compute_size idle source also when destroying
Jonas Ådahl [Fri, 10 Mar 2023 22:30:51 +0000 (23:30 +0100)]
x11/surface: Clear compute_size idle source also when destroying

Doing it on hide() is not enough, since in some edge cases we didn't
ever actually map, we just attempted to compute the size, e.g. in
response to a ConfigureNotify event, then the window was destroyed.

Related: https://gitlab.gnome.org/GNOME/mutter/-/issues/2678

2 years agogsk: Cache scaled texture
Matthias Clasen [Thu, 9 Mar 2023 11:35:07 +0000 (11:35 +0000)]
gsk: Cache scaled texture

Keep the texture we create for texture scale nodes.

Fixes: #5642
2 years agoUpdate Ukrainian translation
Yuri Chornoivan [Fri, 10 Mar 2023 19:24:32 +0000 (19:24 +0000)]
Update Ukrainian translation

2 years agoMerge branch 'wip/otte/filefilter-name' into 'main'
Benjamin Otte [Fri, 10 Mar 2023 17:11:25 +0000 (17:11 +0000)]
Merge branch 'wip/otte/filefilter-name' into 'main'

filefilter: If not given a name, deduce one

See merge request GNOME/gtk!5630

2 years agoUpdate Finnish translation
Jiri Grönroos [Fri, 10 Mar 2023 17:03:35 +0000 (17:03 +0000)]
Update Finnish translation

2 years agoMerge branch 'reverse-file-chooser-recent-files-sort-order' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 16:40:50 +0000 (16:40 +0000)]
Merge branch 'reverse-file-chooser-recent-files-sort-order' into 'main'

filerchooser: Show Recent files in inverse order

See merge request GNOME/gtk!5625

2 years agoMerge branch 'wip/otte/listview-border-spacing' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 16:39:05 +0000 (16:39 +0000)]
Merge branch 'wip/otte/listview-border-spacing' into 'main'

Implement CSS border-spacing support for listview and gridview

See merge request GNOME/gtk!5626

2 years agoMerge branch 'file-chooser-selectability2' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 16:37:41 +0000 (16:37 +0000)]
Merge branch 'file-chooser-selectability2' into 'main'

file system model: Store selectability

See merge request GNOME/gtk!5582

2 years agoMerge branch 'notify_after_value_change' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 16:36:41 +0000 (16:36 +0000)]
Merge branch 'notify_after_value_change' into 'main'

a11y: Notify assistive technologies when a GTK_ACCESSIBLE_PROPERTY_VALUE_NOW changes on a widget

See merge request GNOME/gtk!5624

2 years agoa11y: Notify assistive technologies when a GTK_ACCESSIBLE_PROPERTY_VALUE_NOW changes...
Lukáš Tyrychtr [Fri, 10 Mar 2023 16:36:39 +0000 (16:36 +0000)]
a11y: Notify assistive technologies when a GTK_ACCESSIBLE_PROPERTY_VALUE_NOW changes on a widget

This fixes silent sliders and similar controls when their value is changed.

2 years agofilefilter: If not given a name, deduce one
Benjamin Otte [Fri, 10 Mar 2023 15:12:00 +0000 (16:12 +0100)]
filefilter: If not given a name, deduce one

Otherwise we end up with a critical when cosntructing the GVariant and
the portal claims our filter is for "[Invalid UTF-8]".

Test included

2 years agogridview: Add border-spacing support
Benjamin Otte [Fri, 10 Mar 2023 04:16:25 +0000 (05:16 +0100)]
gridview: Add border-spacing support

omg, this is complicated code.

2 years agogridview: Introduce column size functions
Benjamin Otte [Thu, 9 Mar 2023 16:22:06 +0000 (17:22 +0100)]
gridview: Introduce column size functions

This is in preparation for border-spacing integration.

2 years agogridview: Use gtk_list_item_manager_get_nearest_tile()
Benjamin Otte [Thu, 9 Mar 2023 04:30:25 +0000 (05:30 +0100)]
gridview: Use gtk_list_item_manager_get_nearest_tile()

Simplifies gtk_grid_view_get_position_from_allocation() a bit because we
can omit the bounds shenanigan.

2 years agolistview: Support CSS border-spacing
Benjamin Otte [Thu, 9 Mar 2023 03:43:51 +0000 (04:43 +0100)]
listview: Support CSS border-spacing

Hopefully the code can deal with gaps between the tiles.

We use gtk_list_item_manager_get_nearest_tile() when necessary.

2 years agofilechooser: Set selectability for list items
Matthias Clasen [Fri, 10 Mar 2023 14:18:26 +0000 (15:18 +0100)]
filechooser: Set selectability for list items

We propagate this from the list items to the
GtkListItems. Twisty!

2 years agofilechooser: Dim non-selectable items
Matthias Clasen [Wed, 1 Mar 2023 17:01:15 +0000 (12:01 -0500)]
filechooser: Dim non-selectable items

2 years agocolumview: Propagate activatable and selectable
Matthias Clasen [Wed, 1 Mar 2023 17:00:26 +0000 (12:00 -0500)]
columview: Propagate activatable and selectable

When any of the cells is not activatable or selectable,
make the row not have those properties either.

2 years agofilechooser: Inform the model about selectability
Matthias Clasen [Wed, 1 Mar 2023 12:53:45 +0000 (07:53 -0500)]
filechooser: Inform the model about selectability

In folder modes, we don't want to select files.

2 years agofilesystemmodel: Store selectability
Matthias Clasen [Wed, 1 Mar 2023 12:53:07 +0000 (07:53 -0500)]
filesystemmodel: Store selectability

This will be used later on.

2 years agoMerge branch 'file-chooser-selection' into 'main'
Matthias Clasen [Fri, 10 Mar 2023 14:25:36 +0000 (14:25 +0000)]
Merge branch 'file-chooser-selection' into 'main'

filechooser: Don't automatically select a file

See merge request GNOME/gtk!5572

2 years agoUpdate Friulian translation
Fabio Tomat [Fri, 10 Mar 2023 07:49:25 +0000 (07:49 +0000)]
Update Friulian translation

2 years agolistitemmanager: Add gtk_list_item_manager_get_nearest_tile()
Benjamin Otte [Thu, 9 Mar 2023 03:42:45 +0000 (04:42 +0100)]
listitemmanager: Add gtk_list_item_manager_get_nearest_tile()

... and make the tile finding code use distance.

This also changes how gtk_list_item_manager_get_tile_at() finds the
right tile, so this is a custom commit for bisectability.

gtk_list_item_manager_get_nearest_tile() isn't used yet.

2 years agolistview: Move bounds check into base class
Benjamin Otte [Thu, 9 Mar 2023 03:02:22 +0000 (04:02 +0100)]
listview: Move bounds check into base class

This way, listview and gridview don't need to check if the rect is out
of bounds and nothing is selected, a quick rectangle_intersect() does
the job for them.

2 years agolistview: Return an allocation for unallcoated items
Benjamin Otte [Thu, 9 Mar 2023 02:34:01 +0000 (03:34 +0100)]
listview: Return an allocation for unallcoated items

Just get the position right and give them a height of 0px, that should
be good enough.

If we don't do that, code will think the item doesn't exist, which is
not what we want.

2 years agofilerchooser: Show Recent files in inverse order
Ray Strode [Thu, 9 Mar 2023 20:42:16 +0000 (15:42 -0500)]
filerchooser: Show Recent files in inverse order

When looking at Recent files in the file chooser, it makes more
sense to show the recent files on top.

This commit flips the sort order for that case.

2 years agoMerge branch 'more-size-allocation-fixes' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 22:26:51 +0000 (22:26 +0000)]
Merge branch 'more-size-allocation-fixes' into 'main'

widget: Skip popovers in allocation

See merge request GNOME/gtk!5615

2 years agoMerge branch 'wip/chergert/fix-const-preserving-text-iter-order' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 22:06:04 +0000 (22:06 +0000)]
Merge branch 'wip/chergert/fix-const-preserving-text-iter-order' into 'main'

textlinedisplaycache: fix const-preserving gtk_text_iter_order()

See merge request GNOME/gtk!5620

2 years agoMerge branch 'file_chooser_stuff' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 21:57:13 +0000 (21:57 +0000)]
Merge branch 'file_chooser_stuff' into 'main'

filechooser: two small changes

See merge request GNOME/gtk!5619

2 years agotextlinedisplaycache: fix const-preserving gtk_text_iter_order()
Christian Hergert [Wed, 8 Mar 2023 21:00:08 +0000 (13:00 -0800)]
textlinedisplaycache: fix const-preserving gtk_text_iter_order()

2 years agofilechooser: Do not look up parents of directories
Barnabás Pőcze [Wed, 8 Mar 2023 19:20:35 +0000 (20:20 +0100)]
filechooser: Do not look up parents of directories

If the `GtkRecentInfo` represents a directory, simply use it, and
do not try to find its parent in `_gtk_file_chooser_extract_recent_folders()`.

For example, there is an entry in my recently-used database
from the Amberol music player about the folder I have opened
with it, but the folder is not listed on the "Recent" tab of
the file chooser widget, only its parent. After this change,
the directory itself is shown.

2 years agofilechooser: Use gtk_recent_info_is_local() for filtering
Barnabás Pőcze [Wed, 8 Mar 2023 19:04:41 +0000 (20:04 +0100)]
filechooser: Use gtk_recent_info_is_local() for filtering

There is already a function for determining if URI
has the "file" scheme, so use that.

2 years agoMerge branch 'ebassi/issue-5650' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 18:45:10 +0000 (18:45 +0000)]
Merge branch 'ebassi/issue-5650' into 'main'

Filter recently used files in the file chooser

Closes #5650

See merge request GNOME/gtk!5618

2 years agoMerge branch 'fix-msvc-older-glib' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 18:44:46 +0000 (18:44 +0000)]
Merge branch 'fix-msvc-older-glib' into 'main'

modules/media: Fix Visual Studio builds with older GLib (<= 2.74.x)

See merge request GNOME/gtk!5605

2 years agowidget: Skip popovers in allocation
Matthias Clasen [Wed, 8 Mar 2023 18:36:42 +0000 (13:36 -0500)]
widget: Skip popovers in allocation

Native widgets get allocated via their surface,
so can skip them here. This avoids criticals when
re-mapping a popover for the second time, as can
be seen e.g. in the 'Selections' demo in gtk4-demo.

2 years agowidget: Stop propagating alloc_needed beyond popovers
Matthias Clasen [Wed, 8 Mar 2023 18:13:15 +0000 (13:13 -0500)]
widget:  Stop propagating alloc_needed beyond popovers

This should not be necessary, since popovers get
their new size from present_popup via the compositor.

2 years agowidget: Remove goto usage in widget_allocate()
Benjamin Otte [Wed, 8 Mar 2023 18:27:46 +0000 (18:27 +0000)]
widget: Remove goto usage in widget_allocate()

2 years agowidget: Split out gtk_widget_ensure_allocate_on_children()
Benjamin Otte [Wed, 8 Mar 2023 18:23:50 +0000 (18:23 +0000)]
widget: Split out gtk_widget_ensure_allocate_on_children()

allocate() should not be calling into ensure_allocate(), they do a similar job.
In the end, the code does the same work, but it should be easier to follow now.

2 years agowidget: Simplify size allocation
Matthias Clasen [Wed, 8 Mar 2023 18:06:53 +0000 (13:06 -0500)]
widget: Simplify size allocation

Don't call ensure_allocate if we've just
done size_allocate. This makes criticals
from reshowing popovers go away.

2 years agoFilter recently used files in the file chooser
Emmanuele Bassi [Wed, 8 Mar 2023 18:08:24 +0000 (18:08 +0000)]
Filter recently used files in the file chooser

Since it's a file selection widget, we should only list recently used
files that point to a file.

Fixes: #5650
2 years agoMerge branch 'wip/carlosg/reuse-search-engine' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 12:58:43 +0000 (12:58 +0000)]
Merge branch 'wip/carlosg/reuse-search-engine' into 'main'

gtkfilechooser: Keep GtkSearchEngine around for longer

See merge request GNOME/gtk!5617

2 years agogtkfilechooser: Keep GtkSearchEngine around for longer
Carlos Garnacho [Wed, 8 Mar 2023 12:13:19 +0000 (13:13 +0100)]
gtkfilechooser: Keep GtkSearchEngine around for longer

Currently the GtkSearchEngine is torn down every time the search
is stopped, which also means between typed characters. This
prevents any of the optimizations that the GtkSearchEngine can
do in the long run.

Let the GtkSearchEngine stay around for longer, and only be
disposed after search is cancelled, the filechooser moves
onto a different mode than search, or is otherwise unmapped/disposed.

While at it, remove an unused struct field.

2 years agoMerge branch 'wip/carlosg/recursive-file-search' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 11:56:41 +0000 (11:56 +0000)]
Merge branch 'wip/carlosg/recursive-file-search' into 'main'

searchengine: Improve performance for recursive search

Closes #4133

See merge request GNOME/gtk!5611

2 years agosearchengine: Do not fight filechooser search mode sorting
Carlos Garnacho [Wed, 8 Mar 2023 10:23:39 +0000 (11:23 +0100)]
searchengine: Do not fight filechooser search mode sorting

Provide the hits in an order that is more easily consumed by the
filechooser, and less jarring when populating.

2 years agosearchengine: Bail out on the first character
Carlos Garnacho [Tue, 7 Mar 2023 23:03:28 +0000 (00:03 +0100)]
searchengine: Bail out on the first character

Again on massive filesystems, the very first character
is likely to bring a likewise massive amount of search
results that we need to maybe query info for, then create
icons and widgets for. While it's impressive we can do
that, it's also expensive and likely pointless, for the
first character.

Typing a second character is however very likely to
considerably reduce the amount of items to categorize and
show. So start actually searching from there.

Testing on a filesystem with 1434099 files indexed, trying 5
semi-random 1 character searches (n, h, t, i, o) returns on
average 168K items (min. 78771, max. 331471), trying 5
semi-random 2 character searches (no, he, th, in, on)
returns on average 34K items (min. 11133, max. 94961),
which is a more approachable set.

Doing this is enough that typing on a filechooser search
entry feels completely fluid.

2 years agosearchengine: Ensure some GFileInfo fields
Carlos Garnacho [Tue, 7 Mar 2023 23:01:53 +0000 (00:01 +0100)]
searchengine: Ensure some GFileInfo fields

The search provider should make it sure there are some
specific GFileInfo fields set. Fix the mimetype extraction
from the query, and use that to fill in the missing gaps
the best we can.

2 years agosearchengine: Drop non-recursive search
Carlos Garnacho [Tue, 7 Mar 2023 22:04:25 +0000 (23:04 +0100)]
searchengine: Drop non-recursive search

Recursive search seems to be the hardcoded default, go with it.

2 years agosearchengine: Populate filesystem model in an idle
Carlos Garnacho [Tue, 7 Mar 2023 21:35:47 +0000 (22:35 +0100)]
searchengine: Populate filesystem model in an idle

When starting a search over a very populated filesystem, it
is possible that typing the first chars will return a too
high number of results. Even though iterating through the
cursor is in itself very fast, extracting the GIO information
from those many files at once is not going to be as fast.

In order to increase interactivity (i.e. not make things
possibly sluggish) iterate the cursor in an idle function
and add search results to the filechooser model little by little.

If the user keeps typing (as it is likely will happen), there
will be better chances to cancel and proceed to the next
query timely. If not, the results will be there soon enough.

2 years agoMerge branch 'check_null_gfile_location' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 03:19:00 +0000 (03:19 +0000)]
Merge branch 'check_null_gfile_location' into 'main'

filechooser: Fix memory leaks

See merge request GNOME/gtk!5610

2 years agoMerge branch 'matthiasc/for-main' into 'main'
Matthias Clasen [Wed, 8 Mar 2023 03:02:16 +0000 (03:02 +0000)]
Merge branch 'matthiasc/for-main' into 'main'

build: Handle introspection a bit better

See merge request GNOME/gtk!5614