Vasudev Kamath [Tue, 1 May 2018 07:32:05 +0000 (13:02 +0530)]
Make fast forward from 0.25.0-3
[dgit --quilt=gbp]
Ximin Luo [Tue, 1 May 2018 07:32:05 +0000 (13:02 +0530)]
Avoid installing dev-dependencies
Applied-Upstream: https://github.com/rust-lang/cargo/pull/5012
Applied-Upstream: https://github.com/rust-lang/cargo/pull/5186
Gbp-Pq: Name 1001_PR5012.patch
Ximin Luo [Tue, 1 May 2018 07:32:05 +0000 (13:02 +0530)]
Disable network tests
Forwarded: TODO
Gbp-Pq: Name 2002_disable-net-tests.patch
Ximin Luo [Tue, 1 May 2018 07:32:05 +0000 (13:02 +0530)]
Always use system libgit2
Forwarded: not-needed
Gbp-Pq: Name 2001_use-system-libgit2.patch
Ximin Luo [Tue, 1 May 2018 07:32:05 +0000 (13:02 +0530)]
_clean-cargo-deps
Gbp-Pq: Name 2004_clean-cargo-deps.patch
Rust Maintainers [Tue, 1 May 2018 07:32:05 +0000 (13:02 +0530)]
Disable incremental builds on sparc64
Incremental builds are currently unreliable on sparc64,
disable them by default for the time being.
Last-Update: 2018-04-09
Gbp-Pq: Name 2007_sparc64_disable_incremental_build.patch
Vasudev Kamath [Tue, 1 May 2018 07:32:24 +0000 (13:02 +0530)]
Prepare upload to unstable.
Vasudev Kamath [Sat, 21 Apr 2018 15:29:45 +0000 (20:59 +0530)]
prepare release for experimental.
Vasudev Kamath [Sat, 21 Apr 2018 15:02:33 +0000 (20:32 +0530)]
Add copyright for lazycell, proc-macro, quick-error and ucd-util
Vasudev Kamath [Sun, 15 Apr 2018 16:47:32 +0000 (22:17 +0530)]
Mark as unreleased
Pending copyright file updates.
Vasudev Kamath [Sun, 15 Apr 2018 16:44:38 +0000 (22:14 +0530)]
Prepare for experimetnal release.
Vasudev Kamath [Sun, 15 Apr 2018 16:44:09 +0000 (22:14 +0530)]
Add copyright for humantime crate.
Vasudev Kamath [Sun, 15 Apr 2018 15:30:46 +0000 (21:00 +0530)]
Refresh patch 1001 with new upstream release.
Vasudev Kamath [Sun, 15 Apr 2018 15:29:47 +0000 (20:59 +0530)]
Add generate_lock_file.rs to patch 2002
Disable no_index_update patch.
Vasudev Kamath [Sun, 15 Apr 2018 15:43:05 +0000 (21:13 +0530)]
Drop patch 1002, merged upstream
Vasudev Kamath [Sun, 15 Apr 2018 15:42:47 +0000 (21:12 +0530)]
Drop patch 2006 as the wasm32 tests are dropped.
Vasudev Kamath [Sun, 15 Apr 2018 15:22:48 +0000 (20:52 +0530)]
Drop 2003 2005 and cargo-doc.doc-base as docs can't be built
Vasudev Kamath [Sun, 15 Apr 2018 09:15:51 +0000 (14:45 +0530)]
Mark package compliance with Debian Policy 4.1.4.
Vasudev Kamath [Sun, 15 Apr 2018 09:11:10 +0000 (14:41 +0530)]
Update upstream source from tag 'upstream/0.26.0'
Update to upstream version '0.26.0'
with Debian dir
cb4be93fcfeabfd0586ac0dc6943a32134549461
Vasudev Kamath [Sun, 15 Apr 2018 09:10:21 +0000 (14:40 +0530)]
New upstream version 0.26.0
Vasudev Kamath [Sun, 15 Apr 2018 09:03:15 +0000 (14:33 +0530)]
Refresh the patch 2004 against newer Cargo.toml
Vasudev Kamath [Sun, 15 Apr 2018 07:30:37 +0000 (13:00 +0530)]
Prepare release for unstable.
Vasudev Kamath [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Make fast forward from 0.25.0-2
[dgit --quilt=gbp]
Ximin Luo [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Avoid installing dev-dependencies
Applied-Upstream: https://github.com/rust-lang/cargo/pull/5012
Applied-Upstream: https://github.com/rust-lang/cargo/pull/5186
Gbp-Pq: Name 1001_PR5012.patch
Vasudev Kamath [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Disable wasm32_final_outputs test
This test depends on emscripten built using fastcomp
a fork of LLVM and is not available in Debian.
Last-Update: 2017-12-05
Gbp-Pq: Name 2006_disable_wasm32_tests.patch
Vasudev Kamath [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Don't run mdBook for book preview
Upstream script tries to show preview of generated document
the tool needed is missing and step is not needed during
package build.
Last-Update: 2017-12-03
Gbp-Pq: Name 2005_dont_run_mdbook.patch
Vasudev Kamath [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Fix typo in cargo search subcommand.
Since the search subcommand where typo happened is
also used in test fix the typo in test also.
Last-Update: 2017-10-29
Gbp-Pq: Name 1002_fix_typo_cargo_search.patch
Ximin Luo [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Disable network tests
Forwarded: TODO
Gbp-Pq: Name 2002_disable-net-tests.patch
Ximin Luo [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Always use system libgit2
Forwarded: not-needed
Gbp-Pq: Name 2001_use-system-libgit2.patch
Luca Bruno [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
_local-jquery
Gbp-Pq: Name 2003_local-jquery.patch
Ximin Luo [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
_clean-cargo-deps
Gbp-Pq: Name 2004_clean-cargo-deps.patch
Rust Maintainers [Sun, 15 Apr 2018 06:58:29 +0000 (12:28 +0530)]
Disable incremental builds on sparc64
Incremental builds are currently unreliable on sparc64,
disable them by default for the time being.
Last-Update: 2018-04-09
Gbp-Pq: Name 2007_sparc64_disable_incremental_build.patch
Vasudev Kamath [Sun, 15 Apr 2018 06:54:17 +0000 (12:24 +0530)]
Add patch to prevent incremental builds on sparc64.
Closes: bug#895300, Thanks to John Paul Adrian Glaubitz.
Ximin Luo [Sat, 31 Mar 2018 12:14:27 +0000 (14:14 +0200)]
Update Vcs-* fields to salsa
Vasudev Kamath [Thu, 22 Mar 2018 14:38:36 +0000 (20:08 +0530)]
Prepare upload to unstable.
Vasudev Kamath [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Make fast forward from 0.25.0-1
[dgit --quilt=gbp]
Ximin Luo [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Avoid installing dev-dependencies
Applied-Upstream: https://github.com/rust-lang/cargo/pull/5012
Applied-Upstream: https://github.com/rust-lang/cargo/pull/5186
Gbp-Pq: Name 1001_PR5012.patch
Vasudev Kamath [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Disable wasm32_final_outputs test
This test depends on emscripten built using fastcomp
a fork of LLVM and is not available in Debian.
Last-Update: 2017-12-05
Gbp-Pq: Name 2006_disable_wasm32_tests.patch
Vasudev Kamath [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Don't run mdBook for book preview
Upstream script tries to show preview of generated document
the tool needed is missing and step is not needed during
package build.
Last-Update: 2017-12-03
Gbp-Pq: Name 2005_dont_run_mdbook.patch
Vasudev Kamath [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Fix typo in cargo search subcommand.
Since the search subcommand where typo happened is
also used in test fix the typo in test also.
Last-Update: 2017-10-29
Gbp-Pq: Name 1002_fix_typo_cargo_search.patch
Ximin Luo [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Disable network tests
Forwarded: TODO
Gbp-Pq: Name 2002_disable-net-tests.patch
Ximin Luo [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
Always use system libgit2
Forwarded: not-needed
Gbp-Pq: Name 2001_use-system-libgit2.patch
Luca Bruno [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
_local-jquery
Gbp-Pq: Name 2003_local-jquery.patch
Ximin Luo [Thu, 22 Mar 2018 14:38:17 +0000 (20:08 +0530)]
_clean-cargo-deps
Gbp-Pq: Name 2004_clean-cargo-deps.patch
Ximin Luo [Wed, 21 Mar 2018 11:02:29 +0000 (12:02 +0100)]
Remove Cargo.lock when cleaning, fixes build when checking out new versions
Ximin Luo [Tue, 6 Feb 2018 00:43:10 +0000 (01:43 +0100)]
Don't require dev-dependencies when not needed in certain cases
Ximin Luo [Mon, 19 Mar 2018 16:49:13 +0000 (17:49 +0100)]
Depend on rustc 1.24 or later
Vasudev Kamath [Fri, 9 Mar 2018 15:47:59 +0000 (21:17 +0530)]
Prepare upload to unstable.
Vasudev Kamath [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
Declare fast forward from 0.24.0-1
[dgit --quilt=gbp --overwrite=0.24.0-1]
Vasudev Kamath [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
Disable wasm32_final_outputs test
This test depends on emscripten built using fastcomp
a fork of LLVM and is not available in Debian.
Last-Update: 2017-12-05
Gbp-Pq: Name 2006_disable_wasm32_tests.patch
Vasudev Kamath [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
Don't run mdBook for book preview
Upstream script tries to show preview of generated document
the tool needed is missing and step is not needed during
package build.
Last-Update: 2017-12-03
Gbp-Pq: Name 2005_dont_run_mdbook.patch
Vasudev Kamath [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
Fix typo in cargo search subcommand.
Since the search subcommand where typo happened is
also used in test fix the typo in test also.
Last-Update: 2017-10-29
Gbp-Pq: Name 1002_fix_typo_cargo_search.patch
Ximin Luo [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
Disable network tests
Forwarded: TODO
Gbp-Pq: Name 2002_disable-net-tests.patch
Ximin Luo [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
Always use system libgit2
Forwarded: not-needed
Gbp-Pq: Name 2001_use-system-libgit2.patch
Luca Bruno [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
_local-jquery
Gbp-Pq: Name 2003_local-jquery.patch
Ximin Luo [Fri, 9 Mar 2018 15:39:38 +0000 (21:09 +0530)]
_clean-cargo-deps
Gbp-Pq: Name 2004_clean-cargo-deps.patch
bors [Mon, 26 Feb 2018 21:17:55 +0000 (21:17 +0000)]
Auto merge of #5085 - matklad:rust-1.25.0-tls, r=alexcrichton
[beta] warn about TLS for github specifically
Backport of https://github.com/rust-lang/cargo/pull/5069 to beta
r? @alexcrichton
Aleksey Kladov [Mon, 26 Feb 2018 17:41:22 +0000 (20:41 +0300)]
[beta] warn about TLS for github specifically
Vasudev Kamath [Sun, 25 Feb 2018 06:49:01 +0000 (12:19 +0530)]
Prepare release
Vasudev Kamath [Sun, 25 Feb 2018 06:48:45 +0000 (12:18 +0530)]
Disable tests on powerpc and powerpcspe
Vasudev Kamath [Sat, 24 Feb 2018 09:13:52 +0000 (14:43 +0530)]
Prepare new release for experimental
Vasudev Kamath [Sat, 24 Feb 2018 09:12:31 +0000 (14:42 +0530)]
Update copyright for 0.25.0
Vasudev Kamath [Sat, 24 Feb 2018 08:50:37 +0000 (14:20 +0530)]
Drop unused lintian override for README as patch.
Request to not consider README under patches as a patch file has been
implemented in lintian upstream.
Vasudev Kamath [Sat, 24 Feb 2018 08:50:08 +0000 (14:20 +0530)]
Fix typo in 2006 patch description.
Vasudev Kamath [Sat, 24 Feb 2018 07:32:46 +0000 (13:02 +0530)]
Drop patch 0001 as its merged upstream.
Vasudev Kamath [Sat, 24 Feb 2018 07:22:56 +0000 (12:52 +0530)]
Update upstream source from tag 'upstream/0.25.0'
Update to upstream version '0.25.0'
with Debian dir
44c2a43b3d0c56627bb5fb049db7430d3382d218
Vasudev Kamath [Sat, 24 Feb 2018 07:22:01 +0000 (12:52 +0530)]
New upstream version 0.25.0
Vasudev Kamath [Sat, 24 Feb 2018 07:19:49 +0000 (12:49 +0530)]
Make sure we take filter and unsuspiciaus texts from debian folder
This was added because these files will be present under .git/dgit/unpack if we
use dgit to push source.
Vasudev Kamath [Sat, 24 Feb 2018 07:19:20 +0000 (12:49 +0530)]
Audit unsuspicious files for 0.25.0 release.
Vasudev Kamath [Sat, 24 Feb 2018 07:19:01 +0000 (12:49 +0530)]
Filter out git test data from libgit2-sys.
bors [Tue, 13 Feb 2018 11:03:57 +0000 (11:03 +0000)]
Auto merge of #5029 - matklad:new-defaults-to-bin, r=withoutboats
New defaults to bin
So this switches `cargo new` default from `--lib` to `--bin`, as discussed on IRC.
The first two commits are just refactorings, and the last one actually flips the switch. Surprisingly enough, no tests need to be modified it seems!
r? @withoutboats
bors [Mon, 12 Feb 2018 22:32:11 +0000 (22:32 +0000)]
Auto merge of #5033 - alexcrichton:update-deps, r=matklad
Update dependencies
Just a few major updates here and there
Alex Crichton [Mon, 12 Feb 2018 20:42:31 +0000 (12:42 -0800)]
Update dependencies
Just a few major updates here and there
bors [Mon, 12 Feb 2018 22:02:00 +0000 (22:02 +0000)]
Auto merge of #5032 - matklad:lazycell, r=alexcrichton
Switch to lazycell from crate.io
This switches from a home-grown implementation of `lazycell` to the one from crates.io.
There are no particularly large improvements here, but our own lazy cell is definitely unsafe in theory, because of potential reentrancy in `get_or_try_init`, and the one from crates.io does not have at least this hole :-)
Note that `rustc` already has `lazycell` in its Cargo.lock (because of clippy I guess?), albeit with a lower version, 0.5.
bors [Mon, 12 Feb 2018 20:53:27 +0000 (20:53 +0000)]
Auto merge of #5031 - matthiaskrgr:readme_docs, r=alexcrichton
readme: add link to the cargo documentation on docs.rs
[Rendered](https://github.com/matthiaskrgr/cargo/blob/readme_docs/README.md)
Background: I was searching for cargo source code doc a while back, found the cargo book and crates.io doc relatively quickly but not the actual source code doc which I only found (after way to much time had passed) when I looked up the cargo crate on crates.io and found the "Documentation" link :/
Hope this improves the situation a bit in the future.
Matthias Krüger [Mon, 12 Feb 2018 18:27:45 +0000 (19:27 +0100)]
readme: add link to the cargo documentation on docs.rs
Aleksey Kladov [Mon, 12 Feb 2018 17:00:59 +0000 (20:00 +0300)]
Switch `cargo new` default to `--bin`
Aleksey Kladov [Mon, 12 Feb 2018 18:33:31 +0000 (21:33 +0300)]
Switch to lazycell from crate.io
bors [Mon, 12 Feb 2018 17:53:00 +0000 (17:53 +0000)]
Auto merge of #5030 - alexcrichton:better-poll, r=matklad
Don't spin on empty fds in `read2` on Unix
This commit fixes what I think is some pathological behavior in Cargo where if
one stdio stream is closed before another then Cargo can accidentally spin in a
tight loop and not block appropriately. Previously, for example, if stderr
closed before stdout then Cargo would spin in a `poll` loop continuously getting
notified that stderr is closed.
The behavior is now changed so after a file descriptor is done we stop passing
it to `poll` and instead only pass the one remaining readable file descriptor.
Alex Crichton [Mon, 12 Feb 2018 17:27:11 +0000 (09:27 -0800)]
Don't spin on empty fds in `read2` on Unix
This commit fixes what I think is some pathological behavior in Cargo where if
one stdio stream is closed before another then Cargo can accidentally spin in a
tight loop and not block appropriately. Previously, for example, if stderr
closed before stdout then Cargo would spin in a `poll` loop continuously getting
notified that stderr is closed.
The behavior is now changed so after a file descriptor is done we stop passing
it to `poll` and instead only pass the one remaining readable file descriptor.
Aleksey Kladov [Mon, 12 Feb 2018 16:57:31 +0000 (19:57 +0300)]
Refactor `NewOptions` to make it slightly more clear
Aleksey Kladov [Mon, 12 Feb 2018 16:31:48 +0000 (19:31 +0300)]
Cleanup
bors [Fri, 9 Feb 2018 18:50:24 +0000 (18:50 +0000)]
Auto merge of #5025 - Eh2406:error_mesges, r=alexcrichton
better resolver error messages
This is a start on beter resolver error messages. This is mostly trying to copy the `links` messages. In the process I found that we wor not testing the common case of having found candidates and still not resolving.
Any advice?
Eh2406 [Wed, 7 Feb 2018 16:51:40 +0000 (11:51 -0500)]
better error messages
bors [Fri, 9 Feb 2018 00:22:00 +0000 (00:22 +0000)]
Auto merge of #5024 - debris:helpful_message, r=alexcrichton
Add helpful message when running cargo doc --open
Add helpful message when running cargo doc --open in the root of the workspace.
closes #4962
old output:
```
Documenting foo v0.1.0 (file:///Users/marek/projects/ethcore/tmp/dupa/foo)
Documenting bar v0.1.0 (file:///Users/marek/projects/ethcore/tmp/dupa/bar)
Finished dev [unoptimized + debuginfo] target(s) in 0.78 secs
error: Passing multiple packages and `open` is not supported
```
new output:
```
Documenting foo v0.1.0 (file:///Users/marek/projects/ethcore/tmp/dupa/foo)
Documenting bar v0.1.0 (file:///Users/marek/projects/ethcore/tmp/dupa/bar)
Finished dev [unoptimized + debuginfo] target(s) in 0.81 secs
error: Passing multiple packages and `open` is not supported.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
foo
bar
```
debris [Thu, 8 Feb 2018 21:50:35 +0000 (22:50 +0100)]
Add helpful message when running cargo doc --open in the root of the workspace, fixes #4962
Eh2406 [Wed, 7 Feb 2018 22:50:03 +0000 (17:50 -0500)]
generalize the path_to_top from the links errors
Eh2406 [Wed, 7 Feb 2018 22:45:02 +0000 (17:45 -0500)]
test for the most common cargo resolver error
bors [Wed, 7 Feb 2018 23:11:35 +0000 (23:11 +0000)]
Auto merge of #5020 - stefanbirkner:linkfix, r=alexcrichton
Fix link to documentation
Stefan Birkner [Sat, 3 Feb 2018 21:48:24 +0000 (22:48 +0100)]
Fix link to documentation
bors [Wed, 7 Feb 2018 02:06:13 +0000 (02:06 +0000)]
Auto merge of #5018 - brotzeit:clippy, r=alexcrichton
apply clippy suggestions
I want to try if this actually works =)
There are many other clippy suggestions. I wonder if I can take them for granted or if some of them would be refused.
For example:
```
warning: Constants have by default a `'static` lifetime
--> src/cargo/lib.rs:53:23
|
53 | pub const CARGO_ENV: &'static str = "CARGO";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= note: #[warn(const_static_lifetime)] on by default
= help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.185/index.html#const_static_lifetime
```
brotzeit [Tue, 6 Feb 2018 21:49:50 +0000 (22:49 +0100)]
apply clippy suggestions
bors [Tue, 6 Feb 2018 18:27:28 +0000 (18:27 +0000)]
Auto merge of #5011 - Manishearth:stealing-chickens-off-the-internet, r=alexcrichton
Implement RFC 2052: Epoches
Todo:
- Make epoches affect the fingerprint
- Tests
cc https://github.com/rust-lang/rust/issues/44581
Rust PR: https://github.com/rust-lang/rust/pull/48014
r? @acrichto
Manish Goregaokar [Tue, 6 Feb 2018 17:33:30 +0000 (09:33 -0800)]
epoch -> rust
bors [Tue, 6 Feb 2018 17:33:20 +0000 (17:33 +0000)]
Auto merge of #5017 - matthiaskrgr:manifest_cgu_lto, r=alexcrichton
manifest reference: correct statement: codegen-units=x is not ignored if lto=true.
Also fix typo along the way.
bors [Tue, 6 Feb 2018 17:05:37 +0000 (17:05 +0000)]
Auto merge of #4834 - aidanhs:aphs-better-backtrack, r=alexcrichton
Make resolution backtracking smarter
There's no need to try every candidate for every dependency when backtracking - instead, only try candidates if they *could* change the eventual failure that caused backtracking in the first place, i.e.
1. if we've backtracked past the parent of the dep that failed
2. the number of activations for the dep has changed (activations are only ever added during resolution I believe)
The two new tests before:
```
$ /usr/bin/time cargo test --test resolve -- --test-threads 1 --nocapture resolving_with_constrained_sibling_
Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
Running target/debug/deps/resolve-
19b2a13e5a19eed8
38.45user 2.16system 0:42.00elapsed 96%CPU (0avgtext+0avgdata 47672maxresident)k
0inputs+1664096outputs (0major+10921minor)pagefaults 0swaps
```
After:
```
$ /usr/bin/time cargo test --test resolve -- --test-threads 1 --nocapture resolving_with_constrained_sibling_
Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
Running target/debug/deps/resolve-
19b2a13e5a19eed8
[...]
0.36user 0.01system 0:00.49elapsed 76%CPU (0avgtext+0avgdata 47464maxresident)k
0inputs+32outputs (0major+11602minor)pagefaults 0swaps
```
You observe the issue yourself with the following (it should fail, but hangs for a while instead - I didn't bother timing it and waiting for it to finish. With this PR it terminates almost instantly):
```
$ cargo new --bin x
Created binary (application) `x` project
$ /bin/echo -e 'serde = "=1.0.9"\nrust-s3 = "0.8"' >> x/Cargo.toml
$ cd x && cargo build
Updating registry `https://github.com/rust-lang/crates.io-index`
Resolving dependency graph...
```
Matthias Krüger [Tue, 6 Feb 2018 12:27:56 +0000 (13:27 +0100)]
manifest reference: correct statement: codegen-units=x is not ignored if lto=true.
Also fix typo along the way.
bors [Tue, 6 Feb 2018 06:08:23 +0000 (06:08 +0000)]
Auto merge of #5013 - withoutboats:no-rust-rename, r=matklad
Do not rename packages on `cargo new`.
Prior to this commit, packages beginning with `rust` or ending with
`rs` were renamed automatically when created, unless they were
binaries. The ostensible purpose of this code was to avoid people
uploading "redundant" names to crates.io, which is a repository of
Rust packages.
This behavior was overly opinionated. It is not cargo's
responsibility to discourage users from naming their packages any
particular way. Without a sound technical reasons why packages
cannot be named a certain way, cargo should not be intervening in
users' package naming decisions.
It also did this by automatically renaming the package for the
user, as opposed to erroring. Though it printed a message about
the behavior, it did not give the user a choice to abort the
process; to overrule cargo they had to delete the new project
and start again using the `--name` argument.
`cargo new` is many users' first entrypoint to the Rust ecosystem.
This behavior teaches a user that Rust is opinionated and magical,
both of which are divisive attributes for a tool, and attributes
which do not generally describe Rust's attitude toward things like
names and formatting.
If crates.io wishes to enforce that users not upload packages with
names like this, it should be enforced by crates.io at publish
time.
Manish Goregaokar [Mon, 5 Feb 2018 21:42:42 +0000 (16:42 -0500)]
Add tests for epoch
Manish Goregaokar [Mon, 5 Feb 2018 21:21:40 +0000 (16:21 -0500)]
Include the epoch in the fingerprint