Jocelyn Turcotte [Tue, 4 Jul 2017 14:43:17 +0000 (16:43 +0200)]
SocketApi: Adjust the format of the mailto: URL
Minor tweaks that weren't actually an issue, but just in case.
Jocelyn Turcotte [Tue, 4 Jul 2017 14:41:40 +0000 (16:41 +0200)]
SocketApi: Improve logging
Christian Kamm [Wed, 10 May 2017 07:37:10 +0000 (09:37 +0200)]
Introduce private link sharing #5023
* SocketAPI has COPL_LOCAL_LINK / EMAIL_LOCAL_LINK commands
* The nautilus and dolphing shell integrations show a submenu from which
one can share as well as access the private link.
* The SocketAPI provides a new GET_STRINGS command to access localized
strings.
* The private link can also be accessed from the user/group sharing
dialog.
* The numeric file id is extracted from the full id to create the
private link url.
Christian Kamm [Thu, 6 Jul 2017 11:43:34 +0000 (13:43 +0200)]
Fix crash on account deletion
Calling forgetSensitiveData() on account deletion leads to a timer for
clearQNAMCache() being queued. Then the Account object is deleted. The
Credentials object stays alive for now because it has a deleteLater
deleter.
If the timer calls into a slot on the Credentials object, the _account
pointer will be invalid at this time.
As a workaround, move the target slot to Account - that way it will not
be called as the account object is already destroyed.
However since Account and Credentials are mutually dependent, it would
be much preferable if their lifetimes were linked, avoiding this
category of bugs.
The current behavior was introduced in
d40c56eda561e3a541bf1b23f70fa8d659d3037e and I currently don't
understand why - maybe there's another way of dealing with the problem
that existed then.
ckamm [Tue, 4 Jul 2017 12:08:41 +0000 (14:08 +0200)]
Add a more functional error view #5516 (#5861)
* Add a more functional error view #5516
* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".
* Change mouse cursor to hand over button and new error list area
Several OSX fixes provided by guruz.
Christian Kamm [Tue, 4 Jul 2017 10:23:23 +0000 (12:23 +0200)]
AccountState: Add a 1-5min reconnection delay #5872
This only applies when the server was explicitly in maintenance mode or
when it was 503-unavailable.
Christian Kamm [Tue, 27 Jun 2017 12:17:26 +0000 (14:17 +0200)]
Blacklist: Don't let errors become warnings #5516
Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.
Olivier Goffart [Tue, 4 Jul 2017 08:55:41 +0000 (10:55 +0200)]
main.cpp: Fix a compiler warning
src/gui/main.cpp:112:9: warning: bool literal returned from 'main' [-Wmain]
Used 1 to keep previous behaviour. I supposed the code was meant
to return success (0), but it does not really matter anyway.
Christian Kamm [Tue, 4 Jul 2017 07:57:22 +0000 (09:57 +0200)]
SyncEngineTest: Fix test reliability
There was a rounding issue in the mtimes which sometimes resulted in an
off-by-one error. Caused by storing a full QDateTime in the FileInfo but
the mtime saved to the disk being truncated to seconds.
Olivier Goffart [Mon, 3 Jul 2017 15:24:56 +0000 (17:24 +0200)]
Fix check_csync_update
Commit
816096311027bac0f391ea97d0b61b4175e9b8f9 changed the
SQL requests from csync to read from the checksumtype table.
So we need to add this table in the fake DB as well
Olivier Goffart [Mon, 3 Jul 2017 14:42:31 +0000 (16:42 +0200)]
Fix check_csync_exclude test
Commit
4697f0274f282cafd28cbad07066efb397dbf21b remove .htaccess from
the sync-exclude.lst, so use another known excluded pattern
Piotr Mrowczynski [Tue, 20 Jun 2017 18:27:26 +0000 (20:27 +0200)]
Classify chunked items correctly. Issue #5850
Christian Kamm [Mon, 3 Jul 2017 11:16:29 +0000 (13:16 +0200)]
csync tests: remove stray 'print'
Christian Kamm [Wed, 28 Jun 2017 09:15:22 +0000 (11:15 +0200)]
SyncEngine: Add unittest for SyncFileItem properties #5855
Checks instruction, direction, size, modtime for three common cases.
Christian Kamm [Mon, 3 Jul 2017 09:48:04 +0000 (11:48 +0200)]
csync tests: Fix for new owncloudcmd return codes
These were introduced in
4af45394f9f61fbc68c9f0a4d2e5387d14052e3b
Samuel Alfageme [Wed, 28 Jun 2017 10:28:07 +0000 (12:28 +0200)]
Update central.owncloud.org link
Desktop client category was renamed, old link was 404 - see: https://central.owncloud.org/t/new-central-categories-you-decide
Markus Goetz [Thu, 22 Jun 2017 13:42:56 +0000 (15:42 +0200)]
Jenkinsfile: Some comments
Markus Goetz [Thu, 22 Jun 2017 13:11:27 +0000 (15:11 +0200)]
CSyncSqliteTest: Fix test
Markus Goetz [Thu, 22 Jun 2017 13:09:28 +0000 (15:09 +0200)]
test_journal.db: Add checksumtype table
Christian Kamm [Thu, 22 Jun 2017 12:06:31 +0000 (14:06 +0200)]
Merge remote-tracking branch 'origin/2.3'
Jenkins for ownCloud [Thu, 22 Jun 2017 00:22:09 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Wed, 21 Jun 2017 13:02:26 +0000 (15:02 +0200)]
Jenkinsfile: Compile in debug because of all the asserts
Markus Goetz [Wed, 21 Jun 2017 13:02:26 +0000 (15:02 +0200)]
Jenkinsfile: Compile in debug because of all the asserts
Markus Goetz [Wed, 21 Jun 2017 10:18:21 +0000 (12:18 +0200)]
Jenkinsfile: Run verbose tests
Markus Goetz [Wed, 21 Jun 2017 10:12:08 +0000 (12:12 +0200)]
Jenkinsfile: Run full testing
Markus Goetz [Wed, 21 Jun 2017 10:12:08 +0000 (12:12 +0200)]
Jenkinsfile: Run full testing
Markus Goetz [Wed, 21 Jun 2017 09:59:24 +0000 (11:59 +0200)]
Jenkinsfile: 2.3.3 will ship with Qt 5.
This should fix the current CI run too
Markus Goetz [Wed, 21 Jun 2017 08:01:32 +0000 (10:01 +0200)]
owncloudcmd: Explain --debug parameter
Jenkins for ownCloud [Wed, 21 Jun 2017 00:22:08 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Christian Kamm [Mon, 19 Jun 2017 08:48:19 +0000 (10:48 +0200)]
Ignore ui: Add the sync journal patterns #5844
The ignore patterns for the journal files are hardcoded. Add them to
the UI to make them discoverable.
Christian Kamm [Fri, 16 Jun 2017 13:43:21 +0000 (15:43 +0200)]
Journal: Don't use a ._ path if it won't work #5633
When synchronizing a folder on a samba share, creating files that begin
with ._ is often forbidden. This prevented the client from creating
its ._sync_abcdef.db file.
Now, it'll check whether the preferred filename is creatable, and if
it isn't it'll use .sync_abcdef.db instead.
The disadvantage is that this alternative path won't be ignored by
older clients - that was the reason for the ._ prefix.
Jenkins for ownCloud [Tue, 20 Jun 2017 00:22:12 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Wed, 14 Jun 2017 12:17:50 +0000 (14:17 +0200)]
shell/Windows: Update binaries to build 45
Frederik Juul Christiani [Tue, 13 Jun 2017 09:23:08 +0000 (11:23 +0200)]
shell_integration/windows: Create _newQueries as a non-signaled auto-reset event.
Since ResetEvent() is never called, the call to WaitForMultipleObjects()
can always return immediately once the event has been signaled.
Frederik Juul Christiani [Tue, 13 Jun 2017 08:28:12 +0000 (10:28 +0200)]
Initialize stop variable.
Avoid stopping the worker thread immediately if the stop variable happens to be true.
Jenkins for ownCloud [Mon, 19 Jun 2017 00:22:08 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 18 Jun 2017 00:22:08 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 17 Jun 2017 00:22:17 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Thu, 15 Jun 2017 18:10:30 +0000 (20:10 +0200)]
Remove debug messages by default from sync.engine
Other categories were already set properly.
Christian Kamm [Wed, 14 Jun 2017 10:14:46 +0000 (12:14 +0200)]
Compare the hash of files with identical mtime/size #5589
* For conflicts where mtime and size are identical:
a) If there's no remote checksum, skip (unchanged)
b) If there's a remote checksum that's a useful hash, create a
PropagateDownload job and compute the local hash. If the hashes
are identical, don't download the file and just update metadata.
* Avoid exposing the existence of checksumTypeId beyond the database
layer. This makes handling checksums easier in general because they
can usually be treated as a single blob.
This change was prompted by the difficulty of producing file_stat_t
entries uniformly from PROPFINDs and the database.
Christian Kamm [Wed, 14 Jun 2017 10:03:40 +0000 (12:03 +0200)]
SyncEngineTest: Add network override
This is useful for monitoring what kind of network requests are
sent to the fake server. Such as "did this sync cause an upload?"
and "was there a propfind for this path?". It can also inject
custom replies.
Christian Kamm [Wed, 14 Jun 2017 10:03:10 +0000 (12:03 +0200)]
SyncEngineTest: Send 'checksums' in FakePropfind
Christian Kamm [Wed, 14 Jun 2017 10:01:32 +0000 (12:01 +0200)]
SyncEngineTest: Fix date locale related bug
The client is very picky about date strings it accepts. If dates are
formatted with a non-C locale (such as localized weekday names), it
fails to parse it and tests fail in subtle ways.
Jocelyn Turcotte [Wed, 14 Jun 2017 12:17:50 +0000 (14:17 +0200)]
shell/Windows: Update binaries to build 45
Frederik Juul Christiani [Tue, 13 Jun 2017 09:23:08 +0000 (11:23 +0200)]
shell_integration/windows: Create _newQueries as a non-signaled auto-reset event.
Since ResetEvent() is never called, the call to WaitForMultipleObjects()
can always return immediately once the event has been signaled.
Frederik Juul Christiani [Tue, 13 Jun 2017 08:28:12 +0000 (10:28 +0200)]
Initialize stop variable.
Avoid stopping the worker thread immediately if the stop variable happens to be true.
Olivier Goffart [Tue, 13 Jun 2017 11:49:26 +0000 (13:49 +0200)]
AccountSettings: Triggering log in re-ask about previously rejected certificates #5819
Issue #5819
Jenkins for ownCloud [Wed, 14 Jun 2017 00:22:19 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 13 Jun 2017 08:24:26 +0000 (10:24 +0200)]
OAuth: cleanup debug messages
- Add category to the all messages (they did not have it was merged right after
the patch to add category everywhere, but this code did not have it.)
- Make sure there is no warnings in the normal flow. (The wizard does a request
without authentication to determine the auth type)
Olivier Goffart [Tue, 13 Jun 2017 07:58:20 +0000 (09:58 +0200)]
Don't link dirrectly against openssl
All our crypto code is handled by qt nodaways.
No need to carry this dependency.
Especially since it causes warnings on system where there are
twp openssl version installed:
/usr/bin/ld: warning: libcrypto.so.1.0.0, needed by /usr/lib/libQt5Network.so.5.9.0, may conflict with libcrypto.so.1.1
Markus Goetz [Mon, 12 Jun 2017 16:46:57 +0000 (18:46 +0200)]
Update ChangeLog
Christian Kamm [Mon, 12 Jun 2017 09:50:36 +0000 (11:50 +0200)]
OAuth: Fix a typo in the success message
Olivier Goffart [Wed, 7 Jun 2017 14:49:38 +0000 (16:49 +0200)]
Wizard: Don't let the second to last page go back with OAuth2
We don't want to re-open the browser in that case.
Olivier Goffart [Wed, 7 Jun 2017 14:19:34 +0000 (16:19 +0200)]
OAuth: Error handling in the wizard
Issues: #5813 and #5811
Jenkins for ownCloud [Fri, 9 Jun 2017 00:22:10 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 6 Jun 2017 14:00:41 +0000 (16:00 +0200)]
SyncEngine: SelectiveSync: Remove local files of undelected folder despite other modified files
Issue #5783
When the directry that should be removed by selective sync contains changes,
we ignore the whole sub tree instead of only ignoreing new files.
We cannot ignore the whole directory, we need to ignore only the directory
that do not have files to remove
Christian Kamm [Thu, 8 Jun 2017 11:02:34 +0000 (13:02 +0200)]
Merge branch '2.3'
Olivier Goffart [Tue, 6 Jun 2017 12:45:27 +0000 (14:45 +0200)]
ownsql: fix build on jenkins
sqlite3_system_errno was only added in sqlite 3.12
(cherry picked from commit
e2e56f45af059299d942f237ecf9cefbba0c43be)
Christian Kamm [Tue, 6 Jun 2017 10:59:57 +0000 (12:59 +0200)]
Add extra logging for SQLITE_CANTOPEN errors #5633
(cherry picked from commit
05c1dcef9b35a18d358ab307922eceff312e3304)
Jenkins for ownCloud [Thu, 8 Jun 2017 00:22:10 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 7 Jun 2017 00:22:13 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 6 Jun 2017 12:19:24 +0000 (14:19 +0200)]
OAuth: Fix the secret to the one from commit
05fd985f9f in the oauth2 repository
https://github.com/owncloud/oauth2/commit/
05fd985f9fb58d7d2305ce2db6fe24fe6fc08c79
Olivier Goffart [Mon, 29 May 2017 11:00:43 +0000 (13:00 +0200)]
FolderStatusModel: fix assert in Qt when the list of subfolder is empty
Fix an assert that happens in beginInsertRows when opening a folder
and that folder is empty.
This can only be reproduced with a debug build of Qt.
Olivier Goffart [Tue, 6 Jun 2017 12:45:27 +0000 (14:45 +0200)]
ownsql: fix build on jenkins
sqlite3_system_errno was only added in sqlite 3.12
Christian Kamm [Tue, 6 Jun 2017 10:59:57 +0000 (12:59 +0200)]
Add extra logging for SQLITE_CANTOPEN errors #5633
Christian Kamm [Tue, 6 Jun 2017 08:45:15 +0000 (10:45 +0200)]
Fix maintenance mode detection #5755
The server sends "maintenance": "true" which isn't a json boolean...
Jenkins for ownCloud [Mon, 5 Jun 2017 00:22:03 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 3 Jun 2017 00:22:02 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 2 Jun 2017 00:22:13 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 28 Mar 2017 08:31:38 +0000 (10:31 +0200)]
Authentication with OAuth2
When the OAuth2 app (https://github.com/owncloud/oauth2) is enabled,
We will open a browser and perform the OAuth2 authentication
Issue: #4798 and https://github.com/owncloud/platform/issues/17
Markus Goetz [Thu, 1 Jun 2017 08:37:01 +0000 (10:37 +0200)]
ChangeLog: More things that were done until now
Julius Härtl [Mon, 27 Mar 2017 09:12:28 +0000 (11:12 +0200)]
Set proper application name, icon name for freedesktop notifications
Use application name defined in OEM build configuration
Jenkins for ownCloud [Wed, 31 May 2017 00:22:17 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Mon, 22 May 2017 15:54:57 +0000 (17:54 +0200)]
Application: debug implies logdebug
Dominik Schmidt [Fri, 26 May 2017 11:25:43 +0000 (13:25 +0200)]
Remove obsolete FindQtKeychain for Qt4
Dominik Schmidt [Fri, 26 May 2017 11:24:54 +0000 (13:24 +0200)]
Fix build on Debian 7 (CMake pre 2.8.12)
Christian Kamm [Mon, 29 May 2017 10:05:22 +0000 (12:05 +0200)]
Download: Retrigger folder discovery on 404
See owncloud/enterprise#1966
If the server and the client's database go out of sync, there could be
persistent 404 errors. This change ensures that the problem corrects
itself eventually by triggering a remote discovery of the file's
parent folders.
It does not address the root cause that might have lead to the
divergence.
Olivier Goffart [Mon, 29 May 2017 08:48:21 +0000 (10:48 +0200)]
Don't call QElapsedTimer::restart on uninitialized timer
That's an undefined behavior.
Since we don't use the return value anyway, we should just use start()
Jenkins for ownCloud [Thu, 25 May 2017 00:22:08 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 24 May 2017 00:22:16 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 23 May 2017 00:22:15 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Christian Kamm [Mon, 22 May 2017 12:41:06 +0000 (14:41 +0200)]
Sharing: Disable 'set password' button when password is empty #5788
Christian Kamm [Mon, 22 May 2017 12:15:53 +0000 (14:15 +0200)]
Share dialog: Use default icon if available #5781
Christian Kamm [Thu, 18 May 2017 09:39:13 +0000 (11:39 +0200)]
Share link: Fix disabled API/sharing #5778
* Don't hide the displayed error directly after showing it
* Don't try to fetch shares when sharing isn't possible
Christian Kamm [Thu, 18 May 2017 08:26:12 +0000 (10:26 +0200)]
Share Dialog: Remove unused hline
Christian Kamm [Thu, 18 May 2017 10:41:28 +0000 (12:41 +0200)]
Share link: Fix parsing integer ids #5777
Older ownCloud servers like 8.2.0 used to use integer ids.
This broke when switching to QJson because toString() on JSON
values is strict and returns "" for integers.
Christian Kamm [Fri, 19 May 2017 07:49:24 +0000 (09:49 +0200)]
Sharing dialog: Ensure error labels are expanding #5774
Christian Kamm [Fri, 19 May 2017 07:48:47 +0000 (09:48 +0200)]
Share dialog: Hide the icon when unused
Previously this used up some space when there was no icon, leading
to an oddly indented header.
Christian Kamm [Thu, 27 Apr 2017 11:58:26 +0000 (13:58 +0200)]
Credentials: Simplify credential flow #5728
And as a side effect: don't ask for user password when we can't
connect to the server in the first place.
Christian Kamm [Mon, 22 May 2017 07:32:11 +0000 (09:32 +0200)]
Account: forget credentials on delete #5752
Christian Kamm [Mon, 22 May 2017 07:13:23 +0000 (09:13 +0200)]
Sharing: Show warning that link shares are public #5785 #5747
Backport of
3872e060ba33913e43714776a1afce787e772351
Christian Kamm [Mon, 22 May 2017 08:10:12 +0000 (10:10 +0200)]
Settings: Ensure the 'about' label isn't cut off #5760
Christian Kamm [Mon, 22 May 2017 08:00:28 +0000 (10:00 +0200)]
Merge branch '2.3'
Christian Kamm [Mon, 22 May 2017 07:59:13 +0000 (09:59 +0200)]
mirall.desktop.in: Remove superfluous lines #5767
Jenkins for ownCloud [Mon, 22 May 2017 00:22:15 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 21 May 2017 00:22:14 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 20 May 2017 00:22:15 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 19 May 2017 23:18:15 +0000 (01:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 19 May 2017 00:22:22 +0000 (02:22 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 18 May 2017 00:22:27 +0000 (02:22 +0200)]
[tx-robot] updated from transifex