Fix localisation of updater status strings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Properly handle skipping auto update checks in the sparkle updater

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Only instantiate sparkle updater if autoupdating is available

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix qbytearray related clazy warnings in objective-c++ sparkle updater side

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Only enable check for update button when the sparkle updater is not working

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Implement proper notifying of sparkle updater state changes

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Also record sparkle updater state

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Properly display status string for changes in updater

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability for sparkle updater to notify UI when state has changed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add q pointer to SparkleInterface

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Replace private class with an interfacing class to bridge Obj-C delegate class and owner CPP class

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Name sparkle updater delegate more reasonably

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use std::unique_ptr in sparkle updater class rather than manual management

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5912 from nextcloud/bugfix/fix-msvc-sharemodel-build

Fix build of sharemodel.cpp on MSVC

Fix build of sharemodel.cpp on MSVC

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5698 from nextcloud/feature/trashfiles

Add option to move deleted files to trash instead of permanently deleting them

Add checkbox to general settings to enabling file removal meaning moving files to trash, rather than immediate deletion

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Replace custom moveToTrash solution with Qt QFile::moveToTrash

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #5666 from nextcloud/bugfix/svg-provider-error-fix

Fix SVG rendering error in SvgImageProvider

Remove empty statement, standalone semicolon

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Extract custom color svg image finding into separate function

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Simplify findSvgFilePath, define result value on definition

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #5717 from nextcloud/bugfix/better-password-gen

Fix password generation for shares, improve generator

Simplify loop to write bytes to password

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use std::array to store hash bytes

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Replace use of std::rand with improved C++11 random

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Guarantee that the generated password for share will have all the types of characters needed to pass server check

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Simplify password generation in sharemodel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Generate better passwords for shares

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #5659 from nextcloud/bugfix/expire-date-set-share-view

Fix expire date field in Share settings

Track invalid input in ShareDetailsPage expireDateSpinBoxTextField

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability for NCInputTextField to display red border when invalid input provided

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ensure the text for the expire date spin box is updated even in situations when the expire date is forced back down to the same one being currently held

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make sure to imperatively set text for spinbox textfield after user breaks binding by editing

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Rename "moreMenu" ColumnLayout to "scrollContentsColumn" in ShareView, stop treating like menu which it used to be

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #5890 from m7913d/fixCantUpdateNonExistingPlaceholder

Create placeholder while dehydrating if needed

Create placeholder while dehydrating if needed

When replacing an OnlineOnly file by another one, the file maintains it
OnlineOnly pin state, but it is converted to a regular file. So, the
dehydration should convert the regular file to a (dehydrated)
placeholder instead of trying to update the (non-existing) placeholder.

Closes #4274

Signed-off-by: Dries Mys <dries.mys@my-dreams.be>

Merge pull request #5853 from m7913d/ignoredFilesExcludedPinState

Set VFS PinState to Excluded for ignored files.

Small coding improvements

Signed-off-by: Dries Mys <dries.mys@my-dreams.be>

Remove warning when querying pin state on non-placeholder file

F.ex. Folder::slotWatchedPathChanged calls this function on non-
placeholder files to check if the ignored file is already assigned an
Excluded pin state. Note that it is allowed to set the pin state to
Excluded on non-placeholder files.

Signed-off-by: Dries Mys <dries.mys@my-dreams.be>

Set VFS PinState to Excluded for ignored files.

Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes #5524
Closes #5594

Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5885 from nextcloud/bugfix/sharing-api-disabled-share-view

Disable share view completely when server does not support/has disabled file sharing

Swap folder nullness assert for return

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Compress share page tab button width and height when sharing API is disabled

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make swipeIndex properties readonly

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix background of tabbar in file details page

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not handle setting page to sharing page if sharing not available

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not display sharing entry if sharing is not available on server

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Set sharingAvailable property in FileDetails from Folder account capabilities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add sharingAvailable property to FileDetails class

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #4977 from tomdereub/patch-1

windows reserved word silently excluded - csync exclude.cpp

Adapt test 2

Signed-off-by: tomdereub <pbtom@lamonerie.net>

Adapt test to silent exclusion

Signed-off-by: tomdereub <pbtom@lamonerie.net>

windows reserved word silently excluded - csync exclude.cpp

Proposal to solve https://github.com/nextcloud/desktop/issues/3826, by excluding silently windows reserved word like $RECYCLE.BIN.

Signed-off-by: tomdereub <pbtom@lamonerie.net>

Merge pull request #5879 from nextcloud/bugfix/fix-incorrect-seen-chat-notifications-removal

Fix crash and incorrect implementation of seen chat notofications removal

try to force use of python 3.8 for windows as required by craft

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix crash in _finalList removal loop. Fix incorrect implementation of seen chat notifications removal. Improved notifications fetch code to avoid multiple calls from different threads.

Signed-off-by: alex-z <blackslayer4@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5848 from nextcloud/feature/detect-captive-portal

Added new state and new job to check if /index.php/204 is being redirected

Added new state and new job to check if /index.php/204 is being redirected.

Signed-off-by: alex-z <blackslayer4@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5886 from nextcloud/ci/sign-drone-master

chore(CI): Sign .drone.yml file

chore(CI): Sign .drone.yml file

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5841 from nextcloud/bugfix/lockedFileShouldBeReadOnly

always propagate locked status to read-only or read/write for real file

set read only/read file on the newly downloaded file

will fix behavior on windows by properly setting the new temp file just
downloaded have the proper state (read only or read/write) and not the
already existing file that will be replaced by the newly odwnloaded one

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix failing tests by using FileSystem::setFileReadOnlyWeak

we try to preserve complex existing permissions unless the client is
required to change them significantly

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

enable debug log for some automated tests

should help investigate failure for automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

always propagate locked status to read-only or read/write for real file

make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5864 from nextcloud/addLinkToBinaries

add link in readme to nextcloud-releases correct page with binaries

add link in readme to nextcloud-releases correct page with binaries

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #5871 from nextcloud/bugfix/bulkUploadEmptyFiles

fix bulk upload of empty files

do not use a mirror for KDE's Craft binary cache

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix bulk upload of empty files

force an empty body when we bulk upload empty files

force a "valid" checksum to be computed for empty files as bulk upload
server side expects a checksum even for empty files

Close #5824

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5851 from nextcloud/feature/remove-seen-talk-notifications

Remove seen Talk notificatios from Tray window.

Remove seen Talk notificatios from Tray window.

Signed-off-by: alex-z <blackslayer4@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #5586 from nextcloud/bugfix/e2eeBetterInit

Bugfix/e2ee better init

fix review comments

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

improve logs of e2ee such that errors are easy to see

removed some internal debug logs that should not be needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

make sure to pass shared pointer by const ref when possible

avoid unnecessary copies of shared pointers

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

make sure we clean only what is needed if e2ee is disabled

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

tidy code

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>