git-annex.git
5 years agoRemoved the S3 and WebDAV build flags
Joey Hess [Tue, 8 Sep 2020 16:42:59 +0000 (12:42 -0400)]
Removed the S3 and WebDAV build flags

So these special remotes are always supported.

IIRC these build flags were added because the dep chains were a bit too
long, or perhaps because the libraries were not available in Debian stable,
or something like that. That was long ago, those reasons no longer apply,
and users get confused when builtin special remotes are not available, so
it seems best to remove the build flags now.

If this does cause a problem it can be reverted of course..

This commit was sponsored by Jochen Bartl on Patreon.

5 years agocomment
Joey Hess [Tue, 8 Sep 2020 16:31:37 +0000 (12:31 -0400)]
comment

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 8 Sep 2020 16:26:12 +0000 (12:26 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agoavoid failure when gpgconf is not in path
Joey Hess [Tue, 8 Sep 2020 16:21:24 +0000 (12:21 -0400)]
avoid failure when gpgconf is not in path

5 years agofollowup
Joey Hess [Tue, 8 Sep 2020 16:17:08 +0000 (12:17 -0400)]
followup

5 years agoAdded a comment: Unknown remote type webdav
git@3af0a87771c4b55bee8a599b934914cd98d4bc0b [Tue, 8 Sep 2020 13:19:51 +0000 (13:19 +0000)]
Added a comment: Unknown remote type webdav

5 years agoresolvemerge: Improve cleanup of cruft left in the working tree by a conflicted...
Joey Hess [Mon, 7 Sep 2020 20:50:27 +0000 (16:50 -0400)]
resolvemerge: Improve cleanup of cruft left in the working tree  by a conflicted merge

This commit was sponsored by Jake Vosloo on Patreon.

5 years agoclean up old code
Joey Hess [Mon, 7 Sep 2020 20:16:15 +0000 (16:16 -0400)]
clean up old code

withworktree is no longer doing anything useful so remove it

5 years agorevert change that broke test suite
Joey Hess [Mon, 7 Sep 2020 19:41:16 +0000 (15:41 -0400)]
revert change that broke test suite

Opened a new bug about it.

This commit was sponsored by Ethan Aubin.

5 years agoimprove comment
Joey Hess [Mon, 7 Sep 2020 19:39:07 +0000 (15:39 -0400)]
improve comment

5 years agodevblog
Joey Hess [Mon, 7 Sep 2020 19:12:03 +0000 (15:12 -0400)]
devblog

5 years agoavoid build warning
Joey Hess [Mon, 7 Sep 2020 19:10:09 +0000 (15:10 -0400)]
avoid build warning

5 years agosync, assistant: When merge.directoryRenames is not set, default it it to "false"
Joey Hess [Mon, 7 Sep 2020 17:50:58 +0000 (13:50 -0400)]
sync, assistant: When merge.directoryRenames is not set, default it it to "false"

Works better with automatic merge conflict resolution than git's ususual
default of "conflict".

This is not done when automatic merge conflict resolution is disabled.

This commit was sponsored by Mark Reidenbach on Patreon.

5 years agorefactor
Joey Hess [Mon, 7 Sep 2020 17:26:16 +0000 (13:26 -0400)]
refactor

Make all calls to git merge go through autoMergeFrom, in preparation
for fine-tuning git merge's config for automatic merge conflict
resolution.

This commit was sponsored by Ryan Newton on Patreon.

5 years agoupdate comments
Joey Hess [Mon, 7 Sep 2020 17:03:51 +0000 (13:03 -0400)]
update comments

5 years agoresolvemerge: Improve cleanup of files that were deleted by one side of a conflicted...
Joey Hess [Mon, 7 Sep 2020 16:12:08 +0000 (12:12 -0400)]
resolvemerge: Improve cleanup of files that were deleted by one side of a conflicted merge, and modified by the other side

This case was handled by cleanConflictCruft, but only when the annexed
file's object was present. When not present, it left the annexed file
with the original name, not checked into git, while adding the variant
file. So, add an explicit deletion of the deleted file in this case.

My specific case where this happened actually involves
merge.directoryRenames=conflict. After a merge involving that,
the situation was the file appears as "added by them", because that
caused the file that they added to be moved into a directory we renamed.

That case is the same as them adding a modified version of the file,
while we deleted it. (Except for the history of the file, since it's a
new file, but this doesn't look at history.)

This commit was sponsored by Boyd Stephen Smith Jr. on Patreon.

5 years agomake automerge behavior when one side deleted explict
Joey Hess [Mon, 7 Sep 2020 16:01:03 +0000 (12:01 -0400)]
make automerge behavior when one side deleted explict

This does not actually change how the merge conflict is resolved when
one side deleted the file, but it was not documented before, and I think
it only worked by accident.

This commit was sponsored by Brett Eisenberg on Patreon.

5 years agomore
Joey Hess [Sun, 6 Sep 2020 14:51:23 +0000 (10:51 -0400)]
more

5 years agobug
Joey Hess [Sun, 6 Sep 2020 14:42:19 +0000 (10:42 -0400)]
bug

5 years agoupdate
Joey Hess [Sat, 5 Sep 2020 15:36:47 +0000 (11:36 -0400)]
update

5 years agoExposed annex.forward-retry git config
Joey Hess [Fri, 4 Sep 2020 19:16:40 +0000 (15:16 -0400)]
Exposed annex.forward-retry git config

One reason is, 5 is an arbitrary number so ought to be configurable.

The real reason though, is I wanted to make the man page explain when
forward retry can override annex.retry, and having a config made the
man page easier to write.

5 years agoimport: Retry downloads that fail
Joey Hess [Fri, 4 Sep 2020 17:49:57 +0000 (13:49 -0400)]
import: Retry downloads that fail

Also, using the transfer machinery for this makes eg, git-annex info show
in-progress imports, and makes --notify-start/finish work.

5 years agoRetry transfers to exporttree=yes remotes same as for other remotes
Joey Hess [Fri, 4 Sep 2020 17:23:33 +0000 (13:23 -0400)]
Retry transfers to exporttree=yes remotes same as for other remotes

The comment about noRetry is not well-justified, because transfers to many
remotes cannot be resumed, but retries are still allowed for those.

5 years agocombine retry deciders in better way
Joey Hess [Fri, 4 Sep 2020 16:47:53 +0000 (12:47 -0400)]
combine retry deciders in better way

This fixes the problem that, if forwardRetry was checked for the first 5
and decided to retry, the 6th would go to configuredRetry which would
see the counter was 6 and so wait retry-delay*2^5 seconds (default 32).

Now, it waits for retry-delay before each retry, even when forwardRetry
initiated the retry.

5 years agoLimit retrying of failed transfers when forward progress is being made to 5
Joey Hess [Fri, 4 Sep 2020 16:46:37 +0000 (12:46 -0400)]
Limit retrying of failed transfers when forward progress is being made to 5

To avoid some unusual edge cases where too much retrying could result in
far more data transfer than makes sense.

5 years agoremove unused isSymLink
Joey Hess [Wed, 2 Sep 2020 18:59:35 +0000 (14:59 -0400)]
remove unused isSymLink

That made Utility.FileMode depend on unix, but Utility.Tmp now depends
on it, and is used by Setup, which does not. So it was easiest to remove
this, especially since it's not used.

5 years agofix build
Joey Hess [Wed, 2 Sep 2020 18:59:22 +0000 (14:59 -0400)]
fix build

5 years agobetter dummy value
Joey Hess [Wed, 2 Sep 2020 18:54:46 +0000 (14:54 -0400)]
better dummy value

no need for empty string when it's going to be thrown away..

5 years agomake viaTmp honor umask
Joey Hess [Wed, 2 Sep 2020 18:54:07 +0000 (14:54 -0400)]
make viaTmp honor umask

Fixed several cases where files were created without file mode bits that
the umask would usually set. This included exports to the directory special
remote, torrent files used by the bittorrent special remote, hooks written
by git-annex init, and some log files in .git/annex/

Audited all calls, looking for ones that didn't want the umask bits to be
set. All such turned out to already set the specific restrictive file mode
they wanted.

5 years agomake removeAuthorizedKeys robust if the file DNE
Joey Hess [Wed, 2 Sep 2020 18:36:18 +0000 (14:36 -0400)]
make removeAuthorizedKeys robust if the file DNE

Noticed this could potentially crash, although the only thing using it
would normally create the file first, if something then deleted it..

5 years agofix some file modes in calls to withTmpFileIn to honor umask
Joey Hess [Wed, 2 Sep 2020 18:25:12 +0000 (14:25 -0400)]
fix some file modes in calls to withTmpFileIn to honor umask

Also audited for other calls to openTempFile, and all are ok,
except for viaTmp which will need further work.

Remote.Directory fixed to set umask mode when writing to an export,
although it has another one using viaTmp that's not fixed.
Will make exports that are published via a http server running as
another user work, for example.

Remote.BitTorrent fixed to set umask mode when downloading the torrent
file. Normally this does not matter as that file does not hang around
after the download, but if a bittorrent download were started by one user,
got interrupted and then another user ran it, this will let them access
the torrent file created by the first user.

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Wed, 2 Sep 2020 16:25:52 +0000 (12:25 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agobug report
Joey Hess [Wed, 2 Sep 2020 16:25:27 +0000 (12:25 -0400)]
bug report

5 years agodisplay actual download errors
Joey Hess [Wed, 2 Sep 2020 16:21:10 +0000 (12:21 -0400)]
display actual download errors

Eg, when config prohibits accessing localhost, need to show that
message, not a generic "download failed".

5 years agoavoid multiple download failed messages when learning
Joey Hess [Wed, 2 Sep 2020 16:01:50 +0000 (12:01 -0400)]
avoid multiple download failed messages when learning

Also only display one progress meter for all download attempts, to avoid
a bunch of blank lines.

5 years agofix example: meant to prune --force and include rest of output
kyle [Wed, 2 Sep 2020 15:51:49 +0000 (15:51 +0000)]
fix example: meant to prune --force and include rest of output

5 years agoAdded a comment: verifying source contents
Ilya_Shlyakhter [Wed, 2 Sep 2020 15:35:22 +0000 (15:35 +0000)]
Added a comment: verifying source contents

5 years agowhen downloading same content from multiple urls, only display error if all fail
Joey Hess [Wed, 2 Sep 2020 15:35:07 +0000 (11:35 -0400)]
when downloading same content from multiple urls, only display error if all fail

5 years agohttpalso: support exporttree=yes
Joey Hess [Wed, 2 Sep 2020 15:14:50 +0000 (11:14 -0400)]
httpalso: support exporttree=yes

Also tested what happens if the other special remote has importtree=yes
and exporttree=yes, and in that case, download via httpalso works too,
without needing to implement any importtree methods here.

It might be possible to make it automatically set exporttree=yes if the
--sameas does. Didn't try, will probably be layering issues.

Or perhaps it should be inherited by sameas like some
other configs? But then, wouldn't it also make sense to inherit
importree=yes? But as shown here, it's not needed by this kind of
remote.

5 years agorename http special remote to httpalso
Joey Hess [Wed, 2 Sep 2020 14:41:27 +0000 (10:41 -0400)]
rename http special remote to httpalso

"http" was too generic and easy to confuse with web. The new name makes
clear it's used in addition to some other remote. And other protocols
can use the same naming scheme.

5 years agocontent verification before transfer to special remote
kyle [Wed, 2 Sep 2020 14:02:37 +0000 (14:02 +0000)]
content verification before transfer to special remote

5 years ago(no commit message)
hans.ekbrand@aabd6f2f1f93eab77ef85618d24892ebafc6e20f [Wed, 2 Sep 2020 13:11:03 +0000 (13:11 +0000)]

5 years ago(no commit message)
hans.ekbrand@aabd6f2f1f93eab77ef85618d24892ebafc6e20f [Wed, 2 Sep 2020 13:10:31 +0000 (13:10 +0000)]

5 years ago(no commit message)
hans.ekbrand@aabd6f2f1f93eab77ef85618d24892ebafc6e20f [Wed, 2 Sep 2020 13:09:04 +0000 (13:09 +0000)]

5 years agoAdded a comment
yarikoptic [Wed, 2 Sep 2020 02:53:23 +0000 (02:53 +0000)]
Added a comment

5 years agoremove Show Cipher
Joey Hess [Tue, 1 Sep 2020 22:11:22 +0000 (18:11 -0400)]
remove Show Cipher

committed by accident, and could have been a security hole, but since
this compiles, it was not

5 years agoAdded a comment
yarikoptic [Tue, 1 Sep 2020 20:50:02 +0000 (20:50 +0000)]
Added a comment

5 years agothought
Joey Hess [Tue, 1 Sep 2020 20:04:40 +0000 (16:04 -0400)]
thought

5 years agolink
Joey Hess [Tue, 1 Sep 2020 20:02:03 +0000 (16:02 -0400)]
link

5 years agotodo
Joey Hess [Tue, 1 Sep 2020 20:00:49 +0000 (16:00 -0400)]
todo

5 years agocomment
Joey Hess [Tue, 1 Sep 2020 19:51:41 +0000 (15:51 -0400)]
comment

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 1 Sep 2020 19:36:56 +0000 (15:36 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agocomment
Joey Hess [Tue, 1 Sep 2020 19:36:28 +0000 (15:36 -0400)]
comment

5 years agonoise about 500s
yarikoptic [Tue, 1 Sep 2020 19:29:29 +0000 (19:29 +0000)]
noise about 500s

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 1 Sep 2020 19:18:42 +0000 (15:18 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agoAdded http special remote, which is useful for accessing other remotes that publish...
Joey Hess [Tue, 1 Sep 2020 19:16:35 +0000 (15:16 -0400)]
Added http special remote, which is useful for accessing other remotes that publish content stored in them via http/https.

With automatic layout learning!

5 years agonote common need of these two todos
Joey Hess [Tue, 1 Sep 2020 16:13:41 +0000 (12:13 -0400)]
note common need of these two todos

5 years agoclose as dup
Joey Hess [Tue, 1 Sep 2020 15:58:08 +0000 (11:58 -0400)]
close as dup

5 years ago(no commit message)
gb@4a49bb1afcf3d183bba8f07297b0395808768c6c [Mon, 31 Aug 2020 14:46:21 +0000 (14:46 +0000)]

5 years ago(no commit message)
gb@4a49bb1afcf3d183bba8f07297b0395808768c6c [Sun, 30 Aug 2020 16:50:45 +0000 (16:50 +0000)]

5 years agoUpdate name of attribute in haskellPackages.
falsifian [Fri, 28 Aug 2020 21:52:18 +0000 (21:52 +0000)]
Update name of attribute in haskellPackages.

5 years agomove stack file used by i386ancient autobuilder
Joey Hess [Fri, 28 Aug 2020 19:16:10 +0000 (15:16 -0400)]
move stack file used by i386ancient autobuilder

5 years agoSupport git remotes where .git is a file, not a directory
Joey Hess [Fri, 28 Aug 2020 19:08:14 +0000 (15:08 -0400)]
Support git remotes where .git is a file, not a directory

Eg when --separate-git-dir was used, and core.symlinks=false.

This commit was sponsored by Brock Spratlen on Patreon.

5 years agotest: Stop gpg-agent daemons that are started for the test framework's gpg key
Joey Hess [Fri, 28 Aug 2020 18:28:42 +0000 (14:28 -0400)]
test: Stop gpg-agent daemons that are started for the test framework's gpg key

They normally shutdown when the GNUPGHOME directory is deleted, but on
NFS they keep the directory from being deleted. And also, this avoids
a number of them piling up while the test suite is running.

5 years agoneed lts-13.11 after all
Joey Hess [Fri, 28 Aug 2020 18:07:31 +0000 (14:07 -0400)]
need lts-13.11 after all

the newer one fails at the end of build with an unavailable libc symbol.

5 years agofurther changes to get back to last working build state on OSX
Joey Hess [Fri, 28 Aug 2020 17:59:00 +0000 (13:59 -0400)]
further changes to get back to last working build state on OSX

Seems 13.11 was not being used for a while, but 14.27 works.

For some reason, stack was getting confused when I set the magicmime
flag on the command line, but setting it in stack.yaml didn't confuse
it. Ugh.

5 years agoclose
Joey Hess [Fri, 28 Aug 2020 17:55:54 +0000 (13:55 -0400)]
close

5 years agoclose
Joey Hess [Fri, 28 Aug 2020 17:54:42 +0000 (13:54 -0400)]
close

5 years agoclose
Joey Hess [Fri, 28 Aug 2020 17:53:15 +0000 (13:53 -0400)]
close

5 years agofix build
Joey Hess [Fri, 28 Aug 2020 17:01:56 +0000 (13:01 -0400)]
fix build

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Fri, 28 Aug 2020 16:57:25 +0000 (12:57 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agoadd stack.yaml for OSX autobuilder
Joey Hess [Fri, 28 Aug 2020 16:53:51 +0000 (12:53 -0400)]
add stack.yaml for OSX autobuilder

Unfortunately, the autobuilder is using an old version of OSX, and
cannot use ghc newer than the one in lts-13.11. Newer ghc versions use a
libc symbol that is not available.

Since the main stack.yaml has been updated to a newer lts, and just
substituting in lts-13.11 no longer works due to other dependency
issues, it's simplest to use a separate one for the OSX build.

Hopefully this is temporary, and the autobuilder gets updated.

5 years agoremove build warning about old process version
Joey Hess [Fri, 28 Aug 2020 15:17:30 +0000 (11:17 -0400)]
remove build warning about old process version

The timeout features never materialized.

5 years agoremove unused imports
Joey Hess [Fri, 28 Aug 2020 15:16:51 +0000 (11:16 -0400)]
remove unused imports

5 years ago(no commit message)
jcohen@8a78f6f9e293f581b96cd43634328c0e9de6b36e [Fri, 28 Aug 2020 02:12:57 +0000 (02:12 +0000)]

5 years ago(no commit message)
jcohen@8a78f6f9e293f581b96cd43634328c0e9de6b36e [Fri, 28 Aug 2020 02:12:15 +0000 (02:12 +0000)]

5 years agoAdded a comment
Ilya_Shlyakhter [Fri, 28 Aug 2020 01:02:50 +0000 (01:02 +0000)]
Added a comment

5 years agoAdded a comment
cardoso-neto [Fri, 28 Aug 2020 00:20:31 +0000 (00:20 +0000)]
Added a comment

5 years agoAdded a comment: understanding why standalone conda package gets preferred
Ilya_Shlyakhter [Thu, 27 Aug 2020 15:32:09 +0000 (15:32 +0000)]
Added a comment: understanding why standalone conda package gets preferred

5 years agocomment
Joey Hess [Wed, 26 Aug 2020 17:09:47 +0000 (13:09 -0400)]
comment

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Wed, 26 Aug 2020 17:06:14 +0000 (13:06 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agoDisplay a message when git-annex has to wait for a pid lock file held by another...
Joey Hess [Wed, 26 Aug 2020 17:05:34 +0000 (13:05 -0400)]
Display a message when git-annex has to wait for a pid lock file held by another process

5 years agorefactor out Annex.PidLock
Joey Hess [Wed, 26 Aug 2020 16:20:56 +0000 (12:20 -0400)]
refactor out Annex.PidLock

5 years agoAdded a comment: dreaming of everyone using CoW FSs
yarikoptic [Wed, 26 Aug 2020 01:26:29 +0000 (01:26 +0000)]
Added a comment: dreaming of everyone using CoW FSs

5 years agocomment
Joey Hess [Tue, 25 Aug 2020 21:43:50 +0000 (17:43 -0400)]
comment

5 years agoadd gitAnnexChildProcess and use instead of incorrect use of runsGitAnnexChildProcess
Joey Hess [Tue, 25 Aug 2020 18:57:25 +0000 (14:57 -0400)]
add gitAnnexChildProcess and use instead of incorrect use of runsGitAnnexChildProcess

Fixes reversion in 8.20200617 that made annex.pidlock being enabled result
in some commands stalling, particularly those needing to autoinit.

Renamed runsGitAnnexChildProcess to make clearer where it should be
used.

Arguably, it would be better to have a way to make any process git-annex
runs have the env var set. But then it would need to take the pid lock
when running any and all processes, and that would be a problem when
git-annex runs two processes concurrently. So, I'm left doing it ad-hoc
in places where git-annex really does run a child process, directly
or indirectly via a particular git command.

5 years agowording
Joey Hess [Tue, 25 Aug 2020 18:47:17 +0000 (14:47 -0400)]
wording

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 25 Aug 2020 18:31:43 +0000 (14:31 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agoanalysis
Joey Hess [Tue, 25 Aug 2020 18:31:15 +0000 (14:31 -0400)]
analysis

5 years agoAdded a comment
kyle [Tue, 25 Aug 2020 17:51:43 +0000 (17:51 +0000)]
Added a comment

5 years agofix comment format
Joey Hess [Tue, 25 Aug 2020 17:40:52 +0000 (13:40 -0400)]
fix comment format

5 years agodocument that annex.thin beats annex.hardlink
Joey Hess [Tue, 25 Aug 2020 17:34:37 +0000 (13:34 -0400)]
document that annex.thin beats annex.hardlink

5 years agoMerge branch 'master' of ssh://git-annex.branchable.com into master
Joey Hess [Tue, 25 Aug 2020 17:01:03 +0000 (13:01 -0400)]
Merge branch 'master' of ssh://git-annex.branchable.com into master

5 years agoaddurl --file youtube-dl reversion fix
Joey Hess [Tue, 25 Aug 2020 16:56:38 +0000 (12:56 -0400)]
addurl --file youtube-dl reversion fix

addurl: Fix reversion in 7.20190322 that made --file not be honored when
youtube-dl was used to download media.

8758f9c561 was on the right track, but missed that | otherwise prevented
the code it added from being used.

Also, refactored out a common function.

This commit was sponsored by Graham Spencer on Patreon.

5 years agoAdded a comment: pidlock to blame!
yarikoptic [Tue, 25 Aug 2020 16:27:11 +0000 (16:27 +0000)]
Added a comment: pidlock to blame!

5 years agoAdded a comment
kyle [Tue, 25 Aug 2020 15:20:46 +0000 (15:20 +0000)]
Added a comment

5 years agoinitial report on hardlink in thin mode
yarikoptic [Tue, 25 Aug 2020 15:07:21 +0000 (15:07 +0000)]
initial report on hardlink in thin mode

5 years agoAdded a comment: comment: works on my end
kyle [Tue, 25 Aug 2020 15:02:45 +0000 (15:02 +0000)]
Added a comment: comment: works on my end

5 years agoAdded a comment
yarikoptic [Tue, 25 Aug 2020 15:01:19 +0000 (15:01 +0000)]
Added a comment

5 years agoinitial report on get being stuck
yarikoptic [Tue, 25 Aug 2020 14:47:38 +0000 (14:47 +0000)]
initial report on get being stuck