nextcloud-desktop.git
3 years agoClean up includes in networkjobs
Claudio Cambra [Thu, 20 Apr 2023 11:48:37 +0000 (19:48 +0800)]
Clean up includes in networkjobs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
fix for header fix

3 years agoDo not use magic string for propfind prop element tag name
Claudio Cambra [Thu, 20 Apr 2023 11:41:41 +0000 (19:41 +0800)]
Do not use magic string for propfind prop element tag name

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoUse constexpr in networkjobs notModifiedStatusCode
Claudio Cambra [Thu, 20 Apr 2023 11:41:21 +0000 (19:41 +0800)]
Use constexpr in networkjobs notModifiedStatusCode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSimplify Propfind XML parsing using QDomDocument instead of complex QXmlStreamReader...
Claudio Cambra [Thu, 20 Apr 2023 07:35:46 +0000 (15:35 +0800)]
Simplify Propfind XML parsing using QDomDocument instead of complex QXmlStreamReader-based parsing

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoModernise PropfindJob with new for and const auto
Claudio Cambra [Wed, 19 Apr 2023 15:34:49 +0000 (23:34 +0800)]
Modernise PropfindJob with new for and const auto

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix layout of tags with differing sizes and oversized tags
Claudio Cambra [Wed, 12 Apr 2023 04:11:33 +0000 (12:11 +0800)]
Fix layout of tags with differing sizes and oversized tags

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSimplify file tag model updating in filedetails, only require folder pointer
Claudio Cambra [Wed, 12 Apr 2023 03:37:01 +0000 (11:37 +0800)]
Simplify file tag model updating in filedetails, only require folder pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDisplay filetags in file details window
Claudio Cambra [Tue, 11 Apr 2023 17:30:35 +0000 (01:30 +0800)]
Display filetags in file details window

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSimplify FileTag component
Claudio Cambra [Tue, 11 Apr 2023 17:29:41 +0000 (01:29 +0800)]
Simplify FileTag component

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoInstantiate FileTagModel in FileDetails
Claudio Cambra [Tue, 11 Apr 2023 16:36:09 +0000 (00:36 +0800)]
Instantiate FileTagModel in FileDetails

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd ability to limit maximum amount of tags displayed
Claudio Cambra [Tue, 11 Apr 2023 15:43:59 +0000 (23:43 +0800)]
Add ability to limit maximum amount of tags displayed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoExpose account and serverRelativePath of FileTagModel as QPROPERTYs
Claudio Cambra [Tue, 11 Apr 2023 15:34:39 +0000 (23:34 +0800)]
Expose account and serverRelativePath of FileTagModel as QPROPERTYs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoImplement FileTagModel QAbstractListModel methods
Claudio Cambra [Tue, 11 Apr 2023 15:26:33 +0000 (23:26 +0800)]
Implement FileTagModel QAbstractListModel methods

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd capability for FileTagModel to fetch tags
Claudio Cambra [Tue, 11 Apr 2023 15:21:17 +0000 (23:21 +0800)]
Add capability for FileTagModel to fetch tags

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoGet account and relativeserverpath in constructor for FileTagModel
Claudio Cambra [Tue, 11 Apr 2023 09:41:56 +0000 (17:41 +0800)]
Get account and relativeserverpath in constructor for FileTagModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd a FileTagModel
Claudio Cambra [Mon, 10 Apr 2023 11:27:31 +0000 (19:27 +0800)]
Add a FileTagModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd FileTag QML component
Claudio Cambra [Mon, 10 Apr 2023 11:15:11 +0000 (19:15 +0800)]
Add FileTag QML component

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMerge pull request #5687 from nextcloud/bugfix/notifications
Camila [Tue, 16 May 2023 10:12:24 +0000 (07:12 -0300)]
Merge pull request #5687 from nextcloud/bugfix/notifications

Dismiss notifications

3 years agoAdd a dismiss link for notifications without it.
Camila [Fri, 12 May 2023 14:46:23 +0000 (16:46 +0200)]
Add a dismiss link for notifications without it.

- Fix for #5606 and #5585.
- That is how it is done in the server and other clients.
- Update tests.

Signed-off-by: Camila <hello@camila.codes>
3 years agoMerge pull request #5680 from nextcloud/bugfix/putmultifilejob-crash-mac
Claudio Cambra [Mon, 15 May 2023 14:02:37 +0000 (22:02 +0800)]
Merge pull request #5680 from nextcloud/bugfix/putmultifilejob-crash-mac

Fix unrecoverable freezing when PutMultiFileJob is used with upload rate limits enabled

3 years agoModernise BandwidthManager::absoluteLimitTimerExpired
Claudio Cambra [Mon, 15 May 2023 12:05:30 +0000 (20:05 +0800)]
Modernise BandwidthManager::absoluteLimitTimerExpired

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoUse modern for loop in BandwidthManager::relativeDownloadDelayTimerExpired
Claudio Cambra [Mon, 15 May 2023 12:04:19 +0000 (20:04 +0800)]
Use modern for loop in BandwidthManager::relativeDownloadDelayTimerExpired

getFileJobSigned-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

3 years agoBring improvements of new cpp to BandwidthManager::relativeDownloadMeasuringTimerExpired
Claudio Cambra [Mon, 15 May 2023 12:03:18 +0000 (20:03 +0800)]
Bring improvements of new cpp to BandwidthManager::relativeDownloadMeasuringTimerExpired

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoModernise and improve readability of BandwidthManager::relativeUploadDelayTimerExpired
Claudio Cambra [Mon, 15 May 2023 12:00:28 +0000 (20:00 +0800)]
Modernise and improve readability of BandwidthManager::relativeUploadDelayTimerExpired

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoModernise BandwidthManager::relativeUploadMeasuringTimerExpired with const auto,...
Claudio Cambra [Mon, 15 May 2023 11:54:41 +0000 (19:54 +0800)]
Modernise BandwidthManager::relativeUploadMeasuringTimerExpired with const auto, readability, etc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix deadlock when using putmultifilejob with rate limits enabled
Claudio Cambra [Mon, 15 May 2023 11:30:27 +0000 (19:30 +0800)]
Fix deadlock when using putmultifilejob with rate limits enabled

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoModernise BandwidthManager::switchingTimerExpired
Claudio Cambra [Mon, 15 May 2023 07:43:58 +0000 (15:43 +0800)]
Modernise BandwidthManager::switchingTimerExpired

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoLog if PutMultiFileJob oneDevice has error
Claudio Cambra [Thu, 11 May 2023 13:31:06 +0000 (21:31 +0800)]
Log if PutMultiFileJob oneDevice has error

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDo not close putmultifilejob devices if not open, log when they are not open
Claudio Cambra [Thu, 11 May 2023 13:27:06 +0000 (21:27 +0800)]
Do not close putmultifilejob devices if not open, log when they are not open

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoIncrease logging around emission of putmultifilejobs
Claudio Cambra [Thu, 11 May 2023 12:58:54 +0000 (20:58 +0800)]
Increase logging around emission of putmultifilejobs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDon't bother creating a unique ptr for computeChecksum as we never use the guarded ptr
Claudio Cambra [Thu, 11 May 2023 12:13:39 +0000 (20:13 +0800)]
Don't bother creating a unique ptr for computeChecksum as we never use the guarded ptr

3 years agoImprove general readability of bulkpropagatorjob.cpp
Claudio Cambra [Thu, 11 May 2023 12:11:07 +0000 (20:11 +0800)]
Improve general readability of bulkpropagatorjob.cpp

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoRemove unnecessary double declaration of namespace in bulkpropagatorjob
Claudio Cambra [Thu, 11 May 2023 12:02:14 +0000 (20:02 +0800)]
Remove unnecessary double declaration of namespace in bulkpropagatorjob

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoClean up and const autofy BulkPropagatorJob::scheduleSelfOrChild
Claudio Cambra [Thu, 11 May 2023 11:57:28 +0000 (19:57 +0800)]
Clean up and const autofy BulkPropagatorJob::scheduleSelfOrChild

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDon't bother creating a unique ptr for PutMultiFileJob as we never use the guarded ptr
Claudio Cambra [Thu, 11 May 2023 11:47:55 +0000 (19:47 +0800)]
Don't bother creating a unique ptr for PutMultiFileJob as we never use the guarded ptr

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoClean up putmultifilejob class definition
Claudio Cambra [Thu, 11 May 2023 03:09:57 +0000 (11:09 +0800)]
Clean up putmultifilejob class definition

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix(l10n): Update translations from Transifex
Nextcloud bot [Mon, 15 May 2023 04:33:03 +0000 (04:33 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
3 years agoFix(l10n): Update translations from Transifex
Nextcloud bot [Sun, 14 May 2023 04:31:31 +0000 (04:31 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
3 years agoFix(l10n): Update translations from Transifex
Nextcloud bot [Sat, 13 May 2023 04:32:13 +0000 (04:32 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
3 years agoMerge pull request #5527 from nextcloud/feature/file-provider-try-2
Claudio Cambra [Fri, 12 May 2023 09:05:25 +0000 (17:05 +0800)]
Merge pull request #5527 from nextcloud/feature/file-provider-try-2

Implement File Provider file synchronisation engine for macOS

3 years agoDo not exclude file provider config entries from compile on non-macOS platforms
Claudio Cambra [Fri, 12 May 2023 07:51:56 +0000 (15:51 +0800)]
Do not exclude file provider config entries from compile on non-macOS platforms

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoBuild macOS shell extensions with debug configuration in xcodebuild when CMAKE build...
Claudio Cambra [Fri, 12 May 2023 05:14:29 +0000 (13:14 +0800)]
Build macOS shell extensions with debug configuration in xcodebuild when CMAKE build type set to debug

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDo not initialise file provider module if not enabled in config
Claudio Cambra [Fri, 12 May 2023 04:09:19 +0000 (12:09 +0800)]
Do not initialise file provider module if not enabled in config

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd config entry for file provider module enabling
Claudio Cambra [Fri, 12 May 2023 04:04:05 +0000 (12:04 +0800)]
Add config entry for file provider module enabling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd support for thumbnails in FileProviderExtension
Claudio Cambra [Thu, 6 Apr 2023 09:03:59 +0000 (17:03 +0800)]
Add support for thumbnails in FileProviderExtension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd convenience method to get thumbnailUrl in NextcloudItemMetadataTable
Claudio Cambra [Tue, 4 Apr 2023 13:12:57 +0000 (21:12 +0800)]
Add convenience method to get thumbnailUrl in NextcloudItemMetadataTable

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSplit local file related metadata management into own extension in NextcloudFilesData...
Claudio Cambra [Tue, 4 Apr 2023 08:37:30 +0000 (16:37 +0800)]
Split local file related metadata management into own extension in NextcloudFilesDatabaseManager

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSplit directory item metadata handling in database to new NextcloudFilesDatabaseManag...
Claudio Cambra [Tue, 4 Apr 2023 08:24:17 +0000 (16:24 +0800)]
Split directory item metadata handling in database to new NextcloudFilesDatabaseManager extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoCorrectly report child item count for folders in FileProviderItem
Claudio Cambra [Tue, 4 Apr 2023 07:56:29 +0000 (15:56 +0800)]
Correctly report child item count for folders in FileProviderItem

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoAdd convenience method for NextcloudFilesDatabaseManager to get child items of a...
Claudio Cambra [Tue, 4 Apr 2023 07:52:20 +0000 (15:52 +0800)]
Add convenience method for NextcloudFilesDatabaseManager to get child items of a directory

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix query of childDirectoriesForDirectory in NextcloudFilesDatabaseManager
Claudio Cambra [Tue, 4 Apr 2023 07:49:33 +0000 (15:49 +0800)]
Fix query of childDirectoriesForDirectory in NextcloudFilesDatabaseManager

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoProperly report modification date for FileProviderItem
Claudio Cambra [Mon, 3 Apr 2023 10:22:38 +0000 (18:22 +0800)]
Properly report modification date for FileProviderItem

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoUse consistent if defined in application.cpp
Claudio Cambra [Wed, 22 Mar 2023 13:29:57 +0000 (14:29 +0100)]
Use consistent if defined in application.cpp

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoRename FileProviderDomainManager::Private to FileProviderDomainManager::MacImplementation
Claudio Cambra [Wed, 22 Mar 2023 13:25:15 +0000 (14:25 +0100)]
Rename FileProviderDomainManager::Private to FileProviderDomainManager::MacImplementation

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSet interpolated log strings in FileProvider logs to public
Claudio Cambra [Tue, 21 Mar 2023 15:29:21 +0000 (16:29 +0100)]
Set interpolated log strings in FileProvider logs to public

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSplit client interfacing code into FileProviderExtension extension
Claudio Cambra [Tue, 21 Mar 2023 12:28:48 +0000 (13:28 +0100)]
Split client interfacing code into FileProviderExtension extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMake NKError extension code more Swift-like, clean up
Claudio Cambra [Tue, 21 Mar 2023 12:21:51 +0000 (13:21 +0100)]
Make NKError extension code more Swift-like, clean up

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoRemove readdFileProviderDomain hack in FileProviderDomainManager
Claudio Cambra [Mon, 20 Mar 2023 17:04:41 +0000 (18:04 +0100)]
Remove readdFileProviderDomain hack in FileProviderDomainManager

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoUse specific signalEnumerator method in FileProviderExtension item renaming instead...
Claudio Cambra [Mon, 20 Mar 2023 15:15:39 +0000 (16:15 +0100)]
Use specific signalEnumerator method in FileProviderExtension item renaming instead of reinventing wheel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix unused/unmodified variable definition warnings in FileProviderEnumerator
Claudio Cambra [Mon, 20 Mar 2023 15:14:59 +0000 (16:14 +0100)]
Fix unused/unmodified variable definition warnings in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoEnsure we return deleted metadata directory copy rather than live fire realm object...
Claudio Cambra [Mon, 20 Mar 2023 15:14:35 +0000 (16:14 +0100)]
Ensure we return deleted metadata directory copy rather than live fire realm object in recursive delete of NextcloudFilesDatabaseManager

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoParallelise conversion of NKFiles to NextcloudItemMetadataTables
Claudio Cambra [Mon, 20 Mar 2023 14:02:29 +0000 (15:02 +0100)]
Parallelise conversion of NKFiles to NextcloudItemMetadataTables

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoProperly handle metadata delete after item deletion in FileProviderExtension
Claudio Cambra [Mon, 20 Mar 2023 13:56:41 +0000 (14:56 +0100)]
Properly handle metadata delete after item deletion in FileProviderExtension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix recursive metadata delete in NextcloudFilesDatabaseManager
Claudio Cambra [Mon, 20 Mar 2023 13:51:54 +0000 (14:51 +0100)]
Fix recursive metadata delete in NextcloudFilesDatabaseManager

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMove NKFile to metadata conversion methods to a new extension for NextcloudItemMetada...
Claudio Cambra [Mon, 20 Mar 2023 13:29:14 +0000 (14:29 +0100)]
Move NKFile to metadata conversion methods to a new extension for NextcloudItemMetadataTable, where they are better placed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoPrevent multi-thread modification of the same array with serial array modification...
Claudio Cambra [Mon, 20 Mar 2023 12:16:24 +0000 (13:16 +0100)]
Prevent multi-thread modification of the same array with serial array modification dispatch queue when enumerating items in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoReintegrate sync engine into FileProviderEnumerator class
Claudio Cambra [Sat, 18 Mar 2023 22:36:25 +0000 (23:36 +0100)]
Reintegrate sync engine into FileProviderEnumerator class

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSimplify initial item enumeration, no need to fetch from database in FileProviderEnum...
Claudio Cambra [Sat, 18 Mar 2023 22:35:10 +0000 (23:35 +0100)]
Simplify initial item enumeration, no need to fetch from database in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoPerform slow metadata to FileProviderItem conversion concurrently in FileProviderEnum...
Claudio Cambra [Sat, 18 Mar 2023 20:35:12 +0000 (21:35 +0100)]
Perform slow metadata to FileProviderItem conversion concurrently in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix children serverurl rename in file provider nc files database
Claudio Cambra [Sat, 18 Mar 2023 20:33:02 +0000 (21:33 +0100)]
Fix children serverurl rename in file provider nc files database

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoRemove redundant double read of serverUrl when often we always want to do a depth...
Claudio Cambra [Sat, 18 Mar 2023 20:32:26 +0000 (21:32 +0100)]
Remove redundant double read of serverUrl when often we always want to do a depth 1 read in NextcloudSyncEngine

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMake sure to include new metadatas in folders to scan for changes in recursive scan...
Claudio Cambra [Sat, 18 Mar 2023 19:11:36 +0000 (20:11 +0100)]
Make sure to include new metadatas in folders to scan for changes in recursive scan of NextcloudSyncEngine

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMake sure to notify when folder moved in FileProviderExtension
Claudio Cambra [Sat, 18 Mar 2023 19:07:35 +0000 (20:07 +0100)]
Make sure to notify when folder moved in FileProviderExtension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix unsetting of etags on directories (and only) directories on update
Claudio Cambra [Sat, 18 Mar 2023 19:01:53 +0000 (20:01 +0100)]
Fix unsetting of etags on directories (and only) directories on update

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix recursive directory metadata renaming order
Claudio Cambra [Sat, 18 Mar 2023 19:01:29 +0000 (20:01 +0100)]
Fix recursive directory metadata renaming order

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDo not do specific enumeration of items working set in FileProviderEnumerator
Claudio Cambra [Sat, 18 Mar 2023 18:01:10 +0000 (19:01 +0100)]
Do not do specific enumeration of items working set in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoEnsure we do not set etag if we have set updateDirectoryEtags to false in NextcloudFi...
Claudio Cambra [Sat, 18 Mar 2023 18:00:25 +0000 (19:00 +0100)]
Ensure we do not set etag if we have set updateDirectoryEtags to false in NextcloudFilesDatabaseManager updateItemMetadatas

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMove remote sync functionality out of enumerator and into separate NextcloudSyncEngin...
Claudio Cambra [Sat, 18 Mar 2023 17:04:19 +0000 (18:04 +0100)]
Move remote sync functionality out of enumerator and into separate NextcloudSyncEngine class

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoProgressively enumerate items as we get them for working set
Claudio Cambra [Sat, 18 Mar 2023 15:44:30 +0000 (16:44 +0100)]
Progressively enumerate items as we get them for working set

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMove conversion from NSData to NSFileProviderPage to separate func
Claudio Cambra [Sat, 18 Mar 2023 15:35:59 +0000 (16:35 +0100)]
Move conversion from NSData to NSFileProviderPage to separate func

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSplit metadata parsing to complete enumerator into own function
Claudio Cambra [Sat, 18 Mar 2023 15:27:32 +0000 (16:27 +0100)]
Split metadata parsing to complete enumerator into own function

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoSimplify enumerateItems of working set by using fullRecursiveScan in FileProviderEnum...
Claudio Cambra [Sat, 18 Mar 2023 12:58:27 +0000 (13:58 +0100)]
Simplify enumerateItems of working set by using fullRecursiveScan in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoHandle invalidation of enumerator during long recursive scans in FileProviderEnumerator
Claudio Cambra [Sat, 18 Mar 2023 15:05:34 +0000 (16:05 +0100)]
Handle invalidation of enumerator during long recursive scans in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix recursive scan when scanChangesOnly is false in FileProviderEnumerator
Claudio Cambra [Sat, 18 Mar 2023 14:49:20 +0000 (15:49 +0100)]
Fix recursive scan when scanChangesOnly is false in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMove deleted/updated conflict check to fullRecursiveScan in FileProviderEnumerator...
Claudio Cambra [Sat, 18 Mar 2023 13:10:24 +0000 (14:10 +0100)]
Move deleted/updated conflict check to fullRecursiveScan in FileProviderEnumerator+RemoteSync

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoProperly report and handle critical errors during recursive enumeration in FileProvid...
Claudio Cambra [Sat, 18 Mar 2023 12:57:02 +0000 (13:57 +0100)]
Properly report and handle critical errors during recursive enumeration in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoMove remote sync stuff in FileProviderEnumerator to own file
Claudio Cambra [Sat, 18 Mar 2023 12:41:31 +0000 (13:41 +0100)]
Move remote sync stuff in FileProviderEnumerator to own file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoProperly report deleted metadatas in recursive directory delete in FileProviderEnumerator
Claudio Cambra [Sat, 18 Mar 2023 12:24:37 +0000 (13:24 +0100)]
Properly report deleted metadatas in recursive directory delete in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFavour straight return in updateItemMetadatas rather than unnecessary completionHandl...
Claudio Cambra [Sat, 18 Mar 2023 12:23:53 +0000 (13:23 +0100)]
Favour straight return in updateItemMetadatas rather than unnecessary completionHandler in NextcloudFilesDatabaseManager

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix renaming directories remotely fixing local sync state in file provider
Claudio Cambra [Sat, 18 Mar 2023 03:41:47 +0000 (04:41 +0100)]
Fix renaming directories remotely fixing local sync state in file provider

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoDo not update etags for child folders acquired in a depth 1 readServerUrl in FileProv...
Claudio Cambra [Sat, 18 Mar 2023 01:35:02 +0000 (02:35 +0100)]
Do not update etags for child folders acquired in a depth 1 readServerUrl in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoRemove redundant directory metadata tables in File Provider
Claudio Cambra [Sat, 18 Mar 2023 00:43:05 +0000 (01:43 +0100)]
Remove redundant directory metadata tables in File Provider

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoPrevent premature running of completion handler when modifying folder in FileProvider...
Claudio Cambra [Fri, 17 Mar 2023 22:38:21 +0000 (23:38 +0100)]
Prevent premature running of completion handler when modifying folder in FileProviderExtension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoChange fullRecursiveScan function to enable more than just look for changes, also...
Claudio Cambra [Fri, 17 Mar 2023 22:27:59 +0000 (23:27 +0100)]
Change fullRecursiveScan function to enable more than just look for changes, also do proper full scan

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoEnsure we are not marking items as both updated and deleted in FileProviderEnumerator
Claudio Cambra [Fri, 17 Mar 2023 19:37:22 +0000 (20:37 +0100)]
Ensure we are not marking items as both updated and deleted in FileProviderEnumerator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoEnsure xcodebuild uses the Info.plist file verbatim
Claudio Cambra [Fri, 17 Mar 2023 15:04:17 +0000 (16:04 +0100)]
Ensure xcodebuild uses the Info.plist file verbatim

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoFix FileProviderExt bundle identifier
Claudio Cambra [Fri, 17 Mar 2023 14:18:27 +0000 (15:18 +0100)]
Fix FileProviderExt bundle identifier

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
3 years agoOnly set CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO in FileProviderExt for release configu...
Ivan Sein [Fri, 17 Mar 2023 12:01:43 +0000 (13:01 +0100)]
Only set CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO in FileProviderExt for release configuration.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
3 years agoSet CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO in FileProviderExt.
Ivan Sein [Fri, 17 Mar 2023 10:19:02 +0000 (11:19 +0100)]
Set CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO in FileProviderExt.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
3 years agoDisable automatically manage signing in FileProviderExt target.
Ivan Sein [Thu, 16 Mar 2023 21:48:57 +0000 (22:48 +0100)]
Disable automatically manage signing in FileProviderExt target.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>