nextcloud-desktop.git
10 years agoGUI: Replace term "sign in" with "Log in" and friends.
Klaas Freitag [Thu, 10 Sep 2015 15:16:22 +0000 (17:16 +0200)]
GUI: Replace term "sign in" with "Log in" and friends.

Also with doc changes.

10 years agoMerge pull request #3801 from phil-davis/src2
Daniel Molkentin [Thu, 10 Sep 2015 15:04:52 +0000 (17:04 +0200)]
Merge pull request #3801 from phil-davis/src2

Minor typos in client test section

10 years agoMinor typos in client test section
Phil Davis [Thu, 10 Sep 2015 12:26:44 +0000 (18:11 +0545)]
Minor typos in client test section

Note: I am not sure that nostoredpasswd even exists in the current
version. Maybe the stuff in testplan.txt is old and not relevant anyway?

10 years agoMerge pull request #3800 from phil-davis/src1
Daniel Molkentin [Thu, 10 Sep 2015 11:58:26 +0000 (13:58 +0200)]
Merge pull request #3800 from phil-davis/src1

cmd and crashreporter minor typos

10 years agocmd and crashreporter minor typos
Phil Davis [Thu, 10 Sep 2015 11:49:26 +0000 (17:34 +0545)]
cmd and crashreporter minor typos

nothing important here

10 years agoRemove shadow from ownCloud icon
Daniel Molkentin [Thu, 10 Sep 2015 11:40:50 +0000 (13:40 +0200)]
Remove shadow from ownCloud icon

Fixes #3693

10 years agoUnits: Back to the "usual" mix units.
Klaas Freitag [Thu, 10 Sep 2015 10:08:20 +0000 (12:08 +0200)]
Units: Back to the "usual" mix units.

Now we display units again numerically wrong (based on 1024) but back
to how it was before in ownCloud.

10 years agoAccount: Display non-standard port as part of the hostname
Daniel Molkentin [Thu, 10 Sep 2015 08:17:16 +0000 (10:17 +0200)]
Account: Display non-standard port as part of the hostname

Addresses #3658

10 years agoMerge pull request #3797 from phil-davis/minorstuff
Daniel Molkentin [Thu, 10 Sep 2015 07:49:16 +0000 (09:49 +0200)]
Merge pull request #3797 from phil-davis/minorstuff

Minor build etc typos

10 years agoMinor build etc typos
Phil Davis [Thu, 10 Sep 2015 07:35:11 +0000 (13:20 +0545)]
Minor build etc typos

Just some random stuff I noticed while looking at how this beast is put
together.

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 10 Sep 2015 06:19:05 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoAdjust strings in settings dialogs
Daniel Molkentin [Wed, 9 Sep 2015 23:46:28 +0000 (01:46 +0200)]
Adjust strings in settings dialogs

Implements  #3745 & #3793

10 years ago /doc/autoupdate.rst: "Migrate to the following directory" => "Edit this Registry...
hh.lohmann [Wed, 9 Sep 2015 10:33:25 +0000 (12:33 +0200)]
 /doc/autoupdate.rst: "Migrate to the following directory" => "Edit this Registry key"

Registry keys are no directories; you would not "migrate" to keys if you are just about to switch to them; resembling formulas as "Edit these / this Registry key/s" ease fast reading, for that also ":" instead of "::" at the end (formatting what follows)

10 years agoCoin the term 'folder sync connection'
Phil Davis [Tue, 8 Sep 2015 11:37:57 +0000 (17:22 +0545)]
Coin the term 'folder sync connection'

Proposed wording for issue
https://github.com/owncloud/client/issues/3757

10 years agoAllow (partial) translations even when run from build dir
Daniel Molkentin [Wed, 9 Sep 2015 23:25:16 +0000 (01:25 +0200)]
Allow (partial) translations even when run from build dir

Makes it easier to catch translation issues earlier

10 years agofix unicode issue #3753
Individual IT Services [Tue, 8 Sep 2015 08:14:43 +0000 (13:59 +0545)]
fix unicode issue #3753

fixes the unicode issue #3753

I don't know much CPP and Qt but after some google research I found this http://wiki.qt.io/Strings_and_encodings_in_Qt
it does mention trUtf8() that has done the trick for me on Linux with Gnome 3.16.
Haven't tested it on other systems

10 years agoAccountSettings: Do not prepend the folder alias to the undecided folders
Klaas Freitag [Wed, 9 Sep 2015 15:51:38 +0000 (17:51 +0200)]
AccountSettings: Do not prepend the folder alias to the undecided folders

This fixes bug #3685

10 years agoFix Finder crashing when showing the context menu on OS X <= 10.9
Jocelyn Turcotte [Wed, 9 Sep 2015 15:35:53 +0000 (17:35 +0200)]
Fix Finder crashing when showing the context menu on OS X <= 10.9

OwnCloudFinderRequestManager::_shareMenuTitle was not retained anymore
after the FinderSync refactoring which would cause it to contain any
kind of garbage value for some reason.

Fix the issue by also enabling ARC for RequestManager.m.
We can't enable ARC for the whole project since Finder.h is included
by many .m files and it's not trivial to port to ARC.

10 years agoGeneral settings: Set left margin of layout to zero.
Klaas Freitag [Wed, 9 Sep 2015 13:52:22 +0000 (15:52 +0200)]
General settings: Set left margin of layout to zero.

This fixes the vertical alignment of the checkboxes, see bug #3758

10 years agocsync_update: Handle permission denied as soft error in discovery.
Klaas Freitag [Wed, 9 Sep 2015 12:12:13 +0000 (14:12 +0200)]
csync_update: Handle permission denied as soft error in discovery.

For that, treat the not accessible directory as if it were ignored.

This will fix #3767

10 years agovio_local_win: Properly set errno in case of error happened.
Klaas Freitag [Wed, 9 Sep 2015 12:10:23 +0000 (14:10 +0200)]
vio_local_win: Properly set errno in case of error happened.

Without a proper errno value, the calling function can not detect
the kind of problem.

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 9 Sep 2015 06:19:02 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoMerge pull request #3691 from individual-it/2.0
Markus Goetz [Tue, 8 Sep 2015 14:03:48 +0000 (16:03 +0200)]
Merge pull request #3691 from individual-it/2.0

Nautilus: don't show share menu item for top level folders

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 8 Sep 2015 06:19:14 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoConsistency: Use folder instead of directory in user visible strings
Daniel Molkentin [Mon, 7 Sep 2015 06:51:22 +0000 (08:51 +0200)]
Consistency: Use folder instead of directory in user visible strings

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 7 Sep 2015 06:18:55 +0000 (02:18 -0400)]
[tx-robot] updated from transifex

10 years agoTray: Enable workaround for Qt5 only #3765
Christian Kamm [Mon, 7 Sep 2015 05:44:07 +0000 (07:44 +0200)]
Tray: Enable workaround for Qt5 only #3765

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 6 Sep 2015 06:19:00 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 5 Sep 2015 06:19:05 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agocsync io: Fix UNC path conversion on Win #3748
Christian Kamm [Fri, 4 Sep 2015 12:00:02 +0000 (14:00 +0200)]
csync io: Fix UNC path conversion on Win #3748

Paths that were already in UNC form don't need to be prefixed.

10 years agoTray: Don't use the tray workaround with the KDE theme #3706
Christian Kamm [Fri, 4 Sep 2015 09:58:50 +0000 (11:58 +0200)]
Tray: Don't use the tray workaround with the KDE theme #3706

That just triggers another bug...

10 years agoShareDialog: Fix folder display #3659
Christian Kamm [Fri, 4 Sep 2015 13:15:26 +0000 (15:15 +0200)]
ShareDialog: Fix folder display #3659

Sometimes having a double starting / broke the display logic.

10 years agoFolderStatus: Show 'waiting for other folder' #3619
Christian Kamm [Fri, 4 Sep 2015 08:33:48 +0000 (10:33 +0200)]
FolderStatus: Show 'waiting for other folder' #3619

We monitor the scheduling queue and show messages like
"Waiting for 5 other folders...".

10 years agoAccountSettings: Restore from legacy only once #3565
Christian Kamm [Thu, 3 Sep 2015 04:23:19 +0000 (06:23 +0200)]
AccountSettings: Restore from legacy only once #3565

And also introduce a Accounts/version int at the same time. That
may make future account settings migrations easier to manage.

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 4 Sep 2015 06:19:10 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoSSL Certificate Error Dialog: show account name #3729
Olivier Goffart [Thu, 3 Sep 2015 14:14:14 +0000 (16:14 +0200)]
SSL Certificate Error Dialog: show account name #3729

Change the wording of the certificate error dialog to include the
account URL and be a bit more accurate.

(Do not mention "SSL" in user facing messages)

10 years agoDoc for owncloudcmd: we only use the config of the gui client for the crendential...
Olivier Goffart [Thu, 3 Sep 2015 09:18:02 +0000 (11:18 +0200)]
Doc for owncloudcmd: we only use the config of the gui client for the crendential #3293

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 3 Sep 2015 06:19:02 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoSettings: Allow adding at least one account #3721
Christian Kamm [Thu, 3 Sep 2015 04:14:49 +0000 (06:14 +0200)]
Settings: Allow adding at least one account #3721

We always show the 'Add Account' button when no account exists,
even When the 'singleAccount' option is enabled.

10 years agoFolderDefinition: Escape the alias of a folder before writing to the config
Olivier Goffart [Wed, 2 Sep 2015 14:05:58 +0000 (16:05 +0200)]
FolderDefinition: Escape the alias of a folder before writing to the config

Issue #3707

10 years agoTray: Clicks work even with Qt 5.5.0 workaround #3722
Christian Kamm [Wed, 2 Sep 2015 09:10:01 +0000 (11:10 +0200)]
Tray: Clicks work even with Qt 5.5.0 workaround #3722

10 years agoPropagateLocalRemove: remove entries from the DB even if there was an error.
Olivier Goffart [Wed, 2 Sep 2015 13:19:34 +0000 (15:19 +0200)]
PropagateLocalRemove:  remove entries from the DB even if there was an error.

Previously, in case of an error while deleting a directory, we would not
remove the entries from the local db, despite most of the files would
be deleted.

Which means that if the files re-appear on the server with the same etag,
we would think the file were deleted from the client and propagate the change.

In 1.8.0 we had this bug that we would not see some directory in the server in
some cases. This would lead us to delete the file on the client.  Normaly the
files are deleted from the local database and next sync would re-download the files.
But in the cases where there was an error deleting one of the file (for example
if it was locked) we would then propagate the delete to the server.

Fix this by always deleting from the database the files that we deleted.

Issue #3206

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 2 Sep 2015 11:09:38 +0000 (07:09 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 1 Sep 2015 18:04:35 +0000 (14:04 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 1 Sep 2015 17:02:24 +0000 (13:02 -0400)]
[tx-robot] updated from transifex

10 years agoRemove the accountmigrator.cpp It is not used
Olivier Goffart [Tue, 1 Sep 2015 15:02:23 +0000 (17:02 +0200)]
Remove the accountmigrator.cpp It is not used

This was used to convert the config from the community client to
the  branded client. But we don't need this feature anymore
https://github.com/owncloud/client/issues/3515#issuecomment-133394443

10 years agoDon't show a sync success status toolip when signed out
Jocelyn Turcotte [Sat, 29 Aug 2015 11:04:10 +0000 (13:04 +0200)]
Don't show a sync success status toolip when signed out

10 years agoAccountSettings: Fix coverity warning
Olivier Goffart [Tue, 1 Sep 2015 09:39:55 +0000 (11:39 +0200)]
AccountSettings: Fix coverity warning

FolderMan::folder might return null

10 years agoAccountSettings: remove unused member
Olivier Goffart [Tue, 1 Sep 2015 09:37:47 +0000 (11:37 +0200)]
AccountSettings: remove unused member

Fix a coverity warning

10 years agoSettings dialog: remove the close button #3713
Olivier Goffart [Tue, 1 Sep 2015 09:32:59 +0000 (11:32 +0200)]
Settings dialog: remove the close button #3713

10 years agoTray notification: Don't show a message about modified folder #3613
Olivier Goffart [Tue, 1 Sep 2015 09:29:37 +0000 (11:29 +0200)]
Tray notification: Don't show a message about modified folder #3613

10 years agoFix the Windows build
Jocelyn Turcotte [Mon, 31 Aug 2015 15:23:15 +0000 (17:23 +0200)]
Fix the Windows build

Use an iterator variable declared outside of the loop condition
expression.

MinGW doesn't support C99 very easily and it's easier to keep
our C code C89 compliant.

10 years agoBump 2.0 brancht to 2.0.2 after creation of 2.0.1 branch
Daniel Molkentin [Mon, 31 Aug 2015 14:50:07 +0000 (16:50 +0200)]
Bump 2.0 brancht to 2.0.2 after creation of 2.0.1 branch

10 years agoMove the progress bar to the right of the quota label
Jocelyn Turcotte [Sun, 30 Aug 2015 13:57:33 +0000 (15:57 +0200)]
Move the progress bar to the right of the quota label

Also change the label to show the free space and show
the used and total space only on a tooltip of the bar.

Related to #3644

10 years agoDesktop file: Add X-GNOME-Autostart-Delay #3686 #1739
Markus Goetz [Mon, 31 Aug 2015 09:31:20 +0000 (11:31 +0200)]
Desktop file: Add X-GNOME-Autostart-Delay #3686 #1739

10 years agomore typos
Carla Schroder [Mon, 31 Aug 2015 09:12:47 +0000 (11:12 +0200)]
more typos

10 years agotypo correction
Carla Schroder [Mon, 31 Aug 2015 09:03:14 +0000 (11:03 +0200)]
typo correction

10 years agotypo corrections, cross-refs
Carla Schroder [Mon, 31 Aug 2015 08:48:43 +0000 (10:48 +0200)]
typo corrections, cross-refs

10 years agoFolderStatusModel: add a function to get a QModelIndex from the path
Olivier Goffart [Mon, 31 Aug 2015 08:12:45 +0000 (10:12 +0200)]
FolderStatusModel: add a function to get a QModelIndex from the path

Will be usefull to solve #3704

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 31 Aug 2015 06:19:06 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoMerge pull request #3709 from owncloud/fix/mac
Jocelyn Turcotte [Sun, 30 Aug 2015 15:55:32 +0000 (17:55 +0200)]
Merge pull request #3709 from owncloud/fix/mac

Fix/mac

10 years agoFix qtmacgoodies submodule
Felix Böhm [Sun, 30 Aug 2015 15:51:43 +0000 (17:51 +0200)]
Fix qtmacgoodies submodule

* was broken by 514372db6b0fffae226d7dd43e738ced1b7fa35b

10 years agoupdate documentation link to build for version 2.0
Felix Böhm [Sun, 30 Aug 2015 15:41:51 +0000 (17:41 +0200)]
update documentation link to build for version 2.0

10 years agoAccount Settings: rework the toolbar
Olivier Goffart [Sun, 30 Aug 2015 13:20:35 +0000 (15:20 +0200)]
Account Settings: rework the toolbar

Modifications ask by Jan:

 - Elide the label in the actions
 - Minimum sizes for the actions
 - No separatcions between the accounts

Issue #3516

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 30 Aug 2015 06:19:04 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoAccountWizard: fix when the theme specify a override URL #3699
Olivier Goffart [Sat, 29 Aug 2015 16:49:10 +0000 (18:49 +0200)]
AccountWizard: fix when the theme specify a override URL  #3699

10 years agoMerge pull request #3702 from owncloud/updates2-0
Carla Schroder [Sat, 29 Aug 2015 15:08:03 +0000 (17:08 +0200)]
Merge pull request #3702 from owncloud/updates2-0

updates for 2.0 release

10 years agoupdates for 2.0 release
carla schroder [Sat, 29 Aug 2015 14:26:48 +0000 (16:26 +0200)]
updates for 2.0 release

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 29 Aug 2015 06:19:05 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoTweak the settings UI
Jocelyn Turcotte [Fri, 28 Aug 2015 13:51:11 +0000 (15:51 +0200)]
Tweak the settings UI

- Move the cancel and apply buttons side by side
- Hide the notification label when empty
- Clamp elements at the top together a bit

10 years agodon't show share menu item for top level folders
Individual IT Services [Fri, 28 Aug 2015 10:39:52 +0000 (16:24 +0545)]
don't show share menu item for top level folders

Top level folders cannot be shared. If you try you receive an 403 error.
So we should not show the "Share with Owncloud" menu item for them

10 years agoDon't disable the selective sync cancel button
Jocelyn Turcotte [Fri, 28 Aug 2015 10:14:56 +0000 (12:14 +0200)]
Don't disable the selective sync cancel button

This makes its interaction more consistent versus other
kinds of dialogs or versus when the selective sync config
has been changed or not.

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 28 Aug 2015 06:19:15 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 28 Aug 2015 05:15:38 +0000 (01:15 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 27 Aug 2015 06:19:42 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 26 Aug 2015 06:19:06 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoPush version on to 2.0.1 git
Klaas Freitag [Tue, 25 Aug 2015 08:24:52 +0000 (10:24 +0200)]
Push version on to 2.0.1 git

10 years agoTray: Hide while modifying menus #3656 #3672
Christian Kamm [Tue, 25 Aug 2015 07:46:03 +0000 (09:46 +0200)]
Tray: Hide while modifying menus #3656 #3672

This may help workaround the dbus tray issue in Qt 5.5.0.

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 25 Aug 2015 06:19:17 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years agoAddFolder: Improve remote path selection error handling #3573
Christian Kamm [Fri, 21 Aug 2015 09:46:38 +0000 (11:46 +0200)]
AddFolder: Improve remote path selection error handling #3573

10 years agocsync_excluded: Another speedup #3638
Christian Kamm [Mon, 24 Aug 2015 09:09:34 +0000 (11:09 +0200)]
csync_excluded: Another speedup #3638

Build a list of path components outside of the exclude pattern loop.

10 years agocsync_update: Use excluded_traversal() to improve performance #3638
Christian Kamm [Mon, 24 Aug 2015 07:47:33 +0000 (09:47 +0200)]
csync_update: Use excluded_traversal() to improve performance #3638

10 years agocsync_excluded: Add fast _traversal() function #3638
Christian Kamm [Mon, 24 Aug 2015 07:44:54 +0000 (09:44 +0200)]
csync_excluded: Add fast _traversal() function #3638

This function only checks the full path and the basename and is thus
around 7x faster. It is very useful in a csync_update context where
we know that the leading dirs have already been checked for exclusion.

10 years agocsync_exclude: Speed up siginificantly #3638
Christian Kamm [Fri, 21 Aug 2015 12:20:27 +0000 (14:20 +0200)]
csync_exclude: Speed up siginificantly #3638

The performance test indicates a speedup of around 3x for paths
with around 12 components.

10 years agoAccountSettings: Adjust quota info design #3644 #3651
Christian Kamm [Wed, 19 Aug 2015 13:16:09 +0000 (15:16 +0200)]
AccountSettings: Adjust quota info design #3644 #3651

10 years agoAdjust buttons on remove folder/account questions #3654
Christian Kamm [Fri, 21 Aug 2015 09:01:01 +0000 (11:01 +0200)]
Adjust buttons on remove folder/account questions #3654

10 years agoBump version to 2.0.0 final, some Changlog addings
Klaas Freitag [Mon, 24 Aug 2015 12:23:32 +0000 (14:23 +0200)]
Bump version to 2.0.0 final, some Changlog addings

10 years agoUtility: Fix constants for 32-bit arch #3670
Christian Kamm [Mon, 24 Aug 2015 11:56:10 +0000 (13:56 +0200)]
Utility: Fix constants for 32-bit arch #3670

10 years agoTheme: Fix wizardSelectiveSyncDefaultNothing #3671
Christian Kamm [Mon, 24 Aug 2015 10:52:41 +0000 (12:52 +0200)]
Theme: Fix wizardSelectiveSyncDefaultNothing #3671

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 24 Aug 2015 06:19:03 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

10 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 23 Aug 2015 06:19:02 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

11 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 22 Aug 2015 06:19:05 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

11 years agoBump version to rc2
Klaas Freitag [Fri, 21 Aug 2015 13:59:27 +0000 (15:59 +0200)]
Bump version to rc2

11 years agoSystray: Workaround for issue with Qt 5.5.0 #3656
Christian Kamm [Fri, 21 Aug 2015 07:41:24 +0000 (09:41 +0200)]
Systray: Workaround for issue with Qt 5.5.0 #3656

11 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 21 Aug 2015 06:19:05 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

11 years agoAccountSettings: Fix margins on 'Add folder' button #3650
Christian Kamm [Thu, 20 Aug 2015 11:25:19 +0000 (13:25 +0200)]
AccountSettings: Fix margins on 'Add folder' button #3650

11 years agoSettingsDialog: Fix typo in showFirstPage()
Christian Kamm [Thu, 20 Aug 2015 09:57:44 +0000 (11:57 +0200)]
SettingsDialog: Fix typo in showFirstPage()

11 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 20 Aug 2015 06:19:09 +0000 (02:19 -0400)]
[tx-robot] updated from transifex

11 years agoAccount Settings: Hide the add folder button when Theme::singleSyncFolder is set
Olivier Goffart [Wed, 19 Aug 2015 15:59:39 +0000 (17:59 +0200)]
Account Settings: Hide the add folder button when Theme::singleSyncFolder is set

11 years agoFolderStatusDelegate: Add margin to button #3650
Christian Kamm [Wed, 19 Aug 2015 14:15:30 +0000 (16:15 +0200)]
FolderStatusDelegate: Add margin to button #3650