Merge pull request #7524 from nextcloud/bugfix/more-escapes-mac-crafter

Also escape codesign call with saving entitlements

Use recursive codesign instead of broken wildcard path for sparkle Autoupdate app

Broken when we starting escaping paths in codesign arguments

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Also add options to recursive codesign function

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Also escape codesign call with saving entitlements

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7521 from nextcloud/bugfix/conflict-bad-xpc-vfs

Add missing brace in FileProviderXPC's fileProviderExtReachable

Add missing brace in FileProviderXPC's fileProviderExtReachable

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7519 from nextcloud/bugfix/mac-crafter-codesign-paths-with-spaces

Ensure paths are passed properly escaped into codesign command in mac-crafter

Ensure paths are passed properly escaped into codesign command in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7511 from nextcloud/dependabot/github_actions/platisd/clang-tidy-pr-comments-1.6.1

Build(deps): Bump platisd/clang-tidy-pr-comments from 1.5.1 to 1.6.1

Build(deps): Bump platisd/clang-tidy-pr-comments from 1.5.1 to 1.6.1

Bumps [platisd/clang-tidy-pr-comments](https://github.com/platisd/clang-tidy-pr-comments) from 1.5.1 to 1.6.1.
- [Release notes](https://github.com/platisd/clang-tidy-pr-comments/releases)
- [Commits](https://github.com/platisd/clang-tidy-pr-comments/compare/v1.5.1...v1.6.1)

---
updated-dependencies:
- dependency-name: platisd/clang-tidy-pr-comments
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #7463 from nextcloud/bugfix/revert-windows-dark-regressions

Revert dark mode regressions on Windows 10

some improvements for account network settings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

on Windows 10 follow color scheme changes and apply them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

implement a drak mode palette  and use it when needed

for now unable to dynamically switch between light and dark mode

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

create a log category for OCC::Theme class

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

use QWidget Fusion style on Windows 10: enable dark mode

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Use QOperatingSystemVersion in Windows 11 check

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use registry-based dark mode detection on <= Windows 10

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

If <= Windows 10, use the reserve dark palette for dark mode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use old palette change detection method on Windows 10 and under

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add convenience method to check Windows 11 availability

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Revert "remove broken system paellete detection within our custom style"

This reverts commit 2d08cdb503c69392ac5cb3eddf514f0550953ed8.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7432 from nextcloud/bugfix/findersyncext-crash-pt3000

Fix crash when setting badge for a path that results in a nil URL (macOS FinderSyncExt)

Do not set badge identifier for a given path URL if the URL is nil

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Rewrite setResult:forPath: method signature for SyncClient and FinderSync

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7509 from nextcloud/bugfix/appimage-url

Update url to dowload linuxdeploy-plugin-qt tool latest version.

Update url to dowload linuxdeploy-plugin-qt tool latest version.

Fix https://github.com/linuxdeploy/linuxdeploy-plugin-qt/pull/186 for Qt6 has been released.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7462 from nextcloud/bugfix/reconnect-to-fpext

If File Provider Extension is unreachable, try to reconfigure client communication interface

If fileProviderExtRecheable is false, try to reconfigure client communication service

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7407 from nextcloud/bugfix/encoding-override-server-url

Fix encoding used for override server url

Fix encoding used for override server url

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7374 from nextcloud/bugfix/tf-backgrounds-issue

Fix QML errors caused by illegal customisation of text field backgrounds on native styles

Add small top margin to shareview

Fixes highlight of sharee search field with macOS styling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove background from textfields to fix errors

Fixes the following errors:

ShareeSearchField.qml:53:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42140, parent=0x0, geometry=0,0 0x0)).

NCInputTextField.qml:57:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42220, parent=0x0, geometry=0,0 0x0)).

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7506 from nextcloud/bugfix/removeAssertInIconUtils

remove assert that is being hit always when running debug builds

remove assert that is being hit always when running debug builds

makes no sense as I have to always patch it out to be able to run a
debug build

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7494 from nextcloud/feature/macos-vfs-doc

Add documentation page on the macOS virtual files client

Add section on configuration for macosvfs docs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add note on notify_push to macosvfs doc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add section on finder integration to macosvfs docs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add install/initial setup section to macosvfs docs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add introduction section to macosvfs docs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add starter documentation page on macOS VFS

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7238 from nextcloud/bugfix/removeuser

Always remove folder icon when removing folder.

Modernize Utility::removeFavLink and Utility::setupFavLink.

Exit setupFavLink function when SHGetKnownFolderPath fails.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add documentation about Utility::setupFavLink and Utility::removeFavLink.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Modernize NavigationPaneHelper class.

Signed-off-by: Camila Ayres <hello@camilasan.com>

f => folderToRemove.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add step to remove Desktop.ini to removeFolder function.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7487 from Kaskadee/bugfix/null-check-resultdacl

Fix crash on setting folder permission on non-NTFS file systems on Windows

Add null check for resultDacl after calling GetSecurityDescriptorDacl

Signed-off-by: Fabian Creutz <fabian.creutz@kaskadee.eu>

Merge pull request #7478 from nextcloud/Rello-patch-1

Update nextcloudcmd.rst

Update doc/nextcloudcmd.rst

Co-authored-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>

Update nextcloudcmd.rst

add note on exclude file

https://github.com/nextcloud/desktop/issues/2917

Signed-off-by: Rello <Rello@users.noreply.github.com>

Merge pull request #7488 from nextcloud/bugfix/close-wizard-properly

Clear wizard static pointer on wizardClosed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Also emit close signal on window hide (i.e. user close) on macOS

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Emit a signal on wizard close

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7475 from nextcloud/feature/dev-builds-mac-crafter

Add option to create developer builds of client via mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7491 from nextcloud/bugfix/ats-restrictions-macos

Add section on Apple ATS to docs troubleshooting section

Add section on Apple ATS to docs troubleshooting section

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7468 from nextcloud/bugfix/delete-proxypass-whenempty

Only present proxy password delete error if it is not a "does not exist" error

Prevent error on deletion when the proxy password does not exist

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7398 from nextcloud/bugfix/copyright-year-macOS

Update copyright year in macOS info.plist template

Update copyright year in macOS info.plist template

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7401 from nextcloud/bugfix/materialised-storage-calculation-macOS

Fix materialised storage use calculation (macOS VFS)

Start counting storage usage from 0 for macOS virtual files account

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7397 from nextcloud/bugfix/mac-vfs-syncstatechange-freeze

Fix stuttering and freezing of client while computing sync state changes (macOS VFS)

Store reachability of FileProviderExt by respective account

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Increase reachability retry timeout

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Slash semaphore wait delta on reachability down to 1 second

Any longer does not really yield any positive result and freezes the
client for longer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not attempt to reach out to FileProviderExt every single time we want to check if it is reachable

Only check every 60 seconds, this way we do not freeze the client for 3
seconds every time that we want to check the reachability while the
extension is unreachable

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7428 from nextcloud/dependabot/github_actions/platisd/clang-tidy-pr-comments-1.5.1

Bump platisd/clang-tidy-pr-comments from 1.5.0 to 1.5.1

Bump platisd/clang-tidy-pr-comments from 1.5.0 to 1.5.1

Bumps [platisd/clang-tidy-pr-comments](https://github.com/platisd/clang-tidy-pr-comments) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/platisd/clang-tidy-pr-comments/releases)
- [Commits](https://github.com/platisd/clang-tidy-pr-comments/compare/v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: platisd/clang-tidy-pr-comments
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7418 from nextcloud/bugfix/change-log-settings-fix

Do not alter the user's debug and expiration settings when changing temporary log dir setting

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7350 from nextcloud/bugfix/updatechannels

Bugfix update channels

Fix compiling when BUILD_UPDATER is set to OFF.

Only connect signal/slot for update channels listing when BUILD_UPDATER is ON.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove check in setServerHasValidSubscription.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Address PR feedback.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Update config value when serverHasValidSubscription when accounts are added or removed.

To give priority to server susbscriptions and keep listing the right update channels.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix logic for initial load of update channels and priority for user with subscription.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Save serverHasValidsubcription in the account.

Signed-off-by: Camila Ayres <hello@camilasan.com>