Matthias Clasen [Sat, 20 May 2023 20:45:19 +0000 (16:45 -0400)]
gridview: Use gtk_list_item_manager_gc_tiles
This simplifies the code a bit.
Matthias Clasen [Sat, 20 May 2023 20:12:25 +0000 (16:12 -0400)]
listview: Use gtk_list_item_manager_gc_tiles
This simplifies the code a bit.
Matthias Clasen [Sat, 20 May 2023 20:12:54 +0000 (16:12 -0400)]
testsuite: Use gtk_list_item_manager_gc_tiles
Use this new api instead of open-coding it.
Also, assert that it merges consecutive
multi-item tiles.
Matthias Clasen [Sat, 20 May 2023 22:55:05 +0000 (18:55 -0400)]
listitemmanager: Stop exporting tile_gc
This function is now just used internally,
so make it static.
Matthias Clasen [Sat, 20 May 2023 22:52:44 +0000 (18:52 -0400)]
listitemmanager: Use gc_tiles
Replace an open-coded version of this function
with a call to gtk_list_item_manager_gc_tiles.
Matthias Clasen [Sat, 20 May 2023 20:10:54 +0000 (16:10 -0400)]
Add gtk_list_item_manager_gc_tiles
This will allow us to simplify size allocation
code in listview and gridview.
Benjamin Otte [Sat, 20 May 2023 17:18:53 +0000 (17:18 +0000)]
Merge branch 'drop-filler-tiles' into 'main'
Drop the FILLER tile type
See merge request GNOME/gtk!5993
Matthias Clasen [Sat, 20 May 2023 15:35:31 +0000 (11:35 -0400)]
gridview: Update factories in set_factory
Call update_factories() so the children get their
factories properly updated.
This matches what GtkListView does.
Matthias Clasen [Wed, 17 May 2023 23:13:12 +0000 (19:13 -0400)]
Drop the FILLER tile type
It is not used anymore.
Matthias Clasen [Wed, 17 May 2023 23:09:43 +0000 (19:09 -0400)]
gridview: Stop using a filler tile
We can just use the footer to fill that space.
Matthias Clasen [Wed, 17 May 2023 23:01:08 +0000 (19:01 -0400)]
gridview: Add an assertion
The want to use the footer tile at the end
to fill leftover space at the bottome right.
So lets assert that we actually dealing with
a footer tile, just in case something changes
in the future that might have us end up with
some other kind of tile.
Matthias Clasen [Thu, 18 May 2023 00:10:08 +0000 (20:10 -0400)]
Add some tile helpers
Matthias Clasen [Wed, 17 May 2023 23:26:12 +0000 (19:26 -0400)]
Revert "gridview: GC tiles first"
This reverts commit
e121a5ca6f761fc4433187bf1ad13a093ede205d.
The tile that was causing the critical in #5836
(what that commit was about) was a FILLER, and we
are getting rid of FILLER tiles here. Which will
avoid the issue in a more elegant way.
Matthias Clasen [Sat, 20 May 2023 11:39:21 +0000 (07:39 -0400)]
Cosmetics
Use the proper g_assert variant.
Matthias Clasen [Thu, 18 May 2023 19:10:52 +0000 (19:10 +0000)]
Merge branch 'ci-clang-build' into 'main'
ci: Add a clang build
See merge request GNOME/gtk!5987
Matthias Clasen [Wed, 17 May 2023 15:36:57 +0000 (11:36 -0400)]
ci: Add a clang build
This is meant to catch build errors with clang.
Matthias Clasen [Thu, 18 May 2023 18:39:22 +0000 (14:39 -0400)]
cups: Silence a compiler warning
Bitfields should be unsigned int.
Matthias Clasen [Wed, 17 May 2023 15:51:29 +0000 (11:51 -0400)]
gsk: Mark some variables as unused
Hopefully that shuts up clang.
Asier Sarasua Garmendia [Thu, 18 May 2023 16:30:55 +0000 (16:30 +0000)]
Update Basque translation
(cherry picked from commit
a6931a66c5ff08ce28863d3f61253f2389f6eed7)
Matthias Clasen [Thu, 18 May 2023 13:35:17 +0000 (13:35 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
roaring: Mark a variable as unused
See merge request GNOME/gtk!5990
Matthias Clasen [Thu, 18 May 2023 12:40:50 +0000 (08:40 -0400)]
testsuite: Make this test compile
clang did not like this creative use of
strings at all. Rightfully so.
Matthias Clasen [Thu, 18 May 2023 12:34:48 +0000 (08:34 -0400)]
roaring: Mark a variable as unused
Otherwise clang complains.
Matthias Clasen [Thu, 18 May 2023 12:26:05 +0000 (12:26 +0000)]
Merge branch 'fina/scrolled-window-measure' into 'main'
scrolledwindow: Propagate child measure size whenever possible
Closes #5838
See merge request GNOME/gtk!5986
Fina Wilke [Wed, 17 May 2023 22:55:50 +0000 (00:55 +0200)]
scrolledwindow: Propagate child measure size whenever possible
In height-for-width and hscrollbar-policy = never, we can provide
the child with a proper for_size when measuring it. The same is true for
width-for-height and vscrollbar-policy = never.
This allows for accurately measuring the size of eg. wrapping labels.
Benjamin Otte [Wed, 17 May 2023 18:57:28 +0000 (18:57 +0000)]
Merge branch 'listview-factory-leak' into 'main'
listview: Don't leak the factories
See merge request GNOME/gtk!5989
Matthias Clasen [Wed, 17 May 2023 18:32:55 +0000 (14:32 -0400)]
gridview: Don't leak the factory
Matthias Clasen [Wed, 17 May 2023 18:16:38 +0000 (14:16 -0400)]
listview: Don't leak the factories
Benjamin Otte [Wed, 17 May 2023 17:04:43 +0000 (17:04 +0000)]
Merge branch 'fix-gridview-critical' into 'main'
gridview: GC tiles first
Closes #5836
See merge request GNOME/gtk!5988
Matthias Clasen [Wed, 17 May 2023 16:30:16 +0000 (12:30 -0400)]
gridview: GC tiles first
Before checking that there are no tiles,
we need to gc any possibly leftover filler
tiles.
Fixes: #5836
Matthias Clasen [Wed, 17 May 2023 10:15:26 +0000 (10:15 +0000)]
Merge branch 'pathbar-early-return-on-cancellation' into 'main'
pathbar: Fail setting the path on cancellation
Closes #5792
See merge request GNOME/gtk!5982
Matthias Clasen [Wed, 17 May 2023 10:14:44 +0000 (10:14 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
Reduce pixbuf helpers
See merge request GNOME/gtk!5984
Matthias Clasen [Wed, 17 May 2023 02:00:08 +0000 (22:00 -0400)]
Rename pixbuf utils to texture utils
That is what this is now.
Matthias Clasen [Wed, 17 May 2023 01:53:55 +0000 (21:53 -0400)]
Reduce pixbuf helpers
Concentrate pixbuf handling in gdkpixbufutils.c.
Matthias Clasen [Wed, 17 May 2023 00:58:48 +0000 (00:58 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
gsk: Cosmetics
See merge request GNOME/gtk!5983
Matthias Clasen [Wed, 17 May 2023 00:29:40 +0000 (00:29 +0000)]
Merge branch 'gl-renderer-more-defensive' into 'main'
gsk: Stop setting uniforms when we are out of batches
See merge request GNOME/gtk!5981
Benjamin Otte [Wed, 17 May 2023 00:19:06 +0000 (00:19 +0000)]
Merge branch 'wip/otte/ci-emergency' into 'main'
CI: Actually build our code
See merge request GNOME/gtk!5980
Matthias Clasen [Tue, 16 May 2023 18:53:43 +0000 (14:53 -0400)]
gsk: Don't build unused functions
The only caller is #if 0 ed, so don't build
these functions.
Matthias Clasen [Tue, 16 May 2023 18:53:20 +0000 (14:53 -0400)]
gsk: Cosmetics
Get the context from the driver.
Matthias Clasen [Tue, 16 May 2023 17:45:38 +0000 (13:45 -0400)]
Improve test coverage for property lookup models
Olivier Crête [Wed, 17 May 2023 00:08:34 +0000 (01:08 +0100)]
pathbar: Fail setting the path on cancellation
The cancellation path already clears the GCancellable, if we let it
continue, it causes a later assertion, so just exit early in this case
and hope a new path has been set.
Fixes: #5792
Matthias Clasen [Wed, 17 May 2023 00:03:19 +0000 (20:03 -0400)]
gsk: Stop setting uniforms when we are out of batches
When the command queue is out of batches, there is
no point in doing further work like allocating uniforms.
This helps us avoid assertions in the uniform code
that we would hit when we run out of uniform space
too.
Benjamin Otte [Tue, 16 May 2023 23:52:42 +0000 (01:52 +0200)]
glrenderer: Remove unused function
Thanks, macos CI.
(We should have a Fedora clang build.)
Benjamin Otte [Tue, 16 May 2023 23:24:22 +0000 (01:24 +0200)]
tests: Remove some tests
They are failing to build because they use deprecated functions and
nobody thinks they're worth fixing.
Benjamin Otte [Tue, 16 May 2023 19:21:01 +0000 (21:21 +0200)]
CI: Actually build our code
Commit
3090795351404735672c45a02a577a4e4bf67586 accidentally caused all
CI builds (or at least the ones with -Werror) to no longer build tests,
examples and demos, so none of them had made sure that they compile.
Matthias Clasen [Tue, 16 May 2023 22:20:51 +0000 (22:20 +0000)]
Merge branch 'fix-gsk-assertions' into 'main'
gsk: Fix a crash
See merge request GNOME/gtk!5979
Matthias Clasen [Tue, 16 May 2023 21:32:13 +0000 (17:32 -0400)]
gsk: Fix a crash
When we start ignoring batches, we must do it everywhere,
or we may run into assertions. This was triggered by an
enormous text node tree produced by tests/rendernode-create.
Matthias Clasen [Tue, 16 May 2023 21:28:29 +0000 (21:28 +0000)]
Merge branch 'ebassi/issue-5837' into 'main'
Fix various compiler warnings with GCC 13
Closes #5837
See merge request GNOME/gtk!5977
Emmanuele Bassi [Tue, 16 May 2023 20:22:01 +0000 (21:22 +0100)]
Replace deprecated CSS loading API
Use gtk_css_provider_load_from_string() when loading CSS from C
strings.
Emmanuele Bassi [Tue, 16 May 2023 17:51:07 +0000 (18:51 +0100)]
Implement GtkSelectionModel for GtkNotebookPages
The documentation says that the model returned by
gtk_notebook_get_pages() implements the GtkSelectionModel interface, but
checking the history confirms this is a lie.
Instead of fixing the documentation, we can easily make it true, and
reduce the differences between GtkNotebook and GtkStack.
Fixes: #5837
Emmanuele Bassi [Tue, 16 May 2023 17:50:00 +0000 (18:50 +0100)]
Fix various compiler warnings with GCC 13
There are various null dereference warnings in GtkListItemManager that
make the build noisy.
Matthias Clasen [Tue, 16 May 2023 20:51:01 +0000 (20:51 +0000)]
Merge branch 'no-deprecations-in-demos' into 'main'
demos: Stop using deprecated api
See merge request GNOME/gtk!5978
Matthias Clasen [Tue, 16 May 2023 20:42:27 +0000 (20:42 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
Matthiasc/for main
See merge request GNOME/gtk!5975
Matthias Clasen [Tue, 16 May 2023 20:05:47 +0000 (16:05 -0400)]
demos: Stop using deprecated api
Use texture apis instead of pixbuf ones.
Matthias Clasen [Tue, 16 May 2023 17:25:17 +0000 (17:25 +0000)]
Merge branch 'wip/otte/for-main' into 'main'
gdk: Clamp frame region to surface size
Closes #5812
See merge request GNOME/gtk!5976
Benjamin Otte [Sun, 14 May 2023 21:12:23 +0000 (23:12 +0200)]
nodeparser: Move an error check
By putting the check earlier, it will be emitted for the right token.
Benjamin Otte [Fri, 12 May 2023 15:16:22 +0000 (17:16 +0200)]
node-editor: Print default renderer in title
If there is a value passed to GSK_RENDERER, display it in the window
title.
This is mostly so that when I show off screenshots, people know what
renderer I'm using.
Benjamin Otte [Tue, 16 May 2023 15:18:19 +0000 (17:18 +0200)]
vulkan: Make projection matrix match GL
Vulkan has a different initial coordinate system to GL.
GL:
(-1, 1, -1) +------+.
|`. | `.
| `·--|---·
| : | :
+------+. :
`. : `.:
`·------· (1, -1, 1)
Vulkan:
(-1, -1, 0) +------+.
|`. | `.
| `·--|---·
| : | :
+------+. :
`. : `.:
`·------· (1, 1, 1)
so adjust the near and far plane we pass to
graphene_matrix_init_ortho() to make it end up with the same
projection as the GL renderer.
Benjamin Otte [Wed, 10 May 2023 20:14:26 +0000 (22:14 +0200)]
testsuite: Add crossfade-clip-both-children test
This one tests a crossfade between two non-overlapping nodes with a clip
region that covers neither of the two nodes.
This tests that renderers can deal with clip regions that doesn't
overlap nodes in a situation where they will most likely want to create
an offscreen.
As offscreens are typically clipped to the clip region, this would cause
an empty offscreen and that can cause failures.
Benjamin Otte [Wed, 10 May 2023 19:56:53 +0000 (21:56 +0200)]
testsuite: Add clip-translate-offscreen test
This was an experiment where an offscreen was translated inside an
existing clip.
Because renderers try to limit offscreens to the clip rect, this is
interesting, because they might get the translation wrong.
Benjamin Otte [Fri, 5 May 2023 02:53:08 +0000 (04:53 +0200)]
rendernode: clip when drawing shadows
Ensures the shadow stays small.
Benjamin Otte [Thu, 4 May 2023 23:39:31 +0000 (01:39 +0200)]
build: Make shaders depend on their includes
This does not do any proper dependency tracking, it just makes every
shader depend on every include shader.
But that's good enough for now.
Benjamin Otte [Thu, 11 May 2023 23:31:26 +0000 (01:31 +0200)]
vulkan: Fix typo in clipping code
Benjamin Otte [Fri, 5 May 2023 05:36:03 +0000 (07:36 +0200)]
build: Add a new gcc 13 warning
We don't trigger it and it's a useful warning. So let's use it.
Benjamin Otte [Fri, 12 May 2023 17:20:58 +0000 (19:20 +0200)]
css: Remove crashy resource:// optimization
Using gdk_texture_new_from_resource() is not valid here because we are
not sure if the given resource is valid.
Plus, the previous optimization is no longer relevant, because we are
not using gdk_pixbuf_new_from_resource() anymore - which was what this
optimization was about before it was ported to GdkTexture.
Test attached.
Benjamin Otte [Tue, 16 May 2023 15:29:31 +0000 (17:29 +0200)]
testsuite: Add testcase for z clipping
the near and far clipping plane are at -10000 and 10000 respectively.
Test that the renderers respect that.
Benjamin Otte [Tue, 16 May 2023 16:08:21 +0000 (18:08 +0200)]
gridview: Add border-spacing where it was missed
We were computing column widths without taking border-spacing into
account, making them slightly too big.
Benjamin Otte [Sat, 13 May 2023 16:35:02 +0000 (18:35 +0200)]
gdk: Clamp frame region to surface size
The region may be larger than the surface's size, but many rendering
APIs require the size to be clamped.
Fixes #5812
Matthias Clasen [Tue, 16 May 2023 15:56:47 +0000 (11:56 -0400)]
Cosmetics
Matthias Clasen [Tue, 16 May 2023 15:56:25 +0000 (11:56 -0400)]
Improve test coverage for sorters
Matthias Clasen [Tue, 16 May 2023 15:55:40 +0000 (11:55 -0400)]
Improve test coverage for GtkPropertyLookupListModel
Matthias Clasen [Tue, 16 May 2023 16:31:35 +0000 (16:31 +0000)]
Merge branch 'fix-property-lookup-model' into 'main'
Fix a few bugs in GtkPropertyLookupListModel
See merge request GNOME/gtk!5974
Matthias Clasen [Tue, 16 May 2023 15:54:59 +0000 (11:54 -0400)]
Fix a few bugs in GtkPropertyLookupListModel
Fix bugs in property types.
Matthias Clasen [Tue, 16 May 2023 12:48:40 +0000 (12:48 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
gdk: Drop some unused private api
See merge request GNOME/gtk!5973
Matthias Clasen [Tue, 16 May 2023 03:21:06 +0000 (23:21 -0400)]
Improve test coverage for GtkStringSorter
Matthias Clasen [Tue, 16 May 2023 03:06:07 +0000 (23:06 -0400)]
Only build iconcache validator if it is used
Matthias Clasen [Tue, 16 May 2023 02:41:10 +0000 (22:41 -0400)]
Drop unneeded exports from gdkpixbufutils.c
Matthias Clasen [Tue, 16 May 2023 02:12:33 +0000 (22:12 -0400)]
Drop an unused include
Matthias Clasen [Tue, 16 May 2023 01:46:02 +0000 (21:46 -0400)]
docs: Mention pixbufs in the migration guide
Matthias Clasen [Tue, 16 May 2023 01:40:54 +0000 (21:40 -0400)]
Deprecate from-pixbuf apis for widgets
We want to drop GdkPixbuf from our apis.
These have easy replacements already, so
lets deprecate them.
Matthias Clasen [Tue, 16 May 2023 00:27:16 +0000 (20:27 -0400)]
gdk: Drop some unused private api
Matthias Clasen [Tue, 16 May 2023 00:09:56 +0000 (00:09 +0000)]
Merge branch 'wip/corey/filesystemmodel' into 'main'
filesystemmodel: Ignore changes on the parent directory
Closes #4233
See merge request GNOME/gtk!5970
Matthias Clasen [Tue, 16 May 2023 00:02:15 +0000 (00:02 +0000)]
Merge branch 'matthiasc/for-main' into 'main'
tools: Cosmetics
See merge request GNOME/gtk!5972
Matthias Clasen [Mon, 15 May 2023 23:11:35 +0000 (19:11 -0400)]
Fix texture tests with GLES
No sync for you if you're using GLES.
Matthias Clasen [Mon, 15 May 2023 23:03:42 +0000 (23:03 +0000)]
Merge branch 'deprecate-pixbuf-apis' into 'main'
gdk: Deprecated some pixbuf apis
See merge request GNOME/gtk!5971
Corey Berla [Mon, 15 May 2023 20:10:21 +0000 (13:10 -0700)]
filesystemmodel: Ignore changes on the parent directory
The filesystemmodel tracks changes and additions to child files
through G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED. This event will also
occur if the parent directory is changed. Since the parent directory
doesn't exist in the model, it creates a non-existent item.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/4233
Corey Berla [Mon, 15 May 2023 20:09:52 +0000 (13:09 -0700)]
filechooserwidget: Stop leaking file system models
Matthias Clasen [Mon, 15 May 2023 22:21:08 +0000 (18:21 -0400)]
gdk: Deprecated some pixbuf apis
These are already documented as 'don't use
in new apis'. Lets make it official and
deprecate them properly.
Matthias Clasen [Mon, 15 May 2023 20:49:12 +0000 (16:49 -0400)]
Improve test coverage for GdkGLContext
Corey Berla [Mon, 15 May 2023 20:08:56 +0000 (13:08 -0700)]
.gitignore: Ignore .flatpak-builder directory
Matthias Clasen [Mon, 15 May 2023 19:25:11 +0000 (15:25 -0400)]
Cosmetics
Linkify a reference.
Matthias Clasen [Mon, 15 May 2023 19:24:56 +0000 (15:24 -0400)]
Add tests for GdkTextureDownloader
Matthias Clasen [Mon, 15 May 2023 16:50:28 +0000 (12:50 -0400)]
Test gltexture update functionality
Matthias Clasen [Mon, 15 May 2023 15:56:31 +0000 (11:56 -0400)]
Improve gdk test coverage
Matthias Clasen [Mon, 15 May 2023 12:03:20 +0000 (08:03 -0400)]
tools: Cosmetics
Make gtk-builder-tool screenshot be quiet unless
it had to make up a filename. And tweak --help
output a bit.
Matthias Clasen [Mon, 15 May 2023 10:12:29 +0000 (10:12 +0000)]
Merge branch 'export-handles-properly' into 'main'
Add testfilelauncher
See merge request GNOME/gtk!5968
Matthias Clasen [Sun, 14 May 2023 18:11:12 +0000 (14:11 -0400)]
Add testfilelauncher
This is a test to use GtkFileLauncher a bit
more intensively than usual.
Matthias Clasen [Sun, 14 May 2023 23:14:58 +0000 (19:14 -0400)]
wayland: Try harder to be compatible
We can keep the old unexport_handle api working
in the case that there is only a single exported
handle.
Matthias Clasen [Sun, 14 May 2023 21:34:35 +0000 (17:34 -0400)]
Deprecate gdk_wayland_toplevel_unexport_handle
It doesn't do anything anymore, and is no longer
used internally. The replacement is
gdk_wayland_toplevel_drop_exported_handled().
Matthias Clasen [Sun, 14 May 2023 21:38:11 +0000 (17:38 -0400)]
wayland: Reimplement exporting
Change things so that every call to export_handle
creates a new handle, and unexport_handle destroys
the handle that it is given.
Matthias Clasen [Sun, 14 May 2023 21:37:41 +0000 (17:37 -0400)]
wayland: Give toplevels a destroy hook
We will need to do some cleanup before the
wl_surface is destroyed, so add a hook for that.