emacs.git
17 months ago; Fix last change
Eli Zaretskii [Wed, 17 Jul 2024 11:10:50 +0000 (14:10 +0300)]
; Fix last change

* doc/lispref/windows.texi (Dedicated Windows):
* doc/emacs/windows.texi (Displaying Buffers): Mention keybinding.

17 months agoFix 'toggle-window-dedicated' documentation
Robert Pluim [Wed, 17 Jul 2024 07:38:43 +0000 (09:38 +0200)]
Fix 'toggle-window-dedicated' documentation

* doc/emacs/windows.texi (Displaying Buffers): Fix the cross reference
to the elisp manual.  Add missing 'toggle-window-dedicated'.
* doc/lispref/windows.texi (Dedicated Windows): Mention
'toggle-window-dedicated'.

17 months ago; * doc/lispref/help.texi (Keys in Documentation): Add cross-reference.
Eli Zaretskii [Tue, 16 Jul 2024 14:35:42 +0000 (17:35 +0300)]
; * doc/lispref/help.texi (Keys in Documentation): Add cross-reference.

17 months agoCheckdoc fixes in transient.el
Stefan Kangas [Tue, 16 Jul 2024 01:35:59 +0000 (03:35 +0200)]
Checkdoc fixes in transient.el

* lisp/transient.el (transient-format-description): Checkdoc fixes.

17 months agoFix intermittent failure of dired-test-bug27243-02
Peter Oliver [Mon, 15 Jul 2024 11:03:47 +0000 (12:03 +0100)]
Fix intermittent failure of dired-test-bug27243-02

* test/lisp/dired-tests.el (dired-test-bug27243-02): Exclude free disk
space from dired listing in this test, in case it changes while it's
running and confuses the result.  (Bug#72120)

17 months ago* etc/TODO: Refer to Bug#72127 for Magit assignments.
Stefan Kangas [Mon, 15 Jul 2024 20:59:50 +0000 (22:59 +0200)]
* etc/TODO: Refer to Bug#72127 for Magit assignments.

17 months agoRename treesitter test
Michael Albinus [Mon, 15 Jul 2024 17:25:42 +0000 (19:25 +0200)]
Rename treesitter test

* test/lisp/align-tests.el (align-ts-lua): Rename test in order to
fit to treesitter tests on EMBA.

17 months agoAdapt tressitter tests on EMBA
Michael Albinus [Mon, 15 Jul 2024 17:24:56 +0000 (19:24 +0200)]
Adapt tressitter tests on EMBA

* test/infra/Makefile.in (TREE-SITTER-FILES): Simplify.

* test/infra/test-jobs.yml: Regenerate.

17 months agoSupport passing signals like 'SIGCODE' to 'tramp-signal-process'
Jim Porter [Sun, 14 Jul 2024 22:07:28 +0000 (15:07 -0700)]
Support passing signals like 'SIGCODE' to 'tramp-signal-process'

POSIX specifies that "kill" should take signal names without the "SIG"
prefix.

* lisp/net/tramp.el (tramp-signal-process): Strip the "SIG" prefix when
present.

17 months agoMerge branch 'emacs-30' of git.sv.gnu.org:/srv/git/emacs into emacs-30
Michael Albinus [Mon, 15 Jul 2024 16:20:59 +0000 (18:20 +0200)]
Merge branch 'emacs-30' of git.sv.gnu.org:/srv/git/emacs into emacs-30

17 months ago; Replace quotes with @code{...} in texinfo files
Steven Allen [Mon, 15 Jul 2024 16:20:24 +0000 (18:20 +0200)]
; Replace quotes with @code{...} in texinfo files

* doc/misc/cc-mode.texi:
* doc/misc/cl.texi: Replace quotes with @code{...}

17 months ago; Replace (non-)nil with (non-)@code{nil} in texinfo files
Steven Allen [Mon, 15 Jul 2024 16:16:41 +0000 (18:16 +0200)]
; Replace (non-)nil with (non-)@code{nil} in texinfo files

* doc/lispref/functions.texi:
* doc/lispref/keymaps.texi:
* doc/lispref/strings.texi:
* doc/misc/cl.texi:
* doc/misc/dbus.texi:
* doc/misc/eshell.texi:
* doc/misc/message.texi:
* doc/misc/ses.texi:
* doc/misc/vtable.texi: Replace (non-)nil with (non-)@code{nil}.

17 months agoDon't save to history from 'eshell-command' when aborting
Jim Porter [Sat, 13 Jul 2024 18:43:42 +0000 (11:43 -0700)]
Don't save to history from 'eshell-command' when aborting

* lisp/eshell/eshell.el (eshell-add-input-to-history)
(eshell--save-history): Declare.
(eshell-command-mode-exit): New function...
(eshell-command-mode): ... use it.

* lisp/eshell/em-hist.el (eshell-hist-initialize): Don't handle
minibuffer logic here.  Always read history file (this ensures that
'eshell-command' can see the history, too).
(eshell-add-command-to-history): Remove.

17 months agoUpdate to Org 9.7.7-2-gf308d3
Kyle Meyer [Sun, 14 Jul 2024 16:30:50 +0000 (12:30 -0400)]
Update to Org 9.7.7-2-gf308d3

17 months agoFix decoding 'display' properties with SVG images in Enriched mode
Eli Zaretskii [Sun, 14 Jul 2024 06:06:55 +0000 (09:06 +0300)]
Fix decoding 'display' properties with SVG images in Enriched mode

* lisp/textmodes/enriched.el (enriched-next-annotation): Reject
matches of 'enriched-annotation-regexp' inside strings.  Reported
by Christopher Howard <christopher@librehacker.com> in
https://lists.gnu.org/archive/html/help-gnu-emacs/2024-06/msg00178.html.

17 months ago* configure.ac (D8): Fix typo.
Pip Cet [Sun, 14 Jul 2024 05:41:17 +0000 (05:41 +0000)]
* configure.ac (D8): Fix typo.

17 months ago; * src/android.c (setEmacsParams): Delete unused variable.
Po Lu [Sun, 14 Jul 2024 04:51:48 +0000 (12:51 +0800)]
; * src/android.c (setEmacsParams): Delete unused variable.

17 months agoDo not set LD_LIBRARY_PATH during Android initialization
Po Lu [Sun, 14 Jul 2024 04:46:23 +0000 (12:46 +0800)]
Do not set LD_LIBRARY_PATH during Android initialization

* doc/emacs/android.texi (Android Environment): Adjust
documentation to match.

* java/org/gnu/emacs/EmacsNoninteractive.java (main1): New
function.  Remove initialization of EmacsNative hither.
(main): Acquire an ApplicationInfo or LoadedApk, as the case may
be on the host system, derive a ClassLoader from the result, and
load and call `main1' from within this class loader.

* src/android-emacs.c (main):

* src/android.c (setEmacsParams): Do not override
LD_LIBRARY_PATH or set EMACS_LD_LIBRARY_PATH.  This enables
Emacs to execute subprocesses in certain "fortified" Android
systems, amongst other things.

17 months ago; Set Transient's version
Jonas Bernoulli [Sat, 13 Jul 2024 19:59:20 +0000 (21:59 +0200)]
; Set Transient's version

17 months ago; Fix typos in 'which-key-mode' (bug#72093)
john muhl [Wed, 10 Jul 2024 22:13:58 +0000 (17:13 -0500)]
; Fix typos in 'which-key-mode' (bug#72093)

* lisp/which-key.el (which-key-preserve-window-configuration):
Correct spelling of "taken".
(which-key--create-pages): Correct spelling of "widths".
(which-key--start-paging-timer): Correct spelling of
"secondary".

17 months ago; * src/w32fns.c (Fw32_notification_close): Fix typo (bug#72091).
Raffael Stocker [Sat, 13 Jul 2024 11:26:23 +0000 (13:26 +0200)]
; * src/w32fns.c (Fw32_notification_close): Fix typo (bug#72091).

17 months ago* test/lisp/wdired-tests.el (wdired-test-bug34915): Fix for MS-Windows.
Eli Zaretskii [Sat, 13 Jul 2024 12:06:43 +0000 (15:06 +0300)]
* test/lisp/wdired-tests.el (wdired-test-bug34915): Fix for MS-Windows.

17 months agoFix 'wdired-test-unfinished-edit-01'
Peter Oliver [Fri, 12 Jul 2024 09:52:23 +0000 (10:52 +0100)]
Fix 'wdired-test-unfinished-edit-01'

* test/lisp/wdired-tests.el (wdired-test-unfinished-edit-01):
Don't modify the random directory name if, by chance, it happens
to contain the substring "foo" anywhere but immediately after the
slash.  (Bug#72073)

17 months ago; * src/search.c (Fre_search_forward): Clarify doc string (bug#71879).
Eli Zaretskii [Sat, 13 Jul 2024 10:22:01 +0000 (13:22 +0300)]
; * src/search.c (Fre_search_forward): Clarify doc string (bug#71879).

17 months agoFontify destructor in c++-ts-mode
Vincenzo Pupillo [Mon, 1 Jul 2024 09:52:18 +0000 (11:52 +0200)]
Fontify destructor in c++-ts-mode

* lisp/progmodes/c-ts-mode.el (c-ts-mode--font-lock-settings):
Add a rule for destructors.  (Bug#71872)

17 months agoFix invalid defcustom type for erc-buffers option
F. Jason Park [Fri, 12 Jul 2024 21:41:54 +0000 (14:41 -0700)]
Fix invalid defcustom type for erc-buffers option

* lisp/erc/erc.el (erc-ensure-target-buffer-on-privmsg): Change
invalid inner `choice' to a `const' for the third-state `status'
variant, which is new in ERC 5.6 and Emacs 30.  Thanks to Mattias
Engdegård for catching this.

17 months ago; Fix 'ibuffer-do-isearch{-regexp}'
Eshel Yaron [Sat, 6 Jul 2024 18:53:06 +0000 (20:53 +0200)]
; Fix 'ibuffer-do-isearch{-regexp}'

* lisp/ibuf-ext.el (ibuffer-do-isearch)
(ibuffer-do-isearch-regexp): Use 'defun' instead of
'define-ibuffer-op'.  (Bug#71927)

17 months agoFix infloop in 'shell-resync-dirs'
Eli Zaretskii [Fri, 12 Jul 2024 06:58:53 +0000 (09:58 +0300)]
Fix infloop in 'shell-resync-dirs'

* lisp/shell.el (shell-eval-command): Fix detection of newline
after last output line.  (Bug#71896)
(shell-resync-dirs): Make sure the inner loop never infloops.
Suggested by Troy Hinckley <troyhinckley@dabrev.com>.

17 months ago; * src/image.c (free_image_cache): Add assertion. (Bug#71929)
Eli Zaretskii [Fri, 12 Jul 2024 06:39:39 +0000 (09:39 +0300)]
; * src/image.c (free_image_cache): Add assertion.  (Bug#71929)

17 months agoRender more Android functions safe to execute in a batch session
Po Lu [Fri, 12 Jul 2024 06:31:33 +0000 (14:31 +0800)]
Render more Android functions safe to execute in a batch session

* src/androidfns.c (Fx_display_mm_width, Fx_display_mm_height)
(Fandroid_display_monitor_attributes_list)
(Fandroid_external_storage_available_p)
(Fandroid_request_storage_access): Verify that a display
connection or service object is available.

* src/androidselect.c (Fandroid_get_clipboard)
(Fandroid_browse_url_internal, Fandroid_get_clipboard_targets)
(Fandroid_get_clipboard_data, Fandroid_notifications_notify):
Moderate tone of error messages.

17 months agoDocument means of executing Emacs from unrelated Android applications
Po Lu [Fri, 12 Jul 2024 03:59:09 +0000 (11:59 +0800)]
Document means of executing Emacs from unrelated Android applications

* doc/emacs/android.texi (Android Environment): Document
significance, effect and purpose of EMACS_CLASS_PATH and
EMACS_LD_LIBRARY_PATH, and the utility of `pm path
org.gnu.emacs'.

17 months agoDon't emit a prompt in Eshell when a background command is killed
Jim Porter [Tue, 9 Jul 2024 17:45:35 +0000 (10:45 -0700)]
Don't emit a prompt in Eshell when a background command is killed

* lisp/eshell/esh-cmd.el (eshell-resume-command): Check for
background-ness before resetting the prompt.

* test/lisp/eshell/esh-cmd-tests.el
(esh-cmd-test/background/simple-command): Make the regexp a bit
stricter.
(esh-cmd-test/background/kill): New test.

17 months agoFix reference from buffer-stale-function docstring
Daniel Martín [Wed, 10 Jul 2024 23:22:04 +0000 (01:22 +0200)]
Fix reference from buffer-stale-function docstring

* lisp/files.el (buffer-stale-function): Fix reference to a
non-existent Info node in doc string.  (Bug#72049)

17 months agoTake precautions against ill-formed content URIs
Po Lu [Thu, 11 Jul 2024 03:38:41 +0000 (11:38 +0800)]
Take precautions against ill-formed content URIs

* java/org/gnu/emacs/EmacsService.java (openContentUri)
(checkContentUri): Verify that URIs derived from user-provided
file names can be parsed before attempting to open them.

17 months agoetags-regen-mode: Handle TAGS buffer being killed
Dmitry Gutov [Thu, 11 Jul 2024 00:49:06 +0000 (03:49 +0300)]
etags-regen-mode: Handle TAGS buffer being killed

* lisp/progmodes/etags-regen.el (etags-regen--visit-table):
Use kill-buffer-hook to ensure a refresh if the TAGS buffer is
killed manually (bug#71727).
(etags-regen--tags-cleanup):
Bind the hook var to nil to avoid an infloop.

17 months ago; Tag ERC multiline blanks test as :expensive
F. Jason Park [Wed, 10 Jul 2024 22:36:38 +0000 (15:36 -0700)]
; Tag ERC multiline blanks test as :expensive

* test/lisp/erc/erc-tests.el
(erc--check-prompt-input-for-multiline-blanks): Move message-capturing
business outside of primary fixture.  Extend subprocess sleep duration
to 5m.  Delete some unreachable code.  (Bug#72004)

17 months agoImprove 'put-image' documentation
Robert Pluim [Tue, 9 Jul 2024 15:14:45 +0000 (17:14 +0200)]
Improve 'put-image' documentation

* doc/lispref/display.texi (Showing Images): Mention that it returns the
created overlay.
* lisp/image.el (put-image): And here.

17 months agoImprove 'set-fontset-font' documentation
Robert Pluim [Fri, 19 Apr 2024 13:16:34 +0000 (15:16 +0200)]
Improve 'set-fontset-font' documentation

* doc/emacs/mule.texi (Modifying Fontsets): Add an 'emoji' example.

17 months agoAdapt Tramp's "run0" method
Michael Albinus [Wed, 10 Jul 2024 09:58:22 +0000 (11:58 +0200)]
Adapt Tramp's "run0" method

* doc/misc/tramp.texi (Inline methods):
* etc/NEWS: Adapt "run0" entry.

* lisp/net/tramp-sh.el (tramp-enable-run0-method): Adapt "run0"
arguments.

17 months ago* test/src/sqlite-tests.el (sqlite-execute-batch): Declare to wave warning.
Andrea Corallo [Tue, 9 Jul 2024 19:17:48 +0000 (21:17 +0200)]
* test/src/sqlite-tests.el (sqlite-execute-batch): Declare to wave warning.

17 months agoCapitalize "Dired" and "Lisp" in docstrings
Stefan Kangas [Tue, 9 Jul 2024 22:26:22 +0000 (00:26 +0200)]
Capitalize "Dired" and "Lisp" in docstrings

* lisp/desktop.el (desktop-no-desktop-file-hook):
* lisp/dired-x.el (dired-mark-sexp):
* lisp/dired.el (dired-make-directory-clickable)
(dired-map-over-marks, dired-file-name-at-point)
(dired-save-positions, dired-buffers-for-dir)
(dired-buffers-for-dir-or-subdir, dired-fun-in-all-buffers)
(dired-remove-entry, dired-delete-entry, dired-jump):
* lisp/files.el (save-buffer):
* lisp/find-dired.el (find-ls-option):
* lisp/hilit-chg.el:
* lisp/locate.el (locate-mode):
* lisp/msb.el (msb-dired-item-handler, msb-sort-by-directory):
* lisp/printing.el (pr-ps-printer-alist, pr-ps-utility-alist):
* lisp/uniquify.el (uniquify-trailing-separator-p):
* lisp/wdired.el (wdired, wdired-change-to-dired-mode, wdired-exit):
* lisp/woman.el (woman-dired-define-keys, woman-dired-find-file):
Capitalize "Dired" and "Lisp" in docstrings.  Found with checkdoc.

17 months agoDocument Eshell entry points
Jim Porter [Mon, 8 Jul 2024 04:24:47 +0000 (21:24 -0700)]
Document Eshell entry points

* doc/misc/eshell.texi (Entry Points): New chapter.
(Scripts): Move under Entry Points.  Expand documentation.

17 months agoFix bug#71929
Po Lu [Tue, 9 Jul 2024 14:00:39 +0000 (22:00 +0800)]
Fix bug#71929

* src/image.c (free_image_cache): Unconditionally release image
cache, as this function is only called with its existence
already established.

* src/xfaces.c (free_frame_faces): Clear FRAME_IMAGE_CACHE (f).
(bug#71929)

17 months ago; Change `imap-shell-host` docstring to mention SSH
Stefan Kangas [Tue, 9 Jul 2024 12:09:20 +0000 (14:09 +0200)]
; Change `imap-shell-host` docstring to mention SSH

* lisp/net/imap.el (imap-shell-host): Doc fix; mention SSH instead of
rlogin.

17 months agoFix bug#70697 with respect to fringe bitmaps
Po Lu [Tue, 9 Jul 2024 06:10:07 +0000 (14:10 +0800)]
Fix bug#70697 with respect to fringe bitmaps

* src/pgtkterm.c (pgtk_draw_fringe_bitmap): Always call
`fill_background_by_face' for clearing backgrounds of fringe
bitmaps.  (bug#70697)

17 months agoFix byte-compiler warning in calc.el
Po Lu [Tue, 9 Jul 2024 01:35:16 +0000 (09:35 +0800)]
Fix byte-compiler warning in calc.el

* lisp/calc/calc.el
(calc-embedded-open-close-new-formula-alist): Remove previously
introduced quotation marks, as they bring the width of the doc
string past 80.

17 months agoeditorconfig-core-handle.el: Fix regressions in fnmatch handling
Stefan Monnier [Mon, 8 Jul 2024 21:09:31 +0000 (17:09 -0400)]
editorconfig-core-handle.el: Fix regressions in fnmatch handling

* lisp/editorconfig-core-handle.el
(editorconfig-core-handle-get-properties-hash): Fix computation of
relative file name.
(editorconfig-core-handle--fnmatch-p): Handle the case when `pattern`
doesn't have a `/` but does match the `/` character.

17 months agoCheckdoc fixes in `url/*.el`
Stefan Kangas [Mon, 8 Jul 2024 15:49:14 +0000 (17:49 +0200)]
Checkdoc fixes in `url/*.el`

* lisp/url/url-util.el (url-query-key-value-allowed-chars):
* lisp/url/url.el (url-retrieve-synchronously): Checkdoc fixes.

17 months agoCheckdoc fixes in `term/*.el`
Stefan Kangas [Mon, 8 Jul 2024 15:47:21 +0000 (17:47 +0200)]
Checkdoc fixes in `term/*.el`

* lisp/term/android-win.el (android-clear-preedit-text):
* lisp/term/pgtk-win.el (featurep):
* lisp/term/x-win.el (x-clear-preedit-text): Checkdoc fixes.

17 months agoCheckdoc fixes in `mh-e/*.el`
Stefan Kangas [Mon, 8 Jul 2024 15:39:51 +0000 (17:39 +0200)]
Checkdoc fixes in `mh-e/*.el`

* lisp/mh-e/mh-e.el (mh-tool-bar):
* lisp/mh-e/mh-folder.el (mh-folder-mode):
* lisp/mh-e/mh-search.el (mh-pick-menu, mh-search-mode):
* lisp/mh-e/mh-show.el (mh-show-mode): Checkdoc fixes.

17 months agoCheckdoc fixes in `calc/*.el`
Stefan Kangas [Mon, 8 Jul 2024 14:44:17 +0000 (16:44 +0200)]
Checkdoc fixes in `calc/*.el`

* lisp/calc/calc.el (calc-embedded-open-close-new-formula-alist):
Checkdoc fixes.

17 months agoCheckdoc fixes in `textmodes/*.el`
Stefan Kangas [Mon, 8 Jul 2024 15:16:32 +0000 (17:16 +0200)]
Checkdoc fixes in `textmodes/*.el`

* lisp/textmodes/ispell.el (ispell-command-loop):
* lisp/textmodes/mhtml-mode.el (mhtml--construct-submode):
* lisp/textmodes/page-ext.el (pages-set-delimiter):
* lisp/textmodes/refbib.el (r2b-get-field, r2b-put-field):
* lisp/textmodes/refer.el (refer-cache-bib-files):
* lisp/textmodes/reftex-index.el (reftex-index-phrase-selection-or-word):
(reftex-index-phrases-mode):
* lisp/textmodes/table.el (table-insert, table--fill-region-strictly):
Checkdoc fixes.

17 months agoCheckdoc fixes in `gnus/*.el`
Stefan Kangas [Mon, 8 Jul 2024 15:07:03 +0000 (17:07 +0200)]
Checkdoc fixes in `gnus/*.el`

* lisp/gnus/gnus-agent.el (gnus-agent-enable-expiration)
(gnus-agent-with-refreshed-group, gnus-agentize)
(gnus-agent-fetch-headers, gnus-agent-update-files-total-fetched-for)
(gnus-agent-update-view-total-fetched-for):
* lisp/gnus/gnus-art.el (gnus-article-address-banner-alist)
(gnus-default-article-saver, gnus-mime-view-part-as-charset)
(gnus-block-private-groups, gnus-article-edit-mode):
* lisp/gnus/gnus-dired.el (gnus-dired-mode, gnus-dired-attach)
(gnus-dired-find-file-mailcap, gnus-dired-print):
* lisp/gnus/gnus-msg.el (gnus-summary-attach-article):
* lisp/gnus/gnus-score.el (gnus-home-score-file):
* lisp/gnus/gnus-search.el (gnus-search-ignored-newsgroups)
(gnus-search-mu-switches, gnus-search-mu-remove-prefix)
(gnus-search-thread):
* lisp/gnus/gnus-sieve.el (gnus-sieve-string-list):
* lisp/gnus/message.el (message-beginning-of-line):
* lisp/gnus/mm-url.el:
* lisp/gnus/mm-view.el (mm-w3m-setup, mm-setup-w3m):
* lisp/gnus/mml-sec.el (mml-signencrypt-style):
* lisp/gnus/nndiary.el:
* lisp/gnus/nnimap.el (nnimap-server-port, nnimap-use-namespaces)
(nnimap-expunge):
* lisp/gnus/nnmail.el (nnmail-incoming-coding-system):
(nnmail-ignore-broken-references):
* lisp/gnus/nnmairix.el (nnmairix-default-group):
* lisp/gnus/nntp.el (nntp-report):
* lisp/gnus/nnvirtual.el (nnvirtual-update-read-and-marked):
(nnvirtual-partition-sequence):
* lisp/gnus/spam-stat.el (spam-stat-process-directory-age)
(spam-stat-last-saved-at, spam-stat-save):
* lisp/gnus/spam.el (spam-enter-ham-BBDB, spam-check-BBDB):
Checkdoc fixes.

17 months agoCheckdoc fixes in `eshell/*.el`
Stefan Kangas [Mon, 8 Jul 2024 14:50:17 +0000 (16:50 +0200)]
Checkdoc fixes in `eshell/*.el`

* lisp/eshell/em-elecslash.el:
* lisp/eshell/em-extpipe.el:
* lisp/eshell/em-pred.el (eshell-get-delimited-modifier-argument):
* lisp/eshell/esh-cmd.el (eshell--unmark-deferrable)
(eshell-named-command-hook):
* lisp/eshell/esh-module.el (eshell-module--feature-name):
* lisp/eshell/esh-util.el (eshell-find-delimiter): Checkdoc fixes.

17 months agoCheckdoc fixes in `emulation/*.el`
Stefan Kangas [Mon, 8 Jul 2024 14:43:27 +0000 (16:43 +0200)]
Checkdoc fixes in `emulation/*.el`

* lisp/emulation/cua-base.el:
* lisp/emulation/viper-mous.el (viper-parse-mouse-key):
* lisp/emulation/viper.el (viper-major-mode-modifier-list):
Checkdoc fixes.

17 months agoCheckdoc fixes in `erc/*.el`
Stefan Kangas [Mon, 8 Jul 2024 14:41:02 +0000 (16:41 +0200)]
Checkdoc fixes in `erc/*.el`

* lisp/erc/erc-backend.el (erc-server-parameters):
* lisp/erc/erc-button.el (erc-button--display-error-with-buttons):
* lisp/erc/erc-dcc.el (erc-dcc-member):
* lisp/erc/erc-fill.el (erc-fill-wrap-refill-buffer):
* lisp/erc/erc-speedbar.el (erc-speedbar--last-ran):
* lisp/erc/erc-stamp.el (erc-stamp--current-time):
* lisp/erc/erc-track.el (erc-make-mode-line-buffer-name):
* lisp/erc/erc.el (erc-interactive-display, erc-modules, erc-cmd-CLEAR)
(erc-update-current-channel-member, erc--format-user-modes)
(erc-check-text-conversion): Checkdoc fixes.

17 months agoCheckdoc fixes in `vc/*.el`
Stefan Kangas [Mon, 8 Jul 2024 12:37:29 +0000 (14:37 +0200)]
Checkdoc fixes in `vc/*.el`

* lisp/vc/ediff-init.el (ediff-start-narrowed)
(ediff-buffer-values-orig-A, ediff-buffer-values-orig-B)
(ediff-buffer-values-orig-C, ediff-buffer-values-orig-Ancestor):
* lisp/vc/ediff-mult.el:
* lisp/vc/ediff-ptch.el (ediff-get-patch-buffer):
* lisp/vc/emerge.el (emerge-before-flag, emerge-after-flag):
* lisp/vc/vc-dav.el (vc-dav-checkin):
* lisp/vc/vc-git.el (vc-git-command):
* lisp/vc/vc-hg.el (vc-hg-command):
* lisp/vc/vc-src.el (vc-src-command):
* lisp/vc/vc-svn.el (vc-svn-command):
* lisp/vc/vc.el (vc-checkin): Checkdoc fixes.

17 months agoCheckdoc fixes in `emacs-lisp/*.el`
Stefan Kangas [Mon, 8 Jul 2024 12:30:37 +0000 (14:30 +0200)]
Checkdoc fixes in `emacs-lisp/*.el`

* lisp/emacs-lisp/bytecomp.el (byte-compile-free-vars-warn)
(byte-compile-out):
* lisp/emacs-lisp/eldoc.el (eldoc-documentation-functions):
* lisp/emacs-lisp/find-func.el (find-ert-deftest-regexp):
* lisp/emacs-lisp/macroexp.el (byte-compile-form-stack):
Checkdoc fixes.

17 months agoCheckdoc fixes in `mail/*.el`
Stefan Kangas [Mon, 8 Jul 2024 12:24:33 +0000 (14:24 +0200)]
Checkdoc fixes in `mail/*.el`

* lisp/mail/feedmail.el (feedmail-mail-send-hook-splitter)
(feedmail-queue-runner-message-sender):
* lisp/mail/mail-extr.el (mail-extr-nuke-outside-range):
* lisp/mail/rmail.el (rmail-automatic-folder-directives)
(rmail-summary-displayed):
* lisp/mail/rmailmm.el (rmail-mime-searching):
* lisp/mail/sendmail.el (mail-mode):
* lisp/mail/supercite.el (sc-mail-last-header-nuked-p): Checkdoc fixes.

17 months agoCheckdoc fixes in `net/*.el`
Stefan Kangas [Mon, 8 Jul 2024 12:10:46 +0000 (14:10 +0200)]
Checkdoc fixes in `net/*.el`

* lisp/net/ange-ftp.el:
* lisp/net/dictionary.el (dictionary-tool-bar-map):
* lisp/net/eudc.el (eudc-translate-query)
(eudc-translate-attribute-list)
(eudc-format-inline-expansion-result, eudc-bookmark-server):
* lisp/net/eww.el (eww-check-text-conversion):
* lisp/net/rcirc.el (rcirc-server-name):
* lisp/net/tramp-adb.el (tramp-adb-handle-get-remote-uid):
* lisp/net/tramp-cmds.el (tramp-recompile-elpa-command-completion-p):
* lisp/net/tramp-crypt.el (tramp-crypt-command-completion-p):
* lisp/net/tramp-message.el (tramp-debug-buffer-command-completion-p):
* lisp/net/tramp-sh.el (tramp-use-connection-share):
* lisp/net/tramp.el (tramp-command-completion-p): Checkdoc fixes.

17 months agoImprove `use-package-vc-valid-keywords` docstring format
Stefan Kangas [Mon, 8 Jul 2024 12:03:17 +0000 (14:03 +0200)]
Improve `use-package-vc-valid-keywords` docstring format

* lisp/use-package/use-package-core.el
(use-package-vc-valid-keywords): Improve docstring format.

17 months ago; * etc/TODO: New item on installing Magit.
Stefan Kangas [Mon, 8 Jul 2024 11:52:42 +0000 (13:52 +0200)]
; * etc/TODO: New item on installing Magit.

17 months ago; Improve a recent change to the documentation
Eli Zaretskii [Mon, 8 Jul 2024 11:48:25 +0000 (14:48 +0300)]
; Improve a recent change to the documentation

* lisp/emacs-lisp/comp.el (native-comp-debug):
* doc/lispref/compile.texi (Native-Compilation Variables): Improve
wording.

17 months ago; Delete fixed item from etc/TODO: "proced on macOS"
Stefan Kangas [Mon, 8 Jul 2024 10:45:30 +0000 (12:45 +0200)]
; Delete fixed item from etc/TODO: "proced on macOS"

The 'process-attributes' function is supported since Emacs 26.1, and
proced seems to be fully working.

* etc/TODO: Delete fixed item: "proced on macOS".

17 months ago; Delete fixed NS bug from etc/TODO
Stefan Kangas [Mon, 8 Jul 2024 10:38:29 +0000 (12:38 +0200)]
; Delete fixed NS bug from etc/TODO

* etc/TODO: Delete fixed NS bug with 'mouse-avoidance-mode'.
Ref: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17439#43

17 months agoRevert "Fix link to major mode variable in docstring"
Stefan Kangas [Mon, 8 Jul 2024 10:15:05 +0000 (12:15 +0200)]
Revert "Fix link to major mode variable in docstring"

This reverts commit 73c1252bb6b7cc61d9f992818568d3c57de4ff67.

This will sometimes say
"the variable `(default-value 'global-auto-revert-mode)'".
Problem reported by Eshel Yaron <me@eshelyaron.com>.

17 months ago* etc/TODO: Add item to convert documentation to 'setopt'.
Stefan Kangas [Sun, 7 Jul 2024 20:32:20 +0000 (22:32 +0200)]
* etc/TODO: Add item to convert documentation to 'setopt'.

17 months agoPrefer 'setopt' in browse-url docs
Stefan Kangas [Sun, 7 Jul 2024 19:38:10 +0000 (21:38 +0200)]
Prefer 'setopt' in browse-url docs

* lisp/net/browse-url.el:
(browse-url-filename-alist): Doc fix; prefer 'setopt'.

17 months ago; Improve 'native-comp-debug' documentation
Andrea Corallo [Mon, 8 Jul 2024 09:05:29 +0000 (11:05 +0200)]
; Improve 'native-comp-debug' documentation

* lisp/emacs-lisp/comp.el (native-comp-debug): Improve doc.
* doc/lispref/compile.texi (Native-Compilation Variables): Likewise.

17 months agoCorrect conditions for iconification on Android
Po Lu [Mon, 8 Jul 2024 07:33:26 +0000 (15:33 +0800)]
Correct conditions for iconification on Android

* java/org/gnu/emacs/EmacsActivity.java (EmacsActivity)
<isPaused>: Rename to <isStopped>.
(attachWindow): Adjust to match.
(onPause): Delete function.
(onStop): Deem frames iconified after calls to onStop instead.

17 months agoFix execution of MS-Windows app execution aliases in Eshell
Jim Porter [Sat, 22 Jun 2024 19:45:19 +0000 (12:45 -0700)]
Fix execution of MS-Windows app execution aliases in Eshell

* lisp/eshell/esh-ext.el (eshell-script-interpreter): Check for 0-size
files (bug#71655).

17 months agoImprove 'tab-line-tabs-fixed-window-buffers' sorting performance
Eval EXEC [Fri, 5 Jul 2024 10:53:36 +0000 (18:53 +0800)]
Improve 'tab-line-tabs-fixed-window-buffers' sorting performance

* lsp/tab-line.el (tab-line-tabs-fixed-window-buffers): Enhance
'tab-line-tabs-fixed-window-buffers' performance by optimizing buffer
sorting mechanism.  Replace inefficient 'seq-position' calls with a hash
table to cache buffer positions, significantly improving speed when
handling large buffer lists (bug#71958).

Copyright-paperwork-exempt: yes

17 months agoAdapt Tramp version (don't merge)
Michael Albinus [Sun, 7 Jul 2024 17:35:06 +0000 (19:35 +0200)]
Adapt Tramp version (don't merge)

* doc/misc/trampver.texi:
* lisp/net/trampver.el (tramp-version): Adapt Tramp versions.

17 months agoFix Tramp parser
Michael Albinus [Sun, 7 Jul 2024 17:34:37 +0000 (19:34 +0200)]
Fix Tramp parser

* lisp/net/tramp.el (tramp-host-with-port-regexp): Declare.
(tramp-set-syntax): Set also `tramp-host-with-port-regexp'.
(tramp-build-host-with-port-regexp): New defun.
(tramp-host-with-port-regexp): Make it a defvar.  (Bug#71972)

* test/lisp/net/tramp-tests.el (tramp-test01-file-name-syntax)
(tramp-test01-file-name-syntax-simplified)
(tramp-test01-file-name-syntax-separate): Adapt tests.

17 months agoCheckdoc fixes in progmodes
Stefan Kangas [Sun, 7 Jul 2024 12:50:18 +0000 (14:50 +0200)]
Checkdoc fixes in progmodes

* lisp/progmodes/cperl-mode.el (cperl-file-style)
(cperl-continued-brace-offset, cperl-tips-faces):
* lisp/progmodes/eglot.el (eglot-confirm-server-edits, eglot)
(eglot-list-connections-mode, eglot--outstanding-inlay-hints-region)
(eglot--outstanding-inlay-regions-timer):
* lisp/progmodes/etags.el (etags-goto-tag-location)
(etags--xref-apropos-additional):
* lisp/progmodes/flymake.el (flymake-autoresize-margins):
* lisp/progmodes/gdb-mi.el (gdb-mouse-until, gdb-mouse-jump):
* lisp/progmodes/hideif.el (hif-parse-macro-arglist):
* lisp/progmodes/idlw-help.el (idlwave-html-help-location):
* lisp/progmodes/idlwave.el (idlwave-reserved-word-upcase):
* lisp/progmodes/java-ts-mode.el (java-ts-mode--string-highlight-helper):
* lisp/progmodes/js.el (js--chained-expression-p):
* lisp/progmodes/pascal.el (pascal-mode, pascal-comment-area):
* lisp/progmodes/python.el (python--treesit-fontify-union-types):
* lisp/progmodes/ruby-mode.el (ruby-align-chained-calls)
(ruby-block-indent, ruby-rubocop-use-bundler):
* lisp/progmodes/rust-ts-mode.el
(rust-ts-mode--prettify-symbols-compose-p):
* lisp/progmodes/verilog-mode.el (verilog-cache-has-lisp)
(verilog-auto-insert-lisp, verilog-highlight-region):
* lisp/progmodes/xref.el (xref--get-history): Various checkdoc fixes.

17 months agoCheckdoc fixes in Org Mode
Stefan Kangas [Sun, 7 Jul 2024 12:27:14 +0000 (14:27 +0200)]
Checkdoc fixes in Org Mode

* lisp/org/ob-core.el:
* lisp/org/ob-exp.el:
* lisp/org/ob-lob.el:
* lisp/org/ob-plantuml.el (org-babel-execute:plantuml):
* lisp/org/ob-python.el (org-babel-python--command)
(org-babel-python-initiate-session-by-key)
(org-babel-python-initiate-session):
* lisp/org/ob-scheme.el (org-babel-scheme-make-session-name):
* lisp/org/ob-tangle.el (org-babel-find-file-noselect-refresh)
(org-babel-interpret-file-mode):
* lisp/org/ob.el:
* lisp/org/org-agenda.el (org-agenda-mouse-1-follows-link)
(org-agenda-start-with-archives-mode)
(org-agenda-previous-line):
* lisp/org/org-clock.el (org-clock-save, org-clock-load):
* lisp/org/org-element-ast.el (org-element-type-p):
* lisp/org/org-faces.el (org-cycle-level-faces):
* lisp/org/org-fold-core.el (org-fold-core--isearch-overlays):
* lisp/org/org-fold.el (org-fold--extend-changed-region):
* lisp/org/org-goto.el:
* lisp/org/org-habit.el (org-habit-show-all-today):
* lisp/org/org-inlinetask.el (org-inlinetask-in-task-p):
* lisp/org/org-macs.el (org-current-text-column):
* lisp/org/org-mobile.el (org-mobile-check-setup):
* lisp/org/org-mouse.el (org-mouse-bolp):
* lisp/org/org-refile.el (org-refile):
* lisp/org/org-src.el (org-src-do-key-sequence-at-code-block):
* lisp/org/org-table.el (orgtbl-after-send-table-hook)
(orgtbl-self-insert-command, orgtbl-to-orgtbl):
* lisp/org/org.el (org-read-date-popup-calendar, org-finish-function)
(org-occur-parameters, org-self-insert-command, org-ctrl-c-ctrl-c-hook)
(org-ctrl-c-ctrl-c-final-hook, org-submit-bug-report)
(org--single-lines-list-is-paragraph):
* lisp/org/ox-icalendar.el (org-icalendar--vtodo):
* lisp/org/ox-latex.el (org-latex-generate-engraved-preamble):
(org-latex-src--engrave-code):
* lisp/org/ox-publish.el (org-publish-project-alist):
* lisp/org/ox.el (org-export-data): Various checkdoc fixes.

17 months agoClarify `checkdoc-max-keyref-before-warn` docstring
Stefan Kangas [Sun, 7 Jul 2024 10:45:03 +0000 (12:45 +0200)]
Clarify `checkdoc-max-keyref-before-warn` docstring

* lisp/emacs-lisp/checkdoc.el (checkdoc-max-keyref-before-warn): Clarify
and reflow docstring.  Fix warning about overly long docstring.

17 months ago* lisp/files.el (insert-directory): Quote switches in wildcard case.
Juri Linkov [Sun, 7 Jul 2024 06:57:34 +0000 (09:57 +0300)]
* lisp/files.el (insert-directory): Quote switches in wildcard case.

Use shell-quote-wildcard-pattern on the switches string split by
split-string-and-unquote.  This helps to quote such switches as
"--block-size='1" (bug#71935).

17 months agoFix uses of 'dired-omit-mode' (bug#71905)
Juri Linkov [Sun, 7 Jul 2024 06:52:01 +0000 (09:52 +0300)]
Fix uses of 'dired-omit-mode' (bug#71905)

* lisp/dired.el (dired-jump): Disable dired-omit-mode with -1.

* lisp/files.el (recover-session): Disable dired-omit-mode
explicitly afterwards instead of modifying dired-mode-hook
that fails when it contains a lambda.

17 months ago* src/androidvfs.c (android_saf_check_nonnull): Fix typo.
Po Lu [Sun, 7 Jul 2024 02:24:24 +0000 (10:24 +0800)]
* src/androidvfs.c (android_saf_check_nonnull): Fix typo.

17 months agoCorrect JNI string error checking and miscellaneous corrections
Po Lu [Sun, 7 Jul 2024 02:19:31 +0000 (10:19 +0800)]
Correct JNI string error checking and miscellaneous corrections

* src/android-emacs.c (main): Do not attempt to load the
bootstrap class path, which is redundant on all Android releases.

* src/android.c (initEmacs, android_browse_url): Do not assume
exceptions will be raised if GetStringUTFChars fails.  Decode
Android JNI strings as Qandroid_jni.

* src/androidvfs.c (android_saf_check_nonnull): New function.
(android_saf_new_mkdir): Likewise.

17 months agoCorrectly highlight SYMTAB in `awk-mode`
Stefan Kangas [Sun, 7 Jul 2024 01:39:37 +0000 (03:39 +0200)]
Correctly highlight SYMTAB in `awk-mode`

* lisp/progmodes/cc-awk.el (awk-font-lock-keywords): Fix typo for
"SYMTAB" (see Info node '(gawk) Auto-set').

17 months agoFix formatting of tables with thead/tfoot but no tbody
JD Smith [Sat, 6 Jul 2024 13:22:33 +0000 (09:22 -0400)]
Fix formatting of tables with thead/tfoot but no tbody

Correctly handle formatting of tables containing thead and/or tfoot, but
without any tbody, to prevent including thead/tfoot content twice within
the table's derived body.
* lisp/net/shr.el (shr--fix-tbody): Omit 'thead' and 'tfoot' from
implicit body.  (Bug#71685)
* test/lisp/net/shr-resources/table.html:
* test/lisp/net/shr-resources/table.txt: New tests for table rendering.

17 months ago(buf_bytepos_to_charpos): Fix mixup introduced in commit b300052fb4ef
Stefan Monnier [Thu, 27 Jun 2024 19:36:28 +0000 (15:36 -0400)]
(buf_bytepos_to_charpos): Fix mixup introduced in commit b300052fb4ef

Backport of commit 1b595b4598e7 since it turns out this "minor typo"
had disastrous consequences in pathological cases and explains
some of the problems seen in bug#71644 and bug#63040.

* src/marker.c (buf_bytepos_to_charpos): Don't compare byte-positions
with char-positions.

17 months ago; Reflow "Commentary" in lisp-mnt.el
Stefan Kangas [Sat, 6 Jul 2024 17:34:28 +0000 (19:34 +0200)]
; Reflow "Commentary" in lisp-mnt.el

* lisp/emacs-lisp/lisp-mnt.el: Reflow "Commentary" section.

17 months ago; * lisp/emacs-lisp/comp-run.el (native--compile-async): Improve warning.
Eli Zaretskii [Sat, 6 Jul 2024 17:32:49 +0000 (20:32 +0300)]
; * lisp/emacs-lisp/comp-run.el (native--compile-async): Improve warning.

17 months agopackage-buffer-info: Move 'require' earlier
Stefan Kangas [Sat, 6 Jul 2024 13:19:10 +0000 (15:19 +0200)]
package-buffer-info: Move 'require' earlier

* lisp/emacs-lisp/package.el (package-buffer-info):
Move 'require' earlier, before it is needed.

17 months agoFix treesit range rule for jsdoc
Vincenzo Pupillo [Thu, 27 Jun 2024 14:13:58 +0000 (16:13 +0200)]
Fix treesit range rule for jsdoc

The parser for jsdoc is local, so it is necessary for the range
rule to take this into account.
* lisp/progmodes/js.el (js-ts-mode): Add ':local' keyword.
(js-ts-language-at-point): Remove 'js-ts-language-at-point'.
(Bug#71776)

17 months agoFix documentation of 'balance-windows'
Eli Zaretskii [Sat, 6 Jul 2024 10:44:57 +0000 (13:44 +0300)]
Fix documentation of 'balance-windows'

* lisp/window.el (balance-windows): Doc fix.

* doc/emacs/windows.texi (Change Window): Make the description of
'balance-windows' more accurate.  (Bug#71915)

17 months agonnatom: Ensure some parsed values are one line
Daniel Semyonov [Mon, 1 Jul 2024 23:15:24 +0000 (02:15 +0300)]
nnatom: Ensure some parsed values are one line

* lisp/gnus/nnatom.el (nnatom--dom-line): New function.
(nnatom--read-title, nnatom--read-description)
(nnatom--read-article-or-group-authors, nnatom--read-subject)
(nnatom--read-id, nnatom--read-publish, nnatom--read-update)
(nnatom--read-links): Read text using `nnatom--dom-line'.
(Bug#71889)

17 months agonnfeed: (Mostly) fix group descriptions
Daniel Semyonov [Mon, 1 Jul 2024 22:42:26 +0000 (01:42 +0300)]
nnfeed: (Mostly) fix group descriptions

* lisp/gnus/nnfeed.el (nnfeed--group-description): New function.
(nnfeed-request-group-description, nnfeed-request-list-newsgroups):
Use `nnfeed--group-description' and always return t if group data
is found.  (Bug#71888)

17 months agoEglot: support deprecated MarkedString (bug#71353)
João Távora [Sat, 6 Jul 2024 09:17:42 +0000 (10:17 +0100)]
Eglot: support deprecated MarkedString (bug#71353)

* lisp/progmodes/eglot.el: Make a markdown code block if
MarkedString passed.

17 months ago; * doc/lispref/strings.texi (Creating Strings): Followup to last change.
Eli Zaretskii [Sat, 6 Jul 2024 08:36:44 +0000 (11:36 +0300)]
; * doc/lispref/strings.texi (Creating Strings): Followup to last change.

17 months ago; Fix doc string of 'string-fill'
Eli Zaretskii [Sat, 6 Jul 2024 08:28:39 +0000 (11:28 +0300)]
; Fix doc string of 'string-fill'

* lisp/emacs-lisp/subr-x.el (string-fill): Rename LENGTH to WIDTH
and update the doc string accordingly.  (Bug#71856)

17 months agoFix returning to original TTY frame after 'rmail-reply'
Eli Zaretskii [Sat, 6 Jul 2024 07:32:39 +0000 (10:32 +0300)]
Fix returning to original TTY frame after 'rmail-reply'

* lisp/mail/rmail.el (rmail-start-mail): Record the frame from
which an Rmail command, such as 'rmail-mail' or 'rmail-reply', was
invoked.
(rmail--find-orig-rmail-frame): New function.
(rmail-mail-return): Use 'rmail--find-orig-rmail-frame' to find
the original frame, and make it the top frame on its TTY terminal.
(Bug#69738)

17 months agoImprove warnings from native compiler
Eli Zaretskii [Fri, 5 Jul 2024 19:00:08 +0000 (22:00 +0300)]
Improve warnings from native compiler

* src/comp.c (syms_of_comp) <native-compiler>: Rename from 'comp'.

* src/lread.c (maybe_swap_for_eln):
* lisp/emacs-lisp/comp.el (comp--fwprop):
* lisp/emacs-lisp/comp-run.el
(comp--accept-and-process-async-output, native--compile-async):
Adjust to the new symbol.

17 months agoDocument adding package dependency on Emacs version
Stefan Kangas [Fri, 5 Jul 2024 11:58:07 +0000 (13:58 +0200)]
Document adding package dependency on Emacs version

* doc/lispref/package.texi (Simple Packages, Multi-file Packages):
Document how to make a package depend on a specific version of Emacs.

17 months agoFix file-name detection in Dired under -F
Eli Zaretskii [Fri, 5 Jul 2024 10:58:11 +0000 (13:58 +0300)]
Fix file-name detection in Dired under -F

* lisp/files.el (insert-directory-clean): Support all the symbols
appended to file names by the -F/--classify option of 'ls'.  See
https://lists.gnu.org/archive/html/emacs-devel/2024-07/msg00366.html
for the details.

17 months ago(edebug--called-interactively-skip): Fix bug#71934
Stefan Monnier [Thu, 4 Jul 2024 15:47:01 +0000 (11:47 -0400)]
(edebug--called-interactively-skip): Fix bug#71934

* lisp/emacs-lisp/edebug.el (edebug--called-interactively-skip):
Adjust to new interpreted functions.

17 months ago; * lisp/ibuffer.el (ibuffer-mode): Doc fix.
Eli Zaretskii [Thu, 4 Jul 2024 07:59:45 +0000 (10:59 +0300)]
; * lisp/ibuffer.el (ibuffer-mode): Doc fix.