Start counting storage usage from 0 for macOS virtual files account

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7397 from nextcloud/bugfix/mac-vfs-syncstatechange-freeze

Fix stuttering and freezing of client while computing sync state changes (macOS VFS)

Store reachability of FileProviderExt by respective account

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Increase reachability retry timeout

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Slash semaphore wait delta on reachability down to 1 second

Any longer does not really yield any positive result and freezes the
client for longer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not attempt to reach out to FileProviderExt every single time we want to check if it is reachable

Only check every 60 seconds, this way we do not freeze the client for 3
seconds every time that we want to check the reachability while the
extension is unreachable

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7428 from nextcloud/dependabot/github_actions/platisd/clang-tidy-pr-comments-1.5.1

Bump platisd/clang-tidy-pr-comments from 1.5.0 to 1.5.1

Bump platisd/clang-tidy-pr-comments from 1.5.0 to 1.5.1

Bumps [platisd/clang-tidy-pr-comments](https://github.com/platisd/clang-tidy-pr-comments) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/platisd/clang-tidy-pr-comments/releases)
- [Commits](https://github.com/platisd/clang-tidy-pr-comments/compare/v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: platisd/clang-tidy-pr-comments
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7418 from nextcloud/bugfix/change-log-settings-fix

Do not alter the user's debug and expiration settings when changing temporary log dir setting

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7350 from nextcloud/bugfix/updatechannels

Bugfix update channels

Fix compiling when BUILD_UPDATER is set to OFF.

Only connect signal/slot for update channels listing when BUILD_UPDATER is ON.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove check in setServerHasValidSubscription.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Address PR feedback.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Update config value when serverHasValidSubscription when accounts are added or removed.

To give priority to server susbscriptions and keep listing the right update channels.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix logic for initial load of update channels and priority for user with subscription.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Save serverHasValidsubcription in the account.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Do not override the channels list if one of the account has enterprise.

Maintain stable and enterprise.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Do not override the subscription value if one of the account has enterprise.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Change the list of update channels when server capabilities change.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove checks for the update channel from the getter function.

It should only return the value.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7423 from nextcloud/bugfix/escaped-infoplist-xml-appvendor

Fix code-signing issues for vendors with special chars

Use xml-escaped application vendor in info plist, fixing code-signing issues for vendors with special chars

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add xml-escaped version of application vendor variable in CMakeLists

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7439 from nextcloud/bugfix/appimage

Update share link for AppImage tool.

Update share link for AppImage tool.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7426 from nextcloud/bugfix/accounts

Bugfix account removal

Use const auto.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Validate http_user value before assigning it to user in the config file.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove call to wantsAccountSaved when clearing the cookies.

The cookies are cleared when an account is removed, this call was
bringing back the deleted account.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7379 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.13.3

Bump cpp-linter/cpp-linter-action from 2.13.2 to 2.13.3

Bump cpp-linter/cpp-linter-action from 2.13.2 to 2.13.3

Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.13.2 to 2.13.3.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.13.2...v2.13.3)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #7413 from nextcloud/bugfix/display-multi-enforced-servers-name-only

Only display server name in multiple override servers dropdown

Only display server name in multiple override servers dropdown

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7408 from nextcloud/bugfix/enforceconfig

Change default of promptDeleteFiles to false

On upgrade notification for mass file deletion is disabled by default.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Set promptDeleteFiles default to false.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7404 from nextcloud/bugfix/improveStateHandlingInToSIntegration

improve again state tracking with terms of service app

improve logs when checking terms of service status

should help diagnosing a client stuck with ToS block while thinking they
had been accepted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

improve again state tracking with terms of service app

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7395 from nextcloud/bugfix/fixToSDetection

properly detect need to sign terms of service state

properly detect need to sign terms of service state

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7389 from nextcloud/bugfix/dealWithToSApp

content access denied error during discovery: verify server access

notify user once when terms of service need to be signed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

content access denied error during discovery: verify server access

will trigger a check of the server connectivity in case of content
access denied reporting when listing folders during discovery

should allow discovering early that terms of service need to be signed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7385 from nextcloud/bugfix/dealWithToSApp

detect the terms of service app is requiring the user to sign them

content access denied error during discovery: verify server access

will trigger a check of the server connectivity in case of content
access denied reporting when listing folders during discovery

should allow discovering early that terms of service need to be signed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

detect the terms of service app is requiring the user to sign them

will query the sign state for the terms of service and automatically
pause or resume sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7368 from nextcloud/bugfix/pin-qt-version

Pin Craft Qt version to 6.7.2 and binary cache version to 24.08

Pin Craft Qt version to 6.7.2 and binary cache version to 24.08

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7339 from nextcloud/feature/distinguisable-shares

Make shares distinguishable if there are sharees with the same display name

Ensure on removal of share that display string is updated for last (now non-)duplicate share

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Store duplicate indices as key-value pair with value storing bucket of all duplicates

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Clean up check for equality between sharee display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make sure to update display of all duplicate display name shares

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Display more verbose share display names for shares that have sharees with identical display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Check for and store indices of shares with duplicate display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability to make share sharee displayname more verbose

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6752 from nextcloud/bugfix/locally-available-folders-open-in-browser-tray-header

Fix opening of locally available groupfolders in web browser from tray drop-down

Take reference to folder in folder map within User::getFolder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Prevent double slashes in group folder path parsing

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use for : loop in getFolder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Constify openLocalFolder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7360 from nextcloud/bugfix/mac-vfs-storage-use-elide

Make sure storage headers do not collide with each other in macOS VFS settings

Make sure storage headers do not collide with each other in macOS VFS settings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7323 from nextcloud/bugfix/mac-vfs-ci-swift6

Fix Swift 6-related CI errors with macOS VFS module

Run post-auth state check with main actor task

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix swift 6 concurrency error regarding use of authAttemptState

Cannot pass a local variable into a concurrently executing Task. It's
not a real issue as we are using a semaphore to wait before using this
variable for anything outside of the Task block, but still.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7328 from nextcloud/bugfix/global-progress-vfs-bigsur

Check for availability of Big Sur (under 11.3) before using VFS progress tracking method

Wrap use of NSFileProviderManager globalProgress in availability check

This selector was only made available on macOS 11.3
Just to be safe we should check for the availability

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6123 from nextcloud/bugfix/docs-format

Fix issues on manpages

Incorporate doc fixes from pull request #6122

Fix issues on manpages

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7351 from nextcloud/bugfix/alwaysRecordMovedItemsAfterServerReplied

on receiving reply of a remote MOVE: always record it

on receiving reply of a remote MOVE: always record it

even if local item has disappeared, record the result of a remote MOVE
when receiving the reply

enable better state tracking when syncing rename or move operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7346 from nextcloud/Rello-patch-1

remove ownCloud wording in logging

remove ownCloud wording in logging

remove ownCloud wording in logging

Signed-off-by: Rello <Rello@users.noreply.github.com>

Merge pull request #3014 from nextcloud/foreground-background

Show/Hide Menubar and Dock Icon on macOS

Show/Hide Menubar and Dock Icon

Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>

Merge pull request #4367 from nextcloud/finder-sidebar-icon-fix

Fix Finder sidebar icon to work as a "template" image