Add ability to build and sign sparkle tbz from mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability to notarise package from mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability to sign pkg from mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add flag to build pkg in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add buildPackage function to mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7122 from nextcloud/backport/6921/stable-3.14

[stable-3.14] Add additional options to make cross-compiling client feasible with Mac Crafter

Add option to set product path in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7192 from nextcloud/backport/7182/stable-3.14

[stable-3.14] Revert always enable http2

Revert "Merge pull request #6986 from nextcloud/feature/alwaysEnableHttp2"

This reverts commit 5baec6f128734bc8ed0845ac7a8c269904c1027e, reversing
changes made to ab06ecbc4d02c4b18174e8280a8f242da9ea7970.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7187 from nextcloud/backport/7164/stable-3.14

[stable-3.14] Correctly kill processes spawned by mac-crafter if mac-crafter quits/is killed/etc

Correctly kill processes spawned by mac-crafter if mac-crafter quits/is killed/etc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7131 from nextcloud/backport/6717/stable-3.14

[stable-3.14] Bugfix/fix vfs folder state when remote move is forbidden

as a last resort, try to update VFS metadata of folders when discovered

when doing local discovery, it is possible that files or folders may be
discovered with VFS metadata not up to date (i.e. placeholder file not
set in sync)

in such case, generate a propagation instruction to set them in sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

ensure proper VFS metadata when restoring folders

when remote move is forbidden, desktop client will move back the folder
to its original name

in such cases, we were forgetting to set VFS metadata in their proper
state (i.e. placeholder in sync)

so ensure that when a remote move fails, we still touch VFS metadata
when appropriate and handle errors

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

prepare 3.14.0 release

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

prepare 3.14.0 rc4

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7117 from nextcloud/backport/7101/stable-3.14

[stable-3.14] Fix native UI

Remove extra ';'

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix wrong Style property.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix error: Audio is not a type.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove user status hover effect and background color.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add todo: check if we should keep bottomUnifiedSearchInputSeparator.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add todo: fix predefined status list.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix emoji selector page: transparency made it unusable. Use windows background color.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Adjust radius values: main window and text input uses bigger value, dropdown menus uses half.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add the same round background rectangle for the talk reply text field.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove extra ';'

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix height of text input fields and radius.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix unified search input placeholder text alignment and radius.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix warning: TypeError: Cannot read property 'height'/'width' of null.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix the color of the tab icons in the files details page.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add margin space to the right of the 3 dots user menu.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add radius value, border and hover colors in the folder's menus.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use the same radius value, border colors and hover colors in all header menus.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Match the apps menu list look with the user's list look.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use Style.trayFolderStatusIndicatorRadiusFactor in the UserLine.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add new icon for more apps menu.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use palette.window as header background color.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add colored to base colors.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix display of icons in dark/light theme.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix dark/light mode for account menu.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix caret-down icon theme, size and alignment.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix tray header light/dark theme.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7115 from nextcloud/backport/7096/stable-3.14

[stable-3.14] gui: add some context for translators

gui: add some context for translators

Resolves #7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #7112 from nextcloud/backport/7098/stable-3.14

[stable-3.14] Fix building of client on macOS 10.13 and 10.14

Wrap use of folder permissions restore in mac ifdefs

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Wrap all uses of FileSystem::setFolderPermissions in ifdefs for macOS

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7114 from nextcloud/backport/6970/stable-3.14

[stable-3.14] Make sure we do not renotify notifications when we have received the same etag as during the last check

Notify even if pre-fetch etag header is empty

This prevents situations where the server does not provide an etag header. This would make the empty pre-fetch and empty post-fetch etag headers match, meaning notifications would never be notified

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make sure we do not renotify notifications when we have received the same etag as during the last check

Do this regardless of what the server's response is

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7110 from nextcloud/backport/6960/stable-3.14

[stable-3.14] Feature/macos vfs locking

Signal enumeration of locked/unlocked file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not provide items if account is not set up correctly

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Display checkmark when file lock completed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix NSExtensionFileProviderActionActivationRules for locking menu items

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add warn image to locking view if there is an error

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix internal layouting of lock view by simply using a nsview rather than fumbling with a stack view

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix XIB initialisation in LockViewController

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix file lock server url in lockviewcontroller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make sure not to check for kit before we should in shares table view data source

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Once finished locking/unlocking, stop loading indicator

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Pull out error handling from completionHandler for nckit lockunlock

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Stop loading indicator when presenting error

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add convenience function to stop/hide loading indicator in lock view controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Perform lock/unlock procedure in lock view controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Process target item on init of lock view controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add method to simply provide file details in locking view

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add convenience method to present and log errors in lock view controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Move item metadata fetch into util file in FileProviderUIExt

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Move service connection fetcher method into a utils file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add close action to lock view controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Design lock view in file provider ui

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add basic properties to lock view controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Handle new locking action identifiers in document action view controller of FileProviderUIExt

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add lock/unlock actions in FileProviderUIExt info plist

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add basic LockViewController components

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Move all sharing components for FileProviderUIExt into a Sharing folder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7109 from nextcloud/backport/7102/stable-3.14

[stable-3.14] Bugfix/fix one rename issue

improve some log that are produced during discovery

would be usefull to track bugs during rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

avoid wrong tracking of renamed folders during discovery

ensure server rename operations are tracked as server rename operations

ensure local rename are tracked as local rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

add automated tests for complex move scenario

we rename the top folder and we rename a not direct child that is also
moved to another folder below the original renamed top folder

so
a/b/c
a/b/d/file

will be
e/b/c/f/file

with
a -> e
d-> f

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7108 from nextcloud/backport/7061/stable-3.14

[stable-3.14] Bugfix/delete read only remnants folders

delete invalid folders and restart sync automatically

users should then notice that the sync errors are gone

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

let FileSystem::removeRecursively be able to delete read-only folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

detect remnants read-only folders to delete: try to delete them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

let cancel sync and finish sync  lambda be reusable methods

will enable implementation of other ways to interrupt sync after
discovery to get user feedback

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

collect remnant read-only folders during discovery

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7105 from nextcloud/backport/7103/stable-3.14

[stable-3.14] Code-sign client via mac-crafter so it may pass notarisation

Move building into separate subcommand, add subcommand just for codesigning

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Always move final product to product path in mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix codesigning of qtwebengine related helper app in mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use deep codesigning by default in mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make sure to code-sign all binaries in app bundle

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove get-task-allow entitlement when code-signing app extensions

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix notarisation issues for Sparkle in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add convenience method to save the entitlements of a bundle to a file as XML

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix issue with placing app bundle in product directory if an existing build is there

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7091 from nextcloud/backport/6949/stable-3.14

[stable-3.14] Narrow down ReadWrite folder permission to owner

Narrow down ReadWrite folder permission to owner

Signed-off-by: suiso67 <suiso67@macadamia.rocks>