Timm Bäder [Tue, 27 Mar 2018 16:25:03 +0000 (18:25 +0200)]
spinbutton: Fix a copy/paste bug in the docs
Timm Bäder [Tue, 27 Mar 2018 11:24:14 +0000 (13:24 +0200)]
gl renderer: Fix some crashes
When the first op is a modelview or projection change.
Timm Bäder [Tue, 27 Mar 2018 09:04:23 +0000 (11:04 +0200)]
accellabel: Stop saying it's a GtkLabel
And clean up the includes accordingly.
Timm Bäder [Tue, 27 Mar 2018 08:57:36 +0000 (10:57 +0200)]
accellabel: Remove some unnused class fields
Timm Bäder [Tue, 27 Mar 2018 08:53:38 +0000 (10:53 +0200)]
accellabel: Remove priv pointer
Emmanuele Bassi [Tue, 27 Mar 2018 11:45:20 +0000 (12:45 +0100)]
ci: Move flatpak building to a script
The YAML is getting hard to modify, so let's use a simple script like we
do for the other CI jobs.
Emmanuele Bassi [Mon, 26 Mar 2018 10:48:30 +0000 (11:48 +0100)]
Do not test for linker flags
Meson warns when doing that, as it's not really portable.
Since we're using platform-specific linker flags on Darwin, we can also
do the same on Linux; the syntax is GCC-specific, so we're going to need
Clang users to test it.
Benjamin Otte [Tue, 27 Mar 2018 11:37:24 +0000 (11:37 +0000)]
Merge branch 'krnowak/leak-fixes' into 'master'
Fix some leaks
See merge request GNOME/gtk!87
Krzesimir Nowak [Tue, 27 Mar 2018 11:14:41 +0000 (13:14 +0200)]
Fix some leaks
Timm Bäder [Mon, 26 Mar 2018 19:13:52 +0000 (21:13 +0200)]
gl renderer: Rename everything called window to surface
Timm Bäder [Mon, 26 Mar 2018 17:30:40 +0000 (19:30 +0200)]
entry: Remove useless queue_draw call
This is already taken care of by the add_class/remove_class.
Benjamin Otte [Sat, 24 Mar 2018 22:27:43 +0000 (23:27 +0100)]
snapshot: Generate better names for offset nodes
Benjamin Otte [Mon, 26 Mar 2018 17:41:38 +0000 (19:41 +0200)]
rendernode: Fix serializing
Adding the offset node broke serialization in 2 ways:
1. We store the enum value in the node, so make sure to not change it
for existing values
2. The offset node was missing in the deserialization lookup table
Benjamin Otte [Mon, 26 Mar 2018 16:46:22 +0000 (18:46 +0200)]
iconhelper: Apply scale to paintable
Instead of fiddling around with scale in the iconhelper (and getting it
wrong), create a GtkScaler around the paintable that takes care of the
scaling.
Benjamin Otte [Mon, 26 Mar 2018 16:32:38 +0000 (18:32 +0200)]
dnd: Remove gtk_drag_set_icon_surface()
All users are gone. Use gtk_drag_set_icon_paintable() instead.
Benjamin Otte [Mon, 26 Mar 2018 16:30:34 +0000 (18:30 +0200)]
tests: Don't use gtk_drag_set_icon_surface()
Benjamin Otte [Mon, 26 Mar 2018 04:49:55 +0000 (06:49 +0200)]
textview: Port dnd icon to be a GdkPaintable
Benjamin Otte [Mon, 26 Mar 2018 04:29:06 +0000 (06:29 +0200)]
colorswatch: Port drag icon to paintables
Benjamin Otte [Mon, 26 Mar 2018 04:26:34 +0000 (06:26 +0200)]
colorbutton: Port dnd icon to paintable
Patch is untested, because colorbuttons can't do DND at the moment.
Benjamin Otte [Mon, 26 Mar 2018 04:20:56 +0000 (06:20 +0200)]
treeview: Turn drag icon into paintable
Benjamin Otte [Mon, 26 Mar 2018 03:21:18 +0000 (05:21 +0200)]
iconview: Port DND icons to snapshot paintables
Benjamin Otte [Mon, 26 Mar 2018 03:09:46 +0000 (05:09 +0200)]
tests: Remove references to long-deleted property
Benjamin Otte [Mon, 26 Mar 2018 02:38:54 +0000 (04:38 +0200)]
textutil: Make gtk_text_util_create_drag_icon() return a paintable
Benjamin Otte [Mon, 26 Mar 2018 02:37:01 +0000 (04:37 +0200)]
snapshot: Add gtk_snapshot_to_paintable()
This is intended for DND icons
Benjamin Otte [Mon, 26 Mar 2018 02:23:11 +0000 (04:23 +0200)]
snapshot: Export gtk_snapshot_append_layout()
This is the equivalent snapshot function to pango_cairo_show_layout().
Not to be confused with gtk_snapshot_render_layout(), which is the
equivalent to gtk_render_layout().
Benjamin Otte [Tue, 20 Mar 2018 03:33:58 +0000 (04:33 +0100)]
snapshot: Make gtk_snapshot_append_node() take care of offset
Push an offset node when append_node is called. That resets the offset.
Benjamin Otte [Tue, 20 Mar 2018 01:46:57 +0000 (02:46 +0100)]
rendernode: Add an offset node
This is a special case of the transform node that does a 2D translation.
The implementation in the Vulkan and GL renderers is crude and just does
the same as the transform node.
Nothing uses that node yet.
Piotr Drąg [Sun, 25 Mar 2018 23:42:57 +0000 (01:42 +0200)]
Update Polish translation
Benjamin Otte [Sun, 25 Mar 2018 22:29:52 +0000 (00:29 +0200)]
colorscale: Draw gradient using render nodes
Don't use Cairo when it's not needed.
Benjamin Otte [Sun, 25 Mar 2018 22:12:20 +0000 (00:12 +0200)]
colorscale: Draw hue background as a texture
No need to use Cairo here.
Benjamin Otte [Sun, 25 Mar 2018 21:56:09 +0000 (23:56 +0200)]
colorplane: Create background image as a texture
Don't create it using Cairo.
Matthias Clasen [Sun, 25 Mar 2018 20:44:44 +0000 (20:44 +0000)]
Merge branch 'bz773274' into 'master'
wayland: Don't paint if the window is unmapped
See merge request GNOME/gtk!32
Benjamin Otte [Sun, 25 Mar 2018 20:37:09 +0000 (22:37 +0200)]
colorscale: Don't free surface data before surface
When drawing onto a recording surface, source surfaces get cached.
But if we g_free() the surface data after we're done, that cache is
gonna point at invalid data...
Timm Bäder [Sun, 25 Mar 2018 13:28:40 +0000 (15:28 +0200)]
GdkGLContext: Add a GL debug message callback
If G_ENABLE_CONSISTENCY_CHECKS is defined (i.e. if our buildtype is
'debug'), add a opengl debug callback that prints all debug messages
with a severity higher than SEVERITY_NOTIFICATION as a warning to the
console.
Timm Bäder [Sun, 25 Mar 2018 09:47:04 +0000 (11:47 +0200)]
gl renderer: Skip all 0-sized nodes
These will cause problems later on.
Timm Bäder [Sun, 25 Mar 2018 09:46:48 +0000 (11:46 +0200)]
gl renderer: Remove cairo node special case
Emmanuele Bassi [Sun, 25 Mar 2018 00:31:36 +0000 (00:31 +0000)]
ci: Remove --werror
Turns out that GCC errors out when building the GLib test suite, as it
now checks for overflows in allocator functions, and we're testing for
those.
This would not be an issue for GTK, but since we're building GLib as a
subproject, we get failures for those as well.
Until we can find out how to disable errors for subprojects, or fix the
GLib test suite not to trip up warnings in GCC, we're going to live
without compiler warnings treated as errors for a while.
Emmanuele Bassi [Sun, 25 Mar 2018 00:00:02 +0000 (00:00 +0000)]
ci: Use the appropriate argument for errors
The option to enable fatal warnings in Meson is `--werror`.
Daniel Boles [Sat, 24 Mar 2018 21:57:42 +0000 (21:57 +0000)]
Menu: Don't leak priv->motion_controller
Benjamin Otte [Sat, 24 Mar 2018 21:27:28 +0000 (22:27 +0100)]
ci: build with -Werror
Emmanuele Bassi [Sat, 24 Mar 2018 21:17:34 +0000 (21:17 +0000)]
ci: Disable ccache
Forcibly remove any ccache use, even if it's installed.
Emmanuele Bassi [Wed, 21 Mar 2018 01:05:29 +0000 (01:05 +0000)]
docs: Style fixes for the contribution guidelines
Benjamin Otte [Sat, 24 Mar 2018 20:41:53 +0000 (21:41 +0100)]
snapshot: Remove renderer
Now that there's no longer a need to keep the renderer around for Cairo
rendering, don't do that then.
Benjamin Otte [Sat, 24 Mar 2018 20:33:08 +0000 (21:33 +0100)]
rendernode: Remove renderer argument
It's not needed to create Cairo nodes anymore.
Benjamin Otte [Sat, 24 Mar 2018 19:42:42 +0000 (20:42 +0100)]
rendernode: Create Cairo surfaces as recording surfaces
This way, we can postpone the actual rendeing of the node until the
renderer. This allows the renderer to choose the right scale to
render at, so it can decide to use 2x scale for hidpi on its own.
Last but not least, it makes all nodes independent of the context they
are created in, because they do not need to know at snapshot time what
they will ultimately be rendered into.
Benjamin Otte [Sat, 24 Mar 2018 15:41:59 +0000 (16:41 +0100)]
vulkan: Remove special case for Cairo surfaces
This is in preparation for the next commits which switch Cairo nodes to
recording surfaces.
LRN [Sat, 24 Mar 2018 11:08:36 +0000 (11:08 +0000)]
Merge branch 'lrn/bug-773299' into 'master'
bug 773299 2nd
See merge request GNOME/gtk!79
Руслан Ижбулатов [Sat, 24 Mar 2018 10:58:11 +0000 (10:58 +0000)]
GDK W32: Adapt DnD event putting to recent changes
Set the display for each event that we put.
Also reorganize the dnd_event_put() function a bit, giving it a surface
directly instead of setting it by implication.
https://bugzilla.gnome.org/show_bug.cgi?id=773299
LRN [Sat, 24 Mar 2018 10:46:59 +0000 (10:46 +0000)]
Merge branch 'lrn/bug-773299' into 'master'
bug 773299
See merge request GNOME/gtk!78
Руслан Ижбулатов [Sat, 24 Mar 2018 10:26:51 +0000 (10:26 +0000)]
GDK W32: Don't check dest_surface for != NULL on button events
dest_surface is going to always be NULL for source contexts.
Previously we used to put the root window there to pass this check,
but root windows are gone (and root surfaces never existed to begin
with), so we have to adapt.
https://bugzilla.gnome.org/show_bug.cgi?id=773299
Руслан Ижбулатов [Sat, 24 Mar 2018 10:05:34 +0000 (10:05 +0000)]
GDK W32: Init display scale to the global Windows scale, not 1
This affects gdk_device_query_state() for the virtual device. It has
no window, and is forced to query the display itself, and display
defaults its scale to 1 even for HiDPI desktops. Use the same
"query scale of a NULL monitor" trick that we use in other places
to get the global desktop scale.
https://bugzilla.gnome.org/show_bug.cgi?id=773299
Руслан Ижбулатов [Sat, 24 Mar 2018 10:04:38 +0000 (10:04 +0000)]
GDK W32: adapt to the recent changes in GdkEvent
https://bugzilla.gnome.org/show_bug.cgi?id=773299
Dz Chen [Fri, 23 Mar 2018 15:55:05 +0000 (23:55 +0800)]
Update zh_CN po and po-properties translations
Daniel Boles [Thu, 22 Mar 2018 20:58:31 +0000 (20:58 +0000)]
Adwaita: Regenerate CSS from SASS
https://gitlab.gnome.org/GNOME/gtk/merge_requests/66 introduced spurious
red/green fore/background.
Also, the GtkVideo stuff didn't get regenerated in.
Daniel Boles [Thu, 22 Mar 2018 20:54:01 +0000 (20:54 +0000)]
Merge branch 'toolbar-spacing-fix' into 'master'
theme: Be more selective when adding margins to toolbar items
See merge request GNOME/gtk!66
Benjamin Otte [Wed, 21 Mar 2018 20:58:08 +0000 (21:58 +0100)]
surface: Make process_updates no longer be a vfunc
Benjamin Otte [Wed, 21 Mar 2018 19:33:20 +0000 (20:33 +0100)]
surface: Remove some unused vfuncs
Benjamin Otte [Wed, 21 Mar 2018 19:15:21 +0000 (20:15 +0100)]
gdk: Remove GdkSurfaceImpl::shape_combine_region vfunc
... and all the implementations.
Input shapes still exist.
Benjamin Otte [Wed, 21 Mar 2018 18:58:49 +0000 (19:58 +0100)]
gdk: Remove a bunch of unused variables
Emmanuele Bassi [Wed, 21 Mar 2018 11:49:24 +0000 (11:49 +0000)]
Reduce the header level in the bug template
Make version and additional information headers use h2, like everything else.
Matthias Clasen [Wed, 21 Mar 2018 11:40:55 +0000 (11:40 +0000)]
Merge branch 'wip/sync-pre-swap-buffers' into 'master'
Synchronize wl_surface state before wl_surface_commit
See merge request GNOME/gtk!75
Alexander Larsson [Wed, 21 Mar 2018 10:49:14 +0000 (11:49 +0100)]
Continue renaming window to surface
This renames a lot of arguments, local variables and functions.
Alexander Larsson [Wed, 21 Mar 2018 08:18:30 +0000 (09:18 +0100)]
GdkSurface: Fix doc comments for remoteve invalidate_children argument
Alexander Larsson [Wed, 21 Mar 2018 08:17:50 +0000 (09:17 +0100)]
broadway: Fix up window -> surface renames
Alexander Larsson [Wed, 21 Mar 2018 08:06:31 +0000 (09:06 +0100)]
Fix up indentation after GdkSurface rename
This fixes up a lot of the indentation issues from the
rename of windows to surfaces, at least the ones in the headers
and many others.
Jonas Ådahl [Wed, 21 Mar 2018 06:08:13 +0000 (14:08 +0800)]
wayland/vulkancontext: Sync surface state before vkQueuePresentKHR
A side effect of vkQueuePresentKHR is the Vulkan implementation calling
wl_surface_commit() on the corresponding Wayland surface. Thus, before
this, we must synchronize the surface state (e.g. opaque region, window
geometry, etc) that changed since last time. Prior to this commit this
was done after calling vkQueuePresentKHR(), causing the surface state to
always correspond to the previous buffer state. As of this commit this
is now done before calling vkQueuePresentKHR(), thus before
wl_surface_commit().
Jonas Ådahl [Wed, 21 Mar 2018 06:01:58 +0000 (14:01 +0800)]
wayland/glcontext: Sync surface state before swapping buffers
A side effect of eglSwapBuffers* is the EGL implementation calling
wl_surface_commit() on the corresponding Wayland surface. Thus, before
swapping buffers, we must synchronize the surface state (e.g. opaque
region, window geometry, etc) that changed since the last buffer swap.
Prior to this commit, this was done after eglSwapBuffers*, causing the
surface state to always correspond to the previous buffer state. As of
this commit this is now done before swapping the buffers, thus before
wl_surface_commit().
Benjamin Otte [Wed, 21 Mar 2018 03:07:37 +0000 (04:07 +0100)]
surface: Simplify gdk_surface_invalidate_region()
Remove duplicate functions and unused arguments.
Functionality is identical otherwise.
Benjamin Otte [Wed, 21 Mar 2018 02:51:29 +0000 (03:51 +0100)]
surface: Stop tracking clip region
It's not needed because we're not using it for anything anymore now that
client-side surfaces aren't drawn anymore.
Benjamin Otte [Wed, 21 Mar 2018 02:42:34 +0000 (03:42 +0100)]
gdk: Remove gdk_surface_shape_combine_region()
If you want transparent region, you can just render them transparent.
If you want input shaping, use gdk_surface_input_shape_combine_region().
Also remove gtk_widget_shape_combine_region().
Benjamin Otte [Wed, 21 Mar 2018 01:57:48 +0000 (02:57 +0100)]
surface: Remove gdk_surface_get_clip_region()
... and gdk_surface_get_visible_region() APIs. They are unused.
Benjamin Otte [Wed, 21 Mar 2018 01:50:37 +0000 (02:50 +0100)]
gdk: Remove unused members from surface struct
Benjamin Otte [Wed, 21 Mar 2018 01:45:43 +0000 (02:45 +0100)]
surface: Stop shaping native children of csw surfaces
We don't have them anymore and they are goig away anyway.
Emmanuele Bassi [Wed, 21 Mar 2018 01:02:23 +0000 (01:02 +0000)]
docs: Drop the 'Contributing' section from the README
We have a whole document for that, and it's up to date with regards to
the GitLab workflow.
Emmanuele Bassi [Wed, 21 Mar 2018 00:59:06 +0000 (00:59 +0000)]
Add a template for bug reports
GitLab issues can use templates to guide users when filing new bug
reports; we should take advantage of this feature.
Emmanuele Bassi [Wed, 21 Mar 2018 00:58:46 +0000 (00:58 +0000)]
docs: Point at the right place for new bugs
We use GitLab issues, now.
Emmanuele Bassi [Wed, 21 Mar 2018 00:45:09 +0000 (00:45 +0000)]
Add a build status badge
Like all cool kids are doing, these days.
Matthias Clasen [Wed, 21 Mar 2018 00:04:20 +0000 (20:04 -0400)]
Add appdata for gtk4-widget-factory
This will let us build a better flatpak for gtk4-widget-factory.
Benjamin Otte [Tue, 20 Mar 2018 23:55:59 +0000 (00:55 +0100)]
surface: Remove GSK_SURFACE_ROOT
Root surface have been dead for a while now, no need to keep the enum
value around.
Emmanuele Bassi [Tue, 20 Mar 2018 23:52:31 +0000 (23:52 +0000)]
Merge branch 'ci-flatpak'
Generate Flatpak bundles for gtk-demo and gtk-widget-factory when
running the CI pipeline, and store them as artifacts on the CI server.
Benjamin Otte [Tue, 20 Mar 2018 23:35:51 +0000 (00:35 +0100)]
surface: Remove gdk_surface_invalidate_maybe_recurse()
This also means we can now get rid of child funcs because they're not
used anymore.
Benjamin Otte [Tue, 20 Mar 2018 22:55:20 +0000 (23:55 +0100)]
surface: Remove gdk_surface_scroll()
It's yet another fancy way to call gdk_surface_invalidate_region().
Also remove the one testgtk test that was still using it.
Benjamin Otte [Tue, 20 Mar 2018 22:04:36 +0000 (23:04 +0100)]
surface: Remove gdk_surface_move_region()
It's just a cute version of gdk_surface_invalidate_region()
these days and people can call that function instead.
Benjamin Otte [Tue, 20 Mar 2018 21:53:13 +0000 (22:53 +0100)]
surface: Remove queue_antiexpose()
... and its implementation in the X11 backend.
GDK does lots of work trying to reduce the region in expose events
so that when the server sends multiple expose events, touching the
same area we can make sure to only redraw stuff once. However:
(1) this is only relevant of there's tons of delay and multiple
expose events get sent
(2) we coalesce multiple events into a single expose event anyway
(3) we do this on the frame clock
But most importantly:
(4) Since the invention of compositing, servers caches all contents
anyway
Benjamin Otte [Tue, 20 Mar 2018 21:32:26 +0000 (22:32 +0100)]
gdk: Remove unused area member from GdkEventExpose
Benjamin Otte [Tue, 20 Mar 2018 21:30:04 +0000 (22:30 +0100)]
gdk: Remove unused count member from GdkEventExpose
Benjamin Otte [Tue, 20 Mar 2018 03:40:09 +0000 (04:40 +0100)]
widget: Remove useless macro
Matthias Clasen [Tue, 20 Mar 2018 23:40:30 +0000 (19:40 -0400)]
Add appdata for gtk4-demo
This will let us build a better flatpak for gtk4-demo.
Emmanuele Bassi [Tue, 20 Mar 2018 16:08:45 +0000 (16:08 +0000)]
ci: Add two flatpak jobs
When building GTK through the CI infrastructure, it would help to have
some ways of testing it; for instance, if we want to verify that theme
changes are useful, or if we want to run the result without necessarily
build it locally.
This is where flatpak comes in handy. By having the CI build a flatpak
buundle, and storing it as an artifact, of the GTK demos, we can easily
point developers and designers to an installable binary that won't break
their system, nor will require development tools and environments to
run.
Emmanuele Bassi [Tue, 20 Mar 2018 16:07:38 +0000 (16:07 +0000)]
Add flatpak builder manifests for our demos
We can use manifests as targets when building GTK inside a flatpak
environment; or we can use them for CI purposes.
Olivier Fourdan [Tue, 30 Jan 2018 12:57:35 +0000 (13:57 +0100)]
wayland: Drop cairo surfaces when withdrawing
If a surface is unmapped by the client while gdk is processing updates,
(for example Firefox un-mapping its window on Expose events), the
windowing backend resources might be lost (for example with Wayland)
which can cause a crash in end_paint().
Make sure we drop the cairo surfaces as well when hiding the surface,
that will avoid the crash in gdk_surface_impl_wayland_end_paint() when
trying to attach the staging cairo surface to a released wl_surface,
these will be recreated when needed when the surface becomes visible
again and there is no need to keep such buffers around for a surface
which is not visible anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=793062
Emmanuele Bassi [Tue, 20 Mar 2018 17:20:28 +0000 (17:20 +0000)]
Merge branch 'tests-gdk' into 'master'
gitlab-ci: enable gtk+:gdk tests
See merge request GNOME/gtk!74
Emmanuele Bassi [Tue, 20 Mar 2018 17:00:19 +0000 (17:00 +0000)]
tests: Update renamed symbol
Carlos Garnacho [Tue, 20 Mar 2018 17:03:15 +0000 (17:03 +0000)]
Merge branch 'detect-synaptics-touchpads-v2' into 'master'
x11/xi2: Report touchpads as TOUCHPAD, not MOUSE
See merge request GNOME/gtk!65
Piotr Drąg [Tue, 20 Mar 2018 16:32:35 +0000 (17:32 +0100)]
Update POTFILES.in
Christoph Reiter [Tue, 20 Mar 2018 16:31:38 +0000 (17:31 +0100)]
gitlab-ci: enable gtk+:gdk tests
xvfb doesn't like C.utf8 and returns XLocaleNotSupported.
While (afaik) C.utf8 and C.UTF.8 should be the same thing, and the former
is returned by locale -a on Fedora, switch to C.UTF-8 to make xvfb happy.
This makes gtk+:gdk tests pass.
Alexander Larsson [Tue, 20 Mar 2018 16:16:57 +0000 (16:16 +0000)]
Merge branch 'rename-window-to-surface' into 'master'
Rename window to surface
See merge request GNOME/gtk!72
Matthias Clasen [Tue, 20 Mar 2018 15:46:20 +0000 (15:46 +0000)]
Merge branch 'accessible-role' into 'master'
gtkbuilder: add accessibility role declaration
Closes #109
See merge request GNOME/gtk!69
Benjamin Otte [Tue, 20 Mar 2018 15:36:19 +0000 (15:36 +0000)]
Merge branch 'style-context-null-widget-guard-master' into 'master'
gtkstylecontext: guard against gtk_css_widget_node_get_widget() returning NULL in more places
See merge request GNOME/gtk!71
Matthias Clasen [Tue, 20 Mar 2018 15:33:35 +0000 (15:33 +0000)]
Merge branch 'a11y-fixes' into 'master'
Fix some accessibility issues in demos
Closes #110
See merge request GNOME/gtk!68