Markus Goetz [Mon, 8 May 2017 15:01:37 +0000 (17:01 +0200)]
Update release_template.md
Markus Goetz [Mon, 8 May 2017 14:17:07 +0000 (16:17 +0200)]
Update release_template.md
Christian Kamm [Wed, 26 Apr 2017 10:41:30 +0000 (12:41 +0200)]
Remove 3rdparty qjson #5710
Christian Kamm [Wed, 26 Apr 2017 10:40:32 +0000 (12:40 +0200)]
Port PollJob responses to Qt5's QJson #5710
Christian Kamm [Wed, 26 Apr 2017 10:15:33 +0000 (12:15 +0200)]
Switch JsonApiJob to Qt5's QJson #5710
Christian Kamm [Wed, 26 Apr 2017 09:38:10 +0000 (11:38 +0200)]
Sharing: Switch from QtJson to Qt5's QJson #5710
Olivier Goffart [Fri, 28 Apr 2017 11:16:19 +0000 (13:16 +0200)]
Discovery: Increase the MAX_DEPTH and show deep folder as ignored
Before this patch, to deep folder would just be ignored, without any feedback.
This patch makes it so deep folder are properly shown as ignored in the UI.
Also increase the MAX_DEPTH
Issue: #1067
Markus Goetz [Wed, 26 Apr 2017 18:03:55 +0000 (20:03 +0200)]
Selective Sync: Open sub folder context menu #5596
Olivier Goffart [Fri, 5 May 2017 11:35:40 +0000 (13:35 +0200)]
Exclude list: remove .htaccess
As per issue #5701, if the server does not support it, let the server
show return an error, but we should not blacklist it localy
Christian Kamm [Thu, 4 May 2017 13:12:14 +0000 (15:12 +0200)]
Downloads: Remove empty temporary if disk space full #5746
Christian Kamm [Thu, 27 Apr 2017 08:13:55 +0000 (10:13 +0200)]
SSL error handling: Remove unnecessary confusing code
I'm confident this is unnecessary. The original bug in #3283 was
to call ignoreSslErrors() without an argument in the 'accept'
case, which meant ignoring *all* subsequent SSL errors.
With that fixed, explicitly aborting the reply and resetting QNAM
is not needed since not ignoring the error will lead to the SSL
handshake failing.
See also:
75b38d1a2ffe57d0f1eb3ebb8c5f30b8b2a185e4 (workaround introduced)
89376e14d6135a6f39a6df99d54fde253573575c (real fix)
76ce5adbf02af052ab8d7596b8ded75c7d4d7fcb (cherry-pick of workaround)
Markus Goetz [Wed, 26 Apr 2017 16:31:12 +0000 (18:31 +0200)]
Wizard: Don't show not-so-useful result page #5726
Better immediately show the settings dialog where people can see what's going on.
They can go to sync folder or webinterface from there.
Olivier Goffart [Fri, 28 Apr 2017 09:57:02 +0000 (11:57 +0200)]
Better words for the error message when one cannot create the database.
Issue #5291
Matthew Setter [Wed, 3 May 2017 11:32:21 +0000 (13:32 +0200)]
Merge pull request #5741 from owncloud/add-checksum-details
Document the checksums addition in 10.0
Matthew Setter [Wed, 3 May 2017 11:17:09 +0000 (13:17 +0200)]
Increase the clarity of the checksum statements
This comes after discussion and feedback with @phil-davis.
Christian Kamm [Tue, 2 May 2017 10:58:01 +0000 (12:58 +0200)]
Share dialog: Add option to copy/email direct links #5627
Matthew Setter [Tue, 2 May 2017 10:46:33 +0000 (12:46 +0200)]
Document the checksums addition in 10.0
This commit documents the new checksums addition in 10.0, specifically
in the desktop client. This fixes owncloud/documentation/issues/2964.
Luca Lorenzetto [Thu, 27 Apr 2017 08:34:07 +0000 (10:34 +0200)]
When creating explorer favorite use more specific windows functions (#5690)
Fixes https://github.com/owncloud/client/issues/2719
Tommy Sparber [Mon, 10 Oct 2016 10:38:05 +0000 (12:38 +0200)]
Move check for mono icons into separate function
Michael Stingl [Mon, 24 Apr 2017 09:54:53 +0000 (11:54 +0200)]
templates > .github and create release_template (#5590)
Christian Kamm [Mon, 24 Apr 2017 08:32:53 +0000 (10:32 +0200)]
Merge remote-tracking branch 'origin/2.3'
Jenkins for ownCloud [Mon, 24 Apr 2017 00:18:29 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 23 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 22 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Kiril Vladimiroff [Fri, 21 Apr 2017 16:13:32 +0000 (19:13 +0300)]
Remove all conditional checks for Qt 4.x (#5505)
Christian Kamm [Fri, 21 Apr 2017 12:08:00 +0000 (14:08 +0200)]
Sharing multiple public links: Depend on new capability
See owncloud/core#27709: files_sharing/public/multiple
ckamm [Fri, 21 Apr 2017 08:17:55 +0000 (10:17 +0200)]
Merge pull request #5695 from ckamm/sharedialog-multiplelinkshares
Multiple link shares and UI adjustments for share dialog
Christian Kamm [Wed, 12 Apr 2017 09:09:20 +0000 (11:09 +0200)]
ShareDialog: Review fixes
* Allow creating nameless shares
* Display token as name for nameless shares
(both to be consistent with server)
* Allow changing a share's name by editing it in the table
* Minor adjustments
Christian Kamm [Wed, 5 Apr 2017 07:38:46 +0000 (09:38 +0200)]
ShareDialog: Add support for multiple public link shares #5655
Starting from oC 10.0.0 having several public link shares with
different attributes for a path will be supported. This adds
functionality to create, edit and delete these public link shares.
The behavior is currently gated by server version, but should be
adapted to use a capability as soon as one is introduced, see
owncloud/core#27622.
The UI reduces to a single-share version when talking to older servers.
Testing scenarios:
* Link sharing is disabled (by capability, not by theme)
* Required passwords
* Required expiry
* Forbidden 'allow upload' for folders
* New and old servers
Christian Kamm [Tue, 4 Apr 2017 13:05:08 +0000 (15:05 +0200)]
Rename ShareWidget to ShareUserLine
There will probably be a ShareLinkLine too, due to #5655
Christian Kamm [Tue, 4 Apr 2017 12:41:25 +0000 (14:41 +0200)]
ShareDialog: Use a tab widget #5655
Jenkins for ownCloud [Fri, 21 Apr 2017 00:18:30 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Kaustubh Welankar [Thu, 20 Apr 2017 09:14:53 +0000 (14:44 +0530)]
Removed Magic Numbers in propagator #5685 (#5705)
Olivier Goffart [Thu, 13 Apr 2017 11:02:00 +0000 (13:02 +0200)]
Require Qt5
Dominik Schmidt [Tue, 4 Apr 2017 13:53:22 +0000 (15:53 +0200)]
Disable Qt4 CI
ckamm [Thu, 20 Apr 2017 07:21:33 +0000 (09:21 +0200)]
Fix a crash in ProxyAuthHandler (#5711)
See
https://sentry.io/owncloud/desktop-win-and-mac/issues/
243433178/activity/
https://sentry.io/owncloud/desktop-win-and-mac/issues/
234182688/activity/
The problem was that an account's QNetworkAccessManager can be deleted
when reentering the event loop.
ckamm [Thu, 20 Apr 2017 07:16:55 +0000 (09:16 +0200)]
FolderStatusModel: Fix crash for empty relativePath (#5713)
The problem was that split("", SkipEmptyParts) is the empty list.
See
https://sentry.io/owncloud/desktop-win-and-mac/issues/
251167186/
Markus Goetz [Thu, 20 Apr 2017 06:55:44 +0000 (08:55 +0200)]
Some Dialogs: Bring to top on tray click #5515 #5566 (#5664)
On my OS X, it might get hidden under other apps while I opened it and then want to quickly
verify something in another app.
Jenkins for ownCloud [Thu, 20 Apr 2017 00:18:30 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Wed, 19 Apr 2017 09:02:03 +0000 (11:02 +0200)]
Server: Parse version from capabilities too #5691 (#5698)
Newer servers will have the option of hiding version, versionstring, edition
and productname. They will always send the full information in the capabilities.
dheule [Wed, 19 Apr 2017 08:32:36 +0000 (10:32 +0200)]
added owncloudcmd bandwidth limit parameter (#5707)
Jenkins for ownCloud [Wed, 19 Apr 2017 00:18:38 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 18 Apr 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 17 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 16 Apr 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 15 Apr 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 14 Apr 2017 00:18:37 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Thu, 13 Apr 2017 09:40:27 +0000 (11:40 +0200)]
Merge remote-tracking branch 'origin/avatar_pics'
Also fix compilation because of
22370fdbdadd06f0cacd249a8d7a32f0d3c1374e
Pull request #5482
Olivier Goffart [Thu, 13 Apr 2017 08:19:35 +0000 (10:19 +0200)]
Merge remote-tracking branch 'origin/2.3'
Conflicts:
VERSION.cmake
Christian Kamm [Wed, 12 Apr 2017 13:25:26 +0000 (15:25 +0200)]
AccountSettings: Sync with clean discovery on Ctrl-F6 #5666
Christian Kamm [Wed, 12 Apr 2017 13:24:54 +0000 (15:24 +0200)]
AccountSettings: Easier access to selected folder alias
Olivier Goffart [Fri, 31 Mar 2017 09:13:18 +0000 (11:13 +0200)]
owncloudcmd: return code depend on sync result
Issue #3936
Jenkins for ownCloud [Thu, 13 Apr 2017 00:18:32 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Wed, 12 Apr 2017 15:55:28 +0000 (17:55 +0200)]
Avatar: macOS support
Jenkins for ownCloud [Wed, 12 Apr 2017 00:18:30 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Christian Kamm [Tue, 11 Apr 2017 13:50:32 +0000 (15:50 +0200)]
ShareDialog: Reenable user input textedit on error #5694
Jenkins for ownCloud [Tue, 11 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Mon, 10 Apr 2017 14:15:28 +0000 (16:15 +0200)]
Wizard: Improve folder creation (2)
Jenkins for ownCloud [Mon, 10 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 9 Apr 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 8 Apr 2017 00:18:38 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 7 Apr 2017 23:15:19 +0000 (01:15 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 7 Apr 2017 00:18:29 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 6 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 5 Apr 2017 23:15:15 +0000 (01:15 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Wed, 5 Apr 2017 14:55:36 +0000 (16:55 +0200)]
Wizard: Improve folder creation
Jenkins for ownCloud [Wed, 5 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Christian Kamm [Tue, 4 Apr 2017 08:49:26 +0000 (10:49 +0200)]
Doc: Update to new sync journal db name #5662
Christian Kamm [Tue, 4 Apr 2017 07:54:06 +0000 (09:54 +0200)]
Transfers: Show a decimal for single digit MB rates #4428
Christian Kamm [Tue, 28 Mar 2017 09:15:53 +0000 (11:15 +0200)]
ShareDialog: Hide the detailed permissions if there is only one #5655
Christian Kamm [Tue, 28 Mar 2017 09:05:24 +0000 (11:05 +0200)]
ShareDialog: Margin and spacing refinements #5627
Christian Kamm [Tue, 28 Mar 2017 09:04:57 +0000 (11:04 +0200)]
ShareDialog: Fix thumbnail size #5654
Christian Kamm [Tue, 4 Apr 2017 07:38:23 +0000 (09:38 +0200)]
owncloudcmd docs: Mention required sync-exclude.lst #5679
Christian Kamm [Thu, 23 Mar 2017 14:53:22 +0000 (15:53 +0100)]
Improve http error messages; cleanup
By default QNetworkReply::errorString() often produces messages like
"Error downloading <url> - server replied: <reason>"
but the "downloading" part invariably confuses people since the
error might very well have been produced by a PUT request.
This commit produces clearer error messages for HTTP errors.
Additionally:
* Remove some unnecessary null checks from slots connected to
network job signals and document that these signals never send
null replies.
* There was a bug where AbstractNetworkJob::_timedout wasn't
set when derived classes overrode slotTimeout. We now ensure
it's always set by disallowing overrides of slotTimeout.
Instead it now calls onTimedOut, which allows custom handling.
* Several subclasses declared errorString, isTimedOut. Move
these to AbstractNetworkJob.
* Unify handling of OC-ErrorString (via the new, general
Job::errorString)
* Add documentation in various places.
Jenkins for ownCloud [Tue, 4 Apr 2017 00:18:31 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Samuel Alfageme [Mon, 3 Apr 2017 12:49:41 +0000 (14:49 +0200)]
Fixing a duplicate in the build instructions
- The duplicate and some typos were introduced in
42aed56a5a92a32b86e2bdd1c6e9d75e27728c8b
- Also fixes some minor format issues. There's a lot of notes in this docs, we should refactor some.
Jenkins for ownCloud [Mon, 3 Apr 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 2 Apr 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 1 Apr 2017 00:18:36 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 31 Mar 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 30 Mar 2017 00:18:30 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Markus Goetz [Wed, 29 Mar 2017 16:23:48 +0000 (18:23 +0200)]
Chunking NG: Also send OC-Total-Length on MOVE
For https://github.com/owncloud/core/issues/26988
Roeland Jago Douma [Wed, 29 Mar 2017 15:33:32 +0000 (17:33 +0200)]
complete url when using themed wizardUrlPostfix
Before we would only open the part of the url that the users entered.
Now if the wizardUrlPostfix is used this is should be appended to that
when opening the browser on the result page.
Samuel Alfageme [Wed, 29 Mar 2017 15:26:10 +0000 (17:26 +0200)]
Removed the coverity badge
Following the discussion on https://github.com/owncloud/client/commit/
da45d99b8fed9a37df8031433e11eb574c28a8df
Also updated the link to the current building instructions.
Jenkins for ownCloud [Wed, 29 Mar 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 28 Mar 2017 13:21:59 +0000 (15:21 +0200)]
PropagateDownload: fix possible crash
Backtrace looks like this:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x0
File "propagatedownload.cpp", line 234, in OCC::GETFileJob::slotReadyRead
File "moc_propagatedownl_CA5CFSHZDTX34X.cpp", line 86, in OCC::GETFileJob::qt_static_metacall
File "qobject.cpp", line 495, in QMetaCallEvent::placeMetaCall
File "qobject.cpp", line 1256, in QObject::event
File "qapplication.cpp", line 3804, in QApplicationPrivate::notify_helper
GETFileJob::slotReadyRead can be called with a QueuedConnection when the
bendwith manager is involved. In that case, if the QNAM was reset
in between, the reply might have been destroyed.
(This is only speculation based on the backtrace)
Olivier Goffart [Tue, 28 Mar 2017 13:11:58 +0000 (15:11 +0200)]
AccountState: Attempt to fix a crash
Backtrace from the crash reporter:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x21
File "qcoreapplication.cpp", line 1281, in QCoreApplication::postEvent
File "qobject.cpp", line 2125, in QObject::deleteLater
File "connectionvalidator.cpp", line 240, in OCC::ConnectionValidator::reportResult
File "connectionvalidator.cpp", line 206, in OCC::ConnectionValidator::slotAuthFailed
File "moc_connectionvalidator.cpp", line 127, in OCC::ConnectionValidator::qt_static_metacall
File "qobject.cpp", line 3716, in QMetaObject::activate
File "moc_networkjobs.cpp", line 653, in OCC::PropfindJob::finishedWithError
File "networkjobs.cpp", line 570, in OCC::PropfindJob::finished
I believe the problem is caused because 'this' was deleted in ConnectionValidator::reportResult
as the signal connectionResult gets emited. The AccountState::slotConnectionValidatorResult
slot does indeed call slotInvalidCredentials which might call {Shibboleth,Http}Credentials::fetchFromKeychain
which might emit fetched directly, which will call AccountState::slotCredentialsFetched
which deletes the _connectionValidator
So use deleteLater when deleting the _connectionValidator, hoping this helps
Christian Kamm [Tue, 28 Mar 2017 09:35:01 +0000 (11:35 +0200)]
Merge branch 'dynamic_chunking'
Christian Kamm [Fri, 24 Mar 2017 14:01:50 +0000 (15:01 +0100)]
dynamic chunking: cleanup, fixes, improvements
* make target duration a client option instead of a capability
* simplify algorithm for determining chunk size significantly
* preserve chunk size for the whole propagation, not just per upload
* move options to SyncOptions to avoid depending on ConfigFile
in the propagator
* move chunk-size adjustment to after a chunk finishes, not when
a new chunk starts
Jenkins for ownCloud [Tue, 28 Mar 2017 00:18:27 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Piotr M [Wed, 7 Dec 2016 21:35:50 +0000 (22:35 +0100)]
dynamic chunking prototype
Jenkins for ownCloud [Mon, 27 Mar 2017 00:18:28 +0000 (02:18 +0200)]
[tx-robot] updated from transifex
Olivier Goffart [Sat, 25 Mar 2017 08:06:08 +0000 (09:06 +0100)]
VERSION: 2.3.1 was release, this branch is now for 2.3.2
Jenkins for ownCloud [Sat, 25 Mar 2017 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 25 Mar 2017 00:15:15 +0000 (01:15 +0100)]
[tx-robot] updated from transifex
Jürgen Weigert [Fri, 24 Mar 2017 16:49:20 +0000 (17:49 +0100)]
Update CMakeLists.txt
remove doc-man target in doc/CMakeLists.txt https://github.com/owncloud/client/issues/2153
ajasja [Sat, 18 Mar 2017 23:12:07 +0000 (00:12 +0100)]
Documented the usage of environment variables.
In particular the `OWNCLOUD_CHUNK_SIZE` as requested per #2449.
I looked through the code and it seems the env vars override the conf file, but I'm not 100 % sure.
The `OWNCLOUD_CRITICAL_FREE_SPACE_BYTES` and `OWNCLOUD_FREE_SPACE_BYTES` are now mentioned in two places.
Christian Kamm [Wed, 22 Mar 2017 12:22:22 +0000 (13:22 +0100)]
ShareDialog: Make "can edit" partially checked sometimes #5642
Previously the check box was checked if *any* of its sub-permissions
were granted. This can hide the fact that only a limited subset of them
are actually granted.
The new behavior is to display as "partially checked" if only some
of the sub-permissions are available. Clicking the check box itself
still toggles between granting all or none of them.
Jenkins for ownCloud [Fri, 24 Mar 2017 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Markus Goetz [Thu, 23 Mar 2017 17:18:36 +0000 (18:18 +0100)]
Update README.md
Fix Jenkins badges