Matthieu Gallien [Tue, 4 Oct 2022 11:37:16 +0000 (13:37 +0200)]
pick up clang-format conf files from KDE community
takes it from current extra-cmake-modules repository
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 30 Sep 2022 14:43:23 +0000 (16:43 +0200)]
let's check the format via some github action
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Camila [Tue, 4 Oct 2022 13:35:16 +0000 (15:35 +0200)]
Merge pull request #5002 from nextcloud/update-client-image
Update client image
Camila [Mon, 3 Oct 2022 14:59:14 +0000 (16:59 +0200)]
Remove clang-tidy from .drone.yml.
It is being replaced by GH actions.
Signed-off-by: Camila <hello@camila.codes>
Camila [Mon, 3 Oct 2022 14:57:50 +0000 (16:57 +0200)]
Update to docker image to client-5.15-11.
Signed-off-by: Camila <hello@camila.codes>
Claudio Cambra [Tue, 4 Oct 2022 10:58:34 +0000 (12:58 +0200)]
Merge pull request #4962 from nextcloud/bugfix/files-not-unlocking
Claudio Cambra [Mon, 3 Oct 2022 15:22:36 +0000 (17:22 +0200)]
Ensure we are checking lock state without affecting sync behaviour
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Wed, 21 Sep 2022 11:06:16 +0000 (13:06 +0200)]
Check local file locked and unlocked correctly in testlocaldiscovery
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Sat, 24 Sep 2022 01:00:54 +0000 (03:00 +0200)]
Unschedule previously scheduled sync runs for locked files if it is found the sync run is no longer needed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Fri, 23 Sep 2022 00:33:15 +0000 (02:33 +0200)]
More efficiently schedule sync runs for files that need delayed sync runs
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Tue, 20 Sep 2022 21:03:39 +0000 (23:03 +0200)]
Fix files not unlocking after lock time expired
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Matthieu Gallien [Tue, 4 Oct 2022 09:44:46 +0000 (11:44 +0200)]
Merge pull request #4992 from nextcloud/ci/useNoDiscard
Ci/use no discard
Matthieu Gallien [Fri, 30 Sep 2022 17:12:08 +0000 (19:12 +0200)]
add [[nodiscard]] attribute via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 30 Sep 2022 17:19:03 +0000 (19:19 +0200)]
fix [[nodiscard]] single warning
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 4 Oct 2022 09:14:27 +0000 (11:14 +0200)]
Merge pull request #4993 from nextcloud/ci/useUsing
apply modernize-use-using via clang-tidy
Matthieu Gallien [Fri, 30 Sep 2022 17:56:31 +0000 (19:56 +0200)]
apply modernize-use-using via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-using' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Mon, 3 Oct 2022 23:13:20 +0000 (01:13 +0200)]
Merge pull request #4982 from nextcloud/bugfix/enforced-max-expire-date-link-share-fix
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
Claudio Cambra [Wed, 28 Sep 2022 10:26:37 +0000 (12:26 +0200)]
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Matthieu Gallien [Mon, 3 Oct 2022 20:01:51 +0000 (22:01 +0200)]
Merge pull request #5004 from nextcloud/configure-clang-tidy-checks
configure a list of checks for clang-tidy
Matthieu Gallien [Mon, 3 Oct 2022 19:05:50 +0000 (21:05 +0200)]
configure a list of checks for clang-tidy
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 3 Oct 2022 18:53:22 +0000 (20:53 +0200)]
Merge pull request #5003 from nextcloud/update-client-appimage-image
switch AppImage CI to latest tag: client-appimage-6
Matthieu Gallien [Mon, 3 Oct 2022 15:22:02 +0000 (17:22 +0200)]
switch AppImage CI to latest tag: client-appimage-6
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 3 Oct 2022 11:50:22 +0000 (13:50 +0200)]
Merge pull request #4994 from nextcloud/ci/cppcoreguidelines-pro-type-static-cast-downcast
avoid possibly crashing static_cast
Matthieu Gallien [Fri, 30 Sep 2022 19:36:58 +0000 (21:36 +0200)]
avoid possibly crashing static_cast
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 3 Oct 2022 08:22:45 +0000 (10:22 +0200)]
Merge pull request #4996 from nextcloud/cleanConfigFileConstants
alway use constexpr for all text constants
Matthieu Gallien [Sun, 2 Oct 2022 13:48:20 +0000 (15:48 +0200)]
Merge branch 'master' into cleanConfigFileConstants
Matthieu Gallien [Sun, 2 Oct 2022 13:48:07 +0000 (15:48 +0200)]
Merge pull request #4999 from nextcloud/ci/checkClangTidyInCi
check our code with clang-tidy
Matthieu Gallien [Fri, 30 Sep 2022 19:52:54 +0000 (21:52 +0200)]
check our code with clang-tidy
should allow to keep our code tidy and maybe simplify reviews
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Sun, 2 Oct 2022 13:14:06 +0000 (15:14 +0200)]
Merge pull request #4995 from nextcloud/ci/checkClangTidyInCi
Ci/check clang tidy in ci
Matthieu Gallien [Fri, 30 Sep 2022 19:52:54 +0000 (21:52 +0200)]
check our code with clang-tidy
should allow to keep our code tidy and maybe simplify reviews
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Fri, 30 Sep 2022 19:44:05 +0000 (21:44 +0200)]
use auto
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Sat, 1 Oct 2022 13:31:25 +0000 (15:31 +0200)]
alway use constexpr for all text constants
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Sat, 1 Oct 2022 16:14:41 +0000 (16:14 +0000)]
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 30 Sep 2022 22:06:54 +0000 (00:06 +0200)]
Merge pull request #4988 from nextcloud/bugfix/macos-no-context-menu
Don't set up tray context menu on macOS, even if not building app bundle
Claudio Cambra [Thu, 29 Sep 2022 18:01:35 +0000 (20:01 +0200)]
Don't set up tray context menu on macOS, even if not building app bundle
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Fri, 30 Sep 2022 17:37:07 +0000 (19:37 +0200)]
Merge pull request #4987 from nextcloud/bugfix/fix-predefined-status-text
Claudio Cambra [Thu, 29 Sep 2022 17:37:55 +0000 (19:37 +0200)]
Fix predefined status text formatting
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Fri, 30 Sep 2022 05:44:39 +0000 (05:44 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 29 Sep 2022 20:37:43 +0000 (22:37 +0200)]
Merge pull request #4986 from nextcloud/bugfix/sync-progress-bar-dark
Fix sync progress bar colours in dark mode
Claudio Cambra [Thu, 29 Sep 2022 17:21:49 +0000 (19:21 +0200)]
Fix sync progress bar colours in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Camila [Thu, 29 Sep 2022 16:34:01 +0000 (18:34 +0200)]
Merge pull request #4985 from nextcloud/bugfix/primary-buttons
Fix 'Reply' primay property.
Camila [Thu, 29 Sep 2022 15:15:50 +0000 (17:15 +0200)]
Update tests to follow 'Reply' change of primary action.
Signed-off-by: Camila <hello@camila.codes>
Camila [Thu, 29 Sep 2022 13:14:01 +0000 (15:14 +0200)]
Fix 'Reply' action primary property.
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.
Signed-off-by: Camila <hello@camila.codes>
Camila [Thu, 29 Sep 2022 13:13:01 +0000 (15:13 +0200)]
Remove unused property.
Signed-off-by: Camila <hello@camila.codes>
Claudio Cambra [Thu, 29 Sep 2022 10:48:47 +0000 (12:48 +0200)]
Merge pull request #4976 from nextcloud/feature/nicer-errorbox
Improve the error box QML component
Claudio Cambra [Mon, 26 Sep 2022 11:12:59 +0000 (13:12 +0200)]
Improve the error box QML component
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Thu, 29 Sep 2022 04:35:11 +0000 (04:35 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Wed, 28 Sep 2022 11:43:17 +0000 (13:43 +0200)]
Merge pull request #4784 from nextcloud/bugfix/activity-action-button
Make activity action button an actual button, clean up contents
Claudio Cambra [Wed, 27 Jul 2022 19:07:53 +0000 (21:07 +0200)]
Make activity action button an actual button, clean up contents
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Wed, 28 Sep 2022 11:06:45 +0000 (13:06 +0200)]
Merge pull request #4960 from nextcloud/bugfix/emoji-picker-placeholder-wrap
Ensure placeholder message in emoji picker wraps correctly
Claudio Cambra [Tue, 20 Sep 2022 16:40:34 +0000 (18:40 +0200)]
Ensure placeholder message in emoji picker wraps correctly
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Wed, 28 Sep 2022 04:32:38 +0000 (04:32 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Camila [Tue, 27 Sep 2022 14:52:25 +0000 (16:52 +0200)]
Merge pull request #4967 from nextcloud/bugfix/issue-4841
Fix two factor authentication notification
Camila [Wed, 21 Sep 2022 15:22:01 +0000 (17:22 +0200)]
Fix persistent two factor auth notification.
The server app returns a 202 code when the request succeeded, which was
not taken into account.
Signed-off-by: Camila <hello@camila.codes>
Camila [Tue, 20 Sep 2022 18:50:12 +0000 (20:50 +0200)]
Fix two factor auth notification: 'Approve' link is a primary action.
Signed-off-by: Camila <hello@camila.codes>
Simon L [Tue, 27 Sep 2022 14:42:46 +0000 (16:42 +0200)]
Merge pull request #4968 from nextcloud/bugfix/bring-back-lnk-files
Bring back .lnk files on Windows and always treat them as non-virtual files.
alex-z [Wed, 21 Sep 2022 16:14:03 +0000 (19:14 +0300)]
Bring back .lnk files on Windows and always treat them as non-virtual files.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Tue, 27 Sep 2022 03:28:55 +0000 (03:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Mon, 26 Sep 2022 17:19:33 +0000 (19:19 +0200)]
Merge pull request #4933 from nextcloud/bugfix/sorted-activity-model
Claudio Cambra [Wed, 14 Sep 2022 00:26:38 +0000 (02:26 +0200)]
Remove sorting code in activitylistmodel as not needed with sortedactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Tue, 13 Sep 2022 23:03:56 +0000 (01:03 +0200)]
Add a sortedactivitylistmodel that automatically handles sorting of activities
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Mon, 26 Sep 2022 11:23:57 +0000 (13:23 +0200)]
Merge pull request #4970 from nextcloud/bugfix/file-name-clash
Improve handling of file name clashes
Claudio Cambra [Wed, 21 Sep 2022 17:15:35 +0000 (19:15 +0200)]
Clicking on file name clash activities now opens file in web UI were the clash can be resolved
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Wed, 21 Sep 2022 17:13:54 +0000 (19:13 +0200)]
Categorise file name clash sync file issues as separate FileNameClash enum treated as warning
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Claudio Cambra [Mon, 26 Sep 2022 09:54:37 +0000 (11:54 +0200)]
Merge pull request #4972 from nextcloud/bugfix/sanitised-window-qml
Ensure strings in main window QML are presented as plain text and not HTML
Claudio Cambra [Fri, 23 Sep 2022 13:18:13 +0000 (15:18 +0200)]
Ensure strings in main window QML are presented as plain text and not HTML
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Mon, 26 Sep 2022 04:34:04 +0000 (04:34 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 24 Sep 2022 04:31:54 +0000 (04:31 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 23 Sep 2022 04:27:53 +0000 (04:27 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Thu, 22 Sep 2022 11:01:34 +0000 (13:01 +0200)]
Merge pull request #4959 from nextcloud/feature/activity-list-placeholder
Add a placeholder item for empty activity list
Claudio Cambra [Tue, 20 Sep 2022 16:24:14 +0000 (18:24 +0200)]
Add a placeholder item for empty activity list
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Nextcloud bot [Thu, 22 Sep 2022 04:31:12 +0000 (04:31 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Camila [Wed, 21 Sep 2022 12:54:13 +0000 (14:54 +0200)]
Merge pull request #4961 from nextcloud/bugfix/two-factor-notification-links
Fix two factor auth notification: activity item was disabled.
Camila [Tue, 20 Sep 2022 16:53:55 +0000 (18:53 +0200)]
Fix two factor auth notification: activity item was disabled.
User couldn't click on the links.
Signed-off-by: Camila <hello@camila.codes>
Nextcloud bot [Tue, 20 Sep 2022 04:30:04 +0000 (04:30 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 19 Sep 2022 04:28:54 +0000 (04:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 18 Sep 2022 04:21:43 +0000 (04:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Sat, 17 Sep 2022 21:55:35 +0000 (23:55 +0200)]
Merge pull request #4944 from nextcloud/bugfix/html-enabled-text-qml
Claudio Cambra [Thu, 15 Sep 2022 12:56:02 +0000 (14:56 +0200)]
Do not format text in QML components as HTML
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Matthieu Gallien [Sat, 17 Sep 2022 12:02:53 +0000 (14:02 +0200)]
Merge pull request #4819 from nextcloud/feature/syncjournaldb-handle-errors
Feature/syncjournaldb handle errors
allexzander [Fri, 5 Aug 2022 10:07:55 +0000 (13:07 +0300)]
Revert "Remove behavior changes."
This reverts commit
84d06ce9906df7bb6d87bf7093dd11fac6a6057a.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Fri, 5 Aug 2022 09:23:07 +0000 (12:23 +0300)]
Remove behavior changes.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Fri, 5 Aug 2022 08:31:26 +0000 (11:31 +0300)]
Fix regression in the PropagateDirectory::slotSubJobsFinished.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Thu, 4 Aug 2022 16:17:34 +0000 (19:17 +0300)]
Fix deprecation warnings.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Thu, 4 Aug 2022 14:51:26 +0000 (17:51 +0300)]
Do not ignore return values for SyncJournalDB in unit tests.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Thu, 4 Aug 2022 14:29:02 +0000 (17:29 +0300)]
Do not ignore return values for SyncJournalDB in accountsettings folderstatusmodel activitylistmodel abstractpropagateremotedeleteyncrypted lockgilejobs and propagator jobs
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Thu, 4 Aug 2022 14:13:59 +0000 (17:13 +0300)]
Do not ignore return values for SyncJournalDB in folder, encryptfolderjob, hydrationjob, and vfs_suffix.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Thu, 4 Aug 2022 13:47:39 +0000 (16:47 +0300)]
Do not ignore return values for SyncJournalDB calls in propagator jobs and discovery.
Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander [Thu, 4 Aug 2022 13:22:35 +0000 (16:22 +0300)]
Fix unit tests.
Signed-off-by: allexzander <blackslayer4@gmail.com>
alex-z [Thu, 4 Aug 2022 11:25:57 +0000 (14:25 +0300)]
Do not ignore return value of SyncJournalDB in propagator jobs
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Thu, 4 Aug 2022 11:13:26 +0000 (14:13 +0300)]
Do not ignore return value of SyncJournalDB in socket API.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Thu, 4 Aug 2022 11:10:06 +0000 (14:10 +0300)]
Do not ignore return value of SyncJournalDB in syncengine.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 3 Aug 2022 13:36:12 +0000 (16:36 +0300)]
Do not ignore return value of getFileRecordsByFileId.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 3 Aug 2022 13:25:19 +0000 (16:25 +0300)]
Added 'nodiscard' attribute to some of SyncJournalDb methods.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 3 Aug 2022 13:13:28 +0000 (16:13 +0300)]
Set CXX Standard 17.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 3 Aug 2022 12:35:13 +0000 (15:35 +0300)]
Check return values for SqlQuery.exec().
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Sat, 17 Sep 2022 04:28:02 +0000 (04:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 16 Sep 2022 04:21:49 +0000 (04:21 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Thu, 15 Sep 2022 08:36:03 +0000 (10:36 +0200)]
Merge pull request #4940 from nextcloud/bugfix/debug-conflict
Ensure that the file being processed has had its etag properly sanitised, log etag more
Claudio Cambra [Wed, 14 Sep 2022 10:56:59 +0000 (12:56 +0200)]
Ensure that the file being processed has had its etag properly sanitised, log etag more
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
projects / nextcloud-desktop.git / log