Jenkins for ownCloud [Sun, 25 Dec 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 24 Dec 2016 01:18:26 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 23 Dec 2016 01:18:34 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 22 Dec 2016 01:18:30 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Christian Kamm [Wed, 21 Dec 2016 14:04:37 +0000 (15:04 +0100)]
Wizard: Detach saved account from wizard
Fixes #5408 #5407.
The problem was that cleanup of the credentials page set the
credentials of the account back to dummy, thereby overriding
things like shib usernames.
This should be broken since
a932eac832b442cca763197240f036905dd284da.
Piotr Mrówczyński [Wed, 21 Dec 2016 14:08:45 +0000 (15:08 +0100)]
Add capability to disable parallel chunked upload #5364 - technical review (#5403)
Kyle Fazzari [Wed, 21 Dec 2016 13:14:26 +0000 (05:14 -0800)]
Correctly handle possible missing GIT_SHA1. (#5401)
Currently, if get_git_head_revision() doesn't define GIT_SHA1 (which it
doesn't in some cases) it's possible to end up with the following error:
CMake Error at CMakeLists.txt:69 (if):
if given arguments:
"STREQUAL" "GITDIR-NOTFOUND"
Unknown arguments specified
Fix this by making sure both left and right hand arguments to STREQUAL
are always strings, even if GIT_SHA1 is undefined.
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Christian Kamm [Tue, 20 Dec 2016 12:23:58 +0000 (13:23 +0100)]
Increase initial bandwidth estimates #4428 #5390
To 2 MB/s and 10 files/s.
Jenkins for ownCloud [Wed, 21 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Phil Davis [Tue, 20 Dec 2016 16:32:05 +0000 (22:17 +0545)]
Fix Mac PATH command
Reported in the doc repo owncloud/documentation#1618
This version as suggested by @jturcotte
Christian Kamm [Tue, 20 Dec 2016 10:43:39 +0000 (11:43 +0100)]
Move qDeclareMetatype from Folder to SyncEngine
Christian Kamm [Tue, 13 Dec 2016 12:56:36 +0000 (13:56 +0100)]
Don't wipe db if check fails while disk space is low #5357
An experimental fix for the issue, merged because it's low risk and
makes testing easier.
Jenkins for ownCloud [Tue, 20 Dec 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 19 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 18 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 17 Dec 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 16 Dec 2016 01:18:29 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 15 Dec 2016 01:18:37 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 29 Nov 2016 16:17:06 +0000 (17:17 +0100)]
FolderStatusModel: Fix insert/remove items when there are labels
Otherwise it might happen that the model is inconsistant and this can
lead to crash in the worst case.
(For example, if there was a "fetching" label, and we hide it because it
was a 404. In this case, we would not call begin/endRemoveRows, so the
view could still call the model with an index of row 0, that used to be
for the label, but now correspond to the first element of _subs. And
because _subs is empty, this could lead to crashes)
Olivier Goffart [Tue, 29 Nov 2016 15:20:19 +0000 (16:20 +0100)]
Propagator: make sure every network job has a parent
This could make sure that the network job gets deleted if the parent job gets
deleted, and would avoid crashes like:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0xffffffff8b008a04
File "qiodevice.cpp", line 1617, in QIODevice::errorString
File "propagatedownload.cpp", line 264, in OCC::GETFileJob::slotReadyRead
File "moc_propagatedownload.cpp", line 85, in OCC::GETFileJob::qt_static_metacall
File "qobject.cpp", line 3716, in QMetaObject::activate
File "moc_qiodevice.cpp", line 154, in QIODevice::readyRead
File "qnetworkreplyhttpimpl.cpp", line 1045, in QNetworkReplyHttpImplPrivate::replyDownloadData
(#5329)
Olivier Goffart [Tue, 29 Nov 2016 10:14:11 +0000 (11:14 +0100)]
Account::slotHandleSslErrors: add guards in case the reply gets deleted in the dialog event loop
Since slotHandleSslErrors will show a dialog with an eventloop, it could be
That the reply gets deleted. Guard against that.
(#5329)
Christian Kamm [Tue, 13 Dec 2016 14:28:52 +0000 (15:28 +0100)]
Sync now: Disable on disconnect, rename while running #2158
Jonathan Kawohl [Tue, 13 Dec 2016 08:12:50 +0000 (09:12 +0100)]
fixed merge conflicts
Jenkins for ownCloud [Tue, 13 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 12 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 11 Dec 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 10 Dec 2016 01:18:32 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Thu, 8 Dec 2016 16:30:41 +0000 (17:30 +0100)]
Fix the log window not showing csync logs
The csync log level was only set up on startup, and for log files.
Fix the issue by making Logger::isNoop rely on being explicitly activated
for the log window instead of relying on the presence of a connected
signal, and move the csync log level logic in Logger.
Jocelyn Turcotte [Thu, 8 Dec 2016 14:56:26 +0000 (15:56 +0100)]
Fix the sync direction being wrong on MSVC
The compiler seems to use signed enums and we need to reserve an extra
bit for the sign to avoid the 2 value to overflow and being interpreted
as -2 when read, and thus not being correctly compared to the full enum
value.
Jenkins for ownCloud [Fri, 9 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 8 Dec 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Tue, 6 Dec 2016 13:55:49 +0000 (14:55 +0100)]
Don't try to deploy the mng image format plugin on macOS
Qt now only build it if the system library is available since libmng
isn't active enough to make its security reliable enough. We don't
use that image format ourselves anyway.
Jocelyn Turcotte [Tue, 6 Dec 2016 13:54:05 +0000 (14:54 +0100)]
Rebase Qt patches on 5.6 #3449
Also get rid of the list of different version. We always only support one Qt version
for macOS and Windows, and the list of patches will be based on that supported
version.
Jenkins for ownCloud [Wed, 7 Dec 2016 01:18:34 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
ckamm [Tue, 6 Dec 2016 09:55:58 +0000 (10:55 +0100)]
Merge pull request #5045 from owncloud/dbjournal_per_account
Allow a folder to be synced to several accounts. This changes the path of the sync journal file!
Jenkins for ownCloud [Tue, 6 Dec 2016 01:18:34 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Olivier Goffart [Mon, 5 Dec 2016 16:21:36 +0000 (17:21 +0100)]
libsync: Clear the upload info after several retries (#5345)
Issue #5344
Jenkins for ownCloud [Mon, 5 Dec 2016 01:18:32 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 4 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 3 Dec 2016 01:18:25 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Fri, 2 Dec 2016 01:18:35 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 1 Dec 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 30 Nov 2016 01:18:34 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Felix Tiede [Sun, 20 Nov 2016 15:54:41 +0000 (16:54 +0100)]
Generate .desktop file with OEM name directly.
Instead of renaming the .desktop file at install time it is now
generated with its OEM name during configure time.
Felix Tiede [Sat, 19 Nov 2016 09:48:06 +0000 (10:48 +0100)]
Fix file installation source path.
By default the file is copied from the source and not the build
directory which will fail with the configure-time built file.
Felix Tiede [Sat, 19 Nov 2016 08:33:49 +0000 (09:33 +0100)]
Extend OEM configurability to dolphin desktop file.
OEM configurability creates binaries with OEM names which the .desktop
file doesn't take into account and thus dolphin integration does not
work if OEM changes the binary's name(s).
These changes are now integrated into the .desktop file at compile time.
Olivier Goffart [Wed, 16 Nov 2016 08:30:29 +0000 (09:30 +0100)]
libsync: use the new webdav url if the server reports it
The rules to select the webdav url are now:
- If the server reports that the new chunking algorithm is working,
always use remote.php/dav/files/<username>
This capability can be overriden with an environment variable
- Otherwise, use the dav path provided by the theme, which defaults to
remote.php/webdav
This means that with the newer server, the branding can no longer override
the webdav URL. If there is still an usecase for the branding to do so, we
need to find another way to override it. But it is now more complicated to
configure as might need include the username and need different endpoint
depending on the operations (chunks or not)
Issue #4007
Christian Kamm [Tue, 29 Nov 2016 09:39:20 +0000 (10:39 +0100)]
FolderWizard: pass AccountPtr by const&
For review of #5045
Christian Kamm [Tue, 29 Nov 2016 09:38:47 +0000 (10:38 +0100)]
Fix compilation with Qt < 5.1
For review of #5045
Christian Kamm [Tue, 29 Nov 2016 08:56:45 +0000 (09:56 +0100)]
Ensure the 'Sync paused' state is used after pausing #5290
Jenkins for ownCloud [Tue, 29 Nov 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 28 Nov 2016 01:18:33 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Olivier Goffart [Fri, 25 Nov 2016 17:47:37 +0000 (18:47 +0100)]
owncloudcmd: Don't put the password in the URL
As the URL might be print on the logs.
Also don't change the scheme from http to owncloud.
This was required before when we were using neon through csync, but now that
we use QNAM for everything we don't need it. The credentials from the account
are used.
Jenkins for ownCloud [Sat, 26 Nov 2016 01:18:36 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Christian Kamm [Fri, 25 Nov 2016 13:23:56 +0000 (14:23 +0100)]
AccountSettings: Add a "Force sync now" context menu option
Christian Kamm [Fri, 25 Nov 2016 12:21:34 +0000 (13:21 +0100)]
Fix perl tests for sync journal db name
Jenkins for ownCloud [Fri, 25 Nov 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 24 Nov 2016 01:18:38 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Christian Kamm [Wed, 23 Nov 2016 16:08:17 +0000 (17:08 +0100)]
Account: Rename user() to davUser()
Avoids potential confusion with credentials->user()
Christian Kamm [Wed, 23 Nov 2016 09:40:17 +0000 (10:40 +0100)]
Bugfixes for sync journal name generation and usage
* Use 'user' value for journal name generation
* Save journal name in settings
* Make owncloudcmd choose the right db
Christian Kamm [Tue, 22 Nov 2016 15:12:28 +0000 (16:12 +0100)]
Don't wipe each journal on each start
Christian Kamm [Tue, 22 Nov 2016 14:30:12 +0000 (15:30 +0100)]
Split folders configuration locations for backwards compatibility
Christian Kamm [Tue, 22 Nov 2016 13:20:08 +0000 (14:20 +0100)]
Always migrate .csync_journal to ._sync_xxx
Christian Kamm [Tue, 22 Nov 2016 12:17:04 +0000 (13:17 +0100)]
Rename sync journal to ._sync_xxx.db.
The added underscore means that older clients will also ignore the
file.
Christian Kamm [Tue, 22 Nov 2016 12:09:56 +0000 (13:09 +0100)]
Merge branch 'master' into dbjournal_per_account
Markus Goetz [Wed, 23 Nov 2016 10:43:15 +0000 (11:43 +0100)]
Wizard: Show if server asks for client certificate #2799 #69 (#5261)
This also nicely displays the 'Untrusted domain' message of oC.
The link to add a trusted domain (via web browser) is clickable.
Markus Goetz [Wed, 23 Nov 2016 10:05:41 +0000 (11:05 +0100)]
Folder: Make folder only accessible by user #5282 (#5315)
Because on OS X the parent folder might not protect
against access.
Jonathan Kawohl [Wed, 23 Nov 2016 10:01:52 +0000 (11:01 +0100)]
Merge branch 'Kawohl-master'
fix conflict
Jonathan Kawohl [Wed, 23 Nov 2016 09:59:18 +0000 (10:59 +0100)]
Merge branch 'master' of https://github.com/owncloud/client into Kawohl-master
fix conflict
Jonathan Kawohl [Wed, 23 Nov 2016 09:56:29 +0000 (10:56 +0100)]
Merge branch 'master' of https://gthub.com/Kawohl/client into Kawohl-master
fix conflict
Jonathan Kawohl [Wed, 23 Nov 2016 08:17:33 +0000 (09:17 +0100)]
fixed note
Jonathan Kawohl [Wed, 23 Nov 2016 08:10:58 +0000 (09:10 +0100)]
fixed review https://github.com/owncloud/client/pull/5259#pullrequestreview-
9743725
Jenkins for ownCloud [Wed, 23 Nov 2016 01:18:37 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 22 Nov 2016 16:25:42 +0000 (17:25 +0100)]
Propagator: don't use dynamic_cast for QObject
qobject_cast is better. (no need to use RTTI when we have QMetaObject
Samuel [Tue, 22 Nov 2016 09:15:21 +0000 (10:15 +0100)]
Fixing a typo on a message
This refers to the message shown when copying the list of unsynced items on the activity tab
Christian Kamm [Tue, 22 Nov 2016 09:53:15 +0000 (10:53 +0100)]
FolderMan: Never schedule paused folders #5290
Previously the last folder in the queue was scheduled, regardless
of whether it was paused or not.
Jenkins for ownCloud [Tue, 22 Nov 2016 01:18:29 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jonathan Kawohl [Mon, 21 Nov 2016 12:53:59 +0000 (13:53 +0100)]
adjusted minimum version.
Olivier Goffart [Tue, 15 Nov 2016 17:47:04 +0000 (18:47 +0100)]
libsync: Don't store the remote URI in the csync or in the SyncEngine
We are going to change the webdav path depending on the capabilities.
But the SyncEngine and csync might have been created before the capabilities
are retrieved.
The main raison why we gave the path to the sync engine was to pass it to csync.
But the thing is that csync don't need anymore this url as everything is done by the
discovery classes in libsync that use the network jobs that use the account for the urls.
So csync do not need the remote URI.
shortenFilename in folderstatusmodel.cpp was useless because the string is the
_file of a SyncFileItem which is the relative file name, that name never
starts with owncloud://.
All the csync test creates the folder because csync use to check if the folder
exists. But we don't need to do that anymore
Jenkins for ownCloud [Mon, 21 Nov 2016 01:18:27 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 20 Nov 2016 01:18:28 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 19 Nov 2016 01:18:35 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Christian Kamm [Fri, 18 Nov 2016 15:19:36 +0000 (16:19 +0100)]
Enable clicking on 'not synced' items #5306
ckamm [Fri, 18 Nov 2016 14:14:47 +0000 (15:14 +0100)]
Merge pull request #5272 from owncloud/licensefix-pending
License: Adjust license of GPLv2 source files to GPLv2+
Christian Kamm [Fri, 18 Nov 2016 11:30:41 +0000 (12:30 +0100)]
Always send a progress message at the end of a sync #5290
Some listeners detect whether a sync is finished by checking
for isUpdatingEstimates and completedFiles >= totalFiles. But
if a sync didn't transfer any files we never sent signal
with these values. Now we do.
Christian Kamm [Fri, 18 Nov 2016 11:17:05 +0000 (12:17 +0100)]
Tray: Add a 'New account...' action if no account is configured #5307
Useful when left-clicking the tray icon isn't working for some reason.
Jenkins for ownCloud [Fri, 18 Nov 2016 01:18:35 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Thu, 17 Nov 2016 01:18:43 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Olivier Goffart [Wed, 16 Nov 2016 16:42:25 +0000 (17:42 +0100)]
Revert "Discovery: consider also the "shared by me" as shared"
This reverts pull request 5313 (commit
2d6e473a4044ea4cadd3cf1d043a447790b87222 and
2f3db04e87a4e3edff389389d46d1c7a5a3e0d03)
The problem is that this loads the server too much.
Markus Goetz [Wed, 16 Nov 2016 13:08:05 +0000 (14:08 +0100)]
Folder: Add comments after discussion about pre-selected selective sync
Markus Goetz [Tue, 15 Nov 2016 14:56:52 +0000 (15:56 +0100)]
Merge pull request #5102 from owncloud/chunking-ng
Chunking ng
Olivier Goffart [Tue, 15 Nov 2016 12:58:18 +0000 (13:58 +0100)]
Rename SyncFileStatus::sharedWithMe to shared
Last commit for issue #4788 made the meaning to be simply shared
(with the user or from the user)
Olivier Goffart [Mon, 14 Nov 2016 17:47:58 +0000 (18:47 +0100)]
Discovery: consider also the "shared by me" as shared
The "S" in the permission is only for the "Shared with me" files.
It is only used to show the shared status in the overlay icons.
But we also wish to show the shared status for files that are shared
"by" the users. We can find that out using the 'share-types' webdav
property. If set, then we are sharing the object.
We fake a 'S' in the permission as for our purpose, they mean the same.
Issue #4788
Olivier Goffart [Tue, 15 Nov 2016 10:39:40 +0000 (11:39 +0100)]
SyncEngineTestUtils: Do don't allocate a buffer for the whole file
As the file can be some hunreds of megabytes, allocating such big arrays may
cause problems.
Also make the timeout a bit bigger so the test can rununder valgrind.
Olivier Goffart [Tue, 15 Nov 2016 09:14:50 +0000 (10:14 +0100)]
FolderStatusDelegate: Fix compiler warning.
QStyleOptionProgressBarV2 is deprecated in Qt5.
Jenkins for ownCloud [Tue, 15 Nov 2016 01:18:36 +0000 (02:18 +0100)]
[tx-robot] updated from transifex
Olivier Goffart [Mon, 14 Nov 2016 11:43:10 +0000 (12:43 +0100)]
Merge pull request #5304 from owncloud/Kawohl-linktocentral
documnetation.
Olivier Goffart [Mon, 14 Nov 2016 11:35:18 +0000 (12:35 +0100)]
Merge pull request #5267 from payload/fix_4608
nautilus integration: "share" extension for syncing folders
Olivier Goffart [Mon, 14 Nov 2016 11:20:24 +0000 (12:20 +0100)]
Merge pull request #5266 from rmekarni/patch-1
Fix find_library FindCMocka.cmake
Tobias Haeussler [Sat, 29 Oct 2016 20:06:03 +0000 (22:06 +0200)]
Add manifest file on Windows to make the application UAC aware.