Timm Bäder [Sun, 24 Sep 2017 16:15:41 +0000 (18:15 +0200)]
emojichooser: Plug a memory leak
Andre Klapper [Sat, 23 Sep 2017 21:42:31 +0000 (23:42 +0200)]
Fix broken translations of 'calendar:' settings (ignored translator comments)
Arash Mousavi [Fri, 22 Sep 2017 19:24:21 +0000 (22:54 +0330)]
Update Persian translations
Daniel Boles [Wed, 20 Sep 2017 22:53:54 +0000 (23:53 +0100)]
ToolItem: Fix nullable annotation put on wrong arg
D’oh
Daniel Boles [Tue, 5 Sep 2017 14:44:00 +0000 (15:44 +0100)]
gdkseatdefault: Grab touch events where applicable
gdk_seat_default_grab() grabs POINTER_EVENTS if the capability is
GDK_SEAT_CAPABILITY_ALL_POINTING. But that enumerator is a union that
includes GDK_SEAT_CAPABILITY_TOUCH, but we never grabbed TOUCH_EVENTS,
an unused macro that was presumably created with this purpose in mind.
So, check which of the ALL_POINTING capabilities we have, and set the
right mask of POINTER_EVENTS and/or TOUCH_EVENTS as required.
As part of this, explicitly let TABLET_STYLUS take over pointer events,
as this is the intended behaviour and was the effective result before.
This should fix touch events being lost in migrating from Device.grab()
to Seat.grab(GDK_SEAT_CAPABILITY_ALL_POINTING), as found by Inkscape.
https://bugzilla.gnome.org/show_bug.cgi?id=781757
Daniel Boles [Wed, 20 Sep 2017 16:34:43 +0000 (17:34 +0100)]
Overlay: Document style classes added per position
Piotr Drąg [Tue, 19 Sep 2017 00:05:52 +0000 (02:05 +0200)]
Update Polish translation
Daniel Boles [Mon, 18 Sep 2017 23:05:09 +0000 (00:05 +0100)]
Window: Clarify documentation of set_application()
Clarify that ::destroy, not ::hide*, removes a window from its app, by
replacing the mention of open windows with the blurb on destruction from
:application, completing commit
7db4bee4b62bc9b6f20ba4e599e8d030314984fd
Also link to the equivalent gtk_application_(add|remove)_window() calls,
since Application.add_window() already links back to Window:application.
* unless you use gtkmm…
https://bugzilla.gnome.org/show_bug.cgi?id=639931
Daniel Boles [Mon, 18 Sep 2017 23:14:41 +0000 (00:14 +0100)]
PlacesSidebar: Avoid unused mem if !CLOUDPROVIDERS
The member GList *cloud_rows is only ever used if HAVE_CLOUDPROVIDERS is
defined, so don’t declare it if not.
Daniel Boles [Tue, 12 Sep 2017 21:15:27 +0000 (22:15 +0100)]
PlacesSidebar: Unref cloud_manager in dispose()
We ref the CloudProviders singleton in init() but did not unref it in
dispose(). Do so, using g_clear_object().
https://bugzilla.gnome.org/show_bug.cgi?id=787600
Daniel Boles [Tue, 12 Sep 2017 20:56:46 +0000 (21:56 +0100)]
SidebarRow: Unref CloudProvider on change/finalize
It was never unref()d, either when replacing the existing GObject in
set_property(), cleaning up in finalize(), or becoming a placeholder.
Fix by using g_set_object() and g_clear_object() to unref as needed.
This also drops the check that the newly set object is a valid cloud
provider account, as we don’t do the equivalent for any of the other
object-typed properties, and Carlos didn’t think this was important.
https://bugzilla.gnome.org/show_bug.cgi?id=787600
Anders Jonsson [Mon, 18 Sep 2017 11:14:19 +0000 (11:14 +0000)]
Update Swedish translation
Daniel Boles [Sat, 16 Sep 2017 16:02:24 +0000 (17:02 +0100)]
Adwaita: Fix color of focus outline on colorswatch
The focus outline disappeared as the colour of the swatch got close to
the normal focus outline colour, which is alpha(currentColor, 0.3).
Fix by making the outline an alpha’d version of the tick colour, but
more opaque than normal outlines. 0.6 seems good enough; feel free to
improve it, but at least this ensures the outline can’t vanish anymore.
HighContrast achieves this already because it applies the color property
to the main node, not the overlay. Doing that means the outline is fully
opaque, which is fine for HC obviously but was excessive for Adwaita.
https://bugzilla.gnome.org/show_bug.cgi?id=787757
Daniel Boles [Sat, 16 Sep 2017 14:46:50 +0000 (15:46 +0100)]
Adwaita: dark: Make colorswatch.light tick visible
It used $text_color unconditionally, but in :dark, text is white, so we
overlaid a white tick on any light colours, all the way to white itself.
Using these named colours doesn’t make practical or semantic sense.
Instead, use white/black over dark/light swatches, as in HC, so all
variant–swatch combos work. Light looks the same, & :dark works now.
For backdrop, use alpha 0.5, unlike 0.7 in HC, as that seemed excessive
& different from the current effect. 0.5 is almost identical to how
$backdrop_fg_colour is a 50% mix of $fg_color, & matches backdrop text.
https://bugzilla.gnome.org/show_bug.cgi?id=787531
Daniel Boles [Fri, 15 Sep 2017 17:24:24 +0000 (18:24 +0100)]
Expander: get_label() return is nullable
Also, use gchar to match the header.
Daniel Boles [Thu, 14 Sep 2017 20:19:33 +0000 (21:19 +0100)]
Expander: Annotate new()’s label arg as nullable
to match new_with_mnemonic()
Daniel Boles [Thu, 14 Sep 2017 20:19:12 +0000 (21:19 +0100)]
Expander: Replace (allow-none) with (nullable)
The former is deprecated in favour of the latter.
Daniel Boles [Thu, 14 Sep 2017 20:11:50 +0000 (21:11 +0100)]
Expander: Explain how to conditionally style arrow
Daniel Boles [Thu, 14 Sep 2017 18:22:31 +0000 (19:22 +0100)]
Spinner: Document how to select on animated in CSS
This is not particularly obvious, so it seems worth including.
Daniel Boles [Wed, 13 Sep 2017 13:47:40 +0000 (14:47 +0100)]
gtk-demo/theming: Don’t mislead about raised class
This class is not added by any widgets nor themed by Adwaita/HC.
However, it is presented here as if it does something. It doesn’t.
But we changed the 2 buttons with the .raised class to use symbolic
icons, unlike their ‘unraised’ counterparts, which is unnecessarily
confusing and might make people think .raised affects icons somehow.
So, make them use the same icons in all cases; that way, if .raised is
ever made to do anything, 6 years later, what it does will be clear.
https://bugzilla.gnome.org/show_bug.cgi?id=644248
Daniel Boles [Thu, 14 Sep 2017 17:24:25 +0000 (18:24 +0100)]
gtk-demo/Makefile: Really get deps of C GResource
The XML resides in $(srcdir), not $(builddir); it is not a built source.
Using the latter, changes to the referenced files did not cause rebuild.
Daniel Boles [Wed, 13 Sep 2017 13:37:38 +0000 (14:37 +0100)]
widget-factory: Usefully demo Frame shadow types
Instead of showing the 4 types except for GTK_SHADOW_NONE, which are all
treated identically and provide no way for themes to differentiate, just
keep 2 Frames, and make one of them GTK_SHADOW_NONE to demo a flat Frame
Daniel Boles [Wed, 13 Sep 2017 13:36:46 +0000 (14:36 +0100)]
Frame: Add missing fixed-width format to enums
Daniel Boles [Tue, 12 Sep 2017 21:48:58 +0000 (22:48 +0100)]
FlowBox: Explain how to avoid inflated min size
along the orthogonal orientation. It seems a FlowBox on its own can only
handle being shrunk along its main orientation. The orthogonal requests
a huge min size – reserving what it would need if the main orientation
got its min size, which would flow all children in 1 line orthogonally.
Adding it to a ScrolledWindow (any policy) enables free shrinking, so
size_allocate() can reflow how users in this situation probably expect.
https://bugzilla.gnome.org/show_bug.cgi?id=787021
Hiroyuki Ito [Mon, 11 Sep 2017 12:02:13 +0000 (12:02 +0000)]
ColorButton: Don’t destroy dialog @ ::delete-event
Without specifically connecting ::delete-event to something, the dialog
will be destroyed when it is closed, for example by pressing Esc. This
meant that when dismissing it this way, unlike by pressing Cancel, any
custom palette would be lost when the dialog was next opened, and so on.
Resolve this by making ::delete-event just do GTK_RESPONSE_CANCEL, so
closing the dialog has the same effect as clicking its Cancel button.
https://bugzilla.gnome.org/show_bug.cgi?id=787444
Philip Withnall [Mon, 11 Sep 2017 08:26:52 +0000 (09:26 +0100)]
gtknotebook: Simplify some if-conditions
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://bugzilla.gnome.org/show_bug.cgi?id=787303
Philip Withnall [Mon, 11 Sep 2017 08:23:17 +0000 (09:23 +0100)]
gtkmountoperation-x11: Do array length check before dereference
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://bugzilla.gnome.org/show_bug.cgi?id=787302
Efstathios Iosifidis [Tue, 12 Sep 2017 19:42:33 +0000 (19:42 +0000)]
Update Greek translation
Efstathios Iosifidis [Tue, 12 Sep 2017 19:40:44 +0000 (19:40 +0000)]
Update Greek translation
Stas Solovey [Tue, 12 Sep 2017 19:30:36 +0000 (19:30 +0000)]
Update Russian translation
Stas Solovey [Tue, 12 Sep 2017 19:15:22 +0000 (19:15 +0000)]
Update Russian translation
Cheng-Chia Tseng [Tue, 12 Sep 2017 17:24:00 +0000 (17:24 +0000)]
Update Chinese (Taiwan) translation
Cheng-Chia Tseng [Tue, 12 Sep 2017 17:07:41 +0000 (17:07 +0000)]
Update Chinese (Taiwan) translation
hanniedu [Tue, 12 Sep 2017 10:38:19 +0000 (12:38 +0200)]
Updated Dutch translation 3.22
Matthias Clasen [Mon, 11 Sep 2017 14:49:52 +0000 (10:49 -0400)]
3.22.21
Matthias Clasen [Mon, 11 Sep 2017 15:17:41 +0000 (11:17 -0400)]
Fix a corner-case for emoji input
As reported in https://github.com/ibus/ibus/issues/1944,
typing u201e while holding Ctrl+Shift used to give a „
when letting go of Ctrl+Shift. This broke when we introduced
Ctrl+Shift+e to start Emoji sequences. Fix this by only
looking for Ctrl+Shift+e if we are not already in a hex
sequence.
Daniel Mustieles [Mon, 11 Sep 2017 13:57:21 +0000 (13:57 +0000)]
Update Spanish translation
Ask Hjorth Larsen [Sun, 10 Sep 2017 16:16:33 +0000 (18:16 +0200)]
Updated Danish translation
Ask Hjorth Larsen [Sun, 10 Sep 2017 16:15:01 +0000 (18:15 +0200)]
Updated Danish translation
Muhammet Kara [Sun, 10 Sep 2017 15:09:31 +0000 (15:09 +0000)]
Update Turkish translation
Jordi Mas [Sun, 10 Sep 2017 06:22:12 +0000 (08:22 +0200)]
Fixes to Catalan translation
Inaki Larranaga Murgoitio [Sat, 9 Sep 2017 15:54:59 +0000 (17:54 +0200)]
Update Basque language
Inaki Larranaga Murgoitio [Sat, 9 Sep 2017 15:54:30 +0000 (17:54 +0200)]
Update Basque language
Matej Urbančič [Fri, 8 Sep 2017 09:02:10 +0000 (11:02 +0200)]
Updated Slovenian translation
gogo [Thu, 7 Sep 2017 18:35:09 +0000 (18:35 +0000)]
Update Croatian translation
Daniel Boles [Thu, 7 Sep 2017 13:53:59 +0000 (14:53 +0100)]
Entry: Fix leak of text in ensure_has_tooltip()
Thanks to Mohammed Sadiq for noticing this. I guess I got
Widget.get_tooltip_text() confused with Label.get_label().
https://bugzilla.gnome.org/show_bug.cgi?id=787410
Jiri Grönroos [Thu, 7 Sep 2017 08:41:41 +0000 (08:41 +0000)]
Update Finnish translation
Piotr Drąg [Wed, 6 Sep 2017 18:14:41 +0000 (20:14 +0200)]
Update Polish translation
Çağatay Yiğit Şahin [Wed, 6 Sep 2017 06:48:16 +0000 (06:48 +0000)]
Update Turkish translation
Mario Blättermann [Tue, 5 Sep 2017 17:48:13 +0000 (17:48 +0000)]
Update German translation
Marek Cernocky [Tue, 5 Sep 2017 14:37:09 +0000 (16:37 +0200)]
Updated Czech translation
Jakub Steiner [Wed, 23 Aug 2017 20:26:06 +0000 (22:26 +0200)]
adwaita: use generic sidebar icon style
https://bugzilla.gnome.org/show_bug.cgi?id=786613
Daniel Mustieles [Tue, 5 Sep 2017 10:36:15 +0000 (10:36 +0000)]
Update Spanish translation
Daniel Boles [Tue, 5 Sep 2017 00:38:35 +0000 (01:38 +0100)]
Adwaita: Leave fg color of hovered emoji alone
Only HighContrast has a clear problem, and this avoids some probably
unwanted changes of certain colours in the weird greyscale emoji I have
available to test here.
Daniel Boles [Mon, 4 Sep 2017 23:48:06 +0000 (00:48 +0100)]
themes: Use $selected_fg_color for :hovered emoji
This is much needed for HighContrast as otherwise emoji are invisible
(or nearly in Inverse). It also syncs up with hovered menu items, etc.
https://bugzilla.gnome.org/show_bug.cgi?id=787279
Daniel Boles [Mon, 4 Sep 2017 23:58:00 +0000 (00:58 +0100)]
HighContrast: Kill abominable headerbar vseparator
Commit
70b61973fc0214dab7771fd2b339103592e7358f fixed a syntax error and
unwittingly released this bizarre mutant.
https://bugzilla.gnome.org/show_bug.cgi?id=787280
Daniel Boles [Mon, 4 Sep 2017 22:41:53 +0000 (23:41 +0100)]
ComboBox: Don’t popdown if releasing on scrollbar
On button release, we were popping down if the event widget was anything
but priv->button. This broke scrolling by clicking a mouse button, i.e.
when releasing a click in the trough or finishing a drag of either bar.
That’s unexpected, inconvenient, and pointless. So, let’s stop doing it.
https://bugzilla.gnome.org/show_bug.cgi?id=738893
Anders Jonsson [Mon, 4 Sep 2017 22:16:39 +0000 (22:16 +0000)]
Update Swedish translation
Daniel Boles [Mon, 4 Sep 2017 18:56:47 +0000 (19:56 +0100)]
EmojiChooser: Ensure always have a selected button
We were only selecting a section’s button if the adjustment y coord was
within its heading, so scrolling slightly into it unchecked all buttons.
This also fixes how we could end up with the first 2 selected, somehow.
https://bugzilla.gnome.org/show_bug.cgi?id=787172
Daniel Boles [Sat, 2 Sep 2017 17:47:47 +0000 (18:47 +0100)]
EmojiChooser: Check the 1st button before 1st show
We scroll to the top in show() but only ever selected a button when the
adjustment changed, which doesn’t happen in init(). Check it manually.
https://bugzilla.gnome.org/show_bug.cgi?id=787172
Timm Bäder [Wed, 26 Apr 2017 09:37:58 +0000 (11:37 +0200)]
sidebarrow: Remove useless size group
Nice try, but size groups don't work with invisible widgets anyway.
Invisible widgets request 0×0.
[reapplying after accidental reintroduction in the cloudproviders patch;
see https://bugzilla.gnome.org/show_bug.cgi?id=786123#c39]
Matthias Clasen [Mon, 4 Sep 2017 17:02:58 +0000 (13:02 -0400)]
3.22.20
Baurzhan Muftakhidinov [Mon, 4 Sep 2017 15:48:15 +0000 (15:48 +0000)]
Update Kazakh translation
Matthias Clasen [Mon, 4 Sep 2017 15:29:19 +0000 (11:29 -0400)]
3.22.20
Julius Härtl [Fri, 1 Sep 2017 19:43:39 +0000 (21:43 +0200)]
gtkplacessidebar: adapt libcloudproviders api rename
https://bugzilla.gnome.org/show_bug.cgi?id=786123
Daniel Boles [Sat, 2 Sep 2017 16:41:59 +0000 (17:41 +0100)]
HighContrast: basic port of emoji CSS from Adwaita
This is better than nothing: without specific CSS, the Chooser was too
large, the emoji were too small, and the buttons were generally ugly.
https://bugzilla.gnome.org/show_bug.cgi?id=786956
Daniel Boles [Sat, 2 Sep 2017 15:54:47 +0000 (16:54 +0100)]
Adwaita: proper colours for inactive emoji buttons
Use opacity to differentiate unselected/hovered/selected buttons. It had
assumed bg < border < fg colours, which may be false, as in Adwaita:dark
This also means we do not need to special-case for the backdrop state.
https://bugzilla.gnome.org/show_bug.cgi?id=786956
Daniel Boles [Sat, 2 Sep 2017 15:56:14 +0000 (16:56 +0100)]
Adwaita: Make use of SASS syntax for emoji stuff
This makes the theme easier to maintain.
https://bugzilla.gnome.org/show_bug.cgi?id=786956
Matthias Clasen [Mon, 4 Sep 2017 13:56:24 +0000 (09:56 -0400)]
Updates
Milo Casagrande [Mon, 4 Sep 2017 11:43:05 +0000 (11:43 +0000)]
Update Italian translation
Aurimas Černius [Sun, 3 Sep 2017 20:37:27 +0000 (23:37 +0300)]
Updated Lithuanian translation
Balázs Úr [Sun, 3 Sep 2017 16:51:46 +0000 (16:51 +0000)]
Update Hungarian translation
Rūdolfs Mazurs [Sun, 3 Sep 2017 16:27:50 +0000 (19:27 +0300)]
Update Latvian translation
Daniel Boles [Sun, 3 Sep 2017 12:53:48 +0000 (13:53 +0100)]
Adwaita: Fix ineffective theming of switch slider
in a specific case, which was applying .slider as a class on the parent
switch, instead of correctly selecting on its child node named slider.
This makes the border on the outside of a switch in a selected listbox
row look better in the light variant. Since the code was never removed,
it was clearly meant to work, and making it work is a clear improvement.
Daniel Boles [Sun, 3 Sep 2017 12:32:14 +0000 (13:32 +0100)]
HighContrast: Fix outdated name for headerbar box
Daniel Boles [Sun, 3 Sep 2017 12:10:50 +0000 (13:10 +0100)]
Adwaita: Fix outdated name of selection-menu arrow
Daniel Boles [Sun, 3 Sep 2017 11:07:35 +0000 (12:07 +0100)]
docs: css-overview: Don’t recommend broken syntax
Using this produced warnings about the Pango syntax of <Family> <size>
being deprecated, and the size being invalid due to no unit specified.
Also, that multi-word font family presumably wouldn’t work as expected.
Timm Bäder [Mon, 3 Oct 2016 07:31:44 +0000 (09:31 +0200)]
testgtk: fix css
Daniel Boles [Sun, 3 Sep 2017 10:04:48 +0000 (11:04 +0100)]
Toolbar: Clarify set_show_arrow() a bit more
Daniel Boles [Sun, 3 Sep 2017 09:41:56 +0000 (10:41 +0100)]
Toolbar: Clarify how the arrow overflow menu works
The fact it affects the preferred size, and only works with ToolItems
that return a menu proxy item, was unclear unless deduced from other
sources, and this led to users thinking it was broken, for example:
https://stackoverflow.com/q/
44644642/
2757035
https://bugzilla.gnome.org/show_bug.cgi?id=787158
https://bugzilla.gnome.org/show_bug.cgi?id=787195
Daniel Boles [Sun, 3 Sep 2017 09:41:24 +0000 (10:41 +0100)]
ToolItem: Add see-also from proxy setter to signal
Daniel Boles [Sun, 3 Sep 2017 09:39:58 +0000 (10:39 +0100)]
ToolItem: Annotate menu proxy item as nullable
It can be NULL. ::create-menu-proxy gave an example of when a NULL proxy
menu item could be useful, but the accessors did not annotate it as such.
Rafael Fontenelle [Sat, 2 Sep 2017 20:51:14 +0000 (20:51 +0000)]
Update Brazilian Portuguese translation
Daniel Boles [Sat, 2 Sep 2017 15:11:06 +0000 (16:11 +0100)]
Revert "sk.po: Consistently translate “Insert”"
This reverts commit
d09bc2b108be1643f29bb5a917da06e2a22f975c.
As an English-speaker, I know nothing about complex grammar, and it’s
been brought to my attention that some languages might differ in the
translation of the same command depending on where it appears.
So, I’d better assume everyone else knows better than me. Apologies!
Daniel Boles [Sat, 2 Sep 2017 15:00:08 +0000 (16:00 +0100)]
Adwaita: Fix colour mixing of emoji section button
when hovered, by using %, since SASS does not handle decimal mixes.
Daniel Boles [Sat, 2 Sep 2017 10:56:44 +0000 (11:56 +0100)]
sk.po: Consistently translate “Insert”
The two occurrences disagreed on the translation, and my amateur
investigation indicates this one is correct.
Daniel Boles [Sat, 2 Sep 2017 10:52:45 +0000 (11:52 +0100)]
gl.po: Consistently translate/capitalise “Emoji”
GTK+ 3 and 4 disagreed on capitalisation and the translation of “Emoji”.
Use sentence case as elsewhere & the most common translation: emoticono.
Jordi Mas [Sat, 2 Sep 2017 14:21:10 +0000 (16:21 +0200)]
Update Catalan translation
Jordi Mas [Sat, 2 Sep 2017 14:20:07 +0000 (16:20 +0200)]
Update Catalan translation
Jordi Mas [Sat, 2 Sep 2017 14:16:12 +0000 (16:16 +0200)]
Update Catalan translation
Matthias Clasen [Sat, 2 Sep 2017 12:45:51 +0000 (08:45 -0400)]
emoji chooser: No emoji in the search entry
Recursion is fun, but better avoided in the ui.
https://bugzilla.gnome.org/show_bug.cgi?id=786960
Matthias Clasen [Sat, 2 Sep 2017 12:42:52 +0000 (08:42 -0400)]
entry: Consider input hints for Emoji support
Don't show "insert emoji" in the context menu if input
hints indicate that Emoji input is not useful.
Matthias Clasen [Sat, 2 Sep 2017 12:42:18 +0000 (08:42 -0400)]
Add input hints for Emoji input
Allow hinting input methods about whether Emoji support is
useful or not.
Fran Dieguez [Sat, 2 Sep 2017 10:07:51 +0000 (10:07 +0000)]
Update Galician translation
Dušan Kazik [Sat, 2 Sep 2017 08:06:18 +0000 (08:06 +0000)]
Update Slovak translation
Dušan Kazik [Sat, 2 Sep 2017 08:02:39 +0000 (08:02 +0000)]
Update Slovak translation
Andika Triwidada [Sat, 2 Sep 2017 00:58:14 +0000 (00:58 +0000)]
Update Indonesian translation
Matthias Clasen [Fri, 1 Sep 2017 23:51:17 +0000 (19:51 -0400)]
emoji chooser: Avoid a crash
The emoji chooser gets disposed already, because it is attached
to the toplevel as a popover. Doing it again when the object data
is cleared is leading to a crash.
https://bugzilla.gnome.org/show_bug.cgi?id=787103
Piotr Drąg [Fri, 1 Sep 2017 23:50:34 +0000 (01:50 +0200)]
Update Polish translation
Mohammed Sadiq [Wed, 30 Aug 2017 17:55:59 +0000 (23:25 +0530)]
emoji-chooser: fix subsequent scroll
Event handlers on scroll window should only be run once the widget
is shown.
https://bugzilla.gnome.org/show_bug.cgi?id=786964