Simon McVittie [Sat, 4 Nov 2017 14:05:06 +0000 (14:05 +0000)]
Merge ostree (2017.13-1) import into refs/heads/workingbranch
Simon McVittie [Sat, 4 Nov 2017 14:05:06 +0000 (14:05 +0000)]
ostree (2017.13-1) unstable; urgency=medium
* New upstream release
- d/patches: Drop all patches
- d/copyright: Update
- Update symbols file
* d/control: Require dh-exec 0.23~, for build-profile support.
Strictly speaking we might only need 0.15, but I'm not going to
test versions older than the jessie backport.
* Set Rules-Requires-Root to no
* Standards-Version: 4.1.1 (no changes required)
[dgit import unpatched ostree 2017.13-1]
Simon McVittie [Sat, 4 Nov 2017 14:05:06 +0000 (14:05 +0000)]
Import ostree_2017.13.orig.tar.xz
[dgit import orig ostree_2017.13.orig.tar.xz]
Simon McVittie [Sat, 4 Nov 2017 14:05:06 +0000 (14:05 +0000)]
Import ostree_2017.13-1.debian.tar.xz
[dgit import tarball ostree 2017.13-1 ostree_2017.13-1.debian.tar.xz]
Simon McVittie [Thu, 26 Oct 2017 23:19:45 +0000 (00:19 +0100)]
Merge ostree (2017.12-2) import into refs/heads/workingbranch
Colin Walters [Wed, 25 Oct 2017 17:13:17 +0000 (13:13 -0400)]
lib/repo: Fix loading commitstate with parent repos
This makes the code nicer too. Properly unit testing this though really wants
like a whole set of stuff around parent repos...but we do have coverage of the
non-parent path in the current pull tests.
Closes: https://github.com/ostreedev/ostree/issues/1306
Closes: #1308
Approved by: alexlarsson
Origin: upstream, 2017.13, commit:
90ebd48f6aaf45c47b48c44354359f973dcf22a8
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-repo-Fix-loading-commitstate-with-parent-repos.patch
Jonathan Lebon [Fri, 6 Oct 2017 21:26:41 +0000 (21:26 +0000)]
fdio: allow NULL for fstatat_allow_noent stbuf
Often, the caller doesn't actually care about the details of the stat
struct itself, but just whether the entry exists or not. It does work
to just pass `NULL` directly to glibc in a quick test, but given that
the argument is tagged as `__nonnull` and that the documentation does
not explicitly specify this is supported, let's do this safely.
Origin: upstream (submodule libglnx), 2017.13, commit:
5362f6bc3ff3e30f379e767b203d15c9e56d6f08
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name fdio-allow-NULL-for-fstatat_allow_noent-stbuf.patch
Dan Nicholson [Tue, 24 Oct 2017 19:27:17 +0000 (19:27 +0000)]
lib/repo: Properly handle NULL homedir when signing commit
Without this, ostree_repo_sign_commit throws a critical message when no
homedir is provided:
(ostree gpg-sign:5034): GLib-GIO-CRITICAL **: g_file_new_for_path: assertion 'path != NULL' failed
Closes: #1305
Approved by: cgwalters
Origin: upstream, 2017.13, commit:
63ce86d5977ebfbedd2cdfba1e4f6bd400a3a1b8
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-repo-Properly-handle-NULL-homedir-when-signing-commit.patch
Colin Walters [Fri, 13 Oct 2017 22:14:17 +0000 (18:14 -0400)]
tests: Add test-pull-bareuseronly
I was going to fix a bug in the static deltas code and I noticed
we were missing `pull-test.sh` coverage for bareuseronly.
Obviously fixing this requires duplicating some of the bits we have in
`basic-test.sh`; need to hoist that into `libtest.sh`. For now though let's get
the coverage.
Closes: #1270
Approved by: jlebon
Origin: upstream, 2017.13, commit:
95afe2848d65a8062f4a76adb1ab80b6bcc4d79e
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name tests-Add-test-pull-bareuseronly.patch
Colin Walters [Mon, 16 Oct 2017 19:29:38 +0000 (15:29 -0400)]
lib/sysroot: Fix error handling when mounting overlayfs fails
This isn't perfect, but at least we fix an error-overwrite error, and in
practice `ostree admin unlock` isn't wrapped by `rpm-ostree` yet, so spew to
stderr is OK.
Closes: https://github.com/ostreedev/ostree/issues/1273
Closes: #1279
Approved by: guyshapiro
Origin: upstream, 2017.13, commit:
464965e6b4897f9c6d4487ca10eb5bc60ad9a670
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-sysroot-Fix-error-handling-when-mounting-overlayfs-fa.patch
Simon McVittie [Mon, 16 Oct 2017 11:51:04 +0000 (12:51 +0100)]
Cope with xattr syscalls raising EOPNOTSUPP
ENOTSUP and EOPNOTSUPP are numerically equal on most Linux ports,
but inexplicably differ on PA-RISC (hppa) and possibly other
rare architectures.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Closes: #1275
Approved by: cgwalters
Applied-upstream: 2017.13, commit:
a4723dafed722008ed1ee3c952b7ff8e3d9b9a45
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name Cope-with-xattr-syscalls-raising-EOPNOTSUPP.patch
Simon McVittie [Thu, 26 Oct 2017 11:08:15 +0000 (12:08 +0100)]
lib/utils: Check for invalid UTF-8 in filenames
In case a filename contains invalid UTF-8 characters, libostree will
pass it to g_variant_builder_add() in create_tree_variant_from_hashes()
anyway, which leads to a critical warning from glib and an invalid
commit. This commit makes ostree print a useful error and exit instead.
Closes: #1271
Approved by: cgwalters
Origin: upstream, 2017.13, commit:
2a9c5efe1d10b79681b0ee638994ead375be6597
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-utils-Check-for-invalid-UTF-8-in-filenames.patch
Colin Walters [Thu, 12 Oct 2017 14:46:25 +0000 (10:46 -0400)]
lib/deltas: Check cancellable during processing
Let's react to `Ctrl-C` faster here. Noticed while I was doing an update on my
desktop and playing with cancellation.
Closes: #1266
Approved by: jlebon
Origin: upstream, 2017.13, commit:
a1986b1a8083ef4f840973f1c73d932a52e43644
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-deltas-Check-cancellable-during-processing.patch
Colin Walters [Wed, 11 Oct 2017 21:02:02 +0000 (17:02 -0400)]
lib/deploy: Use _exit() for FIFREEZE watchdog
This works around an (IMO) SpiderMonkey bug - it tries to
clean up in a shared library destructor, but doesn't install a
`pthread_atfork()` handler to unset its state.
Closes: https://github.com/ostreedev/ostree/issues/1262
Closes: #1264
Approved by: dbnicholson
Origin: upstream, 2017.13, commit:
8f6ec62bfb149ec8dfb6076228dd64e5df27a76b
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-deploy-Use-_exit-for-FIFREEZE-watchdog.patch
Dan Nicholson [Wed, 11 Oct 2017 14:03:10 +0000 (14:03 +0000)]
lib/deploy: Ignore FIFREEZE/FITHAW errors when already in state
If the filesystem is already frozen, FIFREEZE returns EBUSY, and if the
filesystem is already thawed, FITHAW returns EINVAL. It's very unlikely
these issues would arise on a real ostree system since the sysroot would
be locked during the freeze/thaw cycle.
However, when multiple fake sysroots are used during the test suite (run
as root), the tests could race to run the freeze/thaw cycle without
locking. Furthermore, there's no reason why an independent process might
be trying to freeze the filesystem while ostree was deploying. Ignore
but warn for these errors since there's not much ostree can do about it,
anyways.
Closes: #1260
Approved by: cgwalters
Origin: upstream, 2017.13, commit:
a5b7660c940a200adac1a7d217e4a1cd72719021
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-deploy-Ignore-FIFREEZE-FITHAW-errors-when-already-in-.patch
Colin Walters [Wed, 4 Oct 2017 14:24:21 +0000 (10:24 -0400)]
lib/sysroot: Fix pointer going out of scope in unlock code
Fixes Coverity CID #
1457317
Closes: #1249
Approved by: jlebon
Origin: upstream, 2017.13, commit:
351ffdb9778436b193ba9d2fbeebe2358e55004f
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-sysroot-Fix-pointer-going-out-of-scope-in-unlock-code.patch
Colin Walters [Wed, 4 Oct 2017 14:22:05 +0000 (10:22 -0400)]
lib/core: Init struct stat buffer
Regression from
d57410a7e62dcb89321807dcb2d91c85f9d26df7
Fixes Coverity CID #
1457316
Closes: #1249
Approved by: jlebon
Origin: upstream, 2017.13, commit:
e80efe0b0668a351361bb0a218a809434dd33d63
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-core-Init-struct-stat-buffer.patch
Philip Withnall [Tue, 3 Oct 2017 14:45:34 +0000 (15:45 +0100)]
lib/repo-commit: Import detached metadata even if hardlink exists
Spotted while reading through the code, it looks like the
copy_detached_metadata() call is accidentally omitted if a hardlink
already exists for the .commit object.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes: #1242
Approved by: cgwalters
Origin: upstream, 2017.13, commit:
86e072bdbe48a4f16efb05c00eb79114e5fdbf61
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-repo-commit-Import-detached-metadata-even-if-hardlink.patch
Colin Walters [Mon, 2 Oct 2017 15:24:05 +0000 (11:24 -0400)]
lib/pull: Fix regression with pull-local for nonexistent refs
I was reading the pull code for the last release, and spotted
a bug in commit
f923c2e1eaebe0c781f07d34ae1a03f94357bccd - in
the case where the ref doesn't exist, we don't set an error,
tripping an assertion in the main code.
The previous code wanted the ref to always exist, so just flip back the boolean
for "ignore noent". I moved the `g_strchomp()` just into the HTTP path - if a
local repo is corrupted in this way it's something to fix in that repo.
Closes: #1238
Approved by: pwithnall
Origin: upstream, 2017.13, commit:
b8c15ae859de7a353b99c98c6266ee626cd94e7e
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-pull-Fix-regression-with-pull-local-for-nonexistent-r.patch
Simon McVittie [Tue, 3 Oct 2017 20:30:36 +0000 (21:30 +0100)]
Add missing test-libglnx-shutil
Because we re-run autogen.sh, we'll regenerate Makefile-libglnx.am.inc
(which results in the version after this patch, including
test-libglnx-shutil, being present) and then try to build
test-libglnx-shutil; but its source code wasn't included in the upstream
tarball, because Makefile-libglnx.am.inc wasn't up to date at
"make dist" time.
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Topic dist
Gbp-Pq: Name Add-missing-test-libglnx-shutil.patch
Simon McVittie [Thu, 26 Oct 2017 23:19:45 +0000 (00:19 +0100)]
ostree (2017.12-2) unstable; urgency=medium
* Disable gtk-doc if we are not going to build libostree-doc,
in particular for architecture-specific builds. Note that it remains
in Build-Depends (not Build-Depends-Indep) because it is also needed
for gtkdocize during dh_autoreconf.
- In particular this might fix FTBFS on sparc64, where highlight(1)
fails.
* d/p/2017.13/lib-core-Init-struct-stat-buffer.patch,
d/p/2017.13/lib-sysroot-Fix-pointer-going-out-of-scope-in-unlock-code.patch,
d/p/2017.13/lib-deploy-Ignore-FIFREEZE-FITHAW-errors-when-already-in-.patch,
d/p/2017.13/lib-deploy-Use-_exit-for-FIFREEZE-watchdog.patch,
d/p/2017.13/lib-deltas-Check-cancellable-during-processing.patch,
d/p/2017.13/lib-utils-Check-for-invalid-UTF-8-in-filenames.patch,
d/p/2017.13/Cope-with-xattr-syscalls-raising-EOPNOTSUPP.patch,
d/p/2017.13/lib-sysroot-Fix-error-handling-when-mounting-overlayfs-fa.patch,
d/p/2017.13/lib-repo-Properly-handle-NULL-homedir-when-signing-commit.patch,
d/p/2017.13/fdio-allow-NULL-for-fstatat_allow_noent-stbuf.patch,
d/p/2017.13/lib-repo-Fix-loading-commitstate-with-parent-repos.patch:
Add various bugfix patches from upstream
- In particular, dealing with the possibility that EOPNOTSUPP != ENOTSUP
should fix test failures on hppa.
* d/p/2017.13/tests-Add-test-pull-bareuseronly.patch:
Add more test coverage from upstream
- d/rules: Make the new test executable
* d/test.sh: Clean up ostree-trivial-httpd processes
* d/test.sh: Don't repeat build-time tests if they fail once. They seem
to be somewhat reliable now.
[dgit import unpatched ostree 2017.12-2]
Simon McVittie [Thu, 26 Oct 2017 23:19:45 +0000 (00:19 +0100)]
Import ostree_2017.12-2.debian.tar.xz
[dgit import tarball ostree 2017.12-2 ostree_2017.12-2.debian.tar.xz]
Simon McVittie [Tue, 3 Oct 2017 21:47:48 +0000 (22:47 +0100)]
Merge ostree (2017.12-1) import into refs/heads/workingbranch
Simon McVittie [Tue, 3 Oct 2017 21:47:48 +0000 (22:47 +0100)]
Import ostree_2017.12.orig.tar.xz
[dgit import orig ostree_2017.12.orig.tar.xz]
Simon McVittie [Tue, 3 Oct 2017 20:30:36 +0000 (21:30 +0100)]
Add missing test-libglnx-shutil
Because we re-run autogen.sh, we'll regenerate Makefile-libglnx.am.inc
(which results in the version after this patch, including
test-libglnx-shutil, being present) and then try to build
test-libglnx-shutil; but its source code wasn't included in the upstream
tarball, because Makefile-libglnx.am.inc wasn't up to date at
"make dist" time.
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Topic dist
Gbp-Pq: Name Add-missing-test-libglnx-shutil.patch
Philip Withnall [Tue, 3 Oct 2017 14:45:34 +0000 (15:45 +0100)]
lib/repo-commit: Import detached metadata even if hardlink exists
Spotted while reading through the code, it looks like the
copy_detached_metadata() call is accidentally omitted if a hardlink
already exists for the .commit object.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes: #1242
Approved by: cgwalters
Origin: upstream, 2017.13, commit:
86e072bdbe48a4f16efb05c00eb79114e5fdbf61
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-repo-commit-Import-detached-metadata-even-if-hardlink.patch
Colin Walters [Mon, 2 Oct 2017 15:24:05 +0000 (11:24 -0400)]
lib/pull: Fix regression with pull-local for nonexistent refs
I was reading the pull code for the last release, and spotted
a bug in commit
f923c2e1eaebe0c781f07d34ae1a03f94357bccd - in
the case where the ref doesn't exist, we don't set an error,
tripping an assertion in the main code.
The previous code wanted the ref to always exist, so just flip back the boolean
for "ignore noent". I moved the `g_strchomp()` just into the HTTP path - if a
local repo is corrupted in this way it's something to fix in that repo.
Closes: #1238
Approved by: pwithnall
Origin: upstream, 2017.13, commit:
b8c15ae859de7a353b99c98c6266ee626cd94e7e
Gbp-Pq: Topic 2017.13
Gbp-Pq: Name lib-pull-Fix-regression-with-pull-local-for-nonexistent-r.patch
Simon McVittie [Tue, 3 Oct 2017 21:47:48 +0000 (22:47 +0100)]
ostree (2017.12-1) unstable; urgency=medium
* New upstream release
- Drop all current patches, applied upstream
- Update symbols file
* Add some post-release bug fix patches
* Simplify autopkgtest now that test-local-pull seems to be stable
* Unexport HTTP proxy variables in autopkgtest to work around lack of
support for no_proxy, which breaks the tests on Ubuntu autopkgtest.
We don't actually need Internet access, so this is OK.
* debian/test.sh: Unexport HTTP proxy variables for build-time tests
too
* Make build-time test failures fatal if they fail at least twice
out of 5 tries (previously they had to fail at least 3 times)
* Add patch to reinstate test-libglnx-shutil.c, which was missed out
of the upstream tarball
[dgit import unpatched ostree 2017.12-1]
Simon McVittie [Tue, 3 Oct 2017 21:47:48 +0000 (22:47 +0100)]
Import ostree_2017.12-1.debian.tar.xz
[dgit import tarball ostree 2017.12-1 ostree_2017.12-1.debian.tar.xz]
Simon McVittie [Fri, 22 Sep 2017 14:48:24 +0000 (15:48 +0100)]
Merge ostree (2017.11-2) import into refs/heads/workingbranch
Jonathan Lebon [Wed, 20 Sep 2017 18:38:16 +0000 (18:38 +0000)]
rofiles-fuse: also pass mode for O_RDONLY
In the `O_RDONLY` case, we were calling `openat` without a mode
argument. However, it's perfectly legal (albeit unusual) to do
`open(O_RDONLY|O_CREAT)`. One such application that makes use of this is
`flock(1)`.
This was actually caught by `_FORTIFY_SOURCE=2`, and once we run
`rofiles-fuse` with `-f`, the message is clear:
```
*** invalid openat64 call: O_CREAT or O_TMPFILE without mode ***:
rofiles-fuse terminated
======= Backtrace: =========
/lib64/libc.so.6(+0x7c8dc)[0x7f36d9f188dc]
/lib64/libc.so.6(__fortify_fail+0x37)[0x7f36d9fbfaa7]
/lib64/libc.so.6(+0x10019a)[0x7f36d9f9c19a]
rofiles-fuse[0x401768]
...
```
Without `_FORTIFY_SOURCE`, the file gets created, but its mode is
completely random.
I ran into this while investigating
https://github.com/projectatomic/rpm-ostree/pull/1003.
Closes: #1200
Approved by: cgwalters
Origin: upstream, 2017.12, commit:
d4c7093e370843c57eab2f89f0c39ef449e6b32e
Gbp-Pq: Topic 2017.12
Gbp-Pq: Name rofiles-fuse-also-pass-mode-for-O_RDONLY.patch
Simon McVittie [Tue, 19 Sep 2017 17:37:58 +0000 (18:37 +0100)]
tests: Reset umask to 022 while creating test repository
In test-basic-root.sh we make assertions about the permissions
of files like baz/cow, which were created without an explicit chmod.
We can't do that unless we control the permissions.
For some reason the "debomatic" autobuilder used to do some Debian
archive rebuilds does the entire build including build-time tests
as uid 0 with umask 002, which broke those assertions. This seems
a weird thing to do, and I've opened a bug, but it also seems
reasonable to fix this test.
This also lets us remove a couple of existing workarounds for the
same issue.
Bug-Debian: https://bugs.debian.org/876138
Signed-off-by: Simon McVittie <smcv@collabora.com>
Closes: #1192
Approved by: cgwalters
Forwarded: https://github.com/ostreedev/ostree/pull/1192
Applied-upstream: 2017.12, commit:
e3c3ec5dd91492e82c79223052443d038c60f41c
Gbp-Pq: Topic 2017.12
Gbp-Pq: Name tests-Reset-umask-to-022-while-creating-test-repository.patch
Simon McVittie [Tue, 19 Sep 2017 13:41:18 +0000 (14:41 +0100)]
tests: Explicitly unset LANGUAGE after setting LC_ALL
As a GNU extension, LANGUAGE takes precedence over LC_ALL for
gettext(3) whenever the locale is not C, causing tests that grep for
specific English strings to fail when run in non-English locales.
The upstream glibc proposal for C.UTF-8 would give C.UTF-8 the same
special case as C here, but the implementation in Debian does not
currently have this, so we have to unset LANGUAGE too.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Forwarded: https://github.com/ostreedev/ostree/pull/1188
Applied-upstream: 2017.12, commit:
223c940b46a4bb335665df7436566b73cdf0effd
Gbp-Pq: Topic 2017.12
Gbp-Pq: Name tests-Explicitly-unset-LANGUAGE-after-setting-LC_ALL.patch
Simon McVittie [Fri, 15 Sep 2017 14:32:55 +0000 (15:32 +0100)]
tests: Fix JavaScript tests with gjs 1.50.0
In recent gjs, you can't declare a variable with "let" multiple times.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Closes: #1178
Approved by: cgwalters
Forwarded: https://github.com/ostreedev/ostree/pull/1178
Applied-upstream: 2017.12, commit:
1b430a776486d68be2d16a0ec53ad5512c604988
Gbp-Pq: Topic 2017.12
Gbp-Pq: Name tests-Fix-JavaScript-tests-with-gjs-1.50.0.patch
Simon McVittie [Fri, 22 Sep 2017 14:48:24 +0000 (15:48 +0100)]
ostree (2017.11-2) unstable; urgency=medium
* Replace patch with the version applied upstream in 2017.12
* Standards-Version: 4.1.0 (no changes)
* Add a patch to fix FTBFS in non-English locales
* Add a patch to fix FTBFS if building as root with umask != 022,
which for some reason debomatic does (Closes: #876138)
* Add a patch from upstream to fix undefined behaviour with
O_RDONLY|O_CREAT in rofiles-fuse
[dgit import unpatched ostree 2017.11-2]
Simon McVittie [Fri, 22 Sep 2017 14:48:24 +0000 (15:48 +0100)]
Import ostree_2017.11-2.debian.tar.xz
[dgit import tarball ostree 2017.11-2 ostree_2017.11-2.debian.tar.xz]
Simon McVittie [Fri, 15 Sep 2017 15:58:15 +0000 (16:58 +0100)]
Merge ostree (2017.11-1) import into refs/heads/workingbranch
Simon McVittie [Fri, 15 Sep 2017 15:58:15 +0000 (16:58 +0100)]
Import ostree_2017.11.orig.tar.xz
[dgit import orig ostree_2017.11.orig.tar.xz]
Simon McVittie [Fri, 15 Sep 2017 14:32:55 +0000 (15:32 +0100)]
Fix JavaScript tests with gjs 1.50.0
In recent gjs, you can't declare a variable with "let" multiple times.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Gbp-Pq: Name Fix-JavaScript-tests-with-gjs-1.50.0.patch
Simon McVittie [Fri, 15 Sep 2017 15:58:15 +0000 (16:58 +0100)]
ostree (2017.11-1) unstable; urgency=medium
* New upstream release
- Drop all current patches, applied upstream
- Update symbols file
* Adjust Description and Upstream-Name to emphasize libostree
* Classify new ostree-tmpfiles.conf as part of ostree-boot, and so
don't install it yet
* Stop copying an old ostree-trivial-httpd.xml from debian/dist/
into source tree. Upstream distributes it again, and has since
2017.8.
* Add a patch to fix JavaScript tests with gjs 1.50.0, which is
more strict about 'let'
* Stop providing "ostree trivial-httpd" CLI, following upstream
default behaviour. flatpak used to use it in its tests, but
the version in stable no longer does.
[dgit import unpatched ostree 2017.11-1]
Simon McVittie [Fri, 15 Sep 2017 15:58:15 +0000 (16:58 +0100)]
Import ostree_2017.11-1.debian.tar.xz
[dgit import tarball ostree 2017.11-1 ostree_2017.11-1.debian.tar.xz]
Simon McVittie [Tue, 29 Aug 2017 17:18:49 +0000 (18:18 +0100)]
Merge ostree (2017.10-1) import into refs/heads/workingbranch
Simon McVittie [Tue, 29 Aug 2017 16:05:16 +0000 (17:05 +0100)]
Remove shebang from bash completions
bash completions are to be sourced. It makes little sense to
execute them.
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name Remove-shebang-from-bash-completions.patch
Simon McVittie [Tue, 29 Aug 2017 16:03:37 +0000 (17:03 +0100)]
test-basic-user-only: Skip final step if no user xattrs
We don't want to skip the entire test, because the whole point of
bare-user-only is that it works in the absence of xattrs; but we do
need to skip this last stage, which explicitly uses a bare-user
repository.
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name test-basic-user-only-Skip-final-step-if-no-user-xattrs.patch
Simon McVittie [Tue, 29 Aug 2017 16:02:43 +0000 (17:02 +0100)]
basic-test: Skip explicit uses of bare-user if no user xattrs
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name basic-test-Skip-explicit-uses-of-bare-user-if-no-user-xat.patch
Simon McVittie [Tue, 29 Aug 2017 16:02:18 +0000 (17:02 +0100)]
libtest: Allow skipping single checks without user xattrs
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name libtest-Allow-skipping-single-checks-without-user-xattrs.patch
Simon McVittie [Tue, 29 Aug 2017 16:01:41 +0000 (17:01 +0100)]
test-pull-bareuser.sh: This test uses bare-user, hence needs xattrs
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name test-pull-bareuser.sh-This-test-uses-bare-user-hence-need.patch
Simon McVittie [Tue, 29 Aug 2017 15:46:19 +0000 (16:46 +0100)]
test-libarchive-import: Skip if extended attributes are unsupported
This is the case at build-time on some (all?) Debian autobuilders.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Gbp-Pq: Name test-libarchive-import-Skip-if-extended-attributes-are-un.patch
Simon McVittie [Tue, 29 Aug 2017 17:18:49 +0000 (18:18 +0100)]
ostree (2017.10-1) unstable; urgency=medium
* New upstream release
- Update symbols file
- Install new bash completions
* Use dh_missing --fail-missing instead of dh_install --fail-missing
* Only run tests when building architecture-dependent packages.
The tests aren't so interesting that we want to run them again
when splitting -arch/-indep builds.
* Add patches to make the tests pass again when /var/tmp is on tmpfs,
which does not support user xattrs
* Add patch to remove useless #! from bash completions
* Make build-time test failures fatal again, but only if they are
reproducible (at least 3 times out of 5) for now
[dgit import unpatched ostree 2017.10-1]
Simon McVittie [Tue, 29 Aug 2017 17:18:49 +0000 (18:18 +0100)]
Import ostree_2017.10.orig.tar.xz
[dgit import orig ostree_2017.10.orig.tar.xz]
Simon McVittie [Tue, 29 Aug 2017 17:18:49 +0000 (18:18 +0100)]
Import ostree_2017.10-1.debian.tar.xz
[dgit import tarball ostree 2017.10-1 ostree_2017.10-1.debian.tar.xz]
Simon McVittie [Fri, 28 Jul 2017 13:43:30 +0000 (14:43 +0100)]
Merge ostree (2017.9-1) import into refs/heads/workingbranch
Simon McVittie [Fri, 28 Jul 2017 13:43:30 +0000 (14:43 +0100)]
ostree (2017.9-1) unstable; urgency=medium
* New upstream release
- Drop backported patch
- Update symbols file
* debian/rules: Adjust a comment to avoid Lintian thinking this is a
dh_make template
[dgit import unpatched ostree 2017.9-1]
Simon McVittie [Fri, 28 Jul 2017 13:43:30 +0000 (14:43 +0100)]
Import ostree_2017.9.orig.tar.xz
[dgit import orig ostree_2017.9.orig.tar.xz]
Simon McVittie [Fri, 28 Jul 2017 13:43:30 +0000 (14:43 +0100)]
Import ostree_2017.9-1.debian.tar.xz
[dgit import tarball ostree 2017.9-1 ostree_2017.9-1.debian.tar.xz]
Simon McVittie [Wed, 19 Jul 2017 21:18:20 +0000 (22:18 +0100)]
Merge ostree (2017.8-1) import into refs/heads/workingbranch
Colin Walters [Wed, 19 Jul 2017 13:19:16 +0000 (09:19 -0400)]
lib/commit: Fix EBADF with GENERATE_SIZES option for commit
Regression from previous tmpfile refactoring; unfortunately
the `OSTREE_REPO_COMMIT_MODIFIER_FLAGS_GENERATE_SIZES` option
only has coverage via gjs currently.
Might expose it via the cmdline in a later option, but in the big picture the
idea was that this data is better kept in static deltas.
Bug: https://github.com/ostreedev/ostree/issues/1014
Forwarded: https://github.com/ostreedev/ostree/pull/1016
Gbp-Pq: Name lib-commit-Fix-EBADF-with-GENERATE_SIZES-option-for-commi.patch
Simon McVittie [Wed, 19 Jul 2017 21:18:20 +0000 (22:18 +0100)]
ostree (2017.8-1) unstable; urgency=medium
* New upstream release
- Update symbols file
- Remove patches that are no longer needed
- Add patch from upstream PR #1016 to fix a regression
* Add a Breaks on flatpak (<< 0.8.7-2~), which rely on libostree to
download the summary and its signature when mirroring.
libostree >= 2017.7 no longer does this. On affected flatpak versions,
this breaks installation of new apps and runtimes system-wide.
* Add Build-Depends-Indep: libglib2.0-doc so gtk-doc can set up
cross-references
[dgit import unpatched ostree 2017.8-1]
Simon McVittie [Wed, 19 Jul 2017 21:18:20 +0000 (22:18 +0100)]
Import ostree_2017.8.orig.tar.xz
[dgit import orig ostree_2017.8.orig.tar.xz]
Simon McVittie [Wed, 19 Jul 2017 21:18:20 +0000 (22:18 +0100)]
Import ostree_2017.8-1.debian.tar.xz
[dgit import tarball ostree 2017.8-1 ostree_2017.8-1.debian.tar.xz]
Simon McVittie [Wed, 21 Jun 2017 12:06:54 +0000 (13:06 +0100)]
Merge ostree (2017.7-1) import into refs/heads/workingbranch
Philip Withnall [Tue, 20 Jun 2017 16:38:15 +0000 (17:38 +0100)]
build: Add ‘devel’ or ‘release’ to OSTREE_FEATURES for test-symbols.sh
test-symbols.sh was looking for the DevelBuild string, which is actually
part of the output from `ostree --version`, not $OSTREE_FEATURES.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes: #948
Approved by: cgwalters
Origin: upstream, 2017.8, commit:
fd50c9732231895b18cd8158726e7f77bc8dcae6
Gbp-Pq: Name build-Add-devel-or-release-to-OSTREE_FEATURES-for-test-sy.patch
Colin Walters [Mon, 19 Jun 2017 15:23:45 +0000 (11:23 -0400)]
main: DevelBuild=yes to `ostree --version` for devel builds
And use it in `test-symbols.sh`, to fix the `distcheck` case;
the previous change stopped distributing `libostree-devel.sym`
in release builds.
Closes: #944
Approved by: jlebon
Origin: upstream, 2017.8, commit:
2a082b20b8da2ffecb4f2c0e179a961c0fd26bd0
Gbp-Pq: Name main-DevelBuild-yes-to-ostree-version-for-devel-builds.patch
Simon McVittie [Wed, 21 Jun 2017 12:06:54 +0000 (13:06 +0100)]
ostree (2017.7-1) unstable; urgency=medium
* New upstream release
- Update symbols file
- Add post-release patches so test-symbols.sh passes again
- debian/dist/: Add ostree-trivial-httpd.xml, which was incorrectly
excluded from the upstream release
* Standards-Version: 4.0.0
- Use https URL for copyright-format
* Implement <nodoc> build profile
* Upload to unstable
[dgit import unpatched ostree 2017.7-1]
Simon McVittie [Wed, 21 Jun 2017 12:06:54 +0000 (13:06 +0100)]
Import ostree_2017.7.orig.tar.xz
[dgit import orig ostree_2017.7.orig.tar.xz]
Simon McVittie [Wed, 21 Jun 2017 12:06:54 +0000 (13:06 +0100)]
Import ostree_2017.7-1.debian.tar.xz
[dgit import tarball ostree 2017.7-1 ostree_2017.7-1.debian.tar.xz]
Simon McVittie [Thu, 19 Jan 2017 13:23:32 +0000 (13:23 +0000)]
Merge ostree (2016.15-3) import into refs/heads/workingbranch
Simon McVittie [Thu, 19 Jan 2017 11:34:57 +0000 (11:34 +0000)]
Make corrupt-repo-ref.js executable
Debian's Lintian packaging consistency check complains that it isn't
executable but has a #! line. In fact it's reasonable to run this
script directly, so make it executable, and put it in a _scripts
variable so it will be installed executable.
Forwarded: https://github.com/ostreedev/ostree/pull/652
Gbp-Pq: Name Make-corrupt-repo-ref.js-executable.patch
Simon McVittie [Thu, 19 Jan 2017 11:23:30 +0000 (11:23 +0000)]
Sourced test snippets: remove shebang and make non-executable
They are installed non-executable, which makes Debian's Lintian
packaging consistency check complain that #! is only useful
in executable scripts. But in fact they are not useful to execute
directly (they rely on setup being done in the script that sources
them), so just chmod them -x.
Forwarded: https://github.com/ostreedev/ostree/pull/652
Gbp-Pq: Name Sourced-test-snippets-remove-shebang-and-make-non-executa.patch
Simon McVittie [Thu, 19 Jan 2017 11:21:58 +0000 (11:21 +0000)]
Fix TAP syntax in test-basic-user.sh, and run it
In its initial commit, Alexander Larsson wrote
This works standalone, but unfortunately it breaks in
gnome-desktop-testing-runner as /tmp doesn't support
xattrs, so it is not installed atm.
but we now (a) use /var/tmp, and (b) explicitly skip the test if
xattr support is unavailable. So it should be OK to run now.
Forwarded: https://github.com/ostreedev/ostree/pull/652
Gbp-Pq: Name Fix-TAP-syntax-in-test-basic-user.sh-and-run-it.patch
Simon McVittie [Thu, 19 Jan 2017 13:23:32 +0000 (13:23 +0000)]
ostree (2016.15-3) unstable; urgency=medium
* debian/control: Don't run gjs tests on sparc64. gjs doesn't seem
to work there at all (#827815)
- d/ostree-tests.lintian-overrides: silence
missing-dep-for-interpreter error on sparc64, where we install
the script but do not attempt to run it
* debian/tests/gnome-desktop-testing: Skip test-local-pull.sh.test
which suffers from a known bug (#842606)
* debian/tests/gnome-desktop-testing: Fail if no tests were found
- debian/tests/test-local-pull: Run the unreliable test separately,
repeated 3 times to assess how often it fails
* d/p/Sourced-test-snippets-remove-shebang-and-make-non-executa.patch,
d/p/Make-corrupt-repo-ref.js-executable.patch:
Fix permissions and #! lines for some tests in the upstream build
system
* d/rules: remove workarounds for script permissions.
The upstream build system now uses the intended permissions throughout.
- Retain explicit chmod for *.js, which dh_fixperms assumes should
not be executable.
* d/p/Fix-TAP-syntax-in-test-basic-user.sh-and-run-it.patch:
Run an additional test, which was previously installed but not run
[dgit import unpatched ostree 2016.15-3]
Simon McVittie [Thu, 19 Jan 2017 13:23:32 +0000 (13:23 +0000)]
Import ostree_2016.15-3.debian.tar.xz
[dgit import tarball ostree 2016.15-3 ostree_2016.15-3.debian.tar.xz]
Simon McVittie [Tue, 20 Dec 2016 11:28:41 +0000 (11:28 +0000)]
Merge ostree (2016.15-2) import into refs/heads/workingbranch
Raspbian Automatic git importer [Thu, 22 Dec 2016 08:07:02 +0000 (08:07 +0000)]
Merge ostree (2016.14-2) import into refs/heads/workingbranch
Raspbian Automatic git importer [Thu, 22 Dec 2016 08:07:03 +0000 (08:07 +0000)]
Merge ostree (2016.13-1) import into refs/heads/workingbranch
Raspbian Automatic git importer [Thu, 22 Dec 2016 08:07:03 +0000 (08:07 +0000)]
Merge ostree (2016.12-2) import into refs/heads/workingbranch
Raspbian Automatic git importer [Thu, 22 Dec 2016 08:07:01 +0000 (08:07 +0000)]
Merge ostree (2016.11-1) import into refs/heads/workingbranch
Simon McVittie [Tue, 20 Dec 2016 11:28:41 +0000 (11:28 +0000)]
ostree (2016.15-2) unstable; urgency=medium
* Make all test failures non-fatal at build time, so that intermittent
test failures do not interfere with possible security updates during
Debian stretch-as-stable.
[dgit import unpatched ostree 2016.15-2]
Simon McVittie [Tue, 20 Dec 2016 11:28:41 +0000 (11:28 +0000)]
Import ostree_2016.15-2.debian.tar.xz
[dgit import tarball ostree 2016.15-2 ostree_2016.15-2.debian.tar.xz]
Simon McVittie [Tue, 13 Dec 2016 13:13:44 +0000 (13:13 +0000)]
Import ostree_2016.15.orig.tar.xz
[dgit import orig ostree_2016.15.orig.tar.xz]
Simon McVittie [Thu, 1 Dec 2016 11:25:33 +0000 (11:25 +0000)]
Terminate individual tests after 10 minutes
While using the Automake parallel test harness, if a test hangs for
long enough for an external watchdog to kill the entire build process
(as happens in Debian sbuild after 150 minutes with no activity on
stdout/stderr), the logs will not be shown. If we make an individual
test time out sooner, logs are more likely to be shown.
We use SIGABRT so that the process(es) under test will dump core,
allowing the point at which ostree is blocking to be analyzed.
After 1 minute, if any have not died, we kill them again with SIGKILL.
Signed-off-by: Simon McVittie <smcv@debian.org>
Forwarded: https://github.com/ostreedev/ostree/pull/607
Gbp-Pq: Name Terminate-individual-tests-after-10-minutes.patch
Colin Walters [Tue, 29 Nov 2016 03:03:53 +0000 (22:03 -0500)]
tests: Fix leaks
Just for cleaner sanitizer output.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-tests-Fix-leaks.patch
Colin Walters [Tue, 29 Nov 2016 03:03:24 +0000 (22:03 -0500)]
set-origin: Squash a leak
Just a minor leak in the commandline.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-set-origin-Squash-a-leak.patch
Colin Walters [Tue, 29 Nov 2016 03:02:42 +0000 (22:02 -0500)]
bootconfig: Drop a pointless strdup in parser
Not entirely sure how this was leaking, but anyways it showed
up in ASAN, and it's pointless to strdup here.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-bootconfig-Drop-a-pointless-strdup-in-parser.patch
Colin Walters [Tue, 29 Nov 2016 03:01:33 +0000 (22:01 -0500)]
metalink: Fix leaks of buffer
We should be religious about the "only set output variables on
success", otherwise it makes leaks more likely.
But the real leak was us simply not using autoptr in one place.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-metalink-Fix-leaks-of-buffer.patch
Colin Walters [Tue, 29 Nov 2016 03:00:01 +0000 (22:00 -0500)]
sysroot: Fix leak/double free of keyfile origin
Use autoptr rather than manual cleanup. The double free isn't a
security problem, since we trust origin files.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-sysroot-Fix-leak-double-free-of-keyfile-origin.patch
Colin Walters [Tue, 29 Nov 2016 02:14:47 +0000 (21:14 -0500)]
traverse: Use g_hash_table_add
And "move semantics" via `g_steal_pointer()`. Just a minor code
cleanup I noticed when I was hunting for a leak, which ended up being
elsewhere.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name traverse-Use-g_hash_table_add.patch
Colin Walters [Tue, 29 Nov 2016 02:12:53 +0000 (21:12 -0500)]
cmdline: Fix minor leak in delta cmdline entrypoint
Small, but it's important to stay clean.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-cmdline-Fix-minor-leak-in-delta-cmdline-entrypoint.patch
Colin Walters [Tue, 29 Nov 2016 02:12:23 +0000 (21:12 -0500)]
deltas: Fix minor memory leak
We were leaking the checksum, ensure we free it in both normal and
error paths.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-deltas-Fix-minor-memory-leak.patch
Colin Walters [Tue, 29 Nov 2016 02:11:37 +0000 (21:11 -0500)]
delta compilation: More leak fixes
Now that I remembered to do `env G_SLICE=always-malloc`, lots more
leaks become apparent. Nothing major.
Closes: #598
Approved by: jlebon
Gbp-Pq: Name ASAN-delta-compilation-More-leak-fixes.patch
Alexander Larsson [Mon, 28 Nov 2016 16:21:59 +0000 (17:21 +0100)]
delta compilation: Fix leak
We need to ref-sik the new varian for g_autoptr to work
Closes: #597
Approved by: cgwalters
Origin: upstream, 2016.15, commit:
d57036f
Gbp-Pq: Name delta-compilation-Fix-leak.patch
Alexander Larsson [Mon, 28 Nov 2016 14:57:11 +0000 (15:57 +0100)]
pull: Don't leak delta superblock variants
Closes: #596
Approved by: cgwalters
Origin: upstream, 2016.15, commit:
36f7824
Gbp-Pq: Name pull-Don-t-leak-delta-superblock-variants.patch
Alexander Larsson [Mon, 28 Nov 2016 14:56:50 +0000 (15:56 +0100)]
pull_with_options: Don't leak csum_v
Closes: #596
Approved by: cgwalters
Origin: upstream, 2016.15, commit:
239cb14
Gbp-Pq: Name pull_with_options-Don-t-leak-csum_v.patch
Alexander Larsson [Mon, 28 Nov 2016 14:31:04 +0000 (15:31 +0100)]
ostree-repo-traverse: Don't leak floating GVariant
ostree_object_name_serialize returns a floating ref, so we need
to sink it before putting in the hashtable.
Closes: #595
Approved by: cgwalters
Origin: upstream, 2016.15, commit:
fc107e5
Gbp-Pq: Name ostree-repo-traverse-Don-t-leak-floating-GVariant.patch
Alexander Larsson [Mon, 28 Nov 2016 12:58:19 +0000 (13:58 +0100)]
pull: scan_commit_object() - don't load variant twice
ostree_repo_load_commit already loaded the object, no need
to load it twice.
Closes: #595
Approved by: cgwalters
Origin: upstream, 2016.15, commit:
c9b158e
Gbp-Pq: Name pull-scan_commit_object-don-t-load-variant-twice.patch
Jasper St. Pierre [Wed, 23 Nov 2016 21:52:39 +0000 (13:52 -0800)]
ostree-repo-traverse: Remove an accidental print statement
Closes: #594
Approved by: jlebon
Origin: upstream, 2016.15, commit:
70d140d
Gbp-Pq: Name ostree-repo-traverse-Remove-an-accidental-print-statement.patch
Simon McVittie [Thu, 1 Dec 2016 12:38:54 +0000 (12:38 +0000)]
ostree (2016.14-2) unstable; urgency=medium
* Make build-time test failures non-fatal, as long as at least
3 out of 5 attempts succeed.
There are several upstream bugs that cause intermittent test
failures, and can intermittently be reproduced in real use.
However, these are not regressions, so we should not FTBFS just
because we happen to have been unlucky during build.
* d/p/Terminate-individual-tests-after-10-minutes.patch:
replace d/p/debian/Terminate-individual-tests-after-half-an-hour.patch
with the version that I sent upstream, which uses SIGABRT and
terminates the tests sooner
* d/p/*.patch: import more memory leak fixes from upstream
[dgit import unpatched ostree 2016.14-2]
Simon McVittie [Thu, 1 Dec 2016 12:38:54 +0000 (12:38 +0000)]
Import ostree_2016.14-2.debian.tar.xz
[dgit import tarball ostree 2016.14-2 ostree_2016.14-2.debian.tar.xz]
Simon McVittie [Tue, 29 Nov 2016 11:05:44 +0000 (11:05 +0000)]
Import ostree_2016.14.orig.tar.xz
[dgit import orig ostree_2016.14.orig.tar.xz]
Simon McVittie [Fri, 9 Sep 2016 07:23:36 +0000 (08:23 +0100)]
Terminate individual tests after half an hour
While using the Automake parallel test harness, if a test hangs for
long enough for an external watchdog to kill the entire build process
(as happens in Debian sbuild after 150 minutes with no activity on
stdout/stderr), the logs will not be shown. If we make an individual
test time out sooner, logs are more likely to be shown.
Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name Terminate-individual-tests-after-half-an-hour.patch